@lwc/engine-core 2.45.4 → 2.46.0

package/dist/framework/api.d.ts

@@ -1,8 +1,8 @@
 import { SlotSet } from './vm';
 import { LightningElementConstructor } from './base-lightning-element';
-import { VNode, VNodes, VElement, VText, VCustomElement, VComment, VElementData, VStatic, Key, VFragment, VScopedSlotFragment } from './vnodes';
+import { VNode, VNodes, VElement, VText, VCustomElement, VComment, VElementData, VStatic, Key, VFragment, VScopedSlotFragment, VStaticElementData } from './vnodes';
 declare function ssf(slotName: unknown, factory: (value: any, key: any) => VFragment): VScopedSlotFragment;
-declare function st(fragment: Element, key: Key): VStatic;
+declare function st(fragment: Element, key: Key, data?: VStaticElementData): VStatic;
 declare function fr(key: Key, children: VNodes, stable: 0 | 1): VFragment;
 declare function h(sel: string, data: VElementData, children?: VNodes): VElement;
 declare function ti(value: any): number;

package/dist/framework/modules/events.d.ts

@@ -1,3 +1,3 @@
 import { RendererAPI } from '../renderer';
-import { VBaseElement } from '../vnodes';
-export declare function applyEventListeners(vnode: VBaseElement, renderer: RendererAPI): void;
+import { VBaseElement, VStatic } from '../vnodes';
+export declare function applyEventListeners(vnode: VBaseElement | VStatic, renderer: RendererAPI): void;

package/dist/framework/vnodes.d.ts

@@ -27,11 +27,13 @@ export interface VScopedSlotFragment extends BaseVNode {
     type: VNodeType.ScopedSlotFragment;
     slotName: unknown;
 }
+export type VStaticElementData = Pick<VNodeData, 'on'>;
 export interface VStatic extends BaseVNode {
-    type: VNodeType.Static;
-    sel: undefined;
-    key: Key;
-    fragment: Element;
+    readonly type: VNodeType.Static;
+    readonly sel: undefined;
+    readonly key: Key;
+    readonly fragment: Element;
+    readonly data: VStaticElementData | undefined;
 }
 export interface VFragment extends BaseVNode, BaseVParent {
     sel: undefined;

package/dist/index.cjs.js

@@ -3310,27 +3310,35 @@ function isVScopedSlotFragment(vnode) {
  * SPDX-License-Identifier: MIT
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
  */
-const ColonCharCode$1 = 58;
+const ColonCharCode = 58;
 function patchAttributes(oldVnode, vnode, renderer) {
-    const { attrs } = vnode.data;
+    const { attrs, external } = vnode.data;
     if (shared.isUndefined(attrs)) {
         return;
     }
     const oldAttrs = shared.isNull(oldVnode) ? EmptyObject : oldVnode.data.attrs;
+    // Attrs may be the same due to the static content optimization, so we can skip diffing
     if (oldAttrs === attrs) {
         return;
     }
     const { elm } = vnode;
-    const { setAttribute, removeAttribute } = renderer;
+    const { setAttribute, removeAttribute, setProperty } = renderer;
     for (const key in attrs) {
         const cur = attrs[key];
         const old = oldAttrs[key];
         if (old !== cur) {
-            if (shared.StringCharCodeAt.call(key, 3) === ColonCharCode$1) {
+            let propName;
+            // For external custom elements, sniff to see if the attr should be considered a prop.
+            // Use kebabCaseToCamelCase directly because we don't want to set props like `ariaLabel` or `tabIndex`
+            // on a custom element versus just using the more reliable attribute format.
+            if (external && (propName = shared.kebabCaseToCamelCase(key)) in elm) {
+                setProperty(elm, propName, cur);
+            }
+            else if (shared.StringCharCodeAt.call(key, 3) === ColonCharCode) {
                 // Assume xml namespace
                 setAttribute(elm, key, cur, shared.XML_NAMESPACE);
             }
-            else if (shared.StringCharCodeAt.call(key, 5) === ColonCharCode$1) {
+            else if (shared.StringCharCodeAt.call(key, 5) === ColonCharCode) {
                 // Assume xlink namespace
                 setAttribute(elm, key, cur, shared.XLINK_NAMESPACE);
             }
@@ -3344,46 +3352,6 @@ function patchAttributes(oldVnode, vnode, renderer) {
     }
 }
 
-/*
- * Copyright (c) 2018, salesforce.com, inc.
- * All rights reserved.
- * SPDX-License-Identifier: MIT
- * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
- */
-const ColonCharCode = 58;
-function patchAttrUnlessProp(oldVnode, vnode, renderer) {
-    const { data: { attrs }, elm, } = vnode;
-    if (shared.isUndefined(attrs)) {
-        return;
-    }
-    const { removeAttribute, setAttribute, setProperty } = renderer;
-    const oldAttrs = shared.isNull(oldVnode) ? EmptyObject : oldVnode.data.attrs;
-    for (const name in attrs) {
-        const cur = attrs[name];
-        const old = oldAttrs[name];
-        if (old !== cur) {
-            const propName = shared.htmlAttributeToProperty(name);
-            if (propName in elm) {
-                setProperty(elm, name, cur);
-            }
-            else if (shared.StringCharCodeAt.call(name, 3) === ColonCharCode) {
-                // Assume xml namespace
-                setAttribute(elm, name, cur, shared.XML_NAMESPACE);
-            }
-            else if (shared.StringCharCodeAt.call(name, 5) === ColonCharCode) {
-                // Assume xlink namespace
-                setAttribute(elm, name, cur, shared.XLINK_NAMESPACE);
-            }
-            else if (shared.isNull(cur) || shared.isUndefined(cur)) {
-                removeAttribute(elm, name);
-            }
-            else {
-                setAttribute(elm, name, cur);
-            }
-        }
-    }
-}
-
 /*
  * Copyright (c) 2018, salesforce.com, inc.
  * All rights reserved.
@@ -3405,6 +3373,7 @@ function patchProps(oldVnode, vnode, renderer) {
     if (!shared.isNull(oldVnode)) {
         oldProps = oldVnode.data.props;
         const oldSpread = oldVnode.data.spread;
+        // Props may be the same due to the static content optimization, so we can skip diffing
         if (oldProps === props && oldSpread === spread) {
             return;
         }
@@ -3535,7 +3504,9 @@ function patchStyleAttribute(oldVnode, vnode, renderer) {
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
  */
 function applyEventListeners(vnode, renderer) {
-    const { elm, data: { on }, } = vnode;
+    var _a;
+    const { elm } = vnode;
+    const on = (_a = vnode.data) === null || _a === void 0 ? void 0 : _a.on;
     if (shared.isUndefined(on)) {
         return;
     }
@@ -3747,6 +3718,8 @@ function mountStatic(vnode, parent, anchor, renderer) {
         }
     }
     insertNode(elm, parent, anchor, renderer);
+    // Event listeners are only applied once when mounting, so they are allowed for static vnodes
+    applyEventListeners(vnode, renderer);
 }
 function mountCustomElement(vnode, parent, anchor, renderer) {
     const { sel, owner } = vnode;
@@ -3979,12 +3952,7 @@ function patchElementPropsAndAttrs$1(oldVnode, vnode, renderer) {
     // value is set before type=radio.
     patchClassAttribute(oldVnode, vnode, renderer);
     patchStyleAttribute(oldVnode, vnode, renderer);
-    if (vnode.data.external) {
-        patchAttrUnlessProp(oldVnode, vnode, renderer);
-    }
-    else {
-        patchAttributes(oldVnode, vnode, renderer);
-    }
+    patchAttributes(oldVnode, vnode, renderer);
     patchProps(oldVnode, vnode, renderer);
 }
 function applyStyleScoping(elm, owner, renderer) {
@@ -4384,7 +4352,7 @@ function ssf(slotName, factory) {
     };
 }
 // [st]atic node
-function st(fragment, key) {
+function st(fragment, key, data) {
     return {
         type: 4 /* VNodeType.Static */,
         sel: undefined,
@@ -4392,6 +4360,7 @@ function st(fragment, key) {
         elm: undefined,
         fragment,
         owner: getVMBeingRendered(),
+        data,
     };
 }
 // [fr]agment node
@@ -4497,7 +4466,12 @@ function s(slotName, data, children, slotset) {
                     // undefined is for root components, but root components cannot accept slotted content
                     setVMBeingRendered(slotset.owner);
                     try {
-                        shared.ArrayPush.call(newChildren, vnode.factory(data.slotData, data.key));
+                        // The factory function is a template snippet from the slot set owner's template,
+                        // hence switch over to the slot set owner's template reactive observer
+                        const { tro } = slotset.owner;
+                        tro.observe(() => {
+                            shared.ArrayPush.call(newChildren, vnode.factory(data.slotData, data.key));
+                        });
                     }
                     finally {
                         setVMBeingRendered(vmBeingRenderedInception);
@@ -6293,6 +6267,7 @@ function hydrateStaticElement(elm, vnode, renderer) {
         return handleMismatch(elm, vnode, renderer);
     }
     vnode.elm = elm;
+    applyEventListeners(vnode, renderer);
     return elm;
 }
 function hydrateFragment(elm, vnode, renderer) {
@@ -6939,5 +6914,5 @@ exports.swapTemplate = swapTemplate;
 exports.track = track;
 exports.unwrap = unwrap;
 exports.wire = wire;
-/** version: 2.45.4 */
+/** version: 2.46.0 */
 //# sourceMappingURL=index.cjs.js.map