@lwc/engine-core 2.43.0 → 2.44.0

package/dist/engine-core.js

@@ -1,5 +1,5 @@
 /* proxy-compat-disable */
-import { noop, StringToLowerCase, isNull, ArrayPush as ArrayPush$1, ArrayJoin, isFrozen, isUndefined as isUndefined$1, defineProperty, ArrayIndexOf, ArraySplice, create, seal, isArray as isArray$1, isFunction as isFunction$1, keys, hasOwnProperty as hasOwnProperty$1, forEach, AriaPropNameToAttrNameMap, getPropertyDescriptor, defineProperties, getOwnPropertyNames as getOwnPropertyNames$1, getPrototypeOf as getPrototypeOf$1, setPrototypeOf, assign, isObject, assert, freeze, KEY__SYNTHETIC_MODE, toString as toString$1, getOwnPropertyDescriptor as getOwnPropertyDescriptor$1, isFalse, LWC_VERSION_COMMENT_REGEX, LWC_VERSION, htmlPropertyToAttribute, ArraySlice, ArrayMap, KEY__SCOPED_CSS, StringCharCodeAt, XML_NAMESPACE, XLINK_NAMESPACE, htmlAttributeToProperty, isString, StringSlice, isTrue, SVG_NAMESPACE, KEY__SHADOW_STATIC, KEY__SHADOW_RESOLVER, ArraySome, ArrayPop, isNumber, StringReplace, ArrayUnshift, globalThis as globalThis$1, KEY__NATIVE_GET_ELEMENT_BY_ID, KEY__NATIVE_QUERY_SELECTOR_ALL, ID_REFERENCING_ATTRIBUTES_SET, KEY__SHADOW_TOKEN, ArrayFilter, StringSplit, htmlEscape, ArrayCopyWithin, ArrayFill, ArraySort, ArrayReverse, ArrayShift } from '@lwc/shared';
+import { noop, StringToLowerCase, isNull, ArrayPush as ArrayPush$1, ArrayJoin, isFrozen, isUndefined as isUndefined$1, defineProperty, ArrayIndexOf, ArraySplice, create, seal, isArray as isArray$1, isFunction as isFunction$1, keys, hasOwnProperty as hasOwnProperty$1, forEach, AriaPropNameToAttrNameMap, getPropertyDescriptor, defineProperties, getPrototypeOf as getPrototypeOf$1, setPrototypeOf, assign, isObject, assert, freeze, KEY__SYNTHETIC_MODE, toString as toString$1, getOwnPropertyDescriptor as getOwnPropertyDescriptor$1, isFalse, LWC_VERSION_COMMENT_REGEX, LWC_VERSION, getOwnPropertyNames as getOwnPropertyNames$1, htmlPropertyToAttribute, ArraySlice, ArrayMap, KEY__SCOPED_CSS, StringCharCodeAt, XML_NAMESPACE, XLINK_NAMESPACE, htmlAttributeToProperty, isString, StringSlice, isTrue, SVG_NAMESPACE, KEY__SHADOW_STATIC, KEY__SHADOW_RESOLVER, ArraySome, ArrayPop, isNumber, StringReplace, ArrayUnshift, globalThis as globalThis$1, KEY__NATIVE_GET_ELEMENT_BY_ID, KEY__NATIVE_QUERY_SELECTOR_ALL, ID_REFERENCING_ATTRIBUTES_SET, KEY__SHADOW_TOKEN, ArrayFilter, StringSplit, ArrayCopyWithin, ArrayFill, ArraySort, ArrayReverse, ArrayShift } from '@lwc/shared';
 import { applyAriaReflection } from '@lwc/aria-reflection';
 export { setFeatureFlag, setFeatureFlagForTest } from '@lwc/features';
 
@@ -444,101 +444,6 @@ const defaultDefHTMLPropertyNames = [
     'tabIndex',
     'title',
 ];
-function offsetPropertyErrorMessage(name) {
-    return `Using the \`${name}\` property is an anti-pattern because it rounds the value to an integer. Instead, use the \`getBoundingClientRect\` method to obtain fractional values for the size of an element and its position relative to the viewport.`;
-}
-// Global HTML Attributes & Properties
-// https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes
-// https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement
-//
-// If you update this list, check for test files that recapitulate the same list. Searching the codebase
-// for e.g. "dropzone" should suffice.
-const globalHTMLProperties = {
-    accessKey: {
-        attribute: 'accesskey',
-    },
-    accessKeyLabel: {
-        readOnly: true,
-    },
-    className: {
-        attribute: 'class',
-        error: 'Using the `className` property is an anti-pattern because of slow runtime behavior and potential conflicts with classes provided by the owner element. Use the `classList` API instead.',
-    },
-    contentEditable: {
-        attribute: 'contenteditable',
-    },
-    dataset: {
-        readOnly: true,
-        error: "Using the `dataset` property is an anti-pattern because it can't be statically analyzed. Expose each property individually using the `@api` decorator instead.",
-    },
-    dir: {
-        attribute: 'dir',
-    },
-    draggable: {
-        attribute: 'draggable',
-    },
-    dropzone: {
-        attribute: 'dropzone',
-        readOnly: true,
-    },
-    hidden: {
-        attribute: 'hidden',
-    },
-    id: {
-        attribute: 'id',
-    },
-    inputMode: {
-        attribute: 'inputmode',
-    },
-    lang: {
-        attribute: 'lang',
-    },
-    slot: {
-        attribute: 'slot',
-        error: 'Using the `slot` property is an anti-pattern.',
-    },
-    spellcheck: {
-        attribute: 'spellcheck',
-    },
-    style: {
-        attribute: 'style',
-    },
-    tabIndex: {
-        attribute: 'tabindex',
-    },
-    title: {
-        attribute: 'title',
-    },
-    translate: {
-        attribute: 'translate',
-    },
-    // additional "global attributes" that are not present in the link above.
-    isContentEditable: {
-        readOnly: true,
-    },
-    offsetHeight: {
-        readOnly: true,
-        error: offsetPropertyErrorMessage('offsetHeight'),
-    },
-    offsetLeft: {
-        readOnly: true,
-        error: offsetPropertyErrorMessage('offsetLeft'),
-    },
-    offsetParent: {
-        readOnly: true,
-    },
-    offsetTop: {
-        readOnly: true,
-        error: offsetPropertyErrorMessage('offsetTop'),
-    },
-    offsetWidth: {
-        readOnly: true,
-        error: offsetPropertyErrorMessage('offsetWidth'),
-    },
-    role: {
-        attribute: 'role',
-    },
-};
 let controlledElement = null;
 let controlledAttributeName;
 function isAttributeLocked(elm, attrName) {
@@ -723,8 +628,7 @@ function getShadowRootRestrictionsDescriptors(sr) {
         }),
         addEventListener: generateDataDescriptor({
             value(type, listener, options) {
-                // TODO [#420]: this is triggered when the component author attempts to add a listener
-                // programmatically into its Component's shadow root
+                // TODO [#1824]: Potentially relax this restriction
                 if (!isUndefined$1(options)) {
                     logError('The `addEventListener` method on ShadowRoot does not support any options.', getAssociatedVMIfPresent(this));
                 }
@@ -770,8 +674,7 @@ function getCustomElementRestrictionsDescriptors(elm) {
         }),
         addEventListener: generateDataDescriptor({
             value(type, listener, options) {
-                // TODO [#420]: this is triggered when the component author attempts to add a listener
-                // programmatically into a lighting element node
+                // TODO [#1824]: Potentially relax this restriction
                 if (!isUndefined$1(options)) {
                     logError('The `addEventListener` method in `LightningElement` does not support any options.', getAssociatedVMIfPresent(this));
                 }
@@ -799,7 +702,7 @@ function getComponentRestrictionsDescriptors() {
 function getLightningElementPrototypeRestrictionsDescriptors(proto) {
     assertNotProd(); // this method should never leak to prod
     const originalDispatchEvent = proto.dispatchEvent;
-    const descriptors = {
+    return {
         dispatchEvent: generateDataDescriptor({
             value(event) {
                 const vm = getAssociatedVM(this);
@@ -817,32 +720,6 @@ function getLightningElementPrototypeRestrictionsDescriptors(proto) {
             },
         }),
     };
-    forEach.call(getOwnPropertyNames$1(globalHTMLProperties), (propName) => {
-        if (propName in proto) {
-            return; // no need to redefine something that we are already exposing
-        }
-        descriptors[propName] = generateAccessorDescriptor({
-            get() {
-                const { error, attribute } = globalHTMLProperties[propName];
-                const msg = [];
-                msg.push(`Accessing the global HTML property "${propName}" is disabled.`);
-                if (error) {
-                    msg.push(error);
-                }
-                else if (attribute) {
-                    msg.push(`Instead access it via \`this.getAttribute("${attribute}")\`.`);
-                }
-                logError(msg.join('\n'), getAssociatedVM(this));
-            },
-            set() {
-                const { readOnly } = globalHTMLProperties[propName];
-                if (readOnly) {
-                    logError(`The global HTML property \`${propName}\` is read-only.`, getAssociatedVM(this));
-                }
-            },
-        });
-    });
-    return descriptors;
 }
 // This routine will prevent access to certain properties on a shadow root instance to guarantee
 // that all components will work fine in IE11 and other browsers without shadow dom support.
@@ -2193,12 +2070,7 @@ function createPublicPropertyDescriptor(key) {
 }
 function createPublicAccessorDescriptor(key, descriptor) {
     const { get, set, enumerable, configurable } = descriptor;
-    if (!isFunction$1(get)) {
-        if (process.env.NODE_ENV !== 'production') {
-            assert.invariant(isFunction$1(get), `Invalid compiler output for public accessor ${toString$1(key)} decorated with @api`);
-        }
-        throw new Error();
-    }
+    assert.invariant(isFunction$1(get), `Invalid public accessor ${toString$1(key)} decorated with @api. The property is missing a getter.`);
     return {
         get() {
             if (process.env.NODE_ENV !== 'production') {
@@ -2320,64 +2192,64 @@ function getClassDescriptorType(descriptor) {
     }
 }
 function validateObservedField(Ctor, fieldName, descriptor) {
+    assertNotProd(); // this method should never leak to prod
     if (!isUndefined$1(descriptor)) {
         const type = getClassDescriptorType(descriptor);
         const message = `Invalid observed ${fieldName} field. Found a duplicate ${type} with the same name.`;
-        // [W-9927596] Ideally we always throw an error when detecting duplicate observed field.
-        // This branch is only here for backward compatibility reasons.
-        if (type === "accessor" /* DescriptorType.Accessor */) {
-            logError(message);
-        }
-        else {
-            assert.fail(message);
-        }
+        // TODO [#3408]: this should throw, not log
+        logError(message);
     }
 }
 function validateFieldDecoratedWithTrack(Ctor, fieldName, descriptor) {
+    assertNotProd(); // this method should never leak to prod
     if (!isUndefined$1(descriptor)) {
         const type = getClassDescriptorType(descriptor);
-        assert.fail(`Invalid @track ${fieldName} field. Found a duplicate ${type} with the same name.`);
+        // TODO [#3408]: this should throw, not log
+        logError(`Invalid @track ${fieldName} field. Found a duplicate ${type} with the same name.`);
     }
 }
 function validateFieldDecoratedWithWire(Ctor, fieldName, descriptor) {
+    assertNotProd(); // this method should never leak to prod
     if (!isUndefined$1(descriptor)) {
         const type = getClassDescriptorType(descriptor);
-        assert.fail(`Invalid @wire ${fieldName} field. Found a duplicate ${type} with the same name.`);
+        // TODO [#3408]: this should throw, not log
+        logError(`Invalid @wire ${fieldName} field. Found a duplicate ${type} with the same name.`);
     }
 }
 function validateMethodDecoratedWithWire(Ctor, methodName, descriptor) {
+    assertNotProd(); // this method should never leak to prod
     if (isUndefined$1(descriptor) || !isFunction$1(descriptor.value) || isFalse(descriptor.writable)) {
-        assert.fail(`Invalid @wire ${methodName} method.`);
+        // TODO [#3441]: This line of code does not seem possible to reach.
+        logError(`Invalid @wire ${methodName} field. The field should have a valid writable descriptor.`);
     }
 }
 function validateFieldDecoratedWithApi(Ctor, fieldName, descriptor) {
+    assertNotProd(); // this method should never leak to prod
     if (!isUndefined$1(descriptor)) {
         const type = getClassDescriptorType(descriptor);
         const message = `Invalid @api ${fieldName} field. Found a duplicate ${type} with the same name.`;
-        // [W-9927596] Ideally we always throw an error when detecting duplicate public properties.
-        // This branch is only here for backward compatibility reasons.
-        if (type === "accessor" /* DescriptorType.Accessor */) {
-            logError(message);
-        }
-        else {
-            assert.fail(message);
-        }
+        // TODO [#3408]: this should throw, not log
+        logError(message);
     }
 }
 function validateAccessorDecoratedWithApi(Ctor, fieldName, descriptor) {
-    if (isUndefined$1(descriptor)) {
-        assert.fail(`Invalid @api get ${fieldName} accessor.`);
-    }
-    else if (isFunction$1(descriptor.set)) {
-        assert.isTrue(isFunction$1(descriptor.get), `Missing getter for property ${fieldName} decorated with @api in ${Ctor}. You cannot have a setter without the corresponding getter.`);
+    assertNotProd(); // this method should never leak to prod
+    if (isFunction$1(descriptor.set)) {
+        if (!isFunction$1(descriptor.get)) {
+            // TODO [#3441]: This line of code does not seem possible to reach.
+            logError(`Missing getter for property ${fieldName} decorated with @api in ${Ctor}. You cannot have a setter without the corresponding getter.`);
+        }
     }
     else if (!isFunction$1(descriptor.get)) {
-        assert.fail(`Missing @api get ${fieldName} accessor.`);
+        // TODO [#3441]: This line of code does not seem possible to reach.
+        logError(`Missing @api get ${fieldName} accessor.`);
     }
 }
 function validateMethodDecoratedWithApi(Ctor, methodName, descriptor) {
+    assertNotProd(); // this method should never leak to prod
     if (isUndefined$1(descriptor) || !isFunction$1(descriptor.value) || isFalse(descriptor.writable)) {
-        assert.fail(`Invalid @api ${methodName} method.`);
+        // TODO [#3441]: This line of code does not seem possible to reach.
+        logError(`Invalid @api ${methodName} method.`);
     }
 }
 /**
@@ -2400,13 +2272,14 @@ function registerDecorators(Ctor, meta) {
             apiFieldsConfig[fieldName] = propConfig.config;
             descriptor = getOwnPropertyDescriptor$1(proto, fieldName);
             if (propConfig.config > 0) {
+                if (isUndefined$1(descriptor)) {
+                    // TODO [#3441]: This line of code does not seem possible to reach.
+                    throw new Error();
+                }
                 // accessor declaration
                 if (process.env.NODE_ENV !== 'production') {
                     validateAccessorDecoratedWithApi(Ctor, fieldName, descriptor);
                 }
-                if (isUndefined$1(descriptor)) {
-                    throw new Error();
-                }
                 descriptor = createPublicAccessorDescriptor(fieldName, descriptor);
             }
             else {
@@ -2446,7 +2319,10 @@ function registerDecorators(Ctor, meta) {
             descriptor = getOwnPropertyDescriptor$1(proto, fieldOrMethodName);
             if (method === 1) {
                 if (process.env.NODE_ENV !== 'production') {
-                    assert.isTrue(adapter, `@wire on method "${fieldOrMethodName}": adapter id must be truthy.`);
+                    if (!adapter) {
+                        // TODO [#3408]: this should throw, not log
+                        logError(`@wire on method "${fieldOrMethodName}": adapter id must be truthy.`);
+                    }
                     validateMethodDecoratedWithWire(Ctor, fieldOrMethodName, descriptor);
                 }
                 if (isUndefined$1(descriptor)) {
@@ -2457,7 +2333,10 @@ function registerDecorators(Ctor, meta) {
             }
             else {
                 if (process.env.NODE_ENV !== 'production') {
-                    assert.isTrue(adapter, `@wire on field "${fieldOrMethodName}": adapter id must be truthy.`);
+                    if (!adapter) {
+                        // TODO [#3408]: this should throw, not log
+                        logError(`@wire on field "${fieldOrMethodName}": adapter id must be truthy.`);
+                    }
                     validateFieldDecoratedWithWire(Ctor, fieldOrMethodName, descriptor);
                 }
                 descriptor = internalWireFieldDecorator(fieldOrMethodName);
@@ -6340,8 +6219,6 @@ function hydrateNode(node, vnode, renderer) {
     return renderer.nextSibling(hydratedNode);
 }
 const NODE_VALUE_PROP = 'nodeValue';
-const PARENT_NODE_PROP = 'parentNode';
-const TAG_NAME_PROP = 'tagName';
 function textNodeContentsAreEqual(node, vnode, renderer) {
     const { getProperty } = renderer;
     const nodeValue = getProperty(node, NODE_VALUE_PROP);
@@ -6353,22 +6230,6 @@ function textNodeContentsAreEqual(node, vnode, renderer) {
     if (nodeValue === '\u200D' && vnode.text === '') {
         return true;
     }
-    // Special case for text nodes inside `<style>` tags – these are escaped when rendered server-size,
-    // but not when generated by the engine client-side.
-    const parentNode = getProperty(node, PARENT_NODE_PROP);
-    // Should never be null, but just to be safe, we check.
-    /* istanbul ignore else */
-    if (!isNull(parentNode)) {
-        const tagName = getProperty(parentNode, TAG_NAME_PROP);
-        // If the tagName is STYLE, then the following condition should always be true.
-        // The LWC compiler blocks using `<style>`s inside of templates, so it should be impossible
-        // for component authors to render different `<style>` text content on the client and server.
-        // But just to be safe, we check.
-        /* istanbul ignore next */
-        if (tagName === 'STYLE' && htmlEscape(vnode.text) === nodeValue) {
-            return true;
-        }
-    }
     return false;
 }
 function hydrateText(node, vnode, renderer) {
@@ -6994,12 +6855,12 @@ function readonly(obj) {
     if (process.env.NODE_ENV !== 'production') {
         // TODO [#1292]: Remove the readonly decorator
         if (arguments.length !== 1) {
-            assert.fail('@readonly cannot be used as a decorator just yet, use it as a function with one argument to produce a readonly version of the provided value.');
+            logError('@readonly cannot be used as a decorator just yet, use it as a function with one argument to produce a readonly version of the provided value.');
         }
     }
     return getReadOnlyProxy(obj);
 }
 
 export { LightningElement, profilerControl as __unstable__ProfilerControl, reportingControl as __unstable__ReportingControl, api$1 as api, connectRootElement, createContextProviderWithRegister, createVM, disconnectRootElement, freezeTemplate, getAssociatedVMIfPresent, getComponentConstructor, getComponentDef, getComponentHtmlPrototype, hydrateRoot, isComponentConstructor, parseFragment, parseSVGFragment, readonly, register, registerComponent, registerDecorators, registerStylesheet, registerTemplate, sanitizeAttribute, setHooks, swapComponent, swapStyle, swapTemplate, track, unwrap, wire };
-/* version: 2.43.0 */
+/* version: 2.44.0 */
 //# sourceMappingURL=engine-core.js.map