@lwc/engine-core 2.30.2 → 2.31.0

package/dist/engine-core.cjs.js

@@ -3158,7 +3158,7 @@ function isVScopedSlotFragment(vnode) {
  * SPDX-License-Identifier: MIT
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
  */
-const ColonCharCode = 58;
+const ColonCharCode$1 = 58;
 function patchAttributes(oldVnode, vnode, renderer) {
     const { attrs } = vnode.data;
     if (shared.isUndefined(attrs)) {
@@ -3175,11 +3175,11 @@ function patchAttributes(oldVnode, vnode, renderer) {
         const old = oldAttrs[key];
         if (old !== cur) {
             unlockAttribute(elm, key);
-            if (shared.StringCharCodeAt.call(key, 3) === ColonCharCode) {
+            if (shared.StringCharCodeAt.call(key, 3) === ColonCharCode$1) {
                 // Assume xml namespace
                 setAttribute(elm, key, cur, shared.XML_NAMESPACE);
             }
-            else if (shared.StringCharCodeAt.call(key, 5) === ColonCharCode) {
+            else if (shared.StringCharCodeAt.call(key, 5) === ColonCharCode$1) {
                 // Assume xlink namespace
                 setAttribute(elm, key, cur, shared.XLINK_NAMESPACE);
             }
@@ -3194,6 +3194,46 @@ function patchAttributes(oldVnode, vnode, renderer) {
     }
 }
 
+/*
+ * Copyright (c) 2018, salesforce.com, inc.
+ * All rights reserved.
+ * SPDX-License-Identifier: MIT
+ * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
+ */
+const ColonCharCode = 58;
+function patchAttrUnlessProp(oldVnode, vnode, renderer) {
+    const { data: { attrs }, elm, } = vnode;
+    if (shared.isUndefined(attrs)) {
+        return;
+    }
+    const { removeAttribute, setAttribute, setProperty } = renderer;
+    const oldAttrs = shared.isNull(oldVnode) ? EmptyObject : oldVnode.data.attrs;
+    for (const name in attrs) {
+        const cur = attrs[name];
+        const old = oldAttrs[name];
+        if (old !== cur) {
+            const propName = shared.htmlAttributeToProperty(name);
+            if (propName in elm) {
+                setProperty(elm, name, cur);
+            }
+            else if (shared.StringCharCodeAt.call(name, 3) === ColonCharCode) {
+                // Assume xml namespace
+                setAttribute(elm, name, cur, shared.XML_NAMESPACE);
+            }
+            else if (shared.StringCharCodeAt.call(name, 5) === ColonCharCode) {
+                // Assume xlink namespace
+                setAttribute(elm, name, cur, shared.XLINK_NAMESPACE);
+            }
+            else if (shared.isNull(cur) || shared.isUndefined(cur)) {
+                removeAttribute(elm, name);
+            }
+            else {
+                setAttribute(elm, name, cur);
+            }
+        }
+    }
+}
+
 /*
  * Copyright (c) 2018, salesforce.com, inc.
  * All rights reserved.
@@ -3794,7 +3834,11 @@ function patchElementPropsAndAttrs$1(oldVnode, vnode, renderer) {
   // value is set before type=radio.
   patchClassAttribute(oldVnode, vnode, renderer);
   patchStyleAttribute(oldVnode, vnode, renderer);
-  patchAttributes(oldVnode, vnode, renderer);
+  if (vnode.data.external) {
+    patchAttrUnlessProp(oldVnode, vnode, renderer);
+  } else {
+    patchAttributes(oldVnode, vnode, renderer);
+  }
   patchProps(oldVnode, vnode, renderer);
 }
 function applyStyleScoping(elm, owner, renderer) {
@@ -4227,8 +4271,11 @@ function s(slotName, data, children, slotset) {
         !shared.isUndefined(slotset.slotAssignments) &&
         !shared.isUndefined(slotset.slotAssignments[slotName]) &&
         slotset.slotAssignments[slotName].length !== 0) {
-        children = slotset.slotAssignments[slotName].reduce((accumulator, vnode) => {
-            if (vnode) {
+        const newChildren = [];
+        const slotAssignments = slotset.slotAssignments[slotName];
+        for (let i = 0; i < slotAssignments.length; i++) {
+            const vnode = slotAssignments[i];
+            if (!shared.isNull(vnode)) {
                 const assignedNodeIsScopedSlot = isVScopedSlotFragment(vnode);
                 // The only sniff test for a scoped <slot> element is the presence of `slotData`
                 const isScopedSlotElement = !shared.isUndefined(data.slotData);
@@ -4238,32 +4285,30 @@ function s(slotName, data, children, slotset) {
                         logError(`Mismatched slot types for ${slotName === '' ? '(default)' : slotName} slot. Both parent and child component must use standard type or scoped type for a given slot.`, slotset.owner);
                     }
                     // Ignore slot content from parent
-                    return accumulator;
+                    continue;
                 }
                 // If the passed slot content is factory, evaluate it and add the produced vnodes
                 if (assignedNodeIsScopedSlot) {
                     const vmBeingRenderedInception = getVMBeingRendered();
-                    let scopedSlotChildren = [];
                     // Evaluate in the scope of the slot content's owner
                     // if a slotset is provided, there will always be an owner. The only case where owner is
                     // undefined is for root components, but root components cannot accept slotted content
                     setVMBeingRendered(slotset.owner);
                     try {
-                        scopedSlotChildren = vnode.factory(data.slotData);
+                        shared.ArrayPush.apply(newChildren, vnode.factory(data.slotData));
                     }
                     finally {
                         setVMBeingRendered(vmBeingRenderedInception);
                     }
-                    return shared.ArrayConcat.call(accumulator, scopedSlotChildren);
                 }
                 else {
                     // If the slot content is standard type, the content is static, no additional
                     // processing needed on the vnode
-                    return shared.ArrayConcat.call(accumulator, vnode);
+                    shared.ArrayPush.call(newChildren, vnode);
                 }
             }
-            return accumulator;
-        }, []);
+        }
+        children = newChildren;
     }
     const vmBeingRendered = getVMBeingRendered();
     const { renderMode, shadowMode } = vmBeingRendered;
@@ -6525,4 +6570,4 @@ exports.swapTemplate = swapTemplate;
 exports.track = track;
 exports.unwrap = unwrap;
 exports.wire = wire;
-/* version: 2.30.2 */
+/* version: 2.31.0 */

package/dist/engine-core.js

@@ -1,7 +1,7 @@
 /* proxy-compat-disable */
 import { lwcRuntimeFlags } from '@lwc/features';
 export { setFeatureFlag, setFeatureFlagForTest } from '@lwc/features';
-import { seal, create, isUndefined as isUndefined$1, isFunction as isFunction$1, ArrayPush as ArrayPush$1, ArrayIndexOf, ArraySplice, StringToLowerCase, isNull, ArrayJoin, isFrozen, defineProperty, hasOwnProperty as hasOwnProperty$1, assign, forEach, keys, AriaPropNameToAttrNameMap, getPropertyDescriptor, defineProperties, getOwnPropertyNames as getOwnPropertyNames$1, getPrototypeOf as getPrototypeOf$1, setPrototypeOf, isObject, freeze, assert, KEY__SYNTHETIC_MODE, isFalse, isTrue, toString as toString$1, getOwnPropertyDescriptor as getOwnPropertyDescriptor$1, LWC_VERSION_COMMENT_REGEX, LWC_VERSION, htmlPropertyToAttribute, ArraySlice, ArrayMap, isArray as isArray$1, KEY__SCOPED_CSS, StringCharCodeAt, XML_NAMESPACE, XLINK_NAMESPACE, isString, StringSlice, SVG_NAMESPACE, KEY__SHADOW_STATIC, KEY__SHADOW_RESOLVER, ArraySome, ArrayConcat as ArrayConcat$1, isNumber, StringReplace, noop, ArrayUnshift, ArrayFilter, ArrayCopyWithin, ArrayFill, ArraySort, ArrayReverse, ArrayShift, ArrayPop } from '@lwc/shared';
+import { seal, create, isUndefined as isUndefined$1, isFunction as isFunction$1, ArrayPush as ArrayPush$1, ArrayIndexOf, ArraySplice, StringToLowerCase, isNull, ArrayJoin, isFrozen, defineProperty, hasOwnProperty as hasOwnProperty$1, assign, forEach, keys, AriaPropNameToAttrNameMap, getPropertyDescriptor, defineProperties, getOwnPropertyNames as getOwnPropertyNames$1, getPrototypeOf as getPrototypeOf$1, setPrototypeOf, isObject, freeze, assert, KEY__SYNTHETIC_MODE, isFalse, isTrue, toString as toString$1, getOwnPropertyDescriptor as getOwnPropertyDescriptor$1, LWC_VERSION_COMMENT_REGEX, LWC_VERSION, htmlPropertyToAttribute, ArraySlice, ArrayMap, isArray as isArray$1, KEY__SCOPED_CSS, StringCharCodeAt, XML_NAMESPACE, XLINK_NAMESPACE, htmlAttributeToProperty, isString, StringSlice, SVG_NAMESPACE, KEY__SHADOW_STATIC, KEY__SHADOW_RESOLVER, ArraySome, isNumber, StringReplace, noop, ArrayUnshift, ArrayFilter, ArrayCopyWithin, ArrayFill, ArraySort, ArrayReverse, ArrayShift, ArrayPop } from '@lwc/shared';
 
 /*
  * Copyright (c) 2018, salesforce.com, inc.
@@ -3157,7 +3157,7 @@ function isVScopedSlotFragment(vnode) {
  * SPDX-License-Identifier: MIT
  * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
  */
-const ColonCharCode = 58;
+const ColonCharCode$1 = 58;
 function patchAttributes(oldVnode, vnode, renderer) {
     const { attrs } = vnode.data;
     if (isUndefined$1(attrs)) {
@@ -3174,11 +3174,11 @@ function patchAttributes(oldVnode, vnode, renderer) {
         const old = oldAttrs[key];
         if (old !== cur) {
             unlockAttribute(elm, key);
-            if (StringCharCodeAt.call(key, 3) === ColonCharCode) {
+            if (StringCharCodeAt.call(key, 3) === ColonCharCode$1) {
                 // Assume xml namespace
                 setAttribute(elm, key, cur, XML_NAMESPACE);
             }
-            else if (StringCharCodeAt.call(key, 5) === ColonCharCode) {
+            else if (StringCharCodeAt.call(key, 5) === ColonCharCode$1) {
                 // Assume xlink namespace
                 setAttribute(elm, key, cur, XLINK_NAMESPACE);
             }
@@ -3193,6 +3193,46 @@ function patchAttributes(oldVnode, vnode, renderer) {
     }
 }
 
+/*
+ * Copyright (c) 2018, salesforce.com, inc.
+ * All rights reserved.
+ * SPDX-License-Identifier: MIT
+ * For full license text, see the LICENSE file in the repo root or https://opensource.org/licenses/MIT
+ */
+const ColonCharCode = 58;
+function patchAttrUnlessProp(oldVnode, vnode, renderer) {
+    const { data: { attrs }, elm, } = vnode;
+    if (isUndefined$1(attrs)) {
+        return;
+    }
+    const { removeAttribute, setAttribute, setProperty } = renderer;
+    const oldAttrs = isNull(oldVnode) ? EmptyObject : oldVnode.data.attrs;
+    for (const name in attrs) {
+        const cur = attrs[name];
+        const old = oldAttrs[name];
+        if (old !== cur) {
+            const propName = htmlAttributeToProperty(name);
+            if (propName in elm) {
+                setProperty(elm, name, cur);
+            }
+            else if (StringCharCodeAt.call(name, 3) === ColonCharCode) {
+                // Assume xml namespace
+                setAttribute(elm, name, cur, XML_NAMESPACE);
+            }
+            else if (StringCharCodeAt.call(name, 5) === ColonCharCode) {
+                // Assume xlink namespace
+                setAttribute(elm, name, cur, XLINK_NAMESPACE);
+            }
+            else if (isNull(cur) || isUndefined$1(cur)) {
+                removeAttribute(elm, name);
+            }
+            else {
+                setAttribute(elm, name, cur);
+            }
+        }
+    }
+}
+
 /*
  * Copyright (c) 2018, salesforce.com, inc.
  * All rights reserved.
@@ -3793,7 +3833,11 @@ function patchElementPropsAndAttrs$1(oldVnode, vnode, renderer) {
   // value is set before type=radio.
   patchClassAttribute(oldVnode, vnode, renderer);
   patchStyleAttribute(oldVnode, vnode, renderer);
-  patchAttributes(oldVnode, vnode, renderer);
+  if (vnode.data.external) {
+    patchAttrUnlessProp(oldVnode, vnode, renderer);
+  } else {
+    patchAttributes(oldVnode, vnode, renderer);
+  }
   patchProps(oldVnode, vnode, renderer);
 }
 function applyStyleScoping(elm, owner, renderer) {
@@ -4226,8 +4270,11 @@ function s(slotName, data, children, slotset) {
         !isUndefined$1(slotset.slotAssignments) &&
         !isUndefined$1(slotset.slotAssignments[slotName]) &&
         slotset.slotAssignments[slotName].length !== 0) {
-        children = slotset.slotAssignments[slotName].reduce((accumulator, vnode) => {
-            if (vnode) {
+        const newChildren = [];
+        const slotAssignments = slotset.slotAssignments[slotName];
+        for (let i = 0; i < slotAssignments.length; i++) {
+            const vnode = slotAssignments[i];
+            if (!isNull(vnode)) {
                 const assignedNodeIsScopedSlot = isVScopedSlotFragment(vnode);
                 // The only sniff test for a scoped <slot> element is the presence of `slotData`
                 const isScopedSlotElement = !isUndefined$1(data.slotData);
@@ -4237,32 +4284,30 @@ function s(slotName, data, children, slotset) {
                         logError(`Mismatched slot types for ${slotName === '' ? '(default)' : slotName} slot. Both parent and child component must use standard type or scoped type for a given slot.`, slotset.owner);
                     }
                     // Ignore slot content from parent
-                    return accumulator;
+                    continue;
                 }
                 // If the passed slot content is factory, evaluate it and add the produced vnodes
                 if (assignedNodeIsScopedSlot) {
                     const vmBeingRenderedInception = getVMBeingRendered();
-                    let scopedSlotChildren = [];
                     // Evaluate in the scope of the slot content's owner
                     // if a slotset is provided, there will always be an owner. The only case where owner is
                     // undefined is for root components, but root components cannot accept slotted content
                     setVMBeingRendered(slotset.owner);
                     try {
-                        scopedSlotChildren = vnode.factory(data.slotData);
+                        ArrayPush$1.apply(newChildren, vnode.factory(data.slotData));
                     }
                     finally {
                         setVMBeingRendered(vmBeingRenderedInception);
                     }
-                    return ArrayConcat$1.call(accumulator, scopedSlotChildren);
                 }
                 else {
                     // If the slot content is standard type, the content is static, no additional
                     // processing needed on the vnode
-                    return ArrayConcat$1.call(accumulator, vnode);
+                    ArrayPush$1.call(newChildren, vnode);
                 }
             }
-            return accumulator;
-        }, []);
+        }
+        children = newChildren;
     }
     const vmBeingRendered = getVMBeingRendered();
     const { renderMode, shadowMode } = vmBeingRendered;
@@ -6488,4 +6533,4 @@ function getComponentConstructor(elm) {
 }
 
 export { LightningElement, profilerControl as __unstable__ProfilerControl, api$1 as api, connectRootElement, createContextProvider, createVM, disconnectRootElement, freezeTemplate, getAssociatedVMIfPresent, getComponentConstructor, getComponentDef, getComponentHtmlPrototype, hydrateRoot, isComponentConstructor, parseFragment, parseSVGFragment, readonly, register, registerComponent, registerDecorators, registerTemplate, sanitizeAttribute, setHooks, swapComponent, swapStyle, swapTemplate, track, unwrap, wire };
-/* version: 2.30.2 */
+/* version: 2.31.0 */

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@lwc/engine-core",
-    "version": "2.30.2",
+    "version": "2.31.0",
     "description": "Core LWC engine APIs.",
     "homepage": "https://lwc.dev/",
     "repository": {
@@ -24,8 +24,8 @@
         "types/"
     ],
     "dependencies": {
-        "@lwc/features": "2.30.2",
-        "@lwc/shared": "2.30.2"
+        "@lwc/features": "2.31.0",
+        "@lwc/shared": "2.31.0"
     },
     "devDependencies": {
         "observable-membrane": "2.0.0"

package/types/framework/modules/attr-unless-prop.d.ts

@@ -0,0 +1,3 @@
+import { RendererAPI } from '../renderer';
+import { VBaseElement } from '../vnodes';
+export declare function patchAttrUnlessProp(oldVnode: VBaseElement | null, vnode: VBaseElement, renderer: RendererAPI): void;

package/types/framework/vnodes.d.ts

@@ -11,7 +11,6 @@ export declare const enum VNodeType {
     ScopedSlotFragment = 6
 }
 export declare type VNode = VText | VComment | VElement | VCustomElement | VStatic | VFragment | VScopedSlotFragment;
-export declare type VParentElement = VElement | VCustomElement | VFragment;
 export declare type VNodes = Readonly<Array<VNode | null>>;
 export interface BaseVParent {
     children: VNodes;
@@ -82,6 +81,7 @@ export interface VNodeData {
 }
 export interface VElementData extends VNodeData {
     readonly key: Key;
+    readonly external?: boolean;
     readonly ref?: string;
     readonly slotData?: any;
 }