@lvlup-sw/exarchos 2.4.3 → 2.6.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.claude-plugin/plugin.json +7 -2
- package/AGENTS.md +2 -2
- package/README.md +91 -57
- package/agents/.gitkeep +0 -0
- package/agents/fixer.md +62 -0
- package/agents/implementer.md +68 -0
- package/agents/reviewer.md +50 -0
- package/commands/dogfood.md +31 -0
- package/commands/ideate.md +1 -1
- package/commands/oneshot.md +178 -0
- package/commands/plan.md +1 -1
- package/commands/prune.md +90 -0
- package/commands/review.md +58 -0
- package/dist/exarchos.js +582 -142
- package/hooks/hooks.json +8 -0
- package/package.json +18 -6
- package/scripts/sync-versions.sh +31 -22
- package/skills/{brainstorming → claude/brainstorming}/SKILL.md +16 -0
- package/skills/{brainstorming → claude/brainstorming}/references/design-template.md +9 -0
- package/skills/{cleanup → claude/cleanup}/SKILL.md +6 -0
- package/skills/{debug → claude/debug}/SKILL.md +41 -0
- package/skills/{debug → claude/debug}/references/hotfix-track.md +12 -49
- package/skills/{debug → claude/debug}/references/investigation-checklist.md +3 -3
- package/skills/{debug → claude/debug}/references/thorough-track.md +12 -42
- package/skills/{delegation → claude/delegation}/SKILL.md +128 -40
- package/skills/{delegation → claude/delegation}/references/agent-teams-saga.md +4 -1
- package/skills/claude/delegation/references/fix-mode.md +118 -0
- package/skills/{delegation → claude/delegation}/references/implementer-prompt.md +29 -1
- package/skills/{delegation → claude/delegation}/references/parallel-strategy.md +1 -1
- package/skills/{delegation → claude/delegation}/references/state-management.md +33 -0
- package/skills/{delegation → claude/delegation}/references/troubleshooting.md +2 -2
- package/skills/{delegation → claude/delegation}/references/workflow-steps.md +6 -10
- package/skills/{delegation → claude/delegation}/references/worktree-enforcement.md +13 -7
- package/skills/claude/dogfood/SKILL.md +235 -0
- package/skills/claude/dogfood/references/report-template.md +109 -0
- package/skills/claude/dogfood/references/root-cause-patterns.md +227 -0
- package/skills/{git-worktrees → claude/git-worktrees}/SKILL.md +6 -9
- package/skills/{implementation-planning → claude/implementation-planning}/SKILL.md +32 -27
- package/skills/claude/implementation-planning/references/task-template.md +63 -0
- package/skills/{implementation-planning → claude/implementation-planning}/references/testing-strategy-guide.md +22 -1
- package/skills/{implementation-planning → claude/implementation-planning}/references/worked-example.md +2 -2
- package/skills/claude/oneshot-workflow/SKILL.md +468 -0
- package/skills/claude/oneshot-workflow/references/choice-state.md +65 -0
- package/skills/claude/prune-workflows/SKILL.md +290 -0
- package/skills/claude/prune-workflows/references/safeguards.md +74 -0
- package/skills/{quality-review → claude/quality-review}/SKILL.md +105 -10
- package/skills/{quality-review → claude/quality-review}/references/auto-transition.md +1 -1
- package/skills/claude/quality-review/references/axiom-integration.md +135 -0
- package/skills/{refactor → claude/refactor}/SKILL.md +32 -39
- package/skills/{refactor → claude/refactor}/references/doc-update-checklist.md +2 -3
- package/skills/{refactor → claude/refactor}/references/explore-checklist.md +4 -6
- package/skills/{refactor → claude/refactor}/references/overhaul-track.md +20 -50
- package/skills/{refactor → claude/refactor/references}/phases/polish-implement.md +2 -2
- package/skills/{refactor → claude/refactor/references}/phases/polish-validate.md +1 -1
- package/skills/{refactor → claude/refactor}/references/polish-track.md +18 -46
- package/skills/{shepherd → claude/shepherd}/SKILL.md +42 -10
- package/skills/{shepherd → claude/shepherd}/references/fix-strategies.md +1 -2
- package/skills/claude/shepherd/references/shepherd-event-schemas.md +56 -0
- package/skills/{spec-review → claude/spec-review}/SKILL.md +48 -10
- package/skills/{spec-review → claude/spec-review}/references/worked-example.md +1 -1
- package/skills/{synthesis → claude/synthesis}/SKILL.md +72 -10
- package/skills/{synthesis → claude/synthesis}/references/github-native-stacking.md +3 -4
- package/skills/{synthesis → claude/synthesis}/references/synthesis-steps.md +11 -13
- package/skills/{workflow-state → claude/workflow-state}/SKILL.md +50 -6
- package/skills/{workflow-state → claude/workflow-state}/references/mcp-tool-reference.md +5 -5
- package/skills/{workflow-state → claude/workflow-state}/references/phase-transitions.md +28 -3
- package/skills/codex/brainstorming/SKILL.md +182 -0
- package/skills/codex/brainstorming/references/design-template.md +107 -0
- package/skills/codex/brainstorming/references/worked-example.md +58 -0
- package/skills/codex/cleanup/SKILL.md +169 -0
- package/skills/codex/cleanup/references/merge-verification.md +40 -0
- package/skills/codex/debug/SKILL.md +247 -0
- package/skills/codex/debug/references/hotfix-track.md +105 -0
- package/skills/codex/debug/references/investigation-checklist.md +217 -0
- package/skills/codex/debug/references/rca-template.md +150 -0
- package/skills/codex/debug/references/state-schema.md +294 -0
- package/skills/codex/debug/references/thorough-track.md +171 -0
- package/skills/codex/debug/references/triage-questions.md +155 -0
- package/skills/codex/debug/references/troubleshooting.md +47 -0
- package/skills/codex/delegation/SKILL.md +353 -0
- package/skills/codex/delegation/references/adaptive-orchestration.md +31 -0
- package/skills/codex/delegation/references/agent-teams-saga.md +254 -0
- package/skills/codex/delegation/references/fix-mode.md +118 -0
- package/skills/codex/delegation/references/fixer-prompt.md +174 -0
- package/skills/codex/delegation/references/implementer-prompt.md +401 -0
- package/skills/codex/delegation/references/parallel-strategy.md +124 -0
- package/skills/codex/delegation/references/pbt-patterns.md +172 -0
- package/skills/codex/delegation/references/pr-fixes-mode.md +155 -0
- package/skills/codex/delegation/references/rationalization-refutation.md +15 -0
- package/skills/codex/delegation/references/state-management.md +84 -0
- package/skills/codex/delegation/references/testing-patterns.md +146 -0
- package/skills/codex/delegation/references/troubleshooting.md +109 -0
- package/skills/codex/delegation/references/worked-example.md +104 -0
- package/skills/codex/delegation/references/workflow-steps.md +131 -0
- package/skills/codex/delegation/references/worktree-enforcement.md +71 -0
- package/skills/codex/dogfood/SKILL.md +235 -0
- package/skills/codex/dogfood/references/report-template.md +109 -0
- package/skills/codex/dogfood/references/root-cause-patterns.md +227 -0
- package/skills/codex/git-worktrees/SKILL.md +193 -0
- package/skills/codex/git-worktrees/references/commands-reference.md +78 -0
- package/skills/codex/implementation-planning/SKILL.md +289 -0
- package/skills/codex/implementation-planning/references/plan-document-template.md +42 -0
- package/skills/codex/implementation-planning/references/rationalization-refutation.md +13 -0
- package/skills/codex/implementation-planning/references/spec-tracing-guide.md +51 -0
- package/skills/codex/implementation-planning/references/task-template.md +63 -0
- package/skills/codex/implementation-planning/references/testing-strategy-guide.md +109 -0
- package/skills/codex/implementation-planning/references/worked-example.md +76 -0
- package/skills/codex/oneshot-workflow/SKILL.md +468 -0
- package/skills/codex/oneshot-workflow/references/choice-state.md +65 -0
- package/skills/codex/prune-workflows/SKILL.md +290 -0
- package/skills/codex/prune-workflows/references/safeguards.md +74 -0
- package/skills/codex/quality-review/SKILL.md +371 -0
- package/skills/codex/quality-review/references/auto-transition.md +47 -0
- package/skills/codex/quality-review/references/axiom-integration.md +135 -0
- package/skills/codex/quality-review/references/code-quality-checklist.md +171 -0
- package/skills/codex/quality-review/references/convergence-and-verdict.md +48 -0
- package/skills/codex/quality-review/references/gate-execution.md +60 -0
- package/skills/codex/quality-review/references/rationalization-refutation.md +13 -0
- package/skills/codex/quality-review/references/review-report-template.md +65 -0
- package/skills/codex/quality-review/references/security-checklist.md +79 -0
- package/skills/codex/quality-review/references/typescript-standards.md +24 -0
- package/skills/codex/refactor/SKILL.md +196 -0
- package/skills/codex/refactor/references/brief-template.md +81 -0
- package/skills/codex/refactor/references/doc-update-checklist.md +113 -0
- package/skills/codex/refactor/references/explore-checklist.md +79 -0
- package/skills/codex/refactor/references/overhaul-track.md +194 -0
- package/skills/codex/refactor/references/phases/auto-chain.md +267 -0
- package/skills/codex/refactor/references/phases/brief.md +176 -0
- package/skills/codex/refactor/references/phases/explore.md +132 -0
- package/skills/codex/refactor/references/phases/overhaul-delegate.md +136 -0
- package/skills/codex/refactor/references/phases/overhaul-plan.md +312 -0
- package/skills/codex/refactor/references/phases/overhaul-review.md +304 -0
- package/skills/codex/refactor/references/phases/polish-implement.md +347 -0
- package/skills/codex/refactor/references/phases/polish-validate.md +218 -0
- package/skills/codex/refactor/references/phases/update-docs.md +234 -0
- package/skills/codex/refactor/references/polish-track.md +152 -0
- package/skills/codex/shepherd/SKILL.md +251 -0
- package/skills/codex/shepherd/references/assess-checklist.md +170 -0
- package/skills/codex/shepherd/references/escalation-criteria.md +53 -0
- package/skills/codex/shepherd/references/fix-strategies.md +289 -0
- package/skills/codex/shepherd/references/gate-event-emission.md +47 -0
- package/skills/codex/shepherd/references/shepherd-event-schemas.md +56 -0
- package/skills/codex/spec-review/SKILL.md +294 -0
- package/skills/codex/spec-review/references/rationalization-refutation.md +13 -0
- package/skills/codex/spec-review/references/review-checklist.md +79 -0
- package/skills/codex/spec-review/references/worked-example.md +72 -0
- package/skills/codex/synthesis/SKILL.md +217 -0
- package/skills/codex/synthesis/references/github-native-stacking.md +135 -0
- package/skills/codex/synthesis/references/merge-ordering.md +50 -0
- package/skills/codex/synthesis/references/pr-descriptions.md +87 -0
- package/skills/codex/synthesis/references/synthesis-steps.md +145 -0
- package/skills/codex/synthesis/references/troubleshooting.md +115 -0
- package/skills/codex/workflow-state/SKILL.md +254 -0
- package/skills/codex/workflow-state/references/mcp-tool-reference.md +89 -0
- package/skills/codex/workflow-state/references/phase-transitions.md +206 -0
- package/skills/copilot/brainstorming/SKILL.md +182 -0
- package/skills/copilot/brainstorming/references/design-template.md +107 -0
- package/skills/copilot/brainstorming/references/worked-example.md +58 -0
- package/skills/copilot/cleanup/SKILL.md +169 -0
- package/skills/copilot/cleanup/references/merge-verification.md +40 -0
- package/skills/copilot/debug/SKILL.md +247 -0
- package/skills/copilot/debug/references/hotfix-track.md +105 -0
- package/skills/copilot/debug/references/investigation-checklist.md +217 -0
- package/skills/copilot/debug/references/rca-template.md +150 -0
- package/skills/copilot/debug/references/state-schema.md +294 -0
- package/skills/copilot/debug/references/thorough-track.md +171 -0
- package/skills/copilot/debug/references/triage-questions.md +155 -0
- package/skills/copilot/debug/references/troubleshooting.md +47 -0
- package/skills/copilot/delegation/SKILL.md +345 -0
- package/skills/copilot/delegation/references/adaptive-orchestration.md +31 -0
- package/skills/copilot/delegation/references/agent-teams-saga.md +254 -0
- package/skills/copilot/delegation/references/fix-mode.md +118 -0
- package/skills/copilot/delegation/references/fixer-prompt.md +174 -0
- package/skills/copilot/delegation/references/implementer-prompt.md +401 -0
- package/skills/copilot/delegation/references/parallel-strategy.md +124 -0
- package/skills/copilot/delegation/references/pbt-patterns.md +172 -0
- package/skills/copilot/delegation/references/pr-fixes-mode.md +155 -0
- package/skills/copilot/delegation/references/rationalization-refutation.md +15 -0
- package/skills/copilot/delegation/references/state-management.md +84 -0
- package/skills/copilot/delegation/references/testing-patterns.md +146 -0
- package/skills/copilot/delegation/references/troubleshooting.md +109 -0
- package/skills/copilot/delegation/references/worked-example.md +104 -0
- package/skills/copilot/delegation/references/workflow-steps.md +131 -0
- package/skills/copilot/delegation/references/worktree-enforcement.md +71 -0
- package/skills/copilot/dogfood/SKILL.md +235 -0
- package/skills/copilot/dogfood/references/report-template.md +109 -0
- package/skills/copilot/dogfood/references/root-cause-patterns.md +227 -0
- package/skills/copilot/git-worktrees/SKILL.md +193 -0
- package/skills/copilot/git-worktrees/references/commands-reference.md +78 -0
- package/skills/copilot/implementation-planning/SKILL.md +289 -0
- package/skills/copilot/implementation-planning/references/plan-document-template.md +42 -0
- package/skills/copilot/implementation-planning/references/rationalization-refutation.md +13 -0
- package/skills/copilot/implementation-planning/references/spec-tracing-guide.md +51 -0
- package/skills/copilot/implementation-planning/references/task-template.md +63 -0
- package/skills/copilot/implementation-planning/references/testing-strategy-guide.md +109 -0
- package/skills/copilot/implementation-planning/references/worked-example.md +76 -0
- package/skills/copilot/oneshot-workflow/SKILL.md +468 -0
- package/skills/copilot/oneshot-workflow/references/choice-state.md +65 -0
- package/skills/copilot/prune-workflows/SKILL.md +290 -0
- package/skills/copilot/prune-workflows/references/safeguards.md +74 -0
- package/skills/copilot/quality-review/SKILL.md +371 -0
- package/skills/copilot/quality-review/references/auto-transition.md +47 -0
- package/skills/copilot/quality-review/references/axiom-integration.md +135 -0
- package/skills/copilot/quality-review/references/code-quality-checklist.md +171 -0
- package/skills/copilot/quality-review/references/convergence-and-verdict.md +48 -0
- package/skills/copilot/quality-review/references/gate-execution.md +60 -0
- package/skills/copilot/quality-review/references/rationalization-refutation.md +13 -0
- package/skills/copilot/quality-review/references/review-report-template.md +65 -0
- package/skills/copilot/quality-review/references/security-checklist.md +79 -0
- package/skills/copilot/quality-review/references/typescript-standards.md +24 -0
- package/skills/copilot/refactor/SKILL.md +196 -0
- package/skills/copilot/refactor/references/brief-template.md +81 -0
- package/skills/copilot/refactor/references/doc-update-checklist.md +113 -0
- package/skills/copilot/refactor/references/explore-checklist.md +79 -0
- package/skills/copilot/refactor/references/overhaul-track.md +194 -0
- package/skills/copilot/refactor/references/phases/auto-chain.md +267 -0
- package/skills/copilot/refactor/references/phases/brief.md +176 -0
- package/skills/copilot/refactor/references/phases/explore.md +132 -0
- package/skills/copilot/refactor/references/phases/overhaul-delegate.md +136 -0
- package/skills/copilot/refactor/references/phases/overhaul-plan.md +312 -0
- package/skills/copilot/refactor/references/phases/overhaul-review.md +304 -0
- package/skills/copilot/refactor/references/phases/polish-implement.md +347 -0
- package/skills/copilot/refactor/references/phases/polish-validate.md +218 -0
- package/skills/copilot/refactor/references/phases/update-docs.md +234 -0
- package/skills/copilot/refactor/references/polish-track.md +152 -0
- package/skills/copilot/shepherd/SKILL.md +251 -0
- package/skills/copilot/shepherd/references/assess-checklist.md +170 -0
- package/skills/copilot/shepherd/references/escalation-criteria.md +53 -0
- package/skills/copilot/shepherd/references/fix-strategies.md +289 -0
- package/skills/copilot/shepherd/references/gate-event-emission.md +47 -0
- package/skills/copilot/shepherd/references/shepherd-event-schemas.md +56 -0
- package/skills/copilot/spec-review/SKILL.md +294 -0
- package/skills/copilot/spec-review/references/rationalization-refutation.md +13 -0
- package/skills/copilot/spec-review/references/review-checklist.md +79 -0
- package/skills/copilot/spec-review/references/worked-example.md +72 -0
- package/skills/copilot/synthesis/SKILL.md +217 -0
- package/skills/copilot/synthesis/references/github-native-stacking.md +135 -0
- package/skills/copilot/synthesis/references/merge-ordering.md +50 -0
- package/skills/copilot/synthesis/references/pr-descriptions.md +87 -0
- package/skills/copilot/synthesis/references/synthesis-steps.md +145 -0
- package/skills/copilot/synthesis/references/troubleshooting.md +115 -0
- package/skills/copilot/workflow-state/SKILL.md +254 -0
- package/skills/copilot/workflow-state/references/mcp-tool-reference.md +89 -0
- package/skills/copilot/workflow-state/references/phase-transitions.md +206 -0
- package/skills/cursor/brainstorming/SKILL.md +182 -0
- package/skills/cursor/brainstorming/references/design-template.md +107 -0
- package/skills/cursor/brainstorming/references/worked-example.md +58 -0
- package/skills/cursor/cleanup/SKILL.md +169 -0
- package/skills/cursor/cleanup/references/merge-verification.md +40 -0
- package/skills/cursor/debug/SKILL.md +247 -0
- package/skills/cursor/debug/references/hotfix-track.md +105 -0
- package/skills/cursor/debug/references/investigation-checklist.md +217 -0
- package/skills/cursor/debug/references/rca-template.md +150 -0
- package/skills/cursor/debug/references/state-schema.md +294 -0
- package/skills/cursor/debug/references/thorough-track.md +171 -0
- package/skills/cursor/debug/references/triage-questions.md +155 -0
- package/skills/cursor/debug/references/troubleshooting.md +47 -0
- package/skills/cursor/delegation/SKILL.md +351 -0
- package/skills/cursor/delegation/references/adaptive-orchestration.md +31 -0
- package/skills/cursor/delegation/references/agent-teams-saga.md +254 -0
- package/skills/cursor/delegation/references/fix-mode.md +118 -0
- package/skills/cursor/delegation/references/fixer-prompt.md +174 -0
- package/skills/cursor/delegation/references/implementer-prompt.md +401 -0
- package/skills/cursor/delegation/references/parallel-strategy.md +124 -0
- package/skills/cursor/delegation/references/pbt-patterns.md +172 -0
- package/skills/cursor/delegation/references/pr-fixes-mode.md +155 -0
- package/skills/cursor/delegation/references/rationalization-refutation.md +15 -0
- package/skills/cursor/delegation/references/state-management.md +84 -0
- package/skills/cursor/delegation/references/testing-patterns.md +146 -0
- package/skills/cursor/delegation/references/troubleshooting.md +109 -0
- package/skills/cursor/delegation/references/worked-example.md +104 -0
- package/skills/cursor/delegation/references/workflow-steps.md +131 -0
- package/skills/cursor/delegation/references/worktree-enforcement.md +71 -0
- package/skills/cursor/dogfood/SKILL.md +235 -0
- package/skills/cursor/dogfood/references/report-template.md +109 -0
- package/skills/cursor/dogfood/references/root-cause-patterns.md +227 -0
- package/skills/cursor/git-worktrees/SKILL.md +193 -0
- package/skills/cursor/git-worktrees/references/commands-reference.md +78 -0
- package/skills/cursor/implementation-planning/SKILL.md +289 -0
- package/skills/cursor/implementation-planning/references/plan-document-template.md +42 -0
- package/skills/cursor/implementation-planning/references/rationalization-refutation.md +13 -0
- package/skills/cursor/implementation-planning/references/spec-tracing-guide.md +51 -0
- package/skills/cursor/implementation-planning/references/task-template.md +63 -0
- package/skills/cursor/implementation-planning/references/testing-strategy-guide.md +109 -0
- package/skills/cursor/implementation-planning/references/worked-example.md +76 -0
- package/skills/cursor/oneshot-workflow/SKILL.md +468 -0
- package/skills/cursor/oneshot-workflow/references/choice-state.md +65 -0
- package/skills/cursor/prune-workflows/SKILL.md +290 -0
- package/skills/cursor/prune-workflows/references/safeguards.md +74 -0
- package/skills/cursor/quality-review/SKILL.md +371 -0
- package/skills/cursor/quality-review/references/auto-transition.md +47 -0
- package/skills/cursor/quality-review/references/axiom-integration.md +135 -0
- package/skills/cursor/quality-review/references/code-quality-checklist.md +171 -0
- package/skills/cursor/quality-review/references/convergence-and-verdict.md +48 -0
- package/skills/cursor/quality-review/references/gate-execution.md +60 -0
- package/skills/cursor/quality-review/references/rationalization-refutation.md +13 -0
- package/skills/cursor/quality-review/references/review-report-template.md +65 -0
- package/skills/cursor/quality-review/references/security-checklist.md +79 -0
- package/skills/cursor/quality-review/references/typescript-standards.md +24 -0
- package/skills/cursor/refactor/SKILL.md +196 -0
- package/skills/cursor/refactor/references/brief-template.md +81 -0
- package/skills/cursor/refactor/references/doc-update-checklist.md +113 -0
- package/skills/cursor/refactor/references/explore-checklist.md +79 -0
- package/skills/cursor/refactor/references/overhaul-track.md +194 -0
- package/skills/cursor/refactor/references/phases/auto-chain.md +267 -0
- package/skills/cursor/refactor/references/phases/brief.md +176 -0
- package/skills/cursor/refactor/references/phases/explore.md +132 -0
- package/skills/cursor/refactor/references/phases/overhaul-delegate.md +136 -0
- package/skills/cursor/refactor/references/phases/overhaul-plan.md +312 -0
- package/skills/cursor/refactor/references/phases/overhaul-review.md +304 -0
- package/skills/cursor/refactor/references/phases/polish-implement.md +347 -0
- package/skills/cursor/refactor/references/phases/polish-validate.md +218 -0
- package/skills/cursor/refactor/references/phases/update-docs.md +234 -0
- package/skills/cursor/refactor/references/polish-track.md +152 -0
- package/skills/cursor/shepherd/SKILL.md +251 -0
- package/skills/cursor/shepherd/references/assess-checklist.md +170 -0
- package/skills/cursor/shepherd/references/escalation-criteria.md +53 -0
- package/skills/cursor/shepherd/references/fix-strategies.md +289 -0
- package/skills/cursor/shepherd/references/gate-event-emission.md +47 -0
- package/skills/cursor/shepherd/references/shepherd-event-schemas.md +56 -0
- package/skills/cursor/spec-review/SKILL.md +294 -0
- package/skills/cursor/spec-review/references/rationalization-refutation.md +13 -0
- package/skills/cursor/spec-review/references/review-checklist.md +79 -0
- package/skills/cursor/spec-review/references/worked-example.md +72 -0
- package/skills/cursor/synthesis/SKILL.md +217 -0
- package/skills/cursor/synthesis/references/github-native-stacking.md +135 -0
- package/skills/cursor/synthesis/references/merge-ordering.md +50 -0
- package/skills/cursor/synthesis/references/pr-descriptions.md +87 -0
- package/skills/cursor/synthesis/references/synthesis-steps.md +145 -0
- package/skills/cursor/synthesis/references/troubleshooting.md +115 -0
- package/skills/cursor/workflow-state/SKILL.md +254 -0
- package/skills/cursor/workflow-state/references/mcp-tool-reference.md +89 -0
- package/skills/cursor/workflow-state/references/phase-transitions.md +206 -0
- package/skills/generic/brainstorming/SKILL.md +182 -0
- package/skills/generic/brainstorming/references/design-template.md +107 -0
- package/skills/generic/brainstorming/references/worked-example.md +58 -0
- package/skills/generic/cleanup/SKILL.md +169 -0
- package/skills/generic/cleanup/references/merge-verification.md +40 -0
- package/skills/generic/debug/SKILL.md +247 -0
- package/skills/generic/debug/references/hotfix-track.md +105 -0
- package/skills/generic/debug/references/investigation-checklist.md +217 -0
- package/skills/generic/debug/references/rca-template.md +150 -0
- package/skills/generic/debug/references/state-schema.md +294 -0
- package/skills/generic/debug/references/thorough-track.md +171 -0
- package/skills/generic/debug/references/triage-questions.md +155 -0
- package/skills/generic/debug/references/troubleshooting.md +47 -0
- package/skills/generic/delegation/SKILL.md +345 -0
- package/skills/generic/delegation/references/adaptive-orchestration.md +31 -0
- package/skills/generic/delegation/references/agent-teams-saga.md +254 -0
- package/skills/generic/delegation/references/fix-mode.md +118 -0
- package/skills/generic/delegation/references/fixer-prompt.md +174 -0
- package/skills/generic/delegation/references/implementer-prompt.md +401 -0
- package/skills/generic/delegation/references/parallel-strategy.md +124 -0
- package/skills/generic/delegation/references/pbt-patterns.md +172 -0
- package/skills/generic/delegation/references/pr-fixes-mode.md +155 -0
- package/skills/generic/delegation/references/rationalization-refutation.md +15 -0
- package/skills/generic/delegation/references/state-management.md +84 -0
- package/skills/generic/delegation/references/testing-patterns.md +146 -0
- package/skills/generic/delegation/references/troubleshooting.md +109 -0
- package/skills/generic/delegation/references/worked-example.md +104 -0
- package/skills/generic/delegation/references/workflow-steps.md +131 -0
- package/skills/generic/delegation/references/worktree-enforcement.md +71 -0
- package/skills/generic/dogfood/SKILL.md +235 -0
- package/skills/generic/dogfood/references/report-template.md +109 -0
- package/skills/generic/dogfood/references/root-cause-patterns.md +227 -0
- package/skills/generic/git-worktrees/SKILL.md +193 -0
- package/skills/generic/git-worktrees/references/commands-reference.md +78 -0
- package/skills/generic/implementation-planning/SKILL.md +289 -0
- package/skills/generic/implementation-planning/references/plan-document-template.md +42 -0
- package/skills/generic/implementation-planning/references/rationalization-refutation.md +13 -0
- package/skills/generic/implementation-planning/references/spec-tracing-guide.md +51 -0
- package/skills/generic/implementation-planning/references/task-template.md +63 -0
- package/skills/generic/implementation-planning/references/testing-strategy-guide.md +109 -0
- package/skills/generic/implementation-planning/references/worked-example.md +76 -0
- package/skills/generic/oneshot-workflow/SKILL.md +468 -0
- package/skills/generic/oneshot-workflow/references/choice-state.md +65 -0
- package/skills/generic/prune-workflows/SKILL.md +290 -0
- package/skills/generic/prune-workflows/references/safeguards.md +74 -0
- package/skills/generic/quality-review/SKILL.md +371 -0
- package/skills/generic/quality-review/references/auto-transition.md +47 -0
- package/skills/generic/quality-review/references/axiom-integration.md +135 -0
- package/skills/generic/quality-review/references/code-quality-checklist.md +171 -0
- package/skills/generic/quality-review/references/convergence-and-verdict.md +48 -0
- package/skills/generic/quality-review/references/gate-execution.md +60 -0
- package/skills/generic/quality-review/references/rationalization-refutation.md +13 -0
- package/skills/generic/quality-review/references/review-report-template.md +65 -0
- package/skills/generic/quality-review/references/security-checklist.md +79 -0
- package/skills/generic/quality-review/references/typescript-standards.md +24 -0
- package/skills/generic/refactor/SKILL.md +196 -0
- package/skills/generic/refactor/references/brief-template.md +81 -0
- package/skills/generic/refactor/references/doc-update-checklist.md +113 -0
- package/skills/generic/refactor/references/explore-checklist.md +79 -0
- package/skills/generic/refactor/references/overhaul-track.md +194 -0
- package/skills/generic/refactor/references/phases/auto-chain.md +267 -0
- package/skills/generic/refactor/references/phases/brief.md +176 -0
- package/skills/generic/refactor/references/phases/explore.md +132 -0
- package/skills/generic/refactor/references/phases/overhaul-delegate.md +136 -0
- package/skills/generic/refactor/references/phases/overhaul-plan.md +312 -0
- package/skills/generic/refactor/references/phases/overhaul-review.md +304 -0
- package/skills/generic/refactor/references/phases/polish-implement.md +347 -0
- package/skills/generic/refactor/references/phases/polish-validate.md +218 -0
- package/skills/generic/refactor/references/phases/update-docs.md +234 -0
- package/skills/generic/refactor/references/polish-track.md +152 -0
- package/skills/generic/shepherd/SKILL.md +251 -0
- package/skills/generic/shepherd/references/assess-checklist.md +170 -0
- package/skills/generic/shepherd/references/escalation-criteria.md +53 -0
- package/skills/generic/shepherd/references/fix-strategies.md +289 -0
- package/skills/generic/shepherd/references/gate-event-emission.md +47 -0
- package/skills/generic/shepherd/references/shepherd-event-schemas.md +56 -0
- package/skills/generic/spec-review/SKILL.md +294 -0
- package/skills/generic/spec-review/references/rationalization-refutation.md +13 -0
- package/skills/generic/spec-review/references/review-checklist.md +79 -0
- package/skills/generic/spec-review/references/worked-example.md +72 -0
- package/skills/generic/synthesis/SKILL.md +217 -0
- package/skills/generic/synthesis/references/github-native-stacking.md +135 -0
- package/skills/generic/synthesis/references/merge-ordering.md +50 -0
- package/skills/generic/synthesis/references/pr-descriptions.md +87 -0
- package/skills/generic/synthesis/references/synthesis-steps.md +145 -0
- package/skills/generic/synthesis/references/troubleshooting.md +115 -0
- package/skills/generic/workflow-state/SKILL.md +254 -0
- package/skills/generic/workflow-state/references/mcp-tool-reference.md +89 -0
- package/skills/generic/workflow-state/references/phase-transitions.md +206 -0
- package/skills/opencode/brainstorming/SKILL.md +182 -0
- package/skills/opencode/brainstorming/references/design-template.md +107 -0
- package/skills/opencode/brainstorming/references/worked-example.md +58 -0
- package/skills/opencode/cleanup/SKILL.md +169 -0
- package/skills/opencode/cleanup/references/merge-verification.md +40 -0
- package/skills/opencode/debug/SKILL.md +247 -0
- package/skills/opencode/debug/references/hotfix-track.md +105 -0
- package/skills/opencode/debug/references/investigation-checklist.md +217 -0
- package/skills/opencode/debug/references/rca-template.md +150 -0
- package/skills/opencode/debug/references/state-schema.md +294 -0
- package/skills/opencode/debug/references/thorough-track.md +171 -0
- package/skills/opencode/debug/references/triage-questions.md +155 -0
- package/skills/opencode/debug/references/troubleshooting.md +47 -0
- package/skills/opencode/delegation/SKILL.md +353 -0
- package/skills/opencode/delegation/references/adaptive-orchestration.md +31 -0
- package/skills/opencode/delegation/references/agent-teams-saga.md +254 -0
- package/skills/opencode/delegation/references/fix-mode.md +118 -0
- package/skills/opencode/delegation/references/fixer-prompt.md +174 -0
- package/skills/opencode/delegation/references/implementer-prompt.md +401 -0
- package/skills/opencode/delegation/references/parallel-strategy.md +124 -0
- package/skills/opencode/delegation/references/pbt-patterns.md +172 -0
- package/skills/opencode/delegation/references/pr-fixes-mode.md +155 -0
- package/skills/opencode/delegation/references/rationalization-refutation.md +15 -0
- package/skills/opencode/delegation/references/state-management.md +84 -0
- package/skills/opencode/delegation/references/testing-patterns.md +146 -0
- package/skills/opencode/delegation/references/troubleshooting.md +109 -0
- package/skills/opencode/delegation/references/worked-example.md +104 -0
- package/skills/opencode/delegation/references/workflow-steps.md +131 -0
- package/skills/opencode/delegation/references/worktree-enforcement.md +71 -0
- package/skills/opencode/dogfood/SKILL.md +235 -0
- package/skills/opencode/dogfood/references/report-template.md +109 -0
- package/skills/opencode/dogfood/references/root-cause-patterns.md +227 -0
- package/skills/opencode/git-worktrees/SKILL.md +193 -0
- package/skills/opencode/git-worktrees/references/commands-reference.md +78 -0
- package/skills/opencode/implementation-planning/SKILL.md +289 -0
- package/skills/opencode/implementation-planning/references/plan-document-template.md +42 -0
- package/skills/opencode/implementation-planning/references/rationalization-refutation.md +13 -0
- package/skills/opencode/implementation-planning/references/spec-tracing-guide.md +51 -0
- package/skills/opencode/implementation-planning/references/task-template.md +63 -0
- package/skills/opencode/implementation-planning/references/testing-strategy-guide.md +109 -0
- package/skills/opencode/implementation-planning/references/worked-example.md +76 -0
- package/skills/opencode/oneshot-workflow/SKILL.md +468 -0
- package/skills/opencode/oneshot-workflow/references/choice-state.md +65 -0
- package/skills/opencode/prune-workflows/SKILL.md +290 -0
- package/skills/opencode/prune-workflows/references/safeguards.md +74 -0
- package/skills/opencode/quality-review/SKILL.md +371 -0
- package/skills/opencode/quality-review/references/auto-transition.md +47 -0
- package/skills/opencode/quality-review/references/axiom-integration.md +135 -0
- package/skills/opencode/quality-review/references/code-quality-checklist.md +171 -0
- package/skills/opencode/quality-review/references/convergence-and-verdict.md +48 -0
- package/skills/opencode/quality-review/references/gate-execution.md +60 -0
- package/skills/opencode/quality-review/references/rationalization-refutation.md +13 -0
- package/skills/opencode/quality-review/references/review-report-template.md +65 -0
- package/skills/opencode/quality-review/references/security-checklist.md +79 -0
- package/skills/opencode/quality-review/references/typescript-standards.md +24 -0
- package/skills/opencode/refactor/SKILL.md +196 -0
- package/skills/opencode/refactor/references/brief-template.md +81 -0
- package/skills/opencode/refactor/references/doc-update-checklist.md +113 -0
- package/skills/opencode/refactor/references/explore-checklist.md +79 -0
- package/skills/opencode/refactor/references/overhaul-track.md +194 -0
- package/skills/opencode/refactor/references/phases/auto-chain.md +267 -0
- package/skills/opencode/refactor/references/phases/brief.md +176 -0
- package/skills/opencode/refactor/references/phases/explore.md +132 -0
- package/skills/opencode/refactor/references/phases/overhaul-delegate.md +136 -0
- package/skills/opencode/refactor/references/phases/overhaul-plan.md +312 -0
- package/skills/opencode/refactor/references/phases/overhaul-review.md +304 -0
- package/skills/opencode/refactor/references/phases/polish-implement.md +347 -0
- package/skills/opencode/refactor/references/phases/polish-validate.md +218 -0
- package/skills/opencode/refactor/references/phases/update-docs.md +234 -0
- package/skills/opencode/refactor/references/polish-track.md +152 -0
- package/skills/opencode/shepherd/SKILL.md +251 -0
- package/skills/opencode/shepherd/references/assess-checklist.md +170 -0
- package/skills/opencode/shepherd/references/escalation-criteria.md +53 -0
- package/skills/opencode/shepherd/references/fix-strategies.md +289 -0
- package/skills/opencode/shepherd/references/gate-event-emission.md +47 -0
- package/skills/opencode/shepherd/references/shepherd-event-schemas.md +56 -0
- package/skills/opencode/spec-review/SKILL.md +294 -0
- package/skills/opencode/spec-review/references/rationalization-refutation.md +13 -0
- package/skills/opencode/spec-review/references/review-checklist.md +79 -0
- package/skills/opencode/spec-review/references/worked-example.md +72 -0
- package/skills/opencode/synthesis/SKILL.md +217 -0
- package/skills/opencode/synthesis/references/github-native-stacking.md +135 -0
- package/skills/opencode/synthesis/references/merge-ordering.md +50 -0
- package/skills/opencode/synthesis/references/pr-descriptions.md +87 -0
- package/skills/opencode/synthesis/references/synthesis-steps.md +145 -0
- package/skills/opencode/synthesis/references/troubleshooting.md +115 -0
- package/skills/opencode/workflow-state/SKILL.md +254 -0
- package/skills/opencode/workflow-state/references/mcp-tool-reference.md +89 -0
- package/skills/opencode/workflow-state/references/phase-transitions.md +206 -0
- package/.claude-plugin/marketplace.json +0 -34
- package/dist/node_modules/electron/index.js +0 -1
- package/dist/node_modules/electron/package.json +0 -1
- package/dist/node_modules/playwright-core/index.js +0 -1
- package/dist/node_modules/playwright-core/package.json +0 -1
- package/scripts/assess-refactor-scope.sh +0 -239
- package/scripts/check-coderabbit.sh +0 -288
- package/scripts/check-context-economy.sh +0 -405
- package/scripts/check-coverage-thresholds.sh +0 -194
- package/scripts/check-operational-resilience.sh +0 -306
- package/scripts/check-polish-scope.sh +0 -245
- package/scripts/check-post-merge.sh +0 -185
- package/scripts/check-pr-comments.sh +0 -127
- package/scripts/check-task-decomposition.sh +0 -451
- package/scripts/check-tdd-compliance.sh +0 -265
- package/scripts/check-workflow-determinism.sh +0 -312
- package/scripts/debug-review-gate.sh +0 -201
- package/scripts/extract-fix-tasks.sh +0 -179
- package/scripts/extract-task.sh +0 -67
- package/scripts/generate-traceability.sh +0 -209
- package/scripts/investigation-timer.sh +0 -171
- package/scripts/needs-schema-sync.sh +0 -174
- package/scripts/new-project.sh +0 -103
- package/scripts/post-delegation-check.sh +0 -317
- package/scripts/pre-synthesis-check.sh +0 -475
- package/scripts/reconcile-state.sh +0 -346
- package/scripts/review-diff.sh +0 -63
- package/scripts/review-verdict.sh +0 -169
- package/scripts/security-scan.sh +0 -248
- package/scripts/select-debug-track.sh +0 -186
- package/scripts/setup-worktree.sh +0 -323
- package/scripts/spec-coverage-check.sh +0 -230
- package/scripts/static-analysis-gate.sh +0 -261
- package/scripts/validate-companion.sh +0 -161
- package/scripts/validate-pr-body.sh +0 -158
- package/scripts/validate-pr-stack.sh +0 -146
- package/scripts/verify-delegation-saga.sh +0 -240
- package/scripts/verify-doc-links.sh +0 -211
- package/scripts/verify-ideate-artifacts.sh +0 -296
- package/scripts/verify-plan-coverage.sh +0 -408
- package/scripts/verify-provenance-chain.sh +0 -310
- package/scripts/verify-review-triage.sh +0 -219
- package/scripts/verify-worktree-baseline.sh +0 -159
- package/scripts/verify-worktree.sh +0 -84
- package/skills/delegation/references/fix-mode.md +0 -78
- package/skills/implementation-planning/references/task-template.md +0 -43
- package/skills/shared/prompts/context-reading.md +0 -66
- package/skills/shared/prompts/report-format.md +0 -54
- package/skills/shared/prompts/tdd-requirements.md +0 -39
- package/skills/shared/references/coding-standards.md +0 -46
- package/skills/shared/references/mcp-tool-guidance.md +0 -26
- package/skills/shared/references/skill-path-resolution.md +0 -10
- package/skills/shared/references/tdd.md +0 -41
- package/skills/shared/references/telemetry-awareness.md +0 -9
- /package/skills/{brainstorming → claude/brainstorming}/references/worked-example.md +0 -0
- /package/skills/{cleanup → claude/cleanup}/references/merge-verification.md +0 -0
- /package/skills/{debug → claude/debug}/references/rca-template.md +0 -0
- /package/skills/{debug → claude/debug}/references/state-schema.md +0 -0
- /package/skills/{debug → claude/debug}/references/triage-questions.md +0 -0
- /package/skills/{debug → claude/debug}/references/troubleshooting.md +0 -0
- /package/skills/{delegation → claude/delegation}/references/adaptive-orchestration.md +0 -0
- /package/skills/{delegation → claude/delegation}/references/fixer-prompt.md +0 -0
- /package/skills/{delegation → claude/delegation}/references/pbt-patterns.md +0 -0
- /package/skills/{delegation → claude/delegation}/references/pr-fixes-mode.md +0 -0
- /package/skills/{delegation → claude/delegation}/references/rationalization-refutation.md +0 -0
- /package/skills/{delegation → claude/delegation}/references/testing-patterns.md +0 -0
- /package/skills/{delegation → claude/delegation}/references/worked-example.md +0 -0
- /package/skills/{git-worktrees → claude/git-worktrees}/references/commands-reference.md +0 -0
- /package/skills/{implementation-planning → claude/implementation-planning}/references/plan-document-template.md +0 -0
- /package/skills/{implementation-planning → claude/implementation-planning}/references/rationalization-refutation.md +0 -0
- /package/skills/{implementation-planning → claude/implementation-planning}/references/spec-tracing-guide.md +0 -0
- /package/skills/{quality-review → claude/quality-review}/references/code-quality-checklist.md +0 -0
- /package/skills/{quality-review → claude/quality-review}/references/convergence-and-verdict.md +0 -0
- /package/skills/{quality-review → claude/quality-review}/references/gate-execution.md +0 -0
- /package/skills/{quality-review → claude/quality-review}/references/rationalization-refutation.md +0 -0
- /package/skills/{quality-review → claude/quality-review}/references/review-report-template.md +0 -0
- /package/skills/{quality-review → claude/quality-review}/references/security-checklist.md +0 -0
- /package/skills/{quality-review → claude/quality-review}/references/typescript-standards.md +0 -0
- /package/skills/{refactor → claude/refactor}/references/brief-template.md +0 -0
- /package/skills/{refactor → claude/refactor/references}/phases/auto-chain.md +0 -0
- /package/skills/{refactor → claude/refactor/references}/phases/brief.md +0 -0
- /package/skills/{refactor → claude/refactor/references}/phases/explore.md +0 -0
- /package/skills/{refactor → claude/refactor/references}/phases/overhaul-delegate.md +0 -0
- /package/skills/{refactor → claude/refactor/references}/phases/overhaul-plan.md +0 -0
- /package/skills/{refactor → claude/refactor/references}/phases/overhaul-review.md +0 -0
- /package/skills/{refactor → claude/refactor/references}/phases/update-docs.md +0 -0
- /package/skills/{shepherd → claude/shepherd}/references/assess-checklist.md +0 -0
- /package/skills/{shepherd → claude/shepherd}/references/escalation-criteria.md +0 -0
- /package/skills/{shepherd → claude/shepherd}/references/gate-event-emission.md +0 -0
- /package/skills/{spec-review → claude/spec-review}/references/rationalization-refutation.md +0 -0
- /package/skills/{spec-review → claude/spec-review}/references/review-checklist.md +0 -0
- /package/skills/{synthesis → claude/synthesis}/references/merge-ordering.md +0 -0
- /package/skills/{synthesis → claude/synthesis}/references/pr-descriptions.md +0 -0
- /package/skills/{synthesis → claude/synthesis}/references/troubleshooting.md +0 -0
|
@@ -0,0 +1,371 @@
|
|
|
1
|
+
---
|
|
2
|
+
name: quality-review
|
|
3
|
+
description: "Stage 2 code quality review. Triggers: 'quality review', 'check code quality', or /review stage 2. Requires spec-review to have passed first. Checks SOLID, DRY, security, and test quality. Do NOT use for spec compliance — use spec-review instead."
|
|
4
|
+
metadata:
|
|
5
|
+
author: exarchos
|
|
6
|
+
version: 1.0.0
|
|
7
|
+
mcp-server: exarchos
|
|
8
|
+
category: workflow
|
|
9
|
+
phase-affinity: review
|
|
10
|
+
---
|
|
11
|
+
|
|
12
|
+
# Quality Review Skill
|
|
13
|
+
|
|
14
|
+
## Overview
|
|
15
|
+
|
|
16
|
+
Stage 2 of two-stage review: Assess code quality, maintainability, and engineering best practices.
|
|
17
|
+
|
|
18
|
+
**Prerequisite:** Spec review must PASS before quality review.
|
|
19
|
+
|
|
20
|
+
> **MANDATORY:** Before accepting any rationalization for rubber-stamping code quality, consult `references/rationalization-refutation.md`. Every common excuse is catalogued with a counter-argument and the correct action.
|
|
21
|
+
|
|
22
|
+
## Triggers
|
|
23
|
+
|
|
24
|
+
Activate this skill when:
|
|
25
|
+
- Spec review has passed
|
|
26
|
+
- `review` command (after spec review)
|
|
27
|
+
- Ready to assess code quality
|
|
28
|
+
- Before synthesis/merge
|
|
29
|
+
|
|
30
|
+
## Execution Context
|
|
31
|
+
|
|
32
|
+
This skill runs in a SUBAGENT spawned by the orchestrator, not inline.
|
|
33
|
+
|
|
34
|
+
The orchestrator provides the state file path, diff output from `exarchos_orchestrate({ action: "review_diff" })`, task ID, and spec review results (must be PASS).
|
|
35
|
+
|
|
36
|
+
The subagent reads the state file for artifact paths, uses the diff output instead of full files, runs static analysis, performs a code walkthrough, generates a report, and returns the verdict.
|
|
37
|
+
|
|
38
|
+
### Data Handoff Protocol
|
|
39
|
+
|
|
40
|
+
The **orchestrator** is responsible for generating the diff before dispatching the quality-review subagent. The subagent does NOT generate its own diff.
|
|
41
|
+
|
|
42
|
+
**Orchestrator responsibilities:**
|
|
43
|
+
1. Generate diff: `git diff main...HEAD` or `git diff main...integration-branch`
|
|
44
|
+
2. Pass diff content in the subagent dispatch prompt
|
|
45
|
+
3. Include state file path for artifact resolution
|
|
46
|
+
4. Include spec review results (must be PASS)
|
|
47
|
+
|
|
48
|
+
**Subagent responsibilities:**
|
|
49
|
+
1. Receive diff content from dispatch prompt (do NOT re-generate)
|
|
50
|
+
2. Read state file for design/plan artifact paths
|
|
51
|
+
3. Run static analysis and security scripts against the working tree
|
|
52
|
+
4. Return structured JSON verdict
|
|
53
|
+
|
|
54
|
+
### Context-Efficient Input
|
|
55
|
+
|
|
56
|
+
Instead of reading full files, receive the integrated diff:
|
|
57
|
+
|
|
58
|
+
```bash
|
|
59
|
+
# Generate integrated diff for review (branch stack vs main)
|
|
60
|
+
git diff main...HEAD > /tmp/stack-diff.patch
|
|
61
|
+
|
|
62
|
+
# Alternative: git diff for integration branch
|
|
63
|
+
git diff main...integration-branch > /tmp/integration-diff.patch
|
|
64
|
+
|
|
65
|
+
# Alternative: use gh CLI to get PR diff
|
|
66
|
+
# gh pr diff <number>
|
|
67
|
+
# Or use GitHub MCP pull_request_read with method "get_diff" if available
|
|
68
|
+
```
|
|
69
|
+
|
|
70
|
+
This reduces context consumption by 80-90% while providing the complete picture.
|
|
71
|
+
|
|
72
|
+
### Pre-Review Schema Discovery
|
|
73
|
+
|
|
74
|
+
Before evaluating, query the review strategy runbook to determine the appropriate evaluation approach:
|
|
75
|
+
|
|
76
|
+
- **Evaluation strategy:** `exarchos_orchestrate({ action: "runbook", id: "review-strategy" })` to determine single-pass vs two-pass evaluation strategy based on diff size and task count.
|
|
77
|
+
|
|
78
|
+
### Review Scope: Combined Changes
|
|
79
|
+
|
|
80
|
+
After delegation completes, quality review examines:
|
|
81
|
+
- The **complete stack diff** (all task branches vs main), or the **feature/integration-branch** diff when using integration branches
|
|
82
|
+
- All changes across all tasks in one view
|
|
83
|
+
- The full picture of combined code quality
|
|
84
|
+
|
|
85
|
+
This enables catching:
|
|
86
|
+
- Cross-task SOLID violations
|
|
87
|
+
- Duplicate code across task boundaries
|
|
88
|
+
- Inconsistent patterns between tasks
|
|
89
|
+
|
|
90
|
+
## Review Scope
|
|
91
|
+
|
|
92
|
+
**Quality Review focuses on:**
|
|
93
|
+
- Code quality and readability
|
|
94
|
+
- SOLID principles
|
|
95
|
+
- Error handling
|
|
96
|
+
- Test quality
|
|
97
|
+
- Performance considerations
|
|
98
|
+
- Security basics
|
|
99
|
+
|
|
100
|
+
**Does NOT re-check:**
|
|
101
|
+
- Functional completeness (spec review)
|
|
102
|
+
- TDD compliance (spec review)
|
|
103
|
+
|
|
104
|
+
## Review Process
|
|
105
|
+
|
|
106
|
+
### Check Quality Signals
|
|
107
|
+
|
|
108
|
+
Before reviewing, query quality signals for the skill(s) under review:
|
|
109
|
+
```
|
|
110
|
+
mcp__exarchos__exarchos_view({ action: "code_quality", workflowId: "<featureId>" })
|
|
111
|
+
```
|
|
112
|
+
- If `regressions` is non-empty, report active quality regressions to the user before proceeding
|
|
113
|
+
- If any hint has `confidenceLevel: 'actionable'`, present the `suggestedAction` to the user
|
|
114
|
+
- If `gatePassRate < 0.80` for the target skill, warn about degrading quality
|
|
115
|
+
|
|
116
|
+
### Step 0: Verify Spec Review Passed (MANDATORY)
|
|
117
|
+
|
|
118
|
+
Before proceeding, confirm spec review passed for all tasks:
|
|
119
|
+
|
|
120
|
+
```text
|
|
121
|
+
action: "get", featureId: "<id>", query: "reviews"
|
|
122
|
+
```
|
|
123
|
+
|
|
124
|
+
If ANY task has `specReview.status !== "pass"`, STOP and return:
|
|
125
|
+
```json
|
|
126
|
+
{ "verdict": "blocked", "summary": "Spec review not passed — run spec-review first" }
|
|
127
|
+
```
|
|
128
|
+
|
|
129
|
+
### Step 0.5: Verify Review Triage (Conditional — run when delegation phase preceded this review)
|
|
130
|
+
|
|
131
|
+
If this review follows a delegation phase, verify triage routing:
|
|
132
|
+
|
|
133
|
+
```typescript
|
|
134
|
+
exarchos_orchestrate({
|
|
135
|
+
action: "verify_review_triage",
|
|
136
|
+
stateFile: "<state-file>"
|
|
137
|
+
})
|
|
138
|
+
```
|
|
139
|
+
|
|
140
|
+
`passed: true`: triage routing correct — continue to Step 1. `passed: false`: triage issues found — investigate and resolve before proceeding.
|
|
141
|
+
|
|
142
|
+
### Step 1: Static Analysis + Security + Extended Gates
|
|
143
|
+
|
|
144
|
+
> **Runbook:** Run quality evaluation gates via runbook:
|
|
145
|
+
> `exarchos_orchestrate({ action: "runbook", id: "quality-evaluation" })`
|
|
146
|
+
> If runbook unavailable, use `describe` to retrieve gate schemas: `exarchos_orchestrate({ action: "describe", actions: ["check_static_analysis", "check_security_scan", "check_convergence", "check_review_verdict"] })`
|
|
147
|
+
|
|
148
|
+
Run automated gates via orchestrate actions. See `references/gate-execution.md` for orchestrate action signatures and response handling.
|
|
149
|
+
|
|
150
|
+
1. `check_static_analysis` — lint, typecheck, quality-check (D2). **Must pass** before continuing.
|
|
151
|
+
2. `check_security_scan` — security pattern detection (D1). Include findings in report.
|
|
152
|
+
3. Optional D3-D5 gates: `check_context_economy`, `check_operational_resilience`, `check_workflow_determinism` — advisory, feed convergence view.
|
|
153
|
+
|
|
154
|
+
### Step 2: Test Desiderata Evaluation
|
|
155
|
+
|
|
156
|
+
Evaluate agent-generated tests against Kent Beck's Test Desiderata. Four properties are critical for agentic code:
|
|
157
|
+
|
|
158
|
+
| Property | What to check | Flag when |
|
|
159
|
+
|---|---|---|
|
|
160
|
+
| **Behavioral** | Tests assert on observable behavior, not implementation details | Mock call count assertions, internal state inspection, testing private methods |
|
|
161
|
+
| **Structure-insensitive** | Tests survive refactoring without behavioral change | Tests coupled to internal helper method signatures, tests that break when internals are renamed |
|
|
162
|
+
| **Deterministic** | Tests produce the same result every run | Uncontrolled `Date.now()`, `Math.random()`, `setTimeout` race conditions, network-dependent tests |
|
|
163
|
+
| **Specific** | Test failures pinpoint the cause | `toBeTruthy()` / `toBeDefined()` without additional specific assertions, catch-all tests with vague descriptions |
|
|
164
|
+
|
|
165
|
+
**Test layer mismatch detection:** Flag unit tests with >3 mocked dependencies as potential layer mismatches — unit tests with many mocks often indicate the test is asserting integration concerns rather than unit logic. Advisory finding: suggest re-classifying as integration test with real collaborators.
|
|
166
|
+
|
|
167
|
+
Include Test Desiderata findings in the quality review report under a "Test Quality" section. **Output format:** Report Test Desiderata violations as entries in the `issues` array with `category: "test-quality"`.
|
|
168
|
+
|
|
169
|
+
### Step 3: Generate Report
|
|
170
|
+
|
|
171
|
+
Use the template from `references/review-report-template.md` to structure the review output.
|
|
172
|
+
|
|
173
|
+
## Priority Levels
|
|
174
|
+
|
|
175
|
+
| Priority | Action | Examples |
|
|
176
|
+
|----------|--------|----------|
|
|
177
|
+
| **HIGH** | Must fix before merge | Security issues, data loss risks |
|
|
178
|
+
| **MEDIUM** | Should fix, may defer | SOLID violations, complexity |
|
|
179
|
+
| **LOW** | Nice to have | Style preferences, minor refactors |
|
|
180
|
+
|
|
181
|
+
### Priority Classification Rules
|
|
182
|
+
|
|
183
|
+
- **HIGH:** security vulnerabilities, data loss risk, API contract breaks, uncaught exception paths
|
|
184
|
+
- **MEDIUM:** SOLID violations (LSP, ISP), cyclomatic complexity >15, test coverage <70%
|
|
185
|
+
- **LOW:** naming, code style, comment clarity, non-impactful performance
|
|
186
|
+
|
|
187
|
+
If classification is ambiguous, default to MEDIUM and flag for human decision.
|
|
188
|
+
|
|
189
|
+
## Fix Loop for HIGH-Priority
|
|
190
|
+
|
|
191
|
+
If HIGH-priority issues found:
|
|
192
|
+
|
|
193
|
+
1. Create fix task listing each HIGH finding with file, issue, and required fix
|
|
194
|
+
2. Dispatch to implementer subagent
|
|
195
|
+
3. Re-review quality after fixes
|
|
196
|
+
4. Only mark APPROVED when all HIGH items resolved and tests pass
|
|
197
|
+
|
|
198
|
+
**Fix loop iteration limit: max 3.** If HIGH-priority issues persist after 3 fix-review cycles, pause and escalate to the user with a summary of unresolved issues. The user can override: `review --max-fix-iterations 5`
|
|
199
|
+
|
|
200
|
+
### Post-Fix Spec Compliance Check (MANDATORY after fix cycle)
|
|
201
|
+
|
|
202
|
+
After the quality-review fix loop completes and quality passes, re-verify that the quality fixes did not break spec compliance. Run inline (not a full dispatch):
|
|
203
|
+
|
|
204
|
+
1. Run spec verification commands:
|
|
205
|
+
```bash
|
|
206
|
+
npm run test:run
|
|
207
|
+
npm run typecheck
|
|
208
|
+
```
|
|
209
|
+
```typescript
|
|
210
|
+
exarchos_orchestrate({
|
|
211
|
+
action: "check_tdd_compliance",
|
|
212
|
+
featureId: "<featureId>",
|
|
213
|
+
taskId: "<taskId>",
|
|
214
|
+
branch: "<branch>"
|
|
215
|
+
})
|
|
216
|
+
```
|
|
217
|
+
2. If all pass: proceed to APPROVED transition
|
|
218
|
+
3. If any fail: return to NEEDS_FIXES with spec regression noted in issues array
|
|
219
|
+
|
|
220
|
+
## Required Output Format
|
|
221
|
+
|
|
222
|
+
The subagent MUST return results as structured JSON. The orchestrator parses this JSON to populate state. Any other format is an error.
|
|
223
|
+
|
|
224
|
+
```json
|
|
225
|
+
{
|
|
226
|
+
"verdict": "pass | fail | blocked",
|
|
227
|
+
"summary": "1-2 sentence summary",
|
|
228
|
+
"issues": [
|
|
229
|
+
{
|
|
230
|
+
"severity": "HIGH | MEDIUM | LOW",
|
|
231
|
+
"category": "security | solid | dry | perf | naming | test-quality | other",
|
|
232
|
+
"file": "path/to/file",
|
|
233
|
+
"line": 123,
|
|
234
|
+
"description": "Issue description",
|
|
235
|
+
"required_fix": "What must change"
|
|
236
|
+
}
|
|
237
|
+
],
|
|
238
|
+
"test_results": {
|
|
239
|
+
"passed": 0,
|
|
240
|
+
"failed": 0,
|
|
241
|
+
"coverage_percent": 0
|
|
242
|
+
}
|
|
243
|
+
}
|
|
244
|
+
```
|
|
245
|
+
|
|
246
|
+
## Anti-Patterns
|
|
247
|
+
|
|
248
|
+
| Don't | Do Instead |
|
|
249
|
+
|-------|------------|
|
|
250
|
+
| Block on LOW priority | Accept and track for later |
|
|
251
|
+
| Review before spec passes | Complete spec review first |
|
|
252
|
+
| Be overly pedantic | Focus on impactful issues |
|
|
253
|
+
| Skip security checks | Always verify basics |
|
|
254
|
+
| Accept poor test quality | Tests are code too |
|
|
255
|
+
| Apply generic standards to language issues | Reference language-specific rules |
|
|
256
|
+
|
|
257
|
+
## Cross-Task Integration Issues
|
|
258
|
+
|
|
259
|
+
If an issue spans multiple tasks:
|
|
260
|
+
1. Classify as "cross-task integration"
|
|
261
|
+
2. Create fix task specifying ALL affected tasks
|
|
262
|
+
3. Dispatch fix to implementer with context from all affected tasks
|
|
263
|
+
4. Mark original tasks as blocked until cross-task fix completes
|
|
264
|
+
|
|
265
|
+
## State Management
|
|
266
|
+
|
|
267
|
+
> **Key format:** The review key MUST be kebab-case `reviews["quality-review"]`, not camelCase `reviews.qualityReview`. The guard matches on the exact key string.
|
|
268
|
+
|
|
269
|
+
**On review complete:**
|
|
270
|
+
```text
|
|
271
|
+
action: "set", featureId: "<id>", updates: {
|
|
272
|
+
"reviews": { "quality-review": { "status": "pass", "summary": "...", "issues": [...] } }
|
|
273
|
+
}
|
|
274
|
+
```
|
|
275
|
+
|
|
276
|
+
**On all reviews pass — advance to synthesis:**
|
|
277
|
+
```text
|
|
278
|
+
action: "set", featureId: "<id>", phase: "synthesize"
|
|
279
|
+
```
|
|
280
|
+
|
|
281
|
+
### Phase Transitions and Guards
|
|
282
|
+
|
|
283
|
+
For the full transition table, consult `@skills/workflow-state/references/phase-transitions.md`.
|
|
284
|
+
|
|
285
|
+
**Quick reference:**
|
|
286
|
+
- `review` → `synthesize` requires guard `all-reviews-passed` — all `reviews.{name}.status` must be passing
|
|
287
|
+
- `review` → `delegate` requires guard `any-review-failed` — triggers fix cycle when any review fails
|
|
288
|
+
|
|
289
|
+
### Schema Discovery
|
|
290
|
+
|
|
291
|
+
Use `exarchos_workflow({ action: "describe", actions: ["set", "init"] })` for
|
|
292
|
+
parameter schemas and `exarchos_workflow({ action: "describe", playbook: "feature" })`
|
|
293
|
+
for phase transitions, guards, and playbook guidance. Use
|
|
294
|
+
`exarchos_orchestrate({ action: "describe", actions: ["check_static_analysis", "check_security_scan", "check_review_verdict"] })`
|
|
295
|
+
for orchestrate action schemas.
|
|
296
|
+
|
|
297
|
+
## Completion Criteria
|
|
298
|
+
|
|
299
|
+
- [ ] Static analysis passes
|
|
300
|
+
- [ ] All HIGH-priority issues fixed
|
|
301
|
+
- [ ] No security vulnerabilities
|
|
302
|
+
- [ ] Test quality acceptable
|
|
303
|
+
- [ ] Code is maintainable
|
|
304
|
+
- [ ] State file updated with review results
|
|
305
|
+
|
|
306
|
+
### Decision Runbooks
|
|
307
|
+
|
|
308
|
+
For review verdict routing, query the decision runbook:
|
|
309
|
+
`exarchos_orchestrate({ action: "runbook", id: "review-escalation" })`
|
|
310
|
+
|
|
311
|
+
This runbook provides structured criteria for routing between APPROVED and NEEDS_FIXES verdicts based on finding severity and fix cycle count. APPROVED transitions to synthesize; NEEDS_FIXES transitions back to delegate for a fix cycle. (BLOCKED routing is only relevant in plan-review, not here.)
|
|
312
|
+
|
|
313
|
+
## MCP-Served Quality Check Catalog (Tier 2)
|
|
314
|
+
|
|
315
|
+
After Tier 1 MCP gates complete, execute the quality check catalog. This provides deterministic quality checks (grep patterns, structural analysis) that run on **any MCP platform** — no companion plugins required.
|
|
316
|
+
|
|
317
|
+
### Step 2.5: Execute Check Catalog
|
|
318
|
+
|
|
319
|
+
```typescript
|
|
320
|
+
exarchos_orchestrate({ action: "prepare_review", featureId: "<id>" })
|
|
321
|
+
```
|
|
322
|
+
|
|
323
|
+
The response contains:
|
|
324
|
+
- `catalog` — structured check dimensions with grep patterns, structural thresholds, and heuristic instructions
|
|
325
|
+
- `findingFormat` — the TypeScript interface for submitting findings
|
|
326
|
+
- `pluginStatus` — which companion plugins are configured in `.exarchos.yml`
|
|
327
|
+
|
|
328
|
+
Execute each check in the catalog against the codebase:
|
|
329
|
+
- **grep checks:** Run the `pattern` against files matching `fileGlob`
|
|
330
|
+
- **structural checks:** Evaluate against the `threshold` (e.g., nesting depth, function length)
|
|
331
|
+
- **heuristic checks:** Use judgment guided by the `description`
|
|
332
|
+
|
|
333
|
+
Collect all matches as findings in the format specified by `findingFormat`, then pass them as `pluginFindings` to `check_review_verdict`.
|
|
334
|
+
|
|
335
|
+
### Companion Plugin Enhancement (Tier 3 — Platform-Dependent)
|
|
336
|
+
|
|
337
|
+
On platforms with skill support (Claude Code, Cursor), the orchestrator may additionally invoke `axiom:audit` and `impeccable:critique` for deeper qualitative analysis. These findings are also passed as `pluginFindings`. See `references/axiom-integration.md` for the full three-tiered architecture.
|
|
338
|
+
|
|
339
|
+
## Convergence & Verdict
|
|
340
|
+
|
|
341
|
+
Query convergence status and compute verdict via orchestrate. See `references/convergence-and-verdict.md` for full orchestrate calls, response fields, and verdict routing logic.
|
|
342
|
+
|
|
343
|
+
Summary: `check_convergence` returns per-dimension D1-D5 status. `check_review_verdict` takes finding counts and optional `pluginFindings` array (from catalog execution and companion plugins), emits gate events, and returns APPROVED or NEEDS_FIXES.
|
|
344
|
+
|
|
345
|
+
## Auto-Transition
|
|
346
|
+
|
|
347
|
+
All transitions are automatic — no user confirmation. See `references/auto-transition.md` for per-verdict transition details, Skill invocations, and integration notes.
|
|
348
|
+
|
|
349
|
+
### Recording Results
|
|
350
|
+
|
|
351
|
+
Before transitioning, record the review verdict. The reviews value MUST be an object with a `status` field, not a flat string:
|
|
352
|
+
|
|
353
|
+
**APPROVED:**
|
|
354
|
+
```
|
|
355
|
+
exarchos_workflow({ action: "set", featureId: "<id>", updates: {
|
|
356
|
+
reviews: { "quality-review": { status: "pass", summary: "...", issues: [] } }
|
|
357
|
+
}, phase: "synthesize" })
|
|
358
|
+
```
|
|
359
|
+
Then invoke `synthesize`.
|
|
360
|
+
|
|
361
|
+
**NEEDS_FIXES:**
|
|
362
|
+
```
|
|
363
|
+
exarchos_workflow({ action: "set", featureId: "<id>", updates: {
|
|
364
|
+
reviews: { "quality-review": { status: "fail", summary: "...", issues: [{ severity: "HIGH", file: "...", description: "..." }] } }
|
|
365
|
+
}})
|
|
366
|
+
```
|
|
367
|
+
Then invoke `delegate --fixes`.
|
|
368
|
+
|
|
369
|
+
> **Gate events:** Do NOT manually emit `gate.executed` events via `exarchos_event`. Gate events are automatically emitted by the `check_review_verdict` orchestrate handler. Manual emission causes duplicates.
|
|
370
|
+
|
|
371
|
+
> **Guard shape:** The `all-reviews-passed` guard requires `reviews.{name}.status` to be a passing value (`pass`, `passed`, `approved`, `fixes-applied`). Flat strings like `reviews: { "quality-review": "pass" }` are silently ignored and will block the `review → synthesize` transition.
|
|
@@ -0,0 +1,47 @@
|
|
|
1
|
+
# Auto-Transition & Integration
|
|
2
|
+
|
|
3
|
+
## Transition
|
|
4
|
+
|
|
5
|
+
All transitions happen **immediately** without user confirmation:
|
|
6
|
+
|
|
7
|
+
### If APPROVED:
|
|
8
|
+
1. Update state: `action: "set", featureId: "<id>", phase: "synthesize"`
|
|
9
|
+
2. Output: "Quality review passed. Auto-continuing to synthesis..."
|
|
10
|
+
3. Auto-invoke synthesize:
|
|
11
|
+
```typescript
|
|
12
|
+
Skill({ skill: "exarchos:synthesize", args: "<feature-name>" })
|
|
13
|
+
```
|
|
14
|
+
|
|
15
|
+
### If NEEDS_FIXES:
|
|
16
|
+
1. Update state: `action: "set", featureId: "<id>", updates: { "reviews": { "quality-review": { "status": "fail", "issues": [...] } } }`
|
|
17
|
+
2. Output: "Quality review found [N] HIGH-priority issues. Auto-continuing to fixes..."
|
|
18
|
+
3. Auto-invoke delegate with fix tasks:
|
|
19
|
+
```typescript
|
|
20
|
+
Skill({ skill: "exarchos:delegate", args: "--fixes <plan-path>" })
|
|
21
|
+
```
|
|
22
|
+
|
|
23
|
+
### If BLOCKED:
|
|
24
|
+
1. Update state: `action: "set", featureId: "<id>", phase: "blocked"`
|
|
25
|
+
2. Output: "Quality review blocked: [issue]. Returning to design..."
|
|
26
|
+
3. Auto-invoke ideate for redesign:
|
|
27
|
+
```typescript
|
|
28
|
+
Skill({ skill: "exarchos:ideate", args: "--redesign <feature-name>" })
|
|
29
|
+
```
|
|
30
|
+
|
|
31
|
+
Quality-review itself is NOT a human checkpoint — it auto-continues. However, the APPROVED path leads to synthesize, which IS a human checkpoint (`WAIT:human-checkpoint:synthesize`).
|
|
32
|
+
|
|
33
|
+
## Exarchos Integration
|
|
34
|
+
|
|
35
|
+
Gate events are automatically emitted by the orchestrate handlers — do NOT manually emit `gate.executed` events via `exarchos_event`.
|
|
36
|
+
|
|
37
|
+
1. **Read CI status** via `gh pr checks <number>` (or GitHub MCP `pull_request_read` with method `get_status` if available)
|
|
38
|
+
2. **Gate events** — emitted automatically by `check_static_analysis`, `check_security_scan`, `check_context_economy`, `check_operational_resilience`, `check_workflow_determinism`, and `check_review_verdict` handlers
|
|
39
|
+
3. **Read unified status** via `exarchos_view` with `action: "tasks"`, `fields: ["taskId", "status", "title"]`, `limit: 20`
|
|
40
|
+
4. **Query convergence** via `exarchos_view` with `action: "convergence"`, `workflowId: "<featureId>"` for per-dimension gate results
|
|
41
|
+
5. **When all per-PR gates pass**, apply `stack-ready` label to the PR
|
|
42
|
+
|
|
43
|
+
## Performance Notes
|
|
44
|
+
|
|
45
|
+
- Complete each step fully before advancing — quality over speed
|
|
46
|
+
- Do not skip validation checks even when the change appears trivial
|
|
47
|
+
- Read each checklist file completely before scoring. Do not skip security or SOLID checks even for small changes.
|
|
@@ -0,0 +1,135 @@
|
|
|
1
|
+
# Axiom Plugin Integration
|
|
2
|
+
|
|
3
|
+
How the exarchos quality review integrates general backend quality checks — through MCP-served check catalogs (platform-agnostic) and optional companion plugins (platform-dependent). Axiom and impeccable are optional skill libraries that enhance depth when available.
|
|
4
|
+
|
|
5
|
+
## Architecture
|
|
6
|
+
|
|
7
|
+
Quality checks are layered across three tiers, each progressively more platform-dependent:
|
|
8
|
+
|
|
9
|
+
- **Tier 1** (MCP gates): Automated checks via `exarchos_orchestrate` actions. Platform-agnostic.
|
|
10
|
+
- **Tier 2** (MCP-served catalog): `prepare_review` returns structured check patterns that any LLM agent executes. Platform-agnostic.
|
|
11
|
+
- **Tier 3** (Companion skills): `axiom:audit` and `impeccable:critique` provide deeper qualitative analysis. Platform-dependent (Claude Code, Cursor).
|
|
12
|
+
|
|
13
|
+
```text
|
|
14
|
+
Any MCP client (Claude Code, Cursor, generic)
|
|
15
|
+
│
|
|
16
|
+
├── Tier 1: MCP Gates (always, automated)
|
|
17
|
+
│ ├── check_static_analysis (D2 gate)
|
|
18
|
+
│ ├── check_security_scan (D1 gate)
|
|
19
|
+
│ ├── check_context_economy (D3 gate — advisory)
|
|
20
|
+
│ ├── check_workflow_determinism (D5 gate — advisory)
|
|
21
|
+
│ └── Test Desiderata evaluation
|
|
22
|
+
│
|
|
23
|
+
├── Tier 2: MCP-Served Check Catalog (always, agent-executed)
|
|
24
|
+
│ ├── prepare_review → returns catalog as structured data
|
|
25
|
+
│ │ ├── Grep patterns (error handling, type safety, test quality, ...)
|
|
26
|
+
│ │ ├── Structural checks (nesting depth, function length, ...)
|
|
27
|
+
│ │ └── Heuristic instructions (LLM-guided checks)
|
|
28
|
+
│ ├── Agent executes checks against codebase
|
|
29
|
+
│ └── Findings fed as pluginFindings to check_review_verdict
|
|
30
|
+
│
|
|
31
|
+
├── Tier 3: Companion Plugin Skills (platform-dependent, optional)
|
|
32
|
+
│ ├── axiom:audit — deeper qualitative backend analysis (7 dimensions)
|
|
33
|
+
│ ├── impeccable:critique — design quality analysis
|
|
34
|
+
│ └── Findings fed as additional pluginFindings to verdict
|
|
35
|
+
│
|
|
36
|
+
└── Verdict: check_review_verdict merges ALL findings → APPROVED | NEEDS_FIXES
|
|
37
|
+
```
|
|
38
|
+
|
|
39
|
+
## Dimension Ownership Split
|
|
40
|
+
|
|
41
|
+
The quality review draws from three independent sources. Each source owns distinct quality dimensions with no overlap:
|
|
42
|
+
|
|
43
|
+
| Concern | Owner | Rationale |
|
|
44
|
+
|---------|-------|-----------|
|
|
45
|
+
| DIM-1: Topology | Axiom plugin (optional) | General backend quality |
|
|
46
|
+
| DIM-2: Observability | Axiom plugin (optional) | General backend quality |
|
|
47
|
+
| DIM-3: Contracts | Axiom plugin (optional) | General backend quality |
|
|
48
|
+
| DIM-4: Test Fidelity | Axiom plugin (optional) | General backend quality |
|
|
49
|
+
| DIM-5: Hygiene | Axiom plugin (optional) | General backend quality |
|
|
50
|
+
| DIM-6: Architecture | Axiom plugin (optional) | General backend quality |
|
|
51
|
+
| DIM-7: Resilience | Axiom plugin (optional) | General backend quality |
|
|
52
|
+
| D1: Spec Fidelity & TDD | Exarchos (always runs) | Requires workflow state (design, plan, implementation traceability) |
|
|
53
|
+
| D2-domain: Event Sourcing / CQRS / HSM / Saga | Exarchos (always runs) | Domain-specific to event-sourced systems |
|
|
54
|
+
| D3: Context Economy | Exarchos (always runs) | Specific to AI-agent skill systems |
|
|
55
|
+
| D5: Workflow Determinism | Exarchos (always runs) | Specific to workflow orchestration |
|
|
56
|
+
| Design Quality (UI, accessibility, design system, responsive) | Impeccable plugin (optional) | Design-specific concerns |
|
|
57
|
+
|
|
58
|
+
**Key distinction:** Axiom's DIM-1 through DIM-7 are general backend quality dimensions. Exarchos's D1-D5 are workflow-specific dimensions that require access to workflow state. These are complementary, not overlapping.
|
|
59
|
+
|
|
60
|
+
## Detection and Invocation Protocol
|
|
61
|
+
|
|
62
|
+
Plugin detection and invocation is performed by the **orchestrator** (commands/review.md), not by the quality-review subagent. The subagent does not have Skill tool access and should not attempt plugin invocation.
|
|
63
|
+
|
|
64
|
+
### Step 1: Detect Plugin Availability (Orchestrator)
|
|
65
|
+
|
|
66
|
+
After the quality-review subagent returns its verdict, the orchestrator checks for companion plugins in its available skills list:
|
|
67
|
+
|
|
68
|
+
- `axiom:audit` — general backend quality (7 dimensions)
|
|
69
|
+
- `impeccable:critique` — design quality (UI, accessibility, design system, responsive)
|
|
70
|
+
|
|
71
|
+
### Step 2: Check Configuration Override (Orchestrator)
|
|
72
|
+
|
|
73
|
+
Read the project's `.exarchos.yml` for explicit plugin toggles:
|
|
74
|
+
|
|
75
|
+
```yaml
|
|
76
|
+
# .exarchos.yml — plugin overrides
|
|
77
|
+
plugins:
|
|
78
|
+
axiom:
|
|
79
|
+
enabled: true # default when key is absent
|
|
80
|
+
impeccable:
|
|
81
|
+
enabled: true # default when key is absent
|
|
82
|
+
```
|
|
83
|
+
|
|
84
|
+
A plugin is invoked only when BOTH conditions are met:
|
|
85
|
+
1. The skill is present in the available skills list (plugin is installed)
|
|
86
|
+
2. The config does not set `plugins.<name>.enabled: false`
|
|
87
|
+
|
|
88
|
+
If the `plugins` key or any sub-key is absent from `.exarchos.yml`, the default is `enabled: true`.
|
|
89
|
+
|
|
90
|
+
### Step 3: Invoke and Merge (Orchestrator)
|
|
91
|
+
|
|
92
|
+
**axiom:audit invocation:**
|
|
93
|
+
1. `Skill({ skill: "axiom:audit" })` with the diff content and list of changed files
|
|
94
|
+
2. axiom returns findings in Standard Finding Format (`severity`, `dimension`, `file`, `line`, `message`)
|
|
95
|
+
3. Map axiom findings to the unified list:
|
|
96
|
+
- `dimension` (DIM-1 through DIM-7) becomes the category prefix (e.g., `axiom:DIM-1-topology`)
|
|
97
|
+
- `severity` maps directly (HIGH, MEDIUM, LOW)
|
|
98
|
+
- axiom HIGH findings are treated identically to exarchos-native HIGH findings
|
|
99
|
+
|
|
100
|
+
**impeccable:critique invocation:**
|
|
101
|
+
1. `Skill({ skill: "impeccable:critique" })` with the diff content
|
|
102
|
+
2. impeccable returns design quality findings (`severity`, `category`, `file`, `line`, `message`)
|
|
103
|
+
3. Map all impeccable findings under the `design-quality` category
|
|
104
|
+
|
|
105
|
+
**Merge:** Append all plugin findings to the subagent's findings list. The merged list informs verdict escalation.
|
|
106
|
+
|
|
107
|
+
### Step 4: Verdict Escalation (Orchestrator)
|
|
108
|
+
|
|
109
|
+
Compare plugin findings against the subagent's verdict:
|
|
110
|
+
|
|
111
|
+
- If the subagent returned **APPROVED** but plugins found HIGH-severity issues → escalate to **NEEDS_FIXES**
|
|
112
|
+
- If the subagent returned **NEEDS_FIXES** → preserve (plugins may add more findings but verdict is already failing)
|
|
113
|
+
- If no plugins ran → preserve subagent verdict as-is
|
|
114
|
+
|
|
115
|
+
## Graceful Degradation
|
|
116
|
+
|
|
117
|
+
When a plugin is not installed or is disabled, the orchestrator skips it and the review proceeds with exarchos-native checks only. The orchestrator logs a "Plugin Coverage" note in the review output:
|
|
118
|
+
|
|
119
|
+
- **Not installed:** Suggests the install command (`claude plugin install axiom@lvlup-sw` or `claude plugin marketplace add pbakaus/impeccable && claude plugin install impeccable@impeccable`)
|
|
120
|
+
- **Disabled via config:** Notes the config key to re-enable
|
|
121
|
+
- **Active:** Reports the number of dimensions checked and findings produced
|
|
122
|
+
|
|
123
|
+
The subagent's verdict is unaffected by plugin absence — it operates on exarchos-native findings. Plugins can only escalate (APPROVED → NEEDS_FIXES), never downgrade.
|
|
124
|
+
|
|
125
|
+
## Verdict Mapping
|
|
126
|
+
|
|
127
|
+
The verdict uses the merged findings from all sources. The logic is the same regardless of which plugins contributed:
|
|
128
|
+
|
|
129
|
+
| Merged Findings | Verdict |
|
|
130
|
+
|----------------|---------|
|
|
131
|
+
| No HIGH findings, acceptable MEDIUM/LOW | APPROVED |
|
|
132
|
+
| Any HIGH findings in blocking dimensions | NEEDS_FIXES |
|
|
133
|
+
| Critical architectural or security issues | BLOCKED |
|
|
134
|
+
|
|
135
|
+
axiom HIGH findings and exarchos-native HIGH findings carry equal weight — both trigger NEEDS_FIXES when present in blocking dimensions.
|