@lvce-editor/test-with-playwright-worker 22.6.0 → 22.7.0

package/dist/workerMain.js

@@ -1,8 +1,8 @@
 import { join, dirname, basename } from 'node:path';
-import { readFile, writeFile, readdir } from 'node:fs/promises';
+import { readFile, writeFile, readdir, mkdtemp, rm } from 'node:fs/promises';
 import { pathToFileURL } from 'node:url';
 import net from 'node:net';
-import os from 'node:os';
+import os, { tmpdir } from 'node:os';
 import { fork, spawn } from 'node:child_process';
 import { createInterface } from 'node:readline';
 import { createRequire } from 'node:module';
@@ -1755,8 +1755,17 @@ const getElectronLaunchOptions = ({
   };
 };
 
+const getElectronProcessArgs = ({
+  args,
+  platform = process.platform,
+  userDataDir
+}) => {
+  return ['--remote-debugging-port=0', ...(platform === 'linux' ? ['--no-sandbox'] : []), ...args, `--user-data-dir=${userDataDir}`];
+};
+
 const SIGINT = 'SIGINT';
 
+const electronConnectionTimeout = 120_000;
 const devtoolsRegex = /^DevTools listening on (ws:\/\/.*)$/;
 const waitForDevtoolsEndpoint = async child => {
   const {
@@ -1773,10 +1782,13 @@ const waitForDevtoolsEndpoint = async child => {
     reject,
     resolve
   } = Promise.withResolvers();
+  const stderrLines = [];
   const onExit = () => {
-    reject(new Error('Electron exited before DevTools endpoint was available'));
+    const details = stderrLines.length > 0 ? `: ${stderrLines.join('\n')}` : '';
+    reject(new Error(`Electron exited before DevTools endpoint was available${details}`));
   };
   const onLine = line => {
+    stderrLines.push(line);
     const match = line.match(devtoolsRegex);
     if (match) {
       resolve(match[1]);
@@ -1802,24 +1814,50 @@ const getFirstPage = async browser => {
     timeout: 15_000
   });
 };
+const waitForChildExit = async child => {
+  if (child.exitCode !== null || child.signalCode !== null) {
+    return;
+  }
+  await new Promise(resolve => {
+    const timeout = setTimeout(resolve, 5000);
+    child.once('exit', () => {
+      clearTimeout(timeout);
+      resolve();
+    });
+  });
+};
+const stopElectronProcess = async child => {
+  if (child.exitCode === null && child.signalCode === null) {
+    child.kill(SIGINT);
+    await waitForChildExit(child);
+  }
+  if (child.exitCode === null && child.signalCode === null) {
+    child.kill('SIGKILL');
+    await waitForChildExit(child);
+  }
+};
 const closeElectron = async ({
   browser,
-  child
+  child,
+  userDataDir
 }) => {
   try {
     await browser.close();
   } catch {
     // ignore close errors during cleanup
   }
-  if (!child.killed) {
-    child.kill(SIGINT);
-  }
+  await stopElectronProcess(child);
+  await rm(userDataDir, {
+    force: true,
+    recursive: true
+  });
 };
 const createElectronLaunch = ({
   browser,
   child,
   page,
-  signal
+  signal,
+  userDataDir
 }) => {
   let disposed = false;
   const dispose = async () => {
@@ -1832,7 +1870,8 @@ const createElectronLaunch = ({
     process.off('SIGTERM', handleSigterm);
     await closeElectron({
       browser,
-      child
+      child,
+      userDataDir
     });
   };
   const handleAbort = () => {
@@ -1874,7 +1913,12 @@ const startElectron = async ({
   signal
 }) => {
   const launchOptions = getElectronLaunchOptions(runtimeOptions);
-  const child = spawn(launchOptions.executablePath, ['--remote-debugging-port=0', ...launchOptions.args], {
+  const userDataDir = await mkdtemp(join(tmpdir(), 'test-with-playwright-electron-'));
+  const args = getElectronProcessArgs({
+    args: launchOptions.args,
+    userDataDir
+  });
+  const child = spawn(launchOptions.executablePath, args, {
     env: launchOptions.env,
     stdio: ['ignore', 'ignore', 'pipe']
   });
@@ -1884,13 +1928,16 @@ const startElectron = async ({
     const {
       chromium
     } = await import('@playwright/test');
-    browser = await chromium.connectOverCDP(endpoint);
+    browser = await chromium.connectOverCDP(endpoint, {
+      timeout: electronConnectionTimeout
+    });
     const page = await getFirstPage(browser);
     return createElectronLaunch({
       browser,
       child,
       page,
-      signal
+      signal,
+      userDataDir
     });
   } catch (error) {
     if (browser) {
@@ -1900,9 +1947,11 @@ const startElectron = async ({
         // ignore close errors during cleanup
       }
     }
-    if (!child.killed) {
-      child.kill(SIGINT);
-    }
+    await stopElectronProcess(child);
+    await rm(userDataDir, {
+      force: true,
+      recursive: true
+    });
     throw error;
   }
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/test-with-playwright-worker",
-  "version": "22.6.0",
+  "version": "22.7.0",
   "description": "Worker package for test-with-playwright",
   "repository": {
     "type": "git",