@lvce-editor/shared-process 0.86.5 → 0.86.7

package/index.js

@@ -25,7 +25,7 @@ const toAbsoluteExtensionPath = (root, extensionPath) => {
  * @param {{extensionPath?: string, extensionPaths?: string[] | string, testPath?: string, root?: string}} [options]
  */
 export const exportStatic = async (options      = {}) => {
-  const { extensionPath, extensionPaths = [], testPath = '', root = '' } = options
+  const { extensionPath, extensionPaths = [], root = '', testPath = '' } = options
   if (!root) {
     throw new Error(`root argument is required`)
   }
@@ -35,5 +35,5 @@ export const exportStatic = async (options      = {}) => {
   const absoluteExtensionPath = toAbsoluteExtensionPath(root, defaultExtensionPath)
   const absoluteExtensionPaths = extensionPathList.map((extensionPath) => toAbsoluteExtensionPath(root, extensionPath))
   const pathPrefix = process.env.PATH_PREFIX || ''
-  return fn.exportStatic({ root, pathPrefix, extensionPath: absoluteExtensionPath, extensionPaths: absoluteExtensionPaths, testPath })
+  return fn.exportStatic({ extensionPath: absoluteExtensionPath, extensionPaths: absoluteExtensionPaths, pathPrefix, root, testPath })
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/shared-process",
-  "version": "0.86.5",
+  "version": "0.86.7",
   "main": "index.js",
   "type": "module",
   "keywords": [
@@ -19,21 +19,21 @@
   "dependencies": {
     "@lvce-editor/assert": "1.7.0",
     "@lvce-editor/auth-process": "1.8.0",
-    "@lvce-editor/extension-host-helper-process": "0.86.5",
-    "@lvce-editor/ipc": "16.2.0",
+    "@lvce-editor/extension-host-helper-process": "0.86.7",
+    "@lvce-editor/ipc": "16.3.0",
     "@lvce-editor/json-rpc": "8.2.0",
     "@lvce-editor/jsonc-parser": "1.5.0",
     "@lvce-editor/pretty-error": "2.0.0",
     "@lvce-editor/process-explorer": "3.8.0",
-    "@lvce-editor/rpc-registry": "9.32.0",
+    "@lvce-editor/rpc-registry": "9.33.0",
     "@lvce-editor/verror": "1.7.0",
     "is-object": "^1.0.2",
     "xdg-basedir": "^5.1.0"
   },
   "optionalDependencies": {
-    "@lvce-editor/embeds-process": "4.6.0",
+    "@lvce-editor/embeds-process": "4.7.0",
     "@lvce-editor/file-system-process": "5.3.0",
-    "@lvce-editor/file-watcher-process": "4.1.0",
+    "@lvce-editor/file-watcher-process": "4.2.0",
     "@lvce-editor/network-process": "5.2.0",
     "@lvce-editor/preload": "1.5.0",
     "@lvce-editor/preview-process": "11.0.0",

package/src/parts/AppWindow/AppWindow.js

@@ -23,14 +23,14 @@ const getValidatedAppUrl = (url) => {
   return parsedUrl.toString()
 }
 
-export const createAppWindow = async ({ preferences, parsedArgs, workingDirectory, url = DefaultUrl.defaultUrl, preloadUrl }     ) => {
+export const createAppWindow = async ({ parsedArgs, preferences, preloadUrl, url = DefaultUrl.defaultUrl, workingDirectory }     ) => {
   const validatedUrl = getValidatedAppUrl(url)
-  const { width, height } = await Screen.getBounds()
+  const { height, width } = await Screen.getBounds()
   const windowOptions = await GetAppWindowOptions.getAppWindowOptions({
     preferences,
-    screenWidth: width,
-    screenHeight: height,
     preloadUrl,
+    screenHeight: height,
+    screenWidth: width,
   })
   const titleBarItems = GetTitleBarItems.getTitleBarItems()
   return ParentIpc.invoke('AppWindow.createAppWindow', windowOptions, parsedArgs, workingDirectory, titleBarItems, validatedUrl)
@@ -39,7 +39,7 @@ export const createAppWindow = async ({ preferences, parsedArgs, workingDirector
 export const openNew = async (url) => {
   const preferences = await Preferences.getAll()
   const preloadUrl = PreloadUrl.getPreloadUrl()
-  return createAppWindow({ preferences, parsedArgs: [], workingDirectory: '', url, preloadUrl })
+  return createAppWindow({ parsedArgs: [], preferences, preloadUrl, url, workingDirectory: '' })
 }
 
 export const openNewWithUri = async (uri) => {

package/src/parts/ApplyEdit/ApplyEdit.js

@@ -1,5 +1,5 @@
-import * as FileSystem from '../FileSystem/FileSystem.js'
 import * as BulkReplacementContent from '../BulkReplacementContent/BulkReplacementContent.js'
+import * as FileSystem from '../FileSystem/FileSystem.js'
 
 export const applyEdit = async (path, ranges, replacement) => {
   const content = await FileSystem.readFile(path)

package/src/parts/ApplyIncomingIpcResponse/ApplyIncomingIpcResponse.js

@@ -2,13 +2,18 @@ import * as HandleIpc from '../HandleIpc/HandleIpc.js'
 import * as SendIncomingIpc from '../SendIncomingIpc/SendIncomingIpc.js'
 
 export const applyIncomingIpcResponse = async (target, response, ipcId) => {
-  switch (response.type) {
-    case 'handle':
-      HandleIpc.handleIpc(target)
-      break
-    case 'send':
-      return SendIncomingIpc.sendIncomingIpc(target, response, ipcId)
-    default:
-      throw new Error('unexpected response')
+  try {
+    switch (response.type) {
+      case 'handle':
+        HandleIpc.handleIpc(target)
+        break
+      case 'send':
+        await SendIncomingIpc.sendIncomingIpc(target, response, ipcId)
+        break
+      default:
+        throw new Error('unexpected response')
+    }
+  } catch (error) {
+    return error
   }
 }

package/src/parts/AutoUpdaterWindowsNsis/AutoUpdaterWindowsNsis.js

@@ -50,10 +50,10 @@ export const installAndRestart = async (downloadPath) => {
     Logger.info(`[shared-process] spawning nsis update: ${downloadPath}`)
     UpdateState.set(UpdateStateType.Updating)
     const child = spawn(downloadPath, args, {
-      stdio: 'inherit',
       detached: true,
+      stdio: 'inherit',
     })
-    const { type, event } = await GetFirstSpawnedProcessEvent.getFirstSpawnedProcessEvent(child)
+    const { event, type } = await GetFirstSpawnedProcessEvent.getFirstSpawnedProcessEvent(child)
     if (type === FirstNodeWorkerEventType.Error) {
       throw new Error(`Child process error: ${event}`)
     }

package/src/parts/BuiltinExtensionsPath/BuiltinExtensionsPath.js

@@ -3,6 +3,6 @@ import { fileURLToPath } from 'url'
 
 export const getBuiltinExtensionsPath = () => {
   const staticServerPath = fileURLToPath(import.meta.resolve('@lvce-editor/static-server'))
-  const builtinExtensionsPath = join(staticServerPath, '..', '..', 'static', 'c377d49', 'extensions')
+  const builtinExtensionsPath = join(staticServerPath, '..', '..', 'static', '78bafe8', 'extensions')
   return builtinExtensionsPath
 }

package/src/parts/CliModule/CliModule.js

@@ -16,10 +16,10 @@ export const getModule = (parsedArgs) => {
   switch (argv0) {
     case CliCommandType.Install:
       return import('../CliInstall/CliInstall.js')
-    case CliCommandType.List:
-      return import('../CliList/CliList.js')
     case CliCommandType.Link:
       return import('../CliLink/CliLink.js')
+    case CliCommandType.List:
+      return import('../CliList/CliList.js')
     case CliCommandType.Unlink:
       return import('../CliUnlink/CliUnlink.js')
     default:

package/src/parts/ColorTheme/ColorTheme.js

@@ -2,9 +2,9 @@ import * as JoinLines from '../JoinLines/JoinLines.js'
 
 export const getColorThemeJson = async () => {
   return {
+    FocusOutline: `#3d5252`,
     MainBackground: '#1e2324',
     TreeItemForeground: ` rgb(188, 190, 190)`,
-    FocusOutline: `#3d5252`,
   }
 }
 

package/src/parts/Command/Command.js

@@ -4,8 +4,8 @@ import { VError } from '../VError/VError.js'
 
 export const state      = {
   commands: Object.create(null),
-  pendingModules: Object.create(null),
   async load(moduleId)               {},
+  pendingModules: Object.create(null),
 }
 
 const initializeModule = (module) => {

package/src/parts/Crash/Crash.js

@@ -1,5 +1,5 @@
-import * as Timeout from '../Timeout/Timeout.js'
 import * as ParentIpc from '../MainProcess/MainProcess.js'
+import * as Timeout from '../Timeout/Timeout.js'
 
 const handleTimeout = () => {
   throw new Error('oops')

package/src/parts/CreateTestOverviewHtml/CreateTestOverviewHtml.js

@@ -1,3 +1,5 @@
+const testFileExtensionRegex = /\.(js|ts)$/
+
 const isTestFile = (dirent) => {
   if (dirent.startsWith('_')) {
     return false
@@ -6,7 +8,7 @@ const isTestFile = (dirent) => {
 }
 
 const toTestName = (dirent) => {
-  return dirent.replace(/\.(js|ts)$/, '')
+  return dirent.replace(testFileExtensionRegex, '')
 }
 
 export const createTestOverviewHtml = (dirents) => {

package/src/parts/DefaultUrl/DefaultUrl.js

@@ -1,4 +1,4 @@
-import * as Platform from '../Platform/Platform.js'
 import * as Authority from '../Authority/Authority.js'
+import * as Platform from '../Platform/Platform.js'
 
 export const defaultUrl = `${Platform.scheme}://${Authority.Authority}/`

package/src/parts/DownloadAndExtract/DownloadAndExtract.js

@@ -1,5 +1,5 @@
 import * as NetworkProcess from '../NetworkProcess/NetworkProcess.js'
 
-export const downloadAndExtractTarGz = async ({ url, outDir, strip }     ) => {
-  return NetworkProcess.invoke('Download.downloadAndExtractTarGz', { url, outDir, strip })
+export const downloadAndExtractTarGz = async ({ outDir, strip, url }     ) => {
+  return NetworkProcess.invoke('Download.downloadAndExtractTarGz', { outDir, strip, url })
 }

package/src/parts/ElectronInitialize/ElectronInitialize.js

@@ -4,8 +4,8 @@ import * as IpcChildType from '../IpcChildType/IpcChildType.js'
 
 export const electronInitialize = async (port, folder) => {
   const ipc = await IpcChild.listen({
-    method: IpcChildType.NodeMessagePort,
     messagePort: port,
+    method: IpcChildType.NodeMessagePort,
   })
   HandleIpc.handleIpc(ipc)
 }

package/src/parts/ElectronWindowProcessExplorer/ElectronWindowProcessExplorer.js

@@ -2,23 +2,23 @@ import { writeFile } from 'node:fs/promises'
 import { tmpdir } from 'node:os'
 import { join } from 'node:path'
 import * as ColorTheme from '../ColorTheme/ColorTheme.js'
-import * as PreloadUrl from '../PreloadUrl/PreloadUrl.js'
 import * as GetProcessExplorerUrl from '../GetProcessExplorerUrl/GetProcessExplorerUrl.js'
 import * as ParentIpc from '../MainProcess/MainProcess.js'
+import * as PreloadUrl from '../PreloadUrl/PreloadUrl.js'
 
 const getOptions = async (colorThemeJson) => {
   const backgroundColor = colorThemeJson.MainBackground
   const preload = PreloadUrl.getPreloadUrl()
   const options = {
-    width: 800,
-    height: 500,
     backgroundColor,
+    height: 500,
     webPreferences: {
+      additionalArguments: ['--lvce-window-kind=process-explorer'],
       preload,
       sandbox: true,
-      additionalArguments: ['--lvce-window-kind=process-explorer'],
       spellcheck: false,
     },
+    width: 800,
   }
   return options
 }

package/src/parts/ErrorHandling/ErrorHandling.js

@@ -14,8 +14,8 @@ export const state      = {
 const preparePrettyError = (error) => {
   const cause = error.cause()
   return {
-    message: error.message,
     codeFrame: cause.codeFrame,
+    message: error.message,
     stack: cause.stack,
   }
 }

package/src/parts/ExecCommand/ExecCommand.js

@@ -4,10 +4,10 @@ import * as ExecPromise from '../ExecPromise/ExecPromise.js'
 import * as Hash from '../Hash/Hash.js'
 
 export const execCommand = async (command, args, options) => {
-  const { stdout, stderr } = await ExecPromise.execPromise(command, args, options)
+  const { stderr, stdout } = await ExecPromise.execPromise(command, args, options)
   return {
-    stdout,
     stderr,
+    stdout,
   }
 }
 

package/src/parts/ExportStatic/ExportStatic.js

@@ -1,12 +1,15 @@
 import { existsSync } from 'node:fs'
+import { readdir, readFile, rm, writeFile } from 'node:fs/promises'
 import { stripTypeScriptTypes } from 'node:module'
 import { isAbsolute, join, relative } from 'node:path'
+import workers from '../Workers/Workers.json' with { type: 'json' }
 import * as FileSystem from '../FileSystem/FileSystem.js'
 import * as GetContentSecurityPolicy from '../GetContentSecurityPolicy/GetContentSecurityPolicy.js'
 import * as JsonFile from '../JsonFile/JsonFile.js'
 import * as Path from '../Path/Path.js'
-import { readdir, readFile, rm, writeFile } from 'node:fs/promises'
-import workers from '../Workers/Workers.json' with { type: 'json' }
+
+const testFileExtensionRegex = /\.(js|ts)$/
+const backslashRegex = /\\/g
 
 const staticContentSecurityPolicy = GetContentSecurityPolicy.getContentSecurityPolicy([
   `default-src 'none'`,
@@ -123,7 +126,7 @@ const copyStaticFiles = async (root, serverStaticPath) => {
   await FileSystem.copy(serverStaticPath, Path.join(root, 'dist'))
 }
 
-const applyOverridesRendererProcess = async ({ root, commitHash, pathPrefix }     ) => {
+const applyOverridesRendererProcess = async ({ commitHash, pathPrefix, root }     ) => {
   await replace(
     Path.join(root, 'dist', commitHash, 'packages', 'renderer-process', 'dist', 'rendererProcessMain.js'),
     'platform = Remote;',
@@ -136,9 +139,9 @@ const applyOverridesRendererProcess = async ({ root, commitHash, pathPrefix }
   )
 }
 
-const applyOverrides = async ({ root, commitHash, pathPrefix, serverStaticPath }     ) => {
+const applyOverrides = async ({ commitHash, pathPrefix, root, serverStaticPath }     ) => {
   const extensionHostWorkerDistPath = getWorkerDistPath(root, commitHash, 'extensionHostWorker')
-  await applyOverridesRendererProcess({ root, commitHash, pathPrefix })
+  await applyOverridesRendererProcess({ commitHash, pathPrefix, root })
   await replace(
     Path.join(root, 'dist', commitHash, 'packages', 'renderer-worker', 'dist', 'rendererWorkerMain.js'),
     'platform = Remote;',
@@ -263,7 +266,7 @@ const applyOverrides = async ({ root, commitHash, pathPrefix, serverStaticPath }
   }
 }
 
-const addExtensionSeo = async ({ root, name, description, commitHash }     ) => {
+const addExtensionSeo = async ({ commitHash, description, name, root }     ) => {
   await replace(Path.join(root, 'dist', 'index.html'), '<title>Lvce Editor</title>', `<title>${name}</title>`)
   await replace(Path.join(root, 'dist', commitHash, 'manifest.json'), `"name": "Code Editor Web - OSS"`, `"name": "${name}"`)
   await replace(Path.join(root, 'dist', commitHash, 'manifest.json'), `"short_name": "Web - OSS"`, `"short_name": "${name}"`)
@@ -279,7 +282,7 @@ const getId = (object) => {
   return object.id
 }
 
-const addExtensionThemes = async ({ root, extensionPath, extensionJson, commitHash }     ) => {
+const addExtensionThemes = async ({ commitHash, extensionJson, extensionPath, root }     ) => {
   const colorThemes = extensionJson.colorThemes || []
   if (colorThemes.length === 0) {
     return
@@ -336,7 +339,7 @@ const toPlaygroundFile = (file) => {
   return `/playground/${file}`
 }
 
-const addExtensionLanguages = async ({ root, extensionPath, extensionJson, commitHash, pathPrefix }     ) => {
+const addExtensionLanguages = async ({ commitHash, extensionJson, extensionPath, pathPrefix, root }     ) => {
   const languages = extensionJson.languages || []
   if (languages.length === 0) {
     return
@@ -395,7 +398,7 @@ export const mergeExtensionManifests = (manifests, extraExtensions) => {
   return merged
 }
 
-const updateExtensionsJson = async ({ root, commitHash, pathPrefix, extraExtensions }     ) => {
+const updateExtensionsJson = async ({ commitHash, extraExtensions, pathPrefix, root }     ) => {
   const dirents = await FileSystem.readDir(Path.join(root, 'dist', commitHash, 'extensions'))
   const manifests = await Promise.all(
     dirents.map(async (dirent) => {
@@ -418,14 +421,14 @@ const updateExtensionsJson = async ({ root, commitHash, pathPrefix, extraExtensi
 }
 
 const addExtensionWebExtension = async ({
-  root,
-  extensionPath,
   commitHash,
   extensionJson,
+  extensionPath,
   pathPrefix,
+  root,
   useSimpleWebExtensionFile,
 }     ) => {
-  await updateExtensionsJson({ root, commitHash, pathPrefix, extraExtensions: [extensionJson] })
+  await updateExtensionsJson({ commitHash, extraExtensions: [extensionJson], pathPrefix, root })
 
   if (!extensionJson.browser) {
     return
@@ -450,36 +453,36 @@ const addExtensionWebExtension = async ({
   }
 }
 
-const addExtension = async ({ root, extensionPath, commitHash, pathPrefix, useSimpleWebExtensionFile }     ) => {
+const addExtension = async ({ commitHash, extensionPath, pathPrefix, root, useSimpleWebExtensionFile }     ) => {
   const extensionJson = await readExtensionManifest(Path.join(extensionPath, 'extension.json'))
   const name = extensionJson.name || extensionJson.id || ''
   const description = extensionJson.description || ''
   await addExtensionSeo({
-    root,
     commitHash,
-    name,
     description,
+    name,
+    root,
   })
   await addExtensionThemes({
-    root,
     commitHash,
     extensionJson,
     extensionPath,
+    root,
   })
   await addExtensionLanguages({
-    root,
-    extensionPath,
     commitHash,
     extensionJson,
+    extensionPath,
     pathPrefix,
+    root,
   })
 
   await addExtensionWebExtension({
-    root,
-    extensionPath,
     commitHash,
     extensionJson,
+    extensionPath,
     pathPrefix,
+    root,
     useSimpleWebExtensionFile,
   })
 }
@@ -513,7 +516,7 @@ const generateTestOverviewHtml = (dirents) => {
 }
 
 const getName = (name) => {
-  return name.replace(/\.(js|ts)$/, '')
+  return name.replace(testFileExtensionRegex, '')
 }
 const isTestFile = (file) => {
   if (file.startsWith('_')) {
@@ -549,7 +552,7 @@ const transpileFiles = async (folder) => {
 export const createFilemap = async (fixturesPath) => {
   const filemap                      = {}
 
-  const dirents = await readdir(fixturesPath, { withFileTypes: true, recursive: true })
+  const dirents = await readdir(fixturesPath, { recursive: true, withFileTypes: true })
 
   for (const dirent of dirents) {
     if (dirent.isFile()) {
@@ -561,8 +564,8 @@ export const createFilemap = async (fixturesPath) => {
       } else {
         // Manually calculate relative path for cross-platform compatibility
         // Remove the fixturesPath prefix from parentPath and normalize separators
-        const normalizedFixturesPath = fixturesPath.replace(/\\/g, '/')
-        const normalizedParentPath = dirent.parentPath.replace(/\\/g, '/')
+        const normalizedFixturesPath = fixturesPath.replace(backslashRegex, '/')
+        const normalizedParentPath = dirent.parentPath.replace(backslashRegex, '/')
         const relativeDir = normalizedParentPath.replace(normalizedFixturesPath + '/', '')
         relativeFilePath = join(relativeDir, dirent.name)
       }
@@ -592,7 +595,7 @@ export const createFilemapsPerFixture = async (fixturesPath) => {
   )
 }
 
-const addTestFiles = async ({ testPath, commitHash, root, pathPrefix }     ) => {
+const addTestFiles = async ({ commitHash, pathPrefix, root, testPath }     ) => {
   const testRoot = isAbsolute(testPath) ? testPath : join(root, testPath)
   await FileSystem.copy(`${testRoot}/src`, `${root}/dist/${commitHash}/packages/extension-host-worker-tests/src`)
   if (existsSync(`${testRoot}/fixtures`)) {
@@ -677,13 +680,13 @@ const getExtensionPaths = (extensionPath, extensionPaths) => {
  * @param {{root:string, pathPrefix:string, extensionPath:string, extensionPaths?:string[], testPath:string, useSimpleWebExtensionFile?:boolean, serverStaticPath?:string }} param0
  */
 export const exportStatic = async ({
-  root,
-  pathPrefix,
   extensionPath,
   extensionPaths,
+  pathPrefix,
+  root,
+  serverStaticPath,
   testPath,
   useSimpleWebExtensionFile,
-  serverStaticPath,
 }     ) => {
   if (!existsSync(root)) {
     throw new Error(`root path does not exist: ${root}`)
@@ -720,20 +723,20 @@ export const exportStatic = async ({
 
   console.time('applyOverrides')
   await applyOverrides({
-    root,
     commitHash,
     pathPrefix,
+    root,
     serverStaticPath,
   })
   console.timeEnd('applyOverrides')
 
-  await updateExtensionsJson({ root, commitHash, pathPrefix, extraExtensions: [] })
+  await updateExtensionsJson({ commitHash, extraExtensions: [], pathPrefix, root })
 
   for (const extensionPath of allExtensionPaths) {
     console.time('addExtension')
     await addExtension({
-      extensionPath,
       commitHash,
+      extensionPath,
       pathPrefix,
       root,
       useSimpleWebExtensionFile,
@@ -744,10 +747,10 @@ export const exportStatic = async ({
   if (testPath) {
     console.time('addTestFiles')
     await addTestFiles({
-      testPath,
       commitHash,
       pathPrefix,
       root,
+      testPath,
     })
     console.timeEnd('addTestFiles')
   }

package/src/parts/ExtensionHostHelperProcessIpc/ExtensionHostHelperProcessIpc.js

@@ -1,15 +1,15 @@
+import * as Id from '../Id/Id.js'
 import * as IpcParent from '../IpcParent/IpcParent.js'
 import * as PlatformPaths from '../PlatformPaths/PlatformPaths.js'
-import * as Id from '../Id/Id.js'
 
 export const create = async ({ method }     ) => {
   const extensionHostHelperProcessPath = await PlatformPaths.getExtensionHostHelperProcessPath()
   const id = Id.create()
   const ipc = await IpcParent.create({
-    method,
-    path: extensionHostHelperProcessPath,
     execArgv: [],
+    method,
     name: `Extension Host Helper Process ${id}`,
+    path: extensionHostHelperProcessPath,
   })
   return ipc
 }

package/src/parts/ExtensionHostRpc/ExtensionHostRpc.js

@@ -1,7 +1,7 @@
 import * as Assert from '../Assert/Assert.js'
+import * as Logger from '../Logger/Logger.js'
 import * as Timeout from '../Timeout/Timeout.js'
 import { VError } from '../VError/VError.js'
-import * as Logger from '../Logger/Logger.js'
 // TODO maybe rename to extension host management for clarity
 
 const CONNECTION_TIMEOUT = 3000
@@ -69,14 +69,14 @@ export const create = async (ipc, socket) => {
   })
 
   return {
+    dispose()      {
+      ipc.dispose()
+    },
     on(event, listener)      {
       ipc.on(event, listener)
     },
     send(message)      {
       ipc.send(message)
     },
-    dispose()      {
-      ipc.dispose()
-    },
   }
 }

package/src/parts/ExtensionInstall/ExtensionInstall.js

@@ -3,12 +3,12 @@ import * as ExtensionInstallType from '../ExtensionInstallType/ExtensionInstallT
 
 const getModule = (type) => {
   switch (type) {
+    case ExtensionInstallType.File:
+      return import('../ExtensionInstallFromFile/ExtensionInstallFromFile.js')
     case ExtensionInstallType.GithubRepository:
       return import('../ExtensionInstallFromGitHub/ExtensionInstallFromGitHub.js')
     case ExtensionInstallType.Url:
       return import('../ExtensionInstallFromUrl/ExtensionInstallFromUrl.js')
-    case ExtensionInstallType.File:
-      return import('../ExtensionInstallFromFile/ExtensionInstallFromFile.js')
     default:
       throw new Error('module not found')
   }

package/src/parts/ExtensionInstallFromGitHub/ExtensionInstallFromGitHub.js

@@ -5,15 +5,15 @@ import * as Path from '../Path/Path.js'
 import * as PlatformPaths from '../PlatformPaths/PlatformPaths.js'
 import { VError } from '../VError/VError.js'
 
-export const install = async ({ user, repo, branch }     ) => {
+export const install = async ({ branch, repo, user }     ) => {
   try {
     const cachedExtensionsPath = PlatformPaths.getCachedExtensionsPath()
     const url = `https://codeload.github.com/${user}/${repo}/tar.gz/${branch}`
     const cachedExtensionPath = Path.join(cachedExtensionsPath, `github-${user}-${repo}-${branch}`)
     await DownloadAndExtract.downloadAndExtractTarGz({
-      url,
       outDir: cachedExtensionPath,
       strip: 1,
+      url,
     })
     const extensionsPath = PlatformPaths.getExtensionsPath()
     const manifestPath = Path.join(cachedExtensionPath, 'extension.json')

package/src/parts/ExtensionInstallFromUrl/ExtensionInstallFromUrl.js

@@ -24,7 +24,7 @@ export const install = async ({ url }     ) => {
       throw new Error('missing id in extension manifest')
     }
     const outDir = join(extensionsPath, id)
-    await rm(outDir, { recursive: true, force: true })
+    await rm(outDir, { force: true, recursive: true })
     await mkdir(dirname(outDir), { recursive: true })
     await rename(tmpDir, outDir)
   } catch (error) {

package/src/parts/ExtensionInstallParseInput/ExtensionInstallParseInput.js

@@ -1,6 +1,6 @@
 import * as ExtensionInstallType from '../ExtensionInstallType/ExtensionInstallType.js'
-import * as Path from '../Path/Path.js'
 import * as ParseUrlGithub from '../ParseUrlGithub/ParseUrlGithub.js'
+import * as Path from '../Path/Path.js'
 
 const parseUrl = (input) => {
   if (input.startsWith('https://github.com')) {
@@ -8,26 +8,26 @@ const parseUrl = (input) => {
   }
   if (input.endsWith('.tar.br')) {
     return {
-      type: ExtensionInstallType.Url,
       options: {
         url: input,
       },
+      type: ExtensionInstallType.Url,
     }
   }
   return {
-    type: ExtensionInstallType.ParsingError,
     options: {
       message: 'Failed to parse url',
     },
+    type: ExtensionInstallType.ParsingError,
   }
 }
 
 const parseFile = (input) => {
   return {
-    type: ExtensionInstallType.File,
     options: {
       path: input,
     },
+    type: ExtensionInstallType.File,
   }
 }
 
@@ -42,9 +42,9 @@ export const parse = (input) => {
     return parseFile(input)
   }
   return {
-    type: ExtensionInstallType.ParsingError,
     options: {
       message: 'Failed to parse input',
     },
+    type: ExtensionInstallType.ParsingError,
   }
 }