@lvce-editor/shared-process 0.12.1 → 0.14.0

package/src/parts/ChromeExtension/ChromeExtension.js

@@ -1,10 +1,10 @@
-import VError from 'verror'
 import * as Assert from '../Assert/Assert.js'
 import * as Download from '../Download/Download.js'
 import * as ExtractZip from '../ExtractZip/ExtractZip.js'
 import * as FileSystem from '../FileSystem/FileSystem.js'
 import * as Path from '../Path/Path.js'
 import * as Platform from '../Platform/Platform.js'
+import { VError } from '../VError/VError.js'
 
 const getExtensionPath = async (tmpDir) => {
   const dirents = await FileSystem.readDirWithFileTypes(tmpDir)
@@ -19,10 +19,7 @@ export const install = async (name, url) => {
     Assert.string(name)
     Assert.string(url)
     const cachedChromeExtensionsPath = Platform.getCachedExtensionsPath()
-    const tempFileCompressed = Path.join(
-      cachedChromeExtensionsPath,
-      `${name}.zip`
-    )
+    const tempFileCompressed = Path.join(cachedChromeExtensionsPath, `${name}.zip`)
     const tmpDir = Path.join(cachedChromeExtensionsPath, name)
     const chromeExtensionsPath = Platform.getChromeExtensionsPath()
     await Download.download(url, tempFileCompressed)

package/src/parts/CleanStack/CleanStack.js

@@ -1,5 +1,93 @@
-import npmCleanStack from 'clean-stack'
+import * as SplitLines from '../SplitLines/SplitLines.js'
+
+const RE_AT = /^\s+at/
+const RE_AT_PROMISE_INDEX = /^\s*at async Promise.all \(index \d+\)$/
+const RE_OBJECT_AS = /^\s*at (async )?Object\.\w+ \[as ([\w\.]+)\]/
+const RE_GET_RESPONSE = /^\s*at async getResponse/
+const RE_WEBSOCKET_HANDLE_MESSAGE = /^\s*at async WebSocket.handleMessage/
+const RE_EXECUTE_COMMAND_ASYNC = /^\s*at executeCommandAsync/
+const RE_HANDLE_OTHER_MESSAGES_FROM_MESSAGE_PORT = /^\s*at async MessagePort\.handleOtherMessagesFromMessagePort/
+
+const isInternalLine = (line) => {
+  return line.includes('node:') || RE_AT_PROMISE_INDEX.test(line) || line.includes('node_modules/ws')
+}
+
+const isRelevantLine = (line) => {
+  return !isInternalLine(line)
+}
+
+const isApplicationUsefulLine = (line, index) => {
+  if (index === 0) {
+    return true
+  }
+  if (RE_GET_RESPONSE.test(line)) {
+    return false
+  }
+  if (RE_WEBSOCKET_HANDLE_MESSAGE.test(line)) {
+    return false
+  }
+  if (RE_EXECUTE_COMMAND_ASYNC.test(line)) {
+    return false
+  }
+  if (RE_HANDLE_OTHER_MESSAGES_FROM_MESSAGE_PORT.test(line)) {
+    return false
+  }
+  return true
+}
+
+const isNormalStackLine = (line) => {
+  return RE_AT.test(line) && !RE_AT_PROMISE_INDEX.test(line)
+}
+
+const cleanLine = (line) => {
+  if (line.startsWith('    at exports.')) {
+    return '    at ' + line.slice('    at exports.'.length)
+  }
+  if (line.startsWith('    at async exports.')) {
+    return '    at async ' + line.slice('    at async exports.'.length)
+  }
+  if (line.startsWith('    at async Module.')) {
+    return '    at async ' + line.slice('    at async Module.'.length)
+  }
+  if (line.startsWith('    at Module.')) {
+    return '    at ' + line.slice('    at Module.'.length)
+  }
+  const objectMatch = line.match(RE_OBJECT_AS)
+  if (objectMatch) {
+    const rest = line.slice(objectMatch[0].length)
+    if (objectMatch[1]) {
+      return '    at ' + objectMatch[1] + objectMatch[2] + rest
+    }
+    return '    at ' + objectMatch[2] + rest
+  }
+  return line
+}
+
+const getDetails = (lines) => {
+  const index = lines.findIndex(isNormalStackLine)
+  return {
+    custom: lines.slice(0, index),
+    actualStack: lines.slice(index).map(cleanLine),
+  }
+}
+
+const RE_PATH_1 = /^\/(.*)(\d+)$/
+
+const mergeCustom = (custom, relevantStack) => {
+  if (custom.length === 0) {
+    return relevantStack
+  }
+  const firstLine = custom[0]
+  if (RE_PATH_1.test(firstLine)) {
+    return [`    at ${firstLine}`, ...relevantStack]
+  }
+  return relevantStack
+}
 
 export const cleanStack = (stack) => {
-  return npmCleanStack(stack)
+  const lines = SplitLines.splitLines(stack)
+  const { custom, actualStack } = getDetails(lines)
+  const relevantStack = actualStack.filter(isRelevantLine).filter(isApplicationUsefulLine)
+  const merged = mergeCustom(custom, relevantStack)
+  return merged
 }

package/src/parts/CliList/CliList.js

@@ -3,6 +3,9 @@ import * as JoinLines from '../JoinLines/JoinLines.js'
 import * as Logger from '../Logger/Logger.js'
 
 const getOutputLine = (extension) => {
+  if (extension.symlink) {
+    return `${extension.id} -> ${extension.symlink}`
+  }
   return `${extension.id}: ${extension.version}`
 }
 

package/src/parts/ClipBoard/ClipBoard.js

@@ -1,8 +1,8 @@
-import * as Platform from '../Platform/Platform.js'
+import * as Desktop from '../Desktop/Desktop.js'
 import * as DesktopType from '../DesktopType/DesktopType.js'
 
 const getClipboard = () => {
-  const desktop = Platform.getDesktop()
+  const desktop = Desktop.getDesktop()
   switch (desktop) {
     case DesktopType.Gnome:
       return import('./ClipBoardGnome.js')

package/src/parts/ClipBoard/ClipBoardGnome.js

@@ -2,10 +2,10 @@
 // see also http://manpages.ubuntu.com/manpages/bionic/man1/xclip.1.html
 // on gnome, get current selection targets with `xclip -selection clipboard -t TARGETS -o`
 
-import VError from 'verror'
 import * as Exec from '../Exec/Exec.js'
 import * as JoinLines from '../JoinLines/JoinLines.js'
 import * as SplitLines from '../SplitLines/SplitLines.js'
+import { VError } from '../VError/VError.js'
 
 const removePrefix = (file) => {
   if (file.startsWith('file://')) {
@@ -57,7 +57,6 @@ export const writeFiles = async (type, files) => {
       input: plainContent,
     })
   } catch (error) {
-    // @ts-ignore
     throw new VError(error, 'Failed to copy files to clipboard')
   }
 }

package/src/parts/ClipBoard/ClipBoardNoop.js

@@ -1,4 +1,4 @@
-import * as Platform from '../Platform/Platform.js'
+import * as Desktop from '../Desktop/Desktop.js'
 
 export const readFiles = async () => {
   return {
@@ -9,6 +9,6 @@ export const readFiles = async () => {
 }
 
 export const writeFiles = (type, files) => {
-  const desktop = Platform.getDesktop()
+  const desktop = Desktop.getDesktop()
   console.info(`writing files to clipboard is not yet supported on ${desktop}`)
 }

package/src/parts/ClipBoard/ClipBoardWindows.js

@@ -1,6 +1,5 @@
 import clipboardEx from 'electron-clipboard-ex'
-
-import VError from 'verror'
+import { VError } from '../VError/VError.js'
 
 export const readFiles = async () => {
   const filePaths = clipboardEx.readFilePaths()
@@ -16,7 +15,6 @@ export const writeFiles = async (type, files) => {
   try {
     clipboardEx.writeFilePaths(files)
   } catch (error) {
-    // @ts-ignore
     throw new VError(error, 'Failed to copy files to clipboard')
   }
 }

package/src/parts/Command/Command.js

@@ -1,3 +1,4 @@
+import { CommandNotFoundError } from '../CommandNotFoundError/CommandNotFoundError.js'
 import * as ModuleMap from '../ModuleMap/ModuleMap.js'
 import { VError } from '../VError/VError.js'
 
@@ -19,9 +20,7 @@ const initializeModule = (module) => {
     }
     return
   }
-  throw new Error(
-    `module ${module.name} is missing an initialize function and commands`
-  )
+  throw new Error(`module ${module.name} is missing an initialize function and commands`)
 }
 
 const loadModule = async (moduleId) => {
@@ -29,11 +28,7 @@ const loadModule = async (moduleId) => {
     const module = await state.load(moduleId)
     initializeModule(module)
   } catch (error) {
-    if (
-      error &&
-      error instanceof SyntaxError &&
-      error.stack === `SyntaxError: ${error.message}`
-    ) {
+    if (error && error instanceof SyntaxError && error.stack === `SyntaxError: ${error.message}`) {
       Error.captureStackTrace(error, loadModule)
     }
     throw new VError(error, `failed to load module ${moduleId}`)
@@ -68,9 +63,9 @@ const executeCommandAsync = async (command, ...args) => {
       return
     }
     hasThrown.add(command)
-    throw new Error(`Command did not register "${command}"`)
+    throw new CommandNotFoundError(command)
   }
-  return execute(command, ...args)
+  return state.commands[command](...args)
 }
 
 export const execute = (command, ...args) => {

package/src/parts/Credentials/Credentials.ipc.js

@@ -1,9 +1,9 @@
 import * as Credentials from './Credentials.js'
 
 export const Commands = {
-  801: Credentials.getPassword,
-  802: Credentials.setPassword,
-  803: Credentials.deletePassword,
-  804: Credentials.findPassword,
-  805: Credentials.findCredentials,
+  getPassword: Credentials.getPassword,
+  setPassword: Credentials.setPassword,
+  deletePassword: Credentials.deletePassword,
+  findPassword: Credentials.findPassword,
+  findCredentials: Credentials.findCredentials,
 }

package/src/parts/Credentials/Credentials.js

@@ -1,5 +1,5 @@
 import keytar from 'keytar'
-import VError from 'verror'
+import { VError } from '../VError/VError.js'
 
 /**
  * @param {string} service
@@ -9,7 +9,6 @@ export const deletePassword = async (service, account) => {
   try {
     return await keytar.deletePassword(service, account)
   } catch (error) {
-    // @ts-ignore
     throw new VError(error, `Failed to delete password from service ${service}`)
   }
 }
@@ -21,11 +20,7 @@ export const findCredentials = async (service) => {
   try {
     return keytar.findCredentials(service)
   } catch (error) {
-    throw new VError(
-      // @ts-ignore
-      error,
-      `Failed to find credentials from service ${service}`
-    )
+    throw new VError(error, `Failed to find credentials from service ${service}`)
   }
 }
 
@@ -36,7 +31,6 @@ export const findPassword = async (service) => {
   try {
     return await keytar.findPassword(service)
   } catch (error) {
-    // @ts-ignore
     throw new VError(error, `Failed to find password from service ${service}`)
   }
 }
@@ -49,7 +43,6 @@ export const getPassword = async (service, account) => {
   try {
     return await keytar.getPassword(service, account)
   } catch (error) {
-    // @ts-ignore
     throw new VError(error, `Failed to get password from service ${service}`)
   }
 }
@@ -63,7 +56,6 @@ export const setPassword = async (service, account, password) => {
   try {
     return await keytar.setPassword(service, account, password)
   } catch (error) {
-    // @ts-ignore
     throw new VError(error, `Failed to set password for service ${service}`)
   }
 }

package/src/parts/Desktop/Desktop.js

@@ -0,0 +1,22 @@
+import * as DesktopType from '../DesktopType/DesktopType.js'
+import * as Platform from '../Platform/Platform.js'
+
+export const getDesktop = () => {
+  const { ORIGINAL_XDG_CURRENT_DESKTOP, XDG_CURRENT_DESKTOP } = process.env
+  if (ORIGINAL_XDG_CURRENT_DESKTOP && ORIGINAL_XDG_CURRENT_DESKTOP !== 'undefined') {
+    if (ORIGINAL_XDG_CURRENT_DESKTOP === 'ubuntu:GNOME') {
+      return DesktopType.Gnome
+    }
+    return ORIGINAL_XDG_CURRENT_DESKTOP
+  }
+  if (XDG_CURRENT_DESKTOP) {
+    if (XDG_CURRENT_DESKTOP === 'ubuntu:GNOME') {
+      return DesktopType.Gnome
+    }
+    return XDG_CURRENT_DESKTOP
+  }
+  if (Platform.isWindows) {
+    return DesktopType.Windows
+  }
+  return DesktopType.Unknown
+}

package/src/parts/Download/Download.js

@@ -1,9 +1,9 @@
+import got, { RequestError } from 'got'
 import { createWriteStream } from 'node:fs'
 import { mkdir, rm } from 'node:fs/promises'
 import { pipeline } from 'node:stream/promises'
-import got, { RequestError } from 'got'
-import VError from 'verror'
 import * as Path from '../Path/Path.js'
+import { VError } from '../VError/VError.js'
 
 export const download = async (url, outFile) => {
   try {

package/src/parts/Error/Error.js

@@ -1,4 +1,4 @@
-import VError from 'verror'
+import { VError } from '../VError/VError.js'
 
 /**
  *

package/src/parts/ErrorCodes/ErrorCodes.js

@@ -1,6 +1,8 @@
 export const E_COLOR_THEME_NOT_FOUND = 'E_COLOR_THEME_NOT_FOUND'
+export const E_COMMAND_NOT_FOUND = 'E_COMMAND_NOT_FOUND'
 export const E_ICON_THEME_NOT_FOUND = 'E_ICON_THEME_NOT_FOUND'
 export const E_MANIFEST_NOT_FOUND = 'E_MANIFEST_NOT_FOUND'
+export const EACCES = 'EACCES'
 export const ECONNRESET = 'ECONNRESET'
 export const EEXIST = 'EEXIST'
 export const EISDIR = 'EISDIR'
@@ -12,4 +14,3 @@ export const EPIPE = 'EPIPE'
 export const ERR_IPC_CHANNEL_CLOSED = 'ERR_IPC_CHANNEL_CLOSED'
 export const ERR_MODULE_NOT_FOUND = 'ERR_MODULE_NOT_FOUND'
 export const EXDEV = 'EXDEV'
-export const E_COMMAND_NOT_FOUND = 'E_COMMAND_NOT_FOUND'

package/src/parts/ErrorHandling/ErrorHandling.js

@@ -1,9 +1,11 @@
-import * as ErrorCodes from '../ErrorCodes/ErrorCodes.js'
 import * as ExitCode from '../ExitCode/ExitCode.js'
+import * as IsIgnoredError from '../IsIgnoredError/IsIgnoredError.js'
 import * as JsonRpcVersion from '../JsonRpcVersion/JsonRpcVersion.js'
+import * as Logger from '../Logger/Logger.js'
 import * as PrettyError from '../PrettyError/PrettyError.js'
 import * as Process from '../Process/Process.js'
 import * as Socket from '../Socket/Socket.js'
+import * as GetNewLineIndex from '../GetNewLineIndex/GetNewLineIndex.js'
 
 export const state = {
   seenErrors: [],
@@ -48,7 +50,7 @@ export const handleError = (error) => {
 
 const firstErrorLine = (error) => {
   if (error.stack) {
-    return error.stack.slice(0, error.stack.indexOf('\n'))
+    return error.stack.slice(0, GetNewLineIndex.getNewLineIndex(error.stack))
   }
   if (error.message) {
     return error.message
@@ -57,19 +59,11 @@ const firstErrorLine = (error) => {
 }
 
 export const handleUncaughtExceptionMonitor = (error, origin) => {
-  console.info(`[shared process] uncaught exception: ${firstErrorLine(error)}`)
-  if (error && error.code === ErrorCodes.EPIPE && !process.connected) {
-    // parent process is disposed, ignore
+  Logger.info(`[shared process] uncaught exception: ${firstErrorLine(error)}`)
+  if (IsIgnoredError.isIgnoredError(error)) {
     return
   }
-  if (error && error.code === ErrorCodes.ERR_IPC_CHANNEL_CLOSED && !Process.isConnected()) {
-    // parent process is disposed, ignore
-    return
-  }
-  // console.log(error)
   const prettyError = PrettyError.prepare(error)
-  // console.error(prettyError.message)
-  console.error(prettyError.codeFrame)
-  console.error(prettyError.stack)
-  Process.exit(ExitCode.Error)
+  Logger.error(prettyError.codeFrame + '\n' + prettyError.stack + '\n')
+  Process.setExitCode(ExitCode.Error)
 }

package/src/parts/ExtensionHost/ExtensionHost.js

@@ -1,10 +1,10 @@
-import VError from 'verror'
 import * as Assert from '../Assert/Assert.js'
 import * as Callback from '../Callback/Callback.js'
 import * as ExtensionHostIpc from '../ExtensionHostIpc/ExtensionHostIpc.js'
 import * as ExtensionHostRpc from '../ExtensionHostRpc/ExtensionHostRpc.js'
 import * as JsonRpc from '../JsonRpc/JsonRpc.js'
 import * as JsonRpcVersion from '../JsonRpcVersion/JsonRpcVersion.js'
+import { VError } from '../VError/VError.js'
 
 // TODO maybe rename to extension host management for clarity
 
@@ -41,7 +41,6 @@ export const start = async (socket) => {
     state.extensionHosts[id] = extensionHost
     return id
   } catch (error) {
-    // @ts-ignore
     throw new VError(error, 'Failed to start extension host')
   }
 }

package/src/parts/ExtensionHost/ExtensionHostKeyBindings.js

@@ -1,16 +1,4 @@
-import VError from 'verror'
-import * as Callback from '../Callback/Callback.js'
-import * as ChildProcess from '../ChildProcess/ChildProcess.js'
-import * as Debug from '../Debug/Debug.js'
-import * as Error from '../Error/Error.js'
 import * as ExtensionManagement from '../ExtensionManagement/ExtensionManagement.js'
-import * as ReadJson from '../JsonFile/JsonFile.js'
-import * as JsonRpc from '../JsonRpc/JsonRpc.js'
-import * as Path from '../Path/Path.js'
-import * as Root from '../Root/Root.js'
-import * as Socket from '../Socket/Socket.js'
-import * as TextDocument from '../TextDocument/TextDocument.js'
-import * as Platform from '../Platform/Platform.js'
 
 const getExtensionKeyBindings = (extension) => {
   return extension.keyBindings || []

package/src/parts/ExtensionHostRpc/ExtensionHostRpc.js

@@ -1,6 +1,6 @@
-import VError from 'verror'
 import * as Assert from '../Assert/Assert.js'
 import * as Timeout from '../Timeout/Timeout.js'
+import { VError } from '../VError/VError.js'
 
 // TODO maybe rename to extension host management for clarity
 

package/src/parts/ExtensionInstallFromFile/ExtensionInstallFromFile.js

@@ -1,9 +1,9 @@
-import VError from 'verror'
 import * as Extract from '../Extract/Extract.js'
 import * as FileSystem from '../FileSystem/FileSystem.js'
 import * as JsonFile from '../JsonFile/JsonFile.js'
 import * as Path from '../Path/Path.js'
 import * as Platform from '../Platform/Platform.js'
+import { VError } from '../VError/VError.js'
 
 const getCachedExtensionFolderName = (path) => {
   const baseName = Path.basename(path)

package/src/parts/ExtensionInstallFromGitHub/ExtensionInstallFromGitHub.js

@@ -1,9 +1,9 @@
-import VError from 'verror'
 import * as DownloadAndExtract from '../DownloadAndExtract/DownloadAndExtract.js'
 import * as FileSystem from '../FileSystem/FileSystem.js'
 import * as JsonFile from '../JsonFile/JsonFile.js'
 import * as Path from '../Path/Path.js'
 import * as Platform from '../Platform/Platform.js'
+import { VError } from '../VError/VError.js'
 
 export const install = async ({ user, repo, branch }) => {
   try {

package/src/parts/ExtensionInstallFromUrl/ExtensionInstallFromUrl.js

@@ -1,11 +1,11 @@
 import { rename, rm } from 'node:fs/promises'
 import { join } from 'node:path'
-import VError from 'verror'
 import * as Download from '../Download/Download.js'
 import * as Extract from '../Extract/Extract.js'
 import * as JsonFile from '../JsonFile/JsonFile.js'
 import * as Platform from '../Platform/Platform.js'
 import * as TmpFile from '../TmpFile/TmpFile.js'
+import { VError } from '../VError/VError.js'
 
 export const install = async ({ url }) => {
   try {

package/src/parts/ExtensionLink/ExtensionLink.js

@@ -23,22 +23,6 @@ const linkFallBack = async (path) => {
   }
 }
 
-const linkMonoRepo = async (path, error) => {
-  try {
-    const monoRepoPath = Path.join(path, 'packages', 'extension')
-    const manifest = await ExtensionManifest.get(monoRepoPath)
-    if (manifest.status === ExtensionManifestStatus.Rejected) {
-      throw manifest.reason
-    }
-    const linkedExtensionsPath = Platform.getLinkedExtensionsPath()
-    // @ts-ignore
-    const to = Path.join(linkedExtensionsPath, manifest.id)
-    await SymLink.createSymLink(monoRepoPath, to)
-  } catch {
-    throw error
-  }
-}
-
 export const link = async (path) => {
   try {
     const manifest = await ExtensionManifest.get(path)
@@ -53,9 +37,6 @@ export const link = async (path) => {
     if (error && error.code === ErrorCodes.EEXIST) {
       return linkFallBack(path)
     }
-    if (error && error.code === ErrorCodes.E_MANIFEST_NOT_FOUND) {
-      await linkMonoRepo(path, new VError(error, `Failed to link extension`))
-    }
     throw new VError(error, `Failed to link extension`)
   }
 }

package/src/parts/ExtensionList/ExtensionList.js

@@ -1,9 +1,9 @@
 import { basename } from 'node:path'
-import VError from 'verror'
 import * as ExtensionManifestInputType from '../ExtensionManifestInputType/ExtensionManifestInputType.js'
 import * as ExtensionManifests from '../ExtensionManifests/ExtensionManifests.js'
 import * as Platform from '../Platform/Platform.js'
 import * as ExtensionManifestStatus from '../ExtensionManifestStatus/ExtensionManifestStatus.js'
+import { VError } from '../VError/VError.js'
 
 const getManifestVersion = (json) => {
   if (json && json.version && typeof json.version === 'string') {
@@ -19,12 +19,21 @@ const getManifestId = (json) => {
   return basename(json.path)
 }
 
+const getSymlink = (json) => {
+  if (json && json.symlink && typeof json.symlink === 'string') {
+    return json.symlink
+  }
+  return ''
+}
+
 const getManifestInfo = (json) => {
   const id = getManifestId(json)
   const version = getManifestVersion(json)
+  const symlink = getSymlink(json)
   return {
     id,
     version,
+    symlink,
   }
 }
 
@@ -41,7 +50,7 @@ export const list = async () => {
   try {
     const manifests = await ExtensionManifests.getAll([
       {
-        type: ExtensionManifestInputType.Folder,
+        type: ExtensionManifestInputType.LinkedExtensionsFolder,
         path: Platform.getLinkedExtensionsPath(),
       },
       {

package/src/parts/ExtensionManagement/ExtensionManagement.js

@@ -1,58 +1,10 @@
-import { mkdir, rename, rm } from 'node:fs/promises'
-import { VError } from '../VError/VError.js'
+import { mkdir, rename } from 'node:fs/promises'
 import * as Debug from '../Debug/Debug.js'
 import * as ExtensionManifestInputType from '../ExtensionManifestInputType/ExtensionManifestInputType.js'
 import * as ExtensionManifests from '../ExtensionManifests/ExtensionManifests.js'
 import * as Path from '../Path/Path.js'
 import * as Platform from '../Platform/Platform.js'
-import * as Queue from '../Queue/Queue.js'
-
-export const install = async (id) => {
-  // TODO this should be a stateless function, renderer-worker should have info on marketplace url
-  // TODO use command.execute
-  try {
-    const { download } = await import('../Download/Download.js')
-    const { extractTarBr } = await import('../Extract/Extract.js')
-    const marketplaceUrl = Platform.getMarketplaceUrl()
-    Debug.debug(`ExtensionManagement#install ${id}`)
-    const cachedExtensionsPath = Platform.getCachedExtensionsPath()
-    const extensionsPath = Platform.getExtensionsPath()
-    // TODO maybe a queue is over engineering here
-    await Queue.add('download', async () => {
-      Debug.debug(`ExtensionManagement#download ${id}`)
-      // TODO use command.execute
-      await download(
-        `${marketplaceUrl}/download/${id}`,
-        Path.join(cachedExtensionsPath, `${id}.tar.br`)
-      )
-      Debug.debug(`ExtensionManagement#extract ${id}`)
-      await extractTarBr(
-        Path.join(cachedExtensionsPath, `${id}.tar.br`),
-        Path.join(extensionsPath, id)
-      )
-    })
-    // TODO should this be here? (probably not)
-    // await ExtensionHost.enableExtension({
-    //   id,
-    //   type: 'marketplace',
-    // })
-  } catch (error) {
-    throw new VError(error, `Failed to install extension "${id}"`)
-  }
-}
-
-export const uninstall = async (id) => {
-  try {
-    Debug.debug(`ExtensionManagement#uninstall ${id}`)
-    const extensionsPath = Platform.getExtensionsPath()
-    await rm(Path.join(extensionsPath, id), { recursive: true })
-  } catch (error) {
-    // if (error.code === 'ENOENT') {
-    //   return
-    // }
-    throw new VError(error, `Failed to uninstall extension "${id}"`)
-  }
-}
+import { VError } from '../VError/VError.js'
 
 export const enable = async (id) => {
   try {
@@ -60,10 +12,7 @@ export const enable = async (id) => {
     const extensionsPath = Platform.getExtensionsPath()
     const disabledExtensionsPath = Platform.getDisabledExtensionsPath()
     await mkdir(extensionsPath, { recursive: true })
-    await rename(
-      Path.join(disabledExtensionsPath, id),
-      Path.join(extensionsPath, id)
-    )
+    await rename(Path.join(disabledExtensionsPath, id), Path.join(extensionsPath, id))
   } catch (error) {
     throw new VError(error, `Failed to enable extension "${id}"`)
   }
@@ -75,10 +24,7 @@ export const disable = async (id) => {
     const disabledExtensionsPath = Platform.getDisabledExtensionsPath()
     const extensionsPath = Platform.getExtensionsPath()
     await mkdir(disabledExtensionsPath, { recursive: true })
-    await rename(
-      Path.join(extensionsPath, id),
-      Path.join(disabledExtensionsPath, id)
-    )
+    await rename(Path.join(extensionsPath, id), Path.join(disabledExtensionsPath, id))
   } catch (error) {
     throw new VError(error, `Failed to disable extension ${id}`)
   }
@@ -131,3 +77,5 @@ export const getDisabledExtensions = () => {
     },
   ])
 }
+
+export * from '../ExtensionUninstall/ExtensionUninstall.js'