@lvce-editor/iframe-worker 5.20.0 → 5.21.0

package/dist/iframeWorkerMain.js

@@ -1566,10 +1566,7 @@ const commandMap$1 = {
   'WebView.readFile': readFile
 };
 
-/**
- * @deprecated use getWebViewWorkerRpc2 instead
- */
-const getWebViewWorkerRpc = async rpcInfo => {
+const getWebViewWorkerRpc2 = async rpcInfo => {
   const {
     port1,
     port2
@@ -1579,15 +1576,32 @@ const getWebViewWorkerRpc = async rpcInfo => {
     messagePort: port2,
     isMessagePortOpen: true
   });
-  await invokeAndTransfer$2('WebView.createWebViewWorkerRpc', rpcInfo, port1);
+  // TODO
+  // 1. ask extension host worker to ask renderer worker to ask renderer process to create a worker with given url
+  // 2. send the port through renderer worker to renderer process to the worker for a direct connection
+  await invokeAndTransfer$2('WebView.createWebViewWorkerRpc2', rpcInfo, port1);
   const rpc = await rpcPromise;
   // TODO rpc module should start the port
   port2.start();
   return rpc;
 };
 
+// TODO not part of this function but, for the webview webworker connection,
+// send two ports to the iframe
+// one port for builtin events like ctrl+shift+p keydown event for quickpick
+// second port for the webview webworker connection
+
+// this creates in total
+// 1 iframe
+// 1 worker
+// 6 messageports
+
+// one way to reduce the number of messageports could be to route the worker events
+// through the iframe worker. However that could introduce some overhead / latency
+// compared to direct connections
+
 const createWebWorkerRpc2 = async (rpcInfo, webView, savedState, uri, portId, webViewUid, origin) => {
-  const rpc = await getWebViewWorkerRpc(rpcInfo);
+  const rpc = await getWebViewWorkerRpc2(rpcInfo);
   const webViewInfo = {
     rpc,
     webViewId: webView.id,
@@ -1613,6 +1627,26 @@ const createWebWorkerRpc2 = async (rpcInfo, webView, savedState, uri, portId, we
   });
 };
 
+/**
+ * @deprecated use getWebViewWorkerRpc2 instead
+ */
+const getWebViewWorkerRpc = async rpcInfo => {
+  const {
+    port1,
+    port2
+  } = getPortTuple();
+  const rpcPromise = MessagePortRpcParent.create({
+    commandMap: commandMap$1,
+    messagePort: port2,
+    isMessagePortOpen: true
+  });
+  await invokeAndTransfer$2('WebView.createWebViewWorkerRpc', rpcInfo, port1);
+  const rpc = await rpcPromise;
+  // TODO rpc module should start the port
+  port2.start();
+  return rpc;
+};
+
 const createWebViewRpc$1 = async (rpcInfo, webView, savedState, uri, portId, webViewUid, origin) => {
   // deprecated below
   const rpc = await getWebViewWorkerRpc(rpcInfo);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/iframe-worker",
-  "version": "5.20.0",
+  "version": "5.21.0",
   "description": "Web Worker to manage creation and lifecycle of iframes in Lvce Editor",
   "keywords": [
     "iframe"