@lvce-editor/extension-management-worker 4.83.2 → 4.84.0

package/dist/extensionManagementWorkerMain.js

@@ -3943,14 +3943,20 @@ const executeExtensionDiagnosticProvider = async (rpc, extension, textDocument,
 const executeMatchingDiagnosticProvider = async (extension, textDocument, args, assetDir, platform, resultPort, providerIndex) => {
   const providerId = extension.id ?? extension.uri ?? extension.path ?? String(providerIndex);
   let diagnostics = [];
+  let providerError;
   try {
     const rpc = await getRpc$1(extension, assetDir, platform, `onDiagnostic:${textDocument.languageId}`);
     diagnostics = await executeExtensionDiagnosticProvider(rpc, extension, textDocument, args);
-  } catch {
-    // A failing provider should not prevent results from other providers from being delivered.
+  } catch (error) {
+    // Preserve failure information for callers waiting for a successful diagnostics pass.
+    // Other providers still deliver their results.
+    providerError = error instanceof Error ? error.message : String(error);
   }
   resultPort?.postMessage({
     diagnostics,
+    ...(providerError !== undefined && {
+      error: providerError
+    }),
     providerId,
     providerIndex,
     type: 'result'
@@ -4898,11 +4904,12 @@ const hasView = (extension, viewId) => {
 const hasOnlyViewAndCommandActivations = extension => {
   return Array.isArray(extension.activation) && extension.activation.length > 0 && extension.activation.every(event => event.startsWith('onView:') || event.startsWith('onCommand:'));
 };
+const pendingViewCreations = new WeakMap();
 const hasOtherViewInstances = rpc => {
   return getEntries().some(entry => entry.instance.status === 'ready' && entry.instance.rpc === rpc);
 };
 const disposeViewOnlyExtensionWorker = async (extensionId, rpc) => {
-  if (hasOtherViewInstances(rpc)) {
+  if (pendingViewCreations.has(rpc) || hasOtherViewInstances(rpc)) {
     return;
   }
   if (get$2(extensionId) !== rpc) {
@@ -4918,7 +4925,7 @@ const getExtensionForView = async (viewId, assetDir, platform, applicationId) =>
   }
   return extension;
 };
-const getRpcForView = async (viewId, assetDir, platform, applicationId) => {
+const getRpcForView = async (viewId, assetDir, platform, applicationId, retain) => {
   const {
     assetDir: resolvedAssetDir,
     platform: resolvedPlatform
@@ -4928,22 +4935,26 @@ const getRpcForView = async (viewId, assetDir, platform, applicationId) => {
   const existingRpc = get$2(extensionId, applicationId);
   // Application teardown and reload own application workers; global view-only disposal does not.
   if (existingRpc) {
-    return {
+    const worker = {
       disposeWorkerWhenLastViewCloses: applicationId === undefined && hasOnlyViewAndCommandActivations(extension),
       extensionId,
       rpc: existingRpc
     };
+    retain?.(worker);
+    return worker;
   }
   const activationResult = await activateByEvent(`onView:${viewId}`, resolvedAssetDir, resolvedPlatform, get$7(applicationId));
   if (activationResult.error) {
     throw activationResult.error;
   }
   const rpc = await getRpc$1(extension, resolvedAssetDir, resolvedPlatform);
-  return {
+  const worker = {
     disposeWorkerWhenLastViewCloses: applicationId === undefined && hasOnlyViewAndCommandActivations(extension),
     extensionId,
     rpc
   };
+  retain?.(worker);
+  return worker;
 };
 const getRpcForInstance = async (viewId, uid, assetDir, platform) => {
   const instance = get$1(uid);
@@ -4972,12 +4983,18 @@ const getViewMetadata = async (rpc, viewId) => {
   };
 };
 const createViewInstance = async (viewId, uid, context, assetDir, platform, applicationId) => {
+  let retainedWorker;
+  const retain = worker => {
+    retainedWorker = worker;
+    pendingViewCreations.set(worker.rpc, (pendingViewCreations.get(worker.rpc) || 0) + 1);
+  };
   try {
+    // Retain at selection time, before yielding the RPC to the caller.
     const {
       disposeWorkerWhenLastViewCloses,
       extensionId,
       rpc
-    } = await getRpcForView(viewId, assetDir, platform, applicationId);
+    } = await getRpcForView(viewId, assetDir, platform, applicationId, retain);
     const {
       eventListeners,
       stateful
@@ -5015,6 +5032,24 @@ const createViewInstance = async (viewId, uid, context, assetDir, platform, appl
       error: serializedError,
       ok: false
     };
+  } finally {
+    if (retainedWorker) {
+      const {
+        disposeWorkerWhenLastViewCloses,
+        extensionId,
+        rpc
+      } = retainedWorker;
+      const remaining = (pendingViewCreations.get(rpc) || 1) - 1;
+      if (remaining) {
+        pendingViewCreations.set(rpc, remaining);
+      } else {
+        pendingViewCreations.delete(rpc);
+      }
+      // Failed creations must also release a worker kept alive by an overlapping close.
+      if (disposeWorkerWhenLastViewCloses) {
+        await disposeViewOnlyExtensionWorker(extensionId, rpc);
+      }
+    }
   }
 };
 const dispatchViewEvent = async (viewId, uid, event, assetDir, platform) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/extension-management-worker",
-  "version": "4.83.2",
+  "version": "4.84.0",
   "description": "Webworker for the Extension Management functionality in Lvce Editor.",
   "keywords": [
     "web-worker"