@lvce-editor/extension-detail-view 7.3.0 → 7.4.0

package/dist/extensionDetailViewWorkerMain.js

@@ -438,12 +438,12 @@ const getChildrenWithCount = (nodes, startIndex, childCount) => {
 };
 
 const compareNodes = (oldNode, newNode) => {
-  const patches = [];
   // Check if node type changed - return null to signal incompatible nodes
   // (caller should handle this with a Replace operation)
   if (oldNode.type !== newNode.type) {
     return null;
   }
+  const patches = [];
   // Handle reference nodes - special handling for uid changes
   if (oldNode.type === Reference) {
     if (oldNode.uid !== newNode.uid) {
@@ -479,7 +479,7 @@ const compareNodes = (oldNode, newNode) => {
   }
   // Check for removed attributes
   for (const key of oldKeys) {
-    if (!(key in newNode)) {
+    if (!Object.hasOwn(newNode, key)) {
       patches.push({
         type: RemoveAttribute,
         key
@@ -497,11 +497,78 @@ const treeToArray = node => {
   return result;
 };
 
+const navigateToChild = (patches, currentChildIndex, index) => {
+  if (currentChildIndex === -1) {
+    patches.push({
+      type: NavigateChild,
+      index
+    });
+    return index;
+  }
+  if (currentChildIndex !== index) {
+    patches.push({
+      type: NavigateSibling,
+      index
+    });
+  }
+  return index;
+};
+const navigateToParent = (patches, currentChildIndex) => {
+  if (currentChildIndex >= 0) {
+    patches.push({
+      type: NavigateParent
+    });
+  }
+  return -1;
+};
+const addTree = (newNode, patches) => {
+  patches.push({
+    type: Add,
+    nodes: treeToArray(newNode)
+  });
+};
+const replaceTree = (newNode, patches) => {
+  patches.push({
+    type: Replace,
+    nodes: treeToArray(newNode)
+  });
+};
+const diffExistingChild = (oldNode, newNode, patches, currentChildIndex, index) => {
+  const nodePatches = compareNodes(oldNode.node, newNode.node);
+  if (nodePatches === null) {
+    const nextChildIndex = navigateToChild(patches, currentChildIndex, index);
+    replaceTree(newNode, patches);
+    return nextChildIndex;
+  }
+  const hasChildrenToCompare = oldNode.children.length > 0 || newNode.children.length > 0;
+  if (nodePatches.length === 0 && !hasChildrenToCompare) {
+    return currentChildIndex;
+  }
+  const nextChildIndex = navigateToChild(patches, currentChildIndex, index);
+  if (nodePatches.length > 0) {
+    patches.push(...nodePatches);
+  }
+  if (hasChildrenToCompare) {
+    diffChildren(oldNode.children, newNode.children, patches);
+  }
+  return nextChildIndex;
+};
+const diffRootNode = (oldNode, newNode, patches) => {
+  const nodePatches = compareNodes(oldNode.node, newNode.node);
+  if (nodePatches === null) {
+    replaceTree(newNode, patches);
+    return;
+  }
+  if (nodePatches.length > 0) {
+    patches.push(...nodePatches);
+  }
+  if (oldNode.children.length > 0 || newNode.children.length > 0) {
+    diffChildren(oldNode.children, newNode.children, patches);
+  }
+};
 const diffChildren = (oldChildren, newChildren, patches) => {
   const maxLength = Math.max(oldChildren.length, newChildren.length);
-  // Track where we are: -1 means at parent, >= 0 means at child index
   let currentChildIndex = -1;
-  // Collect indices of children to remove (we'll add these patches at the end in reverse order)
   const indicesToRemove = [];
   for (let i = 0; i < maxLength; i++) {
     const oldNode = oldChildren[i];
@@ -510,88 +577,17 @@ const diffChildren = (oldChildren, newChildren, patches) => {
       continue;
     }
     if (!oldNode) {
-      // Add new node - we should be at the parent
-      if (currentChildIndex >= 0) {
-        // Navigate back to parent
-        patches.push({
-          type: NavigateParent
-        });
-        currentChildIndex = -1;
-      }
-      // Flatten the entire subtree so renderInternal can handle it
-      const flatNodes = treeToArray(newNode);
-      patches.push({
-        type: Add,
-        nodes: flatNodes
-      });
-    } else if (newNode) {
-      // Compare nodes to see if we need any patches
-      const nodePatches = compareNodes(oldNode.node, newNode.node);
-      // If nodePatches is null, the node types are incompatible - need to replace
-      if (nodePatches === null) {
-        // Navigate to this child
-        if (currentChildIndex === -1) {
-          patches.push({
-            type: NavigateChild,
-            index: i
-          });
-          currentChildIndex = i;
-        } else if (currentChildIndex !== i) {
-          patches.push({
-            type: NavigateSibling,
-            index: i
-          });
-          currentChildIndex = i;
-        }
-        // Replace the entire subtree
-        const flatNodes = treeToArray(newNode);
-        patches.push({
-          type: Replace,
-          nodes: flatNodes
-        });
-        // After replace, we're at the new element (same position)
-        continue;
-      }
-      // Check if we need to recurse into children
-      const hasChildrenToCompare = oldNode.children.length > 0 || newNode.children.length > 0;
-      // Only navigate to this element if we need to do something
-      if (nodePatches.length > 0 || hasChildrenToCompare) {
-        // Navigate to this child if not already there
-        if (currentChildIndex === -1) {
-          patches.push({
-            type: NavigateChild,
-            index: i
-          });
-          currentChildIndex = i;
-        } else if (currentChildIndex !== i) {
-          patches.push({
-            type: NavigateSibling,
-            index: i
-          });
-          currentChildIndex = i;
-        }
-        // Apply node patches (these apply to the current element, not children)
-        if (nodePatches.length > 0) {
-          patches.push(...nodePatches);
-        }
-        // Compare children recursively
-        if (hasChildrenToCompare) {
-          diffChildren(oldNode.children, newNode.children, patches);
-        }
-      }
-    } else {
-      // Remove old node - collect the index for later removal
+      currentChildIndex = navigateToParent(patches, currentChildIndex);
+      addTree(newNode, patches);
+      continue;
+    }
+    if (!newNode) {
       indicesToRemove.push(i);
+      continue;
     }
+    currentChildIndex = diffExistingChild(oldNode, newNode, patches, currentChildIndex, i);
   }
-  // Navigate back to parent if we ended at a child
-  if (currentChildIndex >= 0) {
-    patches.push({
-      type: NavigateParent
-    });
-  }
-  // Add remove patches in reverse order (highest index first)
-  // This ensures indices remain valid as we remove
+  navigateToParent(patches, currentChildIndex);
   for (let j = indicesToRemove.length - 1; j >= 0; j--) {
     patches.push({
       type: RemoveChild,
@@ -600,33 +596,11 @@ const diffChildren = (oldChildren, newChildren, patches) => {
   }
 };
 const diffTrees = (oldTree, newTree, patches, path) => {
-  // At the root level (path.length === 0), we're already AT the element
-  // So we compare the root node directly, then compare its children
   if (path.length === 0 && oldTree.length === 1 && newTree.length === 1) {
-    const oldNode = oldTree[0];
-    const newNode = newTree[0];
-    // Compare root nodes
-    const nodePatches = compareNodes(oldNode.node, newNode.node);
-    // If nodePatches is null, the root node types are incompatible - need to replace
-    if (nodePatches === null) {
-      const flatNodes = treeToArray(newNode);
-      patches.push({
-        type: Replace,
-        nodes: flatNodes
-      });
-      return;
-    }
-    if (nodePatches.length > 0) {
-      patches.push(...nodePatches);
-    }
-    // Compare children
-    if (oldNode.children.length > 0 || newNode.children.length > 0) {
-      diffChildren(oldNode.children, newNode.children, patches);
-    }
-  } else {
-    // Non-root level or multiple root elements - use the regular comparison
-    diffChildren(oldTree, newTree, patches);
+    diffRootNode(oldTree[0], newTree[0], patches);
+    return;
   }
+  diffChildren(oldTree, newTree, patches);
 };
 
 const removeTrailingNavigationPatches = patches => {
@@ -866,9 +840,9 @@ const getCellCodeVirtualDom = (value, props) => {
     childCount: 1,
     className: tdClassName,
     type: Td,
-    ...(props?.title ? {
+    ...(props?.title && {
       title: props.title
-    } : {})
+    })
   }, {
     childCount: 1,
     type: Code$2
@@ -904,9 +878,9 @@ const getCellTextVirtualDom = (value, props) => {
     childCount: 1,
     className: tdClassName,
     type: Td,
-    ...(props?.title ? {
+    ...(props?.title && {
       title: props.title
-    } : {})
+    })
   }, text(value)];
 };
 
@@ -1029,10 +1003,7 @@ const isValidRelativePath = value => {
     return false;
   }
   // Must contain at least one alphanumeric character
-  if (!/[A-Za-z0-9]/.test(value)) {
-    return false;
-  }
-  return true;
+  return !!/[A-Za-z0-9]/.test(value);
 };
 const getSchemaLinkUrl = (schema, extensionUri) => {
   if (!schema || typeof schema !== 'string') {
@@ -1049,7 +1020,7 @@ const getSchemaLinkUrl = (schema, extensionUri) => {
     return '';
   }
   try {
-    return new URL(schema, extensionUri).toString();
+    return new URL(schema, extensionUri).href;
   } catch {
     return '';
   }
@@ -2461,8 +2432,15 @@ const create$2 = rpcId => {
 };
 
 const {
+  invoke: invoke$6,
   set: set$a
 } = create$2(ClipBoardWorker);
+const writeText$1 = async text => {
+  return invoke$6('ClipBoard.writeText', text);
+};
+const writeImage = async image => {
+  return invoke$6('ClipBoard.writeImage', image);
+};
 
 const {
   invoke: invoke$5,
@@ -2566,12 +2544,6 @@ const confirm = async (message, options) => {
   const result = await invoke$1('ConfirmPrompt.prompt', message, options);
   return result;
 };
-const writeClipBoardText = async text => {
-  await invoke$1('ClipBoard.writeText', /* text */text);
-};
-const writeClipBoardImage = async blob => {
-  await invoke$1('ClipBoard.writeImage', /* text */blob);
-};
 const sendMessagePortToExtensionManagementWorker = async (port, rpcId) => {
   const command = 'Extensions.handleMessagePort';
   await invokeAndTransfer('SendMessagePortToExtensionHostWorker.sendMessagePortToExtensionManagementWorker', port, command, rpcId);
@@ -2640,10 +2612,7 @@ const featureRuntimeStatusEnabled = extension => {
   if (!extension || typeof extension !== 'object') {
     return false;
   }
-  if ('main' in extension || 'browser' in extension) {
-    return true;
-  }
-  return false;
+  return 'main' in extension || 'browser' in extension;
 };
 
 const formatTime = time => {
@@ -3339,10 +3308,10 @@ const terminate = () => {
 };
 
 const writeClipboardImage = async blob => {
-  await writeClipBoardImage(blob);
+  await writeImage(blob);
 };
 const writeText = async text => {
-  await writeClipBoardText(text);
+  await writeText$1(text);
 };
 
 /* eslint-disable unicorn/prefer-export-from */
@@ -5175,15 +5144,11 @@ const sendMessagePortToMarkdownWorker = async port => {
 };
 
 const createMarkdownWorkerRpc = async () => {
-  try {
-    const rpc = await create$4({
-      commandMap: {},
-      send: sendMessagePortToMarkdownWorker
-    });
-    return rpc;
-  } catch (error) {
-    throw new VError(error, `Failed to create markdown worker rpc`);
-  }
+  const rpc = await create$4({
+    commandMap: {},
+    send: sendMessagePortToMarkdownWorker
+  });
+  return rpc;
 };
 
 const initializeMarkdownWorker = async () => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/extension-detail-view",
-  "version": "7.3.0",
+  "version": "7.4.0",
   "description": "Extension Detail View Worker",
   "repository": {
     "type": "git",