@lvce-editor/extension-detail-view 6.3.0 → 6.5.0

package/dist/extensionDetailViewWorkerMain.js

@@ -681,7 +681,7 @@ const existsJson = async schemaUrl => {
   }
 };
 
-const isExternalLink$1 = schema => {
+const isExternalLink$2 = schema => {
   return schema.startsWith('http://') || schema.startsWith('https://');
 };
 const hasWhitespace = value => {
@@ -728,7 +728,7 @@ const getSchemaLinkUrl = (schema, extensionUri) => {
   if (trimmed !== schema) {
     return '';
   }
-  if (isExternalLink$1(schema)) {
+  if (isExternalLink$2(schema)) {
     return isValidHttpUrl(schema) ? schema : '';
   }
   if (!isValidRelativePath(schema)) {
@@ -1022,7 +1022,7 @@ const TargetName = 'event.target.name';
 const Script$1 = 2;
 
 const ExtensionDetailReadme = 20;
-const ExtensionDetailIconContextMenu$3 = 4091;
+const ExtensionDetailIconContextMenu$2 = 4091;
 
 const None$2 = 0;
 
@@ -2316,6 +2316,9 @@ const sendMessagePortToExtensionManagementWorker = async (port, rpcId) => {
   const command = 'Extensions.handleMessagePort';
   await invokeAndTransfer('SendMessagePortToExtensionHostWorker.sendMessagePortToExtensionManagementWorker', port, command, rpcId);
 };
+const getPreference = async key => {
+  return await invoke$1('Preferences.get', key);
+};
 const getAllExtensions$1 = async () => {
   return invoke$1('ExtensionManagement.getAllExtensions');
 };
@@ -2338,6 +2341,10 @@ const setExtensionsSearchValue = async searchValue => {
   // @ts-ignore
   return invoke$1('Extensions.handleInput', searchValue, Script$1);
 };
+const openExternal$1 = async uri => {
+  // @ts-ignore
+  await invoke$1('Open.openExternal', uri);
+};
 const openUrl = async uri => {
   // @ts-ignore
   await invoke$1('Open.openUrl', uri);
@@ -2544,6 +2551,7 @@ const HandleAdditionalDetailContextMenu = 15;
 const HandleReadmeClick = 16;
 const HandleSelectionChange = 17;
 const HandleTabFocus = 18;
+const HandleResourceLinkClick = 19;
 
 const ActivationEvents = 'ActivationEvents';
 const Changelog = 'Changelog';
@@ -3060,6 +3068,9 @@ const readFileAsBlob = async uri => {
 };
 
 const getImageCopyUrl = (iconSrc, locationProtocol, locationHost) => {
+  if (!iconSrc) {
+    return '';
+  }
   const prefix = `${locationProtocol}//${locationHost}`;
   const absoluteIconSrc = `${prefix}${iconSrc}`;
   return absoluteIconSrc;
@@ -3084,6 +3095,9 @@ const copyImageUrl = async state => {
     locationProtocol
   } = state;
   const absoluteIconSrc = getImageCopyUrl(iconSrc, locationProtocol, locationHost);
+  if (!absoluteIconSrc) {
+    return state;
+  }
   await writeText(absoluteIconSrc);
   return state;
 };
@@ -3281,7 +3295,7 @@ const getMenuEntriesImage = (state, props) => {
 };
 
 const getMenuEntries2 = (state, props) => {
-  if (props.menuId === ExtensionDetailIconContextMenu$3) {
+  if (props.menuId === ExtensionDetailIconContextMenu$2) {
     return getMenuEntriesImage();
   }
   if (props.menuId === ExtensionDetailReadme && props.href) {
@@ -3351,7 +3365,6 @@ const getLinkMenuEntries = props => {
 
 const getMenuEntries = props => [...getLinkMenuEntries(props), ...getImageMenuEntries(props), getCopyMenuEntry()];
 
-const ExtensionDetailIconContextMenu$2 = 4091;
 const getMenuIds = () => {
   return [ExtensionDetailReadme, ExtensionDetailIconContextMenu$2];
 };
@@ -3671,6 +3684,15 @@ const getExtensionIdFromUri = uri => {
   return id;
 };
 
+const getLinkProtectionEnabled = async () => {
+  try {
+    const setting = await getPreference('application.linkProtectionEnabled');
+    return setting === true || setting === 'true';
+  } catch {
+    return false;
+  }
+};
+
 const interpolate = (value, inMin, inMax, outMin, outMax) => {
   const clamped = Math.min(Math.max(value, inMin), inMax);
   const ratio = (clamped - inMin) / (inMax - inMin);
@@ -4039,6 +4061,7 @@ const supportsFileSize = uri => {
   }
   return true;
 };
+
 const getFolderSize = async uri => {
   if (!uri) {
     throw new VError(`uri is required`);
@@ -4098,11 +4121,6 @@ const getMarketplaceEntries = isBuiltin => {
   }];
 };
 
-const getLicenseLink = extension => {
-  // TODO
-  return '#';
-};
-
 const ensureValidLink = link => {
   if (!link) {
     return '';
@@ -4129,39 +4147,62 @@ const getRepositoryLink = extension => {
   const validLink = ensureValidLink(raw);
   return validLink;
 };
+
+const isGitHubRepository$1 = url => {
+  return url.startsWith('https://github.com/');
+};
 const getIssuesLink = extension => {
   const repositoryLink = getRepositoryLink(extension);
   if (!repositoryLink) {
     return '';
   }
-  if (repositoryLink && repositoryLink.startsWith('https://github.com')) {
+  if (isGitHubRepository$1(repositoryLink)) {
     return `${repositoryLink}/issues`;
   }
   return '';
 };
 
+const isGitHubRepository = url => {
+  return url.startsWith('https://github.com/');
+};
+const getLicenseLink = extension => {
+  const repositoryLink = getRepositoryLink(extension);
+  if (!repositoryLink) {
+    return '#';
+  }
+  if (isGitHubRepository(repositoryLink)) {
+    const normalizedLink = repositoryLink.replace(/\/+$/, '');
+    return `${normalizedLink}/blob/main/license.md`;
+  }
+  return '#';
+};
+
 const getResources = (isBuiltin, extension) => {
   const repositoryLink = getRepositoryLink(extension);
   const issueLink = getIssuesLink(extension);
-  const licenseLink = getLicenseLink();
-  // TODO hide marketplace link for builtin extensions
-  return [{
+  const licenseLink = getLicenseLink(extension);
+  const rawResources = [{
+    enabled: !isBuiltin,
     icon: 'LinkExternal',
     label: marketplace(),
     url: '#'
   }, {
+    enabled: true,
     icon: 'LinkExternal',
     label: issues(),
     url: issueLink
   }, {
+    enabled: true,
     icon: 'Repo',
     label: repository(),
     url: repositoryLink
   }, {
+    enabled: true,
     icon: 'LinkExternal',
     label: license(),
     url: licenseLink
   }];
+  return rawResources.filter(resource => resource.enabled);
 };
 
 const loadSideBarContent = async (extensionId, extensionVersion, extensionUri, isBuiltin, extension, showSizeLink) => {
@@ -4261,6 +4302,7 @@ const loadContent = async (state, platform, savedState, isTest = false) => {
   const [hasReadme, hasChangelog] = await Promise.all([existsFile(readmeUrl), existsFile(changelogUrl)]);
   const readmeContent = hasReadme ? await loadReadmeContent(readmeUrl) : noReadmeFound();
   const baseUrl = getBaseUrl(extension.path, platform);
+  // TODO maybe pass these as arguments also
   const locationProtocol = location.protocol;
   const locationHost = location.host;
   const readmeHtml = await renderMarkdown(readmeContent, {
@@ -4299,6 +4341,7 @@ const loadContent = async (state, platform, savedState, isTest = false) => {
   const padding = getPadding(width);
   const sideBarWidth = getSideBarWidth(width);
   const showSideBar = sideBarWidth > 0;
+  const linkProtectionEnabled = await getLinkProtectionEnabled();
   return {
     ...state,
     badge,
@@ -4322,6 +4365,7 @@ const loadContent = async (state, platform, savedState, isTest = false) => {
     hasReadme,
     iconSrc,
     installationEntries,
+    linkProtectionEnabled,
     locationHost,
     locationProtocol,
     marketplaceEntries,
@@ -4389,9 +4433,17 @@ const handleImageContextMenu = async (state, eventX, eventY) => {
   return state;
 };
 
+const openExternalElectron = async uri => {
+  await openExternal$1(uri);
+};
+const openExternalWeb = async uri => {
+  await openUrl(uri);
+};
 const openExternal = async (uri, platform) => {
-  if (platform === Electron$1) ; else {
-    await openUrl(uri);
+  if (platform === Electron$1) {
+    await openExternalElectron(uri);
+  } else {
+    await openExternalWeb(uri);
   }
 };
 
@@ -4409,7 +4461,7 @@ const handleReadmeLinkClick = async (linkProtectionEnabled, platform, href) => {
   return;
 };
 
-const isExternalLink = href => {
+const isExternalLink$1 = href => {
   return href.startsWith('http://') || href.startsWith('https://');
 };
 const handleReadmeClick = async (state, nodeName, href) => {
@@ -4417,7 +4469,7 @@ const handleReadmeClick = async (state, nodeName, href) => {
     linkProtectionEnabled,
     platform
   } = state;
-  if (!href || !isExternalLink(href)) {
+  if (!href || !isExternalLink$1(href)) {
     return state;
   }
   // TODO what to do about relative links? open them in editor?
@@ -4440,6 +4492,21 @@ const handleReadmeContextMenu = async (state, x, y, nodeName, href) => {
   return state;
 };
 
+const isExternalLink = href => {
+  return href.startsWith('http://') || href.startsWith('https://');
+};
+const handleResourceLinkClick = async (state, href) => {
+  const {
+    linkProtectionEnabled,
+    platform
+  } = state;
+  if (!href || !isExternalLink(href)) {
+    return state;
+  }
+  await handleReadmeLinkClick(linkProtectionEnabled, platform, href);
+  return state;
+};
+
 const handleScroll = (state, scrollTop, scrollSource = Script) => {
   const newScrollTop = Math.max(0, scrollTop);
   return {
@@ -4911,6 +4978,7 @@ const getResourceLinkVirtualDom = resource => {
     childCount: 1 + iconDomCount,
     className: Resource,
     href: url,
+    onClick: HandleResourceLinkClick,
     rel: 'noopener noreferrer',
     target: '_blank',
     type: A
@@ -5381,6 +5449,10 @@ const renderEventListeners = () => {
     name: HandleReadmeClick,
     params: ['handleReadmeClick', 'event.target.nodeName', TargetHref],
     preventDefault: true
+  }, {
+    name: HandleResourceLinkClick,
+    params: ['handleResourceLinkClick', TargetHref],
+    preventDefault: true
   }, {
     name: HandleClickUninstall,
     params: ['handleClickUninstall']
@@ -5457,6 +5529,7 @@ const commandMap = {
   'ExtensionDetail.handleImageContextMenu': wrapCommand(handleImageContextMenu),
   'ExtensionDetail.handleReadmeClick': wrapCommand(handleReadmeClick),
   'ExtensionDetail.handleReadmeContextMenu': wrapCommand(handleReadmeContextMenu),
+  'ExtensionDetail.handleResourceLinkClick': wrapCommand(handleResourceLinkClick),
   'ExtensionDetail.handleScroll': wrapCommand(handleScroll),
   'ExtensionDetail.handleSelectionChange': wrapCommand(handleSelectionChange),
   'ExtensionDetail.handleTabFocus': wrapCommand(handleTabFocus),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/extension-detail-view",
-  "version": "6.3.0",
+  "version": "6.5.0",
   "description": "Extension Detail View Worker",
   "repository": {
     "type": "git",