@lvce-editor/extension-detail-view 6.2.0 → 6.3.0

package/dist/extensionDetailViewWorkerMain.js

@@ -1027,6 +1027,7 @@ const ExtensionDetailIconContextMenu$3 = 4091;
 const None$2 = 0;
 
 const Web$1 = 1;
+const Electron$1 = 2;
 
 const ExtensionHostWorker = 44;
 const ExtensionManagementWorker = 9006;
@@ -2337,7 +2338,7 @@ const setExtensionsSearchValue = async searchValue => {
   // @ts-ignore
   return invoke$1('Extensions.handleInput', searchValue, Script$1);
 };
-const openUrl$1 = async uri => {
+const openUrl = async uri => {
   // @ts-ignore
   await invoke$1('Open.openUrl', uri);
 };
@@ -3137,6 +3138,7 @@ const create = (uid, uri, x, y, width, height, platform, assetDir) => {
     importTime: 0,
     installationEntries: [],
     jsonValidation: [],
+    linkProtectionEnabled: false,
     locationHost: '',
     locationProtocol: '',
     marketplaceEntries: [],
@@ -4326,6 +4328,7 @@ const loadContent = async (state, platform, savedState, isTest = false) => {
     name,
     paddingLeft: padding,
     paddingRight: padding,
+    platform,
     rating,
     readmeScrollTop,
     readmeUrl,
@@ -4386,17 +4389,40 @@ const handleImageContextMenu = async (state, eventX, eventY) => {
   return state;
 };
 
+const openExternal = async (uri, platform) => {
+  if (platform === Electron$1) ; else {
+    await openUrl(uri);
+  }
+};
+
+const handleReadmeLinkClick = async (linkProtectionEnabled, platform, href) => {
+  // TODO what to do about relative links? open them in editor?
+  // TODO what to do about mail links?
+  if (linkProtectionEnabled) {
+    const message = `Do you want to open this external link?\n\n${href}`;
+    const confirmed = await confirm(message);
+    if (!confirmed) {
+      return;
+    }
+  }
+  await openExternal(href, platform);
+  return;
+};
+
 const isExternalLink = href => {
   return href.startsWith('http://') || href.startsWith('https://');
 };
 const handleReadmeClick = async (state, nodeName, href) => {
+  const {
+    linkProtectionEnabled,
+    platform
+  } = state;
   if (!href || !isExternalLink(href)) {
     return state;
   }
   // TODO what to do about relative links? open them in editor?
   // TODO what to do about mail links?
-  await openUrl$1(href);
-  // TODO check node name and href
+  await handleReadmeLinkClick(linkProtectionEnabled, platform, href);
   return state;
 };
 
@@ -4692,18 +4718,15 @@ const loadContent2 = async (state, savedState, isTest = false) => {
   return loadContent(state, state.platform, savedState, isTest);
 };
 
-const openUrl = async uri => {
-  await openUrl$1(uri);
-};
-
 const openImageInNewTab = async state => {
   const {
     iconSrc,
     locationHost,
-    locationProtocol
+    locationProtocol,
+    platform
   } = state;
   const absoluteIconSrc = getImageCopyUrl(iconSrc, locationProtocol, locationHost);
-  await openUrl(absoluteIconSrc);
+  await openExternal(absoluteIconSrc, platform);
   return state;
 };
 
@@ -5313,7 +5336,7 @@ const render2 = (uid, diffResult) => {
 const renderEventListeners = () => {
   return [{
     name: HandleAdditionalDetailContextMenu,
-    params: ['handleAdditionalDetailsContextMenu', ClientX, ClientY, 'event.target.nodeName', 'event.target.href'],
+    params: ['handleAdditionalDetailsContextMenu', ClientX, ClientY, 'event.target.nodeName', TargetHref],
     preventDefault: true
   }, {
     name: HandleClickCategory,
@@ -5356,7 +5379,7 @@ const renderEventListeners = () => {
     params: ['handleClickSettings']
   }, {
     name: HandleReadmeClick,
-    params: ['handleReadmeClick', 'event.target.nodeName', 'event.target.href'],
+    params: ['handleReadmeClick', 'event.target.nodeName', TargetHref],
     preventDefault: true
   }, {
     name: HandleClickUninstall,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/extension-detail-view",
-  "version": "6.2.0",
+  "version": "6.3.0",
   "description": "Extension Detail View Worker",
   "repository": {
     "type": "git",
@@ -11,6 +11,6 @@
   "type": "module",
   "main": "dist/extensionDetailViewWorkerMain.js",
   "dependencies": {
-    "@lvce-editor/constants": "^2.1.0"
+    "@lvce-editor/constants": "^2.4.0"
   }
 }