@lvce-editor/eslint-plugin-virtual-dom 17.1.0 → 17.2.0

package/dist/index.js

@@ -77,7 +77,7 @@ const isStringLiteral = node => {
   return isLiteralNode(node) && typeof node.value === 'string';
 };
 
-const meta$c = {
+const meta$f = {
   docs: {
     description: 'Require an explicit role on clickable virtual-dom div nodes'
   },
@@ -86,7 +86,7 @@ const meta$c = {
   },
   type: 'problem'
 };
-const create$c = context => {
+const create$f = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -108,11 +108,11 @@ const create$c = context => {
 
 const clickableDivNeedsRole = {
   __proto__: null,
-  create: create$c,
-  meta: meta$c
+  create: create$f,
+  meta: meta$f
 };
 
-const meta$b = {
+const meta$e = {
   docs: {
     description: 'Require static virtual-dom nodes created inside functions to be hoisted to module scope'
   },
@@ -223,7 +223,7 @@ const isStaticExpression = (sourceCode, node) => {
       return false;
   }
 };
-const create$b = context => {
+const create$e = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomElement(node)) {
@@ -248,11 +248,11 @@ const create$b = context => {
 
 const hoistStaticNodes = {
   __proto__: null,
-  create: create$b,
-  meta: meta$b
+  create: create$e,
+  meta: meta$e
 };
 
-const meta$a = {
+const meta$d = {
   docs: {
     description: 'Disallow empty ARIA values in virtual-dom nodes'
   },
@@ -264,7 +264,7 @@ const meta$a = {
 const isAriaProperty = name => {
   return /^aria[A-Z]/.test(name);
 };
-const create$a = context => {
+const create$d = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -289,11 +289,11 @@ const create$a = context => {
 
 const noEmptyAria = {
   __proto__: null,
-  create: create$a,
-  meta: meta$a
+  create: create$d,
+  meta: meta$d
 };
 
-const meta$9 = {
+const meta$c = {
   docs: {
     description: 'Disallow empty className values in virtual-dom nodes'
   },
@@ -302,7 +302,7 @@ const meta$9 = {
   },
   type: 'problem'
 };
-const create$9 = context => {
+const create$c = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -322,11 +322,11 @@ const create$9 = context => {
 
 const noEmptyClassName = {
   __proto__: null,
-  create: create$9,
-  meta: meta$9
+  create: create$c,
+  meta: meta$c
 };
 
-const meta$8 = {
+const meta$b = {
   docs: {
     description: 'Disallow inline event handlers in virtual-dom nodes'
   },
@@ -341,7 +341,7 @@ const isEventPropertyName = name => {
 const isInlineEventHandler = node => {
   return isStringLiteral(node) || isTemplateLiteralNode(node) || isArrowFunctionExpressionNode(node) || isFunctionExpressionNode(node);
 };
-const create$8 = context => {
+const create$b = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -366,11 +366,11 @@ const create$8 = context => {
 
 const noInlineEventHandlers = {
   __proto__: null,
-  create: create$8,
-  meta: meta$8
+  create: create$b,
+  meta: meta$b
 };
 
-const meta$7 = {
+const meta$a = {
   docs: {
     description: 'Disallow inline style attributes in virtual-dom nodes'
   },
@@ -379,7 +379,7 @@ const meta$7 = {
   },
   type: 'problem'
 };
-const create$7 = context => {
+const create$a = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -399,11 +399,11 @@ const create$7 = context => {
 
 const noInlineStyle = {
   __proto__: null,
-  create: create$7,
-  meta: meta$7
+  create: create$a,
+  meta: meta$a
 };
 
-const meta$6 = {
+const meta$9 = {
   docs: {
     description: 'Disallow object-like attribute values in virtual-dom nodes'
   },
@@ -416,7 +416,7 @@ const ignoredProperties = new Set(['childCount', 'type']);
 const isObjectLikeAttributeValue = node => {
   return isObjectExpressionNode(node) || isArrayExpressionNode(node) || isArrowFunctionExpressionNode(node) || isFunctionExpressionNode(node);
 };
-const create$6 = context => {
+const create$9 = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -441,11 +441,11 @@ const create$6 = context => {
 
 const noObjectAttributeValues = {
   __proto__: null,
-  create: create$6,
-  meta: meta$6
+  create: create$9,
+  meta: meta$9
 };
 
-const meta$5 = {
+const meta$8 = {
   docs: {
     description: 'Disallow raw string children in virtual-dom arrays'
   },
@@ -457,7 +457,7 @@ const meta$5 = {
 const isVirtualDomArray = node => {
   return isArrayExpressionNode(node) && node.elements.some(element => isVirtualDomNode(element) || isTextCall(element));
 };
-const create$5 = context => {
+const create$8 = context => {
   return {
     ArrayExpression(node) {
       if (!isVirtualDomArray(node)) {
@@ -478,11 +478,54 @@ const create$5 = context => {
 
 const noRawTextChildren = {
   __proto__: null,
-  create: create$5,
-  meta: meta$5
+  create: create$8,
+  meta: meta$8
 };
 
-const meta$4 = {
+const meta$7 = {
+  docs: {
+    description: 'Require each virtual-dom event listener to call its dedicated handler'
+  },
+  messages: {
+    noSharedEventListenerHandler: 'Use the dedicated handler `{{name}}` as the first event listener parameter instead of `{{handler}}`.'
+  },
+  type: 'problem'
+};
+const create$7 = context => {
+  return {
+    ObjectExpression(node) {
+      if (!isObjectExpressionNode(node)) {
+        return;
+      }
+      const nameProperty = getProperty(node, 'name');
+      const paramsProperty = getProperty(node, 'params');
+      if (!nameProperty || !paramsProperty || !isStringLiteral(nameProperty.value) || !isArrayExpressionNode(paramsProperty.value)) {
+        return;
+      }
+      const name = nameProperty.value.value;
+      const firstParameter = paramsProperty.value.elements[0];
+      if (!name.startsWith('handle') || !isStringLiteral(firstParameter) || firstParameter.value === name) {
+        return;
+      }
+      context.report({
+        data: {
+          handler: firstParameter.value,
+          name
+        },
+        messageId: 'noSharedEventListenerHandler',
+        node: firstParameter
+      });
+    }
+  };
+};
+
+const noSharedEventListenerHandlers = {
+  __proto__: null,
+  create: create$7,
+  meta: meta$7
+};
+
+const meta$6 = {
   docs: {
     description: 'Prefer virtual-dom constants over raw type, role, aria boolean, and tabIndex values'
   },
@@ -497,7 +540,7 @@ const meta$4 = {
 const isAriaBooleanProperty = name => {
   return /^aria[A-Z]/.test(name);
 };
-const create$4 = context => {
+const create$6 = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -545,11 +588,11 @@ const create$4 = context => {
 
 const preferConstants = {
   __proto__: null,
-  create: create$4,
-  meta: meta$4
+  create: create$6,
+  meta: meta$6
 };
 
-const meta$3 = {
+const meta$5 = {
   docs: {
     description: 'Require Intl.DateTimeFormat instances to be created lazily'
   },
@@ -564,7 +607,7 @@ const isFunctionNode = node => {
 const isDateTimeFormat = node => {
   return node.type === 'MemberExpression' && !node.computed && node.object.type === 'Identifier' && node.object.name === 'Intl' && node.property.type === 'Identifier' && node.property.name === 'DateTimeFormat';
 };
-const create$3 = context => {
+const create$5 = context => {
   const isCreatedLazily = node => {
     return context.sourceCode.getAncestors(node).some(isFunctionNode);
   };
@@ -585,8 +628,8 @@ const create$3 = context => {
 
 const preferLazyDateTimeFormat = {
   __proto__: null,
-  create: create$3,
-  meta: meta$3
+  create: create$5,
+  meta: meta$5
 };
 
 const isClassNameKey = node => {
@@ -634,7 +677,7 @@ const getParent = node => {
   }
   return undefined;
 };
-const meta$2 = {
+const meta$4 = {
   docs: {
     description: 'Prefer mergeClassNames for composing virtual-dom className values'
   },
@@ -643,7 +686,7 @@ const meta$2 = {
   },
   type: 'suggestion'
 };
-const create$2 = context => {
+const create$4 = context => {
   const reportNamespacedClassNameComposition = node => {
     if (!isManualClassNameConcatenation(node) || !hasClassNamesReference(node)) {
       return;
@@ -674,11 +717,11 @@ const create$2 = context => {
 
 const preferMergeClassNames = {
   __proto__: null,
-  create: create$2,
-  meta: meta$2
+  create: create$4,
+  meta: meta$4
 };
 
-const meta$1 = {
+const meta$3 = {
   docs: {
     description: 'Prefer destructuring state properties before use'
   },
@@ -705,7 +748,7 @@ const isWriteExpression = node => {
   }
   return parent.type === 'UnaryExpression' && parent.operator === 'delete' && parent.argument === node;
 };
-const create$1 = context => {
+const create$3 = context => {
   return {
     MemberExpression(node) {
       if (node.computed) {
@@ -732,6 +775,94 @@ const create$1 = context => {
 };
 
 const preferStateDestructuring = {
+  __proto__: null,
+  create: create$3,
+  meta: meta$3
+};
+
+const meta$2 = {
+  docs: {
+    description: 'Require event listener options for handlers with specific browser event behavior'
+  },
+  messages: {
+    requirePreventDefault: '`{{name}}` event listeners must set `preventDefault` to `true`.'
+  },
+  type: 'problem'
+};
+const listenersRequiringPreventDefault = new Set(['handleDragOver', 'handleDrop']);
+const create$2 = context => {
+  return {
+    ObjectExpression(node) {
+      if (!isObjectExpressionNode(node) || !getProperty(node, 'params')) {
+        return;
+      }
+      const nameProperty = getProperty(node, 'name');
+      if (!nameProperty || !isStringLiteral(nameProperty.value) || !listenersRequiringPreventDefault.has(nameProperty.value.value)) {
+        return;
+      }
+      const preventDefaultProperty = getProperty(node, 'preventDefault');
+      if (preventDefaultProperty && isLiteralNode(preventDefaultProperty.value) && preventDefaultProperty.value.value === true) {
+        return;
+      }
+      context.report({
+        data: {
+          name: nameProperty.value.value
+        },
+        messageId: 'requirePreventDefault',
+        node: preventDefaultProperty ? preventDefaultProperty.value : nameProperty
+      });
+    }
+  };
+};
+
+const requireEventListenerOptions = {
+  __proto__: null,
+  create: create$2,
+  meta: meta$2
+};
+
+const meta$1 = {
+  docs: {
+    description: 'Require secure attributes on virtual-dom links'
+  },
+  messages: {
+    secureLinkRel: 'Set `rel` to `noopener noreferrer` on virtual-dom links.',
+    secureLinkTarget: 'Set `target` to `_blank` on virtual-dom links.'
+  },
+  type: 'problem'
+};
+const hasStringPropertyValue = (node, name, value) => {
+  const property = getProperty(node, name);
+  return Boolean(property && isStringLiteral(property.value) && property.value.value === value);
+};
+const create$1 = context => {
+  return {
+    ObjectExpression(node) {
+      if (!isVirtualDomNode(node)) {
+        return;
+      }
+      const typeProperty = getProperty(node, 'type');
+      const hrefProperty = getProperty(node, 'href');
+      if (!typeProperty || !hrefProperty || !isMemberExpressionWithProperty(typeProperty.value, 'A')) {
+        return;
+      }
+      if (!hasStringPropertyValue(node, 'target', '_blank')) {
+        context.report({
+          messageId: 'secureLinkTarget',
+          node
+        });
+      }
+      if (!hasStringPropertyValue(node, 'rel', 'noopener noreferrer')) {
+        context.report({
+          messageId: 'secureLinkRel',
+          node
+        });
+      }
+    }
+  };
+};
+
+const secureLinks = {
   __proto__: null,
   create: create$1,
   meta: meta$1
@@ -861,10 +992,13 @@ const plugin = {
     'no-inline-style': noInlineStyle,
     'no-object-attribute-values': noObjectAttributeValues,
     'no-raw-text-children': noRawTextChildren,
+    'no-shared-event-listener-handlers': noSharedEventListenerHandlers,
     'prefer-constants': preferConstants,
     'prefer-lazy-date-time-format': preferLazyDateTimeFormat,
     'prefer-merge-class-names': preferMergeClassNames,
     'prefer-state-destructuring': preferStateDestructuring,
+    'require-event-listener-options': requireEventListenerOptions,
+    'secure-links': secureLinks,
     'valid-child-count': validChildCount
   }
 };
@@ -882,10 +1016,13 @@ const recommended = [{
     'virtual-dom/no-inline-style': 'error',
     'virtual-dom/no-object-attribute-values': 'error',
     'virtual-dom/no-raw-text-children': 'error',
+    'virtual-dom/no-shared-event-listener-handlers': 'error',
     'virtual-dom/prefer-constants': 'error',
     'virtual-dom/prefer-lazy-date-time-format': 'error',
     'virtual-dom/prefer-merge-class-names': 'error',
     'virtual-dom/prefer-state-destructuring': 'error',
+    'virtual-dom/require-event-listener-options': 'error',
+    'virtual-dom/secure-links': 'error',
     'virtual-dom/valid-child-count': 'error'
   }
 }, {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/eslint-plugin-virtual-dom",
-  "version": "17.1.0",
+  "version": "17.2.0",
   "main": "dist/index.js",
   "repository": {
     "type": "git",