@lvce-editor/eslint-plugin-virtual-dom 16.4.0 → 17.0.0

package/dist/index.js

@@ -77,7 +77,7 @@ const isStringLiteral = node => {
   return isLiteralNode(node) && typeof node.value === 'string';
 };
 
-const meta$a = {
+const meta$c = {
   docs: {
     description: 'Require an explicit role on clickable virtual-dom div nodes'
   },
@@ -86,7 +86,7 @@ const meta$a = {
   },
   type: 'problem'
 };
-const create$a = context => {
+const create$c = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -108,11 +108,112 @@ const create$a = context => {
 
 const clickableDivNeedsRole = {
   __proto__: null,
-  create: create$a,
-  meta: meta$a
+  create: create$c,
+  meta: meta$c
 };
 
-const meta$9 = {
+const meta$b = {
+  docs: {
+    description: 'Require static virtual-dom nodes created inside functions to be hoisted to module scope'
+  },
+  messages: {
+    hoistStaticNode: 'Hoist this static virtual-dom node to module scope.'
+  },
+  type: 'suggestion'
+};
+const isFunctionNode$1 = node => {
+  return ['ArrowFunctionExpression', 'FunctionDeclaration', 'FunctionExpression'].includes(node.type);
+};
+const findVariable = (sourceCode, identifier) => {
+  let scope = sourceCode.getScope(identifier);
+  while (scope) {
+    const variable = scope.set.get(identifier.name);
+    if (variable) {
+      return variable;
+    }
+    scope = scope.upper;
+  }
+  return undefined;
+};
+const isStaticModuleVariable = variable => {
+  if (!['global', 'module'].includes(variable.scope.type)) {
+    return false;
+  }
+  return variable.defs.every(definition => {
+    if (['ClassName', 'FunctionName', 'ImportBinding'].includes(definition.type)) {
+      return true;
+    }
+    return definition.type === 'Variable' && definition.parent.kind === 'const';
+  });
+};
+const isStaticIdentifier = (sourceCode, node) => {
+  const variable = findVariable(sourceCode, node);
+  return Boolean(variable && isStaticModuleVariable(variable));
+};
+const isStaticProperty = (sourceCode, node) => {
+  if (node.type === 'SpreadElement' || node.kind !== 'init' || node.method) {
+    return false;
+  }
+  if (node.computed && !isStaticExpression(sourceCode, node.key)) {
+    return false;
+  }
+  return isStaticExpression(sourceCode, node.value);
+};
+const isStaticExpression = (sourceCode, node) => {
+  if (!node) {
+    return true;
+  }
+  switch (node.type) {
+    case 'ArrayExpression':
+      return node.elements.every(element => !element || element.type !== 'SpreadElement' && isStaticExpression(sourceCode, element));
+    case 'BinaryExpression':
+    case 'LogicalExpression':
+      return isStaticExpression(sourceCode, node.left) && isStaticExpression(sourceCode, node.right);
+    case 'ConditionalExpression':
+      return isStaticExpression(sourceCode, node.test) && isStaticExpression(sourceCode, node.consequent) && isStaticExpression(sourceCode, node.alternate);
+    case 'Identifier':
+      return isStaticIdentifier(sourceCode, node);
+    case 'Literal':
+      return true;
+    case 'MemberExpression':
+      return isStaticExpression(sourceCode, node.object) && (!node.computed || node.property.type !== 'PrivateIdentifier' && isStaticExpression(sourceCode, node.property));
+    case 'ObjectExpression':
+      return node.properties.every(property => isStaticProperty(sourceCode, property));
+    case 'TemplateLiteral':
+      return node.expressions.every(expression => isStaticExpression(sourceCode, expression));
+    case 'UnaryExpression':
+      return node.operator !== 'delete' && isStaticExpression(sourceCode, node.argument);
+    default:
+      return false;
+  }
+};
+const create$b = context => {
+  return {
+    ObjectExpression(node) {
+      if (!isVirtualDomNode(node)) {
+        return;
+      }
+      if (!context.sourceCode.getAncestors(node).some(isFunctionNode$1)) {
+        return;
+      }
+      if (!isStaticExpression(context.sourceCode, node)) {
+        return;
+      }
+      context.report({
+        messageId: 'hoistStaticNode',
+        node
+      });
+    }
+  };
+};
+
+const hoistStaticNodes = {
+  __proto__: null,
+  create: create$b,
+  meta: meta$b
+};
+
+const meta$a = {
   docs: {
     description: 'Disallow empty ARIA values in virtual-dom nodes'
   },
@@ -124,7 +225,7 @@ const meta$9 = {
 const isAriaProperty = name => {
   return /^aria[A-Z]/.test(name);
 };
-const create$9 = context => {
+const create$a = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -149,11 +250,11 @@ const create$9 = context => {
 
 const noEmptyAria = {
   __proto__: null,
-  create: create$9,
-  meta: meta$9
+  create: create$a,
+  meta: meta$a
 };
 
-const meta$8 = {
+const meta$9 = {
   docs: {
     description: 'Disallow empty className values in virtual-dom nodes'
   },
@@ -162,7 +263,7 @@ const meta$8 = {
   },
   type: 'problem'
 };
-const create$8 = context => {
+const create$9 = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -182,11 +283,11 @@ const create$8 = context => {
 
 const noEmptyClassName = {
   __proto__: null,
-  create: create$8,
-  meta: meta$8
+  create: create$9,
+  meta: meta$9
 };
 
-const meta$7 = {
+const meta$8 = {
   docs: {
     description: 'Disallow inline event handlers in virtual-dom nodes'
   },
@@ -201,7 +302,7 @@ const isEventPropertyName = name => {
 const isInlineEventHandler = node => {
   return isStringLiteral(node) || isTemplateLiteralNode(node) || isArrowFunctionExpressionNode(node) || isFunctionExpressionNode(node);
 };
-const create$7 = context => {
+const create$8 = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -226,11 +327,11 @@ const create$7 = context => {
 
 const noInlineEventHandlers = {
   __proto__: null,
-  create: create$7,
-  meta: meta$7
+  create: create$8,
+  meta: meta$8
 };
 
-const meta$6 = {
+const meta$7 = {
   docs: {
     description: 'Disallow inline style attributes in virtual-dom nodes'
   },
@@ -239,7 +340,7 @@ const meta$6 = {
   },
   type: 'problem'
 };
-const create$6 = context => {
+const create$7 = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -259,11 +360,11 @@ const create$6 = context => {
 
 const noInlineStyle = {
   __proto__: null,
-  create: create$6,
-  meta: meta$6
+  create: create$7,
+  meta: meta$7
 };
 
-const meta$5 = {
+const meta$6 = {
   docs: {
     description: 'Disallow object-like attribute values in virtual-dom nodes'
   },
@@ -276,7 +377,7 @@ const ignoredProperties = new Set(['childCount', 'type']);
 const isObjectLikeAttributeValue = node => {
   return isObjectExpressionNode(node) || isArrayExpressionNode(node) || isArrowFunctionExpressionNode(node) || isFunctionExpressionNode(node);
 };
-const create$5 = context => {
+const create$6 = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -301,11 +402,11 @@ const create$5 = context => {
 
 const noObjectAttributeValues = {
   __proto__: null,
-  create: create$5,
-  meta: meta$5
+  create: create$6,
+  meta: meta$6
 };
 
-const meta$4 = {
+const meta$5 = {
   docs: {
     description: 'Disallow raw string children in virtual-dom arrays'
   },
@@ -317,7 +418,7 @@ const meta$4 = {
 const isVirtualDomArray = node => {
   return isArrayExpressionNode(node) && node.elements.some(element => isVirtualDomNode(element) || isTextCall(element));
 };
-const create$4 = context => {
+const create$5 = context => {
   return {
     ArrayExpression(node) {
       if (!isVirtualDomArray(node)) {
@@ -338,11 +439,11 @@ const create$4 = context => {
 
 const noRawTextChildren = {
   __proto__: null,
-  create: create$4,
-  meta: meta$4
+  create: create$5,
+  meta: meta$5
 };
 
-const meta$3 = {
+const meta$4 = {
   docs: {
     description: 'Prefer virtual-dom constants over raw type, role, aria boolean, and tabIndex values'
   },
@@ -357,7 +458,7 @@ const meta$3 = {
 const isAriaBooleanProperty = name => {
   return /^aria[A-Z]/.test(name);
 };
-const create$3 = context => {
+const create$4 = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -404,6 +505,46 @@ const create$3 = context => {
 };
 
 const preferConstants = {
+  __proto__: null,
+  create: create$4,
+  meta: meta$4
+};
+
+const meta$3 = {
+  docs: {
+    description: 'Require Intl.DateTimeFormat instances to be created lazily'
+  },
+  messages: {
+    preferLazyDateTimeFormat: 'Create Intl.DateTimeFormat instances lazily.'
+  },
+  type: 'suggestion'
+};
+const isFunctionNode = node => {
+  return ['ArrowFunctionExpression', 'FunctionDeclaration', 'FunctionExpression'].includes(node.type);
+};
+const isDateTimeFormat = node => {
+  return node.type === 'MemberExpression' && !node.computed && node.object.type === 'Identifier' && node.object.name === 'Intl' && node.property.type === 'Identifier' && node.property.name === 'DateTimeFormat';
+};
+const create$3 = context => {
+  const isCreatedLazily = node => {
+    return context.sourceCode.getAncestors(node).some(isFunctionNode);
+  };
+  const reportEagerDateTimeFormat = node => {
+    if (!isDateTimeFormat(node.callee) || isCreatedLazily(node)) {
+      return;
+    }
+    context.report({
+      messageId: 'preferLazyDateTimeFormat',
+      node
+    });
+  };
+  return {
+    CallExpression: reportEagerDateTimeFormat,
+    NewExpression: reportEagerDateTimeFormat
+  };
+};
+
+const preferLazyDateTimeFormat = {
   __proto__: null,
   create: create$3,
   meta: meta$3
@@ -638,6 +779,7 @@ const plugin = {
   },
   rules: {
     'clickable-div-needs-role': clickableDivNeedsRole,
+    'hoist-static-nodes': hoistStaticNodes,
     'no-empty-aria': noEmptyAria,
     'no-empty-class-name': noEmptyClassName,
     'no-inline-event-handlers': noInlineEventHandlers,
@@ -645,6 +787,7 @@ const plugin = {
     'no-object-attribute-values': noObjectAttributeValues,
     'no-raw-text-children': noRawTextChildren,
     'prefer-constants': preferConstants,
+    'prefer-lazy-date-time-format': preferLazyDateTimeFormat,
     'prefer-merge-class-names': preferMergeClassNames,
     'prefer-state-destructuring': preferStateDestructuring,
     'valid-child-count': validChildCount
@@ -657,6 +800,7 @@ const recommended = [{
   },
   rules: {
     'virtual-dom/clickable-div-needs-role': 'error',
+    'virtual-dom/hoist-static-nodes': 'error',
     'virtual-dom/no-empty-aria': 'error',
     'virtual-dom/no-empty-class-name': 'error',
     'virtual-dom/no-inline-event-handlers': 'error',
@@ -664,6 +808,7 @@ const recommended = [{
     'virtual-dom/no-object-attribute-values': 'error',
     'virtual-dom/no-raw-text-children': 'error',
     'virtual-dom/prefer-constants': 'error',
+    'virtual-dom/prefer-lazy-date-time-format': 'error',
     'virtual-dom/prefer-merge-class-names': 'error',
     'virtual-dom/prefer-state-destructuring': 'error',
     'virtual-dom/valid-child-count': 'error'

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/eslint-plugin-virtual-dom",
-  "version": "16.4.0",
+  "version": "17.0.0",
   "main": "dist/index.js",
   "repository": {
     "type": "git",