@lvce-editor/eslint-plugin-virtual-dom 14.2.0 → 15.1.0

package/dist/index.js

@@ -77,7 +77,7 @@ const isStringLiteral = node => {
   return isLiteralNode(node) && typeof node.value === 'string';
 };
 
-const meta$9 = {
+const meta$a = {
   docs: {
     description: 'Require an explicit role on clickable virtual-dom div nodes'
   },
@@ -86,7 +86,7 @@ const meta$9 = {
   },
   type: 'problem'
 };
-const create$9 = context => {
+const create$a = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -108,11 +108,11 @@ const create$9 = context => {
 
 const clickableDivNeedsRole = {
   __proto__: null,
-  create: create$9,
-  meta: meta$9
+  create: create$a,
+  meta: meta$a
 };
 
-const meta$8 = {
+const meta$9 = {
   docs: {
     description: 'Disallow empty ARIA values in virtual-dom nodes'
   },
@@ -124,7 +124,7 @@ const meta$8 = {
 const isAriaProperty = name => {
   return /^aria[A-Z]/.test(name);
 };
-const create$8 = context => {
+const create$9 = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -149,11 +149,11 @@ const create$8 = context => {
 
 const noEmptyAria = {
   __proto__: null,
-  create: create$8,
-  meta: meta$8
+  create: create$9,
+  meta: meta$9
 };
 
-const meta$7 = {
+const meta$8 = {
   docs: {
     description: 'Disallow empty className values in virtual-dom nodes'
   },
@@ -162,7 +162,7 @@ const meta$7 = {
   },
   type: 'problem'
 };
-const create$7 = context => {
+const create$8 = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -182,11 +182,11 @@ const create$7 = context => {
 
 const noEmptyClassName = {
   __proto__: null,
-  create: create$7,
-  meta: meta$7
+  create: create$8,
+  meta: meta$8
 };
 
-const meta$6 = {
+const meta$7 = {
   docs: {
     description: 'Disallow inline event handlers in virtual-dom nodes'
   },
@@ -201,7 +201,7 @@ const isEventPropertyName = name => {
 const isInlineEventHandler = node => {
   return isStringLiteral(node) || isTemplateLiteralNode(node) || isArrowFunctionExpressionNode(node) || isFunctionExpressionNode(node);
 };
-const create$6 = context => {
+const create$7 = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -226,11 +226,11 @@ const create$6 = context => {
 
 const noInlineEventHandlers = {
   __proto__: null,
-  create: create$6,
-  meta: meta$6
+  create: create$7,
+  meta: meta$7
 };
 
-const meta$5 = {
+const meta$6 = {
   docs: {
     description: 'Disallow inline style attributes in virtual-dom nodes'
   },
@@ -239,7 +239,7 @@ const meta$5 = {
   },
   type: 'problem'
 };
-const create$5 = context => {
+const create$6 = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -259,11 +259,11 @@ const create$5 = context => {
 
 const noInlineStyle = {
   __proto__: null,
-  create: create$5,
-  meta: meta$5
+  create: create$6,
+  meta: meta$6
 };
 
-const meta$4 = {
+const meta$5 = {
   docs: {
     description: 'Disallow object-like attribute values in virtual-dom nodes'
   },
@@ -276,7 +276,7 @@ const ignoredProperties = new Set(['childCount', 'type']);
 const isObjectLikeAttributeValue = node => {
   return isObjectExpressionNode(node) || isArrayExpressionNode(node) || isArrowFunctionExpressionNode(node) || isFunctionExpressionNode(node);
 };
-const create$4 = context => {
+const create$5 = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -301,11 +301,11 @@ const create$4 = context => {
 
 const noObjectAttributeValues = {
   __proto__: null,
-  create: create$4,
-  meta: meta$4
+  create: create$5,
+  meta: meta$5
 };
 
-const meta$3 = {
+const meta$4 = {
   docs: {
     description: 'Disallow raw string children in virtual-dom arrays'
   },
@@ -317,7 +317,7 @@ const meta$3 = {
 const isVirtualDomArray = node => {
   return isArrayExpressionNode(node) && node.elements.some(element => isVirtualDomNode(element) || isTextCall(element));
 };
-const create$3 = context => {
+const create$4 = context => {
   return {
     ArrayExpression(node) {
       if (!isVirtualDomArray(node)) {
@@ -338,11 +338,11 @@ const create$3 = context => {
 
 const noRawTextChildren = {
   __proto__: null,
-  create: create$3,
-  meta: meta$3
+  create: create$4,
+  meta: meta$4
 };
 
-const meta$2 = {
+const meta$3 = {
   docs: {
     description: 'Prefer virtual-dom constants over raw type, role, aria boolean, and tabIndex values'
   },
@@ -357,7 +357,7 @@ const meta$2 = {
 const isAriaBooleanProperty = name => {
   return /^aria[A-Z]/.test(name);
 };
-const create$2 = context => {
+const create$3 = context => {
   return {
     ObjectExpression(node) {
       if (!isVirtualDomNode(node)) {
@@ -405,8 +405,8 @@ const create$2 = context => {
 
 const preferConstants = {
   __proto__: null,
-  create: create$2,
-  meta: meta$2
+  create: create$3,
+  meta: meta$3
 };
 
 const isClassNameKey = node => {
@@ -433,7 +433,7 @@ const isManualClassNameConcatenation = node => {
   }
   return isStringLiteralWithSpace(node.left) || isStringLiteralWithSpace(node.right) || isManualClassNameConcatenation(node.left) || isManualClassNameConcatenation(node.right);
 };
-const meta$1 = {
+const meta$2 = {
   docs: {
     description: 'Prefer mergeClassNames for composing virtual-dom className values'
   },
@@ -442,7 +442,7 @@ const meta$1 = {
   },
   type: 'suggestion'
 };
-const create$1 = context => {
+const create$2 = context => {
   return {
     Property(node) {
       if (!isPropertyNode(node) || !isClassNameKey(node) || !isManualClassNameConcatenation(node.value)) {
@@ -457,6 +457,65 @@ const create$1 = context => {
 };
 
 const preferMergeClassNames = {
+  __proto__: null,
+  create: create$2,
+  meta: meta$2
+};
+
+const meta$1 = {
+  docs: {
+    description: 'Prefer destructuring state properties before use'
+  },
+  messages: {
+    preferStateDestructuring: 'Prefer destructuring from state instead of using state.{{property}}.'
+  },
+  type: 'suggestion'
+};
+const isIdentifier = node => {
+  return node?.type === 'Identifier';
+};
+const isWriteExpression = node => {
+  const {
+    parent
+  } = node;
+  if (!parent) {
+    return false;
+  }
+  if (parent.type === 'AssignmentExpression' && parent.left === node) {
+    return true;
+  }
+  if (parent.type === 'UpdateExpression' && parent.argument === node) {
+    return true;
+  }
+  return parent.type === 'UnaryExpression' && parent.operator === 'delete' && parent.argument === node;
+};
+const create$1 = context => {
+  return {
+    MemberExpression(node) {
+      if (node.computed) {
+        return;
+      }
+      if (!isIdentifier(node.object) || node.object.name !== 'state') {
+        return;
+      }
+      if (!isIdentifier(node.property)) {
+        return;
+      }
+      if (isWriteExpression(node)) {
+        return;
+      }
+      context.report({
+        data: {
+          property: node.property.name
+        },
+        messageId: 'preferStateDestructuring',
+        node
+      });
+    }
+  };
+};
+
+const preferStateDestructuring = {
   __proto__: null,
   create: create$1,
   meta: meta$1
@@ -587,6 +646,7 @@ const plugin = {
     'no-raw-text-children': noRawTextChildren,
     'prefer-constants': preferConstants,
     'prefer-merge-class-names': preferMergeClassNames,
+    'prefer-state-destructuring': preferStateDestructuring,
     'valid-child-count': validChildCount
   }
 };
@@ -605,6 +665,7 @@ const recommended = [{
     'virtual-dom/no-raw-text-children': 'error',
     'virtual-dom/prefer-constants': 'error',
     'virtual-dom/prefer-merge-class-names': 'error',
+    'virtual-dom/prefer-state-destructuring': 'error',
     'virtual-dom/valid-child-count': 'error'
   }
 }];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/eslint-plugin-virtual-dom",
-  "version": "14.2.0",
+  "version": "15.1.0",
   "main": "dist/index.js",
   "repository": {
     "type": "git",