@lvce-editor/eslint-plugin-github-actions 16.3.0 → 16.4.0

package/dist/index.js

@@ -38,7 +38,7 @@ const permissions$1 = {
 const isSupported = (actions, value) => {
   return actions.includes(value);
 };
-const meta$j = {
+const meta$k = {
   docs: {
     description: 'Disallow unsupported action versions'
   },
@@ -48,7 +48,7 @@ const meta$j = {
   },
   type: 'problem'
 };
-const create$j = context => {
+const create$k = context => {
   const sourceCode = getSourceCode(context);
   if (!sourceCode.parserServices?.isYAML) {
     return {};
@@ -79,8 +79,8 @@ const create$j = context => {
 
 const actionVersions = {
   __proto__: null,
-  create: create$j,
-  meta: meta$j
+  create: create$k,
+  meta: meta$k
 };
 
 const parseVersion = value => {
@@ -104,7 +104,7 @@ const isSupportedMacosversion = version => {
 const isSupportedWindowsVersion = version => {
   return config.windows.includes(version);
 };
-const meta$i = {
+const meta$j = {
   docs: {
     description: 'Disallow unsupported ci versions'
   },
@@ -113,7 +113,7 @@ const meta$i = {
   },
   type: 'problem'
 };
-const create$i = context => {
+const create$j = context => {
   const sourceCode = getSourceCode(context);
   if (!sourceCode.parserServices?.isYAML) {
     return {};
@@ -157,11 +157,11 @@ const create$i = context => {
 
 const ciVersions = {
   __proto__: null,
-  create: create$i,
-  meta: meta$i
+  create: create$j,
+  meta: meta$j
 };
 
-const meta$h = {
+const meta$i = {
   docs: {
     description: 'Disallow unsupported fail fast values'
   },
@@ -170,7 +170,7 @@ const meta$h = {
   },
   type: 'problem'
 };
-const create$h = context => {
+const create$i = context => {
   const sourceCode = getSourceCode(context);
   if (!sourceCode.parserServices?.isYAML) {
     return {};
@@ -193,11 +193,11 @@ const create$h = context => {
 
 const failFast = {
   __proto__: null,
-  create: create$h,
-  meta: meta$h
+  create: create$i,
+  meta: meta$i
 };
 
-const meta$g = {
+const meta$h = {
   docs: {
     description: 'Require GitHub Pages deployment best practices'
   },
@@ -242,7 +242,7 @@ const hasGithubPagesConcurrency = mapping => {
   }
   return isYamlScalarString(getMappingValue(mapping, 'group'), 'pages') && isYamlScalarBoolean(getMappingValue(mapping, 'cancel-in-progress'), false);
 };
-const create$g = context => {
+const create$h = context => {
   const sourceCode = getSourceCode(context);
   if (!sourceCode.parserServices?.isYAML || !isCiWorkflow(context.filename)) {
     return {};
@@ -290,11 +290,11 @@ const create$g = context => {
 
 const githubPages = {
   __proto__: null,
-  create: create$g,
-  meta: meta$g
+  create: create$h,
+  meta: meta$h
 };
 
-const meta$f = {
+const meta$g = {
   docs: {
     description: 'Disallow unsupported github token values'
   },
@@ -303,7 +303,7 @@ const meta$f = {
   },
   type: 'problem'
 };
-const create$f = context => {
+const create$g = context => {
   const sourceCode = getSourceCode(context);
   if (!sourceCode.parserServices?.isYAML) {
     return {};
@@ -328,11 +328,11 @@ const create$f = context => {
 
 const githubToken = {
   __proto__: null,
-  create: create$f,
-  meta: meta$f
+  create: create$g,
+  meta: meta$g
 };
 
-const meta$e = {
+const meta$f = {
   docs: {
     description: 'Disallow unsupported matrix values'
   },
@@ -341,7 +341,7 @@ const meta$e = {
   },
   type: 'problem'
 };
-const create$e = context => {
+const create$f = context => {
   const sourceCode = getSourceCode(context);
   if (!sourceCode.parserServices?.isYAML) {
     return {};
@@ -364,11 +364,11 @@ const create$e = context => {
 
 const matrix = {
   __proto__: null,
-  create: create$e,
-  meta: meta$e
+  create: create$f,
+  meta: meta$f
 };
 
-const meta$d = {
+const meta$e = {
   docs: {
     description: 'Disallow unsupported max parallel values'
   },
@@ -377,7 +377,7 @@ const meta$d = {
   },
   type: 'problem'
 };
-const create$d = context => {
+const create$e = context => {
   const sourceCode = getSourceCode(context);
   if (!sourceCode.parserServices?.isYAML) {
     return {};
@@ -400,11 +400,11 @@ const create$d = context => {
 
 const maxParallel = {
   __proto__: null,
-  create: create$d,
-  meta: meta$d
+  create: create$e,
+  meta: meta$e
 };
 
-const meta$c = {
+const meta$d = {
   docs: {
     description: 'Disallow unsupported needs values'
   },
@@ -437,7 +437,7 @@ const getValidNeeds = node => {
   }
   return validNeeds;
 };
-const create$c = context => {
+const create$d = context => {
   const sourceCode = getSourceCode(context);
   if (!sourceCode.parserServices?.isYAML) {
     return {};
@@ -496,11 +496,11 @@ const create$c = context => {
 
 const needs = {
   __proto__: null,
-  create: create$c,
-  meta: meta$c
+  create: create$d,
+  meta: meta$d
 };
 
-const meta$b = {
+const meta$c = {
   docs: {
     description: 'Disallow e2e tests in release workflows'
   },
@@ -528,7 +528,7 @@ const runsE2eTests = value => {
   }
   return false;
 };
-const create$b = context => {
+const create$c = context => {
   const sourceCode = getSourceCode(context);
   if (!sourceCode.parserServices?.isYAML || !isReleaseWorkflow$1(context.filename)) {
     return {};
@@ -547,11 +547,11 @@ const create$b = context => {
 
 const noE2eInRelease = {
   __proto__: null,
-  create: create$b,
-  meta: meta$b
+  create: create$c,
+  meta: meta$c
 };
 
-const meta$a = {
+const meta$b = {
   docs: {
     description: 'Disallow memory measurement in release workflows'
   },
@@ -579,7 +579,7 @@ const runsMemoryMeasurement = value => {
   }
   return false;
 };
-const create$a = context => {
+const create$b = context => {
   const sourceCode = getSourceCode(context);
   if (!sourceCode.parserServices?.isYAML || !isReleaseWorkflow(context.filename)) {
     return {};
@@ -598,11 +598,11 @@ const create$a = context => {
 
 const noMeasureInRelease = {
   __proto__: null,
-  create: create$a,
-  meta: meta$a
+  create: create$b,
+  meta: meta$b
 };
 
-const meta$9 = {
+const meta$a = {
   docs: {
     description: 'Disallow unsupported node version file values'
   },
@@ -611,7 +611,7 @@ const meta$9 = {
   },
   type: 'problem'
 };
-const create$9 = context => {
+const create$a = context => {
   const sourceCode = getSourceCode(context);
   if (!sourceCode.parserServices?.isYAML) {
     return {};
@@ -636,11 +636,11 @@ const create$9 = context => {
 
 const nodeVersionFile = {
   __proto__: null,
-  create: create$9,
-  meta: meta$9
+  create: create$a,
+  meta: meta$a
 };
 
-const meta$8 = {
+const meta$9 = {
   docs: {
     description: 'Disallow unsupported npm registry values'
   },
@@ -649,7 +649,7 @@ const meta$8 = {
   },
   type: 'problem'
 };
-const create$8 = context => {
+const create$9 = context => {
   const sourceCode = getSourceCode(context);
   if (!sourceCode.parserServices?.isYAML) {
     return {};
@@ -673,6 +673,92 @@ const create$8 = context => {
 };
 
 const npmRegistry = {
+  __proto__: null,
+  create: create$9,
+  meta: meta$9
+};
+
+const meta$8 = {
+  docs: {
+    description: 'Require npm tasks to run in a consistent order'
+  },
+  messages: {
+    invalidNpmTaskOrder: '{{task}} must run after {{laterTask}}'
+  },
+  type: 'problem'
+};
+const npmTaskOrder = ['npm run build', 'npm run build:static', 'npm test', 'npm run type-check', 'npm run lint'];
+const getNpmTask = value => {
+  const command = value.trim();
+  for (const task of npmTaskOrder) {
+    if (command === task || command.startsWith(`${task} `)) {
+      return task;
+    }
+  }
+  return undefined;
+};
+const getNpmTaskStep = entry => {
+  if (entry?.type !== 'YAMLMapping') {
+    return undefined;
+  }
+  for (const pair of entry.pairs) {
+    if (pair.key?.type !== 'YAMLScalar' || pair.key.value !== 'run' || pair.value?.type !== 'YAMLScalar' || typeof pair.value.value !== 'string') {
+      continue;
+    }
+    const task = getNpmTask(pair.value.value);
+    if (!task) {
+      return undefined;
+    }
+    return {
+      node: pair.value,
+      order: npmTaskOrder.indexOf(task),
+      task
+    };
+  }
+  return undefined;
+};
+const isStepsSequence = node => {
+  return node.parent.type === 'YAMLPair' && node.parent.key?.type === 'YAMLScalar' && node.parent.key.value === 'steps';
+};
+const create$8 = context => {
+  const sourceCode = getSourceCode(context);
+  if (!sourceCode.parserServices?.isYAML) {
+    return {};
+  }
+  return {
+    YAMLSequence(node) {
+      if (!isStepsSequence(node)) {
+        return;
+      }
+      const steps = node.entries.flatMap(entry => {
+        const step = getNpmTaskStep(entry);
+        return step ? [step] : [];
+      });
+      let earliestLaterStep;
+      for (let index = steps.length - 1; index >= 0; index--) {
+        const step = steps[index];
+        if (!step) {
+          continue;
+        }
+        if (earliestLaterStep && step.order > earliestLaterStep.order) {
+          context.report({
+            data: {
+              laterTask: earliestLaterStep.task,
+              task: step.task
+            },
+            messageId: 'invalidNpmTaskOrder',
+            node: step.node
+          });
+        }
+        if (!earliestLaterStep || step.order < earliestLaterStep.order) {
+          earliestLaterStep = step;
+        }
+      }
+    }
+  };
+};
+
+const npmTaskOrder$1 = {
   __proto__: null,
   create: create$8,
   meta: meta$8
@@ -1071,6 +1157,7 @@ const plugin = {
     'node-version-file': nodeVersionFile,
     npm: npm,
     'npm-registry': npmRegistry,
+    'npm-task-order': npmTaskOrder$1,
     on: on,
     permissions,
     'python-version': pythonVersion,
@@ -1102,6 +1189,7 @@ const recommended = [{
     'github-actions/node-version-file': 'error',
     'github-actions/npm': 'error',
     'github-actions/npm-registry': 'error',
+    'github-actions/npm-task-order': 'error',
     'github-actions/on': 'error',
     'github-actions/permissions': 'off',
     'github-actions/python-version': 'error',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/eslint-plugin-github-actions",
-  "version": "16.3.0",
+  "version": "16.4.0",
   "main": "dist/index.js",
   "type": "module",
   "license": "MIT",