@lvce-editor/eslint-plugin-extension-json 17.3.1 → 17.5.0

package/dist/index.js

@@ -31,7 +31,7 @@ const findMember = (node, name) => {
 };
 
 const requiredFirstDirective = "default-src 'none'";
-const meta = {
+const meta$1 = {
   docs: {
     description: 'Require a secure content security policy for extension workers'
   },
@@ -48,7 +48,7 @@ const hasMainEntry = manifest => {
 const isValidPolicyArray = node => {
   return isArrayNode(node) && node.elements.every(element => isStringNode(element.value));
 };
-const create = context => {
+const create$1 = context => {
   return {
     Document(node) {
       if (!isObjectNode(node.body)) {
@@ -83,6 +83,120 @@ const create = context => {
 };
 
 const contentSecurityPolicy = {
+  __proto__: null,
+  create: create$1,
+  meta: meta$1
+};
+
+// cspell:ignore ctrlcmd downarrow leftarrow rightarrow uparrow
+const identifierPattern = /^\w[\w-]*(?:\.\w[\w-]*)+$/;
+const keyNames = new Set(['`', ',', '-', '=', '*', '\\', 'backquote', 'backslash', 'comma', 'delete', 'down', 'downarrow', 'end', 'enter', 'escape', 'f1', 'f2', 'f3', 'f4', 'f5', 'f6', 'f7', 'f8', 'f9', 'f10', 'f11', 'f12', 'home', 'insert', 'left', 'leftarrow', 'minus', 'pagedown', 'pageup', 'plus', 'right', 'rightarrow', 'space', 'tab', 'up', 'uparrow']);
+const modifierGroups = new Map([['alt', 'alt'], ['cmd', 'ctrlCmd'], ['command', 'ctrlCmd'], ['ctrl', 'ctrlCmd'], ['ctrlcmd', 'ctrlCmd'], ['meta', 'ctrlCmd'], ['shift', 'shift']]);
+const meta = {
+  docs: {
+    description: 'Require valid keybinding contributions in extension manifests'
+  },
+  messages: {
+    invalidCommand: 'extension keybinding command must be a dot-separated ASCII identifier',
+    invalidKey: 'extension keybinding key is invalid',
+    invalidKeybinding: 'extension keybinding must be an object with string key and command properties',
+    invalidKeybindings: 'extension keybindings must be an array',
+    invalidWhenExpression: 'extension keybinding when expression must be a dot-separated ASCII identifier'
+  },
+  type: 'problem'
+};
+const isIdentifier = value => {
+  return identifierPattern.test(value);
+};
+const isKeyName = value => {
+  return /^[a-z0-9]$/i.test(value) || keyNames.has(value.toLowerCase());
+};
+const isValidKey = value => {
+  const parts = value.split('+').map(part => part.trim());
+  if (parts.length === 0 || parts.some(part => !part)) {
+    return false;
+  }
+  const seenModifiers = new Set();
+  let keyCount = 0;
+  for (const part of parts) {
+    const normalized = part.toLowerCase();
+    const modifierGroup = modifierGroups.get(normalized);
+    if (modifierGroup) {
+      if (seenModifiers.has(modifierGroup)) {
+        return false;
+      }
+      seenModifiers.add(modifierGroup);
+      continue;
+    }
+    if (!isKeyName(part)) {
+      return false;
+    }
+    keyCount++;
+  }
+  return keyCount === 1;
+};
+const reportKeybinding = (context, keybinding) => {
+  if (!isObjectNode(keybinding)) {
+    context.report({
+      loc: keybinding.loc,
+      messageId: 'invalidKeybinding'
+    });
+    return;
+  }
+  const key = findMember(keybinding, 'key');
+  const command = findMember(keybinding, 'command');
+  if (!key || !command || !isStringNode(key.value) || !isStringNode(command.value)) {
+    context.report({
+      loc: keybinding.loc,
+      messageId: 'invalidKeybinding'
+    });
+    return;
+  }
+  if (!isValidKey(key.value.value)) {
+    context.report({
+      loc: key.name.loc,
+      messageId: 'invalidKey'
+    });
+  }
+  if (!isIdentifier(command.value.value)) {
+    context.report({
+      loc: command.name.loc,
+      messageId: 'invalidCommand'
+    });
+  }
+  const when = findMember(keybinding, 'when');
+  if (when && (!isStringNode(when.value) || !isIdentifier(when.value.value))) {
+    context.report({
+      loc: when.name.loc,
+      messageId: 'invalidWhenExpression'
+    });
+  }
+};
+const create = context => {
+  return {
+    Document(node) {
+      if (!isObjectNode(node.body)) {
+        return;
+      }
+      const keybindings = findMember(node.body, 'keybindings');
+      if (!keybindings) {
+        return;
+      }
+      if (!isArrayNode(keybindings.value)) {
+        context.report({
+          loc: keybindings.name.loc,
+          messageId: 'invalidKeybindings'
+        });
+        return;
+      }
+      for (const element of keybindings.value.elements) {
+        reportKeybinding(context, element.value);
+      }
+    }
+  };
+};
+
+const validKeybindings = {
   __proto__: null,
   create,
   meta
@@ -95,7 +209,8 @@ const plugin = {
     version: '0.0.1'
   },
   rules: {
-    'content-security-policy': contentSecurityPolicy
+    'content-security-policy': contentSecurityPolicy,
+    'valid-keybindings': validKeybindings
   }
 };
 const recommended = [{
@@ -107,7 +222,8 @@ const recommended = [{
     json
   },
   rules: {
-    'extension-json/content-security-policy': 'error'
+    'extension-json/content-security-policy': 'error',
+    'extension-json/valid-keybindings': 'error'
   }
 }];
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/eslint-plugin-extension-json",
-  "version": "17.3.1",
+  "version": "17.5.0",
   "main": "dist/index.js",
   "repository": {
     "type": "git",