@lvce-editor/eslint-plugin-eslint-config 18.14.2 → 18.16.0

package/dist/index.js

@@ -1,3 +1,5 @@
+import css from '@eslint/css';
+
 const eslintConfigModule = 'eslint/config';
 const defineConfigName = 'defineConfig';
 const getImportedName = specifier => {
@@ -50,7 +52,7 @@ const isDefineConfigCall = (node, bindings) => {
   }
   return callee.type === 'MemberExpression' && callee.object.type === 'Identifier' && bindings.namespaces.has(callee.object.name) && isDefineConfigProperty(callee);
 };
-const meta$2 = {
+const meta$3 = {
   docs: {
     description: 'Enforce using defineConfig from eslint/config for ESLint flat configurations'
   },
@@ -59,7 +61,7 @@ const meta$2 = {
   },
   type: 'suggestion'
 };
-const create$2 = context => {
+const create$3 = context => {
   return {
     'Program:exit'(program) {
       const bindings = getDefineConfigBindings(program);
@@ -76,6 +78,65 @@ const create$2 = context => {
 };
 
 const defineConfig = {
+  __proto__: null,
+  create: create$3,
+  meta: meta$3
+};
+
+const containsQuickPickItem = node => {
+  if (!node) {
+    return false;
+  }
+  if (node.type === 'ClassSelector' && node.name === 'QuickPickItem') {
+    return true;
+  }
+  let found = false;
+  const children = node.children ?? [];
+  for (const child of children) {
+    found ||= containsQuickPickItem(child);
+  }
+  return found;
+};
+const meta$2 = {
+  docs: {
+    description: 'Disallow strict containment on quick-pick result rows'
+  },
+  messages: {
+    avoidStrictContainment: 'Avoid contain: strict on .QuickPickItem rows; it increases quick-pick paint events. Use size/style containment when appropriate.'
+  },
+  type: 'problem'
+};
+const create$2 = context => {
+  const sourceCode = context.sourceCode;
+  return {
+    Rule(cssRule) {
+      if (cssRule.type !== 'Rule' || !cssRule.prelude?.children || !cssRule.block?.children) {
+        return;
+      }
+      let appliesToQuickPickItem = false;
+      for (const selector of cssRule.prelude.children) {
+        appliesToQuickPickItem ||= containsQuickPickItem(selector);
+      }
+      if (!appliesToQuickPickItem) {
+        return;
+      }
+      for (const declaration of cssRule.block.children) {
+        if (declaration.type !== 'Declaration' || declaration.property.toLowerCase() !== 'contain') {
+          return;
+        }
+        const value = sourceCode.getText(declaration.value).replaceAll(/\/\*[\s\S]*?\*\//gu, '').trim();
+        if (/^strict$/iu.test(value)) {
+          context.report({
+            messageId: 'avoidStrictContainment',
+            node: declaration
+          });
+        }
+      }
+    }
+  };
+};
+
+const noStrictContainmentQuickPickItem = {
   __proto__: null,
   create: create$2,
   meta: meta$2
@@ -153,6 +214,7 @@ const plugin = {
   },
   rules: {
     'define-config': defineConfig,
+    'no-strict-containment-quickpick-item': noStrictContainmentQuickPickItem,
     'prefer-recommended-actions': preferRecommendedActions,
     'prefer-recommended-regex': preferRecommendedRegex
   }
@@ -168,5 +230,16 @@ const recommended = [{
     'eslint-config/prefer-recommended-regex': 'error'
   }
 }];
+const recommendedQuickPickCss = [{
+  files: ['**/*.css'],
+  language: 'css/css',
+  plugins: {
+    css,
+    'eslint-config': plugin
+  },
+  rules: {
+    'eslint-config/no-strict-containment-quickpick-item': 'error'
+  }
+}];
 
-export { recommended as default };
+export { recommended as default, recommendedQuickPickCss };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/eslint-plugin-eslint-config",
-  "version": "18.14.2",
+  "version": "18.16.0",
   "main": "dist/index.js",
   "repository": {
     "type": "git",
@@ -8,5 +8,8 @@
   },
   "type": "module",
   "license": "MIT",
-  "description": "ESLint rules for ESLint flat configuration files."
+  "description": "ESLint rules for ESLint flat configuration files.",
+  "dependencies": {
+    "@eslint/css": "^2.0.1"
+  }
 }