@lvce-editor/eslint-plugin-e2e 18.6.0 → 18.7.0

package/dist/index.js

@@ -1,4 +1,4 @@
-const meta$d = {
+const meta$e = {
   docs: {
     description: 'Disallow direct click calls in E2E tests'
   },
@@ -10,7 +10,7 @@ const meta$d = {
 const isDirectClickCall = node => {
   return node.callee.type === 'MemberExpression' && node.callee.property.type === 'Identifier' && node.callee.property.name === 'click';
 };
-const create$d = context => {
+const create$e = context => {
   return {
     CallExpression(node) {
       if (!isDirectClickCall(node)) {
@@ -26,11 +26,11 @@ const create$d = context => {
 
 const noDirectClick = {
   __proto__: null,
-  create: create$d,
-  meta: meta$d
+  create: create$e,
+  meta: meta$e
 };
 
-const meta$c = {
+const meta$d = {
   docs: {
     description: 'Disallow disabling the memory clipboard in finally blocks'
   },
@@ -57,7 +57,7 @@ const isInFinallyBlock = (context, node) => {
     return finalizer !== null && finalizer !== undefined && ancestors.includes(finalizer);
   });
 };
-const create$c = context => {
+const create$d = context => {
   return {
     CallExpression(node) {
       if (!isDisableMemoryClipBoardCall(node) || !isInFinallyBlock(context, node)) {
@@ -73,12 +73,12 @@ const create$c = context => {
 
 const noDisableMemoryClipBoardInFinally = {
   __proto__: null,
-  create: create$c,
-  meta: meta$c
+  create: create$d,
+  meta: meta$d
 };
 
 const allowedTypeImportSource = '@lvce-editor/test-with-playwright';
-const meta$b = {
+const meta$c = {
   docs: {
     description: 'Disallow imports in e2e tests except type imports from @lvce-editor/test-with-playwright'
   },
@@ -96,7 +96,7 @@ const isAllowedTypeImport = node => {
   }
   return node.specifiers.length > 0 && node.specifiers.every(specifier => specifier.importKind === 'type');
 };
-const create$b = context => {
+const create$c = context => {
   return {
     ImportDeclaration(node) {
       if (isAllowedTypeImport(node)) {
@@ -112,11 +112,11 @@ const create$b = context => {
 
 const noImports = {
   __proto__: null,
-  create: create$b,
-  meta: meta$b
+  create: create$c,
+  meta: meta$c
 };
 
-const meta$a = {
+const meta$b = {
   docs: {
     description: 'Disallow inline import.meta.resolve calls in Main.openUri calls'
   },
@@ -137,7 +137,7 @@ const isImportMetaResolveCall = node => {
 const isMainOpenUriCall = node => {
   return node.callee.type === 'MemberExpression' && !node.callee.computed && isIdentifier$3(node.callee.object, 'Main') && isIdentifier$3(node.callee.property, 'openUri');
 };
-const create$a = context => {
+const create$b = context => {
   return {
     CallExpression(node) {
       const [uri] = node.arguments;
@@ -154,11 +154,11 @@ const create$a = context => {
 
 const noInlineImportMetaResolveInOpenUri = {
   __proto__: null,
-  create: create$a,
-  meta: meta$a
+  create: create$b,
+  meta: meta$b
 };
 
-const meta$9 = {
+const meta$a = {
   docs: {
     description: 'Disallow inline locator expressions inside expect calls'
   },
@@ -215,7 +215,7 @@ const containsInlineLocatorCall = node => {
 const isExpectCall$2 = node => {
   return node.callee.type === 'Identifier' && node.callee.name === 'expect';
 };
-const create$9 = context => {
+const create$a = context => {
   return {
     CallExpression(node) {
       if (!isExpectCall$2(node)) {
@@ -235,11 +235,11 @@ const create$9 = context => {
 
 const noInlineLocatorInExpect = {
   __proto__: null,
-  create: create$9,
-  meta: meta$9
+  create: create$a,
+  meta: meta$a
 };
 
-const meta$8 = {
+const meta$9 = {
   docs: {
     description: 'Disallow inline nth locator expressions inside expect calls'
   },
@@ -302,7 +302,7 @@ const containsInlineNthCall = node => {
 const isExpectCall$1 = node => {
   return node.callee.type === 'Identifier' && node.callee.name === 'expect';
 };
-const create$8 = context => {
+const create$9 = context => {
   return {
     CallExpression(node) {
       if (!isExpectCall$1(node)) {
@@ -322,11 +322,11 @@ const create$8 = context => {
 
 const noInlineNthInExpect = {
   __proto__: null,
-  create: create$8,
-  meta: meta$8
+  create: create$9,
+  meta: meta$9
 };
 
-const meta$7 = {
+const meta$8 = {
   docs: {
     description: 'Disallow lazy nth-based variable names for locator variables'
   },
@@ -387,7 +387,7 @@ const containsNthCall = node => {
 const hasLazyNthVariableName = node => {
   return isIdentifierNode$1(node) && lazyNthVariableNamePattern.test(node.name);
 };
-const create$7 = context => {
+const create$8 = context => {
   return {
     VariableDeclarator(node) {
       if (!isVariableDeclaratorNode$1(node)) {
@@ -409,11 +409,11 @@ const create$7 = context => {
 
 const noLazyNthVariableName = {
   __proto__: null,
-  create: create$7,
-  meta: meta$7
+  create: create$8,
+  meta: meta$8
 };
 
-const meta$6 = {
+const meta$7 = {
   docs: {
     description: 'Disallow clicking context menu item locators directly in E2E tests'
   },
@@ -435,7 +435,7 @@ const isMenuItemLocatorCall = node => {
 const isClickCall = node => {
   return node.callee.type === 'MemberExpression' && node.callee.property.type === 'Identifier' && node.callee.property.name === 'click';
 };
-const create$6 = context => {
+const create$7 = context => {
   const menuItemLocators = new Set();
   return {
     CallExpression(node) {
@@ -460,11 +460,11 @@ const create$6 = context => {
 
 const noMenuItemClick = {
   __proto__: null,
-  create: create$6,
-  meta: meta$6
+  create: create$7,
+  meta: meta$7
 };
 
-const meta$5 = {
+const meta$6 = {
   docs: {
     description: 'Disallow exporting skip with a value of zero'
   },
@@ -494,7 +494,7 @@ const getRemovalRange = (node, sourceCode) => {
   const trailingLineBreaks = /^(?:[\t ]*\r?\n)+/.exec(sourceCode.text.slice(node.range[1]))?.[0].length ?? 0;
   return [node.range[0], node.range[1] + trailingLineBreaks];
 };
-const create$5 = context => {
+const create$6 = context => {
   const {
     sourceCode
   } = context;
@@ -516,6 +516,41 @@ const create$5 = context => {
 };
 
 const noSkipZero = {
+  __proto__: null,
+  create: create$6,
+  meta: meta$6
+};
+
+const meta$5 = {
+  docs: {
+    description: 'Disallow timeouts in E2E tests'
+  },
+  messages: {
+    noTimeouts: 'Do not use setTimeout in e2e tests. Wait for an observable condition instead.'
+  },
+  type: 'problem'
+};
+const isSetTimeoutCall = node => {
+  if (node.callee.type === 'Identifier') {
+    return node.callee.name === 'setTimeout';
+  }
+  return node.callee.type === 'MemberExpression' && !node.callee.computed && node.callee.property.type === 'Identifier' && node.callee.property.name === 'setTimeout';
+};
+const create$5 = context => {
+  return {
+    CallExpression(node) {
+      if (!isSetTimeoutCall(node)) {
+        return;
+      }
+      context.report({
+        messageId: 'noTimeouts',
+        node: node.callee
+      });
+    }
+  };
+};
+
+const noTimeouts = {
   __proto__: null,
   create: create$5,
   meta: meta$5
@@ -797,6 +832,7 @@ const plugin = {
     'no-lazy-nth-variable-name': noLazyNthVariableName,
     'no-menu-item-click': noMenuItemClick,
     'no-skip-zero': noSkipZero,
+    'no-timeouts': noTimeouts,
     'prefer-direct-api-destructuring': preferDirectApiDestructuring,
     'prefer-execute-extension-command': preferExecuteExtensionCommand,
     'prefer-filesystem-set-files': preferFileSystemSetFiles,
@@ -819,6 +855,7 @@ const recommended = [{
     'e2e/no-lazy-nth-variable-name': 'error',
     'e2e/no-menu-item-click': 'error',
     'e2e/no-skip-zero': 'error',
+    'e2e/no-timeouts': 'error',
     'e2e/prefer-direct-api-destructuring': 'error',
     'e2e/prefer-execute-extension-command': 'error',
     'e2e/prefer-filesystem-set-files': 'error',

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/eslint-plugin-e2e",
-  "version": "18.6.0",
+  "version": "18.7.0",
   "main": "dist/index.js",
   "repository": {
     "type": "git",