@lvce-editor/eslint-plugin-e2e 17.5.0 → 17.6.0

package/dist/index.js

@@ -1,4 +1,4 @@
-const meta$8 = {
+const meta$9 = {
   docs: {
     description: 'Disallow direct click calls in E2E tests'
   },
@@ -10,7 +10,7 @@ const meta$8 = {
 const isDirectClickCall = node => {
   return node.callee.type === 'MemberExpression' && node.callee.property.type === 'Identifier' && node.callee.property.name === 'click';
 };
-const create$8 = context => {
+const create$9 = context => {
   return {
     CallExpression(node) {
       if (!isDirectClickCall(node)) {
@@ -26,12 +26,12 @@ const create$8 = context => {
 
 const noDirectClick = {
   __proto__: null,
-  create: create$8,
-  meta: meta$8
+  create: create$9,
+  meta: meta$9
 };
 
 const allowedTypeImportSource = '@lvce-editor/test-with-playwright';
-const meta$7 = {
+const meta$8 = {
   docs: {
     description: 'Disallow imports in e2e tests except type imports from @lvce-editor/test-with-playwright'
   },
@@ -49,7 +49,7 @@ const isAllowedTypeImport = node => {
   }
   return node.specifiers.length > 0 && node.specifiers.every(specifier => specifier.importKind === 'type');
 };
-const create$7 = context => {
+const create$8 = context => {
   return {
     ImportDeclaration(node) {
       if (isAllowedTypeImport(node)) {
@@ -65,11 +65,11 @@ const create$7 = context => {
 
 const noImports = {
   __proto__: null,
-  create: create$7,
-  meta: meta$7
+  create: create$8,
+  meta: meta$8
 };
 
-const meta$6 = {
+const meta$7 = {
   docs: {
     description: 'Disallow inline locator expressions inside expect calls'
   },
@@ -123,13 +123,13 @@ const containsInlineLocatorCall = node => {
   }
   return false;
 };
-const isExpectCall$1 = node => {
+const isExpectCall$2 = node => {
   return node.callee.type === 'Identifier' && node.callee.name === 'expect';
 };
-const create$6 = context => {
+const create$7 = context => {
   return {
     CallExpression(node) {
-      if (!isExpectCall$1(node)) {
+      if (!isExpectCall$2(node)) {
         return;
       }
       const [firstArgument] = node.arguments;
@@ -146,11 +146,11 @@ const create$6 = context => {
 
 const noInlineLocatorInExpect = {
   __proto__: null,
-  create: create$6,
-  meta: meta$6
+  create: create$7,
+  meta: meta$7
 };
 
-const meta$5 = {
+const meta$6 = {
   docs: {
     description: 'Disallow inline nth locator expressions inside expect calls'
   },
@@ -210,13 +210,13 @@ const containsInlineNthCall = node => {
   }
   return false;
 };
-const isExpectCall = node => {
+const isExpectCall$1 = node => {
   return node.callee.type === 'Identifier' && node.callee.name === 'expect';
 };
-const create$5 = context => {
+const create$6 = context => {
   return {
     CallExpression(node) {
-      if (!isExpectCall(node)) {
+      if (!isExpectCall$1(node)) {
         return;
       }
       const [firstArgument] = node.arguments;
@@ -233,11 +233,11 @@ const create$5 = context => {
 
 const noInlineNthInExpect = {
   __proto__: null,
-  create: create$5,
-  meta: meta$5
+  create: create$6,
+  meta: meta$6
 };
 
-const meta$4 = {
+const meta$5 = {
   docs: {
     description: 'Disallow lazy nth-based variable names for locator variables'
   },
@@ -298,7 +298,7 @@ const containsNthCall = node => {
 const hasLazyNthVariableName = node => {
   return isIdentifierNode$1(node) && lazyNthVariableNamePattern.test(node.name);
 };
-const create$4 = context => {
+const create$5 = context => {
   return {
     VariableDeclarator(node) {
       if (!isVariableDeclaratorNode$1(node)) {
@@ -320,11 +320,11 @@ const create$4 = context => {
 
 const noLazyNthVariableName = {
   __proto__: null,
-  create: create$4,
-  meta: meta$4
+  create: create$5,
+  meta: meta$5
 };
 
-const meta$3 = {
+const meta$4 = {
   docs: {
     description: 'Prefer destructuring e2e test api parameters directly'
   },
@@ -345,7 +345,7 @@ const isVariableDeclaratorNode = node => {
 const getParameterNames = node => {
   return node.params.filter(isIdentifierNode).map(param => param.name);
 };
-const create$3 = context => {
+const create$4 = context => {
   const functionParameterNames = [];
   const enterFunction = node => {
     functionParameterNames.push([...getParameterNames(node)]);
@@ -381,11 +381,11 @@ const create$3 = context => {
 
 const preferDirectApiDestructuring = {
   __proto__: null,
-  create: create$3,
-  meta: meta$3
+  create: create$4,
+  meta: meta$4
 };
 
-const meta$2 = {
+const meta$3 = {
   docs: {
     description: 'Prefer Command.executeExtensionCommand over Command.execute for extension commands'
   },
@@ -395,19 +395,19 @@ const meta$2 = {
   },
   type: 'suggestion'
 };
-const isIdentifier$1 = (node, name) => {
+const isIdentifier$2 = (node, name) => {
   return node.type === 'Identifier' && node.name === name;
 };
 const isExtensionHostExecuteCommand = node => {
   return node.type === 'Literal' && node.value === 'ExtensionHost.executeCommand';
 };
 const isCommandExecuteCall = node => {
-  return node.callee.type === 'MemberExpression' && !node.callee.computed && isIdentifier$1(node.callee.object, 'Command') && isIdentifier$1(node.callee.property, 'execute');
+  return node.callee.type === 'MemberExpression' && !node.callee.computed && isIdentifier$2(node.callee.object, 'Command') && isIdentifier$2(node.callee.property, 'execute');
 };
 const isExtensionCommandCall = node => {
   return isCommandExecuteCall(node) && node.arguments.length >= 2 && isExtensionHostExecuteCommand(node.arguments[0]);
 };
-const create$2 = context => {
+const create$3 = context => {
   const {
     sourceCode
   } = context;
@@ -430,11 +430,11 @@ const create$2 = context => {
 
 const preferExecuteExtensionCommand = {
   __proto__: null,
-  create: create$2,
-  meta: meta$2
+  create: create$3,
+  meta: meta$3
 };
 
-const meta$1 = {
+const meta$2 = {
   docs: {
     description: 'Prefer FileSystem.setFiles over adjacent FileSystem.writeFile calls'
   },
@@ -468,7 +468,7 @@ const reportAdjacentFileSystemWriteFiles = (context, statements) => {
     previousStatementWasWriteFile = isWriteFile;
   }
 };
-const create$1 = context => {
+const create$2 = context => {
   return {
     BlockStatement(node) {
       reportAdjacentFileSystemWriteFiles(context, node.body);
@@ -478,11 +478,11 @@ const create$1 = context => {
 
 const preferFileSystemSetFiles = {
   __proto__: null,
-  create: create$1,
-  meta: meta$1
+  create: create$2,
+  meta: meta$2
 };
 
-const meta = {
+const meta$1 = {
   docs: {
     description: 'Prefer import.meta.resolve over new URL(..., import.meta.url).toString()'
   },
@@ -491,22 +491,22 @@ const meta = {
   },
   type: 'suggestion'
 };
-const isIdentifier = (node, name) => {
+const isIdentifier$1 = (node, name) => {
   return node.type === 'Identifier' && node.name === name;
 };
 const isImportMeta = node => {
-  return node.type === 'MetaProperty' && isIdentifier(node.meta, 'import') && isIdentifier(node.property, 'meta');
+  return node.type === 'MetaProperty' && isIdentifier$1(node.meta, 'import') && isIdentifier$1(node.property, 'meta');
 };
 const isImportMetaUrl = node => {
-  return node.type === 'MemberExpression' && !node.computed && isImportMeta(node.object) && isIdentifier(node.property, 'url');
+  return node.type === 'MemberExpression' && !node.computed && isImportMeta(node.object) && isIdentifier$1(node.property, 'url');
 };
 const isUrlConstructor = node => {
   return node.type === 'NewExpression' && node.callee.type === 'Identifier' && ['URL', 'Url'].includes(node.callee.name) && node.arguments.length >= 2 && isImportMetaUrl(node.arguments[1]);
 };
 const isNewUrlToStringCall = node => {
-  return node.callee.type === 'MemberExpression' && !node.callee.computed && isIdentifier(node.callee.property, 'toString') && isUrlConstructor(node.callee.object);
+  return node.callee.type === 'MemberExpression' && !node.callee.computed && isIdentifier$1(node.callee.property, 'toString') && isUrlConstructor(node.callee.object);
 };
-const create = context => {
+const create$1 = context => {
   return {
     CallExpression(node) {
       if (!isNewUrlToStringCall(node)) {
@@ -521,6 +521,64 @@ const create = context => {
 };
 
 const preferImportMetaResolve = {
+  __proto__: null,
+  create: create$1,
+  meta: meta$1
+};
+
+const meta = {
+  docs: {
+    description: 'Prefer toBeHidden over negated toBeVisible assertions'
+  },
+  fixable: 'code',
+  messages: {
+    preferToBeHidden: 'Use toBeHidden() instead of not.toBeVisible().'
+  },
+  type: 'suggestion'
+};
+const isIdentifier = (node, name) => {
+  return node.type === 'Identifier' && node.name === name;
+};
+const isExpectCall = node => {
+  if (node.type !== 'CallExpression') {
+    return false;
+  }
+  const {
+    callee
+  } = node;
+  return isIdentifier(callee, 'expect') || callee.type === 'MemberExpression' && !callee.computed && isIdentifier(callee.property, 'expect');
+};
+const getNegatedToBeVisibleCallee = node => {
+  const {
+    callee
+  } = node;
+  if (callee.type !== 'MemberExpression' || callee.computed || !isIdentifier(callee.property, 'toBeVisible') || callee.object.type !== 'MemberExpression' || callee.object.computed || !isIdentifier(callee.object.property, 'not') || !isExpectCall(callee.object.object)) {
+    return undefined;
+  }
+  return callee;
+};
+const create = context => {
+  const {
+    sourceCode
+  } = context;
+  return {
+    CallExpression(node) {
+      const callee = getNegatedToBeVisibleCallee(node);
+      if (!callee) {
+        return;
+      }
+      context.report({
+        fix(fixer) {
+          return fixer.replaceText(callee, `${sourceCode.getText(callee.object.object)}.toBeHidden`);
+        },
+        messageId: 'preferToBeHidden',
+        node: callee
+      });
+    }
+  };
+};
+
+const preferToBeHidden = {
   __proto__: null,
   create,
   meta
@@ -541,7 +599,8 @@ const plugin = {
     'prefer-direct-api-destructuring': preferDirectApiDestructuring,
     'prefer-execute-extension-command': preferExecuteExtensionCommand,
     'prefer-filesystem-set-files': preferFileSystemSetFiles,
-    'prefer-import-meta-resolve': preferImportMetaResolve
+    'prefer-import-meta-resolve': preferImportMetaResolve,
+    'prefer-to-be-hidden': preferToBeHidden
   }
 };
 const recommended = [{
@@ -558,7 +617,8 @@ const recommended = [{
     'e2e/prefer-direct-api-destructuring': 'error',
     'e2e/prefer-execute-extension-command': 'error',
     'e2e/prefer-filesystem-set-files': 'error',
-    'e2e/prefer-import-meta-resolve': 'error'
+    'e2e/prefer-import-meta-resolve': 'error',
+    'e2e/prefer-to-be-hidden': 'error'
   }
 }];
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/eslint-plugin-e2e",
-  "version": "17.5.0",
+  "version": "17.6.0",
   "main": "dist/index.js",
   "repository": {
     "type": "git",