@lvce-editor/eslint-plugin-e2e 14.1.0 → 14.2.0

package/dist/index.js

@@ -1,4 +1,4 @@
-const meta$5 = {
+const meta$6 = {
   docs: {
     description: 'Disallow direct click calls in E2E tests'
   },
@@ -10,7 +10,7 @@ const meta$5 = {
 const isDirectClickCall = node => {
   return node.callee.type === 'MemberExpression' && node.callee.property.type === 'Identifier' && node.callee.property.name === 'click';
 };
-const create$5 = context => {
+const create$6 = context => {
   return {
     CallExpression(node) {
       if (!isDirectClickCall(node)) {
@@ -26,11 +26,11 @@ const create$5 = context => {
 
 const noDirectClick = {
   __proto__: null,
-  create: create$5,
-  meta: meta$5
+  create: create$6,
+  meta: meta$6
 };
 
-const meta$4 = {
+const meta$5 = {
   docs: {
     description: 'Disallow inline locator expressions inside expect calls'
   },
@@ -87,7 +87,7 @@ const containsInlineLocatorCall = node => {
 const isExpectCall$1 = node => {
   return node.callee.type === 'Identifier' && node.callee.name === 'expect';
 };
-const create$4 = context => {
+const create$5 = context => {
   return {
     CallExpression(node) {
       if (!isExpectCall$1(node)) {
@@ -107,11 +107,11 @@ const create$4 = context => {
 
 const noInlineLocatorInExpect = {
   __proto__: null,
-  create: create$4,
-  meta: meta$4
+  create: create$5,
+  meta: meta$5
 };
 
-const meta$3 = {
+const meta$4 = {
   docs: {
     description: 'Disallow inline nth locator expressions inside expect calls'
   },
@@ -174,7 +174,7 @@ const containsInlineNthCall = node => {
 const isExpectCall = node => {
   return node.callee.type === 'Identifier' && node.callee.name === 'expect';
 };
-const create$3 = context => {
+const create$4 = context => {
   return {
     CallExpression(node) {
       if (!isExpectCall(node)) {
@@ -194,11 +194,11 @@ const create$3 = context => {
 
 const noInlineNthInExpect = {
   __proto__: null,
-  create: create$3,
-  meta: meta$3
+  create: create$4,
+  meta: meta$4
 };
 
-const meta$2 = {
+const meta$3 = {
   docs: {
     description: 'Disallow lazy nth-based variable names for locator variables'
   },
@@ -259,7 +259,7 @@ const containsNthCall = node => {
 const hasLazyNthVariableName = node => {
   return isIdentifierNode$1(node) && lazyNthVariableNamePattern.test(node.name);
 };
-const create$2 = context => {
+const create$3 = context => {
   return {
     VariableDeclarator(node) {
       if (!isVariableDeclaratorNode$1(node)) {
@@ -281,11 +281,11 @@ const create$2 = context => {
 
 const noLazyNthVariableName = {
   __proto__: null,
-  create: create$2,
-  meta: meta$2
+  create: create$3,
+  meta: meta$3
 };
 
-const meta$1 = {
+const meta$2 = {
   docs: {
     description: 'Prefer destructuring e2e test api parameters directly'
   },
@@ -306,7 +306,7 @@ const isVariableDeclaratorNode = node => {
 const getParameterNames = node => {
   return node.params.filter(isIdentifierNode).map(param => param.name);
 };
-const create$1 = context => {
+const create$2 = context => {
   const functionParameterNames = [];
   const enterFunction = node => {
     functionParameterNames.push([...getParameterNames(node)]);
@@ -341,6 +341,55 @@ const create$1 = context => {
 };
 
 const preferDirectApiDestructuring = {
+  __proto__: null,
+  create: create$2,
+  meta: meta$2
+};
+
+const meta$1 = {
+  docs: {
+    description: 'Prefer Command.executeExtensionCommand over Command.execute for extension commands'
+  },
+  fixable: 'code',
+  messages: {
+    preferExecuteExtensionCommand: "Use Command.executeExtensionCommand(...) instead of Command.execute('ExtensionHost.executeCommand', ...)."
+  },
+  type: 'suggestion'
+};
+const isIdentifier$1 = (node, name) => {
+  return node.type === 'Identifier' && node.name === name;
+};
+const isExtensionHostExecuteCommand = node => {
+  return node.type === 'Literal' && node.value === 'ExtensionHost.executeCommand';
+};
+const isCommandExecuteCall = node => {
+  return node.callee.type === 'MemberExpression' && !node.callee.computed && isIdentifier$1(node.callee.object, 'Command') && isIdentifier$1(node.callee.property, 'execute');
+};
+const isExtensionCommandCall = node => {
+  return isCommandExecuteCall(node) && node.arguments.length >= 2 && isExtensionHostExecuteCommand(node.arguments[0]);
+};
+const create$1 = context => {
+  const {
+    sourceCode
+  } = context;
+  return {
+    CallExpression(node) {
+      if (!isExtensionCommandCall(node)) {
+        return;
+      }
+      context.report({
+        fix(fixer) {
+          const args = node.arguments.slice(1).map(argument => sourceCode.getText(argument));
+          return fixer.replaceText(node, `Command.executeExtensionCommand(${args.join(', ')})`);
+        },
+        messageId: 'preferExecuteExtensionCommand',
+        node
+      });
+    }
+  };
+};
+
+const preferExecuteExtensionCommand = {
   __proto__: null,
   create: create$1,
   meta: meta$1
@@ -402,6 +451,7 @@ const plugin = {
     'no-inline-nth-in-expect': noInlineNthInExpect,
     'no-lazy-nth-variable-name': noLazyNthVariableName,
     'prefer-direct-api-destructuring': preferDirectApiDestructuring,
+    'prefer-execute-extension-command': preferExecuteExtensionCommand,
     'prefer-import-meta-resolve': preferImportMetaResolve
   }
 };
@@ -416,6 +466,7 @@ const recommended = [{
     'e2e/no-inline-nth-in-expect': 'error',
     'e2e/no-lazy-nth-variable-name': 'error',
     'e2e/prefer-direct-api-destructuring': 'error',
+    'e2e/prefer-execute-extension-command': 'error',
     'e2e/prefer-import-meta-resolve': 'error'
   }
 }];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/eslint-plugin-e2e",
-  "version": "14.1.0",
+  "version": "14.2.0",
   "main": "dist/index.js",
   "repository": {
     "type": "git",