@lvce-editor/eslint-plugin-e2e 11.1.0 → 12.0.0

package/dist/index.js

@@ -1,24 +1,24 @@
-const meta$3 = {
-  type: 'problem',
+const meta$4 = {
   docs: {
     description: 'Disallow direct click calls in E2E tests'
   },
   messages: {
     noDirectClick: 'Do not call .click() directly in e2e tests. Use Command.execute(...) or the page object API instead.'
-  }
+  },
+  type: 'problem'
 };
 const isDirectClickCall = node => {
   return node.callee.type === 'MemberExpression' && node.callee.property.type === 'Identifier' && node.callee.property.name === 'click';
 };
-const create$3 = context => {
+const create$4 = context => {
   return {
     CallExpression(node) {
       if (!isDirectClickCall(node)) {
         return;
       }
       context.report({
-        node: node.callee.property,
-        messageId: 'noDirectClick'
+        messageId: 'noDirectClick',
+        node: node.callee.property
       });
     }
   };
@@ -26,18 +26,18 @@ const create$3 = context => {
 
 const noDirectClick = {
   __proto__: null,
-  create: create$3,
-  meta: meta$3
+  create: create$4,
+  meta: meta$4
 };
 
-const meta$2 = {
-  type: 'problem',
+const meta$3 = {
   docs: {
     description: 'Disallow inline locator expressions inside expect calls'
   },
   messages: {
     noInlineLocatorInExpect: 'Assign the locator to a variable before passing it to expect(...).'
-  }
+  },
+  type: 'problem'
 };
 const isCallExpressionNode$2 = node => {
   return typeof node === 'object' && node !== null && 'type' in node && node.type === 'CallExpression' && 'callee' in node && 'arguments' in node;
@@ -87,7 +87,7 @@ const containsInlineLocatorCall = node => {
 const isExpectCall$1 = node => {
   return node.callee.type === 'Identifier' && node.callee.name === 'expect';
 };
-const create$2 = context => {
+const create$3 = context => {
   return {
     CallExpression(node) {
       if (!isExpectCall$1(node)) {
@@ -98,8 +98,8 @@ const create$2 = context => {
         return;
       }
       context.report({
-        node: firstArgument,
-        messageId: 'noInlineLocatorInExpect'
+        messageId: 'noInlineLocatorInExpect',
+        node: firstArgument
       });
     }
   };
@@ -107,18 +107,18 @@ const create$2 = context => {
 
 const noInlineLocatorInExpect = {
   __proto__: null,
-  create: create$2,
-  meta: meta$2
+  create: create$3,
+  meta: meta$3
 };
 
-const meta$1 = {
-  type: 'problem',
+const meta$2 = {
   docs: {
     description: 'Disallow inline nth locator expressions inside expect calls'
   },
   messages: {
     noInlineNthInExpect: 'Assign the nth locator to a variable before passing it to expect(...).'
-  }
+  },
+  type: 'problem'
 };
 const isCallExpressionNode$1 = node => {
   return typeof node === 'object' && node !== null && 'type' in node && node.type === 'CallExpression' && 'callee' in node && 'arguments' in node;
@@ -174,7 +174,7 @@ const containsInlineNthCall = node => {
 const isExpectCall = node => {
   return node.callee.type === 'Identifier' && node.callee.name === 'expect';
 };
-const create$1 = context => {
+const create$2 = context => {
   return {
     CallExpression(node) {
       if (!isExpectCall(node)) {
@@ -185,8 +185,8 @@ const create$1 = context => {
         return;
       }
       context.report({
-        node: firstArgument,
-        messageId: 'noInlineNthInExpect'
+        messageId: 'noInlineNthInExpect',
+        node: firstArgument
       });
     }
   };
@@ -194,18 +194,18 @@ const create$1 = context => {
 
 const noInlineNthInExpect = {
   __proto__: null,
-  create: create$1,
-  meta: meta$1
+  create: create$2,
+  meta: meta$2
 };
 
-const meta = {
-  type: 'problem',
+const meta$1 = {
   docs: {
     description: 'Disallow lazy nth-based variable names for locator variables'
   },
   messages: {
     noLazyNthVariableName: 'Prefer a specific variable name like firstRow or row0 over nth-based names like rowsNth0.'
-  }
+  },
+  type: 'problem'
 };
 const lazyNthVariableNamePattern = /nth\d+/i;
 const isIdentifierNode = node => {
@@ -259,7 +259,7 @@ const containsNthCall = node => {
 const hasLazyNthVariableName = node => {
   return isIdentifierNode(node) && lazyNthVariableNamePattern.test(node.name);
 };
-const create = context => {
+const create$1 = context => {
   return {
     VariableDeclarator(node) {
       if (!isVariableDeclaratorNode(node)) {
@@ -272,20 +272,65 @@ const create = context => {
         return;
       }
       context.report({
-        node: node.id,
-        messageId: 'noLazyNthVariableName'
+        messageId: 'noLazyNthVariableName',
+        node: node.id
       });
     }
   };
 };
 
 const noLazyNthVariableName = {
+  __proto__: null,
+  create: create$1,
+  meta: meta$1
+};
+
+const meta = {
+  docs: {
+    description: 'Prefer import.meta.resolve over new URL(..., import.meta.url).toString()'
+  },
+  messages: {
+    preferImportMetaResolve: 'Use import.meta.resolve(...) instead of new URL(..., import.meta.url).toString().'
+  },
+  type: 'suggestion'
+};
+const isIdentifier = (node, name) => {
+  return node.type === 'Identifier' && node.name === name;
+};
+const isImportMeta = node => {
+  return node.type === 'MetaProperty' && isIdentifier(node.meta, 'import') && isIdentifier(node.property, 'meta');
+};
+const isImportMetaUrl = node => {
+  return node.type === 'MemberExpression' && !node.computed && isImportMeta(node.object) && isIdentifier(node.property, 'url');
+};
+const isUrlConstructor = node => {
+  return node.type === 'NewExpression' && node.callee.type === 'Identifier' && ['URL', 'Url'].includes(node.callee.name) && node.arguments.length >= 2 && isImportMetaUrl(node.arguments[1]);
+};
+const isNewUrlToStringCall = node => {
+  return node.callee.type === 'MemberExpression' && !node.callee.computed && isIdentifier(node.callee.property, 'toString') && isUrlConstructor(node.callee.object);
+};
+const create = context => {
+  return {
+    CallExpression(node) {
+      if (!isNewUrlToStringCall(node)) {
+        return;
+      }
+      context.report({
+        messageId: 'preferImportMetaResolve',
+        node
+      });
+    }
+  };
+};
+
+const preferImportMetaResolve = {
   __proto__: null,
   create,
   meta
 };
 
 const plugin = {
+  configs: {},
   meta: {
     name: 'e2e',
     version: '0.0.1'
@@ -294,9 +339,9 @@ const plugin = {
     'no-direct-click': noDirectClick,
     'no-inline-locator-in-expect': noInlineLocatorInExpect,
     'no-inline-nth-in-expect': noInlineNthInExpect,
-    'no-lazy-nth-variable-name': noLazyNthVariableName
-  },
-  configs: {}
+    'no-lazy-nth-variable-name': noLazyNthVariableName,
+    'prefer-import-meta-resolve': preferImportMetaResolve
+  }
 };
 const recommended = [{
   files: ['**/e2e/**/*.ts'],
@@ -307,7 +352,8 @@ const recommended = [{
     'e2e/no-direct-click': 'error',
     'e2e/no-inline-locator-in-expect': 'error',
     'e2e/no-inline-nth-in-expect': 'error',
-    'e2e/no-lazy-nth-variable-name': 'error'
+    'e2e/no-lazy-nth-variable-name': 'error',
+    'e2e/prefer-import-meta-resolve': 'error'
   }
 }];
 

package/package.json

@@ -1,13 +1,12 @@
 {
   "name": "@lvce-editor/eslint-plugin-e2e",
-  "version": "11.1.0",
+  "version": "12.0.0",
   "main": "dist/index.js",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/lvce-editor/eslint-config.git"
   },
   "type": "module",
-  "keywords": [],
   "license": "MIT",
-  "description": ""
+  "description": "ESLint rules for end-to-end test code."
 }