@lvce-editor/eslint-plugin-e2e 10.1.0 → 10.2.0

package/dist/index.js

@@ -1,4 +1,4 @@
-const meta$2 = {
+const meta$3 = {
   type: 'problem',
   docs: {
     description: 'Disallow direct click calls in E2E tests'
@@ -10,7 +10,7 @@ const meta$2 = {
 const isDirectClickCall = node => {
   return node.callee.type === 'MemberExpression' && node.callee.property.type === 'Identifier' && node.callee.property.name === 'click';
 };
-const create$2 = context => {
+const create$3 = context => {
   return {
     CallExpression(node) {
       if (!isDirectClickCall(node)) {
@@ -26,11 +26,11 @@ const create$2 = context => {
 
 const noDirectClick = {
   __proto__: null,
-  create: create$2,
-  meta: meta$2
+  create: create$3,
+  meta: meta$3
 };
 
-const meta$1 = {
+const meta$2 = {
   type: 'problem',
   docs: {
     description: 'Disallow inline locator expressions inside expect calls'
@@ -39,16 +39,16 @@ const meta$1 = {
     noInlineLocatorInExpect: 'Assign the locator to a variable before passing it to expect(...).'
   }
 };
-const isCallExpressionNode$1 = node => {
+const isCallExpressionNode$2 = node => {
   return typeof node === 'object' && node !== null && 'type' in node && node.type === 'CallExpression' && 'callee' in node && 'arguments' in node;
 };
-const isIdentifierNode$1 = node => {
+const isIdentifierNode$2 = node => {
   return typeof node === 'object' && node !== null && 'type' in node && node.type === 'Identifier' && 'name' in node;
 };
-const isMemberExpressionNode$1 = node => {
+const isMemberExpressionNode$2 = node => {
   return typeof node === 'object' && node !== null && 'type' in node && node.type === 'MemberExpression' && 'object' in node && 'property' in node && 'computed' in node;
 };
-const isChainExpressionNode$1 = node => {
+const isChainExpressionNode$2 = node => {
   return typeof node === 'object' && node !== null && 'type' in node && node.type === 'ChainExpression' && 'expression' in node;
 };
 const isAwaitExpressionNode$1 = node => {
@@ -58,7 +58,7 @@ const isTsNonNullExpression = node => {
   return typeof node === 'object' && node !== null && 'type' in node && node.type === 'TSNonNullExpression' && 'expression' in node;
 };
 const isLocatorCall = node => {
-  return isCallExpressionNode$1(node) && isIdentifierNode$1(node.callee) && node.callee.name === 'Locator';
+  return isCallExpressionNode$2(node) && isIdentifierNode$2(node.callee) && node.callee.name === 'Locator';
 };
 const containsInlineLocatorCall = node => {
   if (!node) {
@@ -67,13 +67,13 @@ const containsInlineLocatorCall = node => {
   if (isLocatorCall(node)) {
     return true;
   }
-  if (isCallExpressionNode$1(node)) {
+  if (isCallExpressionNode$2(node)) {
     return containsInlineLocatorCall(node.callee) || node.arguments.some(containsInlineLocatorCall);
   }
-  if (isMemberExpressionNode$1(node)) {
+  if (isMemberExpressionNode$2(node)) {
     return containsInlineLocatorCall(node.object) || node.computed && containsInlineLocatorCall(node.property);
   }
-  if (isChainExpressionNode$1(node)) {
+  if (isChainExpressionNode$2(node)) {
     return containsInlineLocatorCall(node.expression);
   }
   if (isAwaitExpressionNode$1(node)) {
@@ -87,7 +87,7 @@ const containsInlineLocatorCall = node => {
 const isExpectCall$1 = node => {
   return node.callee.type === 'Identifier' && node.callee.name === 'expect';
 };
-const create$1 = context => {
+const create$2 = context => {
   return {
     CallExpression(node) {
       if (!isExpectCall$1(node)) {
@@ -107,11 +107,11 @@ const create$1 = context => {
 
 const noInlineLocatorInExpect = {
   __proto__: null,
-  create: create$1,
-  meta: meta$1
+  create: create$2,
+  meta: meta$2
 };
 
-const meta = {
+const meta$1 = {
   type: 'problem',
   docs: {
     description: 'Disallow inline nth locator expressions inside expect calls'
@@ -120,53 +120,53 @@ const meta = {
     noInlineNthInExpect: 'Assign the nth locator to a variable before passing it to expect(...).'
   }
 };
-const isCallExpressionNode = node => {
+const isCallExpressionNode$1 = node => {
   return typeof node === 'object' && node !== null && 'type' in node && node.type === 'CallExpression' && 'callee' in node && 'arguments' in node;
 };
-const isIdentifierNode = node => {
+const isIdentifierNode$1 = node => {
   return typeof node === 'object' && node !== null && 'type' in node && node.type === 'Identifier' && 'name' in node;
 };
-const isMemberExpressionNode = node => {
+const isMemberExpressionNode$1 = node => {
   return typeof node === 'object' && node !== null && 'type' in node && node.type === 'MemberExpression' && 'object' in node && 'property' in node && 'computed' in node;
 };
-const isChainExpressionNode = node => {
+const isChainExpressionNode$1 = node => {
   return typeof node === 'object' && node !== null && 'type' in node && node.type === 'ChainExpression' && 'expression' in node;
 };
 const isAwaitExpressionNode = node => {
   return typeof node === 'object' && node !== null && 'type' in node && node.type === 'AwaitExpression' && 'argument' in node;
 };
-const isTsAsExpressionNode = node => {
+const isTsAsExpressionNode$1 = node => {
   return typeof node === 'object' && node !== null && 'type' in node && node.type === 'TSAsExpression' && 'expression' in node;
 };
-const isTsNonNullExpressionNode = node => {
+const isTsNonNullExpressionNode$1 = node => {
   return typeof node === 'object' && node !== null && 'type' in node && node.type === 'TSNonNullExpression' && 'expression' in node;
 };
-const isNthCall = node => {
-  return isCallExpressionNode(node) && isMemberExpressionNode(node.callee) && !node.callee.computed && isIdentifierNode(node.callee.property) && node.callee.property.name === 'nth';
+const isNthCall$1 = node => {
+  return isCallExpressionNode$1(node) && isMemberExpressionNode$1(node.callee) && !node.callee.computed && isIdentifierNode$1(node.callee.property) && node.callee.property.name === 'nth';
 };
 const containsInlineNthCall = node => {
   if (!node) {
     return false;
   }
-  if (isNthCall(node)) {
+  if (isNthCall$1(node)) {
     return true;
   }
-  if (isCallExpressionNode(node)) {
+  if (isCallExpressionNode$1(node)) {
     return containsInlineNthCall(node.callee) || node.arguments.some(containsInlineNthCall);
   }
-  if (isMemberExpressionNode(node)) {
+  if (isMemberExpressionNode$1(node)) {
     return containsInlineNthCall(node.object) || node.computed && containsInlineNthCall(node.property);
   }
-  if (isChainExpressionNode(node)) {
+  if (isChainExpressionNode$1(node)) {
     return containsInlineNthCall(node.expression);
   }
   if (isAwaitExpressionNode(node)) {
     return containsInlineNthCall(node.argument);
   }
-  if (isTsAsExpressionNode(node)) {
+  if (isTsAsExpressionNode$1(node)) {
     return containsInlineNthCall(node.expression);
   }
-  if (isTsNonNullExpressionNode(node)) {
+  if (isTsNonNullExpressionNode$1(node)) {
     return containsInlineNthCall(node.expression);
   }
   return false;
@@ -174,7 +174,7 @@ const containsInlineNthCall = node => {
 const isExpectCall = node => {
   return node.callee.type === 'Identifier' && node.callee.name === 'expect';
 };
-const create = context => {
+const create$1 = context => {
   return {
     CallExpression(node) {
       if (!isExpectCall(node)) {
@@ -193,6 +193,93 @@ const create = context => {
 };
 
 const noInlineNthInExpect = {
+  __proto__: null,
+  create: create$1,
+  meta: meta$1
+};
+
+const meta = {
+  type: 'problem',
+  docs: {
+    description: 'Disallow lazy nth-based variable names for locator variables'
+  },
+  messages: {
+    noLazyNthVariableName: 'Prefer a specific variable name like firstRow or row0 over nth-based names like rowsNth0.'
+  }
+};
+const lazyNthVariableNamePattern = /nth\d+/i;
+const isIdentifierNode = node => {
+  return typeof node === 'object' && node !== null && 'type' in node && node.type === 'Identifier' && 'name' in node;
+};
+const isVariableDeclaratorNode = node => {
+  return typeof node === 'object' && node !== null && 'type' in node && node.type === 'VariableDeclarator' && 'id' in node && 'init' in node;
+};
+const isCallExpressionNode = node => {
+  return typeof node === 'object' && node !== null && 'type' in node && node.type === 'CallExpression' && 'callee' in node && 'arguments' in node;
+};
+const isMemberExpressionNode = node => {
+  return typeof node === 'object' && node !== null && 'type' in node && node.type === 'MemberExpression' && 'object' in node && 'property' in node && 'computed' in node;
+};
+const isChainExpressionNode = node => {
+  return typeof node === 'object' && node !== null && 'type' in node && node.type === 'ChainExpression' && 'expression' in node;
+};
+const isTsAsExpressionNode = node => {
+  return typeof node === 'object' && node !== null && 'type' in node && node.type === 'TSAsExpression' && 'expression' in node;
+};
+const isTsNonNullExpressionNode = node => {
+  return typeof node === 'object' && node !== null && 'type' in node && node.type === 'TSNonNullExpression' && 'expression' in node;
+};
+const isNthCall = node => {
+  return isCallExpressionNode(node) && isMemberExpressionNode(node.callee) && !node.callee.computed && isIdentifierNode(node.callee.property) && node.callee.property.name === 'nth';
+};
+const containsNthCall = node => {
+  if (!node) {
+    return false;
+  }
+  if (isNthCall(node)) {
+    return true;
+  }
+  if (isCallExpressionNode(node)) {
+    return containsNthCall(node.callee) || node.arguments.some(containsNthCall);
+  }
+  if (isMemberExpressionNode(node)) {
+    return containsNthCall(node.object) || node.computed && containsNthCall(node.property);
+  }
+  if (isChainExpressionNode(node)) {
+    return containsNthCall(node.expression);
+  }
+  if (isTsAsExpressionNode(node)) {
+    return containsNthCall(node.expression);
+  }
+  if (isTsNonNullExpressionNode(node)) {
+    return containsNthCall(node.expression);
+  }
+  return false;
+};
+const hasLazyNthVariableName = node => {
+  return isIdentifierNode(node) && lazyNthVariableNamePattern.test(node.name);
+};
+const create = context => {
+  return {
+    VariableDeclarator(node) {
+      if (!isVariableDeclaratorNode(node)) {
+        return;
+      }
+      if (!hasLazyNthVariableName(node.id)) {
+        return;
+      }
+      if (!containsNthCall(node.init)) {
+        return;
+      }
+      context.report({
+        node: node.id,
+        messageId: 'noLazyNthVariableName'
+      });
+    }
+  };
+};
+
+const noLazyNthVariableName = {
   __proto__: null,
   create,
   meta
@@ -206,7 +293,8 @@ const plugin = {
   rules: {
     'no-direct-click': noDirectClick,
     'no-inline-locator-in-expect': noInlineLocatorInExpect,
-    'no-inline-nth-in-expect': noInlineNthInExpect
+    'no-inline-nth-in-expect': noInlineNthInExpect,
+    'no-lazy-nth-variable-name': noLazyNthVariableName
   },
   configs: {}
 };
@@ -218,7 +306,8 @@ const recommended = [{
   rules: {
     'e2e/no-direct-click': 'error',
     'e2e/no-inline-locator-in-expect': 'error',
-    'e2e/no-inline-nth-in-expect': 'error'
+    'e2e/no-inline-nth-in-expect': 'error',
+    'e2e/no-lazy-nth-variable-name': 'error'
   }
 }];
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/eslint-plugin-e2e",
-  "version": "10.1.0",
+  "version": "10.2.0",
   "main": "dist/index.js",
   "repository": {
     "type": "git",