@lvce-editor/eslint-plugin-devcontainer 18.9.0 → 18.10.0

package/dist/index.js

@@ -29,8 +29,8 @@ const findMember = (node, name) => {
   return undefined;
 };
 
-const defaultAllowedImages = ['mcr.microsoft.com/devcontainers/javascript-node:24'];
-const meta$2 = {
+const defaultAllowedImages = ['mcr.microsoft.com/devcontainers/javascript-node:24', 'mcr.microsoft.com/devcontainers/javascript-node:26'];
+const meta$3 = {
   docs: {
     description: 'Ensure that the devcontainer image is allowed'
   },
@@ -61,7 +61,7 @@ const getAllowedImages = context => {
   }
   return defaultAllowedImages;
 };
-const create$2 = context => {
+const create$3 = context => {
   const allowedImages = new Set(getAllowedImages(context));
   return {
     Document(node) {
@@ -102,8 +102,62 @@ const create$2 = context => {
 
 const allowedImage = {
   __proto__: null,
-  create: create$2,
+  create: create$3,
   defaultAllowedImages,
+  meta: meta$3
+};
+
+// cspell:ignore moby
+
+const dockerInDockerFeature = 'ghcr.io/devcontainers/features/docker-in-docker';
+const expectedFeature = `${dockerInDockerFeature}:4`;
+const meta$2 = {
+  docs: {
+    description: 'Require docker-in-docker version 4 with moby disabled'
+  },
+  messages: {
+    invalidVersion: 'docker-in-docker devcontainer feature must use version 4',
+    mobyMustBeFalse: 'docker-in-docker devcontainer feature must configure "moby": false'
+  },
+  schema: [],
+  type: 'problem'
+};
+const create$2 = context => {
+  return {
+    Document(node) {
+      const features = findMember(node.body, 'features');
+      if (!features || !isObjectNode(features.value)) {
+        return;
+      }
+      for (const feature of features.value.members) {
+        if (!isStringNode(feature.name)) {
+          continue;
+        }
+        const name = feature.name.value;
+        if (name !== dockerInDockerFeature && !name.startsWith(`${dockerInDockerFeature}:`) && !name.startsWith(`${dockerInDockerFeature}@`)) {
+          continue;
+        }
+        if (name !== expectedFeature) {
+          context.report({
+            loc: feature.name.loc,
+            messageId: 'invalidVersion'
+          });
+        }
+        const moby = findMember(feature.value, 'moby');
+        if (!moby || moby.value.type !== 'Boolean' || moby.value.value !== false) {
+          context.report({
+            loc: (moby || feature).value.loc,
+            messageId: 'mobyMustBeFalse'
+          });
+        }
+      }
+    }
+  };
+};
+
+const dockerInDocker = {
+  __proto__: null,
+  create: create$2,
   meta: meta$2
 };
 
@@ -265,6 +319,7 @@ const plugin = {
   },
   rules: {
     'allowed-image': allowedImage,
+    'docker-in-docker': dockerInDocker,
     'post-create-command': postCreateCommand,
     'require-desktop-lite-feature': requireDesktopLiteFeature
   }
@@ -282,6 +337,7 @@ const recommended = [{
   },
   rules: {
     'devcontainer/allowed-image': 'error',
+    'devcontainer/docker-in-docker': 'error',
     'devcontainer/post-create-command': 'off',
     'devcontainer/require-desktop-lite-feature': 'error'
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/eslint-plugin-devcontainer",
-  "version": "18.9.0",
+  "version": "18.10.0",
   "main": "dist/index.js",
   "type": "module",
   "license": "MIT",