@lvce-editor/eslint-plugin-devcontainer 18.15.1 → 18.16.0

package/dist/index.js

@@ -1,6 +1,6 @@
 import json from '@eslint/json';
-import { existsSync, readFileSync } from 'node:fs';
-import { join } from 'node:path';
+import { readFileSync, existsSync } from 'node:fs';
+import { join, dirname } from 'node:path';
 
 const isObjectNode = node => {
   return node && node.type === 'Object';
@@ -30,7 +30,7 @@ const findMember = (node, name) => {
 };
 
 const defaultAllowedImages = ['mcr.microsoft.com/devcontainers/javascript-node:24', 'mcr.microsoft.com/devcontainers/javascript-node:26'];
-const meta$3 = {
+const meta$4 = {
   docs: {
     description: 'Ensure that the devcontainer image is allowed'
   },
@@ -61,7 +61,7 @@ const getAllowedImages = context => {
   }
   return defaultAllowedImages;
 };
-const create$3 = context => {
+const create$4 = context => {
   const allowedImages = new Set(getAllowedImages(context));
   return {
     Document(node) {
@@ -102,16 +102,16 @@ const create$3 = context => {
 
 const allowedImage = {
   __proto__: null,
-  create: create$3,
+  create: create$4,
   defaultAllowedImages,
-  meta: meta$3
+  meta: meta$4
 };
 
 // cspell:ignore moby
 
 const dockerInDockerFeature = 'ghcr.io/devcontainers/features/docker-in-docker';
 const expectedFeature = `${dockerInDockerFeature}:4`;
-const meta$2 = {
+const meta$3 = {
   docs: {
     description: 'Require docker-in-docker version 4 with moby disabled'
   },
@@ -122,7 +122,7 @@ const meta$2 = {
   schema: [],
   type: 'problem'
 };
-const create$2 = context => {
+const create$3 = context => {
   return {
     Document(node) {
       const features = findMember(node.body, 'features');
@@ -156,6 +156,58 @@ const create$2 = context => {
 };
 
 const dockerInDocker = {
+  __proto__: null,
+  create: create$3,
+  meta: meta$3
+};
+
+const nodeImagePattern = /^mcr\.microsoft\.com\/devcontainers\/javascript-node:(\d+)(?:\.|$)/u;
+const nvmrcPattern = /^v?(\d+)(?:\.|$)/u;
+const meta$2 = {
+  docs: {
+    description: 'Ensure that the devcontainer Node.js image major matches .nvmrc'
+  },
+  messages: {
+    nodeMajorMismatch: 'devcontainer image Node.js major ({{imageMajor}}) must match .nvmrc major ({{nvmrcMajor}})'
+  },
+  type: 'problem'
+};
+const getRepositoryRoot = filename => dirname(dirname(filename));
+const readNvmrcMajor = filename => {
+  try {
+    const nvmrc = readFileSync(join(getRepositoryRoot(filename), '.nvmrc'), 'utf8').trim();
+    return nvmrc.match(nvmrcPattern)?.[1];
+  } catch {
+    return undefined;
+  }
+};
+const create$2 = context => {
+  return {
+    Document(node) {
+      if (!isObjectNode(node.body)) {
+        return;
+      }
+      const image = findMember(node.body, 'image');
+      if (!image || !isStringNode(image.value)) {
+        return;
+      }
+      const imageMajor = image.value.value.match(nodeImagePattern)?.[1];
+      const nvmrcMajor = readNvmrcMajor(context.filename);
+      if (imageMajor && nvmrcMajor && imageMajor !== nvmrcMajor) {
+        context.report({
+          data: {
+            imageMajor,
+            nvmrcMajor
+          },
+          loc: image.value.loc,
+          messageId: 'nodeMajorMismatch'
+        });
+      }
+    }
+  };
+};
+
+const nodeVersion = {
   __proto__: null,
   create: create$2,
   meta: meta$2
@@ -320,6 +372,7 @@ const plugin = {
   rules: {
     'allowed-image': allowedImage,
     'docker-in-docker': dockerInDocker,
+    'node-version': nodeVersion,
     'post-create-command': postCreateCommand,
     'require-desktop-lite-feature': requireDesktopLiteFeature
   }
@@ -338,6 +391,7 @@ const recommended = [{
   rules: {
     'devcontainer/allowed-image': 'error',
     'devcontainer/docker-in-docker': 'error',
+    'devcontainer/node-version': 'error',
     'devcontainer/post-create-command': 'off',
     'devcontainer/require-desktop-lite-feature': 'error'
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lvce-editor/eslint-plugin-devcontainer",
-  "version": "18.15.1",
+  "version": "18.16.0",
   "main": "dist/index.js",
   "type": "module",
   "license": "MIT",