@luxass/eslint-config 4.12.0 → 4.13.0

package/dist/index.js

@@ -237,6 +237,7 @@ async function astro(options = {}) {
       },
       processor: "astro/client-side-ts",
       rules: {
+        // use recommended rules
         "astro/missing-client-only-directive-value": "error",
         "astro/no-conflict-set-directives": "error",
         "astro/no-deprecated-astro-canonicalurl": "error",
@@ -245,12 +246,11 @@ async function astro(options = {}) {
         "astro/no-deprecated-getentrybyslug": "error",
         "astro/no-set-html-directive": "off",
         "astro/no-unused-define-vars-in-style": "error",
-        "astro/semi": "error",
+        "astro/semi": "off",
         "astro/valid-compile": "error",
         ...stylistic2 ? {
           "style/indent": "off",
           "style/jsx-closing-tag-location": "off",
-          "style/jsx-indent": "off",
           "style/jsx-one-expression-per-line": "off",
           "style/no-multiple-empty-lines": "off"
         } : {},
@@ -276,9 +276,8 @@ async function comments() {
         "eslint-comments/no-duplicate-disable": "error",
         // https://github.com/eslint-community/eslint-plugin-eslint-comments/blob/main/docs/rules/no-unlimited-disable.md
         "eslint-comments/no-unlimited-disable": "error",
-        // Deprecated in favor of official reportUnusedDisableDirectives
-        // https://github.com/eslint-community/eslint-plugin-eslint-comments/issues/133
-        "eslint-comments/no-unused-enable": "off"
+        // https://github.com/eslint-community/eslint-plugin-eslint-comments/blob/main/docs/rules/no-unused-enable.md
+        "eslint-comments/no-unused-enable": "error"
       }
     }
   ];
@@ -288,17 +287,19 @@ async function comments() {
 async function disables() {
   return [
     {
-      files: [`scripts/${GLOB_SRC}`],
+      files: [`**/scripts/${GLOB_SRC}`],
       name: "luxass/disables/scripts",
       rules: {
+        "antfu/no-top-level-await": "off",
         "no-console": "off",
         "ts/explicit-function-return-type": "off"
       }
     },
     {
-      files: [`cli/${GLOB_SRC}`, `cli.${GLOB_SRC_EXT}`],
+      files: [`**/cli/${GLOB_SRC}`, `**/cli.${GLOB_SRC_EXT}`],
       name: "luxass/disables/cli",
       rules: {
+        "antfu/no-top-level-await": "off",
         "no-console": "off"
       }
     },
@@ -321,17 +322,27 @@ async function disables() {
       }
     },
     {
-      files: ["**/*.{test,spec}.([tj])s?(x)"],
-      name: "luxass/disables/test",
+      files: ["**/*.js", "**/*.cjs"],
+      name: "luxass/disables/cjs",
       rules: {
-        "no-unused-expressions": "off"
+        "ts/no-require-imports": "off"
       }
     },
     {
-      files: ["**/*.js", "**/*.cjs"],
-      name: "luxass/disables/cjs",
+      name: "luxass/disables/github-actions",
+      files: ["**/.github/workflows/*.{yml,yaml}"],
       rules: {
-        "ts/no-require-imports": "off"
+        // GitHub Actions supports empty values to enable features
+        "yaml/no-empty-mapping-value": "off"
+      }
+    },
+    {
+      files: [`**/*.config.${GLOB_SRC_EXT}`, `**/*.config.*.${GLOB_SRC_EXT}`],
+      name: "luxass/disables/config-files",
+      rules: {
+        "antfu/no-top-level-await": "off",
+        "no-console": "off",
+        "ts/explicit-function-return-type": "off"
       }
     }
   ];
@@ -387,6 +398,16 @@ async function stylistic(options = {}) {
 }
 
 // src/configs/formatters.ts
+function mergePrettierOptions(options, overrides = {}) {
+  return {
+    ...options,
+    ...overrides,
+    plugins: [
+      ...overrides.plugins || [],
+      ...options.plugins || []
+    ]
+  };
+}
 async function formatters(options = {}, stylistic2 = {}) {
   if (options === true) {
     options = {
@@ -449,10 +470,9 @@ async function formatters(options = {}, stylistic2 = {}) {
         rules: {
           "format/prettier": [
             "error",
-            {
-              ...prettierOptions,
+            mergePrettierOptions(prettierOptions, {
               parser: "css"
-            }
+            })
           ]
         }
       },
@@ -465,10 +485,9 @@ async function formatters(options = {}, stylistic2 = {}) {
         rules: {
           "format/prettier": [
             "error",
-            {
-              ...prettierOptions,
+            mergePrettierOptions(prettierOptions, {
               parser: "scss"
-            }
+            })
           ]
         }
       },
@@ -481,10 +500,9 @@ async function formatters(options = {}, stylistic2 = {}) {
         rules: {
           "format/prettier": [
             "error",
-            {
-              ...prettierOptions,
+            mergePrettierOptions(prettierOptions, {
               parser: "less"
-            }
+            })
           ]
         }
       }
@@ -500,10 +518,9 @@ async function formatters(options = {}, stylistic2 = {}) {
       rules: {
         "format/prettier": [
           "error",
-          {
-            ...prettierOptions,
+          mergePrettierOptions(prettierOptions, {
             parser: "html"
-          }
+          })
         ]
       }
     });
@@ -519,11 +536,10 @@ async function formatters(options = {}, stylistic2 = {}) {
       rules: {
         [`format/${formater}`]: [
           "error",
-          formater === "prettier" ? {
-            ...prettierOptions,
+          formater === "prettier" ? mergePrettierOptions(prettierOptions, {
             embeddedLanguageFormatting: "off",
             parser: "markdown"
-          } : {
+          }) : {
             ...dprintOptions,
             language: "markdown"
           }
@@ -541,13 +557,12 @@ async function formatters(options = {}, stylistic2 = {}) {
       rules: {
         "format/prettier": [
           "error",
-          {
-            ...prettierOptions,
+          mergePrettierOptions(prettierOptions, {
             parser: "astro",
             plugins: [
               "prettier-plugin-astro"
             ]
-          }
+          })
         ]
       }
     });
@@ -562,10 +577,9 @@ async function formatters(options = {}, stylistic2 = {}) {
       rules: {
         "format/prettier": [
           "error",
-          {
-            ...prettierOptions,
+          mergePrettierOptions(prettierOptions, {
             parser: "graphql"
-          }
+          })
         ]
       }
     });
@@ -664,6 +678,7 @@ async function javascript(options = {}) {
           "error",
           { enforceForClassMembers: true, setWithoutGet: true }
         ],
+        "antfu/no-top-level-await": "error",
         "array-callback-return": "error",
         "block-scoped-var": "error",
         "constructor-super": "error",
@@ -1060,6 +1075,7 @@ async function markdown(options = {}) {
         }
       },
       rules: {
+        "antfu/no-top-level-await": "off",
         "import/newline-after-import": "off",
         "no-alert": "off",
         "no-console": "off",
@@ -1074,6 +1090,7 @@ async function markdown(options = {}) {
         "style/comma-dangle": "off",
         "style/eol-last": "off",
         "ts/consistent-type-imports": "off",
+        "ts/explicit-function-return-type": "off",
         "ts/no-namespace": "off",
         "ts/no-redeclare": "off",
         "ts/no-require-imports": "off",
@@ -1126,12 +1143,12 @@ async function perfectionist() {
         "perfectionist/sort-exports": ["error", { order: "asc", type: "natural" }],
         "perfectionist/sort-imports": ["error", {
           groups: [
+            "type",
+            ["parent-type", "sibling-type", "index-type"],
             "builtin",
             "external",
-            "type",
             ["internal", "internal-type"],
             ["parent", "sibling", "index"],
-            ["parent-type", "sibling-type", "index-type"],
             "side-effect",
             "object",
             "unknown"
@@ -1158,34 +1175,41 @@ var RemixPackages = [
   "@remix-run/serve",
   "@remix-run/dev"
 ];
+var NextJsPackages = [
+  "next"
+];
 async function react(options = {}) {
   const {
     files = [GLOB_JS, GLOB_JSX, GLOB_TS, GLOB_TSX],
-    overrides = {}
+    overrides = {},
+    filesTypeAware = [GLOB_TS, GLOB_TSX],
+    ignoresTypeAware = [
+      `${GLOB_MARKDOWN}/**`,
+      GLOB_ASTRO_TS
+    ],
+    tsconfigPath
   } = options;
   await ensure([
     "@eslint-react/eslint-plugin",
     "eslint-plugin-react-hooks",
     "eslint-plugin-react-refresh"
   ]);
-  const tsconfigPath = options?.tsconfigPath ? toArray(options.tsconfigPath) : void 0;
   const isTypeAware = !!tsconfigPath;
+  const typeAwareRules = {
+    "react/no-leaked-conditional-rendering": "warn"
+  };
   const [
     pluginReact,
     pluginReactHooks,
-    pluginReactRefresh,
-    parserTs
+    pluginReactRefresh
   ] = await Promise.all([
     interop(import("@eslint-react/eslint-plugin")),
     interop(import("eslint-plugin-react-hooks")),
-    interop(import("eslint-plugin-react-refresh")),
-    interop(import("@typescript-eslint/parser"))
+    interop(import("eslint-plugin-react-refresh"))
   ]);
-  const isAllowConstantExport = ReactRefreshAllowConstantExportPackages.some(
-    (i) => isPackageExists2(i)
-  );
+  const isAllowConstantExport = ReactRefreshAllowConstantExportPackages.some((i) => isPackageExists2(i));
   const isUsingRemix = RemixPackages.some((i) => isPackageExists2(i));
-  const isUsingNext = isPackageExists2("next");
+  const isUsingNext = NextJsPackages.some((i) => isPackageExists2(i));
   const plugins = pluginReact.configs.all.plugins;
   return [
     {
@@ -1203,12 +1227,10 @@ async function react(options = {}) {
       name: "luxass/react/rules",
       files,
       languageOptions: {
-        parser: parserTs,
         parserOptions: {
           ecmaFeatures: {
             jsx: true
-          },
-          ...isTypeAware ? { project: tsconfigPath } : {}
+          }
         },
         sourceType: "module"
       },
@@ -1235,6 +1257,13 @@ async function react(options = {}) {
             allowConstantExport: isAllowConstantExport,
             allowExportNames: [
               ...isUsingNext ? [
+                "dynamic",
+                "dynamicParams",
+                "revalidate",
+                "fetchCache",
+                "runtime",
+                "preferredRegion",
+                "maxDuration",
                 "config",
                 "runtime",
                 "generateStaticParams",
@@ -1290,13 +1319,18 @@ async function react(options = {}) {
         "react/prefer-destructuring-assignment": "warn",
         "react/prefer-shorthand-boolean": "warn",
         "react/prefer-shorthand-fragment": "warn",
-        ...isTypeAware ? {
-          "react/no-leaked-conditional-rendering": "warn"
-        } : {},
         // overrides
         ...overrides
       }
-    }
+    },
+    ...isTypeAware ? [{
+      files: filesTypeAware,
+      ignores: ignoresTypeAware,
+      name: "antfu/react/type-aware-rules",
+      rules: {
+        ...typeAwareRules
+      }
+    }] : []
   ];
 }
 
@@ -1635,7 +1669,6 @@ async function test(options = {}) {
       name: "luxass/test/rules",
       files,
       rules: {
-        "node/prefer-global/process": "off",
         "test/consistent-test-it": [
           "error",
           { fn: "it", withinDescribe: "it" }
@@ -1645,7 +1678,13 @@ async function test(options = {}) {
         "test/no-focused-tests": isInEditor ? "off" : ["error", { fixable: true }],
         "test/prefer-hooks-in-order": "error",
         "test/prefer-lowercase-title": "error",
-        "ts/explicit-function-return-type": "off",
+        // Disables
+        ...{
+          "antfu/no-top-level-await": "off",
+          "no-unused-expressions": "off",
+          "node/prefer-global/process": "off",
+          "ts/explicit-function-return-type": "off"
+        },
         ...overrides
       }
     }
@@ -1719,6 +1758,7 @@ async function typescript(options = {}) {
     exts = [],
     overrides = {},
     parserOptions = {},
+    overridesTypeAware = {},
     type = "app"
   } = options ?? {};
   const files = options.files ?? [
@@ -1843,8 +1883,13 @@ async function typescript(options = {}) {
         "ts/no-invalid-this": "error",
         "ts/no-invalid-void-type": "off",
         "ts/no-non-null-assertion": "off",
-        "ts/no-redeclare": "error",
+        "ts/no-redeclare": ["error", { builtinGlobals: false }],
         "ts/no-require-imports": "error",
+        "ts/no-unused-expressions": ["error", {
+          allowShortCircuit: true,
+          allowTaggedTemplates: true,
+          allowTernary: true
+        }],
         "ts/no-unused-vars": "off",
         "ts/no-use-before-define": [
           "error",
@@ -1868,7 +1913,10 @@ async function typescript(options = {}) {
       files: filesTypeAware,
       ignores: ignoresTypeAware,
       name: "luxass/typescript/rules-type-aware",
-      rules: typeAwareRules
+      rules: {
+        ...typeAwareRules,
+        ...overridesTypeAware
+      }
     }] : []
   ];
 }
@@ -2052,7 +2100,9 @@ async function vue(options = {}) {
         ...pluginVue.configs["vue3-essential"].rules,
         ...pluginVue.configs["vue3-strongly-recommended"].rules,
         ...pluginVue.configs["vue3-recommended"].rules,
+        "antfu/no-top-level-await": "off",
         "node/prefer-global/process": "off",
+        "ts/explicit-function-return-type": "off",
         "vue/block-order": [
           "error",
           {
@@ -2213,10 +2263,7 @@ async function yaml(options = {}) {
           "yaml/indent": ["error", indent === "tab" ? 2 : indent],
           "yaml/key-spacing": "error",
           "yaml/no-tab-indent": "error",
-          "yaml/quotes": [
-            "error",
-            { avoidEscape: false, prefer: quotes }
-          ],
+          "yaml/quotes": ["error", { avoidEscape: true, prefer: quotes === "backtick" ? "single" : quotes }],
           "yaml/spaced-comment": "error"
         } : {},
         ...overrides

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@luxass/eslint-config",
-  "version": "4.12.0",
+  "version": "4.13.0",
   "description": "ESLint config for @luxass",
   "type": "module",
   "author": {
@@ -8,7 +8,7 @@
     "email": "lucasnrgaard@gmail.com",
     "url": "https://luxass.dev"
   },
-  "packageManager": "pnpm@9.10.0",
+  "packageManager": "pnpm@9.14.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -42,7 +42,7 @@
     "dev": "pnpm eslint-config-inspector --config eslint.config.mjs",
     "build:inspector": "pnpm build && pnpm eslint-config-inspector build",
     "test": "vitest --run",
-    "typegen": "pnpx tsx ./scripts/typegen.ts",
+    "typegen": "tsx ./scripts/typegen.ts",
     "test:watch": "vitest",
     "lint": "eslint --flag unstable_ts_config .",
     "typecheck": "tsc --noEmit"
@@ -90,67 +90,67 @@
   },
   "dependencies": {
     "@antfu/install-pkg": "^0.4.1",
-    "@clack/prompts": "^0.7.0",
-    "@eslint-community/eslint-plugin-eslint-comments": "^4.4.0",
-    "@eslint/markdown": "^6.1.0",
-    "@stylistic/eslint-plugin": "^2.8.0",
-    "@typescript-eslint/eslint-plugin": "^8.5.0",
-    "@typescript-eslint/parser": "^8.5.0",
-    "@vitest/eslint-plugin": "^1.1.0",
+    "@clack/prompts": "^0.8.2",
+    "@eslint-community/eslint-plugin-eslint-comments": "^4.4.1",
+    "@eslint/markdown": "^6.2.1",
+    "@stylistic/eslint-plugin": "^2.11.0",
+    "@typescript-eslint/eslint-plugin": "^8.15.0",
+    "@typescript-eslint/parser": "^8.15.0",
+    "@vitest/eslint-plugin": "^1.1.10",
     "eslint-config-flat-gitignore": "^0.3.0",
     "eslint-flat-config-utils": "^0.4.0",
     "eslint-merge-processors": "^0.1.0",
-    "eslint-plugin-antfu": "^2.6.0",
-    "eslint-plugin-import-x": "^4.2.1",
-    "eslint-plugin-jsdoc": "^50.2.2",
-    "eslint-plugin-jsonc": "^2.16.0",
-    "eslint-plugin-n": "^17.10.2",
-    "eslint-plugin-perfectionist": "^3.5.0",
-    "eslint-plugin-regexp": "^2.6.0",
+    "eslint-plugin-antfu": "^2.7.0",
+    "eslint-plugin-import-x": "^4.4.3",
+    "eslint-plugin-jsdoc": "^50.5.0",
+    "eslint-plugin-jsonc": "^2.18.2",
+    "eslint-plugin-n": "^17.14.0",
+    "eslint-plugin-perfectionist": "^4.0.3",
+    "eslint-plugin-regexp": "^2.7.0",
     "eslint-plugin-toml": "^0.11.1",
-    "eslint-plugin-unicorn": "^55.0.0",
-    "eslint-plugin-unused-imports": "^4.1.3",
-    "eslint-plugin-vue": "^9.28.0",
-    "eslint-plugin-yml": "^1.14.0",
+    "eslint-plugin-unicorn": "^56.0.1",
+    "eslint-plugin-unused-imports": "^4.1.4",
+    "eslint-plugin-vue": "^9.31.0",
+    "eslint-plugin-yml": "^1.15.0",
     "eslint-processor-vue-blocks": "^0.1.2",
-    "globals": "^15.9.0",
+    "globals": "^15.12.0",
     "jsonc-eslint-parser": "^2.4.0",
-    "local-pkg": "^0.5.0",
+    "local-pkg": "^0.5.1",
     "parse-gitignore": "^2.0.0",
     "toml-eslint-parser": "^0.10.0",
     "vue-eslint-parser": "^9.4.3",
     "yaml-eslint-parser": "^1.2.3"
   },
   "devDependencies": {
-    "@eslint-react/eslint-plugin": "^1.14.0",
-    "@eslint/config-inspector": "^0.5.4",
-    "@stylistic/eslint-plugin-migrate": "^2.8.0",
-    "@types/eslint": "^9.6.1",
-    "@types/estree": "^1.0.5",
-    "@types/node": "^20.14.12",
-    "@typescript-eslint/rule-tester": "^8.5.0",
-    "@unocss/eslint-plugin": "^0.62.3",
-    "astro-eslint-parser": "^1.0.2",
-    "eslint": "^9.10.0",
-    "eslint-plugin-astro": "^1.2.3",
+    "@eslint-react/eslint-plugin": "^1.17.1",
+    "@eslint/config-inspector": "^0.5.6",
+    "@stylistic/eslint-plugin-migrate": "^2.11.0",
+    "@types/estree": "^1.0.6",
+    "@types/node": "^22.9.0",
+    "@typescript-eslint/rule-tester": "^8.15.0",
+    "@unocss/eslint-plugin": "^0.64.1",
+    "astro-eslint-parser": "^1.1.0",
+    "eslint": "^9.15.0",
+    "eslint-plugin-astro": "^1.3.1",
     "eslint-plugin-format": "^0.1.2",
-    "eslint-plugin-react-hooks": "^4.6.2",
-    "eslint-plugin-react-refresh": "^0.4.11",
-    "eslint-plugin-tailwindcss": "^3.17.4",
+    "eslint-plugin-react-hooks": "^5.0.0",
+    "eslint-plugin-react-refresh": "^0.4.14",
+    "eslint-plugin-tailwindcss": "^3.17.5",
     "eslint-typegen": "^0.3.2",
-    "jiti": "^1.21.6",
+    "jiti": "^2.4.0",
     "prettier-plugin-astro": "^0.14.1",
-    "tailwindcss": "^3.4.10",
-    "tsup": "^8.2.4",
-    "typescript": "^5.6.2",
-    "unocss": "^0.62.3",
-    "vitest": "^2.0.5",
-    "vue": "^3.5.4"
+    "tailwindcss": "^3.4.15",
+    "tsup": "^8.3.5",
+    "tsx": "^4.19.2",
+    "typescript": "^5.7.2",
+    "unocss": "^0.64.1",
+    "vitest": "^2.1.5",
+    "vue": "^3.5.13"
   },
   "resolutions": {
-    "@eslint-community/eslint-utils": "^4.4.0",
-    "@typescript-eslint/utils": "^8.5.0",
-    "eslint": "^9.10.0",
-    "tsx": "^4.19.0"
+    "@eslint-community/eslint-utils": "^4.4.1",
+    "@typescript-eslint/utils": "^8.15.0",
+    "eslint": "^9.15.0",
+    "tsx": "^4.19.2"
   }
 }