@lunora/advisor 1.0.0-alpha.2 → 1.0.0-alpha.21

package/dist/packem_shared/outputProjectionMissingOnPublicRead-Bl5IMx0k.mjs

@@ -0,0 +1,51 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+import { P as PII_FIELD_NAMES } from './helpers-BySnKhVB.mjs';
+
+const outputProjectionMissingOnPublicRead = {
+  categories: ["SECURITY"],
+  description: "A `.public()` `query` returns raw table rows (no `.output(...)` projection, no `.use(mask(...))`) from a table carrying PII-named columns (`email`, `phone`, `ssn`, …). Every column ships to the caller, and a column added to the table later leaks by default.",
+  facing: "EXTERNAL",
+  level: "INFO",
+  name: "output_projection_missing_on_public_read",
+  remediation: "Add an explicit return projection to the public query — `.output(v.object({ … }))` listing only the fields a client needs — or apply a `.use(mask(...))` policy to the PII columns. This makes the exposed shape intentional and stops a newly-added column from leaking through this query by default.",
+  run: (context) => {
+    if (context.rawRowReturns === void 0) {
+      return [];
+    }
+    const piiColumnsByTable = /* @__PURE__ */ new Map();
+    for (const table of context.schema.tables) {
+      const piiColumns = table.fields.filter((field) => PII_FIELD_NAMES.has(field));
+      if (piiColumns.length > 0) {
+        piiColumnsByTable.set(table.name, piiColumns);
+      }
+    }
+    const findings = [];
+    for (const row of context.rawRowReturns) {
+      if (row.visibility !== "public" || row.usesOutput || row.usesMask || row.table === "") {
+        continue;
+      }
+      const piiColumns = piiColumnsByTable.get(row.table);
+      if (piiColumns === void 0) {
+        continue;
+      }
+      findings.push(
+        emit(outputProjectionMissingOnPublicRead, {
+          cacheKey: `output_projection_missing_on_public_read:${row.file}:${row.line.toString()}`,
+          detail: `Public query \`${row.exportName}\` (${row.file}:${row.line.toString()}) returns raw \`${row.table}\` rows with no \`.output(...)\` projection — shipping PII column(s) ${piiColumns.join(", ")} to every caller, and any column added to \`${row.table}\` later leaks by default. Project the return with \`.output(v.object({ … }))\` or mask the PII columns.`,
+          metadata: {
+            columns: piiColumns,
+            exportName: row.exportName,
+            file: row.file,
+            line: row.line,
+            table: row.table
+          }
+        })
+      );
+    }
+    return findings;
+  },
+  source: "static",
+  title: "Public query returns raw rows with PII and no output projection"
+};
+
+export { outputProjectionMissingOnPublicRead as default };

package/dist/packem_shared/ownerFieldFromArgsNotAuth-mOw3hE5z.mjs

@@ -0,0 +1,26 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+
+const ownerFieldFromArgsNotAuth = {
+  categories: ["SECURITY"],
+  description: "A `ctx.db` write sets an ownership/identity column (`userId`, `ownerId`, `tenantId`, …) from the handler's `args`. The caller controls who the row belongs to, so any caller can write rows owned by another user or tenant — an act-as-any-user / cross-tenant IDOR.",
+  facing: "EXTERNAL",
+  level: "ERROR",
+  name: "owner_field_from_args_not_auth",
+  remediation: "Stamp the ownership column from the server-trusted identity (`ctx.auth.userId` / `ctx.identity`), never from request input. Drop the field from the accepted `args` so a caller cannot supply it.",
+  run: (context) => {
+    if (context.ownerFieldWrites === void 0) {
+      return [];
+    }
+    return context.ownerFieldWrites.map(
+      (write) => emit(ownerFieldFromArgsNotAuth, {
+        cacheKey: `owner_field_from_args_not_auth:${write.file}:${write.line.toString()}:${write.field}`,
+        detail: `\`${write.method}\` in \`${write.exportName}\` (${write.file}:${write.line.toString()}) sets the ownership field \`${write.field}\` from \`args\` instead of the server-trusted identity — any caller can write rows owned by another user/tenant (IDOR). Stamp \`${write.field}\` from \`ctx.auth\`/\`ctx.identity\`, never from request input.`,
+        metadata: { exportName: write.exportName, field: write.field, file: write.file, line: write.line, method: write.method }
+      })
+    );
+  },
+  source: "static",
+  title: "Ownership field written from args, not server identity"
+};
+
+export { ownerFieldFromArgsNotAuth as default };

package/dist/packem_shared/paymentCreateWithoutAuthorize-BYm4JLxo.mjs

@@ -0,0 +1,26 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+
+const paymentCreateWithoutAuthorize = {
+  categories: ["SECURITY"],
+  description: "`createPayment({...})` was constructed without an `authorize` callback, so its access-control gate never runs — any caller that reaches a payment reference id can drive a charge, refund, or subscription change against it (a broken-access-control / IDOR risk on money movement).",
+  facing: "EXTERNAL",
+  level: "ERROR",
+  name: "payment_create_without_authorize",
+  remediation: "Pass an `authorize(referenceId)` callback to `createPayment({...})` that verifies the current caller (via `ctx.auth`) owns the payment/subscription reference before the operation runs. Prefer the `ctx.payments` accessor, which is authorization-scoped by default.",
+  run: (context) => {
+    if (context.configCalls === void 0) {
+      return [];
+    }
+    return context.configCalls.filter((call) => call.callee === "createPayment" && call.analyzable && !call.presentKeys.includes("authorize")).map(
+      (call) => emit(paymentCreateWithoutAuthorize, {
+        cacheKey: `payment_create_without_authorize:${call.file}:${call.line.toString()}`,
+        detail: `\`createPayment({...})\` in ${call.file}:${call.line.toString()} has no \`authorize\` callback — its access-control gate never runs, so any caller reaching the payment reference can move money against it. Add an \`authorize(referenceId)\` gate that checks \`ctx.auth\` ownership before the operation.`,
+        metadata: { callee: call.callee, file: call.file, line: call.line }
+      })
+    );
+  },
+  source: "static",
+  title: "createPayment without an authorize gate"
+};
+
+export { paymentCreateWithoutAuthorize as default };

package/dist/packem_shared/paymentWebhookWideTolerance-D9QQJMJq.mjs

@@ -0,0 +1,35 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+
+const WIDE_TOLERANCE_THRESHOLD_SECONDS = 60 * 60;
+const paymentWebhookWideTolerance = {
+  categories: ["SECURITY"],
+  description: "A payment webhook adapter configured with an implausibly wide `webhookToleranceSeconds` (over an hour). The timestamp tolerance is the webhook replay window; widening it far past the 300s default keeps captured signed events replayable long after capture, defeating the replay check.",
+  facing: "EXTERNAL",
+  level: "WARN",
+  name: "payment_webhook_wide_tolerance",
+  remediation: "Keep `webhookToleranceSeconds` at or near the 300s default — just enough for clock skew. If a wide window was set to work around retries or backfills, handle those with idempotency on the event id instead, not by loosening the replay-window guard.",
+  run: (context) => {
+    if (context.paymentWebhooks === void 0) {
+      return [];
+    }
+    const isWide = (row) => row.toleranceSeconds !== void 0 && row.toleranceSeconds >= WIDE_TOLERANCE_THRESHOLD_SECONDS;
+    return context.paymentWebhooks.filter((row) => isWide(row)).map((row) => {
+      const location = `\`${row.exportName}\` (${row.file}:${row.line.toString()})`;
+      return emit(paymentWebhookWideTolerance, {
+        cacheKey: `payment_webhook_wide_tolerance:${row.file}:${row.line.toString()}`,
+        detail: `\`${row.callee}\` in ${location} sets \`webhookToleranceSeconds\` to ${(row.toleranceSeconds ?? 0).toString()}s (default 300s). That replay window keeps captured signed events valid long after capture.`,
+        metadata: {
+          callee: row.callee,
+          exportName: row.exportName,
+          file: row.file,
+          line: row.line,
+          toleranceSeconds: row.toleranceSeconds
+        }
+      });
+    });
+  },
+  source: "static",
+  title: "Payment webhook replay-tolerance window is implausibly wide"
+};
+
+export { paymentWebhookWideTolerance as default };

package/dist/packem_shared/plaintextSecretInWranglerVariables-NKO4YkKf.mjs

@@ -0,0 +1,35 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+
+const plaintextSecretInWranglerVariables = {
+  categories: ["SECURITY"],
+  description: "A plaintext secret is committed to `wrangler.jsonc`'s `vars` block. `vars` are cleartext — baked into the deployed Worker and checked into source control — so the secret leaks via the repo and the bundle, and rotating it needs a config edit plus a redeploy.",
+  facing: "INTERNAL",
+  level: "ERROR",
+  name: "plaintext_secret_in_wrangler_vars",
+  remediation: "Move the value out of `vars`: bind it through a Secrets Store (`ctx.secrets.get(<NAME>)`) or set it with `wrangler secret put <NAME>` and read it from `env.<NAME>`. Delete the `vars` entry and rotate the exposed value — assume it is already compromised. Public/publishable keys (name them `*_PUBLIC` / `*_PUBLISHABLE`) are exempt.",
+  run: (context) => {
+    if (context.wranglerVariables === void 0) {
+      return [];
+    }
+    const findings = [];
+    const occurrenceCount = /* @__PURE__ */ new Map();
+    for (const wranglerVariable of context.wranglerVariables) {
+      const baseKey = `${wranglerVariable.file}:${wranglerVariable.key}`;
+      const occurrence = (occurrenceCount.get(baseKey) ?? 0) + 1;
+      occurrenceCount.set(baseKey, occurrence);
+      const occurrenceSuffix = occurrence > 1 ? `:${occurrence.toString()}` : "";
+      findings.push(
+        emit(plaintextSecretInWranglerVariables, {
+          cacheKey: `plaintext_secret_in_wrangler_vars:${baseKey}${occurrenceSuffix}`,
+          detail: `The \`vars\` entry \`${wranglerVariable.key}\` in ${wranglerVariable.file} holds a plaintext ${wranglerVariable.kind.replaceAll("_", " ")} (${wranglerVariable.preview}). \`vars\` ship in cleartext to the deployed Worker and are committed to source control — move it to a Secrets Store binding or \`wrangler secret put\` and rotate the exposed value.`,
+          metadata: { file: wranglerVariable.file, key: wranglerVariable.key, kind: wranglerVariable.kind, preview: wranglerVariable.preview }
+        })
+      );
+    }
+    return findings;
+  },
+  source: "static",
+  title: "Plaintext secret in wrangler vars"
+};
+
+export { plaintextSecretInWranglerVariables as default };

package/dist/packem_shared/privilegedDispatchUnvalidatedPayload-5Forjckt.mjs

@@ -0,0 +1,37 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+
+const privilegedDispatchUnvalidatedPayload = {
+  categories: ["SECURITY"],
+  description: "A `defineQueue`/`defineWorkflow` handler forwards its untrusted payload (queue body / workflow params) straight into a `ctx.run` dispatch whose target is RLS-gated. The handler runs under the system identity with RLS disabled, so the target's row policy — the only thing guarding it — is bypassed, letting a caller act as any user / write across tenants.",
+  facing: "EXTERNAL",
+  level: "ERROR",
+  name: "privileged_dispatch_unvalidated_payload",
+  remediation: "Don't forward an unchecked queue body / workflow param into an RLS-gated function. Re-derive the ownership/identity keys from server-trusted state (or an argument you validate against it) before dispatching, or route the work through a function that re-checks the caller's identity rather than relying on the row policy the privileged handler skips.",
+  run: (context) => {
+    if (context.privilegedDispatches === void 0) {
+      return [];
+    }
+    const rlsProcedures = context.rlsProcedures ?? [];
+    const targetUsesRls = (targetFile, targetExport) => rlsProcedures.some((procedure) => procedure.usesRls && procedure.file === targetFile && procedure.exportName === targetExport);
+    return context.privilegedDispatches.filter((dispatch) => targetUsesRls(dispatch.targetFile, dispatch.targetExport)).map((dispatch) => {
+      const handlerKind = dispatch.dispatchKind === "queue" ? "queue" : "workflow";
+      const payloadSource = dispatch.dispatchKind === "queue" ? "queue message body" : "workflow params";
+      return emit(privilegedDispatchUnvalidatedPayload, {
+        cacheKey: `privileged_dispatch_unvalidated_payload:${dispatch.file}:${dispatch.line.toString()}`,
+        detail: `The ${handlerKind} handler \`${dispatch.handlerExport}\` (${dispatch.file}:${dispatch.line.toString()}) forwards its untrusted ${payloadSource} straight into \`${dispatch.targetFile}.${dispatch.targetExport}\`, which is guarded by \`.use(rls(...))\`. The handler runs under the system identity with RLS disabled, so the target's row policy is bypassed — any ownership/identity field the payload controls lets a caller act as another user or write across tenants. Re-derive the identity keys from server-trusted state before dispatching, or route through a function that re-checks the caller.`,
+        metadata: {
+          dispatchKind: dispatch.dispatchKind,
+          file: dispatch.file,
+          handlerExport: dispatch.handlerExport,
+          line: dispatch.line,
+          targetExport: dispatch.targetExport,
+          targetFile: dispatch.targetFile
+        }
+      });
+    });
+  },
+  source: "static",
+  title: "Privileged handler forwards untrusted payload into an RLS-gated function"
+};
+
+export { privilegedDispatchUnvalidatedPayload as default };

package/dist/packem_shared/privilegedFanoutFromPublicProcedure-D3dL01B8.mjs

@@ -0,0 +1,26 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+
+const privilegedFanoutFromPublicProcedure = {
+  categories: ["SECURITY"],
+  description: "A public procedure fans work out to a privileged dispatch surface (`ctx.scheduler.runAfter`/`runAt`, a `ctx.queues.<name>` send, or `ctx.workflows.<name>.create`) with no rate-limit guard. Each dispatch runs later under the system identity and bills the account, so an anonymous caller can amplify cost and flood the async surface in a loop.",
+  facing: "EXTERNAL",
+  level: "WARN",
+  name: "privileged_fanout_from_public_procedure",
+  remediation: "Gate the public entry point with a rate limit (`.use(rateLimit(...))` or a `protectPublic({ rateLimit })` bundle), or make the fan-out procedure internal and trigger it only from an authenticated, guarded path. Never expose an unbounded scheduler/queue/workflow dispatch to anonymous callers.",
+  run: (context) => {
+    if (context.procedureProtections === void 0) {
+      return [];
+    }
+    return context.procedureProtections.filter((procedure) => procedure.fanOut && procedure.visibility === "public" && !procedure.usesRateLimit).map(
+      (procedure) => emit(privilegedFanoutFromPublicProcedure, {
+        cacheKey: `privileged_fanout_from_public_procedure:${procedure.file}:${procedure.exportName}`,
+        detail: `\`${procedure.exportName}\` (${procedure.file}) is public and fans work out to a privileged dispatch surface (scheduler/queue/workflow) with no rate limit — an anonymous caller can drive that billable, system-identity dispatch in a loop. Add a rate-limit guard, or make it internal and trigger it from an authenticated path.`,
+        metadata: { exportName: procedure.exportName, file: procedure.file, kind: procedure.kind }
+      })
+    );
+  },
+  source: "static",
+  title: "Public procedure fans out to a privileged dispatch surface"
+};
+
+export { privilegedFanoutFromPublicProcedure as default };

package/dist/packem_shared/{publicMutationWithoutRatelimit-xBpJ6GWK.mjs → publicMutationWithoutRatelimit-DbIhgi7j.mjs}

@@ -1,4 +1,5 @@
 import { e as emit } from './finding-Dm_zvzS1.mjs';
+import { i as isPublicWrite } from './helpers-BySnKhVB.mjs';
 
 const SENSITIVE_NAME_RE = /contact|forgot|login|magic|otp|register|reset|signin|signup|subscribe|verify/iu;
 const publicMutationWithoutRatelimit = {
@@ -14,8 +15,7 @@ const publicMutationWithoutRatelimit = {
     }
     const findings = [];
     for (const procedure of context.procedureProtections) {
-      const isPublicWrite = procedure.visibility === "public" && (procedure.kind === "mutation" || procedure.kind === "action");
-      if (!isPublicWrite || procedure.usesRateLimit) {
+      if (!isPublicWrite(procedure) || procedure.usesRateLimit) {
         continue;
       }
       const sensitive = SENSITIVE_NAME_RE.test(procedure.exportName);

package/dist/packem_shared/publicTableRlsOptoutConfusion-Bn71yoD4.mjs

@@ -0,0 +1,38 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+import { o as ownershipOrPiiColumns } from './helpers-BySnKhVB.mjs';
+
+const publicTableRlsOptoutConfusion = {
+  categories: ["SECURITY"],
+  description: '`.public()` opts a table OUT of the schema\'s `.rls("required")` enforcement — it does not mean the table holds public data. A `.public()` table whose columns look ownership- or PII-shaped (`userId`, `email`, `ssn`, …) is exempt from the row-security guard, not "safe to expose".',
+  facing: "EXTERNAL",
+  level: "WARN",
+  name: "public_table_rls_optout_confusion",
+  remediation: 'Double-check this table actually needs the RLS opt-out. If it does not, remove `.public()` so `.rls("required")` covers it like every other table. If it genuinely must stay open (a shared lookup table, for instance), rename or comment it so the exemption is intentional rather than a name-implies-safety mistake, and make sure no procedure trusts `.public()` as an authorization boundary.',
+  run: (context) => {
+    if (context.schema.rlsMode !== "required") {
+      return [];
+    }
+    const findings = [];
+    for (const table of context.schema.tables) {
+      if (!table.isPublic) {
+        continue;
+      }
+      const flaggedColumns = ownershipOrPiiColumns(table);
+      if (flaggedColumns.length === 0) {
+        continue;
+      }
+      findings.push(
+        emit(publicTableRlsOptoutConfusion, {
+          cacheKey: `public_table_rls_optout_confusion:${table.name}`,
+          detail: `Table "${table.name}" is \`.public()\` (opted OUT of the schema's \`.rls("required")\` enforcement) but carries ownership/PII-shaped column(s): ${flaggedColumns.join(", ")}. \`.public()\` means "exempt from RLS", not "safe to expose" — confirm this table really needs the opt-out.`,
+          metadata: { columns: flaggedColumns, table: table.name }
+        })
+      );
+    }
+    return findings;
+  },
+  source: "static",
+  title: "Public table opts out of RLS but carries sensitive columns"
+};
+
+export { publicTableRlsOptoutConfusion as default };

package/dist/packem_shared/queueWithoutDlq-CSkGNb_0.mjs

@@ -0,0 +1,41 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+
+const queueWithoutDlq = {
+  categories: ["SCHEMA"],
+  description: "A queue consumer drops a message once it exhausts `maxRetries` (default 3) delivery attempts. Without a `deadLetterQueue`, that message is deleted permanently with no record — route exhausted messages to a DLQ so you can inspect, alert on, and replay them.",
+  facing: "INTERNAL",
+  level: "WARN",
+  name: "queue_without_dlq",
+  remediation: 'Add `deadLetterQueue: "<name>-dlq"` to the `defineQueue({...})` options and declare a consumer for that queue so exhausted messages are inspectable (an unconsumed DLQ still expires at the retention window). `vis generate lunora-queue` with the best-practice setup scaffolds both. If the queue is fire-and-forget and message loss is acceptable, this advisory can be ignored.',
+  run: (context) => {
+    if (context.queues === void 0) {
+      return [];
+    }
+    const dlqTargets = new Set(
+      context.queues.map((queue) => queue.tuning.deadLetterQueue).filter((name) => name !== void 0 && name !== "")
+    );
+    const findings = [];
+    for (const queue of context.queues) {
+      const dlq = queue.tuning.deadLetterQueue;
+      if (dlq !== void 0 && dlq !== "") {
+        continue;
+      }
+      if (dlqTargets.has(queue.name)) {
+        continue;
+      }
+      const maxRetries = typeof queue.tuning.maxRetries === "number" ? queue.tuning.maxRetries : 3;
+      findings.push(
+        emit(queueWithoutDlq, {
+          cacheKey: `queue_without_dlq:${queue.exportName}`,
+          detail: `Queue "${queue.exportName}" declares no \`deadLetterQueue\`, so a message that exhausts its retries (\`maxRetries\` = ${String(maxRetries)}, ~${String(maxRetries + 1)} delivery attempts) is dropped and permanently lost.`,
+          metadata: { maxRetries, mode: queue.mode, queue: queue.exportName }
+        })
+      );
+    }
+    return findings;
+  },
+  source: "static",
+  title: "Queue has no dead-letter queue"
+};
+
+export { queueWithoutDlq as default };

package/dist/packem_shared/ratelimitDefaultMemoryStore-BISChG5C.mjs

@@ -0,0 +1,26 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+
+const ratelimitDefaultMemoryStore = {
+  categories: ["SECURITY"],
+  description: "`new RateLimiter({...})` has no `store`, so it falls back to a per-instance in-memory store. On Workers each request may hit a different isolate, so the counter never sums across them — the limit silently under-counts and is effectively a no-op under load, giving false protection against brute-force and cost abuse.",
+  facing: "EXTERNAL",
+  level: "WARN",
+  name: "ratelimit_default_memory_store",
+  remediation: "Pass a shared, durable `store` to `new RateLimiter({...})` (a Durable-Object- or KV-backed store) so every Worker isolate reads and writes the same bucket. The default in-memory store is per-isolate and does not enforce a global limit.",
+  run: (context) => {
+    if (context.configCalls === void 0) {
+      return [];
+    }
+    return context.configCalls.filter((call) => call.callee === "RateLimiter" && call.analyzable && !call.presentKeys.includes("store")).map(
+      (call) => emit(ratelimitDefaultMemoryStore, {
+        cacheKey: `ratelimit_default_memory_store:${call.file}:${call.line.toString()}`,
+        detail: `\`new RateLimiter({...})\` in ${call.file}:${call.line.toString()} has no \`store\` — it uses the per-instance in-memory store, which never sums across Worker isolates, so the limit silently under-counts under load. Pass a Durable-Object- or KV-backed \`store\` so the limit is enforced globally.`,
+        metadata: { callee: call.callee, file: call.file, line: call.line }
+      })
+    );
+  },
+  source: "static",
+  title: "RateLimiter using the default in-memory store"
+};
+
+export { ratelimitDefaultMemoryStore as default };

package/dist/packem_shared/ratelimitKeySpoofableOrGlobal-DqlHYQQ3.mjs

@@ -0,0 +1,26 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+
+const ratelimitKeySpoofableOrGlobal = {
+  categories: ["SECURITY"],
+  description: "A `rateLimit`/`dbRateLimit` middleware call's `key` selector is derived from the handler's `args` with no server-side scoping, so an attacker can rotate the key on every request (e.g. by resubmitting a different email/id) and never share a bucket with themselves — the limit never actually limits them.",
+  facing: "EXTERNAL",
+  level: "WARN",
+  name: "ratelimit_key_spoofable_or_global",
+  remediation: 'Derive the rate-limit `key` from a server-trusted value — `ctx.auth.userId` for authenticated callers, `ctx.ip` for anonymous ones (e.g. `key: (ctx) => ctx.auth.userId ?? ctx.ip ?? "anon"`) — instead of an `args` field the caller controls.',
+  run: (context) => {
+    if (context.ratelimitKeySelectors === void 0) {
+      return [];
+    }
+    return context.ratelimitKeySelectors.map(
+      (selector) => emit(ratelimitKeySpoofableOrGlobal, {
+        cacheKey: `ratelimit_key_spoofable_or_global:${selector.file}:${selector.line.toString()}`,
+        detail: `\`${selector.callee}(…, "${selector.limitName}", { key })\` in \`${selector.exportName}\` (${selector.file}:${selector.line.toString()}) derives its \`key\` from \`args\` with no server-side scoping — an attacker can rotate the key per request and bypass the limit. Derive \`key\` from \`ctx.auth.userId\` / \`ctx.ip\` instead.`,
+        metadata: { callee: selector.callee, exportName: selector.exportName, file: selector.file, limitName: selector.limitName, line: selector.line }
+      })
+    );
+  },
+  source: "static",
+  title: "Rate-limit key derived from spoofable user input"
+};
+
+export { ratelimitKeySpoofableOrGlobal as default };

package/dist/packem_shared/ratelimitMiddlewareFailOpen-CJgDCaUw.mjs

@@ -0,0 +1,33 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+
+const SENSITIVE_TOKENS = ["signin", "signup", "login", "register", "reset", "password", "otp", "verify", "payment", "checkout"];
+const normalize = (value) => value.toLowerCase().replaceAll(/[^a-z0-9]+/gu, "");
+const matchesSensitiveToken = (value) => {
+  const normalized = normalize(value);
+  return SENSITIVE_TOKENS.some((token) => normalized.includes(token));
+};
+const guardsSensitiveFlow = (row) => matchesSensitiveToken(row.exportName) || matchesSensitiveToken(row.limitName);
+const ratelimitMiddlewareFailOpen = {
+  categories: ["SECURITY"],
+  description: "A rate-limit or Turnstile middleware guarding a sensitive auth/payment procedure is configured `failOpen: true`, so a limiter store outage or a failed Turnstile siteverify silently admits every request — turning a transient failure into an unthrottled brute-force / abuse window.",
+  facing: "EXTERNAL",
+  level: "WARN",
+  name: "ratelimit_middleware_fail_open",
+  remediation: "Drop `failOpen: true` (the default is fail-closed) on the rate-limit / Turnstile guard for auth and payment flows, or move the escape hatch to a non-sensitive procedure. Prefer rejecting traffic with a 503 over admitting unlimited unauthenticated attempts when the limiter or siteverify is unavailable.",
+  run: (context) => {
+    if (context.failOpenGuards === void 0) {
+      return [];
+    }
+    return context.failOpenGuards.filter((row) => row.failOpen && guardsSensitiveFlow(row)).map(
+      (row) => emit(ratelimitMiddlewareFailOpen, {
+        cacheKey: `ratelimit_middleware_fail_open:${row.file}:${row.line.toString()}`,
+        detail: `\`${row.callee}(...)\` in \`${row.exportName}\` (${row.file}:${row.line.toString()}) sets \`failOpen: true\` while guarding a sensitive flow — a limiter/siteverify outage then admits every request instead of rejecting it.`,
+        metadata: { callee: row.callee, exportName: row.exportName, file: row.file, limitName: row.limitName, line: row.line }
+      })
+    );
+  },
+  source: "static",
+  title: "Fail-open rate-limit / CAPTCHA guard on a sensitive procedure"
+};
+
+export { ratelimitMiddlewareFailOpen as default };

package/dist/packem_shared/{relationReferencesUnknownField-YznyXt_7.mjs → relationReferencesUnknownField-CjbLScJ1.mjs}

@@ -1,5 +1,5 @@
 import { e as emit } from './finding-Dm_zvzS1.mjs';
-import { t as tableColumnSet } from './helpers-DNCkMWZQ.mjs';
+import { t as tableColumnSet } from './helpers-BySnKhVB.mjs';
 
 const missingColumns = (byName, columnsOf, holder, relation) => {
   const target = byName.get(relation.table);

package/dist/packem_shared/shapeTargetsGlobalTable-DHrf4Koi.mjs

@@ -0,0 +1,34 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+
+const shapeTargetsGlobalTable = {
+  categories: ["PERFORMANCE"],
+  description: "A `defineShape` replicates from a `.global()` table. Global tables live outside the shard DO's SQLite op-log, so the shape is served through the cross-shard tier — coordinator/poll-refreshed and latency-tiered, not poke-live like a sharded shape.",
+  facing: "EXTERNAL",
+  level: "WARN",
+  name: "shape_targets_global_table",
+  remediation: "Expected if you want the cross-shard tier — just don't assume poke-live freshness; global shapes refresh on a poll. For live updates, replicate from a sharded table instead (denormalize the columns you need into the shard).",
+  run: (context) => {
+    if (context.shapes === void 0) {
+      return [];
+    }
+    const globalTables = new Set(context.schema.tables.filter((table) => table.shardKind === "global").map((table) => table.name));
+    const findings = [];
+    for (const shape of context.shapes) {
+      if (shape.table === void 0 || !globalTables.has(shape.table)) {
+        continue;
+      }
+      findings.push(
+        emit(shapeTargetsGlobalTable, {
+          cacheKey: `shape_targets_global_table:${shape.exportName}`,
+          detail: `Shape \`${shape.exportName}\` (${shape.file}) replicates from the \`.global()\` table \`${shape.table}\`. It is served through the cross-shard global tier — poll-refreshed and latency-tiered, not poke-live.`,
+          metadata: { exportName: shape.exportName, file: shape.file, table: shape.table }
+        })
+      );
+    }
+    return findings;
+  },
+  source: "static",
+  title: "Shape replicates from a global (cross-shard) table"
+};
+
+export { shapeTargetsGlobalTable as default };

package/dist/packem_shared/shapeUnknownTable-C8aDWFoe.mjs

@@ -0,0 +1,34 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+
+const shapeUnknownTable = {
+  categories: ["SCHEMA"],
+  description: "A `defineShape` is bound to a `table` name that does not exist in the schema. The shape can never resolve a rowset — its subscription seeds empty and errors at the first flush.",
+  facing: "INTERNAL",
+  level: "ERROR",
+  name: "shape_unknown_table",
+  remediation: "Fix the shape's `table` to a real table name (check for a typo or a table that was renamed/removed).",
+  run: (context) => {
+    if (context.shapes === void 0) {
+      return [];
+    }
+    const knownTables = new Set(context.schema.tables.map((table) => table.name));
+    const findings = [];
+    for (const shape of context.shapes) {
+      if (shape.table === void 0 || knownTables.has(shape.table)) {
+        continue;
+      }
+      findings.push(
+        emit(shapeUnknownTable, {
+          cacheKey: `shape_unknown_table:${shape.exportName}`,
+          detail: `Shape \`${shape.exportName}\` (${shape.file}) replicates from table \`${shape.table}\`, which is not declared in the schema. The shape can never resolve a rowset.`,
+          metadata: { exportName: shape.exportName, file: shape.file, table: shape.table }
+        })
+      );
+    }
+    return findings;
+  },
+  source: "static",
+  title: "Shape bound to an unknown table"
+};
+
+export { shapeUnknownTable as default };

package/dist/packem_shared/softDeleteIncludeDeletedFromArgs-BLqDKrkM.mjs

@@ -0,0 +1,38 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+
+const softDeleteIncludeDeletedFromArgs = {
+  categories: ["SECURITY"],
+  description: "A `.public()` read passes `includeDeleted` (hardcoded `true` or derived from `args`) on a `.softDelete()` table, resurfacing soft-deleted rows to callers that should never see them.",
+  facing: "EXTERNAL",
+  level: "INFO",
+  name: "soft_delete_include_deleted_from_args",
+  remediation: "Drop `includeDeleted` from the public read so soft-deleted rows stay hidden, or move the trash/restore view behind an internal (or RLS/role-gated) procedure. Never wire `includeDeleted` from `args` on a public read — an attacker can set it to see rows the app treats as deleted.",
+  run: (context) => {
+    if (context.softDeleteReads === void 0) {
+      return [];
+    }
+    const softDeleteTables = new Set(context.schema.tables.filter((table) => table.softDelete !== void 0).map((table) => table.name));
+    if (softDeleteTables.size === 0) {
+      return [];
+    }
+    return context.softDeleteReads.filter((row) => row.visibility === "public" && row.table !== "" && softDeleteTables.has(row.table) && (row.hardcodedTrue || row.fromArgs)).map((row) => {
+      const location = `\`${row.exportName}\` (${row.file}:${row.line.toString()})`;
+      const detail = row.fromArgs ? `The public read in ${location} wires \`includeDeleted\` from request \`args\` on soft-delete table \`${row.table}\`, letting any caller resurface soft-deleted rows the app treats as gone.` : `The public read in ${location} hardcodes \`includeDeleted: true\` on soft-delete table \`${row.table}\`, returning soft-deleted rows to every caller.`;
+      return emit(softDeleteIncludeDeletedFromArgs, {
+        cacheKey: `soft_delete_include_deleted_from_args:${row.file}:${row.line.toString()}:${row.table}`,
+        detail,
+        metadata: {
+          exportName: row.exportName,
+          file: row.file,
+          line: row.line,
+          source: row.fromArgs ? "args" : "literal",
+          table: row.table
+        }
+      });
+    });
+  },
+  source: "static",
+  title: "Soft-deleted rows resurfaced via includeDeleted on a public read"
+};
+
+export { softDeleteIncludeDeletedFromArgs as default };

package/dist/packem_shared/storageGenerateUploadUrlNoContentTypePin-Da4L9Ge8.mjs

@@ -0,0 +1,26 @@
+import { e as emit } from './finding-Dm_zvzS1.mjs';
+
+const storageGenerateUploadUrlNoContentTypePin = {
+  categories: ["SECURITY"],
+  description: "A `ctx.storage.generateUploadUrl(key, …)` call has no `contentType` pin, so the signed PUT URL it mints authorizes any content-type/size the client chooses — `upload()`'s `allowedContentTypes`/`maxSize` guards never run for a client-side PUT against this URL.",
+  facing: "EXTERNAL",
+  level: "WARN",
+  name: "storage_generate_upload_url_no_content_type_pin",
+  remediation: "Pass `contentType` to `ctx.storage.generateUploadUrl(key, { contentType })` so the signature only authorizes a PUT with that exact content-type. If the client's upload size/type also needs bounding, prefer `upload()`/`store()` (with `allowedContentTypes`/`maxSize`) over a client-side signed PUT.",
+  run: (context) => {
+    if (context.storageUploads === void 0) {
+      return [];
+    }
+    return context.storageUploads.filter((row) => row.method === "generateUploadUrl" && row.analyzable && !row.presentKeys.includes("contentType")).map(
+      (row) => emit(storageGenerateUploadUrlNoContentTypePin, {
+        cacheKey: `storage_generate_upload_url_no_content_type_pin:${row.file}:${row.line.toString()}`,
+        detail: `\`ctx.storage.generateUploadUrl\` in \`${row.exportName}\` (${row.file}:${row.line.toString()}) has no \`contentType\` pin — the signed PUT it mints accepts any type/size, minted client-side and bypassing \`upload()\`'s guards.`,
+        metadata: { exportName: row.exportName, file: row.file, line: row.line }
+      })
+    );
+  },
+  source: "static",
+  title: "generateUploadUrl signed PUT with no content-type pin"
+};
+
+export { storageGenerateUploadUrlNoContentTypePin as default };

package/dist/packem_shared/storageKeyFromUserArgs-B86elJgS.mjs

@@ -0,0 +1,19 @@
+import { m as makeArgumentDerivedSinkLint } from './argument-derived-sink-C1xTTqAt.mjs';
+
+const storageKeyFromUserArgs = makeArgumentDerivedSinkLint({
+  cacheKey: (access) => `storage_key_from_user_args:${access.file}:${access.line.toString()}`,
+  categories: ["SECURITY"],
+  description: "A `ctx.storage.*` call uses an R2 object key taken directly from the handler's `args` with no server-side scoping. The bucket methods key by the caller-supplied string, so any caller can read, overwrite, or delete another user's object — object-level IDOR.",
+  detail: (access) => `\`ctx.storage.*.${access.method}\` in \`${access.exportName}\` (${access.file}:${access.line.toString()}) uses an object key derived from \`args\` with no server-side scoping — any caller can read/overwrite/delete another user's object (IDOR). Prefix the key with a server-trusted identity (e.g. \`\${ctx.auth.userId}/…\`) or resolve the object through an owned record.`,
+  facing: "EXTERNAL",
+  getAccesses: (context) => context.storageKeyAccesses,
+  level: "ERROR",
+  metadata: (access) => {
+    return { exportName: access.exportName, file: access.file, line: access.line, method: access.method };
+  },
+  name: "storage_key_from_user_args",
+  remediation: `Prefix the object key with a server-trusted identity (e.g. \`\${ctx.auth.userId}/…\`) or resolve the object through a record the caller is known to own. Never pass request input straight through as an R2 object key.`,
+  title: "R2 object key taken directly from user args (IDOR)"
+});
+
+export { storageKeyFromUserArgs as default };