@lumx/react 4.17.1-alpha.1 → 4.17.1-alpha.2

package/index.d.ts

@@ -1862,14 +1862,10 @@ interface ComboboxEventMap {
 }
 /** Callbacks provided by the consumer (React/Vue) to react to combobox state changes. */
 interface ComboboxCallbacks {
-    /**
-     * Called when an option is selected (click or keyboard).
-     * Return `false` to skip the default behaviour of updating the input value via `onChange`.
-     * The combobox will still close normally.
-     */
+    /** Called when an option is selected (click or keyboard). */
     onSelect?(option: {
         value: string;
-    }): boolean | void;
+    }): void;
 }
 /**
  * Behavioral options for input-mode combobox (autocomplete/filter pattern).
@@ -1894,6 +1890,19 @@ interface ComboboxInputOptions {
      * @default false (true when filter is 'off')
      */
     openOnFocus?: boolean;
+    /**
+     * Controls what happens to the input value when an option is selected.
+     *
+     * - `'fill'` (default) — The input is updated with the selected option value via `onChange`.
+     * - `'keep'` — The input value is left unchanged; `onChange` is not called.
+     *   Useful when the component manages the displayed value independently (e.g. showing
+     *   an option display name rather than the raw option ID). The filter still resets.
+     * - `'clear'` — The input is cleared (empty string) via `onChange` after selection.
+     *   Useful for multi-select patterns where typing starts fresh after each pick.
+     *
+     * @default 'fill'
+     */
+    selectionMode?: 'fill' | 'keep' | 'clear';
 }
 
 /**

package/index.js

@@ -7404,17 +7404,14 @@ function setupComboboxInput(input, options) {
   let userHasTyped = false;
 
   /**
-   * Wraps the consumer's onSelect to perform input-mode side effects after selection:
-   * resets the filter and typing state.
-   * Forwards the return value of the consumer callback.
+   * Wraps the consumer's onSelect to perform input-mode side effects after selection.
+   * Filter and typing state are always reset on selection — selectionMode only controls
+   * whether onChange is called by the framework wrapper, not the internal filter.
    */
   const onSelect = option => {
-    const result = optionOnSelect?.(option);
+    optionOnSelect?.(option);
     userHasTyped = false;
-    if (autoFilter) {
-      handle.setFilter('');
-    }
-    return result;
+    if (autoFilter) handle.setFilter('');
   };
   handle = setupCombobox({
     onSelect
@@ -8161,6 +8158,7 @@ const ComboboxInput = forwardRef((props, ref) => {
     onSelect,
     filter,
     openOnFocus,
+    selectionMode,
     ...otherProps
   } = props;
   const internalInputRef = useRef(null);
@@ -8178,11 +8176,12 @@ const ComboboxInput = forwardRef((props, ref) => {
     if (!input) return undefined;
     const handle = setupComboboxInput(input, {
       onSelect(option) {
-        // Fire consumer callback first so it can return false before onChange.
-        const prevented = onSelectRef.current?.(option) === false;
-        // Update controlled value through React's normal onChange flow,
-        // unless the consumer returned false.
-        if (!prevented) {
+        onSelectRef.current?.(option);
+        // Drive onChange according to selectionMode.
+        if (selectionMode === 'keep') ; else if (selectionMode === 'clear') {
+          onChangeRef.current?.('');
+        } else {
+          // 'fill' (default): echo the selected value.
           onChangeRef.current?.(option.value);
         }
       },
@@ -8198,7 +8197,7 @@ const ComboboxInput = forwardRef((props, ref) => {
       handle.destroy();
       setHandle(null);
     };
-  }, [filter, openOnFocus, setHandle]);
+  }, [filter, openOnFocus, selectionMode, setHandle]);
   const handleToggle = useCallback(() => {
     setIsOpen(!isOpen);
     internalInputRef.current?.focus();
@@ -18264,6 +18263,7 @@ const SelectTextField$2 = (props, {
     children: [/*#__PURE__*/jsx(Combobox.Input, {
       label: label,
       ...inputProps,
+      selectionMode: "keep",
       chips: chips
     }), /*#__PURE__*/jsxs(Combobox.Popover, {
       fitToAnchorWidth: "minWidth",