@lumx/react 3.7.1 → 3.7.2-alpha.0

package/package.json

@@ -7,8 +7,8 @@
     },
     "dependencies": {
         "@juggle/resize-observer": "^3.2.0",
-        "@lumx/core": "^3.7.1",
-        "@lumx/icons": "^3.7.1",
+        "@lumx/core": "^3.7.2-alpha.0",
+        "@lumx/icons": "^3.7.2-alpha.0",
         "@popperjs/core": "^2.5.4",
         "body-scroll-lock": "^3.1.5",
         "classnames": "^2.3.2",
@@ -112,5 +112,5 @@
         "build:storybook": "storybook build"
     },
     "sideEffects": false,
-    "version": "3.7.1"
+    "version": "3.7.2-alpha.0"
 }

package/src/components/tooltip/Tooltip.test.tsx

@@ -24,10 +24,10 @@ jest.mock('@lumx/react/constants', () => ({
  */
 const setup = async (propsOverride: Partial<TooltipProps> = {}) => {
     const props: any = { forceOpen: true, label: 'Tooltip label', children: 'Anchor', ...propsOverride };
-    render(<Tooltip {...props} />);
+    const result = render(<Tooltip {...props} />);
     const tooltip = screen.queryByRole('tooltip', { name: props.label });
     const anchorWrapper = queryByClassName(document.body, 'lumx-tooltip-anchor-wrapper');
-    return { props, tooltip, anchorWrapper };
+    return { props, tooltip, anchorWrapper, result };
 };
 
 describe(`<${Tooltip.displayName}>`, () => {
@@ -136,6 +136,28 @@ describe(`<${Tooltip.displayName}>`, () => {
             expect(lines[0]).toHaveTextContent('First line');
             expect(lines[1]).toHaveTextContent('Second line');
         });
+
+        it('should have a stable ref', async () => {
+            const ref = React.createRef() as any;
+
+            // Render without a label
+            const result = render(
+                <Tooltip label="">
+                    <span ref={ref}>some text</span>
+                </Tooltip>,
+            );
+            const element = ref.current;
+            expect(element).not.toBeFalsy();
+
+            // Re-render with a label
+            result.rerender(
+                <Tooltip label="Some tooltip">
+                    <span ref={ref}>some updated text</span>
+                </Tooltip>,
+            );
+            // Children ref is stable
+            expect(ref.current === element).toBe(true);
+        });
     });
 
     describe('activation', () => {

package/src/components/tooltip/Tooltip.tsx

@@ -68,7 +68,7 @@ export const Tooltip: Comp<TooltipProps, HTMLDivElement> = forwardRef((props, re
     const { label, children, className, delay, placement, forceOpen, ...forwardedProps } = props;
     // Disable in SSR or without a label.
     if (!DOCUMENT || !label) {
-        return <>{children}</>;
+        return <TooltipContextProvider>{children}</TooltipContextProvider>;
     }
 
     const id = useMemo(() => `tooltip-${uid()}`, []);