@lumenflow/cli 2.18.3 → 2.20.0

package/dist/wu-create-validation.js

@@ -0,0 +1,124 @@
+/**
+ * @file wu-create-validation.ts
+ * @description Validation logic for wu:create command (WU-1651)
+ *
+ * Extracted from wu-create.ts to isolate spec validation, strict mode checks,
+ * and field-level error aggregation into a focused module.
+ */
+import { todayISO } from '@lumenflow/core/date-utils';
+import { hasSpecRefs } from '@lumenflow/core/wu-create-validators';
+import { WU_TYPES } from '@lumenflow/core/wu-constants';
+import { validateWU } from '@lumenflow/core/wu-schema';
+import { validateSpecCompleteness } from '@lumenflow/core/wu-done-validators';
+import { validateWURulesSync } from '@lumenflow/core/wu-rules-engine';
+import { validateNoPlaceholders, buildPlaceholderErrorMessage } from '@lumenflow/core/wu-validator';
+import { isCodeFile } from '@lumenflow/core/manual-test-validator';
+import { isDocsOrProcessType } from '@lumenflow/core/wu-type-helpers';
+import { buildWUContent } from './wu-create-content.js';
+/** Log prefix for console output */
+const LOG_PREFIX = '[wu:create]';
+/** Default WU type */
+const DEFAULT_TYPE = WU_TYPES.FEATURE;
+export function containsCodeFiles(codePaths) {
+    if (!codePaths || codePaths.length === 0)
+        return false;
+    return codePaths.some((filePath) => isCodeFile(filePath));
+}
+export function hasAnyItems(value) {
+    return Array.isArray(value) && value.length > 0;
+}
+/**
+ * Validate WU spec for creation
+ *
+ * WU-1329: Strict mode (default) validates that code_paths and test_paths exist on disk.
+ * Use opts.strict = false to bypass path existence checks.
+ *
+ * @param params - Validation parameters
+ * @returns {{ valid: boolean, errors: string[] }}
+ */
+export function validateCreateSpec({ id, lane, title, priority, type, opts, }) {
+    const errors = [];
+    const effectiveType = type || DEFAULT_TYPE;
+    // WU-1329: Strict mode flag retained for backwards compatibility in CLI UX.
+    // Reality checks now run in wu:prep/wu:done; create/edit enforce intent only.
+    const strict = opts.strict !== false;
+    // Keep advisory log for callers that explicitly opt out.
+    if (!strict) {
+        console.warn(`${LOG_PREFIX} WARNING: strict validation bypassed (--no-strict). ` +
+            `Reality-phase checks run at wu:prep/wu:done.`);
+    }
+    if (!opts.description) {
+        errors.push('--description is required');
+    }
+    if (!opts.acceptance || opts.acceptance.length === 0) {
+        errors.push('--acceptance is required (repeatable)');
+    }
+    if (!opts.exposure) {
+        errors.push('--exposure is required');
+    }
+    if (!isDocsOrProcessType(effectiveType)) {
+        const codePaths = opts.codePaths ?? [];
+        if (codePaths.length === 0) {
+            errors.push('--code-paths is required for non-documentation WUs');
+        }
+    }
+    if (effectiveType === WU_TYPES.FEATURE && !hasSpecRefs(opts.specRefs)) {
+        errors.push('--spec-refs is required for type: feature WUs\n' +
+            '    Tip: Create a plan first with: pnpm plan:create --id <WU-ID> --title "..."\n' +
+            '    Then use --plan flag or --spec-refs lumenflow://plans/<WU-ID>-plan.md');
+    }
+    // WU-1530: Single-pass validation -- collect all errors before returning.
+    // Always build WU content and run all validation stages, even when early fields are missing.
+    // buildWUContent handles undefined gracefully; Zod catches missing required fields.
+    // Stage 2b: Placeholder check (only meaningful if fields exist)
+    if (opts.description && opts.acceptance && opts.acceptance.length > 0) {
+        const placeholderResult = validateNoPlaceholders({
+            description: opts.description,
+            acceptance: opts.acceptance,
+        });
+        if (!placeholderResult.valid) {
+            errors.push(buildPlaceholderErrorMessage('wu:create', placeholderResult));
+        }
+    }
+    // Stage 2c-2d: Schema + completeness -- always run to catch enum/format errors
+    // even when required fields are missing (Zod reports both)
+    const today = todayISO();
+    const wuContent = buildWUContent({
+        id,
+        lane,
+        title,
+        priority,
+        type: effectiveType,
+        created: today,
+        opts,
+    });
+    const schemaResult = validateWU(wuContent);
+    if (!schemaResult.success) {
+        // Deduplicate: skip schema errors already covered by field-level checks above
+        const fieldErrorFields = new Set(['description', 'acceptance', 'code_paths', 'tests']);
+        const schemaErrors = schemaResult.error.issues
+            .filter((issue) => !fieldErrorFields.has(issue.path[0]) || errors.length === 0)
+            .map((issue) => `${issue.path.join('.')}: ${issue.message}`);
+        errors.push(...schemaErrors);
+    }
+    // Only run completeness if schema passed (it depends on well-formed data)
+    if (schemaResult.success) {
+        const intentRules = validateWURulesSync({
+            id,
+            type: effectiveType,
+            status: 'ready',
+            code_paths: wuContent.code_paths,
+            tests: wuContent.tests,
+        }, { phase: 'intent' });
+        errors.push(...intentRules.errors.map((issue) => issue.message));
+        const completeness = validateSpecCompleteness(wuContent, id);
+        if (!completeness.valid) {
+            errors.push(...completeness.errors);
+        }
+    }
+    if (errors.length > 0) {
+        return { valid: false, errors };
+    }
+    return { valid: true, errors: [] };
+}
+//# sourceMappingURL=wu-create-validation.js.map

package/dist/wu-create-validation.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"wu-create-validation.js","sourceRoot":"","sources":["../src/wu-create-validation.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAEH,OAAO,EAAE,QAAQ,EAAE,MAAM,4BAA4B,CAAC;AACtD,OAAO,EAAE,WAAW,EAAE,MAAM,sCAAsC,CAAC;AACnE,OAAO,EAAE,QAAQ,EAAE,MAAM,8BAA8B,CAAC;AACxD,OAAO,EAAE,UAAU,EAAE,MAAM,2BAA2B,CAAC;AACvD,OAAO,EAAE,wBAAwB,EAAE,MAAM,oCAAoC,CAAC;AAC9E,OAAO,EAAE,mBAAmB,EAAE,MAAM,iCAAiC,CAAC;AACtE,OAAO,EAAE,sBAAsB,EAAE,4BAA4B,EAAE,MAAM,8BAA8B,CAAC;AACpG,OAAO,EAAE,UAAU,EAAE,MAAM,uCAAuC,CAAC;AACnE,OAAO,EAAE,mBAAmB,EAAE,MAAM,iCAAiC,CAAC;AACtE,OAAO,EAAE,cAAc,EAAE,MAAM,wBAAwB,CAAC;AAExD,oCAAoC;AACpC,MAAM,UAAU,GAAG,aAAa,CAAC;AAEjC,sBAAsB;AACtB,MAAM,YAAY,GAAG,QAAQ,CAAC,OAAO,CAAC;AA2BtC,MAAM,UAAU,iBAAiB,CAAC,SAA+B;IAC/D,IAAI,CAAC,SAAS,IAAI,SAAS,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,KAAK,CAAC;IACvD,OAAO,SAAS,CAAC,IAAI,CAAC,CAAC,QAAQ,EAAE,EAAE,CAAC,UAAU,CAAC,QAAQ,CAAC,CAAC,CAAC;AAC5D,CAAC;AAED,MAAM,UAAU,WAAW,CAAC,KAAc;IACxC,OAAO,KAAK,CAAC,OAAO,CAAC,KAAK,CAAC,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC,CAAC;AAClD,CAAC;AAED;;;;;;;;GAQG;AACH,MAAM,UAAU,kBAAkB,CAAC,EACjC,EAAE,EACF,IAAI,EACJ,KAAK,EACL,QAAQ,EACR,IAAI,EACJ,IAAI,GAQL;IACC,MAAM,MAAM,GAAG,EAAE,CAAC;IAClB,MAAM,aAAa,GAAG,IAAI,IAAI,YAAY,CAAC;IAC3C,4EAA4E;IAC5E,8EAA8E;IAC9E,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,KAAK,KAAK,CAAC;IAErC,yDAAyD;IACzD,IAAI,CAAC,MAAM,EAAE,CAAC;QACZ,OAAO,CAAC,IAAI,CACV,GAAG,UAAU,sDAAsD;YACjE,8CAA8C,CACjD,CAAC;IACJ,CAAC;IAED,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC;QACtB,MAAM,CAAC,IAAI,CAAC,2BAA2B,CAAC,CAAC;IAC3C,CAAC;IAED,IAAI,CAAC,IAAI,CAAC,UAAU,IAAI,IAAI,CAAC,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACrD,MAAM,CAAC,IAAI,CAAC,uCAAuC,CAAC,CAAC;IACvD,CAAC;IAED,IAAI,CAAC,IAAI,CAAC,QAAQ,EAAE,CAAC;QACnB,MAAM,CAAC,IAAI,CAAC,wBAAwB,CAAC,CAAC;IACxC,CAAC;IAED,IAAI,CAAC,mBAAmB,CAAC,aAAa,CAAC,EAAE,CAAC;QACxC,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,IAAI,EAAE,CAAC;QACvC,IAAI,SAAS,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YAC3B,MAAM,CAAC,IAAI,CAAC,oDAAoD,CAAC,CAAC;QACpE,CAAC;IACH,CAAC;IAED,IAAI,aAAa,KAAK,QAAQ,CAAC,OAAO,IAAI,CAAC,WAAW,CAAC,IAAI,CAAC,QAAQ,CAAC,EAAE,CAAC;QACtE,MAAM,CAAC,IAAI,CACT,iDAAiD;YAC/C,kFAAkF;YAClF,2EAA2E,CAC9E,CAAC;IACJ,CAAC;IAED,0EAA0E;IAC1E,6FAA6F;IAC7F,oFAAoF;IAEpF,gEAAgE;IAChE,IAAI,IAAI,CAAC,WAAW,IAAI,IAAI,CAAC,UAAU,IAAI,IAAI,CAAC,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACtE,MAAM,iBAAiB,GAAG,sBAAsB,CAAC;YAC/C,WAAW,EAAE,IAAI,CAAC,WAAW;YAC7B,UAAU,EAAE,IAAI,CAAC,UAAU;SAC5B,CAAC,CAAC;QAEH,IAAI,CAAC,iBAAiB,CAAC,KAAK,EAAE,CAAC;YAC7B,MAAM,CAAC,IAAI,CAAC,4BAA4B,CAAC,WAAW,EAAE,iBAAiB,CAAC,CAAC,CAAC;QAC5E,CAAC;IACH,CAAC;IAED,+EAA+E;IAC/E,2DAA2D;IAC3D,MAAM,KAAK,GAAG,QAAQ,EAAE,CAAC;IACzB,MAAM,SAAS,GAAG,cAAc,CAAC;QAC/B,EAAE;QACF,IAAI;QACJ,KAAK;QACL,QAAQ;QACR,IAAI,EAAE,aAAa;QACnB,OAAO,EAAE,KAAK;QACd,IAAI;KACL,CAAC,CAAC;IAEH,MAAM,YAAY,GAAG,UAAU,CAAC,SAAS,CAAC,CAAC;IAC3C,IAAI,CAAC,YAAY,CAAC,OAAO,EAAE,CAAC;QAC1B,8EAA8E;QAC9E,MAAM,gBAAgB,GAAG,IAAI,GAAG,CAAC,CAAC,aAAa,EAAE,YAAY,EAAE,YAAY,EAAE,OAAO,CAAC,CAAC,CAAC;QACvF,MAAM,YAAY,GAAG,YAAY,CAAC,KAAK,CAAC,MAAM;aAC3C,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC,gBAAgB,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAW,CAAC,IAAI,MAAM,CAAC,MAAM,KAAK,CAAC,CAAC;aACxF,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,GAAG,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG,CAAC,KAAK,KAAK,CAAC,OAAO,EAAE,CAAC,CAAC;QAC/D,MAAM,CAAC,IAAI,CAAC,GAAG,YAAY,CAAC,CAAC;IAC/B,CAAC;IAED,0EAA0E;IAC1E,IAAI,YAAY,CAAC,OAAO,EAAE,CAAC;QACzB,MAAM,WAAW,GAAG,mBAAmB,CACrC;YACE,EAAE;YACF,IAAI,EAAE,aAAa;YACnB,MAAM,EAAE,OAAO;YACf,UAAU,EAAE,SAAS,CAAC,UAAU;YAChC,KAAK,EAAE,SAAS,CAAC,KAAK;SACvB,EACD,EAAE,KAAK,EAAE,QAAQ,EAAE,CACpB,CAAC;QACF,MAAM,CAAC,IAAI,CAAC,GAAG,WAAW,CAAC,MAAM,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC;QAEjE,MAAM,YAAY,GAAG,wBAAwB,CAAC,SAAS,EAAE,EAAE,CAAC,CAAC;QAC7D,IAAI,CAAC,YAAY,CAAC,KAAK,EAAE,CAAC;YACxB,MAAM,CAAC,IAAI,CAAC,GAAG,YAAY,CAAC,MAAM,CAAC,CAAC;QACtC,CAAC;IACH,CAAC;IAED,IAAI,MAAM,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACtB,OAAO,EAAE,KAAK,EAAE,KAAK,EAAE,MAAM,EAAE,CAAC;IAClC,CAAC;IAED,OAAO,EAAE,KAAK,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,CAAC;AACrC,CAAC"}