@luma.gl/webgpu 9.3.0-alpha.9 → 9.3.0

package/dist/index.cjs

@@ -1091,6 +1091,7 @@ var init_webgpu_render_pipeline = __esm({
           this.device.pushErrorScope("validation");
           this.handle = this.device.handle.createRenderPipeline(descriptor);
           this.device.popErrorScope((error) => {
+            this.linkStatus = "error";
             this.device.reportError(new Error(`${this} creation failed:
 "${error.message}"`), this)();
             this.device.debug();
@@ -1098,6 +1099,7 @@ var init_webgpu_render_pipeline = __esm({
         }
         this.descriptor = descriptor;
         this.handle.label = this.props.id;
+        this.linkStatus = "success";
         this.vs = props.vs;
         this.fs = props.fs;
         this._bindingsByGroup = props.bindGroups || (0, import_core9.normalizeBindingsByGroup)(this.shaderLayout, props.bindings);
@@ -1128,6 +1130,10 @@ var init_webgpu_render_pipeline = __esm({
       }
       /** @todo - should this be moved to renderpass? */
       draw(options) {
+        if (this.isErrored) {
+          import_core9.log.info(2, `RenderPipeline:${this.id}.draw() aborted - pipeline initialization failed`)();
+          return false;
+        }
         const webgpuRenderPass = options.renderPass;
         const instanceCount = options.instanceCount && options.instanceCount > 0 ? options.instanceCount : 1;
         this.device.pushErrorScope("validation");
@@ -3022,28 +3028,52 @@ var init_generate_mipmaps_webgpu = __esm({
 });
 
 // dist/adapter/helpers/get-bind-group.js
-function getBindGroup(device, bindGroupLayout, shaderLayout, bindings, group) {
+function getBindGroup(device, bindGroupLayout, shaderLayout, bindings, group, label) {
   const entries = getBindGroupEntries(bindings, shaderLayout, group);
   if (entries.length === 0) {
     return null;
   }
   device.pushErrorScope("validation");
   const bindGroup = device.handle.createBindGroup({
+    label,
     layout: bindGroupLayout,
     entries
   });
   device.popErrorScope((error) => {
-    import_core24.log.error(`bindGroup creation: ${error.message}`, bindGroup)();
+    const summary = formatBindGroupCreationErrorSummary(shaderLayout, bindings, entries, group);
+    import_core24.log.error(`bindGroup creation: ${summary}
+Raw WebGPU error: ${error.message}`, bindGroup)();
   });
   return bindGroup;
 }
+function formatBindGroupCreationErrorSummary(shaderLayout, bindings, entries, group) {
+  const expectedBindings = getExpectedBindingsForGroup(shaderLayout, group);
+  const expectedByLocation = new Map(expectedBindings.map((bindingSummary) => [bindingSummary.location, bindingSummary]));
+  const providedBindings = entries.map((entry) => expectedByLocation.get(entry.binding) || getUnexpectedEntrySummary(entry)).sort(compareBindingSummaries);
+  const missingBindings = expectedBindings.filter((bindingSummary) => !providedBindings.some((provided) => provided.location === bindingSummary.location));
+  const unexpectedBindings = providedBindings.filter((bindingSummary) => !expectedByLocation.has(bindingSummary.location));
+  const unmatchedLogicalBindings = Object.keys(bindings).filter((bindingName) => !resolveGroupBinding(bindingName, bindings, shaderLayout, group)).sort();
+  const lines = [
+    `bindGroup creation failed for group ${group}: expected ${expectedBindings.length}, provided ${providedBindings.length}`,
+    `expected: ${formatBindingSummaryList(expectedBindings)}`,
+    `provided: ${formatBindingSummaryList(providedBindings)}`
+  ];
+  if (missingBindings.length > 0) {
+    lines.push(`missing: ${formatBindingSummaryList(missingBindings)}`);
+  }
+  if (unexpectedBindings.length > 0) {
+    lines.push(`unexpected entries: ${formatBindingSummaryList(unexpectedBindings)}`);
+  }
+  if (unmatchedLogicalBindings.length > 0) {
+    lines.push(`unmatched logical bindings: ${unmatchedLogicalBindings.join(", ")}`);
+  }
+  return lines.join("\n");
+}
 function getBindGroupEntries(bindings, shaderLayout, group) {
   const entries = [];
   for (const [bindingName, value] of Object.entries(bindings)) {
-    const exactBindingLayout = shaderLayout.bindings.find((binding) => binding.name === bindingName);
-    const bindingLayout = exactBindingLayout || (0, import_core24.getShaderLayoutBinding)(shaderLayout, bindingName);
-    const isShadowedAlias = !exactBindingLayout && bindingLayout ? bindingLayout.name in bindings : false;
-    if (!isShadowedAlias && (bindingLayout == null ? void 0 : bindingLayout.group) === group) {
+    const { bindingLayout, isShadowedAlias } = resolveGroupBinding(bindingName, bindings, shaderLayout, group) || { bindingLayout: null, isShadowedAlias: false };
+    if (!isShadowedAlias && bindingLayout) {
       const entry = bindingLayout ? getBindGroupEntry(value, bindingLayout.location, void 0, bindingName) : null;
       if (entry) {
         entries.push(entry);
@@ -3097,6 +3127,44 @@ function getBindGroupEntry(binding, index, options, bindingName = "unknown") {
   import_core24.log.warn(`invalid binding ${bindingName}`, binding);
   return null;
 }
+function getExpectedBindingsForGroup(shaderLayout, group) {
+  return shaderLayout.bindings.filter((bindingLayout) => bindingLayout.group === group).map((bindingLayout) => toBindingSummary(bindingLayout)).sort(compareBindingSummaries);
+}
+function resolveGroupBinding(bindingName, bindings, shaderLayout, group) {
+  const exactBindingLayout = shaderLayout.bindings.find((binding) => binding.name === bindingName);
+  const bindingLayout = exactBindingLayout || (0, import_core24.getShaderLayoutBinding)(shaderLayout, bindingName, { ignoreWarnings: true });
+  const isShadowedAlias = !exactBindingLayout && bindingLayout ? bindingLayout.name in bindings : false;
+  if (isShadowedAlias || !bindingLayout || bindingLayout.group !== group) {
+    return null;
+  }
+  return { bindingLayout, isShadowedAlias };
+}
+function toBindingSummary(bindingLayout) {
+  return {
+    name: bindingLayout.name,
+    location: bindingLayout.location,
+    type: bindingLayout.type
+  };
+}
+function getUnexpectedEntrySummary(entry) {
+  return {
+    name: "?",
+    location: entry.binding,
+    type: "unknown"
+  };
+}
+function compareBindingSummaries(left, right) {
+  if (left.location !== right.location) {
+    return left.location - right.location;
+  }
+  return left.name.localeCompare(right.name);
+}
+function formatBindingSummaryList(bindings) {
+  if (bindings.length === 0) {
+    return "none";
+  }
+  return bindings.map((binding) => `${binding.name}@${binding.location}`).join(", ");
+}
 var import_core24;
 var init_get_bind_group = __esm({
   "dist/adapter/helpers/get-bind-group.js"() {
@@ -3181,10 +3249,9 @@ var init_webgpu_device = __esm({
           this.reportError(new Error(errorMessage), this)();
           this.debug();
         });
-        this.lost = new Promise(async (resolve) => {
-          const lostInfo = await this.handle.lost;
+        this.lost = this.handle.lost.then((lostInfo) => {
           this._isLost = true;
-          resolve({ reason: "destroyed", message: lostInfo.message });
+          return { reason: "destroyed", message: lostInfo.message };
         });
         const canvasContextProps = import_core25.Device._getCanvasContextProps(props);
         if (canvasContextProps) {
@@ -3275,14 +3342,15 @@ var init_webgpu_device = __esm({
       _createBindGroupLayoutWebGPU(pipeline, group) {
         return pipeline.handle.getBindGroupLayout(group);
       }
-      _createBindGroupWebGPU(bindGroupLayout, shaderLayout, bindings, group) {
+      _createBindGroupWebGPU(bindGroupLayout, shaderLayout, bindings, group, label) {
         if (Object.keys(bindings).length === 0) {
           return this.handle.createBindGroup({
+            label,
             layout: bindGroupLayout,
             entries: []
           });
         }
-        return getBindGroup(this, bindGroupLayout, shaderLayout, bindings, group);
+        return getBindGroup(this, bindGroupLayout, shaderLayout, bindings, group, label);
       }
       submit(commandBuffer) {
         let submittedCommandEncoder = null;