@luma.gl/webgl 9.3.2 → 9.3.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@luma.gl/webgl",
-  "version": "9.3.2",
+  "version": "9.3.4",
   "description": "WebGL2 adapter for the luma.gl core API",
   "type": "module",
   "license": "MIT",
@@ -61,5 +61,5 @@
     "@math.gl/types": "^4.1.0",
     "@probe.gl/env": "^4.1.1"
   },
-  "gitHead": "8f60fca63dc43702af5b16d0381fd97d7ace7dc9"
+  "gitHead": "f430daba8be25561034dca6bb0af3ea487c9d1c8"
 }

package/src/adapter/resources/webgl-framebuffer.ts

@@ -36,19 +36,20 @@ export class WEBGLFramebuffer extends Framebuffer {
       // default framebuffer handle is null, so we can't set debug metadata...
       device._setWebGLDebugMetadata(this.handle, this, {spector: this.props});
 
-      // Auto create textures for attachments if needed
-      this.autoCreateAttachmentTextures();
+      if (!props.handle) {
+        // Auto create textures for attachments if needed
+        this.autoCreateAttachmentTextures();
 
-      this.updateAttachments();
+        this.updateAttachments();
+      }
     }
   }
 
   /** destroys any auto created resources etc. */
   override destroy(): void {
     super.destroy(); // destroys owned resources etc.
-    if (!this.destroyed && this.handle !== null) {
+    if (!this.destroyed && this.handle !== null && !this.props.handle) {
       this.gl.deleteFramebuffer(this.handle);
-      // this.handle = null;
     }
   }
 

package/src/adapter/resources/webgl-render-pass.ts

@@ -35,7 +35,7 @@ export class WEBGLRenderPass extends RenderPass {
     // If no viewport is provided, apply reasonably defaults
     let viewport: NumberArray4 | undefined;
     if (!props?.parameters?.viewport) {
-      if (!isDefaultFramebuffer) {
+      if (!isDefaultFramebuffer && webglFramebuffer) {
         // Set the viewport to the size of the framebuffer
         const {width, height} = webglFramebuffer;
         viewport = [0, 0, width, height];
@@ -51,13 +51,11 @@ export class WEBGLRenderPass extends RenderPass {
     this.setParameters({viewport, ...this.props.parameters});
 
     // Specify mapping of draw buffer locations to color attachments
-    // Default framebuffers can only be set to GL.BACK or GL.NONE
-    if (!isDefaultFramebuffer) {
+    if (!isDefaultFramebuffer && webglFramebuffer?.colorAttachments.length) {
       const drawBuffers = webglFramebuffer.colorAttachments.map((_, i) => GL.COLOR_ATTACHMENT0 + i);
       this.device.gl.drawBuffers(drawBuffers);
-    } else {
-      // Default framebuffer only supports GL.BACK/GL.NONE draw buffers, even when
-      // passed through an explicit framebuffer wrapper.
+    } else if (isDefaultFramebuffer) {
+      // Default framebuffer only supports GL.BACK/GL.NONE draw buffers
       this.device.gl.drawBuffers([GL.BACK]);
     }