@luma.gl/webgl 9.3.0-alpha.8 → 9.3.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@luma.gl/webgl",
-  "version": "9.3.0-alpha.8",
+  "version": "9.3.0",
   "description": "WebGL2 adapter for the luma.gl core API",
   "type": "module",
   "license": "MIT",
@@ -61,5 +61,5 @@
     "@math.gl/types": "^4.1.0",
     "@probe.gl/env": "^4.1.1"
   },
-  "gitHead": "371f0979c1cd01563badc36118f314365a66e1a1"
+  "gitHead": "c5e44faacd07b315a8622b5927e724f15a3d40ae"
 }

package/src/adapter/converters/webgl-shadertypes.ts

@@ -38,7 +38,7 @@ export function getTextureBindingFromGLSamplerType(
 /** Get vertex format from GL constants */
 export function getVertexFormatFromGL(type: GLDataType, components: 1 | 2 | 3 | 4): VertexFormat {
   const base = getVertexTypeFromGL(type);
-  // prettier-ignore
+  // biome-ignore format: preserve layout
   switch (components) {
     case 1: return base;
     case 2: return `${base}x2`;

package/src/adapter/converters/webgl-texture-table.ts

@@ -44,7 +44,7 @@ type TextureFeatureDefinition = {
   features?: DeviceFeature[];
 };
 
-// prettier-ignore
+// biome-ignore format: preserve layout
 export const TEXTURE_FEATURES: Partial<Record<DeviceFeature, TextureFeatureDefinition>> = {
   'float32-renderable-webgl': {extensions: [EXT_color_buffer_float]},
   'float16-renderable-webgl': {extensions: ['EXT_color_buffer_half_float']},
@@ -137,7 +137,7 @@ type WebGLFormatInfo = {
  * Texture format data -
  * Exported but can change without notice
  */
-// prettier-ignore
+// biome-ignore format: preserve layout
 export const WEBGL_TEXTURE_FORMATS: Record<TextureFormat, WebGLFormatInfo> = {
   // 8-bit formats
   'r8unorm': {gl: GL.R8, rb: true},
@@ -478,7 +478,7 @@ export function getWebGLPixelDataFormat(
   if (format === GL.RGBA || format === GL.RGB) {
     return format;
   }
-  // prettier-ignore
+  // biome-ignore format: preserve layout
   switch (channels) {
     case 'r': return integer && !normalized ? GL.RED_INTEGER : GL.RED;
     case 'rg': return integer && !normalized ? GL.RG_INTEGER : GL.RG;

package/src/adapter/converters/webgl-vertex-formats.ts

@@ -18,7 +18,7 @@ type GLDataType =
 /** Get vertex format from GL constants */
 export function getVertexFormatFromGL(type: GLDataType, components: 1 | 2 | 3 | 4): VertexFormat {
   const base = getVertexTypeFromGL(type);
-  // prettier-ignore
+  // biome-ignore format: preserve layout
   switch (components) {
     case 1: return base;
     case 2: return `${base}x2`;
@@ -32,7 +32,7 @@ export function getVertexFormatFromGL(type: GLDataType, components: 1 | 2 | 3 |
 
 /** Get data type from GL constants */
 export function getVertexTypeFromGL(type: GLDataType, normalized = false): NormalizedDataType {
-  // prettier-ignore
+  // biome-ignore format: preserve layout
   switch (type) {
     // WebGPU does not support normalized 32 bit integer attributes
     case GL.INT: return normalized ? 'sint32' : 'sint32';
@@ -59,7 +59,7 @@ export function getGLFromVertexType(
   | GL.INT
   | GL.HALF_FLOAT
   | GL.FLOAT {
-  // prettier-ignore
+  // biome-ignore format: preserve layout
   switch (dataType) {
     case 'uint8': return GL.UNSIGNED_BYTE;
     case 'sint8': return GL.BYTE;

package/src/adapter/device-helpers/webgl-device-limits.ts

@@ -5,7 +5,7 @@
 import {DeviceLimits} from '@luma.gl/core';
 import {GL} from '@luma.gl/webgl/constants';
 
-// prettier-ignore
+// biome-ignore format: preserve layout
 export class WebGLDeviceLimits extends DeviceLimits {
   get maxTextureDimension1D() { return 0; } // WebGL does not support 1D textures
   get maxTextureDimension2D() { return this.getParameter(GL.MAX_TEXTURE_SIZE); }

package/src/adapter/helpers/parse-shader-compiler-log.ts

@@ -59,12 +59,12 @@ export function parseShaderCompilerLog(errLog: string): readonly CompilerMessage
     }
 
     let lineNum = parseInt(lineNumber, 10);
-    if (isNaN(lineNum)) {
+    if (Number.isNaN(lineNum)) {
       lineNum = 0;
     }
 
     let linePos = parseInt(linePosition, 10);
-    if (isNaN(linePos)) {
+    if (Number.isNaN(linePos)) {
       linePos = 0;
     }
 

package/src/adapter/helpers/set-uniform.ts

@@ -28,7 +28,7 @@ export function setUniform(
   }
   const arrayValue = typeof uniformValue === 'number' ? [uniformValue] : uniformValue;
 
-  // prettier-ignore
+  // biome-ignore format: preserve layout
   switch (type) {
     case GL.SAMPLER_2D:
     case GL.SAMPLER_CUBE:

package/src/adapter/helpers/webgl-texture-utils.ts

@@ -102,10 +102,10 @@ export function copyGPUBufferToMipLevel(
       // 3 dimensional textures requires 3D texture functions
       if (compressed) {
         // TODO enable extension?
-        // prettier-ignore
+        // biome-ignore format: preserve layout
         gl.compressedTexSubImage3D(glTarget, mipLevel, x, y, z, width, height, depth, glFormat, byteLength, byteOffset);
       } else {
-        // prettier-ignore
+        // biome-ignore format: preserve layout
         gl.texSubImage3D(glTarget, mipLevel, x, y, z, width, height, depth, glFormat, glType, byteOffset);
       }
       break;
@@ -113,10 +113,10 @@ export function copyGPUBufferToMipLevel(
     case '2d':
     case 'cube':
       if (compressed) {
-        // prettier-ignore
+        // biome-ignore format: preserve layout
         gl.compressedTexSubImage2D(glTarget, mipLevel, x, y, width, height, glFormat, byteLength, byteOffset);
       } else {
-        // prettier-ignore
+        // biome-ignore format: preserve layout
         gl.texSubImage2D(glTarget, mipLevel, x, y, width, height, BORDER, glFormat, byteOffset);
       }
       break;
@@ -132,7 +132,7 @@ export function copyGPUBufferToMipLevel(
 export function getWebGLTextureTarget(
   dimension: '1d' | '2d' | '2d-array' | 'cube' | 'cube-array' | '3d'
 ): GLTextureTarget {
-  // prettier-ignore
+  // biome-ignore format: preserve layout
   switch (dimension) {
     case '1d': break; // not supported in any WebGL version
     case '2d': return GL.TEXTURE_2D; // supported in WebGL1

package/src/adapter/helpers/webgl-topology-utils.ts

@@ -81,7 +81,7 @@ export function getGLDrawMode(
   | GL.TRIANGLES
   | GL.TRIANGLE_STRIP
   | GL.TRIANGLE_FAN {
-  // prettier-ignore
+  // biome-ignore format: preserve layout
   switch (topology) {
     case 'point-list': return GL.POINTS;
     case 'line-list': return GL.LINES;
@@ -94,7 +94,7 @@ export function getGLDrawMode(
 
 /** Get the primitive type for transform feedback */
 export function getGLPrimitive(topology: PrimitiveTopology): GL.POINTS | GL.LINES | GL.TRIANGLES {
-  // prettier-ignore
+  // biome-ignore format: preserve layout
   switch (topology) {
     case 'point-list': return GL.POINTS;
     case 'line-list': return GL.LINES;

package/src/adapter/resources/webgl-command-buffer.ts

@@ -345,10 +345,10 @@ function _clearTexture(device: WebGLDevice, options: ClearTextureOptions) {
     case '2d-array':
     case '3d':
       if (compressed) {
-        // prettier-ignore
+        // biome-ignore format: preserve layout
         device.gl.compressedTexImage3D(glTarget, mipLevel, glInternalFormat, width, height, depth, BORDER, null);
       } else {
-        // prettier-ignore
+        // biome-ignore format: preserve layout
         device.gl.texImage3D( glTarget, mipLevel, glInternalFormat, width, height, depth, BORDER, glFormat, glType, null);
       }
       break;
@@ -356,10 +356,10 @@ function _clearTexture(device: WebGLDevice, options: ClearTextureOptions) {
     case '2d':
     case 'cube':
       if (compressed) {
-        // prettier-ignore
+        // biome-ignore format: preserve layout
         device.gl.compressedTexImage2D(glTarget, mipLevel, glInternalFormat, width, height, BORDER, null);
       } else {
-        // prettier-ignore
+        // biome-ignore format: preserve layout
         device.gl.texImage2D(glTarget, mipLevel, glInternalFormat, width, height, BORDER, glFormat, glType, null);
       }
       break;

package/src/adapter/resources/webgl-render-pipeline.ts

@@ -114,37 +114,37 @@ export class WEBGLRenderPipeline extends RenderPipeline {
             value
           )();
         }
-        continue;
-      }
-      if (!value) {
-        log.warn(`Unsetting binding "${name}" in render pipeline "${this.id}"`)();
-      }
-      switch (binding.type) {
-        case 'uniform':
-          // @ts-expect-error
-          if (!(value instanceof WEBGLBuffer) && !(value.buffer instanceof WEBGLBuffer)) {
-            throw new Error('buffer value');
-          }
-          break;
-        case 'texture':
-          if (
-            !(
-              value instanceof WEBGLTextureView ||
-              value instanceof WEBGLTexture ||
-              value instanceof WEBGLFramebuffer
-            )
-          ) {
-            throw new Error(`${this} Bad texture binding for ${name}`);
-          }
-          break;
-        case 'sampler':
-          log.warn(`Ignoring sampler ${name}`)();
-          break;
-        default:
-          throw new Error(binding.type);
-      }
+      } else {
+        if (!value) {
+          log.warn(`Unsetting binding "${name}" in render pipeline "${this.id}"`)();
+        }
+        switch (binding.type) {
+          case 'uniform':
+            // @ts-expect-error
+            if (!(value instanceof WEBGLBuffer) && !(value.buffer instanceof WEBGLBuffer)) {
+              throw new Error('buffer value');
+            }
+            break;
+          case 'texture':
+            if (
+              !(
+                value instanceof WEBGLTextureView ||
+                value instanceof WEBGLTexture ||
+                value instanceof WEBGLFramebuffer
+              )
+            ) {
+              throw new Error(`${this} Bad texture binding for ${name}`);
+            }
+            break;
+          case 'sampler':
+            log.warn(`Ignoring sampler ${name}`)();
+            break;
+          default:
+            throw new Error(binding.type);
+        }
 
-      this.bindings[name] = value;
+        this.bindings[name] = value;
+      }
     }
   }
 

package/src/adapter/resources/webgl-texture.ts

@@ -191,12 +191,12 @@ export class WEBGLTexture extends Texture {
       switch (this.dimension) {
         case '2d':
         case 'cube':
-          // prettier-ignore
+          // biome-ignore format: preserve layout
           this.gl.texSubImage2D(glTarget, mipLevel, x, y, width, height, glFormat, glType, image);
           break;
         case '2d-array':
         case '3d':
-          // prettier-ignore
+          // biome-ignore format: preserve layout
           this.gl.texSubImage3D(glTarget, mipLevel, x, y, z, width, height, depth, glFormat, glType, image);
           break;
         default:
@@ -367,14 +367,14 @@ export class WEBGLTexture extends Texture {
         case 'cube':
           if (compressed) {
             if (isFullMipUpload) {
-              // prettier-ignore
+              // biome-ignore format: preserve layout
               this.gl.compressedTexImage2D(glTarget, mipLevel, glFormat, width, height, 0, compressedData);
             } else {
-              // prettier-ignore
+              // biome-ignore format: preserve layout
               this.gl.compressedTexSubImage2D(glTarget, mipLevel, x, y, width, height, glFormat, compressedData);
             }
           } else {
-            // prettier-ignore
+            // biome-ignore format: preserve layout
             this.gl.texSubImage2D(glTarget, mipLevel, x, y, width, height, glFormat, glType, typedArray, sourceElementOffset);
           }
           break;
@@ -382,7 +382,7 @@ export class WEBGLTexture extends Texture {
         case '3d':
           if (compressed) {
             if (isFullMipUpload) {
-              // prettier-ignore
+              // biome-ignore format: preserve layout
               this.gl.compressedTexImage3D(
                 glTarget,
                 mipLevel,
@@ -394,7 +394,7 @@ export class WEBGLTexture extends Texture {
                 compressedData
               );
             } else {
-              // prettier-ignore
+              // biome-ignore format: preserve layout
               this.gl.compressedTexSubImage3D(
                 glTarget,
                 mipLevel,
@@ -409,7 +409,7 @@ export class WEBGLTexture extends Texture {
               );
             }
           } else {
-            // prettier-ignore
+            // biome-ignore format: preserve layout
             this.gl.texSubImage3D(glTarget, mipLevel, x, y, z, width, height, depthOrArrayLayers, glFormat, glType, typedArray, sourceElementOffset);
           }
           break;
@@ -722,7 +722,7 @@ function getWebGLTextureSourceElementOffset(
 export function getWebGLTextureTarget(
   dimension: '1d' | '2d' | '2d-array' | 'cube' | 'cube-array' | '3d'
 ): GLTextureTarget {
-  // prettier-ignore
+  // biome-ignore format: preserve layout
   switch (dimension) {
     case '1d': break; // not supported in any WebGL version
     case '2d': return GL.TEXTURE_2D; // supported in WebGL1

package/src/adapter/webgl-device.ts

@@ -233,7 +233,10 @@ export class WebGLDevice extends Device {
     const contextData = getWebGLContextData(this.handle);
     contextData.device = this; // Update GL context: Link webgl context back to device
 
-    this.extensions = contextData.extensions || (contextData.extensions = {});
+    if (!contextData.extensions) {
+      contextData.extensions = {};
+    }
+    this.extensions = contextData.extensions;
 
     // initialize luma Device fields
     this.info = getDeviceInfo(this.gl, this.extensions);

package/src/context/debug/webgl-developer-tools.ts

@@ -139,7 +139,8 @@ function onGLError(
     'color: white; background: red; padding: 2px 6px; border-radius: 3px;',
     message
   )();
-  debugger; // eslint-disable-line
+  // biome-ignore lint/suspicious/noDebugger: pause immediately on WebGL debug utility errors.
+  debugger;
   throw new Error(message);
 }
 
@@ -163,7 +164,8 @@ function onValidateGLFunc(
   for (const arg of functionArgs) {
     if (arg === undefined) {
       functionString = functionString || getFunctionString(functionName, functionArgs);
-      debugger; // eslint-disable-line
+      // biome-ignore lint/suspicious/noDebugger: pause when validating undefined WebGL call arguments.
+      debugger;
       // throw new Error(`Undefined argument: ${functionString}`);
     }
   }