@luma.gl/webgl 9.2.3 → 9.2.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@luma.gl/webgl",
-  "version": "9.2.3",
+  "version": "9.2.4",
   "description": "WebGL2 adapter for the luma.gl core API",
   "type": "module",
   "license": "MIT",
@@ -43,9 +43,9 @@
     "@luma.gl/core": "~9.2.0"
   },
   "dependencies": {
-    "@luma.gl/constants": "9.2.3",
+    "@luma.gl/constants": "9.2.4",
     "@math.gl/types": "^4.1.0",
     "@probe.gl/env": "^4.0.8"
   },
-  "gitHead": "8bf227ad55baec4e01b16de6ad1093a13b04d605"
+  "gitHead": "b79327df108eb0febd307cc73b8f7196c383114e"
 }

package/src/adapter/resources/webgl-texture.ts

@@ -145,12 +145,26 @@ export class WEBGLTexture extends Texture {
     const {width, height, depth} = this;
     const {mipLevel = 0, byteOffset = 0, x = 0, y = 0, z = 0} = options;
     const {glFormat, glType, compressed} = this;
-    const glTarget = getWebGLCubeFaceTarget(this.glTarget, this.dimension, depth);
 
-    // WebGL automatically ignores these for compressed textures, but we are careful
+    // Target used for face updates, but not for binding
+    const glTarget = getWebGLCubeFaceTarget(this.glTarget, this.dimension, z);
+
+    let unpackRowLength: number | undefined;
+    if (!this.compressed) {
+      const {bytesPerPixel} = this.device.getTextureFormatInfo(this.format);
+      if (bytesPerPixel) {
+        if (options.bytesPerRow % bytesPerPixel !== 0) {
+          throw new Error(
+            `bytesPerRow (${options.bytesPerRow}) must be a multiple of bytesPerPixel (${bytesPerPixel}) for ${this.format}`
+          );
+        }
+        unpackRowLength = options.bytesPerRow / bytesPerPixel;
+      }
+    }
+
     const glParameters: GLValueParameters = !this.compressed
       ? {
-          [GL.UNPACK_ROW_LENGTH]: options.bytesPerRow,
+          ...(unpackRowLength !== undefined ? {[GL.UNPACK_ROW_LENGTH]: unpackRowLength} : {}),
           [GL.UNPACK_IMAGE_HEIGHT]: options.rowsPerImage
         }
       : {};