@luma.gl/webgl 9.0.11 → 9.1.0-alpha.2

package/src/adapter/resources/webgl-transform-feedback.ts

@@ -56,7 +56,7 @@ export class WEBGLTransformFeedback extends TransformFeedback {
 
   end(): void {
     this.gl.endTransformFeedback();
-    if (!this.bindOnUse) {
+    if (this.bindOnUse) {
       this._unbindBuffers();
     }
     this.gl.bindTransformFeedback(GL.TRANSFORM_FEEDBACK, null);

package/src/adapter/resources/webgl-vertex-array.ts

@@ -2,8 +2,9 @@
 // SPDX-License-Identifier: MIT
 // Copyright (c) vis.gl contributors
 
-import type {Device, Buffer, VertexArrayProps, TypedArray, NumberArray} from '@luma.gl/core';
-import {VertexArray, getScratchArray, fillArray} from '@luma.gl/core';
+import type {TypedArray, NumericArray} from '@math.gl/types';
+import type {Device, Buffer, VertexArrayProps} from '@luma.gl/core';
+import {VertexArray, getScratchArray} from '@luma.gl/core';
 import {GL} from '@luma.gl/constants';
 import {getBrowser} from '@probe.gl/env';
 
@@ -11,7 +12,7 @@ import {WebGLDevice} from '../webgl-device';
 import {WEBGLBuffer} from '../resources/webgl-buffer';
 
 import {getGLFromVertexType} from '../converters/vertex-formats';
-// import {getGLFromVertexType} from '../converters/vertex-formats';
+import {fillArray} from '../../utils/fill-array';
 
 /** VertexArrayObject wrapper */
 export class WEBGLVertexArray extends VertexArray {
@@ -32,10 +33,10 @@ export class WEBGLVertexArray extends VertexArray {
   }
 
   // Create a VertexArray
-  constructor(device: WebGLDevice, props?: VertexArrayProps) {
+  constructor(device: WebGLDevice, props: VertexArrayProps) {
     super(device, props);
     this.device = device;
-    this.handle = this.device.gl.createVertexArray();
+    this.handle = this.device.gl.createVertexArray()!;
   }
 
   override destroy(): void {
@@ -96,6 +97,9 @@ export class WEBGLVertexArray extends VertexArray {
       // Attaches ARRAY_BUFFER with specified buffer format to location
       this.device.gl.vertexAttribPointer(location, size, type, normalized, stride, offset);
     }
+    // Clear binding - keeping it may cause [.WebGL-0x12804417100]
+    // GL_INVALID_OPERATION: A transform feedback buffer that would be written to is also bound to a non-transform-feedback target
+    this.device.gl.bindBuffer(GL.ARRAY_BUFFER, null);
 
     // Mark as non-constant
     this.device.gl.enableVertexAttribArray(location);
@@ -249,7 +253,7 @@ export class WEBGLVertexArray extends VertexArray {
  * TODO - convert Arrays based on known type? (read type from accessor, don't assume Float32Array)
  * TODO - handle single values for size 1 attributes?
  */
-function normalizeConstantArrayValue(arrayValue: NumberArray) {
+function normalizeConstantArrayValue(arrayValue: NumericArray) {
   if (Array.isArray(arrayValue)) {
     return new Float32Array(arrayValue);
   }
@@ -259,7 +263,7 @@ function normalizeConstantArrayValue(arrayValue: NumberArray) {
 /**
  *
  */
-function compareConstantArrayValues(v1: NumberArray, v2: NumberArray): boolean {
+function compareConstantArrayValues(v1: NumericArray, v2: NumericArray): boolean {
   if (!v1 || !v2 || v1.length !== v2.length || v1.constructor !== v2.constructor) {
     return false;
   }

package/src/adapter/webgl-canvas-context.ts

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: MIT
 // Copyright (c) vis.gl contributors
 
-import type {CanvasContextProps} from '@luma.gl/core';
+import type {CanvasContextProps, TextureFormat} from '@luma.gl/core';
 import {CanvasContext} from '@luma.gl/core';
 import {WebGLDevice} from './webgl-device';
 import {WEBGLFramebuffer} from './resources/webgl-framebuffer';
@@ -12,6 +12,9 @@ import {WEBGLFramebuffer} from './resources/webgl-framebuffer';
  */
 export class WebGLCanvasContext extends CanvasContext {
   readonly device: WebGLDevice;
+  readonly format: TextureFormat = 'rgba8unorm';
+  readonly depthStencilFormat: TextureFormat = 'depth24plus';
+
   presentationSize: [number, number];
   private _framebuffer: WEBGLFramebuffer | null = null;
 

package/src/adapter/webgl-device.ts

@@ -2,19 +2,10 @@
 // SPDX-License-Identifier: MIT
 // Copyright (c) vis.gl contributors
 
-import type {
-  DeviceProps,
-  DeviceInfo,
-  CanvasContextProps,
-  TextureFormat,
-  VertexArray,
-  VertexArrayProps,
-  Framebuffer,
-  Buffer,
-  Texture,
-  TypedArray
-} from '@luma.gl/core';
-import {Device, CanvasContext, log, uid, assert} from '@luma.gl/core';
+import type {TypedArray} from '@math.gl/types';
+import type {DeviceProps, DeviceInfo, CanvasContextProps, TextureFormat} from '@luma.gl/core';
+import type {Buffer, Texture, Framebuffer, VertexArray, VertexArrayProps} from '@luma.gl/core';
+import {Device, CanvasContext, log} from '@luma.gl/core';
 import type {GLExtensions} from '@luma.gl/constants';
 import {
   popContextState,
@@ -192,7 +183,7 @@ ${device.info.vendor}, ${device.info.renderer} for canvas: ${device.canvasContex
   //
 
   constructor(props: DeviceProps) {
-    super({...props, id: props.id || uid('webgl-device')});
+    super({...props, id: props.id || 'webgl-device'});
 
     // If attaching to an already attached context, return the attached device
     // @ts-expect-error device is attached to context
@@ -298,7 +289,8 @@ ${device.info.vendor}, ${device.info.renderer} for canvas: ${device.canvasContex
     return new WEBGLBuffer(this, newProps);
   }
 
-  _createTexture(props: TextureProps): WEBGLTexture {
+  // _createTexture(props: TextureProps): WEBGLTexture {
+  _createTexture(props: TextureProps): Texture {
     return new WEBGLTexture(this, props);
   }
 
@@ -348,7 +340,7 @@ ${device.info.vendor}, ${device.info.renderer} for canvas: ${device.canvasContex
 
   private renderPass: WEBGLRenderPass | null = null;
 
-  override createCommandEncoder(props?: CommandEncoderProps): WEBGLCommandEncoder {
+  override createCommandEncoder(props: CommandEncoderProps = {}): WEBGLCommandEncoder {
     return new WEBGLCommandEncoder(this, props);
   }
 
@@ -538,7 +530,7 @@ ${device.info.vendor}, ${device.info.renderer} for canvas: ${device.canvasContex
         setConstantUintArray(this, location, constant as Uint32Array);
         break;
       default:
-        assert(false);
+        throw new Error('constant');
     }
   }
 
@@ -574,7 +566,7 @@ function setConstantFloatArray(device: WebGLDevice, location: number, array: Flo
       device.gl.vertexAttrib4fv(location, array);
       break;
     default:
-      assert(false);
+    // assert(false);
   }
 }
 

package/src/classic/accessor.ts

@@ -2,10 +2,39 @@
 // SPDX-License-Identifier: MIT
 // Copyright (c) vis.gl contributors
 
-import {assert, checkProps, Buffer, AccessorObject} from '@luma.gl/core';
+import {Buffer} from '@luma.gl/core';
 import {GL} from '@luma.gl/constants';
 import {getTypedArrayFromGLType} from './typed-array-utils';
 
+/**
+ * Attribute descriptor object
+ * @deprecated Use ShaderLayout
+ */
+export interface AccessorObject {
+  buffer?: Buffer;
+  // format: VertexFormat;
+  offset?: number;
+  // can now be described with single WebGPU-style `format` string
+
+  //
+  stride?: number;
+
+  /** @deprecated - Use accessor.stepMode */
+  divisor?: number;
+
+  /** @deprecated - Infer from format */
+  type?: number;
+  /** @deprecated - Infer from format */
+  size?: number;
+  /** @deprecated - Infer from format */
+  normalized?: boolean;
+  /** @deprecated - Infer from format */
+  integer?: boolean;
+
+  /** @deprecated */
+  index?: number;
+}
+
 const DEFAULT_ACCESSOR_VALUES = {
   offset: 0,
   stride: 0,
@@ -16,13 +45,6 @@ const DEFAULT_ACCESSOR_VALUES = {
   integer: false
 };
 
-const PROP_CHECKS = {
-  deprecatedProps: {
-    instanced: 'divisor',
-    isInstanced: 'divisor'
-  }
-};
-
 export class Accessor implements AccessorObject {
   offset?: number;
   stride?: number;
@@ -43,7 +65,7 @@ export class Accessor implements AccessorObject {
   }
 
   static getBytesPerVertex(accessor: AccessorObject): number {
-    assert(accessor.size);
+    // assert(accessor.size);
     // TODO: using `FLOAT` when type is not specified,
     // ensure this assumption is valid or force API to specify type.
     const ArrayType = getTypedArrayFromGLType(accessor.type || GL.FLOAT);
@@ -82,8 +104,6 @@ export class Accessor implements AccessorObject {
 
   // eslint-disable-next-line complexity, max-statements
   _assign(props: AccessorObject = {}): this {
-    props = checkProps('Accessor', props, PROP_CHECKS);
-
     if (props.type !== undefined) {
       this.type = props.type;
 

package/src/classic/clear.ts

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: MIT
 // Copyright (c) vis.gl contributors
 
-import {Device, Framebuffer, assert} from '@luma.gl/core';
+import {Device, Framebuffer} from '@luma.gl/core';
 import {WebGLDevice} from '../adapter/webgl-device';
 import {withGLParameters} from '../context/state-tracker/with-parameters';
 
@@ -16,9 +16,6 @@ const GL_DEPTH = 0x1801;
 const GL_STENCIL = 0x1802;
 const GL_DEPTH_STENCIL = 0x84f9;
 
-// Should disappear if asserts are removed
-const ERR_ARGUMENTS = 'clear: bad arguments';
-
 /**
  * Optionally clears depth, color and stencil buffers
  * @deprecated Set clear color when creating a RenderPass.
@@ -57,7 +54,7 @@ export function clear(
     }
   }
 
-  assert(clearFlags !== 0, ERR_ARGUMENTS);
+  // assert(clearFlags !== 0, ERR_ARGUMENTS);
 
   // Temporarily set any clear "colors" and call clear
   const gl = (device as WebGLDevice).gl;
@@ -112,7 +109,7 @@ export function clearBuffer(
         break;
 
       default:
-        assert(false, ERR_ARGUMENTS);
+      // assert(false, ERR_ARGUMENTS);
     }
   });
 }

package/src/classic/copy-and-blit.ts

@@ -2,14 +2,14 @@
 // SPDX-License-Identifier: MIT
 // Copyright (c) vis.gl contributors
 
-import {assert, Buffer, Texture, Framebuffer, FramebufferProps} from '@luma.gl/core';
+import {Buffer, Texture, Framebuffer, FramebufferProps} from '@luma.gl/core';
 import {GL} from '@luma.gl/constants';
 
-import {WEBGLTextureView} from '../adapter/resources/webgl-texture-view';
 import {WEBGLFramebuffer} from '../adapter/resources/webgl-framebuffer';
 import {getGLTypeFromTypedArray, getTypedArrayFromGLType} from './typed-array-utils';
 import {glFormatToComponents, glTypeToBytes} from './format-utils';
 import {WEBGLBuffer} from '../adapter/resources/webgl-buffer';
+import {WEBGLTexture} from '../adapter/resources/webgl-texture';
 
 /**
  * Copies data from a type  or a Texture object into ArrayBuffer object.
@@ -51,8 +51,8 @@ export function readPixelsToArray(
   } = options || {};
 
   const {framebuffer, deleteFramebuffer} = getFramebuffer(source);
-  assert(framebuffer);
-  const {gl, handle} = framebuffer as WEBGLFramebuffer;
+  // assert(framebuffer);
+  const {gl, handle} = framebuffer;
   sourceWidth = sourceWidth || framebuffer.width;
   sourceHeight = sourceHeight || framebuffer.height;
 
@@ -66,9 +66,7 @@ export function readPixelsToArray(
 
   // Deduce the type from color attachment if not provided.
   sourceType =
-    sourceType ||
-    (framebuffer.colorAttachments[attachment] as WEBGLTextureView)?.texture?.type ||
-    GL.UNSIGNED_BYTE;
+    sourceType || framebuffer.colorAttachments[attachment]?.texture?.glType || GL.UNSIGNED_BYTE;
 
   // Deduce type and allocated pixelArray if needed
   target = getPixelArray(target, sourceType, sourceFormat, sourceWidth, sourceHeight);
@@ -117,12 +115,12 @@ export function readPixelsToBuffer(
   // following parameters are auto deduced if not provided
   let {sourceWidth, sourceHeight, sourceType} = options || {};
   const {framebuffer, deleteFramebuffer} = getFramebuffer(source);
-  assert(framebuffer);
+  // assert(framebuffer);
   sourceWidth = sourceWidth || framebuffer.width;
   sourceHeight = sourceHeight || framebuffer.height;
 
   // Asynchronous read (PIXEL_PACK_BUFFER) is WebGL2 only feature
-  const webglFramebuffer = framebuffer as WEBGLFramebuffer;
+  const webglFramebuffer = framebuffer;
 
   // deduce type if not available.
   sourceType = sourceType || GL.UNSIGNED_BYTE;
@@ -193,8 +191,8 @@ export function copyToTexture(
   } = options || {};
 
   const {framebuffer, deleteFramebuffer} = getFramebuffer(source);
-  assert(framebuffer);
-  const webglFramebuffer = framebuffer as WEBGLFramebuffer;
+  // assert(framebuffer);
+  const webglFramebuffer = framebuffer;
   const {device, handle} = webglFramebuffer;
   const isSubCopy =
     typeof targetX !== 'undefined' ||
@@ -206,16 +204,18 @@ export function copyToTexture(
   const prevHandle = device.gl.bindFramebuffer(GL.FRAMEBUFFER, handle);
   // TODO - support gl.readBuffer (WebGL2 only)
   // const prevBuffer = gl.readBuffer(attachment);
-  assert(target);
-  let texture = null;
+  // assert(target);
+  let texture: WEBGLTexture | null = null;
   let textureTarget: GL;
-  if (target instanceof Texture) {
+  if (target instanceof WEBGLTexture) {
     texture = target;
     width = Number.isFinite(width) ? width : texture.width;
     height = Number.isFinite(height) ? height : texture.height;
-    texture.bind(0);
+    texture?.bind(0);
+    // @ts-ignore
     textureTarget = texture.target;
   } else {
+    // @ts-ignore
     textureTarget = target;
   }
 
@@ -274,20 +274,20 @@ export function copyToTexture(
 }
 
 function getFramebuffer(source: Texture | Framebuffer): {
-  framebuffer: Framebuffer;
+  framebuffer: WEBGLFramebuffer;
   deleteFramebuffer: boolean;
 } {
   if (!(source instanceof Framebuffer)) {
     return {framebuffer: toFramebuffer(source), deleteFramebuffer: true};
   }
-  return {framebuffer: source, deleteFramebuffer: false};
+  return {framebuffer: source as WEBGLFramebuffer, deleteFramebuffer: false};
 }
 
 /**
  * Wraps a given texture into a framebuffer object, that can be further used
  * to read data from the texture object.
  */
-export function toFramebuffer(texture: Texture, props?: FramebufferProps): Framebuffer {
+export function toFramebuffer(texture: Texture, props?: FramebufferProps): WEBGLFramebuffer {
   const {device, width, height, id} = texture;
   const framebuffer = device.createFramebuffer({
     ...props,
@@ -296,7 +296,7 @@ export function toFramebuffer(texture: Texture, props?: FramebufferProps): Frame
     height,
     colorAttachments: [texture]
   });
-  return framebuffer;
+  return framebuffer as WEBGLFramebuffer;
 }
 
 function getPixelArray(

package/src/classic/format-utils.ts

@@ -2,7 +2,6 @@
 // SPDX-License-Identifier: MIT
 // Copyright (c) vis.gl contributors
 
-import {assert} from '@luma.gl/core';
 import {GL} from '@luma.gl/constants';
 
 // Returns number of components in a specific readPixels WebGL format
@@ -23,7 +22,6 @@ export function glFormatToComponents(format) {
       return 4;
     // TODO: Add support for additional WebGL2 formats
     default:
-      assert(false);
       return 0;
   }
 }
@@ -41,7 +39,6 @@ export function glTypeToBytes(type) {
       return 4;
     // TODO: Add support for additional WebGL2 types
     default:
-      assert(false);
       return 0;
   }
 }

package/src/classic/typed-array-utils.ts

@@ -2,7 +2,7 @@
 // SPDX-License-Identifier: MIT
 // Copyright (c) vis.gl contributors
 
-import {TypedArray, TypedArrayConstructor} from '@luma.gl/core';
+import {TypedArray, TypedArrayConstructor} from '@math.gl/types';
 import {GL, GLDataType, GLPixelType} from '@luma.gl/constants';
 
 const ERR_TYPE_DEDUCTION = 'Failed to deduce GL constant from typed array';

package/src/context/debug/spector.ts

@@ -2,7 +2,8 @@
 // SPDX-License-Identifier: MIT
 // Copyright (c) vis.gl contributors
 
-import {log, loadScript} from '@luma.gl/core';
+import {log} from '@luma.gl/core';
+import {loadScript} from '../../utils/load-script';
 
 /** Spector debug initialization options */
 type SpectorProps = {

package/src/context/debug/webgl-developer-tools.ts

@@ -2,10 +2,11 @@
 // SPDX-License-Identifier: MIT
 // Copyright (c) vis.gl contributors
 
-import {log, loadScript} from '@luma.gl/core';
+import {log} from '@luma.gl/core';
 // Rename constant to prevent inlining. We need the full set of constants for generating debug strings.
 import {GL as GLEnum} from '@luma.gl/constants';
 import {isBrowser} from '@probe.gl/env';
+import {loadScript} from '../../utils/load-script';
 
 const WEBGL_DEBUG_CDN_URL = 'https://unpkg.com/webgl-debug@2.0.1/index.js';
 
@@ -58,12 +59,7 @@ export async function loadWebGLDeveloperTools(): Promise<void> {
 export function makeDebugContext(
   gl: WebGL2RenderingContext,
   props: DebugContextProps = {}
-): WebGL2RenderingContext | null {
-  // Return null to ensure we don't try to create a context in this case (TODO what case is that?)
-  if (!gl) {
-    return null;
-  }
-
+): WebGL2RenderingContext {
   return props.debug ? getDebugContext(gl, props) : getRealContext(gl);
 }
 

package/src/context/parameters/webgl-parameter-tables.ts

@@ -100,7 +100,7 @@ const pixelStorei = (gl: WebGL2RenderingContext, value: number | boolean, key: G
 
 const bindFramebuffer = (gl: WebGL2RenderingContext, value: unknown, key: GL) => {
   const target = key === GL.FRAMEBUFFER_BINDING ? GL.DRAW_FRAMEBUFFER : GL.READ_FRAMEBUFFER;
-  return gl.bindFramebuffer(target, value);
+  return gl.bindFramebuffer(target, value as WebGLFramebuffer);
 };
 
 const bindBuffer = (gl: WebGL2RenderingContext, value: unknown, key: GL) => {
@@ -113,7 +113,7 @@ const bindBuffer = (gl: WebGL2RenderingContext, value: unknown, key: GL) => {
   };
   const glTarget = bindingMap[key];
 
-  gl.bindBuffer(glTarget, value);
+  gl.bindBuffer(glTarget as number, value as WebGLBuffer | null);
 };
 
 // Utility
@@ -304,7 +304,7 @@ export const GL_PARAMETER_SETTERS = {
     gl.polygonOffset(...value),
 
   sampleCoverage: (gl: WebGL2RenderingContext, value: [number, boolean?]) =>
-    gl.sampleCoverage(...value),
+    gl.sampleCoverage(value[0], value[1] || false),
 
   scissorTest: (gl: WebGL2RenderingContext, value) =>
     value ? gl.enable(GL.SCISSOR_TEST) : gl.disable(GL.SCISSOR_TEST),

package/src/context/state-tracker/track-context-state.ts

@@ -4,7 +4,6 @@
 
 // Support for listening to context state changes and intercepting state queries
 // NOTE: this system does not handle buffer bindings
-import {assert} from '@luma.gl/core';
 import {
   GL_PARAMETER_DEFAULTS,
   GL_HOOKED_SETTERS,
@@ -44,7 +43,7 @@ class GLState {
   }
 
   pop() {
-    assert(this.stateStack.length > 0);
+    // assert(this.stateStack.length > 0);
     // Use the saved values in the state stack to restore parameters
     const oldValues = this.stateStack[this.stateStack.length - 1];
     setGLParameters(this.gl, oldValues);
@@ -66,7 +65,7 @@ class GLState {
       this.stateStack.length > 0 ? this.stateStack[this.stateStack.length - 1] : null;
 
     for (const key in values) {
-      assert(key !== undefined);
+      // assert(key !== undefined);
       const value = values[key];
       const cached = this.cache[key];
       // Check that value hasn't already been shadowed
@@ -113,8 +112,8 @@ export function trackContextState(
     log?: any;
   }
 ): WebGL2RenderingContext {
-  const {enable = true, copyState} = options;
-  assert(copyState !== undefined);
+  const {enable = true, copyState} = options || {};
+  // assert(copyState !== undefined);
   // @ts-expect-error
   if (!gl.state) {
     // @ts-ignore
@@ -163,7 +162,7 @@ export function pushContextState(gl: WebGL2RenderingContext): void {
  */
 export function popContextState(gl: WebGL2RenderingContext): void {
   const glState = getContextState(gl);
-  assert(glState);
+  // assert(glState);
   glState.pop();
 }
 

package/src/index.ts

@@ -16,7 +16,6 @@ export {WebGLDevice} from './adapter/webgl-device';
 export {WebGLCanvasContext} from './adapter/webgl-canvas-context';
 
 // WebGL Resource classes
-export {WebGLResource, WebGLResource as WEBGLResource} from './adapter/objects/webgl-resource';
 export {WEBGLBuffer} from './adapter/resources/webgl-buffer';
 export {WEBGLTexture} from './adapter/resources/webgl-texture';
 // export {WEBGLExternalTexture} from './adapter/resources/webgl-external-texture';
@@ -44,11 +43,6 @@ export {setDeviceParameters, withDeviceParameters} from './adapter/converters/de
 
 // HELPERS - EXPERIMENTAL
 export {getShaderLayout} from './adapter/helpers/get-shader-layout';
-export {convertGLToTextureFormat} from './adapter/converters/texture-formats';
-
-// Internal WebGL classes
-export type {RenderbufferProps as _RenderbufferProps} from './adapter/objects/webgl-renderbuffer';
-export {WEBGLRenderbuffer as _WEBGLRenderbuffer} from './adapter/objects/webgl-renderbuffer';
 
 // TEST EXPORTS
 export {TEXTURE_FORMATS as _TEXTURE_FORMATS} from './adapter/converters/texture-formats';

package/src/utils/fill-array.ts

@@ -0,0 +1,35 @@
+// luma.gl
+// SPDX-License-Identifier: MIT
+// Copyright (c) vis.gl contributors
+
+import type {NumberArray} from '@math.gl/types';
+
+// Uses copyWithin to significantly speed up typed array value filling
+export function fillArray(options: {
+  target: NumberArray;
+  source: NumberArray;
+  start?: number;
+  count?: number;
+}): NumberArray {
+  const {target, source, start = 0, count = 1} = options;
+  const length = source.length;
+  const total = count * length;
+  let copied = 0;
+  for (let i = start; copied < length; copied++) {
+    target[i++] = source[copied];
+  }
+
+  while (copied < total) {
+    // If we have copied less than half, copy everything we got
+    // else copy remaining in one operation
+    if (copied < total - copied) {
+      target.copyWithin(start + copied, start, start + copied);
+      copied *= 2;
+    } else {
+      target.copyWithin(start + copied, start, start + total - copied);
+      copied = total;
+    }
+  }
+
+  return options.target;
+}

package/src/utils/load-script.ts

@@ -0,0 +1,30 @@
+// luma.gl
+// SPDX-License-Identifier: MIT
+// Copyright (c) vis.gl contributors
+
+/**
+ * Load a script (identified by an url). When the url returns, the
+ * content of this file is added into a new script element, attached to the DOM (body element)
+ * @param scriptUrl defines the url of the script to laod
+ * @param scriptId defines the id of the script element
+ */
+export async function loadScript(scriptUrl: string, scriptId?: string): Promise<Event> {
+  const head = document.getElementsByTagName('head')[0];
+  if (!head) {
+    throw new Error('loadScript');
+  }
+
+  const script = document.createElement('script');
+  script.setAttribute('type', 'text/javascript');
+  script.setAttribute('src', scriptUrl);
+  if (scriptId) {
+    script.id = scriptId;
+  }
+
+  return new Promise((resolve, reject) => {
+    script.onload = resolve;
+    script.onerror = error =>
+      reject(new Error(`Unable to load script '${scriptUrl}': ${error as string}`));
+    head.appendChild(script);
+  });
+}

package/src/utils/split-uniforms-and-bindings.ts

@@ -0,0 +1,31 @@
+// luma.gl
+// SPDX-License-Identifier: MIT
+// Copyright (c) vis.gl contributors
+
+import type {UniformValue, Binding} from '@luma.gl/core';
+import {isNumericArray} from '@math.gl/types';
+
+export function isUniformValue(value: unknown): boolean {
+  return isNumericArray(value) !== null || typeof value === 'number' || typeof value === 'boolean';
+}
+
+type UniformsAndBindings = {
+  bindings: Record<string, Binding>;
+  uniforms: Record<string, UniformValue>;
+};
+
+export function splitUniformsAndBindings(
+  uniforms: Record<string, Binding | UniformValue>
+): UniformsAndBindings {
+  const result: UniformsAndBindings = {bindings: {}, uniforms: {}};
+  Object.keys(uniforms).forEach(name => {
+    const uniform = uniforms[name];
+    if (isUniformValue(uniform)) {
+      result.uniforms[name] = uniform as UniformValue;
+    } else {
+      result.bindings[name] = uniform as Binding;
+    }
+  });
+
+  return result;
+}

package/dist/adapter/objects/constants-to-keys.d.ts

@@ -1,3 +0,0 @@
-import { GL } from '@luma.gl/constants';
-export declare function getKeyValue(gl: WebGL2RenderingContext, name: string | GL): GL;
-//# sourceMappingURL=constants-to-keys.d.ts.map

package/dist/adapter/objects/constants-to-keys.d.ts.map

@@ -1 +0,0 @@
-{"version":3,"file":"constants-to-keys.d.ts","sourceRoot":"","sources":["../../../src/adapter/objects/constants-to-keys.ts"],"names":[],"mappings":"AAKA,OAAO,EAAC,EAAE,EAAC,MAAM,oBAAoB,CAAC;AAGtC,wBAAgB,WAAW,CAAC,EAAE,EAAE,sBAAsB,EAAE,IAAI,EAAE,MAAM,GAAG,EAAE,GAAG,EAAE,CAkB7E"}