@luma.gl/webgl 9.0.0-beta.4 → 9.0.0-beta.5

package/dist/context/context/context-data.js

@@ -0,0 +1,33 @@
+// luma.gl, MIT license
+// Copyright (c) vis.gl contributors
+/**
+ * Gets luma.gl specific state from a context
+ * @returns context state
+ */
+export function getContextData(gl) {
+    // @ts-expect-error
+    const luma = gl.luma;
+    if (!luma) {
+        const contextState = {
+            _polyfilled: false,
+            _extensions: {}
+        };
+        // @ts-expect-error
+        gl.luma = contextState;
+    }
+    // @ts-expect-error
+    return gl.luma;
+}
+export function initializeExtensions(gl) {
+    const contextState = getContextData(gl);
+    // `getSupportedExtensions` can return null when context is lost.
+    const EXTENSIONS = gl.getSupportedExtensions() || [];
+    // Generates warnings in Chrome
+    const IGNORE_EXTENSIONS = ['WEBGL_polygon_mode'];
+    for (const extensionName of EXTENSIONS) {
+        if (!IGNORE_EXTENSIONS.includes(extensionName)) {
+            const extension = gl.getExtension(extensionName);
+            contextState._extensions[extensionName] = extension;
+        }
+    }
+}

package/dist/context/context/create-browser-context.d.ts

@@ -1,7 +1,5 @@
 /**
  * ContextProps
- * @param webgl2 Set to false to not create a WebGL2 context (force webgl1)
- * @param webgl1 set to false to not create a WebGL1 context (fail if webgl2 not available)
  * @param onContextLost
  * @param onContextRestored
  *
@@ -16,9 +14,6 @@
  * @param failIfMajorPerformanceCaveat Do not create if the system performance is low.
  */
 type ContextProps = {
-    type?: 'webgl' | 'webgl1' | 'webgl2' | string;
-    webgl1?: boolean;
-    webgl2?: boolean;
     onContextLost?: (event: Event) => void;
     onContextRestored?: (event: Event) => void;
     alpha?: boolean;
@@ -35,6 +30,6 @@ type ContextProps = {
  * Note calling this multiple time on the same canvas does return the same context
  * @param canvas A canvas element or offscreen canvas
  */
-export declare function createBrowserContext(canvas: HTMLCanvasElement | OffscreenCanvas, props: ContextProps): WebGLRenderingContext;
+export declare function createBrowserContext(canvas: HTMLCanvasElement | OffscreenCanvas, props: ContextProps): WebGL2RenderingContext;
 export {};
 //# sourceMappingURL=create-browser-context.d.ts.map

package/dist/context/context/create-browser-context.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"create-browser-context.d.ts","sourceRoot":"","sources":["../../../src/context/context/create-browser-context.ts"],"names":[],"mappings":"AAGA;;;;;;;;;;;;;;;;GAgBG;AACH,KAAK,YAAY,GAAG;IAClB,IAAI,CAAC,EAAE,OAAO,GAAG,QAAQ,GAAG,QAAQ,GAAG,MAAM,CAAC;IAC9C,MAAM,CAAC,EAAE,OAAO,CAAC;IACjB,MAAM,CAAC,EAAE,OAAO,CAAC;IACjB,aAAa,CAAC,EAAE,CAAC,KAAK,EAAE,KAAK,KAAK,IAAI,CAAC;IACvC,iBAAiB,CAAC,EAAE,CAAC,KAAK,EAAE,KAAK,KAAK,IAAI,CAAC;IAC3C,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,cAAc,CAAC,EAAE,OAAO,CAAC;IACzB,SAAS,CAAC,EAAE,OAAO,CAAC;IACpB,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,4BAA4B,CAAC,EAAE,OAAO,CAAC;IACvC,eAAe,CAAC,EAAE,SAAS,GAAG,kBAAkB,GAAG,WAAW,CAAC;IAC/D,kBAAkB,CAAC,EAAE,OAAO,CAAC;IAC7B,qBAAqB,CAAC,EAAE,OAAO,CAAC;CACjC,CAAC;AAYF;;;;GAIG;AACH,wBAAgB,oBAAoB,CAClC,MAAM,EAAE,iBAAiB,GAAG,eAAe,EAC3C,KAAK,EAAE,YAAY,GAClB,qBAAqB,CAiEvB"}
+{"version":3,"file":"create-browser-context.d.ts","sourceRoot":"","sources":["../../../src/context/context/create-browser-context.ts"],"names":[],"mappings":"AAGA;;;;;;;;;;;;;;GAcG;AACH,KAAK,YAAY,GAAG;IAClB,aAAa,CAAC,EAAE,CAAC,KAAK,EAAE,KAAK,KAAK,IAAI,CAAC;IACvC,iBAAiB,CAAC,EAAE,CAAC,KAAK,EAAE,KAAK,KAAK,IAAI,CAAC;IAC3C,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,cAAc,CAAC,EAAE,OAAO,CAAC;IACzB,SAAS,CAAC,EAAE,OAAO,CAAC;IACpB,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,4BAA4B,CAAC,EAAE,OAAO,CAAC;IACvC,eAAe,CAAC,EAAE,SAAS,GAAG,kBAAkB,GAAG,WAAW,CAAC;IAC/D,kBAAkB,CAAC,EAAE,OAAO,CAAC;IAC7B,qBAAqB,CAAC,EAAE,OAAO,CAAC;CACjC,CAAC;AAUF;;;;GAIG;AACH,wBAAgB,oBAAoB,CAClC,MAAM,EAAE,iBAAiB,GAAG,eAAe,EAC3C,KAAK,EAAE,YAAY,GAClB,sBAAsB,CA+CxB"}

package/dist/context/context/create-browser-context.js

@@ -1,53 +1,66 @@
+// luma.gl, MIT license
+// Copyright (c) vis.gl contributors
 const DEFAULT_CONTEXT_PROPS = {
-  webgl2: true,
-  webgl1: true,
-  powerPreference: 'high-performance',
-  onContextLost: () => console.error('WebGL context lost'),
-  onContextRestored: () => console.info('WebGL context restored')
+    powerPreference: 'high-performance', // After all, most apps are using WebGL for performance reasons
+    // eslint-disable-next-line no-console
+    onContextLost: () => console.error('WebGL context lost'),
+    // eslint-disable-next-line no-console
+    onContextRestored: () => console.info('WebGL context restored')
 };
+/**
+ * Create a WebGL context for a canvas
+ * Note calling this multiple time on the same canvas does return the same context
+ * @param canvas A canvas element or offscreen canvas
+ */
 export function createBrowserContext(canvas, props) {
-  props = {
-    ...DEFAULT_CONTEXT_PROPS,
-    ...props
-  };
-  let errorMessage = null;
-  const onCreateError = error => errorMessage = error.statusMessage || errorMessage;
-  canvas.addEventListener('webglcontextcreationerror', onCreateError, false);
-  let gl = null;
-  if (props.type === 'webgl2') {
-    props = {
-      ...props,
-      webgl1: false
-    };
-  }
-  if (props.type === 'webgl1') {
-    props = {
-      ...props,
-      webgl2: false
-    };
-  }
-  if (!gl && props.webgl2) {
-    gl = canvas.getContext('webgl2', props);
-  }
-  if (!gl && props.webgl1) {
-    gl = canvas.getContext('webgl', props);
-  }
-  canvas.removeEventListener('webglcontextcreationerror', onCreateError, false);
-  if (!gl) {
-    throw new Error(`Failed to create ${props.webgl2 && !props.webgl1 ? 'WebGL2' : 'WebGL'} context: ${errorMessage || 'Unknown error'}`);
-  }
-  if (props.onContextLost) {
-    const {
-      onContextLost
-    } = props;
-    canvas.addEventListener('webglcontextlost', event => onContextLost(event), false);
-  }
-  if (props.onContextRestored) {
-    const {
-      onContextRestored
-    } = props;
-    canvas.addEventListener('webglcontextrestored', event => onContextRestored(event), false);
-  }
-  return gl;
+    props = { ...DEFAULT_CONTEXT_PROPS, ...props };
+    // Try to extract any extra information about why context creation failed
+    let errorMessage = null;
+    const onCreateError = error => (errorMessage = error.statusMessage || errorMessage);
+    canvas.addEventListener('webglcontextcreationerror', onCreateError, false);
+    // Create the desired context
+    let gl = null;
+    // props.failIfMajorPerformanceCaveat = true;
+    // We require webgl2 context
+    gl ||= canvas.getContext('webgl2', props);
+    // Software GPU
+    // props.failIfMajorPerformanceCaveat = false;
+    // if (!gl && props.webgl1) {
+    //   gl = canvas.getContext('webgl', props);
+    // }
+    // TODO are we removing this listener before giving it a chance to fire?
+    canvas.removeEventListener('webglcontextcreationerror', onCreateError, false);
+    if (!gl) {
+        throw new Error(`Failed to create WebGL context: ${errorMessage || 'Unknown error'}`);
+    }
+    if (props.onContextLost) {
+        // Carefully extract and wrap callbacks to prevent addEventListener from rebinding them.
+        const { onContextLost } = props;
+        canvas.addEventListener('webglcontextlost', (event) => onContextLost(event), false);
+    }
+    if (props.onContextRestored) {
+        // Carefully extract and wrap callbacks to prevent addEventListener from rebinding them.
+        const { onContextRestored } = props;
+        canvas.addEventListener('webglcontextrestored', (event) => onContextRestored(event), false);
+    }
+    return gl;
 }
-//# sourceMappingURL=create-browser-context.js.map
+/* TODO - can we call this asynchronously to catch the error events?
+export async function createBrowserContextAsync(canvas: HTMLCanvasElement | OffscreenCanvas, props: ContextProps): Promise<WebGL2RenderingContext> {
+  props = {...DEFAULT_CONTEXT_PROPS, ...props};
+
+ // Try to extract any extra information about why context creation failed
+ let errorMessage = null;
+ const onCreateError = (error) => (errorMessage = error.statusMessage || errorMessage);
+ canvas.addEventListener('webglcontextcreationerror', onCreateError, false);
+
+ const gl = createBrowserContext(canvas, props);
+
+ // Give the listener a chance to fire
+ await new Promise(resolve => setTimeout(resolve, 0));
+
+ canvas.removeEventListener('webglcontextcreationerror', onCreateError, false);
+
+ return gl;
+}
+*/

package/dist/context/debug/spector.js

@@ -1,64 +1,68 @@
+// luma.gl, MIT license
+// Copyright (c) vis.gl contributors
 import { log, loadScript } from '@luma.gl/core';
 const DEFAULT_SPECTOR_PROPS = {
-  spector: log.get('spector') || log.get('inspect')
+    spector: log.get('spector') || log.get('inspect')
 };
+// https://github.com/BabylonJS/Spector.js#basic-usage
 const SPECTOR_CDN_URL = 'https://spectorcdn.babylonjs.com/spector.bundle.js';
 const LOG_LEVEL = 1;
 let spector = null;
 let initialized = false;
+/** Loads spector from CDN if not already installed */
 export async function loadSpectorJS(props) {
-  if (!globalThis.SPECTOR) {
-    try {
-      await loadScript(SPECTOR_CDN_URL);
-    } catch (error) {
-      log.warn(String(error));
+    if (!globalThis.SPECTOR) {
+        try {
+            await loadScript(SPECTOR_CDN_URL);
+        }
+        catch (error) {
+            log.warn(String(error));
+        }
     }
-  }
 }
 export function initializeSpectorJS(props) {
-  var _props, _props2;
-  props = {
-    ...DEFAULT_SPECTOR_PROPS,
-    ...props
-  };
-  if (!((_props = props) !== null && _props !== void 0 && _props.spector)) {
-    return null;
-  }
-  if (!spector && globalThis.SPECTOR) {
-    log.probe(LOG_LEVEL, 'SPECTOR found and initialized')();
-    spector = new globalThis.SPECTOR.Spector();
-    if (globalThis.luma) {
-      globalThis.luma.spector = spector;
+    props = { ...DEFAULT_SPECTOR_PROPS, ...props };
+    if (!props?.spector) {
+        return null;
     }
-  }
-  if (!spector) {
-    return null;
-  }
-  if (!initialized) {
-    var _spector, _spector2;
-    initialized = true;
-    spector.spyCanvases();
-    (_spector = spector) === null || _spector === void 0 ? void 0 : _spector.onCaptureStarted.add(capture => log.info('Spector capture started:', capture)());
-    (_spector2 = spector) === null || _spector2 === void 0 ? void 0 : _spector2.onCapture.add(capture => {
-      var _spector3, _spector4, _spector5;
-      log.info('Spector capture complete:', capture)();
-      (_spector3 = spector) === null || _spector3 === void 0 ? void 0 : _spector3.getResultUI();
-      (_spector4 = spector) === null || _spector4 === void 0 ? void 0 : _spector4.resultView.display();
-      (_spector5 = spector) === null || _spector5 === void 0 ? void 0 : _spector5.resultView.addCapture(capture);
-    });
-  }
-  if ((_props2 = props) !== null && _props2 !== void 0 && _props2.canvas) {
-    var _spector6, _props3;
-    if (typeof props.spector === 'string' && props.spector !== props.canvas.id) {
-      return spector;
+    if (!spector && globalThis.SPECTOR) {
+        log.probe(LOG_LEVEL, 'SPECTOR found and initialized')();
+        spector = new globalThis.SPECTOR.Spector();
+        if (globalThis.luma) {
+            globalThis.luma.spector = spector;
+        }
     }
-    (_spector6 = spector) === null || _spector6 === void 0 ? void 0 : _spector6.startCapture((_props3 = props) === null || _props3 === void 0 ? void 0 : _props3.canvas, 500);
-    new Promise(resolve => setTimeout(resolve, 2000)).then(_ => {
-      var _spector7;
-      log.info('Spector capture stopped after 2 seconds')();
-      (_spector7 = spector) === null || _spector7 === void 0 ? void 0 : _spector7.stopCapture();
-    });
-  }
-  return spector;
+    if (!spector) {
+        return null;
+    }
+    if (!initialized) {
+        initialized = true;
+        // enables recording some extra information merged in the capture like texture memory sizes and formats
+        spector.spyCanvases();
+        // A callback when results are ready
+        spector?.onCaptureStarted.add((capture) => log.info('Spector capture started:', capture)());
+        spector?.onCapture.add((capture) => {
+            log.info('Spector capture complete:', capture)();
+            // Use undocumented Spector API to open the UI with our capture
+            // See https://github.com/BabylonJS/Spector.js/blob/767ad1195a25b85a85c381f400eb50a979239eca/src/spector.ts#L124
+            spector?.getResultUI();
+            spector?.resultView.display();
+            spector?.resultView.addCapture(capture);
+        });
+    }
+    if (props?.canvas) {
+        // @ts-expect-error If spector is specified as a canvas id, only monitor that canvas
+        if (typeof props.spector === 'string' && props.spector !== props.canvas.id) {
+            return spector;
+        }
+        // capture startup
+        // spector?.captureCanvas(props?.canvas);
+        spector?.startCapture(props?.canvas, 500); // 500 commands
+        new Promise(resolve => setTimeout(resolve, 2000)).then(_ => {
+            log.info('Spector capture stopped after 2 seconds')();
+            spector?.stopCapture();
+            // spector?.displayUI();
+        });
+    }
+    return spector;
 }
-//# sourceMappingURL=spector.js.map

package/dist/context/debug/webgl-developer-tools.d.ts

@@ -2,7 +2,6 @@ type DebugContextProps = {
     debug?: boolean;
     throwOnError?: boolean;
     break?: string[];
-    webgl2?: boolean;
 };
 declare global {
     var WebGLDebugUtils: any;
@@ -14,6 +13,6 @@ declare global {
  * @see https://github.com/vorg/webgl-debug
  */
 export declare function loadWebGLDeveloperTools(): Promise<void>;
-export declare function makeDebugContext(gl: WebGLRenderingContext, props?: DebugContextProps): WebGLRenderingContext | null;
+export declare function makeDebugContext(gl: WebGL2RenderingContext, props?: DebugContextProps): WebGL2RenderingContext | null;
 export {};
 //# sourceMappingURL=webgl-developer-tools.d.ts.map

package/dist/context/debug/webgl-developer-tools.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"webgl-developer-tools.d.ts","sourceRoot":"","sources":["../../../src/context/debug/webgl-developer-tools.ts"],"names":[],"mappings":"AAUA,KAAK,iBAAiB,GAAG;IACvB,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,YAAY,CAAC,EAAE,OAAO,CAAC;IACvB,KAAK,CAAC,EAAE,MAAM,EAAE,CAAC;IACjB,MAAM,CAAC,EAAE,OAAO,CAAC;CAClB,CAAC;AAoBF,OAAO,CAAC,MAAM,CAAC;IAEb,IAAI,eAAe,EAAE,GAAG,CAAC;CAC1B;AAED;;;;;GAKG;AACH,wBAAsB,uBAAuB,IAAI,OAAO,CAAC,IAAI,CAAC,CAO7D;AAID,wBAAgB,gBAAgB,CAAC,EAAE,EAAE,qBAAqB,EAAE,KAAK,GAAE,iBAAsB,GAAG,qBAAqB,GAAG,IAAI,CAOvH"}
+{"version":3,"file":"webgl-developer-tools.d.ts","sourceRoot":"","sources":["../../../src/context/debug/webgl-developer-tools.ts"],"names":[],"mappings":"AAUA,KAAK,iBAAiB,GAAG;IACvB,KAAK,CAAC,EAAE,OAAO,CAAC;IAChB,YAAY,CAAC,EAAE,OAAO,CAAC;IACvB,KAAK,CAAC,EAAE,MAAM,EAAE,CAAC;CAClB,CAAC;AAoBF,OAAO,CAAC,MAAM,CAAC;IAEb,IAAI,eAAe,EAAE,GAAG,CAAC;CAC1B;AAED;;;;;GAKG;AACH,wBAAsB,uBAAuB,IAAI,OAAO,CAAC,IAAI,CAAC,CAO7D;AAID,wBAAgB,gBAAgB,CAAC,EAAE,EAAE,sBAAsB,EAAE,KAAK,GAAE,iBAAsB,GAAG,sBAAsB,GAAG,IAAI,CAOzH"}

package/dist/context/debug/webgl-developer-tools.js

@@ -1,98 +1,124 @@
+// luma.gl, MIT license
+// Copyright (c) vis.gl contributors
 import { log, loadScript } from '@luma.gl/core';
+// Rename constant to prevent inlining. We need the full set of constants for generating debug strings.
 import { GL as GLEnum } from '@luma.gl/constants';
 import { isBrowser } from '@probe.gl/env';
 const WEBGL_DEBUG_CDN_URL = 'https://unpkg.com/webgl-debug@2.0.1/index.js';
+// Helper to get shared context data
 function getContextData(gl) {
-  gl.luma = gl.luma || {};
-  return gl.luma;
+    gl.luma = gl.luma || {};
+    return gl.luma;
 }
+/**
+ * Loads Khronos WebGLDeveloperTools from CDN if not already installed
+ * const WebGLDebugUtils = require('webgl-debug');
+ * @see https://github.com/KhronosGroup/WebGLDeveloperTools
+ * @see https://github.com/vorg/webgl-debug
+ */
 export async function loadWebGLDeveloperTools() {
-  if (isBrowser() && !globalThis.WebGLDebugUtils) {
-    globalThis.global = globalThis.global || globalThis;
-    globalThis.global.module = {};
-    await loadScript(WEBGL_DEBUG_CDN_URL);
-  }
+    if (isBrowser() && !globalThis.WebGLDebugUtils) {
+        globalThis.global = globalThis.global || globalThis;
+        // @ts-expect-error Developer tools expects global to be set
+        globalThis.global.module = {};
+        await loadScript(WEBGL_DEBUG_CDN_URL);
+    }
 }
-export function makeDebugContext(gl) {
-  let props = arguments.length > 1 && arguments[1] !== undefined ? arguments[1] : {};
-  if (!gl) {
-    return null;
-  }
-  return props.debug ? getDebugContext(gl, props) : getRealContext(gl);
+// Returns (a potentially new) context with debug instrumentation turned off or on.
+// Note that this actually returns a new context
+export function makeDebugContext(gl, props = {}) {
+    // Return null to ensure we don't try to create a context in this case (TODO what case is that?)
+    if (!gl) {
+        return null;
+    }
+    return props.debug ? getDebugContext(gl, props) : getRealContext(gl);
 }
+// Returns the real context from either of the real/debug contexts
 function getRealContext(gl) {
-  const data = getContextData(gl);
-  return data.realContext ? data.realContext : gl;
+    const data = getContextData(gl);
+    // If the context has a realContext member, it is a debug context so return the realContext
+    return data.realContext ? data.realContext : gl;
 }
+// Returns the debug context from either of the real/debug contexts
 function getDebugContext(gl, props) {
-  if (!globalThis.WebGLDebugUtils) {
-    log.warn('webgl-debug not loaded')();
-    return gl;
-  }
-  const data = getContextData(gl);
-  if (data.debugContext) {
-    return data.debugContext;
-  }
-  globalThis.WebGLDebugUtils.init({
-    ...GLEnum,
-    ...gl
-  });
-  const glDebug = globalThis.WebGLDebugUtils.makeDebugContext(gl, onGLError.bind(null, props), onValidateGLFunc.bind(null, props));
-  for (const key in GLEnum) {
-    if (!(key in glDebug) && typeof GLEnum[key] === 'number') {
-      glDebug[key] = GLEnum[key];
+    if (!globalThis.WebGLDebugUtils) {
+        log.warn('webgl-debug not loaded')();
+        return gl;
+    }
+    const data = getContextData(gl);
+    // If this already has a debug context, return it.
+    if (data.debugContext) {
+        return data.debugContext;
+    }
+    // Create a new debug context
+    globalThis.WebGLDebugUtils.init({ ...GLEnum, ...gl });
+    const glDebug = globalThis.WebGLDebugUtils.makeDebugContext(gl, onGLError.bind(null, props), onValidateGLFunc.bind(null, props));
+    // Make sure we have all WebGL2 and extension constants (todo dynamic import to circumvent minification?)
+    for (const key in GLEnum) {
+        if (!(key in glDebug) && typeof GLEnum[key] === 'number') {
+            glDebug[key] = GLEnum[key];
+        }
     }
-  }
-  class WebGLDebugContext {}
-  Object.setPrototypeOf(glDebug, Object.getPrototypeOf(gl));
-  Object.setPrototypeOf(WebGLDebugContext, glDebug);
-  const debugContext = Object.create(WebGLDebugContext);
-  data.realContext = gl;
-  data.debugContext = debugContext;
-  debugContext.debug = true;
-  return debugContext;
+    // Ensure we have a clean prototype on the instrumented object
+    // Note: setPrototypeOf does come with perf warnings, but we already take a bigger perf reduction
+    // by synchronizing the WebGL errors after each WebGL call.
+    class WebGLDebugContext {
+    }
+    Object.setPrototypeOf(glDebug, Object.getPrototypeOf(gl));
+    Object.setPrototypeOf(WebGLDebugContext, glDebug);
+    const debugContext = Object.create(WebGLDebugContext);
+    // Store the debug context
+    data.realContext = gl;
+    data.debugContext = debugContext;
+    debugContext.debug = true;
+    // Return it
+    return debugContext;
 }
+// DEBUG TRACING
 function getFunctionString(functionName, functionArgs) {
-  functionArgs = Array.from(functionArgs).map(arg => arg === undefined ? 'undefined' : arg);
-  let args = globalThis.WebGLDebugUtils.glFunctionArgsToString(functionName, functionArgs);
-  args = `${args.slice(0, 100)}${args.length > 100 ? '...' : ''}`;
-  return `gl.${functionName}(${args})`;
+    // Cover bug in webgl-debug-tools
+    functionArgs = Array.from(functionArgs).map(arg => arg === undefined ? 'undefined' : arg);
+    let args = globalThis.WebGLDebugUtils.glFunctionArgsToString(functionName, functionArgs);
+    args = `${args.slice(0, 100)}${args.length > 100 ? '...' : ''}`;
+    return `gl.${functionName}(${args})`;
 }
 function onGLError(props, err, functionName, args) {
-  args = Array.from(args).map(arg => arg === undefined ? 'undefined' : arg);
-  const errorMessage = globalThis.WebGLDebugUtils.glEnumToString(err);
-  const functionArgs = globalThis.WebGLDebugUtils.glFunctionArgsToString(functionName, args);
-  const glName = props.webgl2 ? 'gl2' : 'gl1';
-  const message = `${errorMessage} in ${glName}.${functionName}(${functionArgs})`;
-  log.error(message)();
-  debugger;
-  if (props.throwOnError) {
-    throw new Error(message);
-  }
+    // Cover bug in webgl-debug-tools
+    args = Array.from(args).map(arg => arg === undefined ? 'undefined' : arg);
+    const errorMessage = globalThis.WebGLDebugUtils.glEnumToString(err);
+    const functionArgs = globalThis.WebGLDebugUtils.glFunctionArgsToString(functionName, args);
+    const message = `${errorMessage} in gl.${functionName}(${functionArgs})`;
+    log.error(message)();
+    debugger; // eslint-disable-line
+    if (props.throwOnError) {
+        throw new Error(message);
+    }
 }
+// Don't generate function string until it is needed
 function onValidateGLFunc(props, functionName, functionArgs) {
-  let functionString = '';
-  if (log.level >= 1) {
-    functionString = getFunctionString(functionName, functionArgs);
-    log.log(1, functionString)();
-  }
-  if (props.break && props.break.length > 0) {
-    functionString = functionString || getFunctionString(functionName, functionArgs);
-    const isBreakpoint = props.break.every(breakOn => functionString.indexOf(breakOn) !== -1);
-    if (isBreakpoint) {
-      debugger;
+    let functionString = '';
+    if (log.level >= 1) {
+        functionString = getFunctionString(functionName, functionArgs);
+        log.log(1, functionString)();
+    }
+    // If array of breakpoint strings supplied, check if any of them is contained in current GLEnum function
+    if (props.break && props.break.length > 0) {
+        functionString = functionString || getFunctionString(functionName, functionArgs);
+        const isBreakpoint = props.break.every((breakOn) => functionString.indexOf(breakOn) !== -1);
+        if (isBreakpoint) {
+            debugger; // eslint-disable-line
+        }
     }
-  }
-  for (const arg of functionArgs) {
-    if (arg === undefined) {
-      functionString = functionString || getFunctionString(functionName, functionArgs);
-      if (props.throwOnError) {
-        throw new Error(`Undefined argument: ${functionString}`);
-      } else {
-        log.error(`Undefined argument: ${functionString}`)();
-        debugger;
-      }
+    for (const arg of functionArgs) {
+        if (arg === undefined) {
+            functionString = functionString || getFunctionString(functionName, functionArgs);
+            if (props.throwOnError) {
+                throw new Error(`Undefined argument: ${functionString}`);
+            }
+            else {
+                log.error(`Undefined argument: ${functionString}`)();
+                debugger; // eslint-disable-line
+            }
+        }
     }
-  }
 }
-//# sourceMappingURL=webgl-developer-tools.js.map

package/dist/context/parameters/unified-parameter-api.d.ts

@@ -7,7 +7,7 @@ export type { GLParameters };
  * @note requires a `cache` object to be set on the context (gl.state.cache)
  * This object is used to fill in any missing values for composite setter functions
  */
-export declare function setGLParameters(device: Device | WebGLRenderingContext, parameters: GLParameters): void;
+export declare function setGLParameters(device: Device | WebGL2RenderingContext, parameters: GLParameters): void;
 /**
  * Reads the entire WebGL state from a context
 
@@ -22,12 +22,12 @@ export declare function setGLParameters(device: Device | WebGLRenderingContext,
  * considered a very slow operation, to be used only if/when a context already manipulated
  * by external code needs to be synchronized for the first time
  */
-export declare function getGLParameters(device: Device | WebGLRenderingContext, parameters?: keyof GLParameters | (keyof GLParameters)[] | GLParameters): GLParameters;
+export declare function getGLParameters(device: Device | WebGL2RenderingContext, parameters?: keyof GLParameters | (keyof GLParameters)[] | GLParameters): GLParameters;
 /**
  * Reset all parameters to a (almost) pure context state
  * @note viewport and scissor will be set to the values in GL_PARAMETER_DEFAULTS,
  * NOT the canvas size dimensions, so they will have to be properly set after
  * calling this function.
  */
-export declare function resetGLParameters(device: Device | WebGLRenderingContext): void;
+export declare function resetGLParameters(device: Device | WebGL2RenderingContext): void;
 //# sourceMappingURL=unified-parameter-api.d.ts.map

package/dist/context/parameters/unified-parameter-api.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"unified-parameter-api.d.ts","sourceRoot":"","sources":["../../../src/context/parameters/unified-parameter-api.ts"],"names":[],"mappings":"AAMA,OAAO,EAAC,MAAM,EAAC,MAAM,eAAe,CAAC;AACrC,OAAO,KAAK,EAAC,YAAY,EAAC,MAAM,oBAAoB,CAAC;AAUrD,YAAY,EAAC,YAAY,EAAC,CAAC;AAE3B;;;;;GAKG;AACH,wBAAgB,eAAe,CAC7B,MAAM,EAAE,MAAM,GAAG,qBAAqB,EACtC,UAAU,EAAE,YAAY,GACvB,IAAI,CAiDN;AAED;;;;;;;;;;;;;GAaG;AACH,wBAAgB,eAAe,CAC7B,MAAM,EAAE,MAAM,GAAG,qBAAqB,EACtC,UAAU,GAAE,MAAM,YAAY,GAAG,CAAC,MAAM,YAAY,CAAC,EAAE,GAAG,YAAoC,GAC7F,YAAY,CAqBd;AAED;;;;;GAKG;AACH,wBAAgB,iBAAiB,CAAC,MAAM,EAAE,MAAM,GAAG,qBAAqB,GAAG,IAAI,CAE9E"}
+{"version":3,"file":"unified-parameter-api.d.ts","sourceRoot":"","sources":["../../../src/context/parameters/unified-parameter-api.ts"],"names":[],"mappings":"AAMA,OAAO,EAAC,MAAM,EAAC,MAAM,eAAe,CAAC;AACrC,OAAO,KAAK,EAAC,YAAY,EAAC,MAAM,oBAAoB,CAAC;AAUrD,YAAY,EAAC,YAAY,EAAC,CAAC;AAE3B;;;;;GAKG;AACH,wBAAgB,eAAe,CAC7B,MAAM,EAAE,MAAM,GAAG,sBAAsB,EACvC,UAAU,EAAE,YAAY,GACvB,IAAI,CAiDN;AAED;;;;;;;;;;;;;GAaG;AACH,wBAAgB,eAAe,CAC7B,MAAM,EAAE,MAAM,GAAG,sBAAsB,EACvC,UAAU,GAAE,MAAM,YAAY,GAAG,CAAC,MAAM,YAAY,CAAC,EAAE,GAAG,YAAoC,GAC7F,YAAY,CAqBd;AAED;;;;;GAKG;AACH,wBAAgB,iBAAiB,CAAC,MAAM,EAAE,MAAM,GAAG,sBAAsB,GAAG,IAAI,CAE/E"}