@luma.gl/core 9.3.4 → 9.3.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@luma.gl/core",
-  "version": "9.3.4",
+  "version": "9.3.5",
   "description": "The luma.gl core Device API",
   "license": "MIT",
   "type": "module",
@@ -46,5 +46,5 @@
     "@probe.gl/stats": "^4.1.1",
     "@types/offscreencanvas": "^2019.7.3"
   },
-  "gitHead": "f430daba8be25561034dca6bb0af3ea487c9d1c8"
+  "gitHead": "7c66d63f213836a3fc83f2ad0103d1d3dadf7633"
 }

package/src/adapter/canvas-observer.ts

@@ -2,22 +2,33 @@
 // SPDX-License-Identifier: MIT
 // Copyright (c) vis.gl contributors
 
+/** Options and callbacks used by {@link CanvasObserver}. */
 type CanvasObserverProps = {
+  /** HTML canvas element whose DOM lifecycle should be observed. */
   canvas?: HTMLCanvasElement;
+  /** Whether to poll for canvas position changes. */
   trackPosition: boolean;
+  /** ResizeObserver box type passed to `observe()`. */
+  resizeObserverBox: ResizeObserverBoxOptions;
+  /** Called with ResizeObserver entries for the observed canvas. */
   onResize: (entries: ResizeObserverEntry[]) => void;
+  /** Called with IntersectionObserver entries for the observed canvas. */
   onIntersection: (entries: IntersectionObserverEntry[]) => void;
+  /** Called when the window device pixel ratio may have changed. */
   onDevicePixelRatioChange: () => void;
+  /** Called while canvas position tracking is enabled. */
   onPositionChange: () => void;
 };
 
 /**
  * Internal DOM observer orchestration for HTML canvas surfaces.
  *
+ * @remarks
  * CanvasSurface owns the tracked state and device callback dispatch. This helper only manages
  * browser observers, timers, and polling loops, then reports events through callbacks.
  */
 export class CanvasObserver {
+  /** Observer options and event callbacks. */
   readonly props: CanvasObserverProps;
 
   private _resizeObserver: ResizeObserver | undefined;
@@ -28,14 +39,21 @@ export class CanvasObserver {
   private _trackPositionInterval: ReturnType<typeof setInterval> | null = null;
   private _started = false;
 
+  /** Whether the DOM observers and polling loops have been started. */
   get started(): boolean {
     return this._started;
   }
 
+  /**
+   * Creates an observer coordinator for one HTML canvas.
+   *
+   * @param props - Observer options and event callbacks.
+   */
   constructor(props: CanvasObserverProps) {
     this.props = props;
   }
 
+  /** Starts DOM observation and optional position polling. */
   start(): void {
     if (this._started || !this.props.canvas) {
       return;
@@ -48,8 +66,9 @@ export class CanvasObserver {
     this._resizeObserver ||= new ResizeObserver(entries => this.props.onResize(entries));
 
     this._intersectionObserver.observe(this.props.canvas);
+    const box = this.props.resizeObserverBox;
     try {
-      this._resizeObserver.observe(this.props.canvas, {box: 'device-pixel-content-box'});
+      this._resizeObserver.observe(this.props.canvas, {box});
     } catch {
       this._resizeObserver.observe(this.props.canvas, {box: 'content-box'});
     }
@@ -61,6 +80,7 @@ export class CanvasObserver {
     }
   }
 
+  /** Stops DOM observation, media-query listeners, and position polling. */
   stop(): void {
     if (!this._started) {
       return;
@@ -90,6 +110,7 @@ export class CanvasObserver {
     this._intersectionObserver?.disconnect();
   }
 
+  /** Reports the current device pixel ratio and arms the media query for its next change. */
   private _refreshDevicePixelRatio(): void {
     if (!this._started) {
       return;
@@ -111,6 +132,11 @@ export class CanvasObserver {
     );
   }
 
+  /**
+   * Starts periodic position callbacks while the observer remains active.
+   *
+   * @param intervalMs - Poll interval in milliseconds.
+   */
   private _trackPosition(intervalMs: number = 100): void {
     if (this._trackPositionInterval) {
       return;

package/src/adapter/canvas-surface.ts

@@ -34,8 +34,8 @@ export type CanvasContextProps = {
    *
    * - `'exact'` uses `ResizeObserver.devicePixelContentBoxSize` when available to match the
    *   browser's exact physical pixel coverage.
-   * - `'css-dpr'` uses `Math.round(cssSize * devicePixelRatio)` to match overlays and external
-   *   canvases that still rely on legacy CSS-size times DPR rounding.
+   * - `'css-dpr'` uses `Math.floor(cssSize * devicePixelRatio)` to match overlays and external
+   *   canvases that size their drawing buffer via implicit truncation (e.g. `canvas.width = css * dpr`).
    */
   pixelSizeSource?: 'exact' | 'css-dpr';
   /** Whether to track window resizes. */
@@ -53,6 +53,11 @@ export type MutableCanvasContextProps = {
   useDevicePixels?: boolean | number;
 };
 
+type DevicePixelSize = {
+  devicePixelWidth: number;
+  devicePixelHeight: number;
+};
+
 /**
  * Shared tracked-canvas lifecycle used by both renderable and presentation contexts.
  * - Creates a new canvas or looks up a canvas from the DOM
@@ -176,6 +181,8 @@ export abstract class CanvasSurface {
     this._canvasObserver = new CanvasObserver({
       canvas: this.htmlCanvas,
       trackPosition: this.props.trackPosition,
+      resizeObserverBox:
+        this.props.pixelSizeSource === 'css-dpr' ? 'content-box' : 'device-pixel-content-box',
       onResize: entries => this._handleResize(entries),
       onIntersection: entries => this._handleIntersection(entries),
       onDevicePixelRatioChange: () => this._observeDevicePixelRatio(),
@@ -357,11 +364,7 @@ export abstract class CanvasSurface {
 
     const oldPixelSize = this.getDevicePixelSize();
 
-    const {devicePixelWidth, devicePixelHeight} = this._getDevicePixelSizeFromResizeEntry(entry);
-
-    const [maxDevicePixelWidth, maxDevicePixelHeight] = this.getMaxDrawingBufferSize();
-    this.devicePixelWidth = Math.max(1, Math.min(devicePixelWidth, maxDevicePixelWidth));
-    this.devicePixelHeight = Math.max(1, Math.min(devicePixelHeight, maxDevicePixelHeight));
+    this._setDevicePixelSize(this._getDevicePixelSizeFromResizeEntry(entry));
 
     this._updateDrawingBufferSize();
 
@@ -389,18 +392,14 @@ export abstract class CanvasSurface {
     this.updatePosition();
   }
 
-  protected _getDevicePixelSizeFromResizeEntry(entry: ResizeObserverEntry): {
-    devicePixelWidth: number;
-    devicePixelHeight: number;
-  } {
+  protected _getDevicePixelSizeFromResizeEntry(entry: ResizeObserverEntry): DevicePixelSize {
     const contentBoxSize = assertDefined(entry.contentBoxSize?.[0]);
 
     if (this.props.pixelSizeSource === 'css-dpr') {
-      const devicePixelRatio = this.getDevicePixelRatio();
-      return {
-        devicePixelWidth: Math.round(contentBoxSize.inlineSize * devicePixelRatio),
-        devicePixelHeight: Math.round(contentBoxSize.blockSize * devicePixelRatio)
-      };
+      return this._getDevicePixelSizeFromCSSSize(
+        contentBoxSize.inlineSize,
+        contentBoxSize.blockSize
+      );
     }
 
     return {
@@ -413,6 +412,20 @@ export abstract class CanvasSurface {
     };
   }
 
+  protected _getDevicePixelSizeFromCSSSize(cssWidth: number, cssHeight: number): DevicePixelSize {
+    const devicePixelRatio = this.getDevicePixelRatio();
+    return {
+      devicePixelWidth: Math.floor(cssWidth * devicePixelRatio),
+      devicePixelHeight: Math.floor(cssHeight * devicePixelRatio)
+    };
+  }
+
+  protected _setDevicePixelSize({devicePixelWidth, devicePixelHeight}: DevicePixelSize): void {
+    const [maxDevicePixelWidth, maxDevicePixelHeight] = this.getMaxDrawingBufferSize();
+    this.devicePixelWidth = Math.max(1, Math.min(devicePixelWidth, maxDevicePixelWidth));
+    this.devicePixelHeight = Math.max(1, Math.min(devicePixelHeight, maxDevicePixelHeight));
+  }
+
   _resizeDrawingBufferIfNeeded() {
     if (this._needsDrawingBufferResize) {
       this._needsDrawingBufferResize = false;
@@ -434,6 +447,15 @@ export abstract class CanvasSurface {
     const oldRatio = this.devicePixelRatio;
     this.devicePixelRatio = window.devicePixelRatio;
 
+    if (this.props.pixelSizeSource === 'css-dpr') {
+      // In css-dpr mode the ResizeObserver watches content-box, which won't fire on a pure DPR
+      // change (CSS size unchanged). Recalculate the drawing buffer from the new DPR here.
+      const oldPixelSize = this.getDevicePixelSize();
+      this._setDevicePixelSize(this._getDevicePixelSizeFromCSSSize(this.cssWidth, this.cssHeight));
+      this._updateDrawingBufferSize();
+      this.device.props.onResize(this as CanvasContext | PresentationContext, {oldPixelSize});
+    }
+
     this.updatePosition();
 
     this.device.props.onDevicePixelRatioChange?.(this as CanvasContext | PresentationContext, {