@luma.gl/core 9.0.0-beta.4 → 9.0.0-beta.6

package/src/adapter/resources/compute-pass.ts

@@ -1,21 +1,36 @@
+// luma.gl
+// SPDX-License-Identifier: MIT
+// Copyright (c) vis.gl contributors
+
 import {Resource, ResourceProps} from './resource';
 import {ComputePipeline} from './compute-pipeline';
-import {Buffer} from './buffer';
 import type {Device} from '../device';
+import {Buffer} from './buffer';
+import {QuerySet} from './query-set';
 
-export type ComputePassProps = ResourceProps & {};
+export type ComputePassProps = ResourceProps & {
+  /** QuerySet to write beging/end timestamps to */
+  timestampQuerySet?: QuerySet;
+  /** QuerySet index to write begin timestamp to. No timestamp is written if not provided. */
+  beginTimestampIndex?: number;
+  /** QuerySet index to write end timestamp to. No timestamp is written if not provided. */
+  endTimestampIndex?: number;
+};
 
 export abstract class ComputePass extends Resource<ComputePassProps> {
   static override defaultProps: Required<ComputePassProps> = {
-    ...Resource.defaultProps
-  }
+    ...Resource.defaultProps,
+    timestampQuerySet: undefined,
+    beginTimestampIndex: undefined,
+    endTimestampIndex: undefined
+  };
 
   override get [Symbol.toStringTag](): string {
     return 'ComputePass';
   }
 
   constructor(device: Device, props: ComputePassProps) {
-    super(device, props, Resource.defaultProps);
+    super(device, props, ComputePass.defaultProps);
   }
 
   abstract override destroy(): void;
@@ -42,11 +57,10 @@ export abstract class ComputePass extends Resource<ComputePassProps> {
    */
   abstract dispatchIndirect(indirectBuffer: Buffer, indirectOffset?: number): void;
 
+  /** Begins a labeled debug group containing subsequent commands */
   abstract pushDebugGroup(groupLabel: string): void;
+  /** Ends the labeled debug group most recently started by pushDebugGroup() */
   abstract popDebugGroup(): void;
+  /** Marks a point in a stream of commands with a label */
   abstract insertDebugMarker(markerLabel: string): void;
-
-  // writeTimestamp(querySet: GPUQuerySet, queryIndex: number): void;
-  // beginPipelineStatisticsQuery(querySet: GPUQuerySet, queryIndex: number): void;
-  // endPipelineStatisticsQuery(querySet: GPUQuerySet, queryIndex: number): void;
 }

package/src/adapter/resources/compute-pipeline.ts

@@ -1,4 +1,7 @@
-//
+// luma.gl
+// SPDX-License-Identifier: MIT
+// Copyright (c) vis.gl contributors
+
 import {Resource, ResourceProps} from './resource';
 import {BindingDeclaration} from '../types/shader-layout';
 import type {Device} from '../device';
@@ -25,7 +28,7 @@ export abstract class ComputePipeline extends Resource<ComputePipelineProps> {
     csEntryPoint: undefined,
     csConstants: {},
     shaderLayout: []
-  };  
+  };
 
   override get [Symbol.toStringTag](): string {
     return 'ComputePipeline';

package/src/adapter/resources/external-texture.ts

@@ -1,10 +1,14 @@
+// luma.gl
+// SPDX-License-Identifier: MIT
+// Copyright (c) vis.gl contributors
+
 import type {Device} from '../device';
 import {Resource, ResourceProps} from './resource';
 
 export type ExternalTextureProps = ResourceProps & {
   source: HTMLVideoElement | null;
   colorSpace?: 'srgb';
-}
+};
 export abstract class ExternalTexture extends Resource<ExternalTextureProps> {
   static override defaultProps: Required<ExternalTextureProps> = {
     ...Resource.defaultProps,
@@ -12,7 +16,9 @@ export abstract class ExternalTexture extends Resource<ExternalTextureProps> {
     colorSpace: 'srgb'
   };
 
-  override get [Symbol.toStringTag](): string { return 'ExternalTexture'; }
+  override get [Symbol.toStringTag](): string {
+    return 'ExternalTexture';
+  }
 
   constructor(device: Device, props: ExternalTextureProps) {
     super(device, props, ExternalTexture.defaultProps);

package/src/adapter/resources/framebuffer.ts

@@ -1,17 +1,23 @@
-// luma.gl, MIT license
+// luma.gl
+// SPDX-License-Identifier: MIT
 // Copyright (c) vis.gl contributors
 
-import type {ColorTextureFormat, DepthStencilTextureFormat, TextureFormat} from '../types/texture-formats';
+import type {
+  ColorTextureFormat,
+  DepthStencilTextureFormat,
+  TextureFormat
+} from '../types/texture-formats';
 import type {Device} from '../device';
 import {Resource, ResourceProps} from './resource';
 import {Texture} from './texture';
+import {TextureView} from './texture-view';
 import {log} from '../../utils/log';
 
 export type FramebufferProps = ResourceProps & {
   width?: number;
   height?: number;
-  colorAttachments?: (Texture | ColorTextureFormat)[];
-  depthStencilAttachment?: (Texture | DepthStencilTextureFormat) | null;
+  colorAttachments?: (TextureView | Texture | ColorTextureFormat)[];
+  depthStencilAttachment?: (TextureView | Texture | DepthStencilTextureFormat) | null;
 };
 
 /**
@@ -25,7 +31,7 @@ export abstract class Framebuffer extends Resource<FramebufferProps> {
     height: 1,
     colorAttachments: [], // ['rgba8unorm-unsized'],
     depthStencilAttachment: null // 'depth24plus-stencil8'
-  };  
+  };
 
   override get [Symbol.toStringTag](): string {
     return 'Framebuffer';
@@ -36,9 +42,9 @@ export abstract class Framebuffer extends Resource<FramebufferProps> {
   /** Height of all attachments in this framebuffer */
   height: number;
   /** Color attachments */
-  colorAttachments: Texture[] = [];
+  colorAttachments: TextureView[] = [];
   /** Depth-stencil attachment, if provided */
-  depthStencilAttachment: Texture | null = null;
+  depthStencilAttachment: TextureView | null = null;
 
   constructor(device: Device, props: FramebufferProps = {}) {
     super(device, props, Framebuffer.defaultProps);
@@ -53,7 +59,7 @@ export abstract class Framebuffer extends Resource<FramebufferProps> {
    * Resizes all attachments
    * @note resize() destroys existing textures (if size has changed).
    */
-  resize(size: {width: number; height: number;}): void;
+  resize(size: {width: number; height: number}): void;
   resize(size: [width: number, height: number]): void;
   resize(): void;
   resize(size?: {width: number; height: number} | [width: number, height: number]): void {
@@ -70,75 +76,30 @@ export abstract class Framebuffer extends Resource<FramebufferProps> {
     }
   }
 
-  // /** Returns fully populated attachment object. */
-  // protected normalizeColorAttachment(
-  //   attachment: Texture | ColorTextureFormat
-  // ): Required<ColorAttachment> {
-
-  //   const COLOR_ATTACHMENT_DEFAULTS: Required<ColorAttachment> = {
-  //     texture: undefined!,
-  //     format: undefined!,
-  //     clearValue: [0.0, 0.0, 0.0, 0.0],
-  //     loadOp: 'clear',
-  //     storeOp: 'store'
-  //   };
-
-  //   if (attachment instanceof Texture) {
-  //     return {...COLOR_ATTACHMENT_DEFAULTS, texture: attachment};
-  //   }
-  //   if (typeof attachment === 'string') {
-  //     return {...COLOR_ATTACHMENT_DEFAULTS, format: attachment};
-  //   }
-  //   return {...COLOR_ATTACHMENT_DEFAULTS, ...attachment};
-  // }
-
-  // /** Wraps texture inside fully populated attachment object. */
-  // protected normalizeDepthStencilAttachment(
-  //   attachment: DepthStencilAttachment | Texture | DepthStencilTextureFormat
-  // ): Required<DepthStencilAttachment> {
-  //   const DEPTH_STENCIL_ATTACHMENT_DEFAULTS: Required<DepthStencilAttachment> = {
-  //     texture: undefined!,
-  //     format: undefined!,
-
-  //     depthClearValue: 1.0,
-  //     depthLoadOp: 'clear',
-  //     depthStoreOp: 'store',
-  //     depthReadOnly: false,
-
-  //     stencilClearValue: 0,
-  //     stencilLoadOp: 'clear',
-  //     stencilStoreOp: 'store',
-  //     stencilReadOnly: false
-  //   };
-
-  //   if (typeof attachment === 'string') {
-  //     return {...DEPTH_STENCIL_ATTACHMENT_DEFAULTS, format: attachment};
-  //   }
-  //   // @ts-expect-error attachment instanceof Texture doesn't cover Renderbuffer
-  //   if (attachment.handle || attachment instanceof Texture) {
-  //     return {...DEPTH_STENCIL_ATTACHMENT_DEFAULTS, texture: attachment as Texture};
-  //   }
-  //   return {...DEPTH_STENCIL_ATTACHMENT_DEFAULTS, ...attachment};
-  // }
-
   /** Auto creates any textures */
-  protected autoCreateAttachmentTextures(){
+  protected autoCreateAttachmentTextures(): void {
     this.colorAttachments = this.props.colorAttachments.map(attachment => {
       if (typeof attachment === 'string') {
         const texture = this.createColorTexture(attachment);
         this.attachResource(texture);
-        return texture;
+        return texture.view;
+      }
+      if (attachment instanceof Texture) {
+        return attachment.view;
       }
       return attachment;
     });
 
-    if (this.props.depthStencilAttachment) {
-      if (typeof this.props.depthStencilAttachment === 'string') {
-        const texture = this.createDepthStencilTexture(this.props.depthStencilAttachment);
+    const attachment = this.props.depthStencilAttachment;
+    if (attachment) {
+      if (typeof attachment === 'string') {
+        const texture = this.createDepthStencilTexture(attachment);
         this.attachResource(texture);
-        this.depthStencilAttachment = texture;
+        this.depthStencilAttachment = texture.view;
+      } else if (attachment instanceof Texture) {
+        this.depthStencilAttachment = attachment.view;
       } else {
-        this.depthStencilAttachment = this.props.depthStencilAttachment;
+        this.depthStencilAttachment = attachment;
       }
     }
   }
@@ -150,7 +111,7 @@ export abstract class Framebuffer extends Resource<FramebufferProps> {
       usage: Texture.RENDER_ATTACHMENT,
       format,
       width: this.width,
-      height: this.height,
+      height: this.height
     });
   }
 
@@ -179,8 +140,8 @@ export abstract class Framebuffer extends Resource<FramebufferProps> {
           height
         });
         this.destroyAttachedResource(this.colorAttachments[i]);
-        this.colorAttachments[i] = resizedTexture;
-        this.attachResource(resizedTexture);
+        this.colorAttachments[i] = resizedTexture.view;
+        this.attachResource(resizedTexture.view);
       }
     }
 
@@ -191,40 +152,92 @@ export abstract class Framebuffer extends Resource<FramebufferProps> {
         height
       });
       this.destroyAttachedResource(this.depthStencilAttachment);
-      this.depthStencilAttachment = resizedTexture;
+      this.depthStencilAttachment = resizedTexture.view;
       this.attachResource(resizedTexture);
     }
   }
-
-  /** Create a color attachment for WebGL *
-  protected override createColorTexture(colorAttachment: Required<ColorAttachment>): Required<ColorAttachment> {
-    return this.device._createTexture({
-      id: `${this.id}-color`,
-      data: null, // reserves texture memory, but texels are undefined
-      format,
-      // type: GL.UNSIGNED_BYTE,
-      width: this.width,
-      height: this.height,
-      // Note: Mipmapping can be disabled by texture resource when we resize the texture
-      // to a non-power-of-two dimenstion (NPOT texture) under WebGL1. To have consistant
-      // behavior we always disable mipmaps.
-      mipmaps: false,
-      // Set MIN and MAG filtering parameters so mipmaps are not used in sampling.
-      // Use LINEAR so subpixel algos like fxaa work.
-      // Set WRAP modes that support NPOT textures too.
-      sampler: {
-        minFilter: 'linear',
-        magFilter: 'linear',
-        addressModeU: 'clamp-to-edge',
-        addressModeV: 'clamp-to-edge'
-      }
-      // parameters: {
-      //   [GL.TEXTURE_MIN_FILTER]: GL.LINEAR,
-      //   [GL.TEXTURE_MAG_FILTER]: GL.LINEAR,
-      //   [GL.TEXTURE_WRAP_S]: GL.CLAMP_TO_EDGE,
-      //   [GL.TEXTURE_WRAP_T]: GL.CLAMP_TO_EDGE
-      // }
-    });
-  }
-  */
 }
+
+// TODO - remove if not needed
+
+// Create a color attachment for WebGL *
+// protected override createColorTexture(colorAttachment: Required<ColorAttachment>): Required<ColorAttachment> {
+//   return this.device._createTexture({
+//     id: `${this.id}-color`,
+//     data: null, // reserves texture memory, but texels are undefined
+//     format,
+//     // type: GL.UNSIGNED_BYTE,
+//     width: this.width,
+//     height: this.height,
+//     // Note: Mipmapping can be disabled by texture resource when we resize the texture
+//     // to a non-power-of-two dimenstion (NPOT texture) under WebGL1. To have consistant
+//     // behavior we always disable mipmaps.
+//     mipmaps: false,
+//     // Set MIN and MAG filtering parameters so mipmaps are not used in sampling.
+//     // Use LINEAR so subpixel algos like fxaa work.
+//     // Set WRAP modes that support NPOT textures too.
+//     sampler: {
+//       minFilter: 'linear',
+//       magFilter: 'linear',
+//       addressModeU: 'clamp-to-edge',
+//       addressModeV: 'clamp-to-edge'
+//     }
+//     // parameters: {
+//     //   [GL.TEXTURE_MIN_FILTER]: GL.LINEAR,
+//     //   [GL.TEXTURE_MAG_FILTER]: GL.LINEAR,
+//     //   [GL.TEXTURE_WRAP_S]: GL.CLAMP_TO_EDGE,
+//     //   [GL.TEXTURE_WRAP_T]: GL.CLAMP_TO_EDGE
+//     // }
+//   });
+// }
+
+// /** Returns fully populated attachment object. */
+// protected normalizeColorAttachment(
+//   attachment: Texture | ColorTextureFormat
+// ): Required<ColorAttachment> {
+
+//   const COLOR_ATTACHMENT_DEFAULTS: Required<ColorAttachment> = {
+//     texture: undefined!,
+//     format: undefined!,
+//     clearValue: [0.0, 0.0, 0.0, 0.0],
+//     loadOp: 'clear',
+//     storeOp: 'store'
+//   };
+
+//   if (attachment instanceof Texture) {
+//     return {...COLOR_ATTACHMENT_DEFAULTS, texture: attachment};
+//   }
+//   if (typeof attachment === 'string') {
+//     return {...COLOR_ATTACHMENT_DEFAULTS, format: attachment};
+//   }
+//   return {...COLOR_ATTACHMENT_DEFAULTS, ...attachment};
+// }
+
+// /** Wraps texture inside fully populated attachment object. */
+// protected normalizeDepthStencilAttachment(
+//   attachment: DepthStencilAttachment | Texture | DepthStencilTextureFormat
+// ): Required<DepthStencilAttachment> {
+//   const DEPTH_STENCIL_ATTACHMENT_DEFAULTS: Required<DepthStencilAttachment> = {
+//     texture: undefined!,
+//     format: undefined!,
+
+//     depthClearValue: 1.0,
+//     depthLoadOp: 'clear',
+//     depthStoreOp: 'store',
+//     depthReadOnly: false,
+
+//     stencilClearValue: 0,
+//     stencilLoadOp: 'clear',
+//     stencilStoreOp: 'store',
+//     stencilReadOnly: false
+//   };
+
+//   if (typeof attachment === 'string') {
+//     return {...DEPTH_STENCIL_ATTACHMENT_DEFAULTS, format: attachment};
+//   }
+//   // @ts-expect-error attachment instanceof Texture doesn't cover Renderbuffer
+//   if (attachment.handle || attachment instanceof Texture) {
+//     return {...DEPTH_STENCIL_ATTACHMENT_DEFAULTS, texture: attachment as Texture};
+//   }
+//   return {...DEPTH_STENCIL_ATTACHMENT_DEFAULTS, ...attachment};
+// }

package/src/adapter/resources/query-set.ts

@@ -0,0 +1,41 @@
+// luma.gl
+// SPDX-License-Identifier: MIT
+// Copyright (c) vis.gl contributors
+
+import type {Device} from '../device';
+import {Resource, ResourceProps} from './resource';
+
+/**
+ * Properties for creating a QuerySet
+ * - 'timestamp' - query the GPU timestamp counter at the start and end of render passes
+ *   timestamp queries are available if the 'timestamp-query' feature is present.
+ * - 'occlusion' - query the number of fragment samples that pass all per-fragment tests for a set of drawing commands
+ *   including scissor, sample mask, alpha to coverage, stencil, and depth tests
+ */
+export type QuerySetProps = ResourceProps & {
+  /**
+   * The type of query set
+   * occlusion - query the number of fragment samples that pass all the per-fragment tests for a set of drawing commands, including scissor, sample mask, alpha to coverage, stencil, and depth tests
+   * timestamp - query the GPU timestamp counter at the start and end of render passes
+   */
+  type: 'occlusion' | 'timestamp';
+  /** The number of queries managed by the query set */
+  count: number;
+};
+
+/** Immutable QuerySet object */
+export abstract class QuerySet extends Resource<QuerySetProps> {
+  static override defaultProps: Required<QuerySetProps> = {
+    ...Resource.defaultProps,
+    type: undefined,
+    count: undefined
+  };
+
+  get [Symbol.toStringTag](): string {
+    return 'QuerySet';
+  }
+
+  constructor(device: Device, props: QuerySetProps) {
+    super(device, props, QuerySet.defaultProps);
+  }
+}

package/src/adapter/resources/render-pass.ts

@@ -1,13 +1,14 @@
-// luma.gl, MIT license
-import type {Device} from '../device'
-import type { RenderPassParameters } from '../types/parameters';
+// luma.gl
+// SPDX-License-Identifier: MIT
+// Copyright (c) vis.gl contributors
+
+import type {Device} from '../device';
+import type {RenderPassParameters} from '../types/parameters';
 // import {Binding} from '../types/shader-layout';
 import {Resource, ResourceProps} from './resource';
-// import {Buffer} from './buffer';
-// import {RenderPipeline} from './render-pipeline';
-// import {CommandEncoder} from './command-encoder';
 import {Framebuffer} from './framebuffer';
 import {NumberArray} from '../..';
+import {QuerySet} from './query-set';
 
 /**
  * Properties for a RenderPass instance is a required parameter to all draw calls.
@@ -28,19 +29,27 @@ export type RenderPassProps = ResourceProps & {
   /** Indicates that the stencil component is read only. */
   stencilReadOnly?: boolean;
   /** Whether to disable / discard the output of the rasterizer */
-  discard?: boolean; 
+  discard?: boolean;
+
+  /** QuerySet to write begin/end timestamps to */
+  occlusionQuerySet?: QuerySet;
+  /** QuerySet to write begin/end timestamps to */
+  timestampQuerySet?: QuerySet;
+  /** QuerySet index to write begin timestamp to. No timestamp is written if not provided. */
+  beginTimestampIndex?: number;
+  /** QuerySet index to write end timestamp to. No timestamp is written if not provided. */
+  endTimestampIndex?: number;
 };
 
 /**
  * A RenderPass instance is a required parameter to all draw calls.
- * 
- * It holds a combination of 
+ *
+ * It holds a combination of
  * - render targets (specified via a framebuffer)
  * - clear colors, read/write, discard information for the framebuffer attachments
  * - a couple of mutable parameters ()
  */
 export abstract class RenderPass extends Resource<RenderPassProps> {
-
   /** Default properties for RenderPass */
   static override defaultProps: Required<RenderPassProps> = {
     ...Resource.defaultProps,
@@ -51,7 +60,12 @@ export abstract class RenderPass extends Resource<RenderPassProps> {
     clearStencil: 0,
     depthReadOnly: false,
     stencilReadOnly: false,
-    discard: false
+    discard: false,
+
+    occlusionQuerySet: undefined,
+    timestampQuerySet: undefined,
+    beginTimestampIndex: undefined,
+    endTimestampIndex: undefined
   };
 
   override get [Symbol.toStringTag](): string {
@@ -65,53 +79,33 @@ export abstract class RenderPass extends Resource<RenderPassProps> {
   /** Call when rendering is done in this pass. */
   abstract end(): void;
 
-  /** 
-   * A small set of parameters can be changed between every draw call 
-   * (viewport, scissorRect, blendColor, stencilReference) 
-   */
+  /** A few parameters can be changed at any time (viewport, scissorRect, blendColor, stencilReference) */
   abstract setParameters(parameters: RenderPassParameters): void;
 
-  abstract pushDebugGroup(groupLabel: string): void;
-  abstract popDebugGroup(): void;
-  abstract insertDebugMarker(markerLabel: string): void;
-
-  // writeTimestamp(querySet: GPUQuerySet, queryIndex: number): void;
-
-  // beginOcclusionQuery(queryIndex: number): void;
-  // endOcclusionQuery(): void;
-
   // executeBundles(bundles: Iterable<GPURenderBundle>): void;
 
-  // In WebGPU the following methods are on the renderpass.
-  // luma.gl keeps them on the pipeline for now
+  /** Being an occlusion query. Value will be stored in the occlusionQuerySet at the index. Occlusion queries cannot be nested. */
+  abstract beginOcclusionQuery(queryIndex: number): void;
+  /** End an occlusion query. Stores result in the index specified in beginOcclusionQuery. */
+  abstract endOcclusionQuery(): void;
 
-  /*
-  setPipeline(pipeline: RenderPipeline): void {}
-
-  setIndexBuffer(
-    buffer: Buffer,
-    indexFormat: 'uint16' | 'uint32',
-    offset?: number,
-    size?: number
-  ): void {}
-
-  abstract setVertexBuffer(slot: number, buffer: Buffer, offset: number): void;
-
-  abstract setBindings(bindings: Record<string, Binding>): void;
-
-  abstract setParameters(parameters: RenderPassParameters);
-
-  draw(options: {
-    vertexCount?: number; // Either vertexCount or indexCount must be provided
-    indexCount?: number;  // Activates indexed drawing (call setIndexBuffer())
-    instanceCount?: number; //
-    firstVertex?: number;
-    firstIndex?: number; // requires device.features.has('indirect-first-instance')?
-    firstInstance?: number;
-    baseVertex?: number;
-  }): void {}
+  /** Begins a labeled debug group containing subsequent commands */
+  abstract pushDebugGroup(groupLabel: string): void;
+  /** Ends the labeled debug group most recently started by pushDebugGroup() */
+  abstract popDebugGroup(): void;
+  /** Marks a point in a stream of commands with a label */
+  abstract insertDebugMarker(markerLabel: string): void;
 
-  drawIndirect(indirectBuffer: GPUBuffer, indirectOffset: number): void;
-  drawIndexedIndirect(indirectBuffer: GPUBuffer, indirectOffset: number): void;
-  */
+  // In WebGPU the following methods are on the renderpass instead of the renderpipeline
+  // luma.gl keeps them on the pipeline for now.
+  // TODO - Can we align WebGL implementation with WebGPU API?
+
+  // abstract setPipeline(pipeline: RenderPipeline): void {}
+  // abstract setIndexBuffer()
+  // abstract setVertexBuffer(slot: number, buffer: Buffer, offset: number): void;
+  // abstract setBindings(bindings: Record<string, Binding>): void;
+  // abstract setParameters(parameters: RenderPassParameters);
+  // abstract draw(options: {
+  // abstract drawIndirect(indirectBuffer: GPUBuffer, indirectOffset: number): void;
+  // abstract drawIndexedIndirect(indirectBuffer: GPUBuffer, indirectOffset: number): void;
 }

package/src/adapter/resources/render-pipeline.ts

@@ -1,4 +1,7 @@
-// luma.gl, MIT license
+// luma.gl
+// SPDX-License-Identifier: MIT
+// Copyright (c) vis.gl contributors
+
 import type {Device} from '../device';
 import type {UniformValue} from '../types/types';
 import type {PrimitiveTopology, RenderPipelineParameters} from '../types/parameters';
@@ -85,13 +88,17 @@ export abstract class RenderPipeline extends Resource<RenderPipelineProps> {
     return 'RenderPipeline';
   }
 
-  hash: string = '';
   abstract readonly vs: Shader;
   abstract readonly fs: Shader | null;
+
   /** The merged layout */
   shaderLayout: ShaderLayout;
   /** Buffer map describing buffer interleaving etc */
   readonly bufferLayout: BufferLayout[];
+  /** The linking status of the pipeline. 'pending' if linking is asynchronous, and on production */
+  linkStatus: 'pending' | 'success' | 'error' = 'pending';
+  /** The hash of the pipeline */
+  hash: string = '';
 
   constructor(device: Device, props: RenderPipelineProps) {
     super(device, props, RenderPipeline.defaultProps);
@@ -101,12 +108,6 @@ export abstract class RenderPipeline extends Resource<RenderPipelineProps> {
 
   /** Set bindings (stored on pipeline and set before each call) */
   abstract setBindings(bindings: Record<string, Binding>): void;
-  /** Uniforms
-   * @deprecated Only supported on WebGL devices.
-   * @note textures, samplers and uniform buffers should be set via `setBindings()`, these are not considered uniforms.
-   * @note In WebGL uniforms have a performance penalty, they are reset before each call to enable pipeline sharing.
-   */
-  abstract setUniforms(bindings: Record<string, UniformValue>): void;
 
   /** Draw call */
   abstract draw(options: {
@@ -127,7 +128,19 @@ export abstract class RenderPipeline extends Resource<RenderPipelineProps> {
     /** First instance to draw from */
     firstInstance?: number;
     baseVertex?: number;
-    /** Transform feedback. WebGL 2 only. */
+    /** Transform feedback. WebGL only. */
     transformFeedback?: TransformFeedback;
   }): void;
+
+  // DEPRECATED METHODS
+
+  /**
+   * Uniforms
+   * @deprecated Use uniforms buffers
+   * @note textures, samplers and uniform buffers should be set via `setBindings()`, these are not considered uniforms.
+   * @note In WebGL uniforms have a performance penalty, they are reset before each call to enable pipeline sharing.
+   */
+  setUniformsWebGL(uniforms: Record<string, UniformValue>): void {
+    throw new Error('Use uniform blocks');
+  }
 }