@lukekaalim/act-three 8.1.0 → 8.2.0

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @lukekaalim/act-three
 
+## 8.2.0
+
+### Minor Changes
+
+- 41b49aa: Upgraded NodeBuilder to pass element during destruction, fixed Sprites not being assigned materials in act-three, and act-three objects will set ref to null on destruction
+
+### Patch Changes
+
+- Updated dependencies [41b49aa]
+  - @lukekaalim/act-backstage@4.0.0
+  - @lukekaalim/act-web@6.2.1
+
 ## 8.1.0
 
 ### Minor Changes

package/builder.ts

@@ -1,7 +1,7 @@
 import { NodeBuilder } from "@lukekaalim/act-backstage";
 import { Object3D } from "three";
 import { registry } from "./elements";
-import { Component, h, specialNodeTypes } from "@lukekaalim/act";
+import { Component, h, specialNodeTypes, WriteOnlyRef } from "@lukekaalim/act";
 
 export const ThreeJSRoot: Component = ({ children }) => h(specialNodeTypes.render, { type: 'threejs' }, children);
 
@@ -22,8 +22,11 @@ export const createThreeJSBuilder = (rootObject: Object3D | null = null): NodeBu
   link(el, parent) {
     parent && parent.add(el)
   },
-  destroy(el) {
-    if (el.parent)
-      el.removeFromParent()
+  destroy(obj, el) {
+    if (obj.parent)
+      obj.removeFromParent()
+    if (el.props.ref) {
+      (el.props.ref as WriteOnlyRef<null>).set(null);
+    }
   },
 })

package/elements.ts

@@ -31,7 +31,8 @@ export type PropsFromClass<T extends three.Object3D> = {
   //onAdded?: (self: T) => void,
   //onRemoved?: (self: T) => void,
 
-  ref?: T extends three.Points<any, any, any> ? WriteOnlyRef<three.Points<any, any, any>> : WriteOnlyRef<T>,
+  // Crude fix for Points, which has a fucked generic
+  ref?: T extends three.Points<any, any, any> ? WriteOnlyRef<null | three.Points<any, any, any>> : WriteOnlyRef<T | null>,
 }
   & (T extends three.Mesh | three.Points | three.Line ? DrawableProps : {})
   & (T extends three.Sprite ? SpriteProps : {})

package/package.json

@@ -2,12 +2,12 @@
   "name": "@lukekaalim/act-three",
   "main": "index.ts",
   "type": "module",
-  "version": "8.1.0",
+  "version": "8.2.0",
   "dependencies": {
     "@lukekaalim/act": "^5.0.0",
-    "@lukekaalim/act-backstage": "^3.2.1",
+    "@lukekaalim/act-backstage": "^4.0.0",
     "@lukekaalim/act-recon": "^4.0.1",
-    "@lukekaalim/act-web": "^6.0.0",
+    "@lukekaalim/act-web": "^6.2.1",
     "@types/three": ">= 0.185.0"
   },
   "peerDependencies": {

package/props.ts

@@ -46,6 +46,12 @@ export const setProps = (object: three.Object3D, props: PropsFromClass<three.Obj
     if (meshProps.material)
       object.material = meshProps.material;
   }
+  if (object instanceof three.Sprite) {
+    const spriteProps = props as PropsFromClass<three.Sprite>;
+    if (spriteProps.material)
+      // A little bit of cheating here ;)
+      object.material = spriteProps.material as three.SpriteMaterial;
+  }
 
   if (object instanceof three.PerspectiveCamera) {
     const perspectiveCameraProps = props as PropsFromClass<three.PerspectiveCamera>;