@lukekaalim/act-three 8.0.1 → 8.0.3

package/CHANGELOG.md

@@ -1,5 +1,17 @@
 # @lukekaalim/act-three
 
+## 8.0.3
+
+### Patch Changes
+
+- 0378003: Fix issue with act-three always settings geometry and materials to props, even if left to undefined (resulting in geo/mats being set to undefined even if they exist)
+
+## 8.0.2
+
+### Patch Changes
+
+- 36412c6: Fix issue with threejs builder trying to build non-primirive elements
+
 ## 8.0.1
 
 ### Patch Changes

package/builder.ts

@@ -9,7 +9,9 @@ export const createThreeJSBuilder = (rootObject: Object3D | null = null): NodeBu
   roots: new Set(['threejs']),
 
   create(element) {
-    return registry.create(element);
+    if (typeof element.type === 'string')
+      return registry.create(element);
+    return null;
   },
   update(el, next, prev) {
     registry.update(el, next, prev);

package/elements.ts

@@ -156,7 +156,6 @@ registry
       setProps(object, props as PropsFromClass<three.Object3D>);
       return object;
     }
-    console.warn(`I WONT MAKE ${type}`)
     return null;
   })
   .addGlobalUpdateHandler((type, object, next, prev) => {

package/package.json

@@ -2,7 +2,7 @@
   "name": "@lukekaalim/act-three",
   "main": "index.ts",
   "type": "module",
-  "version": "8.0.1",
+  "version": "8.0.3",
   "dependencies": {
     "@lukekaalim/act": "^4.3.0",
     "@lukekaalim/act-backstage": "^3.2.0",

package/props.ts

@@ -37,12 +37,14 @@ export const setProps = (object: three.Object3D, props: PropsFromClass<three.Obj
     object.userData = props.userData;
 
   if (props.ref)
-    props.ref.current = object;
+    (props.ref as any).current = object;
   
   if (object instanceof three.Mesh || object instanceof three.Points || object instanceof three.Line) {
     const meshProps = props as PropsFromClass<three.Mesh | three.Points | three.Line>;
-    object.geometry = meshProps.geometry;
-    object.material = meshProps.material;
+    if (meshProps.geometry)
+      object.geometry = meshProps.geometry;
+    if (meshProps.material)
+      object.material = meshProps.material;
   }
 
   if (object instanceof three.PerspectiveCamera) {