@lukekaalim/act-recon 3.0.0-alpha.0 → 3.0.0-alpha.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @lukekaalim/act-recon
 
+## 3.0.0-alpha.1
+
+### Patch Changes
+
+- fdf1557: Fixed issue with multiple changes (where changes after first were children of first) being ignored due to "MustVisit" being misinput each time
+
 ## 3.0.0-alpha.0
 
 ### Major Changes

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@lukekaalim/act-recon",
   "type": "module",
-  "version": "3.0.0-alpha.0",
+  "version": "3.0.0-alpha.1",
   "main": "mod.ts",
   "dependencies": {
     "@lukekaalim/act": "^3.2.0"

package/thread.ts

@@ -185,8 +185,9 @@ const queueWorkThreadTarget = (thread: WorkThread, ref: CommitRef, tree: CommitT
   // lead to this commit. If so, make sure ancestor commit
   // is on the MustVisit so they should make their way down
   // eventually
-  for (const id of [...ref.path].reverse().slice(1)) {
-    thread.mustVisit.set(ref.id, ref);
+  for (let i = ref.path.length - 1; i >= 0; i--) {
+    const id = ref.path[i];
+    thread.mustVisit.add(id);
 
     for (const update of thread.pendingUpdates) {
       // Found an ancestor pending update - it should
@@ -221,7 +222,7 @@ export type WorkThread = {
   reasons: WorkReason[],
   
   mustRender: Map<CommitID, CommitRef>,
-  mustVisit: Map<CommitID, CommitRef>,
+  mustVisit: Set<CommitID>,
   
   pendingUpdates: Update[],
   pendingEffects: EffectTask[],
@@ -242,7 +243,7 @@ export const cloneWorkThread = (thread: WorkThread): WorkThread => {
     pendingUpdates: [...thread.pendingUpdates],
     errorNotifications: new Map(thread.errorNotifications),
 
-    mustVisit: new Map(thread.mustVisit),
+    mustVisit: new Set(thread.mustVisit),
     mustRender: new Map(thread.mustRender),
 
     visited: new Map(thread.visited),
@@ -259,7 +260,7 @@ export const WorkThread = {
       pendingUpdates: [],
       errorNotifications: new Map(),
 
-      mustVisit: new Map(),
+      mustVisit: new Set(),
       mustRender: new Map(),
 
       visited: new Map(),