@luceosports/play-rendering 2.6.3 → 2.8.0

package/dist/types/helpers/animation.d.ts

@@ -9,9 +9,7 @@ export declare const getEffectiveTimeline: (anim: HasKeyTimes, timeline: Timelin
 export declare const keyTimesToChunks: (keyTimes: number[]) => [number, number][];
 export declare const deriveLineChunksWithFallback: (params: {
     timeline: TimelineKey;
-    playerAnimation: HasKeyTimes;
     lineAnimation: HasKeyTimes;
     lineType: LineType;
     lineParts: LinePart[];
-    legacySupport?: boolean;
 }) => [number, number][];

package/dist/types/models/PlayerModel.d.ts

@@ -1,4 +1,4 @@
-import { Color, CourtPoint, Line, Player, PlayerAnimation, Position, AnimationMode } from "../../play-rendering";
+import { Color, CourtPoint, Line, Player, Position, AnimationMode } from "../../play-rendering";
 
 export class PlayerModel {
     constructor(data: Player);
@@ -9,13 +9,10 @@ export class PlayerModel {
     get isDefender(): boolean;
     get possession(): boolean;
     set possession(data: boolean);
+    get startBallsCount();
+    set startBallsCount(data: number);
     get position(): Position;
     get location(): CourtPoint;
     get color(): Color;
-    get animations(): PlayerAnimation[];
-    animationsByEndTime(mode: AnimationMode): number[];
-    lastAnimEndTime(mode: AnimationMode): number;
-    get lastAnimation(): PlayerAnimation;
-    get lastAnimationLastLinePartControlPoint(): CourtPoint;
     setPossession(prevPassLines: Line[]): void;
 }

package/dist/types/types/index.d.ts

@@ -59,27 +59,24 @@ export interface Court {
     type: CourtType;
     courtRect: CourtRect;
 }
-export type PlayerAnimationType = 'POSITION';
-export interface Animation {
-    id: string;
-    keyTimes: number[];
-    keyTimesSeq?: number[];
-}
-export interface PlayerAnimation extends Animation {
-    type: PlayerAnimationType;
-    lineParts: LinePart[];
-}
 export interface Player {
     id: string;
     possession: boolean;
+    startBallsCount?: number;
     color: Color;
     position: Position;
     location: CourtPoint;
     textOverride?: string;
-    animations: PlayerAnimation[];
+}
+export interface Animation {
+    id: string;
+    keyTimes: number[];
 }
 export type LineAnimationType = 'LINESTROKE';
-export interface LineAnimation extends Animation {
+export interface LineAnimation {
+    id: string;
+    keyTimes: number[];
+    keyTimesSeq?: number[];
     type: LineAnimationType;
     strokeStartValues: [number, number, number];
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@luceosports/play-rendering",
-  "version": "2.6.3",
+  "version": "2.8.0",
   "main": "dist/play-rendering.js",
   "types": "dist/play-rendering.d.ts",
   "scripts": {

package/src/helpers/animation.ts

@@ -66,13 +66,11 @@ const splitChunkByPartDurations = (params: {
 
 export const deriveLineChunksWithFallback = (params: {
   timeline: TimelineKey;
-  playerAnimation: HasKeyTimes;
   lineAnimation: HasKeyTimes;
   lineType: LineType;
   lineParts: LinePart[];
-  legacySupport?: boolean;
 }): [number, number][] => {
-  const { timeline, playerAnimation, lineAnimation, lineType, lineParts, legacySupport = true } = params;
+  const { timeline, lineAnimation, lineType, lineParts } = params;
   const linePartsCount = lineParts.length ?? 0;
 
   const chunks = keyTimesToChunks(getEffectiveTimeline(lineAnimation, timeline));
@@ -81,32 +79,15 @@ export const deriveLineChunksWithFallback = (params: {
   // If there are no chunks (bad/partial data), just return as-is.
   if (!chunks.length) return chunks;
 
-  // Prefer geometry-based splitting over player animation fallback.
+  // Geometry-based splitting fallback.
   // Typical legacy case: multi-part line stored as a single [start,end] chunk.
   if (chunks.length === 1 && lineParts?.length) {
     const [[start, end]] = chunks;
     const split = splitChunkByPartDurations({ start, end, lineParts, lineType });
-    console.log('geometry based', { chunks, split, linePartsCount });
     if (split.length === linePartsCount) return split;
   }
 
-  console.warn('PLAYER FALLBACK ATTEMPT!!!', { chunks, linePartsCount });
-
-  // If legacy support is disabled, do not attempt reconstruction from player timeline.
-  if (!legacySupport) return chunks;
-
-  // Backward compatibility:
-  // legacy multi-part lines stored only [start,end] in the line animation timeline,
-  // so reconstruct per-part timings from the player animation timeline slice.
-  const [[start, end]] = chunks;
-  const playerTimeline = getEffectiveTimeline(playerAnimation, timeline);
-
-  const startIndex = playerTimeline.indexOf(start);
-  const endIndex = playerTimeline.indexOf(end);
-  if (startIndex < 0 || endIndex < 0) return chunks;
-
-  const sliced = playerTimeline.slice(startIndex, endIndex + 1);
-  return keyTimesToChunks(sliced);
+  return chunks;
 };
 
 export const getLineAnimationChunks = (params: {
@@ -121,22 +102,12 @@ export const getLineAnimationChunks = (params: {
   const lineAnimation = line.animations?.[0] as unknown as HasKeyTimes | undefined;
   if (!lineAnimation) return [];
 
-  const linePlayer = players.find(p => p.position === line.playerPositionOrigin);
-  const playerAnimation = (linePlayer?.animations?.[0] as unknown as HasKeyTimes | undefined) ?? undefined;
-
-  // Fast path: no player timeline available, just chunk the line timeline as-is.
-  if (!playerAnimation) {
-    return keyTimesToChunks(getEffectiveTimeline(lineAnimation, timeline));
-  }
-
   // Full path: handle chunking + legacy reconstruction.
   return deriveLineChunksWithFallback({
     timeline,
-    playerAnimation,
     lineAnimation,
     lineType: line.type,
-    lineParts: line.lineParts,
-    legacySupport: false
+    lineParts: line.lineParts
   });
 };
 

package/src/models/PlayerModel.ts

@@ -1,6 +1,5 @@
-import _ from 'lodash';
 import Model from './Base/InternalFrameModel';
-import { AnimationMode, Line, Player as PlayerData, PlayerAnimation } from '../types';
+import { Line, Player as PlayerData } from '../types';
 
 export default class PlayerModel extends Model<PlayerData, PlayerData> {
   get id() {
@@ -31,6 +30,19 @@ export default class PlayerModel extends Model<PlayerData, PlayerData> {
     this._setAttr('possession', data);
   }
 
+  get startBallsCount() {
+    const raw = this._getAttr('startBallsCount');
+    if (typeof raw === 'number') return raw;
+
+    // Backward-compatible fallback:
+    // legacy model encoded "starts with 1 ball" as possession=true.
+    return this.possession ? 1 : 0;
+  }
+
+  set startBallsCount(data) {
+    this._setAttr('startBallsCount', data);
+  }
+
   get position() {
     return this._getAttr('position');
   }
@@ -47,35 +59,13 @@ export default class PlayerModel extends Model<PlayerData, PlayerData> {
     return this._getAttr('color');
   }
 
-  get animations() {
-    return this._getAttr('animations');
-  }
-
-  private getAnimationKeyTimes(animation: PlayerAnimation, mode: AnimationMode) {
-    return mode === AnimationMode.SEQUENTIAL ? animation.keyTimesSeq || animation.keyTimes : animation.keyTimes;
-  }
-
-  animationsByEndTime(mode: AnimationMode) {
-    return this._getAttr('animations').map(a => _.last(this.getAnimationKeyTimes(a, mode)));
-  }
-
-  lastAnimEndTime(mode: AnimationMode) {
-    return _.max(this.animationsByEndTime(mode));
-  }
-
-  get lastAnimation() {
-    return [...this.animations].pop();
-  }
+  setPossession(prevPassLines: Line[]) {
+    // Support multiple balls: start from startBallsCount, then apply transfers.
+    let ballsCount = this.startBallsCount;
 
-  get lastAnimationLastLinePartControlPoint() {
-    return [...[...this.lastAnimation!.lineParts].pop()!.controlPoints].pop();
-  }
+    ballsCount += prevPassLines.filter(l => l.playerPositionTerminus === this.position).length;
+    ballsCount -= prevPassLines.filter(l => l.playerPositionOrigin === this.position).length;
 
-  setPossession(prevPassLines: Line[]) {
-    if (!prevPassLines.length) return;
-    let possessionCount = this.possession ? 1 : 0;
-    possessionCount += prevPassLines.filter(l => l.playerPositionTerminus === this.position).length;
-    possessionCount -= prevPassLines.filter(l => l.playerPositionOrigin === this.position).length;
-    this.possession = possessionCount > 0;
+    this.possession = ballsCount > 0;
   }
 }

package/src/types/index.ts

@@ -133,32 +133,31 @@ export interface Court {
   courtRect: CourtRect;
 }
 
-export type PlayerAnimationType = 'POSITION';
-
-export interface Animation {
-  id: string;
-  keyTimes: number[];
-  keyTimesSeq?: number[];
-}
-
-export interface PlayerAnimation extends Animation {
-  type: PlayerAnimationType;
-  lineParts: LinePart[];
-}
-
 export interface Player {
   id: string;
   possession: boolean;
+  /**
+   * How many balls the player starts with before applying PASS/HANDOFF/SHOT transfers.
+   * If omitted, legacy data falls back to `possession ? 1 : 0`.
+   */
+  startBallsCount?: number;
   color: Color;
   position: Position;
   location: CourtPoint;
   textOverride?: string;
-  animations: PlayerAnimation[];
+}
+
+export interface Animation {
+  id: string;
+  keyTimes: number[];
 }
 
 export type LineAnimationType = 'LINESTROKE';
 
-export interface LineAnimation extends Animation {
+export interface LineAnimation {
+  id: string;
+  keyTimes: number[];
+  keyTimesSeq?: number[];
   type: LineAnimationType;
   strokeStartValues: [number, number, number];
 }