@luceosports/play-rendering 2.6.1 → 2.6.2

package/dist/types/helpers/animation.d.ts

@@ -1,4 +1,4 @@
-import { AnimationMode } from '../types';
+import { AnimationMode, LinePart, LineType } from '../types';
 export type TimelineKey = 'keyTimes' | 'keyTimesSeq';
 export type HasKeyTimes = {
     keyTimes: number[];
@@ -7,10 +7,11 @@ export type HasKeyTimes = {
 export declare const getTimelineKey: (mode: AnimationMode) => TimelineKey;
 export declare const getEffectiveTimeline: (anim: HasKeyTimes, timeline: TimelineKey) => number[];
 export declare const keyTimesToChunks: (keyTimes: number[]) => [number, number][];
-export declare const deriveLineChunksWithPlayerFallback: (params: {
+export declare const deriveLineChunksWithFallback: (params: {
     timeline: TimelineKey;
     playerAnimation: HasKeyTimes;
     lineAnimation: HasKeyTimes;
-    linePartsCount: number;
+    lineType: LineType;
+    lineParts: LinePart[];
     legacySupport?: boolean;
 }) => [number, number][];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@luceosports/play-rendering",
-  "version": "2.6.1",
+  "version": "2.6.2",
   "main": "dist/play-rendering.js",
   "types": "dist/play-rendering.d.ts",
   "scripts": {

package/src/constants.ts

@@ -1,63 +1,65 @@
-export const SPORT_TYPE_BASKETBALL = 'BASKETBALL';
-export const SPORT_TYPE_VOLLEYBALL = 'VOLLEYBALL';
-export const SPORT_TYPE_BEACH_VOLLEYBALL = 'BEACH_VOLLEYBALL';
-export const SPORT_TYPE_FOOTBALL = 'FOOTBALL';
-export const SPORT_TYPE_LACROSSE = 'LACROSSE';
-export const SPORT_TYPE_LACROSSE_BOX = 'LACROSSE_BOX';
-export const SPORT_TYPE_SOCCER = 'SOCCER';
-export const SPORT_TYPE_HOCKEY = 'HOCKEY';
-export const SPORT_TYPE_BASEBALL = 'BASEBALL';
-export const SPORT_TYPE_SOFTBALL = 'SOFTBALL';
-
-export const COURT_TYPE_BIG3 = 'BIG3';
-export const COURT_TYPE_FIBA = 'FIBA';
-export const COURT_TYPE_NBA = 'NBA';
-export const COURT_TYPE_NCAAM = 'NCAAM';
-export const COURT_TYPE_NCAAW = 'NCAAW';
-export const COURT_TYPE_US_HIGH_SCHOOL = 'US_HIGH_SCHOOL';
-export const COURT_TYPE_US_JUNIOR_HIGH = 'US_JUNIOR_HIGH';
-export const COURT_TYPE_WNBA = 'WNBA';
-
-export const COURT_TYPE_FOOTBALL_COLLEGE = 'FOOTBALL_COLLEGE';
-export const COURT_TYPE_FOOTBALL_NFL = 'FOOTBALL_NFL';
-export const COURT_TYPE_FOOTBALL_HIGH_SCHOOL = 'FOOTBALL_HIGH_SCHOOL';
-export const COURT_TYPE_FOOTBALL_HIGH_SCHOOL_LEGACY = 'FOOTBALL';
-
-export const COURT_TYPE_VOLLEYBALL_INDOOR = 'VOLLEYBALL_INDOOR';
-
-export const COURT_TYPE_BEACH_VOLLEYBALL_NCAA = 'BEACH_VOLLEYBALL_NCAA';
-export const COURT_TYPE_BEACH_VOLLEYBALL_RECREATIONAL = 'BEACH_VOLLEYBALL_RECREATIONAL';
-
-export const COURT_TYPE_LACROSSE_US_M = 'LACROSSE_US_M';
-export const COURT_TYPE_LACROSSE_US_W = 'LACROSSE_US_W';
-
-export const COURT_TYPE_LACROSSE_BOX_US = 'LACROSSE_BOX_US';
-export const COURT_TYPE_LACROSSE_BOX_CLA = 'LACROSSE_BOX_CLA';
-
-export const COURT_TYPE_SOCCER_FIFA = 'SOCCER_FIFA';
-export const COURT_TYPE_SOCCER_NCAA = 'SOCCER_NCAA';
-export const COURT_TYPE_SOCCER_NFHS = 'SOCCER_NFHS';
-export const COURT_TYPE_SOCCER_U10 = 'SOCCER_U10';
-export const COURT_TYPE_SOCCER_U12 = 'SOCCER_U12';
-export const COURT_TYPE_SOCCER_U19 = 'SOCCER_U19';
-
-export const COURT_TYPE_HOCKEY_NHL = 'HOCKEY_NHL';
-export const COURT_TYPE_HOCKEY_INTERNATIONAL = 'HOCKEY_INTERNATIONAL';
-
-export const COURT_TYPE_BASEBALL_HIGH_SCHOOL = 'BASEBALL_HIGH_SCHOOL';
-
-export const COURT_TYPE_SOFTBALL_FP_COLLEGE = 'SOFTBALL_FP_COLLEGE';
-export const COURT_TYPE_SOFTBALL_FP_HIGH_SCHOOL = 'SOFTBALL_FP_HS';
-
-export const SHAPE_TYPE_CIRCLE = 'CIRCLE';
-export const SHAPE_TYPE_SQUARE = 'SQUARE';
-export const SHAPE_TYPE_TRIANGLE = 'TRIANGLE';
-export const SHAPE_TYPE_FOV = 'FOV';
-export const SHAPE_TYPE_XMARK = 'XMARK';
-export const SHAPE_TYPE_STRAIGHT = 'STRAIGHT';
-export const SHAPE_TYPE_CONE = 'CONE';
-export const SHAPE_TYPE_LINE_CUT = 'LINE.CUT';
-export const SHAPE_TYPE_LINE_SCREEN = 'LINE.SCREEN';
-export const SHAPE_TYPE_LINE_DRIBBLE = 'LINE.DRIBBLE';
-export const SHAPE_TYPE_LINE_PASS = 'LINE.PASS';
-export const SHAPE_TYPE_LINE_HANDOFF = 'LINE.HANDOFF';
+export const BALL_TRANSFER_LINE_DURATION_DEFAULT = 0.03;
+
+export const SPORT_TYPE_BASKETBALL = 'BASKETBALL';
+export const SPORT_TYPE_VOLLEYBALL = 'VOLLEYBALL';
+export const SPORT_TYPE_BEACH_VOLLEYBALL = 'BEACH_VOLLEYBALL';
+export const SPORT_TYPE_FOOTBALL = 'FOOTBALL';
+export const SPORT_TYPE_LACROSSE = 'LACROSSE';
+export const SPORT_TYPE_LACROSSE_BOX = 'LACROSSE_BOX';
+export const SPORT_TYPE_SOCCER = 'SOCCER';
+export const SPORT_TYPE_HOCKEY = 'HOCKEY';
+export const SPORT_TYPE_BASEBALL = 'BASEBALL';
+export const SPORT_TYPE_SOFTBALL = 'SOFTBALL';
+
+export const COURT_TYPE_BIG3 = 'BIG3';
+export const COURT_TYPE_FIBA = 'FIBA';
+export const COURT_TYPE_NBA = 'NBA';
+export const COURT_TYPE_NCAAM = 'NCAAM';
+export const COURT_TYPE_NCAAW = 'NCAAW';
+export const COURT_TYPE_US_HIGH_SCHOOL = 'US_HIGH_SCHOOL';
+export const COURT_TYPE_US_JUNIOR_HIGH = 'US_JUNIOR_HIGH';
+export const COURT_TYPE_WNBA = 'WNBA';
+
+export const COURT_TYPE_FOOTBALL_COLLEGE = 'FOOTBALL_COLLEGE';
+export const COURT_TYPE_FOOTBALL_NFL = 'FOOTBALL_NFL';
+export const COURT_TYPE_FOOTBALL_HIGH_SCHOOL = 'FOOTBALL_HIGH_SCHOOL';
+export const COURT_TYPE_FOOTBALL_HIGH_SCHOOL_LEGACY = 'FOOTBALL';
+
+export const COURT_TYPE_VOLLEYBALL_INDOOR = 'VOLLEYBALL_INDOOR';
+
+export const COURT_TYPE_BEACH_VOLLEYBALL_NCAA = 'BEACH_VOLLEYBALL_NCAA';
+export const COURT_TYPE_BEACH_VOLLEYBALL_RECREATIONAL = 'BEACH_VOLLEYBALL_RECREATIONAL';
+
+export const COURT_TYPE_LACROSSE_US_M = 'LACROSSE_US_M';
+export const COURT_TYPE_LACROSSE_US_W = 'LACROSSE_US_W';
+
+export const COURT_TYPE_LACROSSE_BOX_US = 'LACROSSE_BOX_US';
+export const COURT_TYPE_LACROSSE_BOX_CLA = 'LACROSSE_BOX_CLA';
+
+export const COURT_TYPE_SOCCER_FIFA = 'SOCCER_FIFA';
+export const COURT_TYPE_SOCCER_NCAA = 'SOCCER_NCAA';
+export const COURT_TYPE_SOCCER_NFHS = 'SOCCER_NFHS';
+export const COURT_TYPE_SOCCER_U10 = 'SOCCER_U10';
+export const COURT_TYPE_SOCCER_U12 = 'SOCCER_U12';
+export const COURT_TYPE_SOCCER_U19 = 'SOCCER_U19';
+
+export const COURT_TYPE_HOCKEY_NHL = 'HOCKEY_NHL';
+export const COURT_TYPE_HOCKEY_INTERNATIONAL = 'HOCKEY_INTERNATIONAL';
+
+export const COURT_TYPE_BASEBALL_HIGH_SCHOOL = 'BASEBALL_HIGH_SCHOOL';
+
+export const COURT_TYPE_SOFTBALL_FP_COLLEGE = 'SOFTBALL_FP_COLLEGE';
+export const COURT_TYPE_SOFTBALL_FP_HIGH_SCHOOL = 'SOFTBALL_FP_HS';
+
+export const SHAPE_TYPE_CIRCLE = 'CIRCLE';
+export const SHAPE_TYPE_SQUARE = 'SQUARE';
+export const SHAPE_TYPE_TRIANGLE = 'TRIANGLE';
+export const SHAPE_TYPE_FOV = 'FOV';
+export const SHAPE_TYPE_XMARK = 'XMARK';
+export const SHAPE_TYPE_STRAIGHT = 'STRAIGHT';
+export const SHAPE_TYPE_CONE = 'CONE';
+export const SHAPE_TYPE_LINE_CUT = 'LINE.CUT';
+export const SHAPE_TYPE_LINE_SCREEN = 'LINE.SCREEN';
+export const SHAPE_TYPE_LINE_DRIBBLE = 'LINE.DRIBBLE';
+export const SHAPE_TYPE_LINE_PASS = 'LINE.PASS';
+export const SHAPE_TYPE_LINE_HANDOFF = 'LINE.HANDOFF';

package/src/helpers/animation.ts

@@ -2,7 +2,10 @@ import NoteModel from '../models/NoteModel';
 import ShapeModel from '../models/ShapeModel';
 import _ from 'lodash';
 import { FrameDataOptions } from '../models/FrameModel';
-import { AnimationMode, Line, Player } from '../types';
+import { AnimationMode, Line, LinePart, LineType, Player } from '../types';
+import Bezier from '../math/Bezier';
+import { isBallTransferLineType } from './common';
+import { BALL_TRANSFER_LINE_DURATION_DEFAULT } from '../constants';
 
 export type TimelineKey = 'keyTimes' | 'keyTimesSeq';
 export type HasKeyTimes = { keyTimes: number[]; keyTimesSeq?: number[] };
@@ -24,14 +27,53 @@ export const keyTimesToChunks = (keyTimes: number[]): [number, number][] => {
   return chunks;
 };
 
-export const deriveLineChunksWithPlayerFallback = (params: {
+export function computeDefaultLineAnimationDuration(lineType: LineType, linePart: LinePart): number {
+  if (isBallTransferLineType(lineType)) return BALL_TRANSFER_LINE_DURATION_DEFAULT;
+  const [cp1, cp2, cp3, cp4] = linePart.controlPoints;
+  return new Bezier(cp1, cp2, cp3 ?? null, cp4 ?? null).length / 100;
+}
+
+const splitChunkByPartDurations = (params: {
+  start: number;
+  end: number;
+  lineParts: LinePart[];
+  lineType: LineType;
+}): [number, number][] => {
+  const { start, end, lineParts, lineType } = params;
+
+  const total = end - start;
+  if (!Number.isFinite(total) || total <= 0) return [[start, end]];
+
+  const durations = lineParts.map(lp => computeDefaultLineAnimationDuration(lineType, lp));
+  const sum = durations.reduce((acc, v) => acc + (Number.isFinite(v) ? v : 0), 0);
+
+  // If geometry is degenerate, fall back to equal split.
+  const weights =
+    sum > 0 ? durations.map(d => (Number.isFinite(d) ? d / sum : 0)) : lineParts.map(() => 1 / lineParts.length);
+
+  const keyTimes: number[] = [start];
+  let cursor = start;
+
+  for (let i = 0; i < weights.length; i += 1) {
+    const isLast = i === weights.length - 1;
+    const dt = isLast ? end - cursor : total * weights[i];
+    cursor += dt;
+    keyTimes.push(isLast ? end : cursor);
+  }
+
+  return keyTimesToChunks(keyTimes);
+};
+
+export const deriveLineChunksWithFallback = (params: {
   timeline: TimelineKey;
   playerAnimation: HasKeyTimes;
   lineAnimation: HasKeyTimes;
-  linePartsCount: number;
+  lineType: LineType;
+  lineParts: LinePart[];
   legacySupport?: boolean;
 }): [number, number][] => {
-  const { timeline, playerAnimation, lineAnimation, linePartsCount, legacySupport = true } = params;
+  const { timeline, playerAnimation, lineAnimation, lineType, lineParts, legacySupport = true } = params;
+  const linePartsCount = lineParts.length ?? 0;
 
   const chunks = keyTimesToChunks(getEffectiveTimeline(lineAnimation, timeline));
   if (chunks.length === linePartsCount) return chunks;
@@ -39,6 +81,17 @@ export const deriveLineChunksWithPlayerFallback = (params: {
   // If there are no chunks (bad/partial data), just return as-is.
   if (!chunks.length) return chunks;
 
+  // Prefer geometry-based splitting over player animation fallback.
+  // Typical legacy case: multi-part line stored as a single [start,end] chunk.
+  if (chunks.length === 1 && lineParts?.length) {
+    const [[start, end]] = chunks;
+    const split = splitChunkByPartDurations({ start, end, lineParts, lineType });
+    console.log('geometry based', { chunks, split, linePartsCount });
+    if (split.length === linePartsCount) return split;
+  }
+
+  console.warn('PLAYER FALLBACK ATTEMPT!!!', { chunks, linePartsCount });
+
   // If legacy support is disabled, do not attempt reconstruction from player timeline.
   if (!legacySupport) return chunks;
 
@@ -68,8 +121,6 @@ export const getLineAnimationChunks = (params: {
   const lineAnimation = line.animations?.[0] as unknown as HasKeyTimes | undefined;
   if (!lineAnimation) return [];
 
-  const linePartsCount = line.lineParts?.length ?? 0;
-
   const linePlayer = players.find(p => p.position === line.playerPositionOrigin);
   const playerAnimation = (linePlayer?.animations?.[0] as unknown as HasKeyTimes | undefined) ?? undefined;
 
@@ -79,11 +130,13 @@ export const getLineAnimationChunks = (params: {
   }
 
   // Full path: handle chunking + legacy reconstruction.
-  return deriveLineChunksWithPlayerFallback({
+  return deriveLineChunksWithFallback({
     timeline,
     playerAnimation,
     lineAnimation,
-    linePartsCount
+    lineType: line.type,
+    lineParts: line.lineParts,
+    legacySupport: false
   });
 };
 

package/src/helpers/common.ts

@@ -1,6 +1,10 @@
-import { ShapeType } from '../types';
+import { LineType, ShapeType } from '../types';
 import { ShapeModels } from '../index';
 
+export function isBallTransferLineType(type: LineType) {
+  return ['PASS', 'HANDOFF', 'SHOT'].includes(type);
+}
+
 export function animationProgress(globalProgress: number, start: number, end: number) {
   const max = end - start;
   const local = globalProgress - start;