@lucasschirm/devinp 0.1.11 → 0.1.14

package/README.md

@@ -31,14 +31,32 @@ when a script calls it: the model list comes back paged ("click to show more")
 and the JSON never reaches stdout, so `devinp` used to die with *"returned
 invalid JSON (… 0 bytes)"*. It now works harder to get the whole document:
 
-- Prices are captured through a temp file in `os.tmpdir()` — a pipe stream from
-  `devin` can be truncated mid-write, so `devinp` points `devin`'s stdout at a
-  real file first. The temp file is always removed after the run.
-- **Retries, each one louder about not being interactive.** If an attempt
-  yields no usable JSON, `devinp` runs `devin` again with the "not interactive"
-  conventions set (`PAGER=cat`, `GIT_PAGER=cat`, `TERM=dumb`, `NO_COLOR=1`,
-  `CI=1`) and, on the last try, captures over a pipe instead of a file. The
-  first successful attempt wins, so the healthy path costs one `devin` call.
+- **A pipe first, so `TMPDIR` cannot break anything.** The happy path captures
+  `devin`'s stdout over a pipe — no scratch file, no permissions, no sandbox.
+  Measured against the real CLI, the piped document is byte-identical to the
+  file capture (471 855 bytes, 46 families), so the old "pipes truncate" worry
+  that put a temp file first was misplaced; an unwritable or missing `TMPDIR`
+  used to cost two extra `devin` runs, and a missing one even reported *"`devin`
+  CLI not found in PATH"*.
+- **Retries that take the terminal away from `devin`.** If an attempt yields no
+  usable JSON, `devinp` runs `devin` again, each time stripping more of the
+  interactive terminal off it:
+
+  | # | stdout goes to | environment | controlling terminal |
+  | - | ------------ | -------------------------------------------------------- | --------------------- |
+  | 1 | pipe | yours, untouched | yes — the healthy path, one `devin` call |
+  | 2 | pipe | `PAGER=cat`, `GIT_PAGER=cat`, `TERM=dumb`, `NO_COLOR=1`, `CI=1` | **none** |
+  | 3 | scratch file | same | **none** |
+
+  Spawned in its own session, `devin` cannot open `/dev/tty`: a pager or a TUI
+  that paints a "click to show more" view onto the terminal has nowhere to
+  draw, so the document has to come out of stdout. Nothing lands on the screen
+  you are typing in, and Ctrl-C there no longer kills the lookup. The first
+  attempt that parses wins, so the healthy path is unchanged.
+- **The scratch file (attempt 3) walks candidate directories** — `DEVINP_TMP`,
+  `os.tmpdir()`, `~/.devinp`, then the current directory — and uses the first
+  one it can actually write, removing the file afterwards. Set `DEVINP_TMP` to
+  pin it somewhere you control.
 - Noise around the document is tolerated: ANSI colours, an update banner in
   front, or the `pass a slug to --model` hint behind are stripped before the
   JSON is parsed.
@@ -46,9 +64,11 @@ invalid JSON (… 0 bytes)"*. It now works harder to get the whole document:
   prints a warning, and renders the partial table.
 - A real CLI failure (not signed in, network down) is reported as-is instead of
   being retried.
-- If nothing worked, the error lists every attempt — bytes, exit code, stderr,
-  timeout — and how to feed the data in yourself. That always works, because a
-  redirect or a pipe makes `devin` write the whole document in one go:
+- If nothing worked, the error lists all three attempts — bytes, exit code,
+  stderr, timeout — and how to feed the data in yourself. That always works,
+  because a redirect or a pipe makes `devin` write the whole document in one go:
+  (and if it does not, `command -v devin` tells you whether devinp is even
+  talking to the CLI and not to a shell function or agent wrapper around it).
 
   ```sh
   devin models list --format json > models.json && devinp --source models.json
@@ -125,11 +145,25 @@ so `npm publish`, git-URL installs, and `npm link` always ship a fresh bundle.
 
 ## Publishing
 
-`.github/workflows/publish.yml` bumps the patch version and publishes with
-[npm trusted publishing](https://docs.npmjs.com/trusted-publishers) (OIDC —
+`.github/workflows/publish.yml` publishes a patch release on every push to main
+with [npm trusted publishing](https://docs.npmjs.org/trusted-publishers) (OIDC —
 no `NPM_TOKEN`). Requires the trusted publisher to be configured on npmjs.com:
 repository `lucasschirm/devinp`, workflow `publish.yml`.
 
+It **never commits to main** — the branch ruleset requires every change to
+arrive through a pull request, and a rejected release commit used to strand the
+publish step that ran after it (GH013, then `npm publish` skipped). The released
+version therefore lives in the npm registry and in the git tag, not in main's
+`package.json`:
+
+```sh
+git ls-remote --tags origin                 # released versions
+npm view @lucasschirm/devinp version       # latest published
+```
+
+The workflow takes the first patch number that is free in both places, so a tag
+left behind by an older run cannot wedge it.
+
 ## License
 
 MIT

package/bin/command.js

@@ -26885,7 +26885,7 @@ var require_sonic_boom = __commonJS({
       if (!(this instanceof SonicBoom)) {
         return new SonicBoom(opts);
       }
-      let { fd, dest, minLength, maxLength, maxWrite, periodicFlush, sync, append = true, mkdir, retryEAGAIN, fsync, contentMode, mode } = opts || {};
+      let { fd, dest, minLength, maxLength, maxWrite, periodicFlush, sync, append = true, mkdir: mkdir2, retryEAGAIN, fsync, contentMode, mode } = opts || {};
       fd = fd || dest;
       this._len = 0;
       this.fd = -1;
@@ -26910,7 +26910,7 @@ var require_sonic_boom = __commonJS({
       this.append = append || false;
       this.mode = mode;
       this.retryEAGAIN = retryEAGAIN || (() => true);
-      this.mkdir = mkdir || false;
+      this.mkdir = mkdir2 || false;
       let fsWriteSync;
       let fsWrite;
       if (contentMode === kContentModeBuffer) {
@@ -55024,8 +55024,8 @@ async function startServer({ rows, benchMeta, port, log }) {
 
 // src/lib/source.js
 import { spawn } from "node:child_process";
-import { open, readFile as readFile2, unlink } from "node:fs/promises";
-import { tmpdir } from "node:os";
+import { mkdir, open, readFile as readFile2, unlink } from "node:fs/promises";
+import { homedir, tmpdir } from "node:os";
 import { join as join2 } from "node:path";
 
 // src/lib/repair-json.js
@@ -55095,10 +55095,11 @@ var NON_INTERACTIVE_ENV = {
   NO_COLOR: "1",
   CI: "1"
 };
+var DETACHED_SPAWN = { detached: true, windowsHide: true };
 var STRATEGIES = [
-  { label: "temp file", file: true, env: null },
-  { label: "temp file + non-interactive env", file: true, env: NON_INTERACTIVE_ENV },
-  { label: "pipe + non-interactive env", file: false, env: NON_INTERACTIVE_ENV }
+  { label: "pipe", file: false, env: null },
+  { label: "pipe, paging disabled, no controlling terminal", file: false, env: NON_INTERACTIVE_ENV, detached: true },
+  { label: "temp file, paging disabled, no controlling terminal", file: true, env: NON_INTERACTIVE_ENV, detached: true }
 ];
 var ANSI = /\u001b\[[0-9;?]*[ -/]*[@-~]|\u001b\][\s\S]*?(?:\u0007|\u001b\\)|\u001b[@-Z\\-_]/g;
 function stripAnsi(text) {
@@ -55120,11 +55121,12 @@ function parseJsonLoosely(text) {
   }
   return null;
 }
-function spawnDevin({ command, env, stdout, timeoutMs }) {
+function spawnDevin({ command, env, stdout, timeoutMs, detached = false }) {
   return new Promise((resolve, reject) => {
     const child = spawn(command, ["models", "list", "--format", "json"], {
       stdio: ["ignore", stdout, "pipe"],
-      ...env ? { env: { ...process.env, ...env } } : {}
+      ...env ? { env: { ...process.env, ...env } } : {},
+      ...detached ? DETACHED_SPAWN : {}
     });
     let stdoutText = "";
     let stderr = "";
@@ -55140,6 +55142,7 @@ function spawnDevin({ command, env, stdout, timeoutMs }) {
       stderr += chunk;
     });
     child.on("error", (error) => {
+      error.devinSpawn = true;
       clearTimeout(timer);
       reject(error);
     });
@@ -55149,11 +55152,41 @@ function spawnDevin({ command, env, stdout, timeoutMs }) {
     });
   });
 }
-async function captureToFile({ command, env, timeoutMs }) {
-  const file = join2(tmpdir(), `devinp-models-${process.pid}-${Date.now()}.json`);
-  const handle = await open(file, "w");
+async function writableScratchDir() {
+  const candidates = [];
+  if (process.env.DEVINP_TMP) candidates.push(process.env.DEVINP_TMP);
+  candidates.push(tmpdir(), join2(homedir(), ".devinp"), process.cwd());
+  for (const dir of candidates) {
+    try {
+      await mkdir(dir, { recursive: true });
+      const probe = join2(dir, `.devinp-probe-${process.pid}`);
+      const handle = await open(probe, "w");
+      await handle.close();
+      await unlink(probe);
+      return dir;
+    } catch {
+    }
+  }
+  return null;
+}
+async function captureToFile({ command, env, timeoutMs, detached }) {
+  const dir = await writableScratchDir();
+  if (!dir) {
+    const error = new Error(`cannot write a scratch file \u2014 DEVINP_TMP, os.tmpdir() ("${tmpdir()}"), ~/.devinp and "${process.cwd()}" all refused`);
+    error.scratchPath = dir;
+    throw error;
+  }
+  const file = join2(dir, `devinp-models-${process.pid}-${Date.now()}.json`);
+  let handle;
   try {
-    const result = await spawnDevin({ command, env, stdout: handle.fd, timeoutMs });
+    handle = await open(file, "w");
+  } catch (error) {
+    error.message = `cannot write scratch file "${file}" (${error.code ?? error.message})`;
+    error.scratchPath = file;
+    throw error;
+  }
+  try {
+    const result = await spawnDevin({ command, env, stdout: handle.fd, timeoutMs, detached });
     result.stdout = await readFile2(file, "utf8");
     return result;
   } finally {
@@ -55167,9 +55200,9 @@ async function runDevinJson({ command = "devin", timeoutMs = DEVIN_TIMEOUT_MS }
   for (const [index, strategy] of STRATEGIES.entries()) {
     let result;
     try {
-      result = strategy.file ? await captureToFile({ command, env: strategy.env, timeoutMs }) : await spawnDevin({ command, env: strategy.env, stdout: "pipe", timeoutMs });
+      result = strategy.file ? await captureToFile({ command, env: strategy.env, timeoutMs, detached: strategy.detached }) : await spawnDevin({ command, env: strategy.env, stdout: "pipe", timeoutMs, detached: strategy.detached });
     } catch (error) {
-      if (error.code === "ENOENT") throw error;
+      if (error.code === "ENOENT" && error.devinSpawn) throw error;
       attempts.push({ label: strategy.label, bytes: 0, code: null, stderr: "", timedOut: false, note: error.message });
       continue;
     }
@@ -55183,7 +55216,7 @@ async function runDevinJson({ command = "devin", timeoutMs = DEVIN_TIMEOUT_MS }
       timedOut: result.timedOut,
       raw
     });
-    if (parsed != null) return { raw, parsed, attempts, timeoutMs };
+    if (parsed != null) return { raw, parsed, attempts, timeoutMs, via: strategy.label };
     if (index === 0 && result.code !== 0 && !result.timedOut && result.stderr.trim()) {
       throw new Error(`\`devin models list\` failed \u2014 ${result.stderr.trim()}`);
     }
@@ -55192,8 +55225,8 @@ async function runDevinJson({ command = "devin", timeoutMs = DEVIN_TIMEOUT_MS }
   if (explained && attempts.every((a2) => a2.timedOut || a2.code !== 0)) {
     throw new Error(`\`devin models list\` failed \u2014 ${explained.stderr}`);
   }
-  const longest = attempts.reduce((acc, a2) => (a2.raw?.length ?? 0) > acc.length ? a2.raw : acc, "");
-  return { raw: longest || "", parsed: null, attempts, timeoutMs };
+  const longest = attempts.reduce((acc, a2) => (a2.raw?.length ?? 0) >= acc.length ? a2.raw : acc, "");
+  return { raw: longest || "", parsed: null, attempts, timeoutMs, via: null };
 }
 function assertFamilies(data, sourceName) {
   if (data == null || typeof data !== "object" || !Array.isArray(data.families)) {
@@ -55222,7 +55255,7 @@ function describeFailure(attempts, timeoutMs) {
   const lines = [];
   if (bytes === 0) {
     lines.push(
-      'Unable to get model prices: `devin models list --format json` exited without writing the JSON to stdout (0 bytes). Something between devinp and the CLI \u2014 a pager, an interactive "click to show more" view, or a shell/agent wrapper around `devin` \u2014 kept the output for the screen.'
+      'Unable to get model prices: `devin models list --format json` exited without writing the JSON to stdout (0 bytes). devinp re-ran it with paging disabled and in a session with no controlling terminal, so the CLI had no terminal to paint a "click to show more" view on \u2014 whatever swallowed the output sits between devinp and `devin` (a shell function or agent wrapper around it, or a broken install).'
     );
   } else {
     let parseError = "";
@@ -55236,10 +55269,13 @@ function describeFailure(attempts, timeoutMs) {
     );
   }
   lines.push(`Tried: ${attempts.map((a2) => describeAttempt(a2, timeoutMs)).join("; ")}.`);
+  if (attempts.some((a2) => a2.note?.includes("scratch"))) {
+    lines.push("devinp could not write its scratch file \u2014 point it somewhere writable with `DEVINP_TMP=/tmp devinp`.");
+  }
   lines.push("Capture the JSON yourself and hand it to devinp \u2014 piping or redirecting makes `devin` write the whole document in one go:");
   lines.push("  devin models list --format json > models.json && devinp --source models.json");
   lines.push("  devin models list --format json | devinp --source=-");
-  lines.push("If a plain `devin models list --format json > models.json` still prints a paged view, update the CLI (`devin update`).");
+  lines.push("Check `command -v devin` \u2014 if that is not the real CLI, devinp is asking the wrong program. If a plain redirect still prints a paged view, update the CLI (`devin update`).");
   return lines.join("\n");
 }
 async function readStdin() {
@@ -55262,7 +55298,7 @@ async function loadModelData({
       throw new Error(`Unable to get model prices: cannot read ${source === "-" ? "stdin" : `source file "${source}"`} (${error.code ?? error.message})`);
     }
     try {
-      return { data: assertFamilies(JSON.parse(raw), label), retries: 0 };
+      return { data: assertFamilies(JSON.parse(raw), label), retries: 0, via: source === "-" ? "stdin" : "file" };
     } catch (error) {
       if (error.message.startsWith("Unable to get model prices")) throw error;
       throw new Error(`Unable to get model prices: ${label} is not valid JSON (expected \`devin models list --format json\` output)`);
@@ -55272,17 +55308,17 @@ async function loadModelData({
   try {
     outcome = await runDevinJson({ command, timeoutMs });
   } catch (error) {
-    if (error.code === "ENOENT") {
+    if (error.code === "ENOENT" && error.devinSpawn) {
       throw new Error("Unable to get model prices: `devin` CLI not found in PATH. Install it, or pass --source <file> / --source=- to supply the JSON yourself.");
     }
     throw new Error(`Unable to get model prices: ${error.message}`);
   }
   if (outcome.parsed != null) {
-    return { data: assertFamilies(outcome.parsed, "devin models list"), retries: outcome.attempts.length - 1 };
+    return { data: assertFamilies(outcome.parsed, "devin models list"), retries: outcome.attempts.length - 1, via: outcome.via };
   }
   const recovered = recoverTruncatedJson(outcome.raw);
   if (recovered != null) {
-    return { data: assertFamilies(recovered, "devin models list (recovered)"), truncated: true, retries: outcome.attempts.length - 1 };
+    return { data: assertFamilies(recovered, "devin models list (recovered)"), truncated: true, retries: outcome.attempts.length - 1, via: outcome.via ?? "repaired" };
   }
   throw new Error(describeFailure(outcome.attempts, outcome.timeoutMs));
 }
@@ -55343,7 +55379,7 @@ var Devinp = class _Devinp extends import_core.Command {
         this.warn("devin output was truncated mid-stream \u2014 showing partial data, re-run for the full list");
       }
       if (loaded.retries > 0) {
-        this.warn(`devin needed ${loaded.retries + 1} attempts to hand over the model list \u2014 something on this machine (pager, paged "show more" view, wrapper) interferes with \`devin models list\``);
+        this.warn(`devin needed ${loaded.retries + 1} attempts to hand over the model list \u2014 the data arrived via ${loaded.via ?? "a fallback"} (something on this machine interferes with \`devin models list\`; DEVINP_TMP sets the scratch directory)`);
       }
       data = loaded.data;
     } catch (error) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lucasschirm/devinp",
-  "version": "0.1.11",
+  "version": "0.1.14",
   "description": "Pretty pricing table for Devin models, powered by `devin models list`",
   "type": "module",
   "bin": {