@lti-tool/core 0.14.0 → 0.14.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @lti-tool/core
 
+## 0.14.1
+
+### Patch Changes
+
+- 25534f8: Fix score and results endpoint to use a cleansed ags line item endpoint without search params.
+
 ## 0.14.0
 
 ### Minor Changes

package/dist/services/ags.service.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ags.service.d.ts","sourceRoot":"","sources":["../../src/services/ags.service.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,MAAM,CAAC;AAEvC,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAC9D,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAC9D,OAAO,KAAK,EACV,cAAc,EACd,cAAc,EACf,MAAM,yCAAyC,CAAC;AACjD,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,gDAAgD,CAAC;AAGtF,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAC;AAEvD;;;;;GAKG;AACH,qBAAa,UAAU;IASnB,OAAO,CAAC,YAAY;IACpB,OAAO,CAAC,OAAO;IACf,OAAO,CAAC,MAAM;IAVhB;;;;;;OAMG;gBAEO,YAAY,EAAE,YAAY,EAC1B,OAAO,EAAE,UAAU,EACnB,MAAM,EAAE,UAAU;IAG5B;;;;;;;;;;;;;;;;;;OAkBG;IACG,WAAW,CAAC,OAAO,EAAE,UAAU,EAAE,KAAK,EAAE,eAAe,GAAG,OAAO,CAAC,QAAQ,CAAC;IAiCjF;;;;;;;;;;;;;OAaG;IACG,SAAS,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,QAAQ,CAAC;IA4BvD;;;;;;;;;;;;;OAaG;IACG,aAAa,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,QAAQ,CAAC;IAsB3D;;;;;;;;;;;;;OAaG;IACG,WAAW,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,QAAQ,CAAC;IAsBzD;;;;;;;;;;;;;;;;;;;OAmBG;IACG,cAAc,CAClB,OAAO,EAAE,UAAU,EACnB,cAAc,EAAE,cAAc,GAC7B,OAAO,CAAC,QAAQ,CAAC;IAuBpB;;;;;;;;;;;;;;;;;OAiBG;IACG,cAAc,CAClB,OAAO,EAAE,UAAU,EACnB,cAAc,EAAE,cAAc,GAC7B,OAAO,CAAC,QAAQ,CAAC;IAuBpB;;;;;;;;;;;;OAYG;IACG,cAAc,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,QAAQ,CAAC;YAqB9C,WAAW;YAeX,mBAAmB;CAalC"}
+{"version":3,"file":"ags.service.d.ts","sourceRoot":"","sources":["../../src/services/ags.service.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,MAAM,CAAC;AAEvC,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAC9D,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAC9D,OAAO,KAAK,EACV,cAAc,EACd,cAAc,EACf,MAAM,yCAAyC,CAAC;AACjD,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,gDAAgD,CAAC;AAGtF,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAC;AAEvD;;;;;GAKG;AACH,qBAAa,UAAU;IASnB,OAAO,CAAC,YAAY;IACpB,OAAO,CAAC,OAAO;IACf,OAAO,CAAC,MAAM;IAVhB;;;;;;OAMG;gBAEO,YAAY,EAAE,YAAY,EAC1B,OAAO,EAAE,UAAU,EACnB,MAAM,EAAE,UAAU;IAG5B;;;;;;;;;;;;;;;;;;OAkBG;IACG,WAAW,CAAC,OAAO,EAAE,UAAU,EAAE,KAAK,EAAE,eAAe,GAAG,OAAO,CAAC,QAAQ,CAAC;IAkCjF;;;;;;;;;;;;;OAaG;IACG,SAAS,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,QAAQ,CAAC;IAwBvD;;;;;;;;;;;;;OAaG;IACG,aAAa,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,QAAQ,CAAC;IAsB3D;;;;;;;;;;;;;OAaG;IACG,WAAW,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,QAAQ,CAAC;IAsBzD;;;;;;;;;;;;;;;;;;;OAmBG;IACG,cAAc,CAClB,OAAO,EAAE,UAAU,EACnB,cAAc,EAAE,cAAc,GAC7B,OAAO,CAAC,QAAQ,CAAC;IAuBpB;;;;;;;;;;;;;;;;;OAiBG;IACG,cAAc,CAClB,OAAO,EAAE,UAAU,EACnB,cAAc,EAAE,cAAc,GAC7B,OAAO,CAAC,QAAQ,CAAC;IAuBpB;;;;;;;;;;;;OAYG;IACG,cAAc,CAAC,OAAO,EAAE,UAAU,GAAG,OAAO,CAAC,QAAQ,CAAC;YAqB9C,WAAW;YAeX,mBAAmB;CAalC"}

package/dist/services/ags.service.js

@@ -54,7 +54,8 @@ export class AGSService {
             activityProgress: score.activityProgress,
             gradingProgress: score.gradingProgress,
         };
-        const response = await fetch(`${session.services.ags.lineitem}/scores`, {
+        const agsScoreEndpoint = `${session.services.ags.lineitem}/scores`;
+        const response = await fetch(agsScoreEndpoint, {
             method: 'POST',
             headers: {
                 Authorization: `Bearer ${token}`,
@@ -84,12 +85,8 @@ export class AGSService {
             throw new Error('AGS line item not available for this session');
         }
         const token = await this.getAGSToken(session, 'https://purl.imsglobal.org/spec/lti-ags/scope/result.readonly');
-        // cleanse the results URL
-        // we cannot include a search / query param
-        const lineItemUrl = new URL(session.services.ags.lineitem);
-        lineItemUrl.search = '';
-        const resultsUrl = `${lineItemUrl.toString()}/results`;
-        const response = await fetch(resultsUrl, {
+        const resultsEndpoint = `${session.services.ags.lineitem}/results`;
+        const response = await fetch(resultsEndpoint, {
             method: 'GET',
             headers: {
                 Authorization: `Bearer ${token}`,

package/dist/services/session.service.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"session.service.d.ts","sourceRoot":"","sources":["../../src/services/session.service.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAC9D,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,qBAAqB,CAAC;AAE3D;;;;;;GAMG;AAEH,wBAAgB,aAAa,CAAC,eAAe,EAAE,eAAe,GAAG,UAAU,CAuG1E"}
+{"version":3,"file":"session.service.d.ts","sourceRoot":"","sources":["../../src/services/session.service.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAC9D,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,qBAAqB,CAAC;AAE3D;;;;;;GAMG;AAEH,wBAAgB,aAAa,CAAC,eAAe,EAAE,eAAe,GAAG,UAAU,CA4G1E"}

package/dist/services/session.service.js

@@ -20,9 +20,14 @@ export function createSession(lti13JwtPayload) {
     const isAdmin = roles.some((role) => role.includes('Administrator'));
     const services = {};
     if (agsEndpoint) {
+        let lineItemUrl;
+        if (agsEndpoint.lineitem) {
+            const url = new URL(agsEndpoint.lineitem);
+            lineItemUrl = `${url.origin}${url.pathname}`; // quirk: moodle adds a url search param
+        }
         services.ags = {
-            lineitem: agsEndpoint.lineitem,
-            lineitems: agsEndpoint.lineitems,
+            lineitem: lineItemUrl,
+            lineitems: agsEndpoint.lineitems, // quirk: keep the moodle url search param
             scopes: agsEndpoint.scope || [],
         };
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@lti-tool/core",
-  "version": "0.14.0",
+  "version": "0.14.1",
   "description": "LTI 1.3 implementation for Node.js",
   "keywords": [
     "lti",

package/src/services/ags.service.ts

@@ -70,7 +70,8 @@ export class AGSService {
       gradingProgress: score.gradingProgress,
     };
 
-    const response = await fetch(`${session.services.ags.lineitem}/scores`, {
+    const agsScoreEndpoint = `${session.services.ags.lineitem}/scores`;
+    const response = await fetch(agsScoreEndpoint, {
       method: 'POST',
       headers: {
         Authorization: `Bearer ${token}`,
@@ -107,13 +108,9 @@ export class AGSService {
       'https://purl.imsglobal.org/spec/lti-ags/scope/result.readonly',
     );
 
-    // cleanse the results URL
-    // we cannot include a search / query param
-    const lineItemUrl = new URL(session.services.ags.lineitem);
-    lineItemUrl.search = '';
-    const resultsUrl = `${lineItemUrl.toString()}/results`;
+    const resultsEndpoint = `${session.services.ags.lineitem}/results`;
 
-    const response = await fetch(resultsUrl, {
+    const response = await fetch(resultsEndpoint, {
       method: 'GET',
       headers: {
         Authorization: `Bearer ${token}`,

package/src/services/session.service.ts

@@ -31,9 +31,14 @@ export function createSession(lti13JwtPayload: LTI13JwtPayload): LTISession {
 
   const services: Record<string, unknown> = {};
   if (agsEndpoint) {
+    let lineItemUrl: string | undefined;
+    if (agsEndpoint.lineitem) {
+      const url = new URL(agsEndpoint.lineitem);
+      lineItemUrl = `${url.origin}${url.pathname}`; // quirk: moodle adds a url search param
+    }
     services.ags = {
-      lineitem: agsEndpoint.lineitem,
-      lineitems: agsEndpoint.lineitems,
+      lineitem: lineItemUrl,
+      lineitems: agsEndpoint.lineitems, // quirk: keep the moodle url search param
       scopes: agsEndpoint.scope || [],
     };
   }