@loxia-labs/loxia-autopilot-one 1.0.1

package/src/core/messageProcessor.js

@@ -0,0 +1,732 @@
+/**
+ * MessageProcessor - Processes messages from agents, extracts tool commands, executes tools
+ * 
+ * NEW ARCHITECTURE:
+ * - Only handles message queuing and tool execution
+ * - No scheduling or autonomous loops (handled by AgentScheduler)
+ * - Clean separation of concerns
+ */
+
+import { AGENT_MODES, AGENT_MODE_STATES } from '../utilities/constants.js';
+import TagParser from '../utilities/tagParser.js';
+import { TOOL_IDS, COMMAND_FORMATS } from '../utilities/toolConstants.js';
+
+class MessageProcessor {
+  constructor(config, logger, toolsRegistry, agentPool, contextManager, aiService, modelRouterService = null, modelsService = null) {
+    this.config = config;
+    this.logger = logger;
+    this.toolsRegistry = toolsRegistry;
+    this.agentPool = agentPool;
+    this.contextManager = contextManager;
+    this.aiService = aiService;
+    this.modelRouterService = modelRouterService;
+    this.modelsService = modelsService;
+    
+    // Active async operations tracking
+    this.asyncOperations = new Map();
+    
+    // Tool execution history
+    this.executionHistory = new Map();
+    
+    // Operation ID counter
+    this.operationCounter = 0;
+    
+    // WebSocket manager for real-time updates
+    this.webSocketManager = null;
+    
+    // AgentScheduler reference
+    this.scheduler = null;
+    
+    // Orchestrator reference (for backward compatibility)
+    this.orchestrator = null;
+    
+    // Initialize TagParser for comprehensive tool command extraction
+    this.tagParser = new TagParser();
+  }
+
+  /**
+   * Set WebSocket manager for real-time UI updates
+   * @param {Object} webSocketManager - WebSocket manager instance
+   */
+  setWebSocketManager(webSocketManager) {
+    this.webSocketManager = webSocketManager;
+    this.logger?.info('WebSocket manager set for MessageProcessor', {
+      hasManager: !!webSocketManager
+    });
+  }
+
+  /**
+   * Set AgentScheduler reference
+   * @param {AgentScheduler} scheduler - AgentScheduler instance
+   */
+  setScheduler(scheduler) {
+    this.scheduler = scheduler;
+    this.logger?.info('AgentScheduler set for MessageProcessor', {
+      hasScheduler: !!scheduler
+    });
+  }
+
+  /**
+   * Main message processing entry point - NEW ARCHITECTURE
+   * Simply queues messages for scheduler processing
+   * @param {string} agentId - Target agent ID
+   * @param {string} message - Message content
+   * @param {Object} context - Message context
+   * @returns {Promise<Object>} Queuing result
+   */
+  async processMessage(agentId, message, context = {}) {
+    const agent = await this.agentPool.getAgent(agentId);
+    if (!agent) {
+      throw new Error(`Agent not found: ${agentId}`);
+    }
+
+    const messageString = typeof message === 'string' ? message : (message ? JSON.stringify(message) : '');
+    this.logger.info(`Queueing message for agent: ${agentId}`, {
+      messageLength: messageString.length,
+      messageType: typeof message,
+      isInterAgentMessage: context.isInterAgentMessage,
+      contextMessageType: context.messageType || 'user'
+    });
+
+    // Determine message type and queue appropriately
+    if (context.isInterAgentMessage) {
+      // Inter-agent message
+      await this.agentPool.addInterAgentMessage(agentId, {
+        content: message,
+        sender: context.originalSender,
+        senderName: context.senderName,
+        subject: context.subject || 'Inter-agent message',
+        timestamp: new Date().toISOString(),
+        sessionId: context.sessionId,
+        requiresReply: context.requiresReply || false
+      });
+    } else {
+      // User message
+      await this.agentPool.addUserMessage(agentId, {
+        content: message,
+        role: 'user',
+        timestamp: new Date().toISOString(),
+        contextReferences: context.contextReferences || [],
+        sessionId: context.sessionId
+      });
+    }
+
+    // Add agent to scheduler if not already active
+    if (this.scheduler) {
+      await this.scheduler.addAgent(agentId, {
+        triggeredBy: context.isInterAgentMessage ? 'inter-agent-message' : 'user-message',
+        sessionId: context.sessionId
+      });
+    }
+
+    return {
+      success: true,
+      message: 'Message queued for processing',
+      agentId: agentId,
+      queuedAt: new Date().toISOString()
+    };
+  }
+
+  /**
+   * Unwrap TagParser format parameters
+   * TagParser wraps XML parameters in {value, attributes} objects
+   * This method unwraps them to direct values for tool consumption
+   * @param {Object} params - Parameters to unwrap
+   * @returns {Object} Unwrapped parameters
+   */
+  unwrapParameters(params) {
+    if (!params || typeof params !== 'object') {
+      return params;
+    }
+
+    const unwrapped = {};
+    for (const [key, value] of Object.entries(params)) {
+      if (value && typeof value === 'object' && 'value' in value && 'attributes' in value) {
+        // TagParser wrapped format: {value: "...", attributes: {}}
+        unwrapped[key] = value.value;
+
+        // Also preserve attributes if tool needs them
+        if (value.attributes && Object.keys(value.attributes).length > 0) {
+          unwrapped[`${key}_attributes`] = value.attributes;
+        }
+      } else {
+        // Already unwrapped or direct value
+        unwrapped[key] = value;
+      }
+    }
+
+    return unwrapped;
+  }
+
+  /**
+   * Extract tool commands from message content
+   * Supports multiple formats: XML, JSON, and simple bracket notation
+   * @param {string} message - Message containing tool commands
+   * @returns {Promise<Array>} Array of tool commands
+   */
+  async extractToolCommands(message) {
+    const commands = [];
+    
+    // Use TagParser to extract XML and JSON format commands
+    const tagParserCommands = this.tagParser.extractToolCommands(message);
+    
+    // Process TagParser commands and normalize them
+    for (const cmd of tagParserCommands) {
+      const normalized = this.tagParser.normalizeToolCommand(cmd);
+      commands.push({
+        toolId: normalized.toolId,
+        content: JSON.stringify(normalized.parameters), // Convert parameters to JSON string for tool execution
+        parameters: normalized.parameters,
+        type: normalized.type,
+        isAsync: normalized.parameters?.async === true,
+        raw: normalized.rawContent,
+        position: cmd.position || {}
+      });
+    }
+    
+    // Also check for simple bracket notation [tool id="..."] for backward compatibility
+    const toolPattern = /\[tool\s+id="([^"]+)"(?:\s+async="(true|false)")?\]([\s\S]*?)\[\/tool\]/gi;
+    
+    console.log('MessageProcessor DEBUG: checking bracket pattern on message length:', message.length);
+    
+    let match;
+    while ((match = toolPattern.exec(message)) !== null) {
+      const [fullMatch, toolId, isAsync, content] = match;
+      
+      console.log('MessageProcessor DEBUG: bracket pattern matched:', {
+        toolId: toolId.trim(),
+        contentLength: content.trim().length,
+        contentPreview: content.trim().substring(0, 100)
+      });
+      
+      // Check if this command was already extracted by TagParser
+      const alreadyExtracted = commands.some(cmd => 
+        cmd.raw === fullMatch || (cmd.position.start === match.index && cmd.position.end === match.index + fullMatch.length)
+      );
+      
+      if (!alreadyExtracted) {
+        console.log('MessageProcessor DEBUG: adding bracket command (not already extracted by TagParser)');
+        
+        const trimmedContent = content.trim();
+        
+        // Check if the content inside brackets contains XML tags
+        const hasXmlTags = /<[^>]+>/g.test(trimmedContent);
+        
+        if (hasXmlTags) {
+          console.log('MessageProcessor DEBUG: detected XML content inside brackets, parsing with TagParser');
+          
+          // Decode HTML entities before parsing XML
+          const decodedXmlContent = this.tagParser.decodeHtmlEntities(trimmedContent);
+          console.log('MessageProcessor DEBUG: HTML decoding changed content:', trimmedContent !== decodedXmlContent);
+          
+          // Parse the XML content using TagParser
+          try {
+            const xmlParameters = this.tagParser.parseXMLParameters(decodedXmlContent);
+            
+            console.log('MessageProcessor DEBUG: XML parameters extracted:', Object.keys(xmlParameters));
+            
+            // Check if we got valid parameters
+            if (!xmlParameters || typeof xmlParameters !== 'object') {
+              throw new Error('Invalid XML parameters returned');
+            }
+            
+            // Create a temporary XML command structure for normalization
+            const xmlCommand = {
+              type: COMMAND_FORMATS.XML,
+              toolId: toolId.trim(),
+              parameters: xmlParameters,
+              rawContent: decodedXmlContent
+            };
+            
+            // Normalize it to get the actions array
+            const normalized = this.tagParser.normalizeToolCommand(xmlCommand);
+            
+            console.log('MessageProcessor DEBUG: normalized XML command:', {
+              toolId: normalized.toolId,
+              hasActions: !!normalized.parameters.actions,
+              actionsLength: normalized.parameters.actions?.length || 0
+            });
+            
+            // Add the properly parsed command
+            commands.push({
+              toolId: normalized.toolId,
+              content: JSON.stringify(normalized.parameters),
+              parameters: normalized.parameters,
+              type: COMMAND_FORMATS.XML, // Mark as XML since we parsed it
+              isAsync: isAsync === 'true',
+              raw: fullMatch,
+              position: {
+                start: match.index,
+                end: match.index + fullMatch.length
+              }
+            });
+            
+          } catch (error) {
+            console.log('MessageProcessor DEBUG: XML parsing failed:', error.message);
+            console.log('MessageProcessor DEBUG: falling back to raw bracket format');
+            
+            // Fall back to treating it as a simple bracket command
+            commands.push({
+              toolId: toolId.trim(),
+              content: trimmedContent,
+              type: COMMAND_FORMATS.BRACKET,
+              isAsync: isAsync === 'true',
+              raw: fullMatch,
+              position: {
+                start: match.index,
+                end: match.index + fullMatch.length
+              }
+            });
+          }
+        } else {
+          console.log('MessageProcessor DEBUG: no XML detected, treating as simple bracket command');
+          
+          // Simple bracket command without XML content
+          commands.push({
+            toolId: toolId.trim(),
+            content: trimmedContent,
+            type: COMMAND_FORMATS.BRACKET,
+            isAsync: isAsync === 'true',
+            raw: fullMatch,
+            position: {
+              start: match.index,
+              end: match.index + fullMatch.length
+            }
+          });
+        }
+      } else {
+        console.log('MessageProcessor DEBUG: bracket command already extracted by TagParser, skipping');
+      }
+    }
+    
+    // Extract agent redirects as well (for inter-agent communication)
+    const redirects = this.tagParser.extractAgentRedirects(message);
+    for (const redirect of redirects) {
+      commands.push({
+        toolId: TOOL_IDS.AGENT_COMMUNICATION,
+        content: JSON.stringify({
+          to: redirect.to,
+          message: redirect.content,
+          urgent: redirect.urgent,
+          requiresResponse: redirect.requiresResponse,
+          context: redirect.context
+        }),
+        type: COMMAND_FORMATS.REDIRECT,
+        isAsync: false,
+        raw: redirect.rawMatch,
+        position: {}
+      });
+    }
+    
+    this.logger.debug(`Extracted ${commands.length} tool commands from message`, {
+      formats: commands.map(c => c.type),
+      tools: commands.map(c => c.toolId)
+    });
+    
+    return commands;
+  }
+
+  /**
+   * Execute tool commands
+   * @param {Array} commands - Array of tool commands
+   * @param {Object} context - Execution context
+   * @returns {Promise<Array>} Array of execution results
+   */
+  async executeTools(commands, context) {
+    const results = [];
+    
+    for (const command of commands) {
+      try {
+        const tool = this.toolsRegistry.getTool(command.toolId);
+        
+        if (!tool) {
+          results.push({
+            toolId: command.toolId,
+            status: 'failed',
+            error: `Tool not found: ${command.toolId}`,
+            timestamp: new Date().toISOString()
+          });
+          continue;
+        }
+        
+        this.logger.info(`Executing tool: ${command.toolId}`, {
+          agentId: context.agentId,
+          isAsync: command.isAsync
+        });
+        
+        let result;
+        if (command.isAsync) {
+          result = await this.executeAsyncTool(command, tool, context);
+        } else {
+          // Synchronous tool execution
+          // If we have parameters object, use it. Otherwise parse the content.
+          let toolInput = command.parameters;
+
+          if (!toolInput && command.content) {
+            // Content is a string, need to parse it using tool's parseParameters method
+            if (typeof tool.parseParameters === 'function') {
+              try {
+                toolInput = tool.parseParameters(command.content);
+                this.logger?.debug(`Parsed parameters for tool: ${command.toolId}`, {
+                  parsedKeys: Object.keys(toolInput)
+                });
+              } catch (error) {
+                this.logger?.warn(`Failed to parse parameters for tool: ${command.toolId}`, {
+                  error: error.message
+                });
+                // Fall back to raw content
+                toolInput = command.content;
+              }
+            } else {
+              // Tool doesn't have parseParameters, use raw content
+              toolInput = command.content;
+            }
+          }
+
+          // CRITICAL FIX: Unwrap TagParser format before tool execution
+          // TagParser wraps XML parameters in {value, attributes} objects
+          // This unwrapping makes all tools work consistently
+          if (toolInput && typeof toolInput === 'object') {
+            toolInput = this.unwrapParameters(toolInput);
+          }
+
+          const toolResult = await tool.execute(toolInput, context);
+          result = {
+            toolId: command.toolId,
+            status: 'completed',
+            result: toolResult,
+            timestamp: new Date().toISOString()
+          };
+        }
+        
+        results.push(result);
+        
+        // Store in execution history
+        const historyKey = `${context.agentId}-${Date.now()}`;
+        this.executionHistory.set(historyKey, {
+          ...result,
+          agentId: context.agentId,
+          sessionId: context.sessionId
+        });
+        
+      } catch (error) {
+        this.logger.error(`Tool execution failed: ${command.toolId}`, {
+          error: error.message,
+          agentId: context.agentId
+        });
+        
+        results.push({
+          toolId: command.toolId,
+          status: 'failed',
+          error: error.message,
+          timestamp: new Date().toISOString()
+        });
+      }
+    }
+    
+    return results;
+  }
+
+  /**
+   * Execute async tool
+   * @param {Object} command - Tool command
+   * @param {Object} tool - Tool instance
+   * @param {Object} context - Execution context
+   * @returns {Promise<Object>} Async operation reference
+   */
+  async executeAsyncTool(command, tool, context) {
+    const operationId = `async-${Date.now()}-${this.operationCounter++}`;
+    
+    // Create async operation entry
+    const operation = {
+      id: operationId,
+      toolId: command.toolId,
+      agentId: context.agentId,
+      status: 'pending',
+      startTime: new Date().toISOString(),
+      context: context
+    };
+    
+    this.asyncOperations.set(operationId, operation);
+
+    // Start async execution
+    // If we have parameters object, use it. Otherwise parse the content.
+    let toolInput = command.parameters;
+
+    if (!toolInput && command.content) {
+      // Content is a string, need to parse it using tool's parseParameters method
+      if (typeof tool.parseParameters === 'function') {
+        try {
+          toolInput = tool.parseParameters(command.content);
+        } catch (error) {
+          this.logger?.warn(`Failed to parse parameters for async tool: ${command.toolId}`, {
+            error: error.message
+          });
+          // Fall back to raw content
+          toolInput = command.content;
+        }
+      } else {
+        // Tool doesn't have parseParameters, use raw content
+        toolInput = command.content;
+      }
+    }
+
+    // CRITICAL FIX: Unwrap TagParser format before tool execution
+    // TagParser wraps XML parameters in {value, attributes} objects
+    // This unwrapping makes all tools work consistently
+    if (toolInput && typeof toolInput === 'object') {
+      toolInput = this.unwrapParameters(toolInput);
+    }
+
+    tool.execute(toolInput, context)
+      .then(result => {
+        operation.status = 'completed';
+        operation.result = result;
+        operation.endTime = new Date().toISOString();
+        this.notifyAgentOfToolCompletion(operation);
+      })
+      .catch(error => {
+        operation.status = 'failed';
+        operation.error = error.message;
+        operation.endTime = new Date().toISOString();
+        this.notifyAgentOfToolCompletion(operation);
+      });
+    
+    // Start monitoring
+    this.monitorAsyncOperation(operationId);
+    
+    return {
+      toolId: command.toolId,
+      status: 'async-pending',
+      operationId: operationId,
+      message: `Async tool started with operation ID: ${operationId}`,
+      timestamp: new Date().toISOString()
+    };
+  }
+
+  /**
+   * Monitor async operation
+   * @param {string} operationId - Operation ID to monitor
+   */
+  async monitorAsyncOperation(operationId) {
+    const checkInterval = 5000; // 5 seconds
+    const maxChecks = 120; // 10 minutes max
+    let checks = 0;
+    
+    const monitor = setInterval(() => {
+      const operation = this.asyncOperations.get(operationId);
+      
+      if (!operation) {
+        clearInterval(monitor);
+        return;
+      }
+      
+      checks++;
+      
+      if (operation.status !== 'pending' || checks >= maxChecks) {
+        clearInterval(monitor);
+        
+        if (checks >= maxChecks) {
+          operation.status = 'timeout';
+          operation.error = 'Operation timed out';
+          operation.endTime = new Date().toISOString();
+          this.notifyAgentOfToolCompletion(operation);
+        }
+      }
+    }, checkInterval);
+  }
+
+  /**
+   * Notify agent of tool completion
+   * @param {Object} operation - Completed operation
+   */
+  async notifyAgentOfToolCompletion(operation) {
+    if (!operation.agentId) return;
+    
+    try {
+      // Queue tool result for the agent
+      await this.agentPool.addToolResult(operation.agentId, {
+        toolId: operation.toolId,
+        status: operation.status,
+        result: operation.result,
+        error: operation.error,
+        executionTime: operation.endTime ? 
+          new Date(operation.endTime) - new Date(operation.startTime) : null,
+        timestamp: operation.endTime || new Date().toISOString()
+      });
+      
+      // Add agent back to scheduler if needed
+      if (this.scheduler) {
+        await this.scheduler.addAgent(operation.agentId, {
+          triggeredBy: 'tool-completion',
+          sessionId: operation.context?.sessionId
+        });
+      }
+      
+      this.logger.info(`Agent notified of tool completion: ${operation.agentId}`, {
+        toolId: operation.toolId,
+        status: operation.status
+      });
+      
+    } catch (error) {
+      this.logger.error(`Failed to notify agent of tool completion`, {
+        agentId: operation.agentId,
+        toolId: operation.toolId,
+        error: error.message
+      });
+    }
+  }
+
+  /**
+   * Get tool status
+   * @param {string} operationId - Operation ID
+   * @returns {Promise<Object>} Operation status
+   */
+  async getToolStatus(operationId) {
+    const operation = this.asyncOperations.get(operationId);
+    
+    if (!operation) {
+      return {
+        status: 'not-found',
+        error: `Operation not found: ${operationId}`
+      };
+    }
+    
+    return {
+      id: operation.id,
+      toolId: operation.toolId,
+      status: operation.status,
+      result: operation.result,
+      error: operation.error,
+      startTime: operation.startTime,
+      endTime: operation.endTime
+    };
+  }
+
+  /**
+   * Extract and execute tools from content
+   * Called by AgentScheduler after getting AI response
+   * @param {string} content - Content containing tool commands
+   * @param {string} agentId - Agent ID
+   * @param {Object} context - Execution context
+   * @returns {Promise<Array>} Tool execution results
+   */
+  async extractAndExecuteTools(content, agentId, context) {
+    try {
+      // Extract tool commands
+      const commands = await this.extractToolCommands(content);
+      
+      if (commands.length === 0) {
+        return [];
+      }
+      
+      // Get agent to include its directoryAccess configuration
+      const agent = await this.agentPool.getAgent(agentId);
+      
+      // Execute tools with agent context including sessionId and directoryAccess
+      const toolContext = {
+        ...context,
+        agentId,
+        sessionId: context.sessionId, // Ensure sessionId is explicitly available for tools
+        directoryAccess: agent?.directoryAccess, // Include agent's directory access configuration
+        projectDir: agent?.directoryAccess?.workingDirectory || agent?.projectDir || context.projectDir, // Extract project directory from directoryAccess
+        agentPool: this.agentPool,
+        contextManager: this.contextManager,
+        aiService: this.aiService,
+        messageProcessor: this,
+        orchestrator: this.orchestrator
+      };
+      
+      const results = await this.executeTools(commands, toolContext);
+      
+      this.logger.info(`Executed ${results.length} tools for agent: ${agentId}`, {
+        tools: results.map(r => ({ toolId: r.toolId, status: r.status }))
+      });
+      
+      return results;
+      
+    } catch (error) {
+      this.logger.error(`Tool extraction/execution failed for agent: ${agentId}`, {
+        error: error.message
+      });
+      return [];
+    }
+  }
+
+  /**
+   * Stop autonomous execution for an agent
+   * Proxy method to AgentScheduler
+   * @param {string} agentId - Agent ID to stop
+   * @returns {Promise<Object>} Result with agent state
+   */
+  async stopAutonomousExecution(agentId) {
+    if (!this.scheduler) {
+      return {
+        success: false,
+        error: 'Scheduler not available'
+      };
+    }
+    
+    return await this.scheduler.stopAgentExecution(agentId);
+  }
+
+  /**
+   * Inject tool results into conversation
+   * @param {string} agentId - Agent ID
+   * @param {Array} toolResults - Tool execution results
+   * @returns {Promise<void>}
+   */
+  async injectToolResultsIntoConversation(agentId, toolResults) {
+    const agent = await this.agentPool.getAgent(agentId);
+    if (!agent) return;
+
+    for (const result of toolResults) {
+      const toolMessage = {
+        id: `tool-${Date.now()}-${Math.random().toString(36).substr(2, 9)}`,
+        role: 'system',
+        content: this.formatToolResultForAgent(result),
+        timestamp: new Date().toISOString(),
+        type: 'tool-result',
+        toolId: result.toolId,
+        status: result.status
+      };
+
+      // Add to conversation history
+      agent.conversations.full.messages.push(toolMessage);
+      
+      // Also add to current model conversation if exists
+      if (agent.currentModel && agent.conversations[agent.currentModel]) {
+        agent.conversations[agent.currentModel].messages.push(toolMessage);
+      }
+    }
+
+    // Update last activity
+    agent.conversations.full.lastUpdated = new Date().toISOString();
+    if (agent.currentModel && agent.conversations[agent.currentModel]) {
+      agent.conversations[agent.currentModel].lastUpdated = new Date().toISOString();
+    }
+
+    await this.agentPool.persistAgentState(agentId);
+  }
+
+  /**
+   * Format tool result for agent consumption
+   * @param {Object} result - Tool execution result
+   * @returns {string} Formatted result
+   */
+  formatToolResultForAgent(result) {
+    if (result.status === 'completed') {
+      if (typeof result.result === 'object') {
+        return `Tool ${result.toolId} completed successfully:\n${JSON.stringify(result.result, null, 2)}`;
+      }
+      return `Tool ${result.toolId} completed successfully:\n${result.result}`;
+    } else if (result.status === 'failed') {
+      return `Tool ${result.toolId} failed: ${result.error || 'Unknown error'}`;
+    } else if (result.status === 'async-pending') {
+      return `Tool ${result.toolId} is running asynchronously (Operation ID: ${result.operationId})`;
+    }
+    return `Tool ${result.toolId} status: ${result.status}`;
+  }
+}
+
+export default MessageProcessor;