@love-moon/conductor-cli 0.8.0 → 0.10.0

package/src/remote-exec-handlers.js

@@ -0,0 +1,421 @@
+import { promises as fsp } from "node:fs";
+import path from "node:path";
+import { spawn } from "node:child_process";
+import { randomUUID } from "node:crypto";
+import { StringDecoder } from "node:string_decoder";
+
+import { resolveUserHome } from "./conductor-paths.js";
+
+const VALID_ACTIONS = new Set(["exec", "status", "cancel"]);
+const MAX_TAIL_CHARS = 64_000;
+const MAX_RUNS = 200;
+const MAX_CONCURRENT_RUNS = 32;
+const MAX_ARGS = 256;
+const DEFAULT_WAIT_MS = 30_000;
+const MAX_WAIT_MS = 120_000;
+/** Grace between SIGTERM and SIGKILL when a run is cancelled. */
+const KILL_GRACE_MS = 5_000;
+const NUL = String.fromCharCode(0);
+
+export const REMOTE_EXEC_CAPABILITY = "remote_exec";
+
+/**
+ * Run arbitrary commands on this daemon's host on behalf of the account that
+ * owns it.
+ *
+ * This is not a new trust boundary: the same account can already reach the same
+ * shell through `create_pty_task`, whose `entrypoint_type: "custom"` branch
+ * takes a caller-supplied command, argv, cwd and env, and whose server-side
+ * validation only checks `cols`/`rows`. The one case where this genuinely does
+ * add reach is a host whose node-pty probe failed — there `pty_task` is not
+ * advertised at all — which is why the capability is opt-out-able via
+ * `remote_exec: false` in the daemon's config.
+ *
+ * Commands are spawned without a shell: the caller sends argv, so nothing is
+ * re-parsed here. Callers that genuinely want a shell pass `-- bash -lc "..."`.
+ *
+ * @param {object} opts
+ * @param {typeof spawn} [opts.spawnFn]
+ * @param {string} [opts.defaultWorkspace] cwd used when the request omits one
+ */
+export function createRemoteExecHandlers(opts = {}) {
+  const spawnFn = opts.spawnFn || spawn;
+  const defaultWorkspace = opts.defaultWorkspace || resolveUserHome();
+  const runs = new Map();
+
+  async function exec(args = {}) {
+    // Start the clock before any I/O. The server's waiter starts ticking the
+    // moment it sends the request, and its only margin is a few seconds of
+    // slack; a slow `stat` on a stale network mount would otherwise let the
+    // server time out first, stranding a running child whose runId the caller
+    // never learned.
+    const waitMs = clampWaitMs(args.timeoutMs ?? args.timeout_ms);
+    const waitDeadline = Date.now() + waitMs;
+
+    const command = normalizeCommand(args.command);
+    if (!command) {
+      throw new Error("exec requires a `command` string");
+    }
+    const argv = normalizeArgv(args.args);
+    const running = countRunning(runs);
+    if (running >= MAX_CONCURRENT_RUNS) {
+      throw new Error(
+        `too many concurrent remote exec runs on this daemon (${running}/${MAX_CONCURRENT_RUNS}); cancel one first`,
+      );
+    }
+    const cwd = await resolveWorkspace(args.workspace ?? args.workspace_path, defaultWorkspace);
+    const env = buildExecEnv(args.env);
+
+    const runState = {
+      runId: randomUUID(),
+      command,
+      args: argv,
+      workspace: cwd,
+      status: "running",
+      pid: null,
+      exitCode: null,
+      signal: null,
+      stdoutTail: "",
+      stderrTail: "",
+      truncated: false,
+      error: null,
+      startedAt: new Date().toISOString(),
+      finishedAt: null,
+      settleWaiters: [],
+      child: null,
+      cancelRequested: false,
+      killTimer: null,
+    };
+    rememberRun(runs, runState);
+
+    let child;
+    try {
+      child = spawnFn(command, argv, {
+        cwd,
+        env,
+        stdio: ["ignore", "pipe", "pipe"],
+      });
+    } catch (error) {
+      finishRun(runState, "failed", { error: errMsg(error) });
+      return toPublicRun(runState);
+    }
+
+    runState.child = child;
+    runState.pid = typeof child.pid === "number" ? child.pid : null;
+
+    // Decode per stream: a multi-byte character can straddle two `data` chunks,
+    // and a naive String(chunk) would turn each half into U+FFFD.
+    const stdoutDecoder = new StringDecoder("utf8");
+    const stderrDecoder = new StringDecoder("utf8");
+    child.stdout?.on("data", (chunk) => {
+      runState.stdoutTail = appendTail(runState, runState.stdoutTail, stdoutDecoder.write(chunk));
+    });
+    child.stderr?.on("data", (chunk) => {
+      runState.stderrTail = appendTail(runState, runState.stderrTail, stderrDecoder.write(chunk));
+    });
+    child.on("error", (error) => {
+      finishRun(runState, "failed", { error: errMsg(error) });
+    });
+    child.on("close", (code, signal) => {
+      runState.stdoutTail = appendTail(runState, runState.stdoutTail, stdoutDecoder.end());
+      runState.stderrTail = appendTail(runState, runState.stderrTail, stderrDecoder.end());
+      const status = runState.cancelRequested ? "cancelled" : code === 0 ? "completed" : "failed";
+      finishRun(runState, status, {
+        exitCode: typeof code === "number" ? code : null,
+        signal: signal || null,
+      });
+    });
+
+    await waitForSettle(runState, Math.max(0, waitDeadline - Date.now()));
+    return toPublicRun(runState);
+  }
+
+  async function status(args = {}) {
+    return toPublicRun(mustFindRun(runs, args.runId));
+  }
+
+  async function cancel(args = {}) {
+    const runState = mustFindRun(runs, args.runId);
+    if (runState.status !== "running") {
+      return toPublicRun(runState);
+    }
+    runState.cancelRequested = true;
+    try {
+      runState.child?.kill("SIGTERM");
+    } catch (error) {
+      runState.error = runState.error || errMsg(error);
+    }
+    // Escalate if the child ignores SIGTERM. The timer is unref'd so it can
+    // never hold the daemon's event loop open.
+    runState.killTimer = setTimeout(() => {
+      try {
+        runState.child?.kill("SIGKILL");
+      } catch {
+        /* already gone */
+      }
+    }, KILL_GRACE_MS);
+    runState.killTimer.unref?.();
+
+    await waitForSettle(runState, KILL_GRACE_MS * 2);
+    return toPublicRun(runState);
+  }
+
+  /**
+   * Run a single action and return a `result` object, never throwing.
+   * @param {{action:string,args?:object}} payload
+   */
+  async function dispatch(payload) {
+    const action = payload?.action;
+    if (!VALID_ACTIONS.has(action)) {
+      return { error: `unknown action: ${action}` };
+    }
+    try {
+      switch (action) {
+        case "exec":
+          return { result: await exec(payload?.args ?? {}) };
+        case "status":
+          return { result: await status(payload?.args ?? {}) };
+        case "cancel":
+          return { result: await cancel(payload?.args ?? {}) };
+        default:
+          return { error: `unhandled action: ${action}` };
+      }
+    } catch (err) {
+      return { error: errMsg(err) };
+    }
+  }
+
+  return { dispatch, runs, defaultWorkspace };
+}
+
+/**
+ * @param {object} client
+ * @param {ReturnType<typeof createRemoteExecHandlers>} handlers
+ * @param {object} payload
+ */
+export async function handleRemoteExecRequest(client, handlers, payload) {
+  const requestId = payload?.request_id ? String(payload.request_id) : "";
+  const action = payload?.action ? String(payload.action) : "";
+  if (!requestId) {
+    return { error: "missing request_id" };
+  }
+
+  const response = await handlers.dispatch({
+    action,
+    args: payload?.args && typeof payload.args === "object" ? payload.args : {},
+  });
+
+  const outgoing = {
+    type: "remote_exec_response",
+    payload: {
+      request_id: requestId,
+      action,
+      ...(response?.error ? { error: response.error } : { result: response?.result }),
+    },
+  };
+  await client.sendJson(outgoing).catch(() => {});
+  return response;
+}
+
+function mustFindRun(runs, rawRunId) {
+  const runId = typeof rawRunId === "string" ? rawRunId.trim() : "";
+  if (!runId) {
+    throw new Error("this action requires a `runId` string");
+  }
+  const runState = runs.get(runId);
+  if (!runState) {
+    throw new Error(`remote exec run not found: ${runId}`);
+  }
+  return runState;
+}
+
+function countRunning(runs) {
+  let count = 0;
+  for (const entry of runs.values()) {
+    if (entry.status === "running") count += 1;
+  }
+  return count;
+}
+
+export function normalizeCommand(value) {
+  if (typeof value !== "string") {
+    return "";
+  }
+  const command = value.trim();
+  if (!command || command.includes(NUL)) {
+    return "";
+  }
+  return command;
+}
+
+export function normalizeArgv(value) {
+  if (value === undefined || value === null) {
+    return [];
+  }
+  if (!Array.isArray(value)) {
+    throw new Error("`args` must be an array of strings");
+  }
+  if (value.length > MAX_ARGS) {
+    throw new Error(`\`args\` must contain at most ${MAX_ARGS} entries`);
+  }
+  return value.map((entry) => {
+    if (typeof entry !== "string") {
+      throw new Error("`args` must contain only strings");
+    }
+    if (entry.includes(NUL)) {
+      throw new Error("`args` must not contain NUL bytes");
+    }
+    return entry;
+  });
+}
+
+export async function resolveWorkspace(value, fallback) {
+  const raw = typeof value === "string" ? value.trim() : "";
+  const target = raw ? expandHome(raw) : fallback;
+  const resolved = path.resolve(target);
+
+  let stat;
+  try {
+    stat = await fsp.stat(resolved);
+  } catch (error) {
+    if (error?.code === "ENOENT") {
+      throw new Error(`workspace does not exist: ${resolved}`);
+    }
+    throw error;
+  }
+  if (!stat.isDirectory()) {
+    throw new Error(`workspace is not a directory: ${resolved}`);
+  }
+  return resolved;
+}
+
+function expandHome(raw) {
+  if (raw === "~") {
+    return resolveUserHome();
+  }
+  if (raw.startsWith("~/")) {
+    return path.join(resolveUserHome(), raw.slice(2));
+  }
+  return raw;
+}
+
+export function clampWaitMs(value) {
+  const parsed = typeof value === "number" ? value : Number.parseInt(String(value ?? ""), 10);
+  if (!Number.isFinite(parsed) || parsed <= 0) {
+    return DEFAULT_WAIT_MS;
+  }
+  return Math.min(Math.trunc(parsed), MAX_WAIT_MS);
+}
+
+/**
+ * Inherit the daemon environment minus `CONDUCTOR_*`, matching what
+ * `custom_commands` does. This keeps the agent token out of the child's env; it
+ * is NOT a confidentiality guarantee — the token still sits in
+ * `~/.conductor/config.yaml`, which an arbitrary command can simply read. Do
+ * not build any security control on top of this.
+ */
+export function buildExecEnv(overrides) {
+  const env = { ...process.env };
+  for (const name of Object.keys(env)) {
+    if (name.startsWith("CONDUCTOR_")) {
+      delete env[name];
+    }
+  }
+  if (overrides && typeof overrides === "object" && !Array.isArray(overrides)) {
+    for (const [key, value] of Object.entries(overrides)) {
+      if (!key || key.includes("=") || key.includes(NUL)) {
+        throw new Error(`invalid env variable name: ${key}`);
+      }
+      if (typeof value !== "string" || value.includes(NUL)) {
+        throw new Error(`env variable ${key} must be a string`);
+      }
+      env[key] = value;
+    }
+  }
+  return env;
+}
+
+function waitForSettle(runState, waitMs) {
+  if (runState.status !== "running") {
+    return Promise.resolve();
+  }
+  return new Promise((resolve) => {
+    let settled = false;
+    const finish = () => {
+      if (settled) return;
+      settled = true;
+      clearTimeout(timer);
+      const index = runState.settleWaiters.indexOf(finish);
+      if (index >= 0) runState.settleWaiters.splice(index, 1);
+      resolve();
+    };
+    const timer = setTimeout(finish, waitMs);
+    timer.unref?.();
+    runState.settleWaiters.push(finish);
+  });
+}
+
+function rememberRun(runs, runState) {
+  runs.set(runState.runId, runState);
+  while (runs.size > MAX_RUNS) {
+    const oldest = [...runs.values()].find((entry) => entry.status !== "running")?.runId;
+    // Only finished runs are evictable, and `MAX_CONCURRENT_RUNS` bounds how
+    // many can be running at once, so the map cannot grow without limit.
+    if (!oldest) break;
+    runs.delete(oldest);
+  }
+}
+
+function finishRun(runState, status, updates = {}) {
+  if (runState.status !== "running") {
+    return;
+  }
+  runState.status = status;
+  runState.finishedAt = new Date().toISOString();
+  runState.exitCode = updates.exitCode ?? runState.exitCode;
+  runState.signal = updates.signal ?? runState.signal;
+  runState.error = updates.error ?? runState.error;
+  if (runState.killTimer) {
+    clearTimeout(runState.killTimer);
+    runState.killTimer = null;
+  }
+  runState.child = null;
+  for (const waiter of runState.settleWaiters.splice(0)) {
+    waiter();
+  }
+}
+
+function appendTail(runState, current, chunk) {
+  if (!chunk) {
+    return current;
+  }
+  const next = current + chunk;
+  if (next.length <= MAX_TAIL_CHARS) {
+    return next;
+  }
+  runState.truncated = true;
+  return next.slice(next.length - MAX_TAIL_CHARS);
+}
+
+function toPublicRun(runState) {
+  return {
+    runId: runState.runId,
+    command: runState.command,
+    args: runState.args,
+    workspace: runState.workspace,
+    status: runState.status,
+    pid: runState.pid,
+    exitCode: runState.exitCode,
+    signal: runState.signal,
+    error: runState.error,
+    startedAt: runState.startedAt,
+    finishedAt: runState.finishedAt,
+    stdoutTail: runState.stdoutTail,
+    stderrTail: runState.stderrTail,
+    truncated: runState.truncated,
+  };
+}
+
+function errMsg(err) {
+  return err?.message ?? String(err);
+}

package/src/runtime-backends.js

@@ -9,12 +9,13 @@ import { resolveConductorConfigPath } from "./conductor-paths.js";
 // CLI display order for built-in backends. ai-sdk owns the canonical set of
 // built-in backends; CLI just picks an ordering for "Supported Backends:" log
 // output. The self-check below ensures this list always matches ai-sdk's set.
-const BUILT_IN_RUNTIME_BACKENDS = ["codex", "claude", "kimi", "opencode", "copilot", "chat-web"];
+const BUILT_IN_RUNTIME_BACKENDS = ["codex", "claude", "kimi", "opencode", "copilot", "chat-web", "dsh"];
 const BUILT_IN_RUNTIME_BACKEND_SET = new Set(BUILT_IN_RUNTIME_BACKENDS);
 // Backends that don't shell out to a CLI binary AND should be advertised
-// without any user-side allow_cli_list entry. `copilot` is the only such
-// backend today — it ships with @github/copilot-sdk as a hard dep so
-// every install gets it for free.
+// without any user-side allow_cli_list entry. `copilot` ships with
+// @github/copilot-sdk as a hard dep so every install gets it for free;
+// `dsh` (DeepSeek Harness) ships its pinned runtime inside ai-sdk's own
+// dependencies and is spawned via @deepseek-ai/dsh-sdk-client.
 //
 // chat-web is intentionally NOT here even though it's also command-optional
 // (it drives a Chromium browser, not a CLI). The reason: chat-web has
@@ -23,7 +24,7 @@ const BUILT_IN_RUNTIME_BACKEND_SET = new Set(BUILT_IN_RUNTIME_BACKENDS);
 // aliases like `web-chatgpt` / `web-gemini` is just confusing — the alias
 // IS the sub-provider choice. Users who want chat-web must declare an
 // explicit allow_cli_list entry (which is also where `--model` lives).
-const COMMAND_OPTIONAL_BUILT_IN_RUNTIME_BACKENDS = ["copilot"];
+const COMMAND_OPTIONAL_BUILT_IN_RUNTIME_BACKENDS = ["copilot", "dsh"];
 const COMMAND_OPTIONAL_BUILT_IN_RUNTIME_BACKEND_SET = new Set(COMMAND_OPTIONAL_BUILT_IN_RUNTIME_BACKENDS);
 
 // Legacy aliases (e.g. "code" → "codex", "kimi-cli" → "kimi") are derived
@@ -365,6 +366,46 @@ function readConfigEnvValue(configFilePath, key) {
   }
 }
 
+// Read the top-level `disable_built_in_cli_list` config key: the mirror of
+// `allow_cli_list` for the command-optional built-in backends (copilot, dsh)
+// that are advertised WITHOUT any allow_cli_list entry. Listing a name here
+// suppresses that automatic advertising so an operator can opt out of a
+// built-in they don't want. Scoped to command-optional built-ins on purpose:
+// a stray external or PATH-CLI name (e.g. "codex") is a documented no-op,
+// since those never auto-advertise in the first place.
+function readDisabledBuiltInBackends(configFilePath) {
+  const targetPath = resolveConductorConfigPath(configFilePath);
+  try {
+    if (!targetPath || !fs.existsSync(targetPath)) {
+      return new Set();
+    }
+    const parsed = yaml.load(fs.readFileSync(targetPath, "utf8"));
+    const raw = parsed?.disable_built_in_cli_list;
+    if (!Array.isArray(raw)) {
+      return new Set();
+    }
+    return new Set(
+      raw
+        .map((value) => normalizeRuntimeBackendName(value))
+        .filter((value) => value && isCommandOptionalBuiltInRuntimeBackend(value)),
+    );
+  } catch {
+    return new Set();
+  }
+}
+
+// Reuse a caller-provided disabled set when present (so a hot loop reads the
+// config file once), else read it now. Keeps every call site one line.
+function resolveDisabledBuiltIns(options = {}) {
+  return options.disabledBuiltIns instanceof Set
+    ? options.disabledBuiltIns
+    : readDisabledBuiltInBackends(options.configFilePath);
+}
+
+export function isDisabledBuiltInRuntimeBackend(backend, options = {}) {
+  return resolveDisabledBuiltIns(options).has(normalizeRuntimeBackendName(backend));
+}
+
 function resolveProviderModulePaths(options = {}) {
   return [
     ...listProviderModulePaths(process.env.AISDK_PROVIDER_PATH),
@@ -576,6 +617,21 @@ export async function filterRuntimeSupportedAllowCliList(allowCliList, options =
 }
 
 export async function resolveConfiguredRuntimeBackend(backend, allowCliList, options = {}) {
+  const resolved = await resolveConfiguredRuntimeBackendInner(backend, allowCliList, options);
+  if (!resolved?.runtimeBackend) {
+    return resolved;
+  }
+  // A disabled command-optional built-in (copilot/dsh via
+  // `disable_built_in_cli_list`) is never resolvable, whether it reached here
+  // through an explicit allow_cli_list entry or the command-optional fallback.
+  const disabled = resolveDisabledBuiltIns(options);
+  if (disabled.has(resolved.runtimeBackend) || disabled.has(resolved.requestedBackend)) {
+    return null;
+  }
+  return resolved;
+}
+
+async function resolveConfiguredRuntimeBackendInner(backend, allowCliList, options = {}) {
   const normalizedBackend = normalizeRuntimeBackendName(backend);
   if (!normalizedBackend || LEGACY_RUNTIME_BACKEND_ALIASES.has(normalizedBackend)) {
     return null;
@@ -633,6 +689,9 @@ export async function listAdvertisedBackends(allowCliList, options = {}) {
         )
       : {};
   const configuredBackends = Object.keys(filteredAllowCliList);
+  // Read the disable list once and thread it through every per-backend
+  // resolve below, so this whole pass touches the config file a single time.
+  const resolveOptions = { ...options, disabledBuiltIns: readDisabledBuiltInBackends(options.configFilePath) };
   let runtimeBackends = [...BUILT_IN_RUNTIME_BACKENDS];
   let discoveryError = null;
   try {
@@ -646,7 +705,7 @@ export async function listAdvertisedBackends(allowCliList, options = {}) {
 
   for (const backend of configuredBackends) {
     try {
-      const configuredBackend = await resolveConfiguredRuntimeBackend(backend, filteredAllowCliList, options);
+      const configuredBackend = await resolveConfiguredRuntimeBackend(backend, filteredAllowCliList, resolveOptions);
       if (!configuredBackend?.runtimeBackend) {
         continue;
       }
@@ -682,7 +741,10 @@ export async function listAdvertisedBackends(allowCliList, options = {}) {
   }
 
   const commandOptionalBuiltIns = BUILT_IN_RUNTIME_BACKENDS.filter(
-    (backend) => isCommandOptionalBuiltInRuntimeBackend(backend) && !runtimeBackendMap[backend],
+    (backend) =>
+      isCommandOptionalBuiltInRuntimeBackend(backend) &&
+      !runtimeBackendMap[backend] &&
+      !resolveOptions.disabledBuiltIns.has(backend),
   );
   for (const backend of commandOptionalBuiltIns) {
     runtimeBackendMap[backend] = backend;

package/src/version-check.js

@@ -13,6 +13,7 @@ export const DEFAULT_HOMEBREW_FORMULA = "lovemoon-ai/tap/conductor";
 const DEFAULT_UPDATE_WINDOW = { startMinutes: 120, endMinutes: 240 };
 const REQUEST_TIMEOUT_MS = 10_000;
 const INSTALL_METHOD_FILENAME = ".install-method";
+const GLOBAL_PACKAGE_MARKER = `${path.sep}lib${path.sep}node_modules${path.sep}`;
 
 function resolveTimeoutMs(value) {
   const parsed = Number.parseInt(String(value ?? ""), 10);
@@ -139,6 +140,28 @@ export function resolveInstallMethod(options = {}) {
   }
 }
 
+/**
+ * Derive the npm global prefix that the currently running package was installed into.
+ *
+ * A global install always lands at `<prefix>/lib/node_modules/<package>`, so the prefix is
+ * whatever precedes that marker. Returns `null` for layouts that are not a global install
+ * (git checkout, project-local `node_modules`), where the caller should leave npm's own
+ * prefix resolution alone.
+ */
+export function resolveGlobalInstallPrefix(packageRoot) {
+  if (typeof packageRoot !== "string" || !packageRoot.trim()) {
+    return null;
+  }
+
+  const normalized = path.resolve(packageRoot);
+  const markerIndex = normalized.lastIndexOf(GLOBAL_PACKAGE_MARKER);
+  if (markerIndex <= 0) {
+    return null;
+  }
+
+  return normalized.slice(0, markerIndex);
+}
+
 export function buildUpgradeCommand(options = {}) {
   const installMethod = resolveInstallMethod(options);
   if (installMethod === "homebrew") {