@love-moon/conductor-cli 0.5.0 → 0.5.1

package/CHANGELOG.md

@@ -1,5 +1,29 @@
 # @love-moon/conductor-cli
 
+## 0.5.1
+
+### Patch Changes
+
+- 39a49fc: fix: reclaim orphaned chat-web browser and cap chat-web task lifetime
+
+  chat-web persists one Chromium profile per provider, guarded by a per-profile
+  SingletonLock. A task whose browser was not cleaned up (e.g. the ai-sdk worker
+  was SIGKILLed) left an orphaned Chromium holding that lock, so the next task for
+  the same provider failed to launch with `Opening in existing browser session`.
+
+  - chat-web now reclaims stale/orphaned profile locks before launching (kills an
+    orphan whose owner process is gone, clears dead locks) and refuses with a
+    clear `ProfileLockedError` when a genuine live chat still holds the profile.
+  - The ai-sdk worker now closes its session (and browser) on SIGTERM/SIGINT and
+    bounds the close so it can't hang, preventing browser leaks on shutdown.
+  - conductor fire caps a chat-web task's active lifetime (default 24h,
+    `CONDUCTOR_CHATWEB_MAX_ACTIVE_MS`) and auto-stops it as
+    `KILLED / max_active_duration`; chat history is preserved.
+
+- Updated dependencies [39a49fc]
+  - @love-moon/ai-sdk@0.5.1
+  - @love-moon/conductor-sdk@0.5.1
+
 ## 0.5.0
 
 ### Patch Changes

package/bin/conductor-fire.js

@@ -246,6 +246,18 @@ const DEFAULT_POLL_INTERVAL_MS = parseInt(
 const DEFAULT_ERROR_LOOP_WINDOW_MS = 2 * 60 * 1000;
 const DEFAULT_ERROR_LOOP_BACKOFF_MS = 3 * 60 * 1000;
 const DEFAULT_ERROR_LOOP_THRESHOLD = 3;
+// Runtime backend tokens (first word of the resolved command line) that mean
+// "this task drives a chat-web Chromium browser". Mirrors ai-sdk's chat-web
+// aliases; user-facing aliases like `web-chatgpt` resolve to one of these.
+const CHAT_WEB_RUNTIME_BACKEND_TOKENS = new Set(["chat-web", "chatweb", "chat_web", "web-chat"]);
+// Max active lifetime for a chat-web task before it is auto-stopped (default
+// 24h). Bounded to [1min, 7d]; override via CONDUCTOR_CHATWEB_MAX_ACTIVE_MS.
+const CHAT_WEB_MAX_ACTIVE_MS = getBoundedEnvInt(
+  "CONDUCTOR_CHATWEB_MAX_ACTIVE_MS",
+  24 * 60 * 60 * 1000,
+  60_000,
+  7 * 24 * 60 * 60 * 1000,
+);
 const SESSION_BOOTSTRAP_LOCK_TIMEOUT_MS = 15_000;
 const SESSION_BOOTSTRAP_LOCK_RETRY_MS = 50;
 const FIRE_WATCHDOG_INTERVAL_MS = getBoundedEnvInt(
@@ -866,6 +878,18 @@ async function main() {
       env: process.env,
     });
 
+    // chat-web tasks drive a real Chromium browser that holds a per-profile
+    // singleton lock for as long as the task lives. A task that never ends
+    // pins that browser indefinitely (and blocks other chats for the same
+    // provider), so we cap its active lifetime and auto-stop it when exceeded.
+    // The conversation itself is preserved (it lives in the provider account
+    // and the persisted profile; closing the browser does not delete it).
+    const runtimeBackendToken = String(sessionCommandLine || "")
+      .trim()
+      .split(/\s+/)[0]
+      ?.toLowerCase() || "";
+    const isChatWebTask = CHAT_WEB_RUNTIME_BACKEND_TOKENS.has(runtimeBackendToken);
+
     log(`Using backend: ${cliArgs.backend}`);
 
     try {
@@ -880,6 +904,7 @@ async function main() {
 
     const signals = new AbortController();
     let shutdownSignal = null;
+    let autoStopReason = null;
     let backendShutdownRequested = false;
     const requestBackendShutdown = (source) => {
       if (backendShutdownRequested) {
@@ -911,6 +936,27 @@ async function main() {
     process.on("SIGINT", onSigint);
     process.on("SIGTERM", onSigterm);
 
+    // Cap the active lifetime of chat-web tasks (default 24h). On expiry we
+    // stop the task gracefully — abort the runner and close the backend
+    // session so the Chromium browser is released — and mark it KILLED with a
+    // max_active_duration reason. Chat history is retained on the provider side.
+    let maxActiveTimer = null;
+    if (isChatWebTask) {
+      maxActiveTimer = setTimeout(() => {
+        log(
+          `chat-web task exceeded max active duration (${CHAT_WEB_MAX_ACTIVE_MS}ms); ` +
+            `auto-stopping task (chat history is preserved).`,
+        );
+        autoStopReason = "max_active_duration";
+        fireShuttingDown = true;
+        signals.abort();
+        requestBackendShutdown("max_active_duration");
+      }, CHAT_WEB_MAX_ACTIVE_MS);
+      if (typeof maxActiveTimer.unref === "function") {
+        maxActiveTimer.unref();
+      }
+    }
+
     if (shouldFireReportTaskStatus({ launchedByDaemon, phase: "running" })) {
       try {
         await conductor.sendTaskStatus(taskContext.taskId, {
@@ -1030,7 +1076,12 @@ async function main() {
           // SDK durable outbox would retry forever, preventing the process from
           // exiting.
           const taskDeletedByUser = remoteStopReason === "deleted_by_user";
-          const finalStatus = shutdownSignal
+          const finalStatus = autoStopReason
+            ? {
+                status: "KILLED",
+                summary: `${autoStopReason}: chat-web task exceeded its max active duration`,
+              }
+            : shutdownSignal
             ? {
                 status: "KILLED",
                 summary: `terminated by ${shutdownSignal}`,
@@ -1079,6 +1130,9 @@ async function main() {
     } finally {
       process.off("SIGINT", onSigint);
       process.off("SIGTERM", onSigterm);
+      if (maxActiveTimer) {
+        clearTimeout(maxActiveTimer);
+      }
       if (shutdownSignal === "SIGINT") {
         process.exitCode = 130;
       } else if (shutdownSignal === "SIGTERM") {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@love-moon/conductor-cli",
-  "version": "0.5.0",
-  "gitCommitId": "7f50aa7",
+  "version": "0.5.1",
+  "gitCommitId": "119eab6",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/lovemoon-ai/conductor.git"
@@ -23,8 +23,8 @@
     "test": "node --test test/*.test.js"
   },
   "dependencies": {
-    "@love-moon/ai-sdk": "0.5.0",
-    "@love-moon/conductor-sdk": "0.5.0",
+    "@love-moon/ai-sdk": "0.5.1",
+    "@love-moon/conductor-sdk": "0.5.1",
     "@github/copilot-sdk": "^0.3.0",
     "chrome-launcher": "^1.2.1",
     "chrome-remote-interface": "^0.33.0",
@@ -37,7 +37,7 @@
   },
   "optionalDependencies": {
     "@roamhq/wrtc": "^0.10.0",
-    "@love-moon/chat-web": "0.5.0"
+    "@love-moon/chat-web": "0.5.1"
   },
   "pnpm": {
     "onlyBuiltDependencies": [

package/src/daemon.js

@@ -28,6 +28,7 @@ import {
   listAdvertisedBackends,
   resolveConfiguredRuntimeBackend,
   isBuiltInRuntimeBackend,
+  isCommandOptionalBuiltInRuntimeBackend,
   isRuntimeSupportedBackend,
   normalizeRuntimeBackendAlias,
   normalizeRuntimeBackendName,
@@ -5055,7 +5056,8 @@ export function startDaemon(config = {}, deps = {}) {
       const isAllowedExternalBackend =
         !isBuiltInRuntimeBackend(effectiveBackend) &&
         await isRuntimeSupportedBackend(effectiveBackend, { configFilePath: config.CONFIG_FILE });
-      if (!isAdvertisedBackend || (!hasConfiguredEntry && !isAllowedExternalBackend)) {
+      const isCommandOptionalBuiltIn = isCommandOptionalBuiltInRuntimeBackend(effectiveBackend);
+      if (!isAdvertisedBackend || (!hasConfiguredEntry && !isAllowedExternalBackend && !isCommandOptionalBuiltIn)) {
         logError(`Unsupported backend: ${selectedBackend}. Supported: ${SUPPORTED_BACKENDS.join(", ")}`);
         sendAgentCommandAck({
           requestId,
@@ -5526,7 +5528,8 @@ export function startDaemon(config = {}, deps = {}) {
     const isAllowedExternalBackend =
       !isBuiltInRuntimeBackend(effectiveBackend) &&
       await isRuntimeSupportedBackend(effectiveBackend, { configFilePath: config.CONFIG_FILE });
-    if (!isAdvertisedBackend || (!hasConfiguredEntry && !isAllowedExternalBackend)) {
+    const isCommandOptionalBuiltIn = isCommandOptionalBuiltInRuntimeBackend(effectiveBackend);
+    if (!isAdvertisedBackend || (!hasConfiguredEntry && !isAllowedExternalBackend && !isCommandOptionalBuiltIn)) {
       reportRestartFailure({
         taskId: normalizedTargetTaskId,
         projectId: normalizedProjectId,