@loucompanion/forge-bridge 0.1.1-dev.ac486debe210 → 0.1.1-dev.ac656b52f9c6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -1,17 +1,60 @@
1
1
  import crypto from "node:crypto";
2
2
  import fs from "node:fs/promises";
3
+ import os from "node:os";
3
4
  import path from "node:path";
4
5
  import { execFile, spawn } from "node:child_process";
5
6
  import readline from "node:readline";
6
7
  import { promisify } from "node:util";
7
8
  import { GitClient } from "../../shared/git/git.js";
8
9
  import { resolveCursorAgentDirectLaunch } from "../../shared/cursor-agent/cursor-agent.launch.js";
10
+ import { ensureNoSymbolicLinkPathSegments, isPathUnderRoot, sha256File } from "../qa-sidecar-validation.js";
9
11
  import { buildSpecBody, selectLaneCommand } from "../../worktree/artifact-injector.js";
10
- import { codexMcpConfigArgs, completionPhaseFromDispatch, completionPromptForDevelopCycle, completionPromptForPhase, completionRedactionEnv, expectedCompletionToolName, prepareCompletionToolRuntime, readCompletionArtifact, usesDevelopCycleCompletion, writeCompletionArtifact, artifactRootFor } from "../phase-completion.js";
12
+ import { codexMcpConfigArgs, completionPhaseFromDispatch, completionPromptForDebugCycle, completionPromptForDevelopCycle, completionPromptForPhase, completionPromptForQaCycle, completionRedactionEnv, expectedCompletionToolName, expectedDebugCompletionToolName, expectedQaCompletionToolName, prepareCompletionToolRuntime, readCompletionArtifact, usesDebugCycleCompletion, usesDevelopCycleCompletion, writeCompletionArtifact, artifactRootFor, artifactRootForOwner, debugCompletionPhaseOrder, qaCompletionGateOrder } from "../phase-completion.js";
11
13
  import { addUsage, buildProviderUsageEvent, emptyUsage, hasUsage, readUsageNumber } from "./provider-usage.js";
12
14
  const fakeWorkerModel = "server-local-fake-worker";
13
15
  const execFileAsync = promisify(execFile);
14
16
  const developCyclePhaseOrder = ["implementation", "self_review", "validation"];
17
+ const allowedProviderParentEnvNames = [
18
+ "PATH",
19
+ "HOME",
20
+ "USERPROFILE",
21
+ "TMPDIR",
22
+ "TEMP",
23
+ "TMP",
24
+ "LANG"
25
+ ];
26
+ const windowsAllowedProviderParentEnvNames = [
27
+ "SystemRoot",
28
+ "ComSpec",
29
+ "PATHEXT",
30
+ "APPDATA",
31
+ "LOCALAPPDATA"
32
+ ];
33
+ function buildProviderChildEnvironment(requestEnv) {
34
+ const env = {};
35
+ for (const [key, value] of Object.entries(process.env)) {
36
+ if (typeof value === "string" && isAllowedProviderParentEnv(key)) {
37
+ env[key] = value;
38
+ }
39
+ }
40
+ if (requestEnv) {
41
+ for (const [key, value] of Object.entries(requestEnv)) {
42
+ const trimmedKey = key.trim();
43
+ if (trimmedKey.length > 0) {
44
+ env[trimmedKey] = value;
45
+ }
46
+ }
47
+ }
48
+ return env;
49
+ }
50
+ function isAllowedProviderParentEnv(key) {
51
+ return isAllowedProviderParentEnvName(key, allowedProviderParentEnvNames)
52
+ || key.toUpperCase().startsWith("LC_")
53
+ || (process.platform === "win32" && isAllowedProviderParentEnvName(key, windowsAllowedProviderParentEnvNames));
54
+ }
55
+ function isAllowedProviderParentEnvName(key, allowedNames) {
56
+ return allowedNames.some((allowed) => allowed.toLowerCase() === key.toLowerCase());
57
+ }
15
58
  export class RoutingProviderCliService {
16
59
  realProvider;
17
60
  deterministicProvider;
@@ -24,6 +67,11 @@ export class RoutingProviderCliService {
24
67
  ? await this.deterministicProvider.runImplementation(context)
25
68
  : await this.realProvider.runImplementation(context);
26
69
  }
70
+ async runArchitect(context) {
71
+ return isFakeWorkerModel(context.dispatch.execution.model)
72
+ ? await this.deterministicProvider.runArchitect(context)
73
+ : await this.realProvider.runArchitect(context);
74
+ }
27
75
  async runConflictResolve(context) {
28
76
  return isFakeWorkerModel(context.dispatch.execution.model)
29
77
  ? await this.deterministicProvider.runConflictResolve(context)
@@ -34,6 +82,11 @@ export class RoutingProviderCliService {
34
82
  ? await this.deterministicProvider.runQa(context)
35
83
  : await this.realProvider.runQa(context);
36
84
  }
85
+ async runDraft(context) {
86
+ return isFakeWorkerModel(context.dispatch.execution.model)
87
+ ? await this.deterministicProvider.runDraft(context)
88
+ : await this.realProvider.runDraft(context);
89
+ }
37
90
  }
38
91
  export class ProcessBackedProviderCliService {
39
92
  processRunner;
@@ -42,10 +95,65 @@ export class ProcessBackedProviderCliService {
42
95
  this.processRunner = processRunner;
43
96
  this.git = git;
44
97
  }
98
+ async runDraft(context) {
99
+ const { dispatch } = context;
100
+ if (!dispatch.draft) {
101
+ throw new Error("Draft dispatch context is missing.");
102
+ }
103
+ const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), "forge-bridge-draft-"));
104
+ const command = buildProviderCliCommand(dispatch, {
105
+ worktreePath: tempDir,
106
+ prompt: buildDraftPrompt(dispatch),
107
+ skipGitRepoCheck: true
108
+ });
109
+ await context.emit({
110
+ role: "runner",
111
+ kind: "checkpoint",
112
+ content: `Starting provider CLI Draft: ${formatProviderCliCommand(command)}`,
113
+ eventType: "provider_cli_started"
114
+ });
115
+ const outputState = createProviderOutputState(dispatch.execution.provider);
116
+ try {
117
+ const result = await this.processRunner.run({
118
+ command: command.command,
119
+ args: command.args,
120
+ cwd: tempDir,
121
+ env: providerProcessEnv(dispatch)
122
+ }, {
123
+ onStdoutLine: async (line) => {
124
+ for (const event of outputState.consume(line)) {
125
+ await context.emit(event);
126
+ }
127
+ }
128
+ }, context.signal);
129
+ if (result.exitCode !== 0) {
130
+ throw new Error(`Provider CLI exited with code ${result.exitCode}${summarizeStderr(result.stderr)}.`);
131
+ }
132
+ const content = outputState.finalMessage ?? result.stdout.trim();
133
+ if (!content) {
134
+ throw new Error("Provider CLI completed without returning a draft.");
135
+ }
136
+ const json = extractJsonObject(content);
137
+ await context.emit({
138
+ role: "assistant",
139
+ kind: "message",
140
+ content: json,
141
+ eventType: "draft_complete"
142
+ });
143
+ await emitProviderUsageEvent(context.emit, dispatch, outputState);
144
+ return {
145
+ summary: "Draft generated through Forge Runner."
146
+ };
147
+ }
148
+ finally {
149
+ await fs.rm(tempDir, { recursive: true, force: true });
150
+ }
151
+ }
45
152
  async runImplementation(context) {
46
153
  const { dispatch, worktree } = context;
47
154
  const phase = completionPhaseFromDispatch(dispatch);
48
155
  const developCycle = usesDevelopCycleCompletion(dispatch);
156
+ const debugCycle = usesDebugCycleCompletion(dispatch);
49
157
  const metadataRoot = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id);
50
158
  await fs.mkdir(metadataRoot, { recursive: true });
51
159
  const laneCommand = selectLaneCommand(dispatch.artifacts, dispatch.execution.lane, dispatch.cycleRun.phase);
@@ -59,7 +167,11 @@ export class ProcessBackedProviderCliService {
59
167
  const completionTools = await prepareCompletionToolRuntime({ dispatch, worktree, phase });
60
168
  const command = buildProviderCliCommand(dispatch, {
61
169
  worktreePath: worktree.worktreePath,
62
- prompt: developCycle ? buildDevelopCyclePrompt(dispatch, phase) : buildImplementationPrompt(dispatch, phase),
170
+ prompt: debugCycle
171
+ ? buildDebugCyclePrompt(dispatch, phase)
172
+ : developCycle
173
+ ? buildDevelopCyclePrompt(dispatch, phase)
174
+ : buildImplementationPrompt(dispatch, phase),
63
175
  completionTools
64
176
  });
65
177
  await context.emit({
@@ -71,13 +183,15 @@ export class ProcessBackedProviderCliService {
71
183
  await context.emit({
72
184
  role: "runner",
73
185
  kind: "checkpoint",
74
- content: developCycle
75
- ? "Forge completion tools configured for implementation -> self_review -> validation; provider must call each MCP completion tool before exit."
76
- : `Forge completion tools configured for ${phase}; provider must call the MCP completion tool before exit.`,
186
+ content: debugCycle
187
+ ? "Forge Debug completion tools configured for debug_repro -> debug_root_cause -> debug_fix -> debug_regression; provider must call each MCP completion tool before exit."
188
+ : developCycle
189
+ ? "Forge completion tools configured for implementation -> self_review -> validation; provider must call each MCP completion tool before exit."
190
+ : `Forge completion tools configured for ${phase}; provider must call the MCP completion tool before exit.`,
77
191
  eventType: "completion_tools_configured"
78
192
  });
79
193
  const outputState = createProviderOutputState(dispatch.execution.provider);
80
- const liveCompletionEvents = new LiveCompletionArtifactEmitter(worktree.worktreePath, dispatch.workItem.id, phase, developCycle, context.emit);
194
+ const liveCompletionEvents = new LiveCompletionArtifactEmitter(worktree.worktreePath, dispatch.workItem.id, phase, developCycle, debugCycle, context.emit);
81
195
  let result;
82
196
  try {
83
197
  liveCompletionEvents.start();
@@ -85,11 +199,10 @@ export class ProcessBackedProviderCliService {
85
199
  command: command.command,
86
200
  args: command.args,
87
201
  cwd: worktree.worktreePath,
88
- env: providerRedactionEnv(dispatch)
202
+ env: providerProcessEnv(dispatch)
89
203
  }, {
90
204
  onStdoutLine: async (line) => {
91
- const event = outputState.consume(line);
92
- if (event) {
205
+ for (const event of outputState.consume(line)) {
93
206
  await context.emit(event);
94
207
  }
95
208
  }
@@ -111,7 +224,7 @@ export class ProcessBackedProviderCliService {
111
224
  });
112
225
  await emitProviderUsageEvent(context.emit, dispatch, outputState);
113
226
  const committed = await commitWorktreeChanges(this.git, worktree.worktreePath, dispatch.workItem.id);
114
- const completionArtifacts = await readCompletionArtifactsForRun(worktree.worktreePath, dispatch.workItem.id, phase, developCycle);
227
+ const completionArtifacts = await readCompletionArtifactsForRun(worktree.worktreePath, dispatch.workItem.id, phase, developCycle, debugCycle);
115
228
  for (const artifact of completionArtifacts) {
116
229
  if (!liveCompletionEvents.hasEmitted(completionPhaseFromArtifact(artifact))) {
117
230
  await emitCompletionArtifactRecorded(context.emit, worktree.worktreePath, artifact);
@@ -137,7 +250,7 @@ export class ProcessBackedProviderCliService {
137
250
  });
138
251
  }
139
252
  return {
140
- summary: `${dispatch.execution.provider} CLI completed ${worktree.branchName} (${developCycle ? "develop cycle" : phase}, ${committed.commitSha.slice(0, 12)}).`,
253
+ summary: `${dispatch.execution.provider} CLI completed ${worktree.branchName} (${debugCycle ? "debug cycle" : developCycle ? "develop cycle" : phase}, ${committed.commitSha.slice(0, 12)}).`,
141
254
  spec: {
142
255
  repoPath: worktree.worktreePath,
143
256
  path: specPath,
@@ -149,11 +262,106 @@ export class ProcessBackedProviderCliService {
149
262
  artifacts: completionArtifacts
150
263
  };
151
264
  }
265
+ async runArchitect(context) {
266
+ const { dispatch, worktree } = context;
267
+ const completionTools = await prepareCompletionToolRuntime({ dispatch, worktree, phase: "architect" });
268
+ const command = buildProviderCliCommand(dispatch, {
269
+ worktreePath: worktree.worktreePath,
270
+ prompt: buildArchitectPrompt(dispatch),
271
+ completionTools
272
+ });
273
+ const commandText = formatProviderCliCommand(command);
274
+ await context.emit({
275
+ role: "runner",
276
+ kind: "checkpoint",
277
+ content: `Starting provider CLI Architect: ${commandText} in ${worktree.worktreePath}`,
278
+ eventType: "provider_cli_started"
279
+ });
280
+ await context.emit({
281
+ role: "runner",
282
+ kind: "checkpoint",
283
+ content: "Forge Architect completion tools configured; provider must call forge.complete_architect_plan before exit.",
284
+ eventType: "completion_tools_configured"
285
+ });
286
+ const outputState = createProviderOutputState(dispatch.execution.provider);
287
+ const liveArchitectEvents = new LiveArchitectArtifactEmitter(worktree.worktreePath, dispatch.workItem.id, context.emit);
288
+ let result;
289
+ try {
290
+ liveArchitectEvents.start();
291
+ result = await this.processRunner.run({
292
+ command: command.command,
293
+ args: command.args,
294
+ cwd: worktree.worktreePath,
295
+ env: providerProcessEnv(dispatch)
296
+ }, {
297
+ onStdoutLine: async (line) => {
298
+ for (const event of outputState.consume(line)) {
299
+ await context.emit(event);
300
+ }
301
+ }
302
+ }, context.signal);
303
+ }
304
+ finally {
305
+ await liveArchitectEvents.stop();
306
+ await cleanupCompletionTools(completionTools, context.emit);
307
+ }
308
+ if (result.exitCode !== 0) {
309
+ const stderr = clip(result.stderr.trim() || result.stdout.trim(), 1200);
310
+ throw new Error(`${command.command} exited ${result.exitCode}${stderr ? `: ${stderr}` : ""}`);
311
+ }
312
+ await context.emit({
313
+ role: "runner",
314
+ kind: "checkpoint",
315
+ content: `Provider CLI Architect completed: ${command.command} exit ${result.exitCode}${outputState.sessionLabel ? ` ${outputState.sessionLabel}` : ""}.`,
316
+ eventType: "provider_cli_completed"
317
+ });
318
+ await emitProviderUsageEvent(context.emit, dispatch, outputState);
319
+ const architectArtifact = await readCompletionArtifact(worktree.worktreePath, dispatch.workItem.id, "architect");
320
+ if (!architectArtifact) {
321
+ throw new Error("Provider CLI Architect completed but did not call the Forge Architect completion tool.");
322
+ }
323
+ if (!liveArchitectEvents.hasEmitted()) {
324
+ await emitCompletionArtifactRecorded(context.emit, worktree.worktreePath, architectArtifact);
325
+ await emitArchitectStructuredEvents(context.emit, worktree.worktreePath, dispatch.workItem.id, architectArtifact);
326
+ }
327
+ await context.emit({
328
+ role: "assistant",
329
+ kind: "message",
330
+ content: outputState.finalMessage || `${dispatch.execution.provider} CLI produced an Architect plan for ${worktree.branchName}.`,
331
+ eventType: "architect_complete"
332
+ });
333
+ const specPath = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id, "spec.md");
334
+ const specBody = await fs.readFile(specPath, "utf8").catch(() => `# ${dispatch.workItem.title}\n\nArchitect plan pending approval.\n`);
335
+ return {
336
+ summary: `${dispatch.execution.provider} CLI Architect plan produced.`,
337
+ spec: {
338
+ repoPath: worktree.worktreePath,
339
+ path: specPath,
340
+ body: specBody,
341
+ producedBy: `${dispatch.execution.provider}-cli`,
342
+ status: "pending_approval"
343
+ },
344
+ artifact: architectArtifact,
345
+ artifacts: [architectArtifact]
346
+ };
347
+ }
152
348
  async runQa(context) {
153
349
  const { dispatch, worktree } = context;
350
+ const metadataRoot = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id);
351
+ await fs.mkdir(metadataRoot, { recursive: true });
352
+ const laneCommand = selectLaneCommand(dispatch.artifacts, dispatch.execution.lane, dispatch.cycleRun.phase);
353
+ if (!laneCommand) {
354
+ throw new Error(`Lane command for lane '${dispatch.execution.lane}' phase '${dispatch.cycleRun.phase}' was not resolved.`);
355
+ }
356
+ const specBody = buildSpecBody(laneCommand, dispatch.workItem, "qa");
357
+ const specPath = path.join(metadataRoot, "spec.md");
358
+ await fs.writeFile(specPath, specBody, "utf8");
359
+ await fs.writeFile(path.join(metadataRoot, "spec.meta.json"), JSON.stringify({ schema_version: 1, status: "approved", produced_by: "forge-lane-command" }) + "\n", "utf8");
360
+ const completionTools = await prepareCompletionToolRuntime({ dispatch, worktree, phase: "qa" });
154
361
  const command = buildProviderCliCommand(dispatch, {
155
362
  worktreePath: worktree.worktreePath,
156
- prompt: buildQaPrompt(dispatch)
363
+ prompt: buildQaPrompt(dispatch, specBody),
364
+ completionTools
157
365
  });
158
366
  const commandText = formatProviderCliCommand(command);
159
367
  await context.emit({
@@ -162,20 +370,34 @@ export class ProcessBackedProviderCliService {
162
370
  content: `Starting provider CLI QA: ${commandText} in ${worktree.worktreePath}`,
163
371
  eventType: "provider_cli_started"
164
372
  });
373
+ await context.emit({
374
+ role: "runner",
375
+ kind: "checkpoint",
376
+ content: "Forge QA completion tools configured; provider must call all seven QA MCP gates before exit.",
377
+ eventType: "completion_tools_configured"
378
+ });
165
379
  const outputState = createProviderOutputState(dispatch.execution.provider);
166
- const result = await this.processRunner.run({
167
- command: command.command,
168
- args: command.args,
169
- cwd: worktree.worktreePath,
170
- env: providerRedactionEnv(dispatch)
171
- }, {
172
- onStdoutLine: async (line) => {
173
- const event = outputState.consume(line);
174
- if (event) {
175
- await context.emit(event);
380
+ const liveQaEvents = new LiveQaArtifactEmitter(worktree.worktreePath, dispatch.workItem.id, dispatch, context.emit);
381
+ let result;
382
+ try {
383
+ liveQaEvents.start();
384
+ result = await this.processRunner.run({
385
+ command: command.command,
386
+ args: command.args,
387
+ cwd: worktree.worktreePath,
388
+ env: providerProcessEnv(dispatch)
389
+ }, {
390
+ onStdoutLine: async (line) => {
391
+ for (const event of outputState.consume(line)) {
392
+ await context.emit(event);
393
+ }
176
394
  }
177
- }
178
- }, context.signal);
395
+ }, context.signal);
396
+ }
397
+ finally {
398
+ await liveQaEvents.stop();
399
+ await cleanupCompletionTools(completionTools, context.emit);
400
+ }
179
401
  if (result.exitCode !== 0) {
180
402
  const stderr = clip(result.stderr.trim() || result.stdout.trim(), 1200);
181
403
  throw new Error(`${command.command} exited ${result.exitCode}${stderr ? `: ${stderr}` : ""}`);
@@ -187,45 +409,61 @@ export class ProcessBackedProviderCliService {
187
409
  eventType: "provider_cli_completed"
188
410
  });
189
411
  await emitProviderUsageEvent(context.emit, dispatch, outputState);
190
- const summary = outputState.finalMessage || `${dispatch.execution.provider} CLI QA passed.`;
191
- const qaArtifact = await writeQaArtifacts({
192
- worktreePath: worktree.worktreePath,
193
- workItemId: dispatch.workItem.id,
194
- acceptanceCriteria: dispatch.workItem.acceptanceCriteria,
195
- producedBy: `${dispatch.execution.provider}-cli`,
196
- provider: dispatch.execution.provider,
197
- model: dispatch.execution.model,
198
- command: commandText,
199
- summary
200
- });
201
- await emitQaArtifactRecorded(context.emit, worktree.worktreePath, qaArtifact);
412
+ const qaArtifact = await readQaCompletionArtifactBundle(worktree.worktreePath, dispatch.workItem.id, dispatch.cycleRun.ownerType, dispatch.cycleRun.ownerId);
413
+ if (!qaArtifact) {
414
+ const verdictOnly = await readCompletionArtifact(worktree.worktreePath, dispatch.workItem.id, "qa");
415
+ throw new Error(verdictOnly
416
+ ? "Provider CLI QA completed but did not produce the complete durable QA artifact bundle."
417
+ : "Provider CLI QA completed but did not call the Forge QA completion tool.");
418
+ }
419
+ enforceQaBrowserLaunchTargetGate(dispatch, qaArtifact);
420
+ if (!liveQaEvents.hasEmitted()) {
421
+ await emitQaArtifactRecorded(context.emit, worktree.worktreePath, qaArtifact);
422
+ await emitQaStructuredEvents(context.emit, qaArtifact);
423
+ }
424
+ const status = (qaArtifact.status ?? "unknown").trim().toLowerCase();
425
+ const statusSummary = status === "pass"
426
+ ? "passed"
427
+ : status === "blocked"
428
+ ? "blocked"
429
+ : "found rework";
202
430
  return {
203
- summary: `${dispatch.execution.provider} CLI QA passed.`,
431
+ summary: `${dispatch.execution.provider} CLI QA ${statusSummary}.`,
432
+ spec: {
433
+ repoPath: worktree.worktreePath,
434
+ path: specPath,
435
+ body: specBody,
436
+ producedBy: "forge-lane-command",
437
+ status: "approved"
438
+ },
204
439
  artifact: qaArtifact,
205
440
  artifacts: [qaArtifact]
206
441
  };
207
442
  }
208
443
  async runConflictResolve(context) {
209
444
  const { dispatch, worktree } = context;
445
+ const addressComments = isPullRequestCommentsDispatch(dispatch);
210
446
  const command = buildProviderCliCommand(dispatch, {
211
447
  worktreePath: worktree.worktreePath,
212
- prompt: buildConflictResolvePrompt(dispatch, worktree.branchName)
448
+ prompt: addressComments
449
+ ? buildPullRequestCommentsPrompt(dispatch, worktree.branchName)
450
+ : buildConflictResolvePrompt(dispatch, worktree.branchName)
213
451
  });
214
452
  await context.emit({
215
453
  role: "runner",
216
454
  kind: "checkpoint",
217
- content: `Starting provider CLI conflict resolve: ${formatProviderCliCommand(command)} in ${worktree.worktreePath}`,
455
+ content: `Starting provider CLI ${addressComments ? "PR comment address" : "conflict resolve"}: ${formatProviderCliCommand(command)} in ${worktree.worktreePath}`,
218
456
  eventType: "provider_cli_started"
219
457
  });
220
458
  const outputState = createProviderOutputState(dispatch.execution.provider);
221
459
  const result = await this.processRunner.run({
222
460
  command: command.command,
223
461
  args: command.args,
224
- cwd: worktree.worktreePath
462
+ cwd: worktree.worktreePath,
463
+ env: providerProcessEnv(dispatch)
225
464
  }, {
226
465
  onStdoutLine: async (line) => {
227
- const event = outputState.consume(line);
228
- if (event) {
466
+ for (const event of outputState.consume(line)) {
229
467
  await context.emit(event);
230
468
  }
231
469
  }
@@ -240,11 +478,15 @@ export class ProcessBackedProviderCliService {
240
478
  await context.emit({
241
479
  role: "assistant",
242
480
  kind: "message",
243
- content: outputState.finalMessage || `${dispatch.execution.provider} CLI resolved merge conflicts for ${worktree.branchName}.`,
244
- eventType: "conflict_resolve_complete"
481
+ content: outputState.finalMessage || (addressComments
482
+ ? `${dispatch.execution.provider} CLI addressed pull request comments for ${worktree.branchName}.`
483
+ : `${dispatch.execution.provider} CLI resolved merge conflicts for ${worktree.branchName}.`),
484
+ eventType: addressComments ? "pr_comments_complete" : "conflict_resolve_complete"
245
485
  });
246
486
  return {
247
- summary: `${dispatch.execution.provider} CLI resolved conflicts on ${worktree.branchName} (${committed.commitSha.slice(0, 12)}).`
487
+ summary: addressComments
488
+ ? `${dispatch.execution.provider} CLI addressed PR comments on ${worktree.branchName} (${committed.commitSha.slice(0, 12)}).`
489
+ : `${dispatch.execution.provider} CLI resolved conflicts on ${worktree.branchName} (${committed.commitSha.slice(0, 12)}).`
248
490
  };
249
491
  }
250
492
  }
@@ -253,10 +495,22 @@ export class DeterministicProviderCliService {
253
495
  constructor(git = new GitClient()) {
254
496
  this.git = git;
255
497
  }
498
+ async runDraft(context) {
499
+ const content = JSON.stringify(deterministicDraftPayload(context.dispatch));
500
+ await context.emit({
501
+ role: "assistant",
502
+ kind: "message",
503
+ content,
504
+ eventType: "draft_complete"
505
+ });
506
+ await context.emit(buildProviderUsageEvent(context.dispatch, estimatedDeterministicUsage()));
507
+ return { summary: "forge-bridge generated deterministic draft." };
508
+ }
256
509
  async runImplementation(context) {
257
510
  const { dispatch, worktree } = context;
258
511
  const phase = completionPhaseFromDispatch(dispatch);
259
512
  const developCycle = usesDevelopCycleCompletion(dispatch);
513
+ const debugCycle = usesDebugCycleCompletion(dispatch);
260
514
  const providerCommand = buildProviderCliCommand(dispatch);
261
515
  const providerCommandText = formatProviderCliCommand(providerCommand);
262
516
  const metadataRoot = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id);
@@ -287,9 +541,11 @@ export class DeterministicProviderCliService {
287
541
  content: `Created bridge changeset at ${changesetPath}`,
288
542
  eventType: "changeset"
289
543
  });
290
- const phases = developCycle
291
- ? ["implementation", "self_review", "validation"]
292
- : [phase];
544
+ const phases = debugCycle
545
+ ? debugCompletionPhaseOrder
546
+ : developCycle
547
+ ? ["implementation", "self_review", "validation"]
548
+ : [phase];
293
549
  const completionArtifacts = [];
294
550
  for (const completionPhase of phases) {
295
551
  await writeCompletionArtifact({
@@ -298,7 +554,9 @@ export class DeterministicProviderCliService {
298
554
  phase: completionPhase,
299
555
  producedBy: "forge-bridge",
300
556
  redactionSecrets: exactRedactionSecrets(dispatch)
301
- }, expectedCompletionToolName(completionPhase), deterministicCompletionPayload(completionPhase, dispatch, changesetBody));
557
+ }, isDebugCompletionPhaseForProvider(completionPhase)
558
+ ? expectedDebugCompletionToolName(completionPhase)
559
+ : expectedCompletionToolName(completionPhase), deterministicCompletionPayload(completionPhase, dispatch, changesetBody));
302
560
  const completionArtifact = await readCompletionArtifact(worktree.worktreePath, dispatch.workItem.id, completionPhase);
303
561
  if (!completionArtifact) {
304
562
  throw new Error(`Deterministic provider did not produce the Forge ${completionPhase} completion artifact.`);
@@ -314,7 +572,7 @@ export class DeterministicProviderCliService {
314
572
  }
315
573
  await context.emit(buildProviderUsageEvent(dispatch, estimatedDeterministicUsage()));
316
574
  return {
317
- summary: `forge-bridge completed ${worktree.branchName} (${developCycle ? "develop cycle" : phase}).`,
575
+ summary: `forge-bridge completed ${worktree.branchName} (${debugCycle ? "debug cycle" : developCycle ? "develop cycle" : phase}).`,
318
576
  spec: {
319
577
  repoPath: worktree.worktreePath,
320
578
  path: specPath,
@@ -326,57 +584,131 @@ export class DeterministicProviderCliService {
326
584
  artifacts: completionArtifacts
327
585
  };
328
586
  }
329
- async runQa(context) {
587
+ async runArchitect(context) {
330
588
  const { dispatch, worktree } = context;
331
- await context.emit({
332
- role: "worker",
333
- kind: "message",
334
- content: `Running ${dispatch.execution.provider} QA checks through forge-bridge.`,
335
- eventType: "qa_analysis"
336
- });
337
- const summary = "All checks passed. forge-bridge QA completed.";
338
- const qaArtifact = await writeQaArtifacts({
589
+ const metadataRoot = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id);
590
+ await fs.mkdir(metadataRoot, { recursive: true });
591
+ const specBody = `---\ntitle: "${dispatch.workItem.title}"\nstatus: pending_approval\nproduced_by: forge-bridge\n---\n\n# ${dispatch.workItem.title}\n\nArchitect plan pending approval.\n`;
592
+ const specPath = path.join(metadataRoot, "spec.md");
593
+ await fs.writeFile(specPath, specBody, "utf8");
594
+ await fs.writeFile(path.join(metadataRoot, "spec.meta.json"), JSON.stringify({ schema_version: 1, status: "pending_approval", produced_by: "forge-bridge" }) + "\n", "utf8");
595
+ await writeCompletionArtifact({
339
596
  worktreePath: worktree.worktreePath,
340
597
  workItemId: dispatch.workItem.id,
341
- acceptanceCriteria: dispatch.workItem.acceptanceCriteria,
598
+ phase: "architect",
342
599
  producedBy: "forge-bridge",
343
- provider: dispatch.execution.provider,
344
- model: dispatch.execution.model,
345
- command: "forge-bridge deterministic QA",
346
- summary
347
- });
348
- await emitQaArtifactRecorded(context.emit, worktree.worktreePath, qaArtifact);
600
+ redactionSecrets: exactRedactionSecrets(dispatch),
601
+ architectCycle: true
602
+ }, expectedCompletionToolName("architect"), deterministicArchitectPayload(dispatch));
603
+ const artifact = await readCompletionArtifact(worktree.worktreePath, dispatch.workItem.id, "architect");
604
+ if (!artifact) {
605
+ throw new Error("Deterministic provider did not produce the Forge Architect completion artifact.");
606
+ }
607
+ await emitCompletionArtifactRecorded(context.emit, worktree.worktreePath, artifact);
608
+ await emitArchitectStructuredEvents(context.emit, worktree.worktreePath, dispatch.workItem.id, artifact);
349
609
  await context.emit({
350
610
  role: "assistant",
351
611
  kind: "message",
352
- content: summary,
353
- eventType: "qa_complete"
612
+ content: "Architect plan complete. forge-bridge produced deterministic planning artifacts.",
613
+ eventType: "architect_complete"
614
+ });
615
+ return {
616
+ summary: "forge-bridge completed Architect plan (deterministic).",
617
+ spec: {
618
+ repoPath: worktree.worktreePath,
619
+ path: specPath,
620
+ body: specBody,
621
+ producedBy: "forge-bridge",
622
+ status: "pending_approval"
623
+ },
624
+ artifact,
625
+ artifacts: [artifact]
626
+ };
627
+ }
628
+ async runQa(context) {
629
+ const { dispatch, worktree } = context;
630
+ await context.emit({
631
+ role: "worker",
632
+ kind: "message",
633
+ content: `Planning ${dispatch.execution.provider} QA checks through forge-bridge.`,
634
+ eventType: "qa_plan"
354
635
  });
636
+ const qaBrowser = dispatch.qaBrowser;
637
+ const launchTarget = qaBrowser?.launchTarget ?? null;
638
+ const missingLaunchTarget = qaBrowser?.required === true && !hasLaunchTarget(launchTarget);
639
+ const browserSidecar = !missingLaunchTarget && qaBrowser?.required === true && launchTarget
640
+ ? deterministicBrowserSidecar(dispatch.workItem.id, launchTarget, dispatch.cycleRun.ownerType, dispatch.cycleRun.ownerId)
641
+ : null;
642
+ const browserChecks = browserSidecar && launchTarget
643
+ ? [deterministicBrowserCheck(launchTarget, browserSidecar.relativePath)]
644
+ : [];
645
+ const sidecars = await writeQaSidecarFiles(worktree.worktreePath, browserSidecar ? [browserSidecar] : []);
646
+ const summary = missingLaunchTarget
647
+ ? "QA blocked because browser testing is required but no app launch target was provided."
648
+ : "All checks passed. forge-bridge QA completed.";
649
+ const criterion = dispatch.workItem.acceptanceCriteria.trim() || "Forge QA evidence exists";
650
+ for (const gate of qaCompletionGateOrder) {
651
+ await writeCompletionArtifact({
652
+ worktreePath: worktree.worktreePath,
653
+ workItemId: dispatch.workItem.id,
654
+ phase: "qa",
655
+ producedBy: "forge-bridge",
656
+ redactionSecrets: exactRedactionSecrets(dispatch),
657
+ qaCycle: true,
658
+ ownerType: dispatch.cycleRun.ownerType ?? undefined,
659
+ ownerId: dispatch.cycleRun.ownerId ?? undefined
660
+ }, expectedQaCompletionToolName(gate), deterministicQaGatePayload({
661
+ gate,
662
+ criterion,
663
+ summary,
664
+ missingLaunchTarget,
665
+ browserChecks,
666
+ sidecars
667
+ }));
668
+ const gateArtifact = await readQaGateArtifact(qaArtifactRootForDispatch(worktree.worktreePath, dispatch.workItem.id, dispatch), gate);
669
+ if (gateArtifact) {
670
+ await emitQaGateAccepted(context.emit, worktree.worktreePath, gateArtifact, nextQaGate(gate));
671
+ }
672
+ }
673
+ const qaArtifact = await readQaCompletionArtifactBundle(worktree.worktreePath, dispatch.workItem.id, dispatch.cycleRun.ownerType, dispatch.cycleRun.ownerId);
674
+ if (!qaArtifact) {
675
+ throw new Error("Deterministic QA did not produce the complete durable QA artifact bundle.");
676
+ }
677
+ await emitQaArtifactRecorded(context.emit, worktree.worktreePath, qaArtifact);
678
+ await emitQaStructuredEvents(context.emit, qaArtifact);
355
679
  await context.emit(buildProviderUsageEvent(dispatch, estimatedDeterministicUsage()));
356
680
  return {
357
- summary: "forge-bridge QA passed.",
681
+ summary: missingLaunchTarget ? "forge-bridge QA blocked." : "forge-bridge QA passed.",
358
682
  artifact: qaArtifact,
359
683
  artifacts: [qaArtifact]
360
684
  };
361
685
  }
362
686
  async runConflictResolve(context) {
363
687
  const { dispatch, worktree } = context;
364
- await this.git.run(worktree.worktreePath, ["commit", "--allow-empty", "-m", `forge bridge conflict resolve for ${dispatch.workItem.id.slice(0, 8)}`]);
688
+ const addressComments = isPullRequestCommentsDispatch(dispatch);
689
+ await this.git.run(worktree.worktreePath, ["commit", "--allow-empty", "-m", `forge bridge ${addressComments ? "pr comments" : "conflict resolve"} for ${dispatch.workItem.id.slice(0, 8)}`]);
365
690
  await context.emit(buildProviderUsageEvent(dispatch, estimatedDeterministicUsage()));
366
691
  await context.emit({
367
692
  role: "assistant",
368
693
  kind: "message",
369
- content: `Deterministic conflict resolve completed for ${worktree.branchName}.`,
370
- eventType: "conflict_resolve_complete"
694
+ content: addressComments
695
+ ? `Deterministic PR comment addressing completed for ${worktree.branchName}.`
696
+ : `Deterministic conflict resolve completed for ${worktree.branchName}.`,
697
+ eventType: addressComments ? "pr_comments_complete" : "conflict_resolve_complete"
371
698
  });
372
699
  return {
373
- summary: `forge-bridge resolved conflicts for ${worktree.branchName}.`
700
+ summary: addressComments
701
+ ? `forge-bridge addressed PR comments for ${worktree.branchName}.`
702
+ : `forge-bridge resolved conflicts for ${worktree.branchName}.`
374
703
  };
375
704
  }
376
705
  }
377
706
  function phaseCompleteEventType(phase) {
378
707
  return phase === "implementation" ? "implementation_complete" : `${phase}_complete`;
379
708
  }
709
+ function isDebugCompletionPhaseForProvider(phase) {
710
+ return debugCompletionPhaseOrder.includes(phase);
711
+ }
380
712
  function deterministicCompletionPayload(phase, dispatch, changesetBody) {
381
713
  const changesetHash = sha256(changesetBody);
382
714
  const criterion = dispatch.workItem.acceptanceCriteria || "Deterministic bridge changeset exists";
@@ -399,6 +731,56 @@ function deterministicCompletionPayload(phase, dispatch, changesetBody) {
399
731
  next_phase_context: "Review FORGE_PHASE5_CHANGESET.md and the bridge commit before validation."
400
732
  };
401
733
  }
734
+ if (phase === "debug_repro") {
735
+ return {
736
+ status: "pass",
737
+ summary: "forge-bridge reproduced the bug deterministically.",
738
+ repro_steps: ["Run the deterministic fake-worker debug reproduction."],
739
+ observed: "The configured bug scenario is reproducible in deterministic bridge mode.",
740
+ expected: "The bug scenario should be fixed before QA handoff.",
741
+ evidence: [{ kind: "changeset", path: "FORGE_PHASE5_CHANGESET.md", content_hash: changesetHash }]
742
+ };
743
+ }
744
+ if (phase === "debug_root_cause") {
745
+ return {
746
+ status: "pass",
747
+ summary: "forge-bridge isolated a deterministic root cause.",
748
+ root_cause: "The deterministic fake-worker bug is represented by the generated changeset evidence.",
749
+ evidence: [{ kind: "changeset", path: "FORGE_PHASE5_CHANGESET.md", content_hash: changesetHash }],
750
+ eliminated_alternatives: [{ summary: "No alternate deterministic fake-worker path was implicated." }],
751
+ risk_area: "forge-bridge deterministic debug lane"
752
+ };
753
+ }
754
+ if (phase === "debug_fix") {
755
+ return {
756
+ status: "pass",
757
+ summary: "forge-bridge applied a deterministic debug fix.",
758
+ changed_files: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Recorded deterministic debug fix evidence." }],
759
+ tests_added_or_updated: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Deterministic debug evidence doubles as fake-worker regression coverage." }],
760
+ remaining_risks: [],
761
+ resolved_findings: (dispatch.qaRework?.findingIds ?? []).map((qaId) => ({
762
+ qa_id: qaId,
763
+ status: "resolved",
764
+ summary: `Resolved deterministic QA finding ${qaId}.`,
765
+ evidence: { path: "FORGE_PHASE5_CHANGESET.md", content_hash: changesetHash },
766
+ changed_files: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Recorded deterministic debug fix evidence." }],
767
+ tests_added_or_updated: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Deterministic fake-worker regression evidence." }],
768
+ regression_evidence: [{ command: "forge-bridge deterministic debug regression", status: "pass" }]
769
+ }))
770
+ };
771
+ }
772
+ if (phase === "debug_regression") {
773
+ return {
774
+ status: "pass",
775
+ summary: "forge-bridge proved the deterministic debug regression is QA-ready.",
776
+ commands: [{ command: "forge-bridge deterministic debug regression", exit_code: 0, status: "pass", summary: "Deterministic debug regression completed." }],
777
+ required_regressions: ["Original deterministic repro no longer fails."],
778
+ build_status: "not_applicable",
779
+ test_status: "pass",
780
+ repro_negative: true,
781
+ qa_ready: true
782
+ };
783
+ }
402
784
  if (phase === "self_review") {
403
785
  return {
404
786
  status: "pass",
@@ -427,140 +809,674 @@ function deterministicCompletionPayload(phase, dispatch, changesetBody) {
427
809
  remaining_risks: []
428
810
  };
429
811
  }
430
- return {
431
- status: "pass",
432
- summary: "forge-bridge fake worker completed deterministic validation.",
433
- commands: [
434
- {
435
- command: "git status --short && git diff --check",
436
- exit_code: 0,
437
- status: "pass",
438
- summary: "Deterministic validation command completed for the fake-worker changeset."
439
- }
440
- ],
441
- acceptance_criteria: [
442
- {
443
- criterion,
444
- evidence: `FORGE_PHASE5_CHANGESET.md exists with content hash ${changesetHash}.`,
445
- status: "satisfied"
812
+ return {
813
+ status: "pass",
814
+ summary: "forge-bridge fake worker completed deterministic validation.",
815
+ commands: [
816
+ {
817
+ command: "git status --short && git diff --check",
818
+ exit_code: 0,
819
+ status: "pass",
820
+ summary: "Deterministic validation command completed for the fake-worker changeset."
821
+ }
822
+ ],
823
+ acceptance_criteria: [
824
+ {
825
+ criterion,
826
+ evidence: `FORGE_PHASE5_CHANGESET.md exists with content hash ${changesetHash}.`,
827
+ status: "satisfied"
828
+ }
829
+ ],
830
+ build_status: "pass",
831
+ test_status: "pass",
832
+ lint_status: "not_applicable",
833
+ design_status: "not_applicable",
834
+ drift_checks: [
835
+ {
836
+ command_or_tool: "git diff --check",
837
+ status: "pass",
838
+ summary: "No deterministic drift or whitespace errors were reported for the fake-worker changeset."
839
+ }
840
+ ],
841
+ ready_for_dev_test: true
842
+ };
843
+ }
844
+ function deterministicArchitectPayload(dispatch) {
845
+ const planId = `architect-${dispatch.workItem.id.replace(/-/g, "")}`;
846
+ return {
847
+ status: "pass",
848
+ summary: "forge-bridge produced a deterministic Architect plan.",
849
+ implementation_plan: {
850
+ schema_version: 1,
851
+ plan_id: planId,
852
+ story_id: dispatch.workItem.id,
853
+ phases: [
854
+ { id: "phase-1", name: "Foundation", tasks: ["task-1"], gate: "phase-1-gate" }
855
+ ],
856
+ tasks: [
857
+ {
858
+ id: "task-1",
859
+ title: `Implement ${dispatch.workItem.title}`,
860
+ phase: "phase-1",
861
+ summary: "Deterministic bridge Architect task proving MCP artifact contract persistence.",
862
+ acceptance_criteria: [dispatch.workItem.acceptanceCriteria || `Preserve story intent for ${dispatch.workItem.title}`],
863
+ tests: [
864
+ { command: "dotnet test /home/dillon/repos/Forge/Forge.sln --filter Architect", purpose: "Architect bridge contract regression" }
865
+ ]
866
+ }
867
+ ],
868
+ dependencies: [],
869
+ phase_gates: [
870
+ { id: "phase-1-gate", phase: "phase-1", checks: ["Task tests pass", "Artifacts validate"] }
871
+ ]
872
+ },
873
+ qa_plan: {
874
+ schema_version: 1,
875
+ plan_id: planId,
876
+ final_qa: [
877
+ { id: "qa-1", coverage: `Verify Architect plan artifacts and pending approval status for ${dispatch.workItem.title}` }
878
+ ]
879
+ },
880
+ report_markdown: `# Architect Report\n\nWork item: ${dispatch.workItem.id}\nTitle: ${dispatch.workItem.title}\n\nVerdict: pass\n\nDeterministic bridge Architect plan produced for pending approval.\n`
881
+ };
882
+ }
883
+ function deterministicQaGatePayload(options) {
884
+ const blocked = options.missingLaunchTarget;
885
+ const skippedBecauseBlocked = blocked
886
+ ? {
887
+ status: "skipped",
888
+ summary: "Skipped because browser QA was blocked by missing launch target.",
889
+ reason: "Upstream browser QA blocker prevents meaningful downstream evidence."
890
+ }
891
+ : null;
892
+ switch (options.gate) {
893
+ case "qa_plan":
894
+ return {
895
+ status: "pass",
896
+ summary: "Deterministic QA plan recorded.",
897
+ checklist: [
898
+ "Review the validated work item against acceptance criteria.",
899
+ "Run deterministic regression evidence.",
900
+ "Confirm no in-scope QA findings remain."
901
+ ],
902
+ acceptance_criteria: [options.criterion]
903
+ };
904
+ case "qa_regression":
905
+ return {
906
+ status: "pass",
907
+ summary: "Deterministic regression QA completed.",
908
+ commands: [
909
+ {
910
+ command: "forge-bridge deterministic QA",
911
+ exit_code: 0,
912
+ status: "pass",
913
+ summary: "Deterministic regression evidence completed."
914
+ }
915
+ ],
916
+ notes: "Regression gate passed in deterministic fake-worker mode."
917
+ };
918
+ case "qa_api":
919
+ return {
920
+ status: "skipped",
921
+ summary: "No API/backend surface was identified for deterministic QA.",
922
+ reason: "The deterministic fake-worker changeset does not exercise API/backend behavior."
923
+ };
924
+ case "qa_manual_web":
925
+ return blocked
926
+ ? {
927
+ status: "blocked",
928
+ summary: "Browser QA could not run because no app launch target was provided.",
929
+ blocker_reason: "missing_app_launch_target"
930
+ }
931
+ : options.browserChecks.length > 0
932
+ ? {
933
+ status: "pass",
934
+ summary: "Deterministic browser QA exercised the configured launch target.",
935
+ browser_checks: options.browserChecks,
936
+ sidecars: options.sidecars,
937
+ notes: "Browser sidecar evidence recorded."
938
+ }
939
+ : {
940
+ status: "skipped",
941
+ summary: "Manual web QA was not required for this deterministic run.",
942
+ reason: "Forge did not require browser QA and no launch target was necessary."
943
+ };
944
+ case "qa_bug_repro":
945
+ return skippedBecauseBlocked ?? {
946
+ status: "skipped",
947
+ summary: "No failed QA observation required bug reproduction.",
948
+ reason: "No defects or candidate bugs were observed."
949
+ };
950
+ case "qa_findings":
951
+ return skippedBecauseBlocked ?? {
952
+ status: "pass",
953
+ summary: "No QA findings or candidate bugs were identified.",
954
+ findings: [],
955
+ candidate_bugs: []
956
+ };
957
+ case "qa_verdict":
958
+ return {
959
+ status: blocked ? "blocked" : "pass",
960
+ summary: options.summary,
961
+ checklist: [
962
+ "Review the validated work item against acceptance criteria.",
963
+ "Run deterministic regression evidence.",
964
+ blocked ? "Record missing browser launch target blocker." : "Confirm no in-scope QA findings remain."
965
+ ],
966
+ tested_acceptance_criteria: blocked ? [] : [options.criterion],
967
+ commands: blocked
968
+ ? []
969
+ : [
970
+ {
971
+ command: "forge-bridge deterministic QA",
972
+ exit_code: 0,
973
+ status: "pass",
974
+ summary: "Deterministic QA command completed."
975
+ }
976
+ ],
977
+ browser_checks: blocked ? [] : options.browserChecks,
978
+ sidecars: blocked ? [] : options.sidecars,
979
+ notes: options.summary,
980
+ findings: [],
981
+ candidate_bugs: [],
982
+ blocker_reason: blocked ? "missing_app_launch_target" : null,
983
+ report_markdown: `# QA report\n\n${options.summary}\n`
984
+ };
985
+ }
986
+ }
987
+ const qaArtifactFileNames = {
988
+ plan: "qa.plan.json",
989
+ evidence: "qa.evidence.json",
990
+ findings: "qa.findings.json",
991
+ verdict: "qa.verdict.json",
992
+ report: "qa.report.md"
993
+ };
994
+ const qaGateArtifactFileNames = {
995
+ qa_plan: "qa.plan.json",
996
+ qa_regression: "qa.regression.json",
997
+ qa_api: "qa.api.json",
998
+ qa_manual_web: "qa.manual-web.json",
999
+ qa_bug_repro: "qa.bug-repro.json",
1000
+ qa_findings: "qa.findings.json",
1001
+ qa_verdict: "qa.verdict.json"
1002
+ };
1003
+ function hasLaunchTarget(target) {
1004
+ return Boolean(target?.url?.trim()
1005
+ || target?.ready_url?.trim()
1006
+ || target?.command?.trim()
1007
+ || (target?.routes ?? []).some((route) => route.trim().length > 0));
1008
+ }
1009
+ function deterministicBrowserSidecar(workItemId, target, ownerType, ownerId) {
1010
+ const route = primaryLaunchRoute(target);
1011
+ return {
1012
+ relativePath: qaArtifactRelativePath(workItemId, "qa/screenshots/deterministic-browser-check.txt", ownerType, ownerId),
1013
+ content: `Deterministic Forge QA browser evidence\nRoute: ${route}\nConsole errors: []\nNetwork errors: []\nResponsive checks: desktop, mobile\n`
1014
+ };
1015
+ }
1016
+ function deterministicBrowserCheck(target, screenshotPath) {
1017
+ const route = primaryLaunchRoute(target);
1018
+ return {
1019
+ route,
1020
+ url: route,
1021
+ status: "pass",
1022
+ summary: "Deterministic browser QA exercised the configured launch target.",
1023
+ actions: ["open launch target", "walk acceptance criteria", "check console/network summaries", "check responsive viewport"],
1024
+ screenshots: [screenshotPath],
1025
+ console_errors: [],
1026
+ network_errors: [],
1027
+ responsive_checks: ["desktop", "mobile"]
1028
+ };
1029
+ }
1030
+ function primaryLaunchRoute(target) {
1031
+ return target.ready_url?.trim()
1032
+ || target.url?.trim()
1033
+ || target.routes.find((route) => route.trim().length > 0)?.trim()
1034
+ || "app launch command";
1035
+ }
1036
+ async function writeQaSidecarFiles(worktreePath, files) {
1037
+ const sidecars = [];
1038
+ for (const file of files) {
1039
+ const fullPath = path.resolve(worktreePath, file.relativePath);
1040
+ const relativePath = path.relative(worktreePath, fullPath).split(path.sep).join("/");
1041
+ if (relativePath.startsWith("..") || path.isAbsolute(relativePath)) {
1042
+ throw new Error(`QA sidecar path must stay under the worktree: ${file.relativePath}`);
1043
+ }
1044
+ await fs.mkdir(path.dirname(fullPath), { recursive: true });
1045
+ await fs.writeFile(fullPath, file.content, "utf8");
1046
+ sidecars.push({
1047
+ path: relativePath,
1048
+ content_hash: sha256(file.content),
1049
+ bytes: Buffer.byteLength(file.content, "utf8")
1050
+ });
1051
+ }
1052
+ return sidecars;
1053
+ }
1054
+ async function emitQaArtifactRecorded(emit, worktreePath, artifact) {
1055
+ const relativePath = path.relative(worktreePath, artifact.path) || path.basename(artifact.path);
1056
+ await emit({
1057
+ role: "tool",
1058
+ kind: "tool_result",
1059
+ content: `Forge QA artifact recorded ${relativePath} (${artifact.status}).`,
1060
+ eventType: "qa_artifact_recorded"
1061
+ });
1062
+ await emit({
1063
+ role: "hook",
1064
+ kind: "checkpoint",
1065
+ content: `phase_gate: qa artifact accepted with status ${artifact.status}.`,
1066
+ eventType: "phase_gate"
1067
+ });
1068
+ }
1069
+ async function readQaCompletionArtifactBundle(worktreePath, workItemId, ownerType, ownerId) {
1070
+ const artifact = await readCompletionArtifact(worktreePath, workItemId, "qa", ownerType, ownerId);
1071
+ if (!artifact || !await hasCompleteQaArtifactBundle(worktreePath, workItemId, ownerType, ownerId)) {
1072
+ return null;
1073
+ }
1074
+ const artifactRoot = ownerType && ownerId
1075
+ ? artifactRootForOwner(worktreePath, ownerType, ownerId)
1076
+ : artifactRootFor(worktreePath, workItemId);
1077
+ const planJson = await fs.readFile(path.join(artifactRoot, qaArtifactFileNames.plan), "utf8");
1078
+ const evidenceJson = await fs.readFile(path.join(artifactRoot, qaArtifactFileNames.evidence), "utf8");
1079
+ const findingsJson = await fs.readFile(path.join(artifactRoot, qaArtifactFileNames.findings), "utf8");
1080
+ await validateQaBundleSidecarReferences(worktreePath, workItemId, ownerType, ownerId);
1081
+ return {
1082
+ ...artifact,
1083
+ planJson,
1084
+ evidenceJson,
1085
+ findingsJson
1086
+ };
1087
+ }
1088
+ async function hasCompleteQaArtifactBundle(worktreePath, workItemId, ownerType, ownerId) {
1089
+ const artifactRoot = ownerType && ownerId
1090
+ ? artifactRootForOwner(worktreePath, ownerType, ownerId)
1091
+ : artifactRootFor(worktreePath, workItemId);
1092
+ for (const fileName of Object.values(qaArtifactFileNames)) {
1093
+ try {
1094
+ const stat = await fs.stat(path.join(artifactRoot, fileName));
1095
+ if (!stat.isFile()) {
1096
+ return false;
1097
+ }
1098
+ }
1099
+ catch (error) {
1100
+ if (isNodeError(error) && error.code === "ENOENT") {
1101
+ return false;
1102
+ }
1103
+ throw error;
1104
+ }
1105
+ }
1106
+ return true;
1107
+ }
1108
+ function enforceQaBrowserLaunchTargetGate(dispatch, artifact) {
1109
+ const qaBrowser = dispatch.qaBrowser;
1110
+ if (!qaBrowser?.required || hasLaunchTarget(qaBrowser.launchTarget ?? null)) {
1111
+ return;
1112
+ }
1113
+ const verdict = parseJsonLine(artifact.verdictJson) ?? {};
1114
+ const status = normalizedString(stringField(verdict, "status") ?? artifact.status ?? "");
1115
+ const blockerReason = normalizedString(stringField(verdict, "blocker_reason") ?? "");
1116
+ if (status !== "blocked" || blockerReason !== "missing_app_launch_target") {
1117
+ throw new Error("QA browser testing is required but no app launch target was provided; provider must return blocked with blocker_reason missing_app_launch_target.");
1118
+ }
1119
+ }
1120
+ async function validateQaBundleSidecarReferences(worktreePath, workItemId, ownerType, ownerId) {
1121
+ const artifactRoot = ownerType && ownerId
1122
+ ? artifactRootForOwner(worktreePath, ownerType, ownerId)
1123
+ : artifactRootFor(worktreePath, workItemId);
1124
+ const evidence = await readJsonObjectFile(path.join(artifactRoot, qaArtifactFileNames.evidence));
1125
+ const sidecars = arrayField(evidence, "sidecars");
1126
+ if (sidecars.length === 0) {
1127
+ return;
1128
+ }
1129
+ const qaSidecarRoot = path.resolve(artifactRoot, "qa");
1130
+ for (const [index, sidecar] of sidecars.entries()) {
1131
+ const sidecarPath = stringField(sidecar, "path");
1132
+ const expectedHash = stringField(sidecar, "content_hash");
1133
+ const expectedBytes = sidecar.bytes;
1134
+ if (!sidecarPath || !expectedHash || typeof expectedBytes !== "number" || !Number.isFinite(expectedBytes) || expectedBytes <= 0) {
1135
+ throw new Error(`QA sidecar ${index} must include path, content_hash, and positive bytes.`);
1136
+ }
1137
+ if (path.isAbsolute(sidecarPath)) {
1138
+ throw new Error(`QA sidecar ${index} path must be relative to the worktree.`);
1139
+ }
1140
+ const fullPath = path.resolve(worktreePath, sidecarPath);
1141
+ if (!isPathUnderRoot(qaSidecarRoot, fullPath)) {
1142
+ const ownerDirectory = ownerType && ownerId && ownerType.trim().toLowerCase() === "story" ? "stories" : "work-items";
1143
+ const ownerSegment = ownerType && ownerId ? ownerId : workItemId;
1144
+ throw new Error(`QA sidecar ${index} path must be under .forge/${ownerDirectory}/${ownerSegment}/artifacts/qa/.`);
1145
+ }
1146
+ const stat = await fs.lstat(fullPath).catch((error) => {
1147
+ if (isNodeError(error) && error.code === "ENOENT") {
1148
+ throw new Error(`QA sidecar ${index} file does not exist: ${sidecarPath}`);
1149
+ }
1150
+ throw error;
1151
+ });
1152
+ if (!stat.isFile() || stat.isSymbolicLink()) {
1153
+ throw new Error(`QA sidecar ${index} must reference a regular file.`);
1154
+ }
1155
+ await ensureNoSymbolicLinkPathSegments(qaSidecarRoot, path.dirname(fullPath), `QA sidecar ${index} path must not traverse symbolic links.`);
1156
+ if (stat.size !== expectedBytes) {
1157
+ throw new Error(`QA sidecar ${index} bytes do not match the referenced file.`);
1158
+ }
1159
+ const actualHash = await sha256File(fullPath);
1160
+ if (actualHash !== expectedHash.trim().toLowerCase()) {
1161
+ throw new Error(`QA sidecar ${index} content_hash does not match the referenced file.`);
1162
+ }
1163
+ }
1164
+ }
1165
+ async function emitQaStructuredEvents(emit, artifact) {
1166
+ const artifactRoot = path.dirname(artifact.path);
1167
+ const plan = await readJsonObjectFile(path.join(artifactRoot, qaArtifactFileNames.plan));
1168
+ const evidence = await readJsonObjectFile(path.join(artifactRoot, qaArtifactFileNames.evidence));
1169
+ const findings = await readJsonObjectFile(path.join(artifactRoot, qaArtifactFileNames.findings));
1170
+ const verdict = parseJsonLine(artifact.verdictJson) ?? {};
1171
+ const status = stringField(verdict, "status") ?? artifact.status ?? "unknown";
1172
+ const checklist = stringArrayField(plan, "checklist");
1173
+ await emit({
1174
+ role: "worker",
1175
+ kind: "message",
1176
+ content: checklist.length > 0
1177
+ ? `QA plan: ${checklist.join("; ")}`
1178
+ : "QA plan recorded.",
1179
+ eventType: "qa_plan"
1180
+ });
1181
+ for (const browserCheck of arrayField(evidence, "browser_checks")) {
1182
+ await emit({
1183
+ role: "worker",
1184
+ kind: "checkpoint",
1185
+ content: `QA browser check: ${summarizeQaObject(browserCheck)}`,
1186
+ eventType: "qa_browser_check"
1187
+ });
1188
+ }
1189
+ for (const finding of [...arrayField(findings, "findings"), ...arrayField(findings, "candidate_bugs")]) {
1190
+ await emit({
1191
+ role: "worker",
1192
+ kind: "checkpoint",
1193
+ content: `QA finding: ${summarizeQaObject(finding)}`,
1194
+ eventType: "qa_finding"
1195
+ });
1196
+ }
1197
+ await emit({
1198
+ role: "assistant",
1199
+ kind: "message",
1200
+ content: status === "blocked"
1201
+ ? `QA blocked: ${stringField(verdict, "summary") ?? "No summary provided."}`
1202
+ : `QA completed with status ${status}: ${stringField(verdict, "summary") ?? "No summary provided."}`,
1203
+ eventType: status === "blocked" ? "qa_blocked" : "qa_complete"
1204
+ });
1205
+ }
1206
+ function qaArtifactRootForDispatch(worktreePath, workItemId, dispatch) {
1207
+ return dispatch.cycleRun.ownerType && dispatch.cycleRun.ownerId
1208
+ ? artifactRootForOwner(worktreePath, dispatch.cycleRun.ownerType, dispatch.cycleRun.ownerId)
1209
+ : artifactRootFor(worktreePath, workItemId);
1210
+ }
1211
+ async function readQaGateArtifact(artifactRoot, gate) {
1212
+ const artifactPath = path.join(artifactRoot, qaGateArtifactFileNames[gate]);
1213
+ try {
1214
+ const stat = await fs.stat(artifactPath);
1215
+ if (!stat.isFile()) {
1216
+ return null;
1217
+ }
1218
+ }
1219
+ catch (error) {
1220
+ if (isNodeError(error) && error.code === "ENOENT") {
1221
+ return null;
1222
+ }
1223
+ throw error;
1224
+ }
1225
+ const payload = await readJsonObjectFile(artifactPath);
1226
+ return {
1227
+ gate,
1228
+ path: artifactPath,
1229
+ status: stringField(payload, "status") ?? "unknown",
1230
+ producedBy: stringField(payload, "produced_by") ?? stringField(payload, "producedBy") ?? undefined,
1231
+ contentHash: stringField(payload, "content_hash") ?? undefined
1232
+ };
1233
+ }
1234
+ function nextQaGate(gate) {
1235
+ const index = qaCompletionGateOrder.indexOf(gate);
1236
+ return index >= 0 ? qaCompletionGateOrder[index + 1] ?? null : null;
1237
+ }
1238
+ async function emitQaGateAccepted(emit, worktreePath, artifact, nextGate) {
1239
+ const relativePath = path.relative(worktreePath, artifact.path).split(path.sep).join("/");
1240
+ await emit({
1241
+ role: "hook",
1242
+ kind: artifact.status === "blocked" ? "error" : "checkpoint",
1243
+ content: `phase_gate: ${artifact.gate} artifact accepted with status ${artifact.status}.`,
1244
+ eventType: "phase_gate",
1245
+ data: JSON.stringify({
1246
+ phase: "qa",
1247
+ qa_gate: artifact.gate,
1248
+ status: artifact.status,
1249
+ artifact_relative_paths: [relativePath],
1250
+ content_hash: artifact.contentHash ?? null,
1251
+ produced_by: artifact.producedBy ?? null
1252
+ })
1253
+ });
1254
+ if (!nextGate) {
1255
+ return;
1256
+ }
1257
+ await emit({
1258
+ role: "hook",
1259
+ kind: "checkpoint",
1260
+ content: `phase_progression: ${artifact.gate} -> ${nextGate}`,
1261
+ eventType: "phase_gate",
1262
+ data: JSON.stringify({
1263
+ phase: "qa",
1264
+ from_gate: artifact.gate,
1265
+ to_gate: nextGate
1266
+ })
1267
+ });
1268
+ }
1269
+ class LiveQaArtifactEmitter {
1270
+ worktreePath;
1271
+ workItemId;
1272
+ dispatch;
1273
+ emit;
1274
+ emittedBundle = false;
1275
+ emittedGates = new Set();
1276
+ timer = null;
1277
+ pending = Promise.resolve();
1278
+ constructor(worktreePath, workItemId, dispatch, emit) {
1279
+ this.worktreePath = worktreePath;
1280
+ this.workItemId = workItemId;
1281
+ this.dispatch = dispatch;
1282
+ this.emit = emit;
1283
+ }
1284
+ start() {
1285
+ void this.pollQueued();
1286
+ this.timer = setInterval(() => {
1287
+ void this.pollQueued();
1288
+ }, 250);
1289
+ }
1290
+ async stop() {
1291
+ if (this.timer) {
1292
+ clearInterval(this.timer);
1293
+ this.timer = null;
1294
+ }
1295
+ await this.pollQueued();
1296
+ }
1297
+ hasEmitted() {
1298
+ return this.emittedBundle;
1299
+ }
1300
+ pollQueued() {
1301
+ this.pending = this.pending
1302
+ .then(() => this.poll())
1303
+ .catch(() => undefined);
1304
+ return this.pending;
1305
+ }
1306
+ async poll() {
1307
+ await this.emitAvailableGateEvents();
1308
+ if (this.emittedBundle) {
1309
+ return;
1310
+ }
1311
+ const artifact = await readQaCompletionArtifactBundle(this.worktreePath, this.workItemId, this.dispatch.cycleRun.ownerType, this.dispatch.cycleRun.ownerId);
1312
+ if (!artifact) {
1313
+ return;
1314
+ }
1315
+ enforceQaBrowserLaunchTargetGate(this.dispatch, artifact);
1316
+ this.emittedBundle = true;
1317
+ await emitQaArtifactRecorded(this.emit, this.worktreePath, artifact);
1318
+ await emitQaStructuredEvents(this.emit, artifact);
1319
+ }
1320
+ async emitAvailableGateEvents() {
1321
+ const artifactRoot = qaArtifactRootForDispatch(this.worktreePath, this.workItemId, this.dispatch);
1322
+ for (const gate of qaCompletionGateOrder) {
1323
+ if (this.emittedGates.has(gate)) {
1324
+ continue;
446
1325
  }
447
- ],
448
- build_status: "pass",
449
- test_status: "pass",
450
- lint_status: "not_applicable",
451
- design_status: "not_applicable",
452
- drift_checks: [
453
- {
454
- command_or_tool: "git diff --check",
455
- status: "pass",
456
- summary: "No deterministic drift or whitespace errors were reported for the fake-worker changeset."
1326
+ const artifact = await readQaGateArtifact(artifactRoot, gate);
1327
+ if (!artifact) {
1328
+ return;
457
1329
  }
458
- ],
459
- ready_for_dev_test: true
460
- };
1330
+ this.emittedGates.add(gate);
1331
+ await emitQaGateAccepted(this.emit, this.worktreePath, artifact, nextQaGate(gate));
1332
+ }
1333
+ }
461
1334
  }
462
- const qaArtifactFileNames = {
463
- plan: "qa.plan.json",
464
- evidence: "qa.evidence.json",
465
- findings: "qa.findings.json",
466
- verdict: "qa.verdict.json",
467
- report: "qa.report.md"
468
- };
469
- async function writeQaArtifacts(request) {
470
- const artifactRoot = artifactRootFor(request.worktreePath, request.workItemId);
471
- await fs.mkdir(artifactRoot, { recursive: true });
472
- const criterion = request.acceptanceCriteria.trim() || "Forge QA evidence exists";
473
- const relativeEvidencePath = qaArtifactRelativePath(request.workItemId, qaArtifactFileNames.evidence);
474
- const relativeFindingsPath = qaArtifactRelativePath(request.workItemId, qaArtifactFileNames.findings);
475
- const relativeReportPath = qaArtifactRelativePath(request.workItemId, qaArtifactFileNames.report);
476
- const planJson = jsonText({
477
- schema_version: 1,
478
- phase: "qa",
479
- checklist: [
480
- "Review the validated work item against acceptance criteria.",
481
- "Run relevant provider QA verification.",
482
- "Confirm no in-scope QA findings remain."
483
- ],
484
- acceptance_criteria: [criterion]
485
- });
486
- const evidenceJson = jsonText({
487
- schema_version: 1,
488
- phase: "qa",
489
- commands: [
490
- {
491
- command: request.command,
492
- exit_code: 0,
493
- status: "pass",
494
- summary: `${request.provider} QA completed successfully.`
1335
+ class LiveArchitectArtifactEmitter {
1336
+ worktreePath;
1337
+ workItemId;
1338
+ emit;
1339
+ emitted = false;
1340
+ timer = null;
1341
+ pending = Promise.resolve();
1342
+ constructor(worktreePath, workItemId, emit) {
1343
+ this.worktreePath = worktreePath;
1344
+ this.workItemId = workItemId;
1345
+ this.emit = emit;
1346
+ }
1347
+ start() {
1348
+ void this.pollQueued();
1349
+ this.timer = setInterval(() => {
1350
+ void this.pollQueued();
1351
+ }, 250);
1352
+ }
1353
+ async stop() {
1354
+ if (this.timer) {
1355
+ clearInterval(this.timer);
1356
+ this.timer = null;
1357
+ }
1358
+ await this.pollQueued();
1359
+ }
1360
+ hasEmitted() {
1361
+ return this.emitted;
1362
+ }
1363
+ pollQueued() {
1364
+ this.pending = this.pending
1365
+ .then(() => this.poll())
1366
+ .catch(() => undefined);
1367
+ return this.pending;
1368
+ }
1369
+ async poll() {
1370
+ if (this.emitted || !await hasCompleteArchitectArtifactBundle(this.worktreePath, this.workItemId)) {
1371
+ return;
1372
+ }
1373
+ const artifact = await readCompletionArtifact(this.worktreePath, this.workItemId, "architect");
1374
+ if (!artifact) {
1375
+ return;
1376
+ }
1377
+ this.emitted = true;
1378
+ await emitCompletionArtifactRecorded(this.emit, this.worktreePath, artifact);
1379
+ await emitArchitectStructuredEvents(this.emit, this.worktreePath, this.workItemId, artifact);
1380
+ }
1381
+ }
1382
+ async function hasCompleteArchitectArtifactBundle(worktreePath, workItemId) {
1383
+ const artifactRoot = artifactRootFor(worktreePath, workItemId);
1384
+ for (const fileName of ["implementation.plan.json", "qa.plan.json", "architect.verdict.json", "architect.report.md"]) {
1385
+ try {
1386
+ const stat = await fs.stat(path.join(artifactRoot, fileName));
1387
+ if (!stat.isFile()) {
1388
+ return false;
495
1389
  }
496
- ],
497
- browser_checks: [],
498
- notes: request.summary
499
- });
500
- const findingsJson = jsonText({
501
- schema_version: 1,
502
- phase: "qa",
503
- findings: [],
504
- candidate_bugs: []
505
- });
506
- const verdictJson = jsonText({
507
- schema_version: 1,
508
- phase: "qa",
509
- status: "pass",
510
- summary: request.summary,
511
- tested_acceptance_criteria: [criterion],
512
- finding_ids: [],
513
- candidate_bug_ids: [],
514
- blocker_reason: null,
515
- evidence_path: relativeEvidencePath,
516
- findings_path: relativeFindingsPath,
517
- report_path: relativeReportPath
518
- });
519
- const report = `# QA report\n\n${request.summary}\n\n- Provider: ${singleLine(request.provider)}\n- Model: ${singleLine(request.model)}\n- Command: ${singleLine(request.command)}\n`;
520
- await fs.writeFile(path.join(artifactRoot, qaArtifactFileNames.plan), planJson, "utf8");
521
- await fs.writeFile(path.join(artifactRoot, qaArtifactFileNames.evidence), evidenceJson, "utf8");
522
- await fs.writeFile(path.join(artifactRoot, qaArtifactFileNames.findings), findingsJson, "utf8");
523
- const verdictPath = path.join(artifactRoot, qaArtifactFileNames.verdict);
524
- await fs.writeFile(verdictPath, verdictJson, "utf8");
525
- await fs.writeFile(path.join(artifactRoot, qaArtifactFileNames.report), report, "utf8");
526
- return {
527
- repoPath: request.worktreePath,
528
- path: verdictPath,
529
- verdictJson,
530
- report,
531
- producedBy: request.producedBy,
532
- status: "pass",
533
- phase: "qa"
534
- };
1390
+ }
1391
+ catch (error) {
1392
+ if (isNodeError(error) && error.code === "ENOENT") {
1393
+ return false;
1394
+ }
1395
+ throw error;
1396
+ }
1397
+ }
1398
+ return true;
535
1399
  }
536
- async function emitQaArtifactRecorded(emit, worktreePath, artifact) {
537
- const relativePath = path.relative(worktreePath, artifact.path) || path.basename(artifact.path);
1400
+ async function emitArchitectStructuredEvents(emit, worktreePath, workItemId, artifact) {
1401
+ const artifactRoot = artifactRootFor(worktreePath, workItemId);
1402
+ const implementationPlan = await readJsonObjectFile(path.join(artifactRoot, "implementation.plan.json"));
1403
+ const qaPlan = await readJsonObjectFile(path.join(artifactRoot, "qa.plan.json"));
1404
+ const verdict = parseJsonLine(artifact.verdictJson) ?? {};
1405
+ const status = stringField(verdict, "status") ?? artifact.status ?? "unknown";
1406
+ const planId = stringField(implementationPlan, "plan_id") ?? "unknown";
538
1407
  await emit({
539
- role: "tool",
540
- kind: "tool_result",
541
- content: `Forge QA artifact recorded ${relativePath} (${artifact.status}).`,
542
- eventType: "qa_artifact_recorded"
1408
+ role: "worker",
1409
+ kind: "checkpoint",
1410
+ content: `Architect plan recorded: ${planId} with ${arrayField(implementationPlan, "phases").length} phases and ${arrayField(implementationPlan, "tasks").length} tasks.`,
1411
+ eventType: "architect_plan"
543
1412
  });
544
1413
  await emit({
545
- role: "hook",
1414
+ role: "worker",
546
1415
  kind: "checkpoint",
547
- content: `phase_gate: qa artifact accepted with status ${artifact.status}.`,
548
- eventType: "phase_gate"
1416
+ content: `Architect QA seed recorded with ${arrayField(qaPlan, "final_qa").length} final QA items.`,
1417
+ eventType: "architect_qa_seed"
1418
+ });
1419
+ await emit({
1420
+ role: "hook",
1421
+ kind: status === "pass" ? "checkpoint" : "error",
1422
+ content: `architect_mcp_complete: ${status === "pass" ? "accepted" : "recorded"} - ${stringField(verdict, "summary") ?? "Architect completion payload recorded."}`,
1423
+ eventType: "architect_mcp_complete"
549
1424
  });
550
1425
  }
551
- function qaArtifactRelativePath(workItemId, fileName) {
552
- return [".forge", "work-items", workItemId, "artifacts", fileName].join("/");
1426
+ async function readJsonObjectFile(filePath) {
1427
+ const content = await fs.readFile(filePath, "utf8").catch(() => "");
1428
+ return parseJsonLine(content) ?? {};
1429
+ }
1430
+ function arrayField(source, key) {
1431
+ const value = source[key];
1432
+ if (!Array.isArray(value)) {
1433
+ return [];
1434
+ }
1435
+ return value.filter((entry) => Boolean(entry) && typeof entry === "object" && !Array.isArray(entry));
1436
+ }
1437
+ function stringArrayField(source, key) {
1438
+ const value = source[key];
1439
+ if (!Array.isArray(value)) {
1440
+ return [];
1441
+ }
1442
+ return value.filter((entry) => typeof entry === "string" && entry.trim().length > 0);
1443
+ }
1444
+ function summarizeQaObject(source) {
1445
+ return clip(stringField(source, "title")
1446
+ ?? stringField(source, "summary")
1447
+ ?? stringField(source, "id")
1448
+ ?? JSON.stringify(source), 500);
553
1449
  }
554
- function jsonText(value) {
555
- return `${JSON.stringify(value, null, 2)}\n`;
1450
+ function qaArtifactRelativePath(workItemId, fileName, ownerType, ownerId) {
1451
+ if (ownerType && ownerId) {
1452
+ const ownerDirectory = ownerType.trim().toLowerCase() === "story" ? "stories" : "work-items";
1453
+ return [".forge", ownerDirectory, ownerId, "artifacts", fileName].join("/");
1454
+ }
1455
+ return [".forge", "work-items", workItemId, "artifacts", fileName].join("/");
556
1456
  }
557
1457
  async function emitCompletionArtifactRecorded(emit, worktreePath, artifact) {
558
1458
  const relativePath = path.relative(worktreePath, artifact.path) || path.basename(artifact.path);
1459
+ await emit({
1460
+ role: "tool",
1461
+ kind: "checkpoint",
1462
+ content: `Forge completion tool validation passed for ${artifact.phase ?? "unknown"} (${artifact.status}).`,
1463
+ eventType: "completion_tool_validation_passed",
1464
+ data: JSON.stringify({
1465
+ phase: artifact.phase ?? "unknown",
1466
+ status: artifact.status,
1467
+ artifact_relative_paths: [relativePath.split(path.sep).join("/")]
1468
+ })
1469
+ });
559
1470
  await emit({
560
1471
  role: "tool",
561
1472
  kind: "tool_result",
562
1473
  content: `Forge completion tool recorded ${artifact.phase ?? "unknown"} artifact ${relativePath} (${artifact.status}).`,
563
- eventType: "completion_tool_artifact_recorded"
1474
+ eventType: "completion_tool_artifact_recorded",
1475
+ data: JSON.stringify({
1476
+ phase: artifact.phase ?? "unknown",
1477
+ status: artifact.status,
1478
+ artifact_relative_paths: [relativePath.split(path.sep).join("/")]
1479
+ })
564
1480
  });
565
1481
  }
566
1482
  async function emitPhaseCompletionEvent(emit, artifact) {
@@ -588,7 +1504,15 @@ async function emitPhaseGateEvents(emit, artifact) {
588
1504
  ? "phase_progression: implementation -> self_review"
589
1505
  : phase === "self_review"
590
1506
  ? "phase_progression: self_review -> validation"
591
- : "phase_progression: validation -> QA ready";
1507
+ : phase === "debug_repro"
1508
+ ? "phase_progression: debug_repro -> debug_root_cause"
1509
+ : phase === "debug_root_cause"
1510
+ ? "phase_progression: debug_root_cause -> debug_fix"
1511
+ : phase === "debug_fix"
1512
+ ? "phase_progression: debug_fix -> debug_regression"
1513
+ : phase === "debug_regression"
1514
+ ? "phase_progression: debug_regression -> QA ready"
1515
+ : "phase_progression: validation -> QA ready";
592
1516
  await emit({
593
1517
  role: "hook",
594
1518
  kind: "checkpoint",
@@ -598,7 +1522,8 @@ async function emitPhaseGateEvents(emit, artifact) {
598
1522
  }
599
1523
  function completionPhaseFromArtifact(artifact) {
600
1524
  const phase = artifact.phase?.trim();
601
- return phase === "self_review" || phase === "validation" || phase === "implementation"
1525
+ return phase === "self_review" || phase === "validation" || phase === "implementation" || phase === "qa"
1526
+ || phase === "architect" || phase === "debug_repro" || phase === "debug_root_cause" || phase === "debug_fix" || phase === "debug_regression"
602
1527
  ? phase
603
1528
  : "implementation";
604
1529
  }
@@ -610,13 +1535,18 @@ class LiveCompletionArtifactEmitter {
610
1535
  emitted = new Set();
611
1536
  timer = null;
612
1537
  pending = Promise.resolve();
613
- constructor(worktreePath, workItemId, phase, developCycle, emit) {
1538
+ constructor(worktreePath, workItemId, phase, developCycle, debugCycle, emit) {
614
1539
  this.worktreePath = worktreePath;
615
1540
  this.workItemId = workItemId;
616
1541
  this.emit = emit;
617
- this.phases = developCycle
618
- ? developCyclePhaseOrder.slice(developCyclePhaseOrder.indexOf(phase))
619
- : [phase];
1542
+ if (debugCycle && isDebugCompletionPhaseForProvider(phase)) {
1543
+ this.phases = debugCompletionPhaseOrder.slice(debugCompletionPhaseOrder.indexOf(phase));
1544
+ }
1545
+ else {
1546
+ this.phases = developCycle
1547
+ ? developCyclePhaseOrder.slice(developCyclePhaseOrder.indexOf(phase))
1548
+ : [phase];
1549
+ }
620
1550
  }
621
1551
  start() {
622
1552
  void this.pollQueued();
@@ -659,20 +1589,23 @@ class LiveCompletionArtifactEmitter {
659
1589
  }
660
1590
  }
661
1591
  }
662
- async function readCompletionArtifactsForRun(worktreePath, workItemId, phase, developCycle) {
663
- if (!developCycle) {
1592
+ async function readCompletionArtifactsForRun(worktreePath, workItemId, phase, developCycle, debugCycle) {
1593
+ if (!developCycle && !debugCycle) {
664
1594
  const artifact = await readCompletionArtifact(worktreePath, workItemId, phase);
665
1595
  if (!artifact) {
666
1596
  throw new Error(`Provider CLI completed but did not call the Forge ${phase} completion tool.`);
667
1597
  }
668
1598
  return [artifact];
669
1599
  }
1600
+ const expectedPhases = debugCycle && isDebugCompletionPhaseForProvider(phase)
1601
+ ? debugCompletionPhaseOrder.slice(debugCompletionPhaseOrder.indexOf(phase))
1602
+ : ["implementation", "self_review", "validation"];
670
1603
  const artifacts = [];
671
- for (const expectedPhase of ["implementation", "self_review", "validation"]) {
1604
+ for (const expectedPhase of expectedPhases) {
672
1605
  const artifact = await readCompletionArtifact(worktreePath, workItemId, expectedPhase);
673
1606
  if (!artifact) {
674
1607
  if (artifacts.length === 0) {
675
- throw new Error("Provider CLI completed but did not call the Forge implementation completion tool.");
1608
+ throw new Error(`Provider CLI completed but did not call the Forge ${expectedPhase} completion tool.`);
676
1609
  }
677
1610
  const previous = artifacts[artifacts.length - 1];
678
1611
  if ((previous.status ?? "").trim().toLowerCase() === "pass") {
@@ -687,10 +1620,24 @@ async function readCompletionArtifactsForRun(worktreePath, workItemId, phase, de
687
1620
  }
688
1621
  return artifacts;
689
1622
  }
690
- function providerRedactionEnv(dispatch) {
691
- const env = completionRedactionEnv(exactRedactionSecrets(dispatch));
1623
+ function providerProcessEnv(dispatch) {
1624
+ const env = {
1625
+ ...completionRedactionEnv(exactRedactionSecrets(dispatch)),
1626
+ ...providerCredentialEnv(dispatch)
1627
+ };
692
1628
  return Object.keys(env).length > 0 ? env : undefined;
693
1629
  }
1630
+ function providerCredentialEnv(dispatch) {
1631
+ const secret = dispatch.apiKeySecretGrant?.secret;
1632
+ if (!secret || !dispatch.execution.requiresApiKeySecretGrant) {
1633
+ return {};
1634
+ }
1635
+ const provider = dispatch.execution.provider.trim().toLowerCase();
1636
+ if (provider === "codex" || provider === "openai") {
1637
+ return { OPENAI_API_KEY: secret };
1638
+ }
1639
+ return {};
1640
+ }
694
1641
  function exactRedactionSecrets(dispatch) {
695
1642
  return dispatch.apiKeySecretGrant?.secret ? [dispatch.apiKeySecretGrant.secret] : [];
696
1643
  }
@@ -713,7 +1660,7 @@ export class StreamingProviderProcessRunner {
713
1660
  return await new Promise((resolve, reject) => {
714
1661
  const child = spawn(launch.command, launch.args, {
715
1662
  cwd: request.cwd,
716
- env: request.env ? { ...process.env, ...request.env } : undefined,
1663
+ env: buildProviderChildEnvironment(request.env),
717
1664
  stdio: ["ignore", "pipe", "pipe"],
718
1665
  windowsHide: true
719
1666
  });
@@ -848,9 +1795,6 @@ function quoteWindowsCommandLineArg(value) {
848
1795
  }
849
1796
  return `"${value.replace(/(\\*)"/g, '$1$1\\"').replace(/(\\+)$/g, "$1$1")}"`;
850
1797
  }
851
- async function fileExists(inputPath) {
852
- return fs.stat(inputPath).then((stat) => stat.isFile()).catch(() => false);
853
- }
854
1798
  async function readProcessLines(stream, onLine) {
855
1799
  const reader = readline.createInterface({ input: stream });
856
1800
  try {
@@ -868,12 +1812,69 @@ function isFakeWorkerModel(model) {
868
1812
  function sha256(content) {
869
1813
  return crypto.createHash("sha256").update(content).digest("hex");
870
1814
  }
1815
+ function buildDraftPrompt(dispatch) {
1816
+ const draft = dispatch.draft;
1817
+ if (!draft) {
1818
+ throw new Error("Draft prompt is missing.");
1819
+ }
1820
+ return `${draft.systemPrompt}
1821
+
1822
+ Draft kind: ${draft.kind}
1823
+
1824
+ ${draft.userPrompt}
1825
+
1826
+ Return ONLY the requested JSON object. Do not wrap it in markdown and do not modify files.`;
1827
+ }
1828
+ function extractJsonObject(content) {
1829
+ let trimmed = content.trim();
1830
+ if (trimmed.startsWith("```")) {
1831
+ const firstNewline = trimmed.indexOf("\n");
1832
+ const lastFence = trimmed.lastIndexOf("```");
1833
+ if (firstNewline >= 0 && lastFence > firstNewline) {
1834
+ trimmed = trimmed.slice(firstNewline + 1, lastFence).trim();
1835
+ }
1836
+ }
1837
+ const start = trimmed.indexOf("{");
1838
+ const end = trimmed.lastIndexOf("}");
1839
+ return start >= 0 && end >= start ? trimmed.slice(start, end + 1) : trimmed;
1840
+ }
1841
+ function summarizeStderr(stderr) {
1842
+ const trimmed = stderr.trim();
1843
+ return trimmed ? `: ${clip(trimmed, 1000)}` : "";
1844
+ }
1845
+ function deterministicDraftPayload(dispatch) {
1846
+ const kind = dispatch.draft?.kind ?? "work_item";
1847
+ if (kind === "work_order") {
1848
+ return {
1849
+ title: "Deterministic runner Work Order draft",
1850
+ summary: "Forge Runner generated this deterministic Work Order draft.",
1851
+ objective: "Validate runner-backed Draft generation.",
1852
+ planningPacket: "Runner-backed draft generation returned a Work Order JSON payload.",
1853
+ decompositionContext: "Use this deterministic fixture only in bridge tests.",
1854
+ assumptions: ["Forge Runner dispatch is available."],
1855
+ warnings: []
1856
+ };
1857
+ }
1858
+ if (kind === "story") {
1859
+ return {
1860
+ title: "Deterministic runner Story draft",
1861
+ description: "Forge Runner generated this deterministic Story draft.",
1862
+ acceptanceCriteria: "Given runner-backed Draft generation, when Forge requests a Story draft, then JSON is returned.",
1863
+ points: 3
1864
+ };
1865
+ }
1866
+ return {
1867
+ title: "Deterministic runner Work Item draft",
1868
+ description: "Forge Runner generated this deterministic Work Item draft.",
1869
+ acceptanceCriteria: "Given runner-backed Draft generation, when Forge requests a draft, then JSON is returned.",
1870
+ reproSteps: "Run Draft with a Forge Runner provider selected.",
1871
+ systemInfo: "forge-bridge deterministic provider",
1872
+ points: 1
1873
+ };
1874
+ }
871
1875
  export function formatProviderCliCommand(command) {
872
1876
  return [command.command, ...command.args].map(singleLine).join(" ");
873
1877
  }
874
- function yamlQuotedScalar(value) {
875
- return JSON.stringify(singleLine(value));
876
- }
877
1878
  function singleLine(value) {
878
1879
  return value.replace(/\s+/g, " ").trim();
879
1880
  }
@@ -882,16 +1883,19 @@ export function buildProviderCliCommand(dispatch, run) {
882
1883
  const normalizedProvider = provider.toLowerCase();
883
1884
  const model = dispatch.execution.model.trim();
884
1885
  if (normalizedProvider === "codex") {
885
- const args = ["exec"];
1886
+ const args = run ? ["-s", codexSandboxModeForPlatform(), "-a", "never", "exec"] : ["exec"];
886
1887
  if (run?.completionTools) {
887
1888
  args.push(...codexMcpConfigArgs(run.completionTools));
888
1889
  }
889
1890
  args.push("--model", model);
890
1891
  if (run) {
891
- args.push("--json", "--dangerously-bypass-approvals-and-sandbox");
1892
+ args.push("--json");
892
1893
  if (run.worktreePath) {
893
1894
  args.push("--cd", run.worktreePath);
894
1895
  }
1896
+ if (run.skipGitRepoCheck) {
1897
+ args.push("--skip-git-repo-check");
1898
+ }
895
1899
  args.push(run.prompt ?? "");
896
1900
  }
897
1901
  return { command: "codex", args };
@@ -912,11 +1916,40 @@ export function buildProviderCliCommand(dispatch, run) {
912
1916
  }
913
1917
  return { command: provider, args };
914
1918
  }
1919
+ export function codexSandboxModeForPlatform(platform = process.platform) {
1920
+ return platform === "win32" ? "danger-full-access" : "workspace-write";
1921
+ }
1922
+ function buildArchitectPrompt(dispatch) {
1923
+ return `You are Forge's Architect lane running locally in a prepared git worktree.
1924
+
1925
+ Work item: ${dispatch.workItem.id} — ${dispatch.workItem.title}
1926
+
1927
+ Plan only. Do not implement source changes, do not create Develop phase artifacts, and do not mark the spec approved.
1928
+ Read injected Forge context under .forge plus the repository shape, then produce a repo-grounded implementation DAG with task tests, phase gates, final QA coverage, and a pending-approval spec.
1929
+ ${architectRevisionInstruction(dispatch)}
1930
+ Forge owns protocol files: write Architect artifacts only through the completion MCP tool.
1931
+
1932
+ ${completionPromptForPhase("architect")}
1933
+
1934
+ Finish only after calling forge.complete_architect_plan with implementation_plan, qa_plan, status, summary, and report/report_markdown.`;
1935
+ }
1936
+ function architectRevisionInstruction(dispatch) {
1937
+ if (!dispatch.architectRevision) {
1938
+ return "";
1939
+ }
1940
+ return `
1941
+ Architect revision context:
1942
+ - Previous plan id: ${dispatch.architectRevision.priorPlanId}
1943
+ - Previous content hash: ${dispatch.architectRevision.priorContentHash}
1944
+ - Reviewer feedback: ${dispatch.architectRevision.feedback}
1945
+ Revise the prior plan in response to the feedback. Preserve accepted scope and only change what the feedback requires.`;
1946
+ }
915
1947
  function buildImplementationPrompt(dispatch, phase = completionPhaseFromDispatch(dispatch)) {
916
1948
  return `You are Forge's ${phase.replace(/_/g, " ")} phase runner running locally in a prepared git worktree.
917
1949
 
918
1950
  Read .forge/work-items/${dispatch.workItem.id}/spec.md and any prior phase artifacts required by this phase.
919
1951
  ${phaseWorkInstruction(phase)}
1952
+ ${qaReworkImplementationInstruction(dispatch)}
920
1953
  Use the repository's existing conventions. Run relevant tests when practical.
921
1954
  Forge owns protocol files: worktree prep, injected .forge commands/hooks/skills, phase verdict artifacts, reports, and commits.
922
1955
  Read Forge-provided context under .forge when needed, but do not edit .forge files or create Forge verdict/report artifacts by hand.
@@ -930,6 +1963,7 @@ function buildDevelopCyclePrompt(dispatch, phase = completionPhaseFromDispatch(d
930
1963
 
931
1964
  Read .forge/work-items/${dispatch.workItem.id}/spec.md, implement the work item, self-review the diff, then validate it in this same provider session.
932
1965
  Start in the ${phase.replace(/_/g, " ")} phase. Do not stop after implementation if it passes; continue through self-review and validation using the next instruction returned by each completion tool.
1966
+ ${qaReworkImplementationInstruction(dispatch)}
933
1967
  Use the repository's existing conventions. Run relevant tests when practical.
934
1968
  Forge owns protocol files: worktree prep, injected .forge commands/hooks/skills, phase verdict artifacts, reports, and commits.
935
1969
  Read Forge-provided context under .forge when needed, but do not edit .forge files or create Forge verdict/report artifacts by hand.
@@ -938,6 +1972,55 @@ ${completionPromptForDevelopCycle(phase)}
938
1972
 
939
1973
  Finish with a concise summary of changed files and verification after the validation completion tool has accepted the work, or after the current phase tool records a non-pass blocker.`;
940
1974
  }
1975
+ function buildDebugCyclePrompt(dispatch, phase = completionPhaseFromDispatch(dispatch)) {
1976
+ return `You are Forge's Debug lane running locally in a prepared git worktree for a bug work item.
1977
+
1978
+ Read .forge/work-items/${dispatch.workItem.id}/spec.md, reproduce or characterize the bug, isolate root cause, apply the smallest safe fix, then prove the regression in this same provider session.
1979
+ Start in the ${phase.replace(/_/g, " ")} gate. Do not stop after a passing Debug gate; continue through the next Debug MCP instruction returned by the tool server until debug_regression is accepted or the current gate records a non-pass blocker.
1980
+ ${debugQaReworkInstruction(dispatch)}
1981
+ Use the repository's existing conventions. Run focused tests when practical, especially the original repro and required regressions.
1982
+ Forge owns protocol files: worktree prep, injected .forge commands/hooks/skills, Debug verdict artifacts, reports, and commits.
1983
+ Read Forge-provided context under .forge when needed, but do not edit .forge files or create Forge Debug artifacts by hand.
1984
+
1985
+ ${completionPromptForDebugCycle(isDebugCompletionPhaseForProvider(phase) ? phase : "debug_repro")}
1986
+
1987
+ Finish with a concise summary of changed files and verification after the debug_regression completion tool has accepted the work, or after the current Debug gate tool records a non-pass blocker.`;
1988
+ }
1989
+ function qaReworkImplementationInstruction(dispatch) {
1990
+ if (!dispatch.qaRework) {
1991
+ return "";
1992
+ }
1993
+ return `
1994
+ QA rework context:
1995
+ - Attempt ${dispatch.qaRework.attempt}/${dispatch.qaRework.maxAttempts}
1996
+ - Rework packet: ${dispatch.qaRework.packetPath}
1997
+ - Required QA finding IDs: ${dispatch.qaRework.findingIds.join(", ")}
1998
+ Read the packet JSON and fix or explicitly dispute each listed finding. The implementation completion artifact must include resolved_findings entries for every required QA ID with qa_id, status, summary, evidence, changed_files, tests_added_or_updated, and regression_evidence.
1999
+ Use only these resolved_findings status values: resolved, disputed, or not_reproduced. Use resolved when the finding was fixed; do not use fixed.`;
2000
+ }
2001
+ function debugQaReworkInstruction(dispatch) {
2002
+ if (!dispatch.qaRework) {
2003
+ return "";
2004
+ }
2005
+ return `
2006
+ QA rework context for Debug:
2007
+ - Attempt ${dispatch.qaRework.attempt}/${dispatch.qaRework.maxAttempts}
2008
+ - Rework packet: ${dispatch.qaRework.packetPath}
2009
+ - Required QA finding IDs: ${dispatch.qaRework.findingIds.join(", ")}
2010
+ Read the packet JSON, reproduce or characterize each listed finding, fix or explicitly dispute it, and include resolved_findings entries for every required QA ID in forge.complete_debug_fix with qa_id, status, summary, evidence, changed_files, tests_added_or_updated, and regression_evidence.
2011
+ Use only these resolved_findings status values: resolved, disputed, or not_reproduced. Use resolved when the finding was fixed; do not use fixed.`;
2012
+ }
2013
+ function qaReworkRetestInstruction(dispatch) {
2014
+ if (!dispatch.qaRework) {
2015
+ return "";
2016
+ }
2017
+ return `
2018
+ QA retest context:
2019
+ - Rework attempt ${dispatch.qaRework.attempt}/${dispatch.qaRework.maxAttempts}
2020
+ - Rework packet: ${dispatch.qaRework.packetPath}
2021
+ - Priority finding IDs: ${dispatch.qaRework.findingIds.join(", ")}
2022
+ Prioritize retesting the listed QA findings and their required regressions before deciding pass, needs_rework, or blocked.`;
2023
+ }
941
2024
  function phaseWorkInstruction(phase) {
942
2025
  if (phase === "self_review") {
943
2026
  return "Review the implementation diff, apply safe fixes when needed, and record remaining risks explicitly.";
@@ -947,11 +2030,90 @@ function phaseWorkInstruction(phase) {
947
2030
  }
948
2031
  return "Implement the work item and keep the change focused.";
949
2032
  }
950
- function buildQaPrompt(dispatch) {
951
- return `You are Forge's QA lane running locally.
2033
+ function qaBrowserInstruction(dispatch) {
2034
+ const qaBrowser = dispatch.qaBrowser;
2035
+ if (!qaBrowser) {
2036
+ return "Browser/app launch context: not provided by Forge.";
2037
+ }
2038
+ const launchTarget = qaBrowser.launchTarget;
2039
+ if (qaBrowser.required && !hasLaunchTarget(launchTarget ?? null)) {
2040
+ return `Browser/app launch context:\n- UI/browser QA is required for this item.\n- No app launch target was provided.\n- Return blocked with blocker_reason: missing_app_launch_target instead of pretending browser testing occurred.\n- Artifact sidecars path when available: ${qaBrowser.artifactsPath || `.forge/work-items/${dispatch.workItem.id}/artifacts/qa`}`;
2041
+ }
2042
+ if (!launchTarget) {
2043
+ return `Browser/app launch context:\n- UI/browser QA is not required by Forge heuristics for this item.\n- If you determine browser testing is needed, return blocked with blocker_reason: missing_app_launch_target unless you can safely identify a launch target from the repo.\n- Browser sidecars path: ${qaBrowser.artifactsPath || `.forge/work-items/${dispatch.workItem.id}/artifacts/qa`}`;
2044
+ }
2045
+ const routes = launchTarget.routes.length > 0 ? launchTarget.routes.join(", ") : "not specified";
2046
+ return `Browser/app launch context:\n- Browser QA required: ${qaBrowser.required ? "yes" : "no, unless the diff/AC requires it"}\n- URL: ${launchTarget.url || "not specified"}\n- Ready URL: ${launchTarget.ready_url || "not specified"}\n- Launch command: ${launchTarget.command || "not specified"}\n- Working directory: ${launchTarget.working_directory || "repo root"}\n- Routes to cover: ${routes}\n- Notes: ${launchTarget.notes || "none"}\n- Browser sidecars path: ${qaBrowser.artifactsPath || `.forge/work-items/${dispatch.workItem.id}/artifacts/qa`}`;
2047
+ }
2048
+ function storyQaInstruction(dispatch) {
2049
+ const storyQa = dispatch.storyQa;
2050
+ if (!storyQa) {
2051
+ return "";
2052
+ }
2053
+ const childLines = storyQa.childTasks.map((child) => {
2054
+ const dependencies = child.dependencyWorkItemIds.length > 0
2055
+ ? child.dependencyWorkItemIds.join(", ")
2056
+ : "none";
2057
+ const validation = child.validationArtifact
2058
+ ? `${child.validationArtifact.status} (${child.validationArtifact.path || "artifact path unavailable"})`
2059
+ : "missing";
2060
+ const childQa = child.qaArtifact
2061
+ ? `${child.qaArtifact.status} (${child.qaArtifact.path || "artifact path unavailable"})`
2062
+ : "not present";
2063
+ return `- ${child.title} (${child.workItemId}, architect ${child.architectTaskId}, phase ${child.phaseId}/${child.phaseOrder}); deps: ${dependencies}; validation: ${validation}; child QA: ${childQa}`;
2064
+ }).join("\n");
2065
+ const finalQa = storyQa.finalQaChecks.length > 0
2066
+ ? storyQa.finalQaChecks.map((check) => `- ${check}`).join("\n")
2067
+ : "- No final QA checks were provided in qa.plan.final_qa.";
2068
+ return `Story QA integration context:
2069
+ - Story work item: ${storyQa.storyWorkItemId}
2070
+ - Plan: ${storyQa.planId} / ${storyQa.planContentHash}
2071
+ - Story worktree: ${storyQa.worktreeKey}
2072
+ - Branch: ${storyQa.branch}
2073
+ - Architect implementation.plan.json provided: ${storyQa.implementationPlanJson ? "yes" : "no"}
2074
+ - Architect qa.plan.json provided: ${storyQa.qaPlanJson ? "yes" : "no"}
2075
+ Materialized child tasks and evidence:
2076
+ ${childLines || "- No child tasks were provided."}
2077
+ Architect final QA checks:
2078
+ ${finalQa}
2079
+ This is parent Story QA: inspect the integrated Story result, all current-plan child specs/evidence, and the final worktree state. Do not treat the final child task as separately signed off.`;
2080
+ }
2081
+ function buildQaPrompt(dispatch, laneSpec) {
2082
+ return `You are Forge's QA lane running locally in a prepared git worktree.
2083
+
2084
+ First read and follow the injected QA lane command at .forge/work-items/${dispatch.workItem.id}/spec.md. It defines the required gated QA skill workflow for this run.
2085
+
2086
+ Injected QA lane command and work item spec:
2087
+ ${laneSpec}
2088
+
2089
+ ---
952
2090
 
953
- Review the implementation for work item ${dispatch.workItem.id}: ${dispatch.workItem.title}
954
- Run relevant verification when practical and finish with a concise QA verdict.`;
2091
+ Work item: ${dispatch.workItem.id}
2092
+ Title: ${dispatch.workItem.title}
2093
+ Description:
2094
+ ${dispatch.workItem.description || "Not provided."}
2095
+
2096
+ Acceptance criteria:
2097
+ ${dispatch.workItem.acceptanceCriteria || "Not specified."}
2098
+
2099
+ Repro steps / scenario:
2100
+ ${dispatch.workItem.reproSteps || "Not provided."}
2101
+
2102
+ System info / environment notes:
2103
+ ${dispatch.workItem.systemInfo || "Not provided."}
2104
+
2105
+ ${storyQaInstruction(dispatch)}
2106
+ Inspect the validated implementation and Forge artifacts under .forge/work-items/${dispatch.workItem.id}/artifacts/ when present, especially implementation, self-review, and validation evidence.
2107
+ ${qaBrowserInstruction(dispatch)}
2108
+ ${qaReworkRetestInstruction(dispatch)}
2109
+ QA is read-mostly: inspect code, run commands, and exercise browser/app flows when available, but do not edit product source or tests.
2110
+ Record concrete evidence. For UI/browser work, include browser_checks with URLs/routes, actions, observed results, screenshots/traces when available, console errors, failed network requests, and responsive checks. Store browser sidecars under .forge/work-items/${dispatch.workItem.id}/artifacts/qa/.
2111
+ Report in-scope defects as actionable findings with repro steps, expected/actual behavior, evidence, likely area, required fix, and required regression.
2112
+ Out-of-scope or follow-up issues belong in candidate_bugs instead of blocking the current item.
2113
+
2114
+ ${completionPromptForQaCycle()}
2115
+
2116
+ Finish with a concise summary only after forge.complete_qa_verdict accepts the QA bundle.`;
955
2117
  }
956
2118
  function buildConflictResolvePrompt(dispatch, branchName) {
957
2119
  const targetBranch = dispatch.cycleRun.requestedBase || dispatch.repo.defaultBranch || "main";
@@ -966,6 +2128,34 @@ Keep the original work item intent intact:
966
2128
 
967
2129
  Finish with a concise summary of the conflicts resolved and verification performed.`;
968
2130
  }
2131
+ function buildPullRequestCommentsPrompt(dispatch, branchName) {
2132
+ const pr = dispatch.pullRequest;
2133
+ const targetBranch = pr?.targetBranch || dispatch.cycleRun.requestedBase || dispatch.repo.defaultBranch || "main";
2134
+ const prLocator = pr
2135
+ ? `PR #${pr.number}${pr.url ? ` (${pr.url})` : ""}`
2136
+ : "the open pull request for this work item";
2137
+ return `You are Forge's Pull Request Comments lane running locally in a prepared git worktree.
2138
+
2139
+ The current branch is the pull request branch ${branchName}. Address unresolved review comments on ${prLocator}.
2140
+ PR context:
2141
+ - Provider: ${pr?.provider || "not provided"}
2142
+ - Source branch: ${pr?.sourceBranch || branchName}
2143
+ - Target branch: ${targetBranch}
2144
+ - Unresolved comments: ${pr?.unresolvedThreads ?? "unknown"}
2145
+
2146
+ Use the PR URL, local git metadata, and available GitHub tooling/auth to inspect unresolved review threads. Make focused code or test changes that answer the feedback, commit the changes, and push ${branchName} to origin.
2147
+ After the push succeeds, Forge will resolve the addressed review threads through the pull request API.
2148
+ If the review thread contents are unavailable, stop with a clear summary of what could not be accessed instead of guessing.
2149
+ Keep the original work item intent intact:
2150
+ - Work item: ${dispatch.workItem.id}
2151
+ - Title: ${dispatch.workItem.title}
2152
+ - Acceptance criteria: ${dispatch.workItem.acceptanceCriteria || "Not specified"}
2153
+
2154
+ Finish with a concise summary of comments addressed and verification performed.`;
2155
+ }
2156
+ function isPullRequestCommentsDispatch(dispatch) {
2157
+ return dispatch.cycleRun.kind.trim().toLowerCase() === "pr_comments";
2158
+ }
969
2159
  async function cleanupCompletionTools(completionTools, emit) {
970
2160
  try {
971
2161
  await completionTools.cleanup();
@@ -1023,31 +2213,31 @@ class CursorStreamJsonState {
1023
2213
  consume(line) {
1024
2214
  const event = parseJsonLine(line);
1025
2215
  if (!event) {
1026
- return null;
2216
+ return [];
1027
2217
  }
1028
2218
  const type = stringField(event, "type");
1029
2219
  if (type === "system" && stringField(event, "subtype") === "init") {
1030
2220
  this.sessionId = stringField(event, "session_id");
1031
2221
  if (this.sessionId && !this.emittedSession) {
1032
2222
  this.emittedSession = true;
1033
- return {
1034
- role: "runner",
1035
- kind: "checkpoint",
1036
- content: `Cursor session started: ${this.sessionId}.`,
1037
- eventType: "provider_thread_started"
1038
- };
2223
+ return [{
2224
+ role: "runner",
2225
+ kind: "checkpoint",
2226
+ content: `Cursor session started: ${this.sessionId}.`,
2227
+ eventType: "provider_thread_started"
2228
+ }];
1039
2229
  }
1040
2230
  }
1041
2231
  if (type === "assistant") {
1042
2232
  const text = assistantMessageText(event);
1043
2233
  if (text) {
1044
2234
  this.finalMessage = clip(text, 4000);
1045
- return {
1046
- role: "assistant",
1047
- kind: "message",
1048
- content: this.finalMessage,
1049
- eventType: "provider_message"
1050
- };
2235
+ return [{
2236
+ role: "assistant",
2237
+ kind: "message",
2238
+ content: this.finalMessage,
2239
+ eventType: "provider_message"
2240
+ }];
1051
2241
  }
1052
2242
  }
1053
2243
  if (type === "tool_call") {
@@ -1056,23 +2246,23 @@ class CursorStreamJsonState {
1056
2246
  if (subtype === "started") {
1057
2247
  const summary = formatCursorToolCallStarted(toolCall);
1058
2248
  if (summary) {
1059
- return {
1060
- role: "worker",
1061
- kind: "checkpoint",
1062
- content: summary,
1063
- eventType: "provider_tool_call"
1064
- };
2249
+ return [{
2250
+ role: "worker",
2251
+ kind: "checkpoint",
2252
+ content: summary,
2253
+ eventType: "provider_tool_call"
2254
+ }];
1065
2255
  }
1066
2256
  }
1067
2257
  if (subtype === "completed") {
1068
2258
  const completed = formatCursorToolCallCompleted(toolCall);
1069
2259
  if (completed) {
1070
- return {
1071
- role: "worker",
1072
- kind: completed.kind,
1073
- content: completed.content,
1074
- eventType: completed.kind === "file_edit" ? "provider_file_edit" : "provider_tool_call"
1075
- };
2260
+ return [{
2261
+ role: "worker",
2262
+ kind: completed.kind,
2263
+ content: completed.content,
2264
+ eventType: completed.kind === "file_edit" ? "provider_file_edit" : "provider_tool_call"
2265
+ }];
1076
2266
  }
1077
2267
  }
1078
2268
  }
@@ -1084,14 +2274,14 @@ class CursorStreamJsonState {
1084
2274
  this.accumulateUsage(event);
1085
2275
  }
1086
2276
  if (type === "error" || (type === "result" && event.is_error === true)) {
1087
- return {
1088
- role: "runner",
1089
- kind: "error",
1090
- content: clip(line.trim(), 1000),
1091
- eventType: "provider_cli_error"
1092
- };
2277
+ return [{
2278
+ role: "runner",
2279
+ kind: "error",
2280
+ content: clip(line.trim(), 1000),
2281
+ eventType: "provider_cli_error"
2282
+ }];
1093
2283
  }
1094
- return null;
2284
+ return [];
1095
2285
  }
1096
2286
  accumulateUsage(event) {
1097
2287
  const usage = objectField(event, "usage");
@@ -1222,37 +2412,37 @@ class CodexJsonState {
1222
2412
  consume(line) {
1223
2413
  const event = parseJsonLine(line);
1224
2414
  if (!event) {
1225
- return null;
2415
+ return [];
1226
2416
  }
1227
2417
  const type = stringField(event, "type") ?? "";
1228
2418
  if (type === "thread.started") {
1229
2419
  this.threadId = stringField(event, "thread_id");
1230
2420
  if (this.threadId && !this.emittedThread) {
1231
2421
  this.emittedThread = true;
1232
- return {
1233
- role: "runner",
1234
- kind: "checkpoint",
1235
- content: `Codex thread started: ${this.threadId}.`,
1236
- eventType: "provider_thread_started"
1237
- };
2422
+ return [{
2423
+ role: "runner",
2424
+ kind: "checkpoint",
2425
+ content: `Codex thread started: ${this.threadId}.`,
2426
+ eventType: "provider_thread_started"
2427
+ }];
1238
2428
  }
1239
2429
  }
1240
2430
  if (type === "turn.completed") {
1241
2431
  this.accumulateUsage(event);
1242
- return {
1243
- role: "runner",
1244
- kind: "checkpoint",
1245
- content: "Codex turn completed.",
1246
- eventType: "provider_turn_completed"
1247
- };
2432
+ return [{
2433
+ role: "runner",
2434
+ kind: "checkpoint",
2435
+ content: "Codex turn completed.",
2436
+ eventType: "provider_turn_completed"
2437
+ }];
1248
2438
  }
1249
2439
  if (type === "turn.failed" || type === "error") {
1250
- return {
1251
- role: "runner",
1252
- kind: "error",
1253
- content: clip(line.trim(), 1000),
1254
- eventType: "provider_cli_error"
1255
- };
2440
+ return [{
2441
+ role: "runner",
2442
+ kind: "error",
2443
+ content: clip(line.trim(), 1000),
2444
+ eventType: "provider_cli_error"
2445
+ }];
1256
2446
  }
1257
2447
  if (type === "item.completed" || type === "item.updated") {
1258
2448
  const item = objectField(event, "item");
@@ -1261,28 +2451,32 @@ class CodexJsonState {
1261
2451
  const text = stringField(item, "text");
1262
2452
  if (text) {
1263
2453
  this.finalMessage = clip(text, 4000);
1264
- return {
1265
- role: "assistant",
1266
- kind: "message",
1267
- content: this.finalMessage,
1268
- eventType: "provider_message"
1269
- };
2454
+ return [{
2455
+ role: "assistant",
2456
+ kind: "message",
2457
+ content: this.finalMessage,
2458
+ eventType: "provider_message"
2459
+ }];
1270
2460
  }
1271
2461
  }
1272
2462
  if (itemType === "command_execution") {
1273
2463
  const command = stringField(item, "command");
1274
2464
  const status = stringField(item, "status");
1275
2465
  if (command) {
1276
- return {
1277
- role: "worker",
1278
- kind: "checkpoint",
1279
- content: `Codex command ${status || "completed"}: ${clip(command, 500)}`,
1280
- eventType: "provider_command"
1281
- };
2466
+ return [{
2467
+ role: "worker",
2468
+ kind: "checkpoint",
2469
+ content: `Codex command ${status || "completed"}: ${clip(command, 500)}`,
2470
+ eventType: "provider_command"
2471
+ }];
1282
2472
  }
1283
2473
  }
1284
2474
  }
1285
- return null;
2475
+ const mcpEvents = formatCodexMcpToolCallEvents(type, event);
2476
+ if (mcpEvents.length > 0) {
2477
+ return mcpEvents;
2478
+ }
2479
+ return [];
1286
2480
  }
1287
2481
  accumulateUsage(event) {
1288
2482
  const usage = objectField(event, "usage");
@@ -1298,6 +2492,113 @@ class CodexJsonState {
1298
2492
  });
1299
2493
  }
1300
2494
  }
2495
+ function formatCodexMcpToolCallEvents(type, event) {
2496
+ if (type !== "item.started" && type !== "item.updated" && type !== "item.completed") {
2497
+ return [];
2498
+ }
2499
+ const item = objectField(event, "item");
2500
+ const itemType = stringField(item, "type") ?? "";
2501
+ const serverName = mcpServerName(item);
2502
+ const toolName = mcpToolName(item);
2503
+ const isMcpItem = itemType.toLowerCase().includes("mcp")
2504
+ || Boolean(serverName)
2505
+ || (toolName ? isForgeCompletionTool(toolName) || toolName.toLowerCase().includes("mcp") : false);
2506
+ if (!isMcpItem || !toolName) {
2507
+ return [];
2508
+ }
2509
+ const status = normalizedString(stringField(item, "status")
2510
+ ?? stringField(event, "status")
2511
+ ?? (type === "item.started" ? "started" : type === "item.completed" ? "completed" : "updated"));
2512
+ const failed = status === "failed" || status === "error" || status === "cancelled" || Boolean(item.error);
2513
+ const completed = failed || type === "item.completed" || status === "completed" || status === "succeeded" || status === "success";
2514
+ const started = type === "item.started" || status === "started" || status === "running" || status === "in_progress";
2515
+ const data = safeProviderMcpData(item, serverName ?? "unknown", toolName, status);
2516
+ const label = `${serverName ?? "unknown"}.${toolName}`;
2517
+ if (failed) {
2518
+ const summary = mcpErrorSummary(item) ?? "MCP tool call failed.";
2519
+ const events = [{
2520
+ role: "tool",
2521
+ kind: "error",
2522
+ content: `MCP tool call failed: ${label} - ${summary}`,
2523
+ eventType: "provider_mcp_call_failed",
2524
+ data
2525
+ }];
2526
+ if (isForgeCompletionTool(toolName)) {
2527
+ events.push({
2528
+ role: "tool",
2529
+ kind: "error",
2530
+ content: `Forge completion tool validation failed: ${label} - ${summary}`,
2531
+ eventType: "completion_tool_validation_failed",
2532
+ data
2533
+ });
2534
+ }
2535
+ return events;
2536
+ }
2537
+ if (completed) {
2538
+ return [{
2539
+ role: "tool",
2540
+ kind: "checkpoint",
2541
+ content: `MCP tool call completed: ${label}.`,
2542
+ eventType: "provider_mcp_call_completed",
2543
+ data
2544
+ }];
2545
+ }
2546
+ if (started) {
2547
+ return [{
2548
+ role: "tool",
2549
+ kind: "checkpoint",
2550
+ content: `MCP tool call started: ${label}.`,
2551
+ eventType: "provider_mcp_call_started",
2552
+ data
2553
+ }];
2554
+ }
2555
+ return [];
2556
+ }
2557
+ function mcpServerName(item) {
2558
+ return stringField(item, "server")
2559
+ ?? stringField(item, "server_name")
2560
+ ?? stringField(item, "mcp_server")
2561
+ ?? stringField(objectField(item, "mcp"), "server")
2562
+ ?? stringField(objectField(item, "mcp"), "server_name");
2563
+ }
2564
+ function mcpToolName(item) {
2565
+ return stringField(item, "tool")
2566
+ ?? stringField(item, "tool_name")
2567
+ ?? stringField(item, "name")
2568
+ ?? stringField(objectField(item, "function"), "name")
2569
+ ?? stringField(objectField(item, "mcp"), "tool")
2570
+ ?? stringField(objectField(item, "mcp"), "tool_name");
2571
+ }
2572
+ function mcpErrorSummary(item) {
2573
+ const direct = stringField(item, "error")
2574
+ ?? stringField(item, "error_message")
2575
+ ?? stringField(item, "message");
2576
+ if (direct) {
2577
+ return clip(direct, 600);
2578
+ }
2579
+ const error = objectField(item, "error");
2580
+ return stringField(error, "message")
2581
+ ?? stringField(error, "summary")
2582
+ ?? stringField(objectField(item, "result"), "error")
2583
+ ?? null;
2584
+ }
2585
+ function safeProviderMcpData(item, serverName, toolName, status) {
2586
+ const elapsedMs = numericField(item, "elapsed_ms") ?? numericField(item, "duration_ms");
2587
+ return JSON.stringify(stripUndefined({
2588
+ server_name: serverName,
2589
+ tool_name: toolName,
2590
+ status,
2591
+ elapsed_ms: elapsedMs,
2592
+ error_summary: mcpErrorSummary(item)
2593
+ }));
2594
+ }
2595
+ function isForgeCompletionTool(toolName) {
2596
+ const normalized = toolName.trim().toLowerCase();
2597
+ return normalized.startsWith("forge.complete_")
2598
+ || normalized.startsWith("complete_")
2599
+ || normalized.includes("forge.complete_")
2600
+ || normalized.includes("complete_architect_plan");
2601
+ }
1301
2602
  function objectField(source, key) {
1302
2603
  const value = source[key];
1303
2604
  return value && typeof value === "object" && !Array.isArray(value)
@@ -1308,3 +2609,16 @@ function stringField(source, key) {
1308
2609
  const value = source[key];
1309
2610
  return typeof value === "string" && value.trim().length > 0 ? value : null;
1310
2611
  }
2612
+ function numericField(source, key) {
2613
+ const value = source[key];
2614
+ return typeof value === "number" && Number.isFinite(value) ? value : null;
2615
+ }
2616
+ function stripUndefined(value) {
2617
+ return Object.fromEntries(Object.entries(value).filter(([, entry]) => entry !== undefined));
2618
+ }
2619
+ function normalizedString(value) {
2620
+ return value.trim().toLowerCase().replace(/-/g, "_");
2621
+ }
2622
+ function isNodeError(error) {
2623
+ return error instanceof Error && "code" in error;
2624
+ }