@loucompanion/forge-bridge 0.1.1-dev.4f31cdd58cac → 0.1.1-dev.5b0a0fe4307c
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/bridge/bridge.service.d.ts +1 -0
- package/dist/bridge/bridge.service.js +151 -23
- package/dist/bridge/bridge.types.d.ts +13 -2
- package/dist/cli/cli.service.js +245 -10
- package/dist/cli/local-config.d.ts +1 -0
- package/dist/cli/local-config.js +22 -3
- package/dist/config.js +1 -1
- package/dist/session/internals.d.ts +1 -1
- package/dist/session/phase-completion.d.ts +34 -5
- package/dist/session/phase-completion.js +1797 -42
- package/dist/session/provider-cli/provider-cli.base.d.ts +4 -3
- package/dist/session/provider-cli/provider-cli.service.d.ts +12 -5
- package/dist/session/provider-cli/provider-cli.service.js +1687 -248
- package/dist/session/provider-cli/provider-cli.types.d.ts +5 -0
- package/dist/session/qa-sidecar-validation.d.ts +3 -0
- package/dist/session/qa-sidecar-validation.js +44 -0
- package/dist/session/session.service.js +53 -15
- package/dist/session/session.types.d.ts +121 -0
- package/dist/session/session.types.js +250 -2
- package/dist/version.d.ts +1 -1
- package/dist/version.js +1 -1
- package/dist/worktree/artifact-injector.d.ts +1 -0
- package/dist/worktree/artifact-injector.js +78 -1
- package/dist/worktree/worktree.service.d.ts +1 -0
- package/dist/worktree/worktree.service.js +132 -6
- package/dist/worktree/worktree.types.d.ts +8 -1
- package/package.json +8 -3
|
@@ -1,17 +1,60 @@
|
|
|
1
1
|
import crypto from "node:crypto";
|
|
2
2
|
import fs from "node:fs/promises";
|
|
3
|
+
import os from "node:os";
|
|
3
4
|
import path from "node:path";
|
|
4
5
|
import { execFile, spawn } from "node:child_process";
|
|
5
6
|
import readline from "node:readline";
|
|
6
7
|
import { promisify } from "node:util";
|
|
7
8
|
import { GitClient } from "../../shared/git/git.js";
|
|
8
9
|
import { resolveCursorAgentDirectLaunch } from "../../shared/cursor-agent/cursor-agent.launch.js";
|
|
10
|
+
import { ensureNoSymbolicLinkPathSegments, isPathUnderRoot, sha256File } from "../qa-sidecar-validation.js";
|
|
9
11
|
import { buildSpecBody, selectLaneCommand } from "../../worktree/artifact-injector.js";
|
|
10
|
-
import { codexMcpConfigArgs, completionPhaseFromDispatch, completionPromptForDevelopCycle, completionPromptForPhase, completionRedactionEnv, expectedCompletionToolName, prepareCompletionToolRuntime, readCompletionArtifact, usesDevelopCycleCompletion, writeCompletionArtifact } from "../phase-completion.js";
|
|
12
|
+
import { codexMcpConfigArgs, completionPhaseFromDispatch, completionPromptForDebugCycle, completionPromptForDevelopCycle, completionPromptForPhase, completionPromptForQaCycle, completionRedactionEnv, expectedCompletionToolName, expectedDebugCompletionToolName, expectedQaCompletionToolName, prepareCompletionToolRuntime, readCompletionArtifact, usesDebugCycleCompletion, usesDevelopCycleCompletion, writeCompletionArtifact, artifactRootFor, artifactRootForOwner, debugCompletionPhaseOrder, qaCompletionGateOrder } from "../phase-completion.js";
|
|
11
13
|
import { addUsage, buildProviderUsageEvent, emptyUsage, hasUsage, readUsageNumber } from "./provider-usage.js";
|
|
12
14
|
const fakeWorkerModel = "server-local-fake-worker";
|
|
13
15
|
const execFileAsync = promisify(execFile);
|
|
14
16
|
const developCyclePhaseOrder = ["implementation", "self_review", "validation"];
|
|
17
|
+
const allowedProviderParentEnvNames = [
|
|
18
|
+
"PATH",
|
|
19
|
+
"HOME",
|
|
20
|
+
"USERPROFILE",
|
|
21
|
+
"TMPDIR",
|
|
22
|
+
"TEMP",
|
|
23
|
+
"TMP",
|
|
24
|
+
"LANG"
|
|
25
|
+
];
|
|
26
|
+
const windowsAllowedProviderParentEnvNames = [
|
|
27
|
+
"SystemRoot",
|
|
28
|
+
"ComSpec",
|
|
29
|
+
"PATHEXT",
|
|
30
|
+
"APPDATA",
|
|
31
|
+
"LOCALAPPDATA"
|
|
32
|
+
];
|
|
33
|
+
function buildProviderChildEnvironment(requestEnv) {
|
|
34
|
+
const env = {};
|
|
35
|
+
for (const [key, value] of Object.entries(process.env)) {
|
|
36
|
+
if (typeof value === "string" && isAllowedProviderParentEnv(key)) {
|
|
37
|
+
env[key] = value;
|
|
38
|
+
}
|
|
39
|
+
}
|
|
40
|
+
if (requestEnv) {
|
|
41
|
+
for (const [key, value] of Object.entries(requestEnv)) {
|
|
42
|
+
const trimmedKey = key.trim();
|
|
43
|
+
if (trimmedKey.length > 0) {
|
|
44
|
+
env[trimmedKey] = value;
|
|
45
|
+
}
|
|
46
|
+
}
|
|
47
|
+
}
|
|
48
|
+
return env;
|
|
49
|
+
}
|
|
50
|
+
function isAllowedProviderParentEnv(key) {
|
|
51
|
+
return isAllowedProviderParentEnvName(key, allowedProviderParentEnvNames)
|
|
52
|
+
|| key.toUpperCase().startsWith("LC_")
|
|
53
|
+
|| (process.platform === "win32" && isAllowedProviderParentEnvName(key, windowsAllowedProviderParentEnvNames));
|
|
54
|
+
}
|
|
55
|
+
function isAllowedProviderParentEnvName(key, allowedNames) {
|
|
56
|
+
return allowedNames.some((allowed) => allowed.toLowerCase() === key.toLowerCase());
|
|
57
|
+
}
|
|
15
58
|
export class RoutingProviderCliService {
|
|
16
59
|
realProvider;
|
|
17
60
|
deterministicProvider;
|
|
@@ -24,15 +67,25 @@ export class RoutingProviderCliService {
|
|
|
24
67
|
? await this.deterministicProvider.runImplementation(context)
|
|
25
68
|
: await this.realProvider.runImplementation(context);
|
|
26
69
|
}
|
|
70
|
+
async runArchitect(context) {
|
|
71
|
+
return isFakeWorkerModel(context.dispatch.execution.model)
|
|
72
|
+
? await this.deterministicProvider.runArchitect(context)
|
|
73
|
+
: await this.realProvider.runArchitect(context);
|
|
74
|
+
}
|
|
27
75
|
async runConflictResolve(context) {
|
|
28
76
|
return isFakeWorkerModel(context.dispatch.execution.model)
|
|
29
77
|
? await this.deterministicProvider.runConflictResolve(context)
|
|
30
78
|
: await this.realProvider.runConflictResolve(context);
|
|
31
79
|
}
|
|
32
|
-
async runQa(
|
|
33
|
-
return isFakeWorkerModel(dispatch.execution.model)
|
|
34
|
-
? await this.deterministicProvider.runQa(
|
|
35
|
-
: await this.realProvider.runQa(
|
|
80
|
+
async runQa(context) {
|
|
81
|
+
return isFakeWorkerModel(context.dispatch.execution.model)
|
|
82
|
+
? await this.deterministicProvider.runQa(context)
|
|
83
|
+
: await this.realProvider.runQa(context);
|
|
84
|
+
}
|
|
85
|
+
async runDraft(context) {
|
|
86
|
+
return isFakeWorkerModel(context.dispatch.execution.model)
|
|
87
|
+
? await this.deterministicProvider.runDraft(context)
|
|
88
|
+
: await this.realProvider.runDraft(context);
|
|
36
89
|
}
|
|
37
90
|
}
|
|
38
91
|
export class ProcessBackedProviderCliService {
|
|
@@ -42,10 +95,65 @@ export class ProcessBackedProviderCliService {
|
|
|
42
95
|
this.processRunner = processRunner;
|
|
43
96
|
this.git = git;
|
|
44
97
|
}
|
|
98
|
+
async runDraft(context) {
|
|
99
|
+
const { dispatch } = context;
|
|
100
|
+
if (!dispatch.draft) {
|
|
101
|
+
throw new Error("Draft dispatch context is missing.");
|
|
102
|
+
}
|
|
103
|
+
const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), "forge-bridge-draft-"));
|
|
104
|
+
const command = buildProviderCliCommand(dispatch, {
|
|
105
|
+
worktreePath: tempDir,
|
|
106
|
+
prompt: buildDraftPrompt(dispatch),
|
|
107
|
+
skipGitRepoCheck: true
|
|
108
|
+
});
|
|
109
|
+
await context.emit({
|
|
110
|
+
role: "runner",
|
|
111
|
+
kind: "checkpoint",
|
|
112
|
+
content: `Starting provider CLI Draft: ${formatProviderCliCommand(command)}`,
|
|
113
|
+
eventType: "provider_cli_started"
|
|
114
|
+
});
|
|
115
|
+
const outputState = createProviderOutputState(dispatch.execution.provider);
|
|
116
|
+
try {
|
|
117
|
+
const result = await this.processRunner.run({
|
|
118
|
+
command: command.command,
|
|
119
|
+
args: command.args,
|
|
120
|
+
cwd: tempDir,
|
|
121
|
+
env: providerProcessEnv(dispatch)
|
|
122
|
+
}, {
|
|
123
|
+
onStdoutLine: async (line) => {
|
|
124
|
+
for (const event of outputState.consume(line)) {
|
|
125
|
+
await context.emit(event);
|
|
126
|
+
}
|
|
127
|
+
}
|
|
128
|
+
}, context.signal);
|
|
129
|
+
if (result.exitCode !== 0) {
|
|
130
|
+
throw new Error(`Provider CLI exited with code ${result.exitCode}${summarizeStderr(result.stderr)}.`);
|
|
131
|
+
}
|
|
132
|
+
const content = outputState.finalMessage ?? result.stdout.trim();
|
|
133
|
+
if (!content) {
|
|
134
|
+
throw new Error("Provider CLI completed without returning a draft.");
|
|
135
|
+
}
|
|
136
|
+
const json = extractJsonObject(content);
|
|
137
|
+
await context.emit({
|
|
138
|
+
role: "assistant",
|
|
139
|
+
kind: "message",
|
|
140
|
+
content: json,
|
|
141
|
+
eventType: "draft_complete"
|
|
142
|
+
});
|
|
143
|
+
await emitProviderUsageEvent(context.emit, dispatch, outputState);
|
|
144
|
+
return {
|
|
145
|
+
summary: "Draft generated through Forge Runner."
|
|
146
|
+
};
|
|
147
|
+
}
|
|
148
|
+
finally {
|
|
149
|
+
await fs.rm(tempDir, { recursive: true, force: true });
|
|
150
|
+
}
|
|
151
|
+
}
|
|
45
152
|
async runImplementation(context) {
|
|
46
153
|
const { dispatch, worktree } = context;
|
|
47
154
|
const phase = completionPhaseFromDispatch(dispatch);
|
|
48
155
|
const developCycle = usesDevelopCycleCompletion(dispatch);
|
|
156
|
+
const debugCycle = usesDebugCycleCompletion(dispatch);
|
|
49
157
|
const metadataRoot = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id);
|
|
50
158
|
await fs.mkdir(metadataRoot, { recursive: true });
|
|
51
159
|
const laneCommand = selectLaneCommand(dispatch.artifacts, dispatch.execution.lane, dispatch.cycleRun.phase);
|
|
@@ -59,7 +167,11 @@ export class ProcessBackedProviderCliService {
|
|
|
59
167
|
const completionTools = await prepareCompletionToolRuntime({ dispatch, worktree, phase });
|
|
60
168
|
const command = buildProviderCliCommand(dispatch, {
|
|
61
169
|
worktreePath: worktree.worktreePath,
|
|
62
|
-
prompt:
|
|
170
|
+
prompt: debugCycle
|
|
171
|
+
? buildDebugCyclePrompt(dispatch, phase)
|
|
172
|
+
: developCycle
|
|
173
|
+
? buildDevelopCyclePrompt(dispatch, phase)
|
|
174
|
+
: buildImplementationPrompt(dispatch, phase),
|
|
63
175
|
completionTools
|
|
64
176
|
});
|
|
65
177
|
await context.emit({
|
|
@@ -71,13 +183,15 @@ export class ProcessBackedProviderCliService {
|
|
|
71
183
|
await context.emit({
|
|
72
184
|
role: "runner",
|
|
73
185
|
kind: "checkpoint",
|
|
74
|
-
content:
|
|
75
|
-
? "Forge completion tools configured for
|
|
76
|
-
:
|
|
186
|
+
content: debugCycle
|
|
187
|
+
? "Forge Debug completion tools configured for debug_repro -> debug_root_cause -> debug_fix -> debug_regression; provider must call each MCP completion tool before exit."
|
|
188
|
+
: developCycle
|
|
189
|
+
? "Forge completion tools configured for implementation -> self_review -> validation; provider must call each MCP completion tool before exit."
|
|
190
|
+
: `Forge completion tools configured for ${phase}; provider must call the MCP completion tool before exit.`,
|
|
77
191
|
eventType: "completion_tools_configured"
|
|
78
192
|
});
|
|
79
193
|
const outputState = createProviderOutputState(dispatch.execution.provider);
|
|
80
|
-
const liveCompletionEvents = new LiveCompletionArtifactEmitter(worktree.worktreePath, dispatch.workItem.id, phase, developCycle, context.emit);
|
|
194
|
+
const liveCompletionEvents = new LiveCompletionArtifactEmitter(worktree.worktreePath, dispatch.workItem.id, phase, developCycle, debugCycle, context.emit);
|
|
81
195
|
let result;
|
|
82
196
|
try {
|
|
83
197
|
liveCompletionEvents.start();
|
|
@@ -85,11 +199,10 @@ export class ProcessBackedProviderCliService {
|
|
|
85
199
|
command: command.command,
|
|
86
200
|
args: command.args,
|
|
87
201
|
cwd: worktree.worktreePath,
|
|
88
|
-
env:
|
|
202
|
+
env: providerProcessEnv(dispatch)
|
|
89
203
|
}, {
|
|
90
204
|
onStdoutLine: async (line) => {
|
|
91
|
-
const event
|
|
92
|
-
if (event) {
|
|
205
|
+
for (const event of outputState.consume(line)) {
|
|
93
206
|
await context.emit(event);
|
|
94
207
|
}
|
|
95
208
|
}
|
|
@@ -111,7 +224,7 @@ export class ProcessBackedProviderCliService {
|
|
|
111
224
|
});
|
|
112
225
|
await emitProviderUsageEvent(context.emit, dispatch, outputState);
|
|
113
226
|
const committed = await commitWorktreeChanges(this.git, worktree.worktreePath, dispatch.workItem.id);
|
|
114
|
-
const completionArtifacts = await readCompletionArtifactsForRun(worktree.worktreePath, dispatch.workItem.id, phase, developCycle);
|
|
227
|
+
const completionArtifacts = await readCompletionArtifactsForRun(worktree.worktreePath, dispatch.workItem.id, phase, developCycle, debugCycle);
|
|
115
228
|
for (const artifact of completionArtifacts) {
|
|
116
229
|
if (!liveCompletionEvents.hasEmitted(completionPhaseFromArtifact(artifact))) {
|
|
117
230
|
await emitCompletionArtifactRecorded(context.emit, worktree.worktreePath, artifact);
|
|
@@ -137,7 +250,7 @@ export class ProcessBackedProviderCliService {
|
|
|
137
250
|
});
|
|
138
251
|
}
|
|
139
252
|
return {
|
|
140
|
-
summary: `${dispatch.execution.provider} CLI completed ${worktree.branchName} (${developCycle ? "develop cycle" : phase}, ${committed.commitSha.slice(0, 12)}).`,
|
|
253
|
+
summary: `${dispatch.execution.provider} CLI completed ${worktree.branchName} (${debugCycle ? "debug cycle" : developCycle ? "develop cycle" : phase}, ${committed.commitSha.slice(0, 12)}).`,
|
|
141
254
|
spec: {
|
|
142
255
|
repoPath: worktree.worktreePath,
|
|
143
256
|
path: specPath,
|
|
@@ -149,65 +262,208 @@ export class ProcessBackedProviderCliService {
|
|
|
149
262
|
artifacts: completionArtifacts
|
|
150
263
|
};
|
|
151
264
|
}
|
|
152
|
-
async
|
|
265
|
+
async runArchitect(context) {
|
|
266
|
+
const { dispatch, worktree } = context;
|
|
267
|
+
const completionTools = await prepareCompletionToolRuntime({ dispatch, worktree, phase: "architect" });
|
|
153
268
|
const command = buildProviderCliCommand(dispatch, {
|
|
154
|
-
|
|
269
|
+
worktreePath: worktree.worktreePath,
|
|
270
|
+
prompt: buildArchitectPrompt(dispatch),
|
|
271
|
+
completionTools
|
|
155
272
|
});
|
|
156
|
-
|
|
273
|
+
const commandText = formatProviderCliCommand(command);
|
|
274
|
+
await context.emit({
|
|
157
275
|
role: "runner",
|
|
158
276
|
kind: "checkpoint",
|
|
159
|
-
content: `Starting provider CLI
|
|
277
|
+
content: `Starting provider CLI Architect: ${commandText} in ${worktree.worktreePath}`,
|
|
160
278
|
eventType: "provider_cli_started"
|
|
161
279
|
});
|
|
280
|
+
await context.emit({
|
|
281
|
+
role: "runner",
|
|
282
|
+
kind: "checkpoint",
|
|
283
|
+
content: "Forge Architect completion tools configured; provider must call forge.complete_architect_plan before exit.",
|
|
284
|
+
eventType: "completion_tools_configured"
|
|
285
|
+
});
|
|
162
286
|
const outputState = createProviderOutputState(dispatch.execution.provider);
|
|
163
|
-
const
|
|
164
|
-
|
|
165
|
-
|
|
166
|
-
|
|
167
|
-
|
|
168
|
-
|
|
169
|
-
|
|
170
|
-
|
|
171
|
-
|
|
287
|
+
const liveArchitectEvents = new LiveArchitectArtifactEmitter(worktree.worktreePath, dispatch.workItem.id, context.emit);
|
|
288
|
+
let result;
|
|
289
|
+
try {
|
|
290
|
+
liveArchitectEvents.start();
|
|
291
|
+
result = await this.processRunner.run({
|
|
292
|
+
command: command.command,
|
|
293
|
+
args: command.args,
|
|
294
|
+
cwd: worktree.worktreePath,
|
|
295
|
+
env: providerProcessEnv(dispatch)
|
|
296
|
+
}, {
|
|
297
|
+
onStdoutLine: async (line) => {
|
|
298
|
+
for (const event of outputState.consume(line)) {
|
|
299
|
+
await context.emit(event);
|
|
300
|
+
}
|
|
172
301
|
}
|
|
173
|
-
}
|
|
174
|
-
}
|
|
302
|
+
}, context.signal);
|
|
303
|
+
}
|
|
304
|
+
finally {
|
|
305
|
+
await liveArchitectEvents.stop();
|
|
306
|
+
await cleanupCompletionTools(completionTools, context.emit);
|
|
307
|
+
}
|
|
175
308
|
if (result.exitCode !== 0) {
|
|
176
309
|
const stderr = clip(result.stderr.trim() || result.stdout.trim(), 1200);
|
|
177
310
|
throw new Error(`${command.command} exited ${result.exitCode}${stderr ? `: ${stderr}` : ""}`);
|
|
178
311
|
}
|
|
179
|
-
await emit({
|
|
312
|
+
await context.emit({
|
|
313
|
+
role: "runner",
|
|
314
|
+
kind: "checkpoint",
|
|
315
|
+
content: `Provider CLI Architect completed: ${command.command} exit ${result.exitCode}${outputState.sessionLabel ? ` ${outputState.sessionLabel}` : ""}.`,
|
|
316
|
+
eventType: "provider_cli_completed"
|
|
317
|
+
});
|
|
318
|
+
await emitProviderUsageEvent(context.emit, dispatch, outputState);
|
|
319
|
+
const architectArtifact = await readCompletionArtifact(worktree.worktreePath, dispatch.workItem.id, "architect");
|
|
320
|
+
if (!architectArtifact) {
|
|
321
|
+
throw new Error("Provider CLI Architect completed but did not call the Forge Architect completion tool.");
|
|
322
|
+
}
|
|
323
|
+
if (!liveArchitectEvents.hasEmitted()) {
|
|
324
|
+
await emitCompletionArtifactRecorded(context.emit, worktree.worktreePath, architectArtifact);
|
|
325
|
+
await emitArchitectStructuredEvents(context.emit, worktree.worktreePath, dispatch.workItem.id, architectArtifact);
|
|
326
|
+
}
|
|
327
|
+
await context.emit({
|
|
328
|
+
role: "assistant",
|
|
329
|
+
kind: "message",
|
|
330
|
+
content: outputState.finalMessage || `${dispatch.execution.provider} CLI produced an Architect plan for ${worktree.branchName}.`,
|
|
331
|
+
eventType: "architect_complete"
|
|
332
|
+
});
|
|
333
|
+
const specPath = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id, "spec.md");
|
|
334
|
+
const specBody = await fs.readFile(specPath, "utf8").catch(() => `# ${dispatch.workItem.title}\n\nArchitect plan pending approval.\n`);
|
|
335
|
+
return {
|
|
336
|
+
summary: `${dispatch.execution.provider} CLI Architect plan produced.`,
|
|
337
|
+
spec: {
|
|
338
|
+
repoPath: worktree.worktreePath,
|
|
339
|
+
path: specPath,
|
|
340
|
+
body: specBody,
|
|
341
|
+
producedBy: `${dispatch.execution.provider}-cli`,
|
|
342
|
+
status: "pending_approval"
|
|
343
|
+
},
|
|
344
|
+
artifact: architectArtifact,
|
|
345
|
+
artifacts: [architectArtifact]
|
|
346
|
+
};
|
|
347
|
+
}
|
|
348
|
+
async runQa(context) {
|
|
349
|
+
const { dispatch, worktree } = context;
|
|
350
|
+
const metadataRoot = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id);
|
|
351
|
+
await fs.mkdir(metadataRoot, { recursive: true });
|
|
352
|
+
const laneCommand = selectLaneCommand(dispatch.artifacts, dispatch.execution.lane, dispatch.cycleRun.phase);
|
|
353
|
+
if (!laneCommand) {
|
|
354
|
+
throw new Error(`Lane command for lane '${dispatch.execution.lane}' phase '${dispatch.cycleRun.phase}' was not resolved.`);
|
|
355
|
+
}
|
|
356
|
+
const specBody = buildSpecBody(laneCommand, dispatch.workItem, "qa");
|
|
357
|
+
const specPath = path.join(metadataRoot, "spec.md");
|
|
358
|
+
await fs.writeFile(specPath, specBody, "utf8");
|
|
359
|
+
await fs.writeFile(path.join(metadataRoot, "spec.meta.json"), JSON.stringify({ schema_version: 1, status: "approved", produced_by: "forge-lane-command" }) + "\n", "utf8");
|
|
360
|
+
const completionTools = await prepareCompletionToolRuntime({ dispatch, worktree, phase: "qa" });
|
|
361
|
+
const command = buildProviderCliCommand(dispatch, {
|
|
362
|
+
worktreePath: worktree.worktreePath,
|
|
363
|
+
prompt: buildQaPrompt(dispatch, specBody),
|
|
364
|
+
completionTools
|
|
365
|
+
});
|
|
366
|
+
const commandText = formatProviderCliCommand(command);
|
|
367
|
+
await context.emit({
|
|
368
|
+
role: "runner",
|
|
369
|
+
kind: "checkpoint",
|
|
370
|
+
content: `Starting provider CLI QA: ${commandText} in ${worktree.worktreePath}`,
|
|
371
|
+
eventType: "provider_cli_started"
|
|
372
|
+
});
|
|
373
|
+
await context.emit({
|
|
374
|
+
role: "runner",
|
|
375
|
+
kind: "checkpoint",
|
|
376
|
+
content: "Forge QA completion tools configured; provider must call all seven QA MCP gates before exit.",
|
|
377
|
+
eventType: "completion_tools_configured"
|
|
378
|
+
});
|
|
379
|
+
const outputState = createProviderOutputState(dispatch.execution.provider);
|
|
380
|
+
const liveQaEvents = new LiveQaArtifactEmitter(worktree.worktreePath, dispatch.workItem.id, dispatch, context.emit);
|
|
381
|
+
let result;
|
|
382
|
+
try {
|
|
383
|
+
liveQaEvents.start();
|
|
384
|
+
result = await this.processRunner.run({
|
|
385
|
+
command: command.command,
|
|
386
|
+
args: command.args,
|
|
387
|
+
cwd: worktree.worktreePath,
|
|
388
|
+
env: providerProcessEnv(dispatch)
|
|
389
|
+
}, {
|
|
390
|
+
onStdoutLine: async (line) => {
|
|
391
|
+
for (const event of outputState.consume(line)) {
|
|
392
|
+
await context.emit(event);
|
|
393
|
+
}
|
|
394
|
+
}
|
|
395
|
+
}, context.signal);
|
|
396
|
+
}
|
|
397
|
+
finally {
|
|
398
|
+
await liveQaEvents.stop();
|
|
399
|
+
await cleanupCompletionTools(completionTools, context.emit);
|
|
400
|
+
}
|
|
401
|
+
if (result.exitCode !== 0) {
|
|
402
|
+
const stderr = clip(result.stderr.trim() || result.stdout.trim(), 1200);
|
|
403
|
+
throw new Error(`${command.command} exited ${result.exitCode}${stderr ? `: ${stderr}` : ""}`);
|
|
404
|
+
}
|
|
405
|
+
await context.emit({
|
|
180
406
|
role: "runner",
|
|
181
407
|
kind: "checkpoint",
|
|
182
408
|
content: `Provider CLI QA completed: ${command.command} exit ${result.exitCode}${outputState.sessionLabel ? ` ${outputState.sessionLabel}` : ""}.`,
|
|
183
409
|
eventType: "provider_cli_completed"
|
|
184
410
|
});
|
|
185
|
-
await emitProviderUsageEvent(emit, dispatch, outputState);
|
|
411
|
+
await emitProviderUsageEvent(context.emit, dispatch, outputState);
|
|
412
|
+
const qaArtifact = await readQaCompletionArtifactBundle(worktree.worktreePath, dispatch.workItem.id, dispatch.cycleRun.ownerType, dispatch.cycleRun.ownerId);
|
|
413
|
+
if (!qaArtifact) {
|
|
414
|
+
const verdictOnly = await readCompletionArtifact(worktree.worktreePath, dispatch.workItem.id, "qa");
|
|
415
|
+
throw new Error(verdictOnly
|
|
416
|
+
? "Provider CLI QA completed but did not produce the complete durable QA artifact bundle."
|
|
417
|
+
: "Provider CLI QA completed but did not call the Forge QA completion tool.");
|
|
418
|
+
}
|
|
419
|
+
enforceQaBrowserLaunchTargetGate(dispatch, qaArtifact);
|
|
420
|
+
if (!liveQaEvents.hasEmitted()) {
|
|
421
|
+
await emitQaArtifactRecorded(context.emit, worktree.worktreePath, qaArtifact);
|
|
422
|
+
await emitQaStructuredEvents(context.emit, qaArtifact);
|
|
423
|
+
}
|
|
424
|
+
const status = (qaArtifact.status ?? "unknown").trim().toLowerCase();
|
|
425
|
+
const statusSummary = status === "pass"
|
|
426
|
+
? "passed"
|
|
427
|
+
: status === "blocked"
|
|
428
|
+
? "blocked"
|
|
429
|
+
: "found rework";
|
|
186
430
|
return {
|
|
187
|
-
summary: `${dispatch.execution.provider} CLI QA
|
|
431
|
+
summary: `${dispatch.execution.provider} CLI QA ${statusSummary}.`,
|
|
432
|
+
spec: {
|
|
433
|
+
repoPath: worktree.worktreePath,
|
|
434
|
+
path: specPath,
|
|
435
|
+
body: specBody,
|
|
436
|
+
producedBy: "forge-lane-command",
|
|
437
|
+
status: "approved"
|
|
438
|
+
},
|
|
439
|
+
artifact: qaArtifact,
|
|
440
|
+
artifacts: [qaArtifact]
|
|
188
441
|
};
|
|
189
442
|
}
|
|
190
443
|
async runConflictResolve(context) {
|
|
191
444
|
const { dispatch, worktree } = context;
|
|
445
|
+
const addressComments = isPullRequestCommentsDispatch(dispatch);
|
|
192
446
|
const command = buildProviderCliCommand(dispatch, {
|
|
193
447
|
worktreePath: worktree.worktreePath,
|
|
194
|
-
prompt:
|
|
448
|
+
prompt: addressComments
|
|
449
|
+
? buildPullRequestCommentsPrompt(dispatch, worktree.branchName)
|
|
450
|
+
: buildConflictResolvePrompt(dispatch, worktree.branchName)
|
|
195
451
|
});
|
|
196
452
|
await context.emit({
|
|
197
453
|
role: "runner",
|
|
198
454
|
kind: "checkpoint",
|
|
199
|
-
content: `Starting provider CLI conflict resolve: ${formatProviderCliCommand(command)} in ${worktree.worktreePath}`,
|
|
455
|
+
content: `Starting provider CLI ${addressComments ? "PR comment address" : "conflict resolve"}: ${formatProviderCliCommand(command)} in ${worktree.worktreePath}`,
|
|
200
456
|
eventType: "provider_cli_started"
|
|
201
457
|
});
|
|
202
458
|
const outputState = createProviderOutputState(dispatch.execution.provider);
|
|
203
459
|
const result = await this.processRunner.run({
|
|
204
460
|
command: command.command,
|
|
205
461
|
args: command.args,
|
|
206
|
-
cwd: worktree.worktreePath
|
|
462
|
+
cwd: worktree.worktreePath,
|
|
463
|
+
env: providerProcessEnv(dispatch)
|
|
207
464
|
}, {
|
|
208
465
|
onStdoutLine: async (line) => {
|
|
209
|
-
const event
|
|
210
|
-
if (event) {
|
|
466
|
+
for (const event of outputState.consume(line)) {
|
|
211
467
|
await context.emit(event);
|
|
212
468
|
}
|
|
213
469
|
}
|
|
@@ -222,11 +478,15 @@ export class ProcessBackedProviderCliService {
|
|
|
222
478
|
await context.emit({
|
|
223
479
|
role: "assistant",
|
|
224
480
|
kind: "message",
|
|
225
|
-
content: outputState.finalMessage ||
|
|
226
|
-
|
|
481
|
+
content: outputState.finalMessage || (addressComments
|
|
482
|
+
? `${dispatch.execution.provider} CLI addressed pull request comments for ${worktree.branchName}.`
|
|
483
|
+
: `${dispatch.execution.provider} CLI resolved merge conflicts for ${worktree.branchName}.`),
|
|
484
|
+
eventType: addressComments ? "pr_comments_complete" : "conflict_resolve_complete"
|
|
227
485
|
});
|
|
228
486
|
return {
|
|
229
|
-
summary:
|
|
487
|
+
summary: addressComments
|
|
488
|
+
? `${dispatch.execution.provider} CLI addressed PR comments on ${worktree.branchName} (${committed.commitSha.slice(0, 12)}).`
|
|
489
|
+
: `${dispatch.execution.provider} CLI resolved conflicts on ${worktree.branchName} (${committed.commitSha.slice(0, 12)}).`
|
|
230
490
|
};
|
|
231
491
|
}
|
|
232
492
|
}
|
|
@@ -235,10 +495,22 @@ export class DeterministicProviderCliService {
|
|
|
235
495
|
constructor(git = new GitClient()) {
|
|
236
496
|
this.git = git;
|
|
237
497
|
}
|
|
498
|
+
async runDraft(context) {
|
|
499
|
+
const content = JSON.stringify(deterministicDraftPayload(context.dispatch));
|
|
500
|
+
await context.emit({
|
|
501
|
+
role: "assistant",
|
|
502
|
+
kind: "message",
|
|
503
|
+
content,
|
|
504
|
+
eventType: "draft_complete"
|
|
505
|
+
});
|
|
506
|
+
await context.emit(buildProviderUsageEvent(context.dispatch, estimatedDeterministicUsage()));
|
|
507
|
+
return { summary: "forge-bridge generated deterministic draft." };
|
|
508
|
+
}
|
|
238
509
|
async runImplementation(context) {
|
|
239
510
|
const { dispatch, worktree } = context;
|
|
240
511
|
const phase = completionPhaseFromDispatch(dispatch);
|
|
241
512
|
const developCycle = usesDevelopCycleCompletion(dispatch);
|
|
513
|
+
const debugCycle = usesDebugCycleCompletion(dispatch);
|
|
242
514
|
const providerCommand = buildProviderCliCommand(dispatch);
|
|
243
515
|
const providerCommandText = formatProviderCliCommand(providerCommand);
|
|
244
516
|
const metadataRoot = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id);
|
|
@@ -269,9 +541,11 @@ export class DeterministicProviderCliService {
|
|
|
269
541
|
content: `Created bridge changeset at ${changesetPath}`,
|
|
270
542
|
eventType: "changeset"
|
|
271
543
|
});
|
|
272
|
-
const phases =
|
|
273
|
-
?
|
|
274
|
-
:
|
|
544
|
+
const phases = debugCycle
|
|
545
|
+
? debugCompletionPhaseOrder
|
|
546
|
+
: developCycle
|
|
547
|
+
? ["implementation", "self_review", "validation"]
|
|
548
|
+
: [phase];
|
|
275
549
|
const completionArtifacts = [];
|
|
276
550
|
for (const completionPhase of phases) {
|
|
277
551
|
await writeCompletionArtifact({
|
|
@@ -280,7 +554,9 @@ export class DeterministicProviderCliService {
|
|
|
280
554
|
phase: completionPhase,
|
|
281
555
|
producedBy: "forge-bridge",
|
|
282
556
|
redactionSecrets: exactRedactionSecrets(dispatch)
|
|
283
|
-
},
|
|
557
|
+
}, isDebugCompletionPhaseForProvider(completionPhase)
|
|
558
|
+
? expectedDebugCompletionToolName(completionPhase)
|
|
559
|
+
: expectedCompletionToolName(completionPhase), deterministicCompletionPayload(completionPhase, dispatch, changesetBody));
|
|
284
560
|
const completionArtifact = await readCompletionArtifact(worktree.worktreePath, dispatch.workItem.id, completionPhase);
|
|
285
561
|
if (!completionArtifact) {
|
|
286
562
|
throw new Error(`Deterministic provider did not produce the Forge ${completionPhase} completion artifact.`);
|
|
@@ -296,7 +572,7 @@ export class DeterministicProviderCliService {
|
|
|
296
572
|
}
|
|
297
573
|
await context.emit(buildProviderUsageEvent(dispatch, estimatedDeterministicUsage()));
|
|
298
574
|
return {
|
|
299
|
-
summary: `forge-bridge completed ${worktree.branchName} (${developCycle ? "develop cycle" : phase}).`,
|
|
575
|
+
summary: `forge-bridge completed ${worktree.branchName} (${debugCycle ? "debug cycle" : developCycle ? "develop cycle" : phase}).`,
|
|
300
576
|
spec: {
|
|
301
577
|
repoPath: worktree.worktreePath,
|
|
302
578
|
path: specPath,
|
|
@@ -308,131 +584,899 @@ export class DeterministicProviderCliService {
|
|
|
308
584
|
artifacts: completionArtifacts
|
|
309
585
|
};
|
|
310
586
|
}
|
|
311
|
-
async
|
|
312
|
-
|
|
313
|
-
|
|
314
|
-
|
|
315
|
-
|
|
316
|
-
|
|
317
|
-
|
|
318
|
-
await
|
|
319
|
-
|
|
320
|
-
|
|
321
|
-
|
|
322
|
-
|
|
323
|
-
|
|
324
|
-
|
|
325
|
-
|
|
326
|
-
|
|
327
|
-
|
|
587
|
+
async runArchitect(context) {
|
|
588
|
+
const { dispatch, worktree } = context;
|
|
589
|
+
const metadataRoot = path.join(worktree.worktreePath, ".forge", "work-items", dispatch.workItem.id);
|
|
590
|
+
await fs.mkdir(metadataRoot, { recursive: true });
|
|
591
|
+
const specBody = `---\ntitle: "${dispatch.workItem.title}"\nstatus: pending_approval\nproduced_by: forge-bridge\n---\n\n# ${dispatch.workItem.title}\n\nArchitect plan pending approval.\n`;
|
|
592
|
+
const specPath = path.join(metadataRoot, "spec.md");
|
|
593
|
+
await fs.writeFile(specPath, specBody, "utf8");
|
|
594
|
+
await fs.writeFile(path.join(metadataRoot, "spec.meta.json"), JSON.stringify({ schema_version: 1, status: "pending_approval", produced_by: "forge-bridge" }) + "\n", "utf8");
|
|
595
|
+
await writeCompletionArtifact({
|
|
596
|
+
worktreePath: worktree.worktreePath,
|
|
597
|
+
workItemId: dispatch.workItem.id,
|
|
598
|
+
phase: "architect",
|
|
599
|
+
producedBy: "forge-bridge",
|
|
600
|
+
redactionSecrets: exactRedactionSecrets(dispatch),
|
|
601
|
+
architectCycle: true
|
|
602
|
+
}, expectedCompletionToolName("architect"), deterministicArchitectPayload(dispatch));
|
|
603
|
+
const artifact = await readCompletionArtifact(worktree.worktreePath, dispatch.workItem.id, "architect");
|
|
604
|
+
if (!artifact) {
|
|
605
|
+
throw new Error("Deterministic provider did not produce the Forge Architect completion artifact.");
|
|
606
|
+
}
|
|
607
|
+
await emitCompletionArtifactRecorded(context.emit, worktree.worktreePath, artifact);
|
|
608
|
+
await emitArchitectStructuredEvents(context.emit, worktree.worktreePath, dispatch.workItem.id, artifact);
|
|
609
|
+
await context.emit({
|
|
610
|
+
role: "assistant",
|
|
611
|
+
kind: "message",
|
|
612
|
+
content: "Architect plan complete. forge-bridge produced deterministic planning artifacts.",
|
|
613
|
+
eventType: "architect_complete"
|
|
614
|
+
});
|
|
615
|
+
return {
|
|
616
|
+
summary: "forge-bridge completed Architect plan (deterministic).",
|
|
617
|
+
spec: {
|
|
618
|
+
repoPath: worktree.worktreePath,
|
|
619
|
+
path: specPath,
|
|
620
|
+
body: specBody,
|
|
621
|
+
producedBy: "forge-bridge",
|
|
622
|
+
status: "pending_approval"
|
|
623
|
+
},
|
|
624
|
+
artifact,
|
|
625
|
+
artifacts: [artifact]
|
|
626
|
+
};
|
|
627
|
+
}
|
|
628
|
+
async runQa(context) {
|
|
629
|
+
const { dispatch, worktree } = context;
|
|
630
|
+
await context.emit({
|
|
631
|
+
role: "worker",
|
|
632
|
+
kind: "message",
|
|
633
|
+
content: `Planning ${dispatch.execution.provider} QA checks through forge-bridge.`,
|
|
634
|
+
eventType: "qa_plan"
|
|
635
|
+
});
|
|
636
|
+
const qaBrowser = dispatch.qaBrowser;
|
|
637
|
+
const launchTarget = qaBrowser?.launchTarget ?? null;
|
|
638
|
+
const missingLaunchTarget = qaBrowser?.required === true && !hasLaunchTarget(launchTarget);
|
|
639
|
+
const browserSidecar = !missingLaunchTarget && qaBrowser?.required === true && launchTarget
|
|
640
|
+
? deterministicBrowserSidecar(dispatch.workItem.id, launchTarget, dispatch.cycleRun.ownerType, dispatch.cycleRun.ownerId)
|
|
641
|
+
: null;
|
|
642
|
+
const browserChecks = browserSidecar && launchTarget
|
|
643
|
+
? [deterministicBrowserCheck(launchTarget, browserSidecar.relativePath)]
|
|
644
|
+
: [];
|
|
645
|
+
const sidecars = await writeQaSidecarFiles(worktree.worktreePath, browserSidecar ? [browserSidecar] : []);
|
|
646
|
+
const summary = missingLaunchTarget
|
|
647
|
+
? "QA blocked because browser testing is required but no app launch target was provided."
|
|
648
|
+
: "All checks passed. forge-bridge QA completed.";
|
|
649
|
+
const criterion = dispatch.workItem.acceptanceCriteria.trim() || "Forge QA evidence exists";
|
|
650
|
+
for (const gate of qaCompletionGateOrder) {
|
|
651
|
+
await writeCompletionArtifact({
|
|
652
|
+
worktreePath: worktree.worktreePath,
|
|
653
|
+
workItemId: dispatch.workItem.id,
|
|
654
|
+
phase: "qa",
|
|
655
|
+
producedBy: "forge-bridge",
|
|
656
|
+
redactionSecrets: exactRedactionSecrets(dispatch),
|
|
657
|
+
qaCycle: true,
|
|
658
|
+
ownerType: dispatch.cycleRun.ownerType ?? undefined,
|
|
659
|
+
ownerId: dispatch.cycleRun.ownerId ?? undefined
|
|
660
|
+
}, expectedQaCompletionToolName(gate), deterministicQaGatePayload({
|
|
661
|
+
gate,
|
|
662
|
+
criterion,
|
|
663
|
+
summary,
|
|
664
|
+
missingLaunchTarget,
|
|
665
|
+
browserChecks,
|
|
666
|
+
sidecars
|
|
667
|
+
}));
|
|
668
|
+
const gateArtifact = await readQaGateArtifact(qaArtifactRootForDispatch(worktree.worktreePath, dispatch.workItem.id, dispatch), gate);
|
|
669
|
+
if (gateArtifact) {
|
|
670
|
+
await emitQaGateAccepted(context.emit, worktree.worktreePath, gateArtifact, nextQaGate(gate));
|
|
671
|
+
}
|
|
672
|
+
}
|
|
673
|
+
const qaArtifact = await readQaCompletionArtifactBundle(worktree.worktreePath, dispatch.workItem.id, dispatch.cycleRun.ownerType, dispatch.cycleRun.ownerId);
|
|
674
|
+
if (!qaArtifact) {
|
|
675
|
+
throw new Error("Deterministic QA did not produce the complete durable QA artifact bundle.");
|
|
676
|
+
}
|
|
677
|
+
await emitQaArtifactRecorded(context.emit, worktree.worktreePath, qaArtifact);
|
|
678
|
+
await emitQaStructuredEvents(context.emit, qaArtifact);
|
|
679
|
+
await context.emit(buildProviderUsageEvent(dispatch, estimatedDeterministicUsage()));
|
|
680
|
+
return {
|
|
681
|
+
summary: missingLaunchTarget ? "forge-bridge QA blocked." : "forge-bridge QA passed.",
|
|
682
|
+
artifact: qaArtifact,
|
|
683
|
+
artifacts: [qaArtifact]
|
|
684
|
+
};
|
|
685
|
+
}
|
|
686
|
+
async runConflictResolve(context) {
|
|
687
|
+
const { dispatch, worktree } = context;
|
|
688
|
+
const addressComments = isPullRequestCommentsDispatch(dispatch);
|
|
689
|
+
await this.git.run(worktree.worktreePath, ["commit", "--allow-empty", "-m", `forge bridge ${addressComments ? "pr comments" : "conflict resolve"} for ${dispatch.workItem.id.slice(0, 8)}`]);
|
|
690
|
+
await context.emit(buildProviderUsageEvent(dispatch, estimatedDeterministicUsage()));
|
|
691
|
+
await context.emit({
|
|
692
|
+
role: "assistant",
|
|
693
|
+
kind: "message",
|
|
694
|
+
content: addressComments
|
|
695
|
+
? `Deterministic PR comment addressing completed for ${worktree.branchName}.`
|
|
696
|
+
: `Deterministic conflict resolve completed for ${worktree.branchName}.`,
|
|
697
|
+
eventType: addressComments ? "pr_comments_complete" : "conflict_resolve_complete"
|
|
698
|
+
});
|
|
699
|
+
return {
|
|
700
|
+
summary: addressComments
|
|
701
|
+
? `forge-bridge addressed PR comments for ${worktree.branchName}.`
|
|
702
|
+
: `forge-bridge resolved conflicts for ${worktree.branchName}.`
|
|
703
|
+
};
|
|
704
|
+
}
|
|
705
|
+
}
|
|
706
|
+
function phaseCompleteEventType(phase) {
|
|
707
|
+
return phase === "implementation" ? "implementation_complete" : `${phase}_complete`;
|
|
708
|
+
}
|
|
709
|
+
function isDebugCompletionPhaseForProvider(phase) {
|
|
710
|
+
return debugCompletionPhaseOrder.includes(phase);
|
|
711
|
+
}
|
|
712
|
+
function deterministicCompletionPayload(phase, dispatch, changesetBody) {
|
|
713
|
+
const changesetHash = sha256(changesetBody);
|
|
714
|
+
const criterion = dispatch.workItem.acceptanceCriteria || "Deterministic bridge changeset exists";
|
|
715
|
+
if (phase === "implementation") {
|
|
716
|
+
return {
|
|
717
|
+
status: "pass",
|
|
718
|
+
summary: "forge-bridge produced a deterministic implementation changeset.",
|
|
719
|
+
plan: [{ step: "Create deterministic changeset", status: "done" }],
|
|
720
|
+
changed_files: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Recorded deterministic bridge evidence." }],
|
|
721
|
+
tests_added_or_updated: [{ name: "forge_bridge_run_once", evidence: "The bridge committed FORGE_PHASE5_CHANGESET.md." }],
|
|
722
|
+
docs_added_or_updated: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Deterministic evidence document created for the run." }],
|
|
723
|
+
acceptance_criteria: [
|
|
724
|
+
{
|
|
725
|
+
criterion,
|
|
726
|
+
evidence: `FORGE_PHASE5_CHANGESET.md was committed with content hash ${changesetHash}.`,
|
|
727
|
+
status: "satisfied"
|
|
728
|
+
}
|
|
729
|
+
],
|
|
730
|
+
known_gaps: [],
|
|
731
|
+
next_phase_context: "Review FORGE_PHASE5_CHANGESET.md and the bridge commit before validation."
|
|
732
|
+
};
|
|
733
|
+
}
|
|
734
|
+
if (phase === "debug_repro") {
|
|
735
|
+
return {
|
|
736
|
+
status: "pass",
|
|
737
|
+
summary: "forge-bridge reproduced the bug deterministically.",
|
|
738
|
+
repro_steps: ["Run the deterministic fake-worker debug reproduction."],
|
|
739
|
+
observed: "The configured bug scenario is reproducible in deterministic bridge mode.",
|
|
740
|
+
expected: "The bug scenario should be fixed before QA handoff.",
|
|
741
|
+
evidence: [{ kind: "changeset", path: "FORGE_PHASE5_CHANGESET.md", content_hash: changesetHash }]
|
|
742
|
+
};
|
|
743
|
+
}
|
|
744
|
+
if (phase === "debug_root_cause") {
|
|
745
|
+
return {
|
|
746
|
+
status: "pass",
|
|
747
|
+
summary: "forge-bridge isolated a deterministic root cause.",
|
|
748
|
+
root_cause: "The deterministic fake-worker bug is represented by the generated changeset evidence.",
|
|
749
|
+
evidence: [{ kind: "changeset", path: "FORGE_PHASE5_CHANGESET.md", content_hash: changesetHash }],
|
|
750
|
+
eliminated_alternatives: [{ summary: "No alternate deterministic fake-worker path was implicated." }],
|
|
751
|
+
risk_area: "forge-bridge deterministic debug lane"
|
|
752
|
+
};
|
|
753
|
+
}
|
|
754
|
+
if (phase === "debug_fix") {
|
|
755
|
+
return {
|
|
756
|
+
status: "pass",
|
|
757
|
+
summary: "forge-bridge applied a deterministic debug fix.",
|
|
758
|
+
changed_files: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Recorded deterministic debug fix evidence." }],
|
|
759
|
+
tests_added_or_updated: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Deterministic debug evidence doubles as fake-worker regression coverage." }],
|
|
760
|
+
remaining_risks: [],
|
|
761
|
+
resolved_findings: (dispatch.qaRework?.findingIds ?? []).map((qaId) => ({
|
|
762
|
+
qa_id: qaId,
|
|
763
|
+
status: "resolved",
|
|
764
|
+
summary: `Resolved deterministic QA finding ${qaId}.`,
|
|
765
|
+
evidence: { path: "FORGE_PHASE5_CHANGESET.md", content_hash: changesetHash },
|
|
766
|
+
changed_files: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Recorded deterministic debug fix evidence." }],
|
|
767
|
+
tests_added_or_updated: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Deterministic fake-worker regression evidence." }],
|
|
768
|
+
regression_evidence: [{ command: "forge-bridge deterministic debug regression", status: "pass" }]
|
|
769
|
+
}))
|
|
770
|
+
};
|
|
771
|
+
}
|
|
772
|
+
if (phase === "debug_regression") {
|
|
773
|
+
return {
|
|
774
|
+
status: "pass",
|
|
775
|
+
summary: "forge-bridge proved the deterministic debug regression is QA-ready.",
|
|
776
|
+
commands: [{ command: "forge-bridge deterministic debug regression", exit_code: 0, status: "pass", summary: "Deterministic debug regression completed." }],
|
|
777
|
+
required_regressions: ["Original deterministic repro no longer fails."],
|
|
778
|
+
build_status: "not_applicable",
|
|
779
|
+
test_status: "pass",
|
|
780
|
+
repro_negative: true,
|
|
781
|
+
qa_ready: true
|
|
782
|
+
};
|
|
783
|
+
}
|
|
784
|
+
if (phase === "self_review") {
|
|
785
|
+
return {
|
|
786
|
+
status: "pass",
|
|
787
|
+
summary: "forge-bridge fake worker completed deterministic self-review.",
|
|
788
|
+
reviewed_diff: true,
|
|
789
|
+
findings: [],
|
|
790
|
+
security_review: {
|
|
791
|
+
status: "pass",
|
|
792
|
+
notes: "No secret handling, auth, or destructive behavior changes were introduced by the deterministic changeset."
|
|
793
|
+
},
|
|
794
|
+
edge_case_review: {
|
|
795
|
+
status: "pass",
|
|
796
|
+
notes: "The deterministic fake-worker changeset is intentionally narrow and repeatable."
|
|
797
|
+
},
|
|
798
|
+
design_review: {
|
|
799
|
+
status: "not_applicable",
|
|
800
|
+
screenshots: [],
|
|
801
|
+
notes: "No UI changes."
|
|
802
|
+
},
|
|
803
|
+
deterministic_comparison: {
|
|
804
|
+
status: "pass",
|
|
805
|
+
command_or_tool: "git diff --stat HEAD~1..HEAD",
|
|
806
|
+
notes: `Reviewed deterministic changeset with content hash ${changesetHash}.`
|
|
807
|
+
},
|
|
808
|
+
fixes_applied: [],
|
|
809
|
+
remaining_risks: []
|
|
810
|
+
};
|
|
811
|
+
}
|
|
812
|
+
return {
|
|
813
|
+
status: "pass",
|
|
814
|
+
summary: "forge-bridge fake worker completed deterministic validation.",
|
|
815
|
+
commands: [
|
|
816
|
+
{
|
|
817
|
+
command: "git status --short && git diff --check",
|
|
818
|
+
exit_code: 0,
|
|
819
|
+
status: "pass",
|
|
820
|
+
summary: "Deterministic validation command completed for the fake-worker changeset."
|
|
821
|
+
}
|
|
822
|
+
],
|
|
823
|
+
acceptance_criteria: [
|
|
824
|
+
{
|
|
825
|
+
criterion,
|
|
826
|
+
evidence: `FORGE_PHASE5_CHANGESET.md exists with content hash ${changesetHash}.`,
|
|
827
|
+
status: "satisfied"
|
|
828
|
+
}
|
|
829
|
+
],
|
|
830
|
+
build_status: "pass",
|
|
831
|
+
test_status: "pass",
|
|
832
|
+
lint_status: "not_applicable",
|
|
833
|
+
design_status: "not_applicable",
|
|
834
|
+
drift_checks: [
|
|
835
|
+
{
|
|
836
|
+
command_or_tool: "git diff --check",
|
|
837
|
+
status: "pass",
|
|
838
|
+
summary: "No deterministic drift or whitespace errors were reported for the fake-worker changeset."
|
|
839
|
+
}
|
|
840
|
+
],
|
|
841
|
+
ready_for_dev_test: true
|
|
842
|
+
};
|
|
843
|
+
}
|
|
844
|
+
function deterministicArchitectPayload(dispatch) {
|
|
845
|
+
const planId = `architect-${dispatch.workItem.id.replace(/-/g, "")}`;
|
|
846
|
+
return {
|
|
847
|
+
status: "pass",
|
|
848
|
+
summary: "forge-bridge produced a deterministic Architect plan.",
|
|
849
|
+
implementation_plan: {
|
|
850
|
+
schema_version: 1,
|
|
851
|
+
plan_id: planId,
|
|
852
|
+
story_id: dispatch.workItem.id,
|
|
853
|
+
phases: [
|
|
854
|
+
{ id: "phase-1", name: "Foundation", tasks: ["task-1"], gate: "phase-1-gate" }
|
|
855
|
+
],
|
|
856
|
+
tasks: [
|
|
857
|
+
{
|
|
858
|
+
id: "task-1",
|
|
859
|
+
title: `Implement ${dispatch.workItem.title}`,
|
|
860
|
+
phase: "phase-1",
|
|
861
|
+
summary: "Deterministic bridge Architect task proving MCP artifact contract persistence.",
|
|
862
|
+
acceptance_criteria: [dispatch.workItem.acceptanceCriteria || `Preserve story intent for ${dispatch.workItem.title}`],
|
|
863
|
+
tests: [
|
|
864
|
+
{ command: "dotnet test /home/dillon/repos/Forge/Forge.sln --filter Architect", purpose: "Architect bridge contract regression" }
|
|
865
|
+
]
|
|
866
|
+
}
|
|
867
|
+
],
|
|
868
|
+
dependencies: [],
|
|
869
|
+
phase_gates: [
|
|
870
|
+
{ id: "phase-1-gate", phase: "phase-1", checks: ["Task tests pass", "Artifacts validate"] }
|
|
871
|
+
]
|
|
872
|
+
},
|
|
873
|
+
qa_plan: {
|
|
874
|
+
schema_version: 1,
|
|
875
|
+
plan_id: planId,
|
|
876
|
+
final_qa: [
|
|
877
|
+
{ id: "qa-1", coverage: `Verify Architect plan artifacts and pending approval status for ${dispatch.workItem.title}` }
|
|
878
|
+
]
|
|
879
|
+
},
|
|
880
|
+
report_markdown: `# Architect Report\n\nWork item: ${dispatch.workItem.id}\nTitle: ${dispatch.workItem.title}\n\nVerdict: pass\n\nDeterministic bridge Architect plan produced for pending approval.\n`
|
|
881
|
+
};
|
|
882
|
+
}
|
|
883
|
+
function deterministicQaGatePayload(options) {
|
|
884
|
+
const blocked = options.missingLaunchTarget;
|
|
885
|
+
const skippedBecauseBlocked = blocked
|
|
886
|
+
? {
|
|
887
|
+
status: "skipped",
|
|
888
|
+
summary: "Skipped because browser QA was blocked by missing launch target.",
|
|
889
|
+
reason: "Upstream browser QA blocker prevents meaningful downstream evidence."
|
|
890
|
+
}
|
|
891
|
+
: null;
|
|
892
|
+
switch (options.gate) {
|
|
893
|
+
case "qa_plan":
|
|
894
|
+
return {
|
|
895
|
+
status: "pass",
|
|
896
|
+
summary: "Deterministic QA plan recorded.",
|
|
897
|
+
checklist: [
|
|
898
|
+
"Review the validated work item against acceptance criteria.",
|
|
899
|
+
"Run deterministic regression evidence.",
|
|
900
|
+
"Confirm no in-scope QA findings remain."
|
|
901
|
+
],
|
|
902
|
+
acceptance_criteria: [options.criterion]
|
|
903
|
+
};
|
|
904
|
+
case "qa_regression":
|
|
905
|
+
return {
|
|
906
|
+
status: "pass",
|
|
907
|
+
summary: "Deterministic regression QA completed.",
|
|
908
|
+
commands: [
|
|
909
|
+
{
|
|
910
|
+
command: "forge-bridge deterministic QA",
|
|
911
|
+
exit_code: 0,
|
|
912
|
+
status: "pass",
|
|
913
|
+
summary: "Deterministic regression evidence completed."
|
|
914
|
+
}
|
|
915
|
+
],
|
|
916
|
+
notes: "Regression gate passed in deterministic fake-worker mode."
|
|
917
|
+
};
|
|
918
|
+
case "qa_api":
|
|
919
|
+
return {
|
|
920
|
+
status: "skipped",
|
|
921
|
+
summary: "No API/backend surface was identified for deterministic QA.",
|
|
922
|
+
reason: "The deterministic fake-worker changeset does not exercise API/backend behavior."
|
|
923
|
+
};
|
|
924
|
+
case "qa_manual_web":
|
|
925
|
+
return blocked
|
|
926
|
+
? {
|
|
927
|
+
status: "blocked",
|
|
928
|
+
summary: "Browser QA could not run because no app launch target was provided.",
|
|
929
|
+
blocker_reason: "missing_app_launch_target"
|
|
930
|
+
}
|
|
931
|
+
: options.browserChecks.length > 0
|
|
932
|
+
? {
|
|
933
|
+
status: "pass",
|
|
934
|
+
summary: "Deterministic browser QA exercised the configured launch target.",
|
|
935
|
+
browser_checks: options.browserChecks,
|
|
936
|
+
sidecars: options.sidecars,
|
|
937
|
+
notes: "Browser sidecar evidence recorded."
|
|
938
|
+
}
|
|
939
|
+
: {
|
|
940
|
+
status: "skipped",
|
|
941
|
+
summary: "Manual web QA was not required for this deterministic run.",
|
|
942
|
+
reason: "Forge did not require browser QA and no launch target was necessary."
|
|
943
|
+
};
|
|
944
|
+
case "qa_bug_repro":
|
|
945
|
+
return skippedBecauseBlocked ?? {
|
|
946
|
+
status: "skipped",
|
|
947
|
+
summary: "No failed QA observation required bug reproduction.",
|
|
948
|
+
reason: "No defects or candidate bugs were observed."
|
|
949
|
+
};
|
|
950
|
+
case "qa_findings":
|
|
951
|
+
return skippedBecauseBlocked ?? {
|
|
952
|
+
status: "pass",
|
|
953
|
+
summary: "No QA findings or candidate bugs were identified.",
|
|
954
|
+
findings: [],
|
|
955
|
+
candidate_bugs: []
|
|
956
|
+
};
|
|
957
|
+
case "qa_verdict":
|
|
958
|
+
return {
|
|
959
|
+
status: blocked ? "blocked" : "pass",
|
|
960
|
+
summary: options.summary,
|
|
961
|
+
checklist: [
|
|
962
|
+
"Review the validated work item against acceptance criteria.",
|
|
963
|
+
"Run deterministic regression evidence.",
|
|
964
|
+
blocked ? "Record missing browser launch target blocker." : "Confirm no in-scope QA findings remain."
|
|
965
|
+
],
|
|
966
|
+
tested_acceptance_criteria: blocked ? [] : [options.criterion],
|
|
967
|
+
commands: blocked
|
|
968
|
+
? []
|
|
969
|
+
: [
|
|
970
|
+
{
|
|
971
|
+
command: "forge-bridge deterministic QA",
|
|
972
|
+
exit_code: 0,
|
|
973
|
+
status: "pass",
|
|
974
|
+
summary: "Deterministic QA command completed."
|
|
975
|
+
}
|
|
976
|
+
],
|
|
977
|
+
browser_checks: blocked ? [] : options.browserChecks,
|
|
978
|
+
sidecars: blocked ? [] : options.sidecars,
|
|
979
|
+
notes: options.summary,
|
|
980
|
+
findings: [],
|
|
981
|
+
candidate_bugs: [],
|
|
982
|
+
blocker_reason: blocked ? "missing_app_launch_target" : null,
|
|
983
|
+
report_markdown: `# QA report\n\n${options.summary}\n`
|
|
984
|
+
};
|
|
985
|
+
}
|
|
986
|
+
}
|
|
987
|
+
const qaArtifactFileNames = {
|
|
988
|
+
plan: "qa.plan.json",
|
|
989
|
+
evidence: "qa.evidence.json",
|
|
990
|
+
findings: "qa.findings.json",
|
|
991
|
+
verdict: "qa.verdict.json",
|
|
992
|
+
report: "qa.report.md"
|
|
993
|
+
};
|
|
994
|
+
const qaGateArtifactFileNames = {
|
|
995
|
+
qa_plan: "qa.plan.json",
|
|
996
|
+
qa_regression: "qa.regression.json",
|
|
997
|
+
qa_api: "qa.api.json",
|
|
998
|
+
qa_manual_web: "qa.manual-web.json",
|
|
999
|
+
qa_bug_repro: "qa.bug-repro.json",
|
|
1000
|
+
qa_findings: "qa.findings.json",
|
|
1001
|
+
qa_verdict: "qa.verdict.json"
|
|
1002
|
+
};
|
|
1003
|
+
function hasLaunchTarget(target) {
|
|
1004
|
+
return Boolean(target?.url?.trim()
|
|
1005
|
+
|| target?.ready_url?.trim()
|
|
1006
|
+
|| target?.command?.trim()
|
|
1007
|
+
|| (target?.routes ?? []).some((route) => route.trim().length > 0));
|
|
1008
|
+
}
|
|
1009
|
+
function deterministicBrowserSidecar(workItemId, target, ownerType, ownerId) {
|
|
1010
|
+
const route = primaryLaunchRoute(target);
|
|
1011
|
+
return {
|
|
1012
|
+
relativePath: qaArtifactRelativePath(workItemId, "qa/screenshots/deterministic-browser-check.txt", ownerType, ownerId),
|
|
1013
|
+
content: `Deterministic Forge QA browser evidence\nRoute: ${route}\nConsole errors: []\nNetwork errors: []\nResponsive checks: desktop, mobile\n`
|
|
1014
|
+
};
|
|
1015
|
+
}
|
|
1016
|
+
function deterministicBrowserCheck(target, screenshotPath) {
|
|
1017
|
+
const route = primaryLaunchRoute(target);
|
|
1018
|
+
return {
|
|
1019
|
+
route,
|
|
1020
|
+
url: route,
|
|
1021
|
+
status: "pass",
|
|
1022
|
+
summary: "Deterministic browser QA exercised the configured launch target.",
|
|
1023
|
+
actions: ["open launch target", "walk acceptance criteria", "check console/network summaries", "check responsive viewport"],
|
|
1024
|
+
screenshots: [screenshotPath],
|
|
1025
|
+
console_errors: [],
|
|
1026
|
+
network_errors: [],
|
|
1027
|
+
responsive_checks: ["desktop", "mobile"]
|
|
1028
|
+
};
|
|
1029
|
+
}
|
|
1030
|
+
function primaryLaunchRoute(target) {
|
|
1031
|
+
return target.ready_url?.trim()
|
|
1032
|
+
|| target.url?.trim()
|
|
1033
|
+
|| target.routes.find((route) => route.trim().length > 0)?.trim()
|
|
1034
|
+
|| "app launch command";
|
|
1035
|
+
}
|
|
1036
|
+
async function writeQaSidecarFiles(worktreePath, files) {
|
|
1037
|
+
const sidecars = [];
|
|
1038
|
+
for (const file of files) {
|
|
1039
|
+
const fullPath = path.resolve(worktreePath, file.relativePath);
|
|
1040
|
+
const relativePath = path.relative(worktreePath, fullPath).split(path.sep).join("/");
|
|
1041
|
+
if (relativePath.startsWith("..") || path.isAbsolute(relativePath)) {
|
|
1042
|
+
throw new Error(`QA sidecar path must stay under the worktree: ${file.relativePath}`);
|
|
1043
|
+
}
|
|
1044
|
+
await fs.mkdir(path.dirname(fullPath), { recursive: true });
|
|
1045
|
+
await fs.writeFile(fullPath, file.content, "utf8");
|
|
1046
|
+
sidecars.push({
|
|
1047
|
+
path: relativePath,
|
|
1048
|
+
content_hash: sha256(file.content),
|
|
1049
|
+
bytes: Buffer.byteLength(file.content, "utf8")
|
|
1050
|
+
});
|
|
1051
|
+
}
|
|
1052
|
+
return sidecars;
|
|
1053
|
+
}
|
|
1054
|
+
async function emitQaArtifactRecorded(emit, worktreePath, artifact) {
|
|
1055
|
+
const relativePath = path.relative(worktreePath, artifact.path) || path.basename(artifact.path);
|
|
1056
|
+
await emit({
|
|
1057
|
+
role: "tool",
|
|
1058
|
+
kind: "tool_result",
|
|
1059
|
+
content: `Forge QA artifact recorded ${relativePath} (${artifact.status}).`,
|
|
1060
|
+
eventType: "qa_artifact_recorded"
|
|
1061
|
+
});
|
|
1062
|
+
await emit({
|
|
1063
|
+
role: "hook",
|
|
1064
|
+
kind: "checkpoint",
|
|
1065
|
+
content: `phase_gate: qa artifact accepted with status ${artifact.status}.`,
|
|
1066
|
+
eventType: "phase_gate"
|
|
1067
|
+
});
|
|
1068
|
+
}
|
|
1069
|
+
async function readQaCompletionArtifactBundle(worktreePath, workItemId, ownerType, ownerId) {
|
|
1070
|
+
const artifact = await readCompletionArtifact(worktreePath, workItemId, "qa", ownerType, ownerId);
|
|
1071
|
+
if (!artifact || !await hasCompleteQaArtifactBundle(worktreePath, workItemId, ownerType, ownerId)) {
|
|
1072
|
+
return null;
|
|
1073
|
+
}
|
|
1074
|
+
const artifactRoot = ownerType && ownerId
|
|
1075
|
+
? artifactRootForOwner(worktreePath, ownerType, ownerId)
|
|
1076
|
+
: artifactRootFor(worktreePath, workItemId);
|
|
1077
|
+
const planJson = await fs.readFile(path.join(artifactRoot, qaArtifactFileNames.plan), "utf8");
|
|
1078
|
+
const evidenceJson = await fs.readFile(path.join(artifactRoot, qaArtifactFileNames.evidence), "utf8");
|
|
1079
|
+
const findingsJson = await fs.readFile(path.join(artifactRoot, qaArtifactFileNames.findings), "utf8");
|
|
1080
|
+
await validateQaBundleSidecarReferences(worktreePath, workItemId, ownerType, ownerId);
|
|
1081
|
+
return {
|
|
1082
|
+
...artifact,
|
|
1083
|
+
planJson,
|
|
1084
|
+
evidenceJson,
|
|
1085
|
+
findingsJson
|
|
1086
|
+
};
|
|
1087
|
+
}
|
|
1088
|
+
async function hasCompleteQaArtifactBundle(worktreePath, workItemId, ownerType, ownerId) {
|
|
1089
|
+
const artifactRoot = ownerType && ownerId
|
|
1090
|
+
? artifactRootForOwner(worktreePath, ownerType, ownerId)
|
|
1091
|
+
: artifactRootFor(worktreePath, workItemId);
|
|
1092
|
+
for (const fileName of Object.values(qaArtifactFileNames)) {
|
|
1093
|
+
try {
|
|
1094
|
+
const stat = await fs.stat(path.join(artifactRoot, fileName));
|
|
1095
|
+
if (!stat.isFile()) {
|
|
1096
|
+
return false;
|
|
1097
|
+
}
|
|
1098
|
+
}
|
|
1099
|
+
catch (error) {
|
|
1100
|
+
if (isNodeError(error) && error.code === "ENOENT") {
|
|
1101
|
+
return false;
|
|
1102
|
+
}
|
|
1103
|
+
throw error;
|
|
1104
|
+
}
|
|
1105
|
+
}
|
|
1106
|
+
return true;
|
|
1107
|
+
}
|
|
1108
|
+
function enforceQaBrowserLaunchTargetGate(dispatch, artifact) {
|
|
1109
|
+
const qaBrowser = dispatch.qaBrowser;
|
|
1110
|
+
if (!qaBrowser?.required || hasLaunchTarget(qaBrowser.launchTarget ?? null)) {
|
|
1111
|
+
return;
|
|
1112
|
+
}
|
|
1113
|
+
const verdict = parseJsonLine(artifact.verdictJson) ?? {};
|
|
1114
|
+
const status = normalizedString(stringField(verdict, "status") ?? artifact.status ?? "");
|
|
1115
|
+
const blockerReason = normalizedString(stringField(verdict, "blocker_reason") ?? "");
|
|
1116
|
+
if (status !== "blocked" || blockerReason !== "missing_app_launch_target") {
|
|
1117
|
+
throw new Error("QA browser testing is required but no app launch target was provided; provider must return blocked with blocker_reason missing_app_launch_target.");
|
|
1118
|
+
}
|
|
1119
|
+
}
|
|
1120
|
+
async function validateQaBundleSidecarReferences(worktreePath, workItemId, ownerType, ownerId) {
|
|
1121
|
+
const artifactRoot = ownerType && ownerId
|
|
1122
|
+
? artifactRootForOwner(worktreePath, ownerType, ownerId)
|
|
1123
|
+
: artifactRootFor(worktreePath, workItemId);
|
|
1124
|
+
const evidence = await readJsonObjectFile(path.join(artifactRoot, qaArtifactFileNames.evidence));
|
|
1125
|
+
const sidecars = arrayField(evidence, "sidecars");
|
|
1126
|
+
if (sidecars.length === 0) {
|
|
1127
|
+
return;
|
|
1128
|
+
}
|
|
1129
|
+
const qaSidecarRoot = path.resolve(artifactRoot, "qa");
|
|
1130
|
+
for (const [index, sidecar] of sidecars.entries()) {
|
|
1131
|
+
const sidecarPath = stringField(sidecar, "path");
|
|
1132
|
+
const expectedHash = stringField(sidecar, "content_hash");
|
|
1133
|
+
const expectedBytes = sidecar.bytes;
|
|
1134
|
+
if (!sidecarPath || !expectedHash || typeof expectedBytes !== "number" || !Number.isFinite(expectedBytes) || expectedBytes <= 0) {
|
|
1135
|
+
throw new Error(`QA sidecar ${index} must include path, content_hash, and positive bytes.`);
|
|
1136
|
+
}
|
|
1137
|
+
if (path.isAbsolute(sidecarPath)) {
|
|
1138
|
+
throw new Error(`QA sidecar ${index} path must be relative to the worktree.`);
|
|
1139
|
+
}
|
|
1140
|
+
const fullPath = path.resolve(worktreePath, sidecarPath);
|
|
1141
|
+
if (!isPathUnderRoot(qaSidecarRoot, fullPath)) {
|
|
1142
|
+
const ownerDirectory = ownerType && ownerId && ownerType.trim().toLowerCase() === "story" ? "stories" : "work-items";
|
|
1143
|
+
const ownerSegment = ownerType && ownerId ? ownerId : workItemId;
|
|
1144
|
+
throw new Error(`QA sidecar ${index} path must be under .forge/${ownerDirectory}/${ownerSegment}/artifacts/qa/.`);
|
|
1145
|
+
}
|
|
1146
|
+
const stat = await fs.lstat(fullPath).catch((error) => {
|
|
1147
|
+
if (isNodeError(error) && error.code === "ENOENT") {
|
|
1148
|
+
throw new Error(`QA sidecar ${index} file does not exist: ${sidecarPath}`);
|
|
1149
|
+
}
|
|
1150
|
+
throw error;
|
|
1151
|
+
});
|
|
1152
|
+
if (!stat.isFile() || stat.isSymbolicLink()) {
|
|
1153
|
+
throw new Error(`QA sidecar ${index} must reference a regular file.`);
|
|
1154
|
+
}
|
|
1155
|
+
await ensureNoSymbolicLinkPathSegments(qaSidecarRoot, path.dirname(fullPath), `QA sidecar ${index} path must not traverse symbolic links.`);
|
|
1156
|
+
if (stat.size !== expectedBytes) {
|
|
1157
|
+
throw new Error(`QA sidecar ${index} bytes do not match the referenced file.`);
|
|
1158
|
+
}
|
|
1159
|
+
const actualHash = await sha256File(fullPath);
|
|
1160
|
+
if (actualHash !== expectedHash.trim().toLowerCase()) {
|
|
1161
|
+
throw new Error(`QA sidecar ${index} content_hash does not match the referenced file.`);
|
|
1162
|
+
}
|
|
1163
|
+
}
|
|
1164
|
+
}
|
|
1165
|
+
async function emitQaStructuredEvents(emit, artifact) {
|
|
1166
|
+
const artifactRoot = path.dirname(artifact.path);
|
|
1167
|
+
const plan = await readJsonObjectFile(path.join(artifactRoot, qaArtifactFileNames.plan));
|
|
1168
|
+
const evidence = await readJsonObjectFile(path.join(artifactRoot, qaArtifactFileNames.evidence));
|
|
1169
|
+
const findings = await readJsonObjectFile(path.join(artifactRoot, qaArtifactFileNames.findings));
|
|
1170
|
+
const verdict = parseJsonLine(artifact.verdictJson) ?? {};
|
|
1171
|
+
const status = stringField(verdict, "status") ?? artifact.status ?? "unknown";
|
|
1172
|
+
const checklist = stringArrayField(plan, "checklist");
|
|
1173
|
+
await emit({
|
|
1174
|
+
role: "worker",
|
|
1175
|
+
kind: "message",
|
|
1176
|
+
content: checklist.length > 0
|
|
1177
|
+
? `QA plan: ${checklist.join("; ")}`
|
|
1178
|
+
: "QA plan recorded.",
|
|
1179
|
+
eventType: "qa_plan"
|
|
1180
|
+
});
|
|
1181
|
+
for (const browserCheck of arrayField(evidence, "browser_checks")) {
|
|
1182
|
+
await emit({
|
|
1183
|
+
role: "worker",
|
|
1184
|
+
kind: "checkpoint",
|
|
1185
|
+
content: `QA browser check: ${summarizeQaObject(browserCheck)}`,
|
|
1186
|
+
eventType: "qa_browser_check"
|
|
1187
|
+
});
|
|
1188
|
+
}
|
|
1189
|
+
for (const finding of [...arrayField(findings, "findings"), ...arrayField(findings, "candidate_bugs")]) {
|
|
1190
|
+
await emit({
|
|
1191
|
+
role: "worker",
|
|
1192
|
+
kind: "checkpoint",
|
|
1193
|
+
content: `QA finding: ${summarizeQaObject(finding)}`,
|
|
1194
|
+
eventType: "qa_finding"
|
|
1195
|
+
});
|
|
1196
|
+
}
|
|
1197
|
+
await emit({
|
|
1198
|
+
role: "assistant",
|
|
1199
|
+
kind: "message",
|
|
1200
|
+
content: status === "blocked"
|
|
1201
|
+
? `QA blocked: ${stringField(verdict, "summary") ?? "No summary provided."}`
|
|
1202
|
+
: `QA completed with status ${status}: ${stringField(verdict, "summary") ?? "No summary provided."}`,
|
|
1203
|
+
eventType: status === "blocked" ? "qa_blocked" : "qa_complete"
|
|
1204
|
+
});
|
|
1205
|
+
}
|
|
1206
|
+
function qaArtifactRootForDispatch(worktreePath, workItemId, dispatch) {
|
|
1207
|
+
return dispatch.cycleRun.ownerType && dispatch.cycleRun.ownerId
|
|
1208
|
+
? artifactRootForOwner(worktreePath, dispatch.cycleRun.ownerType, dispatch.cycleRun.ownerId)
|
|
1209
|
+
: artifactRootFor(worktreePath, workItemId);
|
|
1210
|
+
}
|
|
1211
|
+
async function readQaGateArtifact(artifactRoot, gate) {
|
|
1212
|
+
const artifactPath = path.join(artifactRoot, qaGateArtifactFileNames[gate]);
|
|
1213
|
+
try {
|
|
1214
|
+
const stat = await fs.stat(artifactPath);
|
|
1215
|
+
if (!stat.isFile()) {
|
|
1216
|
+
return null;
|
|
1217
|
+
}
|
|
1218
|
+
}
|
|
1219
|
+
catch (error) {
|
|
1220
|
+
if (isNodeError(error) && error.code === "ENOENT") {
|
|
1221
|
+
return null;
|
|
1222
|
+
}
|
|
1223
|
+
throw error;
|
|
1224
|
+
}
|
|
1225
|
+
const payload = await readJsonObjectFile(artifactPath);
|
|
1226
|
+
return {
|
|
1227
|
+
gate,
|
|
1228
|
+
path: artifactPath,
|
|
1229
|
+
status: stringField(payload, "status") ?? "unknown",
|
|
1230
|
+
producedBy: stringField(payload, "produced_by") ?? stringField(payload, "producedBy") ?? undefined,
|
|
1231
|
+
contentHash: stringField(payload, "content_hash") ?? undefined
|
|
1232
|
+
};
|
|
1233
|
+
}
|
|
1234
|
+
function nextQaGate(gate) {
|
|
1235
|
+
const index = qaCompletionGateOrder.indexOf(gate);
|
|
1236
|
+
return index >= 0 ? qaCompletionGateOrder[index + 1] ?? null : null;
|
|
1237
|
+
}
|
|
1238
|
+
async function emitQaGateAccepted(emit, worktreePath, artifact, nextGate) {
|
|
1239
|
+
const relativePath = path.relative(worktreePath, artifact.path).split(path.sep).join("/");
|
|
1240
|
+
await emit({
|
|
1241
|
+
role: "hook",
|
|
1242
|
+
kind: artifact.status === "blocked" ? "error" : "checkpoint",
|
|
1243
|
+
content: `phase_gate: ${artifact.gate} artifact accepted with status ${artifact.status}.`,
|
|
1244
|
+
eventType: "phase_gate",
|
|
1245
|
+
data: JSON.stringify({
|
|
1246
|
+
phase: "qa",
|
|
1247
|
+
qa_gate: artifact.gate,
|
|
1248
|
+
status: artifact.status,
|
|
1249
|
+
artifact_relative_paths: [relativePath],
|
|
1250
|
+
content_hash: artifact.contentHash ?? null,
|
|
1251
|
+
produced_by: artifact.producedBy ?? null
|
|
1252
|
+
})
|
|
1253
|
+
});
|
|
1254
|
+
if (!nextGate) {
|
|
1255
|
+
return;
|
|
1256
|
+
}
|
|
1257
|
+
await emit({
|
|
1258
|
+
role: "hook",
|
|
1259
|
+
kind: "checkpoint",
|
|
1260
|
+
content: `phase_progression: ${artifact.gate} -> ${nextGate}`,
|
|
1261
|
+
eventType: "phase_gate",
|
|
1262
|
+
data: JSON.stringify({
|
|
1263
|
+
phase: "qa",
|
|
1264
|
+
from_gate: artifact.gate,
|
|
1265
|
+
to_gate: nextGate
|
|
1266
|
+
})
|
|
1267
|
+
});
|
|
1268
|
+
}
|
|
1269
|
+
class LiveQaArtifactEmitter {
|
|
1270
|
+
worktreePath;
|
|
1271
|
+
workItemId;
|
|
1272
|
+
dispatch;
|
|
1273
|
+
emit;
|
|
1274
|
+
emittedBundle = false;
|
|
1275
|
+
emittedGates = new Set();
|
|
1276
|
+
timer = null;
|
|
1277
|
+
pending = Promise.resolve();
|
|
1278
|
+
constructor(worktreePath, workItemId, dispatch, emit) {
|
|
1279
|
+
this.worktreePath = worktreePath;
|
|
1280
|
+
this.workItemId = workItemId;
|
|
1281
|
+
this.dispatch = dispatch;
|
|
1282
|
+
this.emit = emit;
|
|
1283
|
+
}
|
|
1284
|
+
start() {
|
|
1285
|
+
void this.pollQueued();
|
|
1286
|
+
this.timer = setInterval(() => {
|
|
1287
|
+
void this.pollQueued();
|
|
1288
|
+
}, 250);
|
|
1289
|
+
}
|
|
1290
|
+
async stop() {
|
|
1291
|
+
if (this.timer) {
|
|
1292
|
+
clearInterval(this.timer);
|
|
1293
|
+
this.timer = null;
|
|
1294
|
+
}
|
|
1295
|
+
await this.pollQueued();
|
|
1296
|
+
}
|
|
1297
|
+
hasEmitted() {
|
|
1298
|
+
return this.emittedBundle;
|
|
1299
|
+
}
|
|
1300
|
+
pollQueued() {
|
|
1301
|
+
this.pending = this.pending
|
|
1302
|
+
.then(() => this.poll())
|
|
1303
|
+
.catch(() => undefined);
|
|
1304
|
+
return this.pending;
|
|
1305
|
+
}
|
|
1306
|
+
async poll() {
|
|
1307
|
+
await this.emitAvailableGateEvents();
|
|
1308
|
+
if (this.emittedBundle) {
|
|
1309
|
+
return;
|
|
1310
|
+
}
|
|
1311
|
+
const artifact = await readQaCompletionArtifactBundle(this.worktreePath, this.workItemId, this.dispatch.cycleRun.ownerType, this.dispatch.cycleRun.ownerId);
|
|
1312
|
+
if (!artifact) {
|
|
1313
|
+
return;
|
|
1314
|
+
}
|
|
1315
|
+
enforceQaBrowserLaunchTargetGate(this.dispatch, artifact);
|
|
1316
|
+
this.emittedBundle = true;
|
|
1317
|
+
await emitQaArtifactRecorded(this.emit, this.worktreePath, artifact);
|
|
1318
|
+
await emitQaStructuredEvents(this.emit, artifact);
|
|
1319
|
+
}
|
|
1320
|
+
async emitAvailableGateEvents() {
|
|
1321
|
+
const artifactRoot = qaArtifactRootForDispatch(this.worktreePath, this.workItemId, this.dispatch);
|
|
1322
|
+
for (const gate of qaCompletionGateOrder) {
|
|
1323
|
+
if (this.emittedGates.has(gate)) {
|
|
1324
|
+
continue;
|
|
1325
|
+
}
|
|
1326
|
+
const artifact = await readQaGateArtifact(artifactRoot, gate);
|
|
1327
|
+
if (!artifact) {
|
|
1328
|
+
return;
|
|
1329
|
+
}
|
|
1330
|
+
this.emittedGates.add(gate);
|
|
1331
|
+
await emitQaGateAccepted(this.emit, this.worktreePath, artifact, nextQaGate(gate));
|
|
1332
|
+
}
|
|
1333
|
+
}
|
|
1334
|
+
}
|
|
1335
|
+
class LiveArchitectArtifactEmitter {
|
|
1336
|
+
worktreePath;
|
|
1337
|
+
workItemId;
|
|
1338
|
+
emit;
|
|
1339
|
+
emitted = false;
|
|
1340
|
+
timer = null;
|
|
1341
|
+
pending = Promise.resolve();
|
|
1342
|
+
constructor(worktreePath, workItemId, emit) {
|
|
1343
|
+
this.worktreePath = worktreePath;
|
|
1344
|
+
this.workItemId = workItemId;
|
|
1345
|
+
this.emit = emit;
|
|
1346
|
+
}
|
|
1347
|
+
start() {
|
|
1348
|
+
void this.pollQueued();
|
|
1349
|
+
this.timer = setInterval(() => {
|
|
1350
|
+
void this.pollQueued();
|
|
1351
|
+
}, 250);
|
|
1352
|
+
}
|
|
1353
|
+
async stop() {
|
|
1354
|
+
if (this.timer) {
|
|
1355
|
+
clearInterval(this.timer);
|
|
1356
|
+
this.timer = null;
|
|
1357
|
+
}
|
|
1358
|
+
await this.pollQueued();
|
|
1359
|
+
}
|
|
1360
|
+
hasEmitted() {
|
|
1361
|
+
return this.emitted;
|
|
1362
|
+
}
|
|
1363
|
+
pollQueued() {
|
|
1364
|
+
this.pending = this.pending
|
|
1365
|
+
.then(() => this.poll())
|
|
1366
|
+
.catch(() => undefined);
|
|
1367
|
+
return this.pending;
|
|
1368
|
+
}
|
|
1369
|
+
async poll() {
|
|
1370
|
+
if (this.emitted || !await hasCompleteArchitectArtifactBundle(this.worktreePath, this.workItemId)) {
|
|
1371
|
+
return;
|
|
1372
|
+
}
|
|
1373
|
+
const artifact = await readCompletionArtifact(this.worktreePath, this.workItemId, "architect");
|
|
1374
|
+
if (!artifact) {
|
|
1375
|
+
return;
|
|
1376
|
+
}
|
|
1377
|
+
this.emitted = true;
|
|
1378
|
+
await emitCompletionArtifactRecorded(this.emit, this.worktreePath, artifact);
|
|
1379
|
+
await emitArchitectStructuredEvents(this.emit, this.worktreePath, this.workItemId, artifact);
|
|
328
1380
|
}
|
|
329
|
-
|
|
330
|
-
|
|
331
|
-
|
|
332
|
-
|
|
333
|
-
|
|
334
|
-
|
|
335
|
-
|
|
336
|
-
|
|
337
|
-
|
|
338
|
-
}
|
|
339
|
-
|
|
340
|
-
|
|
341
|
-
|
|
1381
|
+
}
|
|
1382
|
+
async function hasCompleteArchitectArtifactBundle(worktreePath, workItemId) {
|
|
1383
|
+
const artifactRoot = artifactRootFor(worktreePath, workItemId);
|
|
1384
|
+
for (const fileName of ["implementation.plan.json", "qa.plan.json", "architect.verdict.json", "architect.report.md"]) {
|
|
1385
|
+
try {
|
|
1386
|
+
const stat = await fs.stat(path.join(artifactRoot, fileName));
|
|
1387
|
+
if (!stat.isFile()) {
|
|
1388
|
+
return false;
|
|
1389
|
+
}
|
|
1390
|
+
}
|
|
1391
|
+
catch (error) {
|
|
1392
|
+
if (isNodeError(error) && error.code === "ENOENT") {
|
|
1393
|
+
return false;
|
|
1394
|
+
}
|
|
1395
|
+
throw error;
|
|
1396
|
+
}
|
|
342
1397
|
}
|
|
1398
|
+
return true;
|
|
343
1399
|
}
|
|
344
|
-
function
|
|
345
|
-
|
|
1400
|
+
async function emitArchitectStructuredEvents(emit, worktreePath, workItemId, artifact) {
|
|
1401
|
+
const artifactRoot = artifactRootFor(worktreePath, workItemId);
|
|
1402
|
+
const implementationPlan = await readJsonObjectFile(path.join(artifactRoot, "implementation.plan.json"));
|
|
1403
|
+
const qaPlan = await readJsonObjectFile(path.join(artifactRoot, "qa.plan.json"));
|
|
1404
|
+
const verdict = parseJsonLine(artifact.verdictJson) ?? {};
|
|
1405
|
+
const status = stringField(verdict, "status") ?? artifact.status ?? "unknown";
|
|
1406
|
+
const planId = stringField(implementationPlan, "plan_id") ?? "unknown";
|
|
1407
|
+
await emit({
|
|
1408
|
+
role: "worker",
|
|
1409
|
+
kind: "checkpoint",
|
|
1410
|
+
content: `Architect plan recorded: ${planId} with ${arrayField(implementationPlan, "phases").length} phases and ${arrayField(implementationPlan, "tasks").length} tasks.`,
|
|
1411
|
+
eventType: "architect_plan"
|
|
1412
|
+
});
|
|
1413
|
+
await emit({
|
|
1414
|
+
role: "worker",
|
|
1415
|
+
kind: "checkpoint",
|
|
1416
|
+
content: `Architect QA seed recorded with ${arrayField(qaPlan, "final_qa").length} final QA items.`,
|
|
1417
|
+
eventType: "architect_qa_seed"
|
|
1418
|
+
});
|
|
1419
|
+
await emit({
|
|
1420
|
+
role: "hook",
|
|
1421
|
+
kind: status === "pass" ? "checkpoint" : "error",
|
|
1422
|
+
content: `architect_mcp_complete: ${status === "pass" ? "accepted" : "recorded"} - ${stringField(verdict, "summary") ?? "Architect completion payload recorded."}`,
|
|
1423
|
+
eventType: "architect_mcp_complete"
|
|
1424
|
+
});
|
|
346
1425
|
}
|
|
347
|
-
function
|
|
348
|
-
const
|
|
349
|
-
|
|
350
|
-
|
|
351
|
-
|
|
352
|
-
|
|
353
|
-
|
|
354
|
-
|
|
355
|
-
changed_files: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Recorded deterministic bridge evidence." }],
|
|
356
|
-
tests_added_or_updated: [{ name: "forge_bridge_run_once", evidence: "The bridge committed FORGE_PHASE5_CHANGESET.md." }],
|
|
357
|
-
docs_added_or_updated: [{ path: "FORGE_PHASE5_CHANGESET.md", summary: "Deterministic evidence document created for the run." }],
|
|
358
|
-
acceptance_criteria: [
|
|
359
|
-
{
|
|
360
|
-
criterion,
|
|
361
|
-
evidence: `FORGE_PHASE5_CHANGESET.md was committed with content hash ${changesetHash}.`,
|
|
362
|
-
status: "satisfied"
|
|
363
|
-
}
|
|
364
|
-
],
|
|
365
|
-
known_gaps: [],
|
|
366
|
-
next_phase_context: "Review FORGE_PHASE5_CHANGESET.md and the bridge commit before validation."
|
|
367
|
-
};
|
|
1426
|
+
async function readJsonObjectFile(filePath) {
|
|
1427
|
+
const content = await fs.readFile(filePath, "utf8").catch(() => "");
|
|
1428
|
+
return parseJsonLine(content) ?? {};
|
|
1429
|
+
}
|
|
1430
|
+
function arrayField(source, key) {
|
|
1431
|
+
const value = source[key];
|
|
1432
|
+
if (!Array.isArray(value)) {
|
|
1433
|
+
return [];
|
|
368
1434
|
}
|
|
369
|
-
|
|
370
|
-
|
|
371
|
-
|
|
372
|
-
|
|
373
|
-
|
|
374
|
-
|
|
375
|
-
security_review: {
|
|
376
|
-
status: "pass",
|
|
377
|
-
notes: "No secret handling, auth, or destructive behavior changes were introduced by the deterministic changeset."
|
|
378
|
-
},
|
|
379
|
-
edge_case_review: {
|
|
380
|
-
status: "pass",
|
|
381
|
-
notes: "The deterministic fake-worker changeset is intentionally narrow and repeatable."
|
|
382
|
-
},
|
|
383
|
-
design_review: {
|
|
384
|
-
status: "not_applicable",
|
|
385
|
-
screenshots: [],
|
|
386
|
-
notes: "No UI changes."
|
|
387
|
-
},
|
|
388
|
-
deterministic_comparison: {
|
|
389
|
-
status: "pass",
|
|
390
|
-
command_or_tool: "git diff --stat HEAD~1..HEAD",
|
|
391
|
-
notes: `Reviewed deterministic changeset with content hash ${changesetHash}.`
|
|
392
|
-
},
|
|
393
|
-
fixes_applied: [],
|
|
394
|
-
remaining_risks: []
|
|
395
|
-
};
|
|
1435
|
+
return value.filter((entry) => Boolean(entry) && typeof entry === "object" && !Array.isArray(entry));
|
|
1436
|
+
}
|
|
1437
|
+
function stringArrayField(source, key) {
|
|
1438
|
+
const value = source[key];
|
|
1439
|
+
if (!Array.isArray(value)) {
|
|
1440
|
+
return [];
|
|
396
1441
|
}
|
|
397
|
-
return
|
|
398
|
-
|
|
399
|
-
|
|
400
|
-
|
|
401
|
-
|
|
402
|
-
|
|
403
|
-
|
|
404
|
-
|
|
405
|
-
|
|
406
|
-
|
|
407
|
-
|
|
408
|
-
|
|
409
|
-
|
|
410
|
-
|
|
411
|
-
evidence: `FORGE_PHASE5_CHANGESET.md exists with content hash ${changesetHash}.`,
|
|
412
|
-
status: "satisfied"
|
|
413
|
-
}
|
|
414
|
-
],
|
|
415
|
-
build_status: "pass",
|
|
416
|
-
test_status: "pass",
|
|
417
|
-
lint_status: "not_applicable",
|
|
418
|
-
design_status: "not_applicable",
|
|
419
|
-
drift_checks: [
|
|
420
|
-
{
|
|
421
|
-
command_or_tool: "git diff --check",
|
|
422
|
-
status: "pass",
|
|
423
|
-
summary: "No deterministic drift or whitespace errors were reported for the fake-worker changeset."
|
|
424
|
-
}
|
|
425
|
-
],
|
|
426
|
-
ready_for_dev_test: true
|
|
427
|
-
};
|
|
1442
|
+
return value.filter((entry) => typeof entry === "string" && entry.trim().length > 0);
|
|
1443
|
+
}
|
|
1444
|
+
function summarizeQaObject(source) {
|
|
1445
|
+
return clip(stringField(source, "title")
|
|
1446
|
+
?? stringField(source, "summary")
|
|
1447
|
+
?? stringField(source, "id")
|
|
1448
|
+
?? JSON.stringify(source), 500);
|
|
1449
|
+
}
|
|
1450
|
+
function qaArtifactRelativePath(workItemId, fileName, ownerType, ownerId) {
|
|
1451
|
+
if (ownerType && ownerId) {
|
|
1452
|
+
const ownerDirectory = ownerType.trim().toLowerCase() === "story" ? "stories" : "work-items";
|
|
1453
|
+
return [".forge", ownerDirectory, ownerId, "artifacts", fileName].join("/");
|
|
1454
|
+
}
|
|
1455
|
+
return [".forge", "work-items", workItemId, "artifacts", fileName].join("/");
|
|
428
1456
|
}
|
|
429
1457
|
async function emitCompletionArtifactRecorded(emit, worktreePath, artifact) {
|
|
430
1458
|
const relativePath = path.relative(worktreePath, artifact.path) || path.basename(artifact.path);
|
|
1459
|
+
await emit({
|
|
1460
|
+
role: "tool",
|
|
1461
|
+
kind: "checkpoint",
|
|
1462
|
+
content: `Forge completion tool validation passed for ${artifact.phase ?? "unknown"} (${artifact.status}).`,
|
|
1463
|
+
eventType: "completion_tool_validation_passed",
|
|
1464
|
+
data: JSON.stringify({
|
|
1465
|
+
phase: artifact.phase ?? "unknown",
|
|
1466
|
+
status: artifact.status,
|
|
1467
|
+
artifact_relative_paths: [relativePath.split(path.sep).join("/")]
|
|
1468
|
+
})
|
|
1469
|
+
});
|
|
431
1470
|
await emit({
|
|
432
1471
|
role: "tool",
|
|
433
1472
|
kind: "tool_result",
|
|
434
1473
|
content: `Forge completion tool recorded ${artifact.phase ?? "unknown"} artifact ${relativePath} (${artifact.status}).`,
|
|
435
|
-
eventType: "completion_tool_artifact_recorded"
|
|
1474
|
+
eventType: "completion_tool_artifact_recorded",
|
|
1475
|
+
data: JSON.stringify({
|
|
1476
|
+
phase: artifact.phase ?? "unknown",
|
|
1477
|
+
status: artifact.status,
|
|
1478
|
+
artifact_relative_paths: [relativePath.split(path.sep).join("/")]
|
|
1479
|
+
})
|
|
436
1480
|
});
|
|
437
1481
|
}
|
|
438
1482
|
async function emitPhaseCompletionEvent(emit, artifact) {
|
|
@@ -460,7 +1504,15 @@ async function emitPhaseGateEvents(emit, artifact) {
|
|
|
460
1504
|
? "phase_progression: implementation -> self_review"
|
|
461
1505
|
: phase === "self_review"
|
|
462
1506
|
? "phase_progression: self_review -> validation"
|
|
463
|
-
:
|
|
1507
|
+
: phase === "debug_repro"
|
|
1508
|
+
? "phase_progression: debug_repro -> debug_root_cause"
|
|
1509
|
+
: phase === "debug_root_cause"
|
|
1510
|
+
? "phase_progression: debug_root_cause -> debug_fix"
|
|
1511
|
+
: phase === "debug_fix"
|
|
1512
|
+
? "phase_progression: debug_fix -> debug_regression"
|
|
1513
|
+
: phase === "debug_regression"
|
|
1514
|
+
? "phase_progression: debug_regression -> QA ready"
|
|
1515
|
+
: "phase_progression: validation -> QA ready";
|
|
464
1516
|
await emit({
|
|
465
1517
|
role: "hook",
|
|
466
1518
|
kind: "checkpoint",
|
|
@@ -470,7 +1522,8 @@ async function emitPhaseGateEvents(emit, artifact) {
|
|
|
470
1522
|
}
|
|
471
1523
|
function completionPhaseFromArtifact(artifact) {
|
|
472
1524
|
const phase = artifact.phase?.trim();
|
|
473
|
-
return phase === "self_review" || phase === "validation" || phase === "implementation"
|
|
1525
|
+
return phase === "self_review" || phase === "validation" || phase === "implementation" || phase === "qa"
|
|
1526
|
+
|| phase === "architect" || phase === "debug_repro" || phase === "debug_root_cause" || phase === "debug_fix" || phase === "debug_regression"
|
|
474
1527
|
? phase
|
|
475
1528
|
: "implementation";
|
|
476
1529
|
}
|
|
@@ -482,13 +1535,18 @@ class LiveCompletionArtifactEmitter {
|
|
|
482
1535
|
emitted = new Set();
|
|
483
1536
|
timer = null;
|
|
484
1537
|
pending = Promise.resolve();
|
|
485
|
-
constructor(worktreePath, workItemId, phase, developCycle, emit) {
|
|
1538
|
+
constructor(worktreePath, workItemId, phase, developCycle, debugCycle, emit) {
|
|
486
1539
|
this.worktreePath = worktreePath;
|
|
487
1540
|
this.workItemId = workItemId;
|
|
488
1541
|
this.emit = emit;
|
|
489
|
-
|
|
490
|
-
|
|
491
|
-
|
|
1542
|
+
if (debugCycle && isDebugCompletionPhaseForProvider(phase)) {
|
|
1543
|
+
this.phases = debugCompletionPhaseOrder.slice(debugCompletionPhaseOrder.indexOf(phase));
|
|
1544
|
+
}
|
|
1545
|
+
else {
|
|
1546
|
+
this.phases = developCycle
|
|
1547
|
+
? developCyclePhaseOrder.slice(developCyclePhaseOrder.indexOf(phase))
|
|
1548
|
+
: [phase];
|
|
1549
|
+
}
|
|
492
1550
|
}
|
|
493
1551
|
start() {
|
|
494
1552
|
void this.pollQueued();
|
|
@@ -531,20 +1589,23 @@ class LiveCompletionArtifactEmitter {
|
|
|
531
1589
|
}
|
|
532
1590
|
}
|
|
533
1591
|
}
|
|
534
|
-
async function readCompletionArtifactsForRun(worktreePath, workItemId, phase, developCycle) {
|
|
535
|
-
if (!developCycle) {
|
|
1592
|
+
async function readCompletionArtifactsForRun(worktreePath, workItemId, phase, developCycle, debugCycle) {
|
|
1593
|
+
if (!developCycle && !debugCycle) {
|
|
536
1594
|
const artifact = await readCompletionArtifact(worktreePath, workItemId, phase);
|
|
537
1595
|
if (!artifact) {
|
|
538
1596
|
throw new Error(`Provider CLI completed but did not call the Forge ${phase} completion tool.`);
|
|
539
1597
|
}
|
|
540
1598
|
return [artifact];
|
|
541
1599
|
}
|
|
1600
|
+
const expectedPhases = debugCycle && isDebugCompletionPhaseForProvider(phase)
|
|
1601
|
+
? debugCompletionPhaseOrder.slice(debugCompletionPhaseOrder.indexOf(phase))
|
|
1602
|
+
: ["implementation", "self_review", "validation"];
|
|
542
1603
|
const artifacts = [];
|
|
543
|
-
for (const expectedPhase of
|
|
1604
|
+
for (const expectedPhase of expectedPhases) {
|
|
544
1605
|
const artifact = await readCompletionArtifact(worktreePath, workItemId, expectedPhase);
|
|
545
1606
|
if (!artifact) {
|
|
546
1607
|
if (artifacts.length === 0) {
|
|
547
|
-
throw new Error(
|
|
1608
|
+
throw new Error(`Provider CLI completed but did not call the Forge ${expectedPhase} completion tool.`);
|
|
548
1609
|
}
|
|
549
1610
|
const previous = artifacts[artifacts.length - 1];
|
|
550
1611
|
if ((previous.status ?? "").trim().toLowerCase() === "pass") {
|
|
@@ -559,10 +1620,24 @@ async function readCompletionArtifactsForRun(worktreePath, workItemId, phase, de
|
|
|
559
1620
|
}
|
|
560
1621
|
return artifacts;
|
|
561
1622
|
}
|
|
562
|
-
function
|
|
563
|
-
const env =
|
|
1623
|
+
function providerProcessEnv(dispatch) {
|
|
1624
|
+
const env = {
|
|
1625
|
+
...completionRedactionEnv(exactRedactionSecrets(dispatch)),
|
|
1626
|
+
...providerCredentialEnv(dispatch)
|
|
1627
|
+
};
|
|
564
1628
|
return Object.keys(env).length > 0 ? env : undefined;
|
|
565
1629
|
}
|
|
1630
|
+
function providerCredentialEnv(dispatch) {
|
|
1631
|
+
const secret = dispatch.apiKeySecretGrant?.secret;
|
|
1632
|
+
if (!secret || !dispatch.execution.requiresApiKeySecretGrant) {
|
|
1633
|
+
return {};
|
|
1634
|
+
}
|
|
1635
|
+
const provider = dispatch.execution.provider.trim().toLowerCase();
|
|
1636
|
+
if (provider === "codex" || provider === "openai") {
|
|
1637
|
+
return { OPENAI_API_KEY: secret };
|
|
1638
|
+
}
|
|
1639
|
+
return {};
|
|
1640
|
+
}
|
|
566
1641
|
function exactRedactionSecrets(dispatch) {
|
|
567
1642
|
return dispatch.apiKeySecretGrant?.secret ? [dispatch.apiKeySecretGrant.secret] : [];
|
|
568
1643
|
}
|
|
@@ -585,7 +1660,7 @@ export class StreamingProviderProcessRunner {
|
|
|
585
1660
|
return await new Promise((resolve, reject) => {
|
|
586
1661
|
const child = spawn(launch.command, launch.args, {
|
|
587
1662
|
cwd: request.cwd,
|
|
588
|
-
env: request.env
|
|
1663
|
+
env: buildProviderChildEnvironment(request.env),
|
|
589
1664
|
stdio: ["ignore", "pipe", "pipe"],
|
|
590
1665
|
windowsHide: true
|
|
591
1666
|
});
|
|
@@ -720,9 +1795,6 @@ function quoteWindowsCommandLineArg(value) {
|
|
|
720
1795
|
}
|
|
721
1796
|
return `"${value.replace(/(\\*)"/g, '$1$1\\"').replace(/(\\+)$/g, "$1$1")}"`;
|
|
722
1797
|
}
|
|
723
|
-
async function fileExists(inputPath) {
|
|
724
|
-
return fs.stat(inputPath).then((stat) => stat.isFile()).catch(() => false);
|
|
725
|
-
}
|
|
726
1798
|
async function readProcessLines(stream, onLine) {
|
|
727
1799
|
const reader = readline.createInterface({ input: stream });
|
|
728
1800
|
try {
|
|
@@ -740,12 +1812,69 @@ function isFakeWorkerModel(model) {
|
|
|
740
1812
|
function sha256(content) {
|
|
741
1813
|
return crypto.createHash("sha256").update(content).digest("hex");
|
|
742
1814
|
}
|
|
1815
|
+
function buildDraftPrompt(dispatch) {
|
|
1816
|
+
const draft = dispatch.draft;
|
|
1817
|
+
if (!draft) {
|
|
1818
|
+
throw new Error("Draft prompt is missing.");
|
|
1819
|
+
}
|
|
1820
|
+
return `${draft.systemPrompt}
|
|
1821
|
+
|
|
1822
|
+
Draft kind: ${draft.kind}
|
|
1823
|
+
|
|
1824
|
+
${draft.userPrompt}
|
|
1825
|
+
|
|
1826
|
+
Return ONLY the requested JSON object. Do not wrap it in markdown and do not modify files.`;
|
|
1827
|
+
}
|
|
1828
|
+
function extractJsonObject(content) {
|
|
1829
|
+
let trimmed = content.trim();
|
|
1830
|
+
if (trimmed.startsWith("```")) {
|
|
1831
|
+
const firstNewline = trimmed.indexOf("\n");
|
|
1832
|
+
const lastFence = trimmed.lastIndexOf("```");
|
|
1833
|
+
if (firstNewline >= 0 && lastFence > firstNewline) {
|
|
1834
|
+
trimmed = trimmed.slice(firstNewline + 1, lastFence).trim();
|
|
1835
|
+
}
|
|
1836
|
+
}
|
|
1837
|
+
const start = trimmed.indexOf("{");
|
|
1838
|
+
const end = trimmed.lastIndexOf("}");
|
|
1839
|
+
return start >= 0 && end >= start ? trimmed.slice(start, end + 1) : trimmed;
|
|
1840
|
+
}
|
|
1841
|
+
function summarizeStderr(stderr) {
|
|
1842
|
+
const trimmed = stderr.trim();
|
|
1843
|
+
return trimmed ? `: ${clip(trimmed, 1000)}` : "";
|
|
1844
|
+
}
|
|
1845
|
+
function deterministicDraftPayload(dispatch) {
|
|
1846
|
+
const kind = dispatch.draft?.kind ?? "work_item";
|
|
1847
|
+
if (kind === "work_order") {
|
|
1848
|
+
return {
|
|
1849
|
+
title: "Deterministic runner Work Order draft",
|
|
1850
|
+
summary: "Forge Runner generated this deterministic Work Order draft.",
|
|
1851
|
+
objective: "Validate runner-backed Draft generation.",
|
|
1852
|
+
planningPacket: "Runner-backed draft generation returned a Work Order JSON payload.",
|
|
1853
|
+
decompositionContext: "Use this deterministic fixture only in bridge tests.",
|
|
1854
|
+
assumptions: ["Forge Runner dispatch is available."],
|
|
1855
|
+
warnings: []
|
|
1856
|
+
};
|
|
1857
|
+
}
|
|
1858
|
+
if (kind === "story") {
|
|
1859
|
+
return {
|
|
1860
|
+
title: "Deterministic runner Story draft",
|
|
1861
|
+
description: "Forge Runner generated this deterministic Story draft.",
|
|
1862
|
+
acceptanceCriteria: "Given runner-backed Draft generation, when Forge requests a Story draft, then JSON is returned.",
|
|
1863
|
+
points: 3
|
|
1864
|
+
};
|
|
1865
|
+
}
|
|
1866
|
+
return {
|
|
1867
|
+
title: "Deterministic runner Work Item draft",
|
|
1868
|
+
description: "Forge Runner generated this deterministic Work Item draft.",
|
|
1869
|
+
acceptanceCriteria: "Given runner-backed Draft generation, when Forge requests a draft, then JSON is returned.",
|
|
1870
|
+
reproSteps: "Run Draft with a Forge Runner provider selected.",
|
|
1871
|
+
systemInfo: "forge-bridge deterministic provider",
|
|
1872
|
+
points: 1
|
|
1873
|
+
};
|
|
1874
|
+
}
|
|
743
1875
|
export function formatProviderCliCommand(command) {
|
|
744
1876
|
return [command.command, ...command.args].map(singleLine).join(" ");
|
|
745
1877
|
}
|
|
746
|
-
function yamlQuotedScalar(value) {
|
|
747
|
-
return JSON.stringify(singleLine(value));
|
|
748
|
-
}
|
|
749
1878
|
function singleLine(value) {
|
|
750
1879
|
return value.replace(/\s+/g, " ").trim();
|
|
751
1880
|
}
|
|
@@ -754,16 +1883,19 @@ export function buildProviderCliCommand(dispatch, run) {
|
|
|
754
1883
|
const normalizedProvider = provider.toLowerCase();
|
|
755
1884
|
const model = dispatch.execution.model.trim();
|
|
756
1885
|
if (normalizedProvider === "codex") {
|
|
757
|
-
const args = ["exec"];
|
|
1886
|
+
const args = run ? ["-s", "workspace-write", "-a", "never", "exec"] : ["exec"];
|
|
758
1887
|
if (run?.completionTools) {
|
|
759
1888
|
args.push(...codexMcpConfigArgs(run.completionTools));
|
|
760
1889
|
}
|
|
761
1890
|
args.push("--model", model);
|
|
762
1891
|
if (run) {
|
|
763
|
-
args.push("--json"
|
|
1892
|
+
args.push("--json");
|
|
764
1893
|
if (run.worktreePath) {
|
|
765
1894
|
args.push("--cd", run.worktreePath);
|
|
766
1895
|
}
|
|
1896
|
+
if (run.skipGitRepoCheck) {
|
|
1897
|
+
args.push("--skip-git-repo-check");
|
|
1898
|
+
}
|
|
767
1899
|
args.push(run.prompt ?? "");
|
|
768
1900
|
}
|
|
769
1901
|
return { command: "codex", args };
|
|
@@ -784,11 +1916,37 @@ export function buildProviderCliCommand(dispatch, run) {
|
|
|
784
1916
|
}
|
|
785
1917
|
return { command: provider, args };
|
|
786
1918
|
}
|
|
1919
|
+
function buildArchitectPrompt(dispatch) {
|
|
1920
|
+
return `You are Forge's Architect lane running locally in a prepared git worktree.
|
|
1921
|
+
|
|
1922
|
+
Work item: ${dispatch.workItem.id} — ${dispatch.workItem.title}
|
|
1923
|
+
|
|
1924
|
+
Plan only. Do not implement source changes, do not create Develop phase artifacts, and do not mark the spec approved.
|
|
1925
|
+
Read injected Forge context under .forge plus the repository shape, then produce a repo-grounded implementation DAG with task tests, phase gates, final QA coverage, and a pending-approval spec.
|
|
1926
|
+
${architectRevisionInstruction(dispatch)}
|
|
1927
|
+
Forge owns protocol files: write Architect artifacts only through the completion MCP tool.
|
|
1928
|
+
|
|
1929
|
+
${completionPromptForPhase("architect")}
|
|
1930
|
+
|
|
1931
|
+
Finish only after calling forge.complete_architect_plan with implementation_plan, qa_plan, status, summary, and report/report_markdown.`;
|
|
1932
|
+
}
|
|
1933
|
+
function architectRevisionInstruction(dispatch) {
|
|
1934
|
+
if (!dispatch.architectRevision) {
|
|
1935
|
+
return "";
|
|
1936
|
+
}
|
|
1937
|
+
return `
|
|
1938
|
+
Architect revision context:
|
|
1939
|
+
- Previous plan id: ${dispatch.architectRevision.priorPlanId}
|
|
1940
|
+
- Previous content hash: ${dispatch.architectRevision.priorContentHash}
|
|
1941
|
+
- Reviewer feedback: ${dispatch.architectRevision.feedback}
|
|
1942
|
+
Revise the prior plan in response to the feedback. Preserve accepted scope and only change what the feedback requires.`;
|
|
1943
|
+
}
|
|
787
1944
|
function buildImplementationPrompt(dispatch, phase = completionPhaseFromDispatch(dispatch)) {
|
|
788
1945
|
return `You are Forge's ${phase.replace(/_/g, " ")} phase runner running locally in a prepared git worktree.
|
|
789
1946
|
|
|
790
1947
|
Read .forge/work-items/${dispatch.workItem.id}/spec.md and any prior phase artifacts required by this phase.
|
|
791
1948
|
${phaseWorkInstruction(phase)}
|
|
1949
|
+
${qaReworkImplementationInstruction(dispatch)}
|
|
792
1950
|
Use the repository's existing conventions. Run relevant tests when practical.
|
|
793
1951
|
Forge owns protocol files: worktree prep, injected .forge commands/hooks/skills, phase verdict artifacts, reports, and commits.
|
|
794
1952
|
Read Forge-provided context under .forge when needed, but do not edit .forge files or create Forge verdict/report artifacts by hand.
|
|
@@ -802,6 +1960,7 @@ function buildDevelopCyclePrompt(dispatch, phase = completionPhaseFromDispatch(d
|
|
|
802
1960
|
|
|
803
1961
|
Read .forge/work-items/${dispatch.workItem.id}/spec.md, implement the work item, self-review the diff, then validate it in this same provider session.
|
|
804
1962
|
Start in the ${phase.replace(/_/g, " ")} phase. Do not stop after implementation if it passes; continue through self-review and validation using the next instruction returned by each completion tool.
|
|
1963
|
+
${qaReworkImplementationInstruction(dispatch)}
|
|
805
1964
|
Use the repository's existing conventions. Run relevant tests when practical.
|
|
806
1965
|
Forge owns protocol files: worktree prep, injected .forge commands/hooks/skills, phase verdict artifacts, reports, and commits.
|
|
807
1966
|
Read Forge-provided context under .forge when needed, but do not edit .forge files or create Forge verdict/report artifacts by hand.
|
|
@@ -810,20 +1969,148 @@ ${completionPromptForDevelopCycle(phase)}
|
|
|
810
1969
|
|
|
811
1970
|
Finish with a concise summary of changed files and verification after the validation completion tool has accepted the work, or after the current phase tool records a non-pass blocker.`;
|
|
812
1971
|
}
|
|
1972
|
+
function buildDebugCyclePrompt(dispatch, phase = completionPhaseFromDispatch(dispatch)) {
|
|
1973
|
+
return `You are Forge's Debug lane running locally in a prepared git worktree for a bug work item.
|
|
1974
|
+
|
|
1975
|
+
Read .forge/work-items/${dispatch.workItem.id}/spec.md, reproduce or characterize the bug, isolate root cause, apply the smallest safe fix, then prove the regression in this same provider session.
|
|
1976
|
+
Start in the ${phase.replace(/_/g, " ")} gate. Do not stop after a passing Debug gate; continue through the next Debug MCP instruction returned by the tool server until debug_regression is accepted or the current gate records a non-pass blocker.
|
|
1977
|
+
${debugQaReworkInstruction(dispatch)}
|
|
1978
|
+
Use the repository's existing conventions. Run focused tests when practical, especially the original repro and required regressions.
|
|
1979
|
+
Forge owns protocol files: worktree prep, injected .forge commands/hooks/skills, Debug verdict artifacts, reports, and commits.
|
|
1980
|
+
Read Forge-provided context under .forge when needed, but do not edit .forge files or create Forge Debug artifacts by hand.
|
|
1981
|
+
|
|
1982
|
+
${completionPromptForDebugCycle(isDebugCompletionPhaseForProvider(phase) ? phase : "debug_repro")}
|
|
1983
|
+
|
|
1984
|
+
Finish with a concise summary of changed files and verification after the debug_regression completion tool has accepted the work, or after the current Debug gate tool records a non-pass blocker.`;
|
|
1985
|
+
}
|
|
1986
|
+
function qaReworkImplementationInstruction(dispatch) {
|
|
1987
|
+
if (!dispatch.qaRework) {
|
|
1988
|
+
return "";
|
|
1989
|
+
}
|
|
1990
|
+
return `
|
|
1991
|
+
QA rework context:
|
|
1992
|
+
- Attempt ${dispatch.qaRework.attempt}/${dispatch.qaRework.maxAttempts}
|
|
1993
|
+
- Rework packet: ${dispatch.qaRework.packetPath}
|
|
1994
|
+
- Required QA finding IDs: ${dispatch.qaRework.findingIds.join(", ")}
|
|
1995
|
+
Read the packet JSON and fix or explicitly dispute each listed finding. The implementation completion artifact must include resolved_findings entries for every required QA ID with qa_id, status, summary, evidence, changed_files, tests_added_or_updated, and regression_evidence.
|
|
1996
|
+
Use only these resolved_findings status values: resolved, disputed, or not_reproduced. Use resolved when the finding was fixed; do not use fixed.`;
|
|
1997
|
+
}
|
|
1998
|
+
function debugQaReworkInstruction(dispatch) {
|
|
1999
|
+
if (!dispatch.qaRework) {
|
|
2000
|
+
return "";
|
|
2001
|
+
}
|
|
2002
|
+
return `
|
|
2003
|
+
QA rework context for Debug:
|
|
2004
|
+
- Attempt ${dispatch.qaRework.attempt}/${dispatch.qaRework.maxAttempts}
|
|
2005
|
+
- Rework packet: ${dispatch.qaRework.packetPath}
|
|
2006
|
+
- Required QA finding IDs: ${dispatch.qaRework.findingIds.join(", ")}
|
|
2007
|
+
Read the packet JSON, reproduce or characterize each listed finding, fix or explicitly dispute it, and include resolved_findings entries for every required QA ID in forge.complete_debug_fix with qa_id, status, summary, evidence, changed_files, tests_added_or_updated, and regression_evidence.
|
|
2008
|
+
Use only these resolved_findings status values: resolved, disputed, or not_reproduced. Use resolved when the finding was fixed; do not use fixed.`;
|
|
2009
|
+
}
|
|
2010
|
+
function qaReworkRetestInstruction(dispatch) {
|
|
2011
|
+
if (!dispatch.qaRework) {
|
|
2012
|
+
return "";
|
|
2013
|
+
}
|
|
2014
|
+
return `
|
|
2015
|
+
QA retest context:
|
|
2016
|
+
- Rework attempt ${dispatch.qaRework.attempt}/${dispatch.qaRework.maxAttempts}
|
|
2017
|
+
- Rework packet: ${dispatch.qaRework.packetPath}
|
|
2018
|
+
- Priority finding IDs: ${dispatch.qaRework.findingIds.join(", ")}
|
|
2019
|
+
Prioritize retesting the listed QA findings and their required regressions before deciding pass, needs_rework, or blocked.`;
|
|
2020
|
+
}
|
|
813
2021
|
function phaseWorkInstruction(phase) {
|
|
814
2022
|
if (phase === "self_review") {
|
|
815
2023
|
return "Review the implementation diff, apply safe fixes when needed, and record remaining risks explicitly.";
|
|
816
2024
|
}
|
|
817
2025
|
if (phase === "validation") {
|
|
818
|
-
return "Run the validation commands and deterministic drift checks needed to prove the work is ready for
|
|
2026
|
+
return "Run the validation commands and deterministic drift checks needed to prove the work is ready for QA.";
|
|
819
2027
|
}
|
|
820
2028
|
return "Implement the work item and keep the change focused.";
|
|
821
2029
|
}
|
|
822
|
-
function
|
|
823
|
-
|
|
2030
|
+
function qaBrowserInstruction(dispatch) {
|
|
2031
|
+
const qaBrowser = dispatch.qaBrowser;
|
|
2032
|
+
if (!qaBrowser) {
|
|
2033
|
+
return "Browser/app launch context: not provided by Forge.";
|
|
2034
|
+
}
|
|
2035
|
+
const launchTarget = qaBrowser.launchTarget;
|
|
2036
|
+
if (qaBrowser.required && !hasLaunchTarget(launchTarget ?? null)) {
|
|
2037
|
+
return `Browser/app launch context:\n- UI/browser QA is required for this item.\n- No app launch target was provided.\n- Return blocked with blocker_reason: missing_app_launch_target instead of pretending browser testing occurred.\n- Artifact sidecars path when available: ${qaBrowser.artifactsPath || `.forge/work-items/${dispatch.workItem.id}/artifacts/qa`}`;
|
|
2038
|
+
}
|
|
2039
|
+
if (!launchTarget) {
|
|
2040
|
+
return `Browser/app launch context:\n- UI/browser QA is not required by Forge heuristics for this item.\n- If you determine browser testing is needed, return blocked with blocker_reason: missing_app_launch_target unless you can safely identify a launch target from the repo.\n- Browser sidecars path: ${qaBrowser.artifactsPath || `.forge/work-items/${dispatch.workItem.id}/artifacts/qa`}`;
|
|
2041
|
+
}
|
|
2042
|
+
const routes = launchTarget.routes.length > 0 ? launchTarget.routes.join(", ") : "not specified";
|
|
2043
|
+
return `Browser/app launch context:\n- Browser QA required: ${qaBrowser.required ? "yes" : "no, unless the diff/AC requires it"}\n- URL: ${launchTarget.url || "not specified"}\n- Ready URL: ${launchTarget.ready_url || "not specified"}\n- Launch command: ${launchTarget.command || "not specified"}\n- Working directory: ${launchTarget.working_directory || "repo root"}\n- Routes to cover: ${routes}\n- Notes: ${launchTarget.notes || "none"}\n- Browser sidecars path: ${qaBrowser.artifactsPath || `.forge/work-items/${dispatch.workItem.id}/artifacts/qa`}`;
|
|
2044
|
+
}
|
|
2045
|
+
function storyQaInstruction(dispatch) {
|
|
2046
|
+
const storyQa = dispatch.storyQa;
|
|
2047
|
+
if (!storyQa) {
|
|
2048
|
+
return "";
|
|
2049
|
+
}
|
|
2050
|
+
const childLines = storyQa.childTasks.map((child) => {
|
|
2051
|
+
const dependencies = child.dependencyWorkItemIds.length > 0
|
|
2052
|
+
? child.dependencyWorkItemIds.join(", ")
|
|
2053
|
+
: "none";
|
|
2054
|
+
const validation = child.validationArtifact
|
|
2055
|
+
? `${child.validationArtifact.status} (${child.validationArtifact.path || "artifact path unavailable"})`
|
|
2056
|
+
: "missing";
|
|
2057
|
+
const childQa = child.qaArtifact
|
|
2058
|
+
? `${child.qaArtifact.status} (${child.qaArtifact.path || "artifact path unavailable"})`
|
|
2059
|
+
: "not present";
|
|
2060
|
+
return `- ${child.title} (${child.workItemId}, architect ${child.architectTaskId}, phase ${child.phaseId}/${child.phaseOrder}); deps: ${dependencies}; validation: ${validation}; child QA: ${childQa}`;
|
|
2061
|
+
}).join("\n");
|
|
2062
|
+
const finalQa = storyQa.finalQaChecks.length > 0
|
|
2063
|
+
? storyQa.finalQaChecks.map((check) => `- ${check}`).join("\n")
|
|
2064
|
+
: "- No final QA checks were provided in qa.plan.final_qa.";
|
|
2065
|
+
return `Story QA integration context:
|
|
2066
|
+
- Story work item: ${storyQa.storyWorkItemId}
|
|
2067
|
+
- Plan: ${storyQa.planId} / ${storyQa.planContentHash}
|
|
2068
|
+
- Story worktree: ${storyQa.worktreeKey}
|
|
2069
|
+
- Branch: ${storyQa.branch}
|
|
2070
|
+
- Architect implementation.plan.json provided: ${storyQa.implementationPlanJson ? "yes" : "no"}
|
|
2071
|
+
- Architect qa.plan.json provided: ${storyQa.qaPlanJson ? "yes" : "no"}
|
|
2072
|
+
Materialized child tasks and evidence:
|
|
2073
|
+
${childLines || "- No child tasks were provided."}
|
|
2074
|
+
Architect final QA checks:
|
|
2075
|
+
${finalQa}
|
|
2076
|
+
This is parent Story QA: inspect the integrated Story result, all current-plan child specs/evidence, and the final worktree state. Do not treat the final child task as separately signed off.`;
|
|
2077
|
+
}
|
|
2078
|
+
function buildQaPrompt(dispatch, laneSpec) {
|
|
2079
|
+
return `You are Forge's QA lane running locally in a prepared git worktree.
|
|
2080
|
+
|
|
2081
|
+
First read and follow the injected QA lane command at .forge/work-items/${dispatch.workItem.id}/spec.md. It defines the required gated QA skill workflow for this run.
|
|
2082
|
+
|
|
2083
|
+
Injected QA lane command and work item spec:
|
|
2084
|
+
${laneSpec}
|
|
2085
|
+
|
|
2086
|
+
---
|
|
824
2087
|
|
|
825
|
-
|
|
826
|
-
|
|
2088
|
+
Work item: ${dispatch.workItem.id}
|
|
2089
|
+
Title: ${dispatch.workItem.title}
|
|
2090
|
+
Description:
|
|
2091
|
+
${dispatch.workItem.description || "Not provided."}
|
|
2092
|
+
|
|
2093
|
+
Acceptance criteria:
|
|
2094
|
+
${dispatch.workItem.acceptanceCriteria || "Not specified."}
|
|
2095
|
+
|
|
2096
|
+
Repro steps / scenario:
|
|
2097
|
+
${dispatch.workItem.reproSteps || "Not provided."}
|
|
2098
|
+
|
|
2099
|
+
System info / environment notes:
|
|
2100
|
+
${dispatch.workItem.systemInfo || "Not provided."}
|
|
2101
|
+
|
|
2102
|
+
${storyQaInstruction(dispatch)}
|
|
2103
|
+
Inspect the validated implementation and Forge artifacts under .forge/work-items/${dispatch.workItem.id}/artifacts/ when present, especially implementation, self-review, and validation evidence.
|
|
2104
|
+
${qaBrowserInstruction(dispatch)}
|
|
2105
|
+
${qaReworkRetestInstruction(dispatch)}
|
|
2106
|
+
QA is read-mostly: inspect code, run commands, and exercise browser/app flows when available, but do not edit product source or tests.
|
|
2107
|
+
Record concrete evidence. For UI/browser work, include browser_checks with URLs/routes, actions, observed results, screenshots/traces when available, console errors, failed network requests, and responsive checks. Store browser sidecars under .forge/work-items/${dispatch.workItem.id}/artifacts/qa/.
|
|
2108
|
+
Report in-scope defects as actionable findings with repro steps, expected/actual behavior, evidence, likely area, required fix, and required regression.
|
|
2109
|
+
Out-of-scope or follow-up issues belong in candidate_bugs instead of blocking the current item.
|
|
2110
|
+
|
|
2111
|
+
${completionPromptForQaCycle()}
|
|
2112
|
+
|
|
2113
|
+
Finish with a concise summary only after forge.complete_qa_verdict accepts the QA bundle.`;
|
|
827
2114
|
}
|
|
828
2115
|
function buildConflictResolvePrompt(dispatch, branchName) {
|
|
829
2116
|
const targetBranch = dispatch.cycleRun.requestedBase || dispatch.repo.defaultBranch || "main";
|
|
@@ -838,6 +2125,34 @@ Keep the original work item intent intact:
|
|
|
838
2125
|
|
|
839
2126
|
Finish with a concise summary of the conflicts resolved and verification performed.`;
|
|
840
2127
|
}
|
|
2128
|
+
function buildPullRequestCommentsPrompt(dispatch, branchName) {
|
|
2129
|
+
const pr = dispatch.pullRequest;
|
|
2130
|
+
const targetBranch = pr?.targetBranch || dispatch.cycleRun.requestedBase || dispatch.repo.defaultBranch || "main";
|
|
2131
|
+
const prLocator = pr
|
|
2132
|
+
? `PR #${pr.number}${pr.url ? ` (${pr.url})` : ""}`
|
|
2133
|
+
: "the open pull request for this work item";
|
|
2134
|
+
return `You are Forge's Pull Request Comments lane running locally in a prepared git worktree.
|
|
2135
|
+
|
|
2136
|
+
The current branch is the pull request branch ${branchName}. Address unresolved review comments on ${prLocator}.
|
|
2137
|
+
PR context:
|
|
2138
|
+
- Provider: ${pr?.provider || "not provided"}
|
|
2139
|
+
- Source branch: ${pr?.sourceBranch || branchName}
|
|
2140
|
+
- Target branch: ${targetBranch}
|
|
2141
|
+
- Unresolved comments: ${pr?.unresolvedThreads ?? "unknown"}
|
|
2142
|
+
|
|
2143
|
+
Use the PR URL, local git metadata, and available GitHub tooling/auth to inspect unresolved review threads. Make focused code or test changes that answer the feedback, commit the changes, and push ${branchName} to origin.
|
|
2144
|
+
After the push succeeds, Forge will resolve the addressed review threads through the pull request API.
|
|
2145
|
+
If the review thread contents are unavailable, stop with a clear summary of what could not be accessed instead of guessing.
|
|
2146
|
+
Keep the original work item intent intact:
|
|
2147
|
+
- Work item: ${dispatch.workItem.id}
|
|
2148
|
+
- Title: ${dispatch.workItem.title}
|
|
2149
|
+
- Acceptance criteria: ${dispatch.workItem.acceptanceCriteria || "Not specified"}
|
|
2150
|
+
|
|
2151
|
+
Finish with a concise summary of comments addressed and verification performed.`;
|
|
2152
|
+
}
|
|
2153
|
+
function isPullRequestCommentsDispatch(dispatch) {
|
|
2154
|
+
return dispatch.cycleRun.kind.trim().toLowerCase() === "pr_comments";
|
|
2155
|
+
}
|
|
841
2156
|
async function cleanupCompletionTools(completionTools, emit) {
|
|
842
2157
|
try {
|
|
843
2158
|
await completionTools.cleanup();
|
|
@@ -895,31 +2210,31 @@ class CursorStreamJsonState {
|
|
|
895
2210
|
consume(line) {
|
|
896
2211
|
const event = parseJsonLine(line);
|
|
897
2212
|
if (!event) {
|
|
898
|
-
return
|
|
2213
|
+
return [];
|
|
899
2214
|
}
|
|
900
2215
|
const type = stringField(event, "type");
|
|
901
2216
|
if (type === "system" && stringField(event, "subtype") === "init") {
|
|
902
2217
|
this.sessionId = stringField(event, "session_id");
|
|
903
2218
|
if (this.sessionId && !this.emittedSession) {
|
|
904
2219
|
this.emittedSession = true;
|
|
905
|
-
return {
|
|
906
|
-
|
|
907
|
-
|
|
908
|
-
|
|
909
|
-
|
|
910
|
-
|
|
2220
|
+
return [{
|
|
2221
|
+
role: "runner",
|
|
2222
|
+
kind: "checkpoint",
|
|
2223
|
+
content: `Cursor session started: ${this.sessionId}.`,
|
|
2224
|
+
eventType: "provider_thread_started"
|
|
2225
|
+
}];
|
|
911
2226
|
}
|
|
912
2227
|
}
|
|
913
2228
|
if (type === "assistant") {
|
|
914
2229
|
const text = assistantMessageText(event);
|
|
915
2230
|
if (text) {
|
|
916
2231
|
this.finalMessage = clip(text, 4000);
|
|
917
|
-
return {
|
|
918
|
-
|
|
919
|
-
|
|
920
|
-
|
|
921
|
-
|
|
922
|
-
|
|
2232
|
+
return [{
|
|
2233
|
+
role: "assistant",
|
|
2234
|
+
kind: "message",
|
|
2235
|
+
content: this.finalMessage,
|
|
2236
|
+
eventType: "provider_message"
|
|
2237
|
+
}];
|
|
923
2238
|
}
|
|
924
2239
|
}
|
|
925
2240
|
if (type === "tool_call") {
|
|
@@ -928,23 +2243,23 @@ class CursorStreamJsonState {
|
|
|
928
2243
|
if (subtype === "started") {
|
|
929
2244
|
const summary = formatCursorToolCallStarted(toolCall);
|
|
930
2245
|
if (summary) {
|
|
931
|
-
return {
|
|
932
|
-
|
|
933
|
-
|
|
934
|
-
|
|
935
|
-
|
|
936
|
-
|
|
2246
|
+
return [{
|
|
2247
|
+
role: "worker",
|
|
2248
|
+
kind: "checkpoint",
|
|
2249
|
+
content: summary,
|
|
2250
|
+
eventType: "provider_tool_call"
|
|
2251
|
+
}];
|
|
937
2252
|
}
|
|
938
2253
|
}
|
|
939
2254
|
if (subtype === "completed") {
|
|
940
2255
|
const completed = formatCursorToolCallCompleted(toolCall);
|
|
941
2256
|
if (completed) {
|
|
942
|
-
return {
|
|
943
|
-
|
|
944
|
-
|
|
945
|
-
|
|
946
|
-
|
|
947
|
-
|
|
2257
|
+
return [{
|
|
2258
|
+
role: "worker",
|
|
2259
|
+
kind: completed.kind,
|
|
2260
|
+
content: completed.content,
|
|
2261
|
+
eventType: completed.kind === "file_edit" ? "provider_file_edit" : "provider_tool_call"
|
|
2262
|
+
}];
|
|
948
2263
|
}
|
|
949
2264
|
}
|
|
950
2265
|
}
|
|
@@ -956,14 +2271,14 @@ class CursorStreamJsonState {
|
|
|
956
2271
|
this.accumulateUsage(event);
|
|
957
2272
|
}
|
|
958
2273
|
if (type === "error" || (type === "result" && event.is_error === true)) {
|
|
959
|
-
return {
|
|
960
|
-
|
|
961
|
-
|
|
962
|
-
|
|
963
|
-
|
|
964
|
-
|
|
2274
|
+
return [{
|
|
2275
|
+
role: "runner",
|
|
2276
|
+
kind: "error",
|
|
2277
|
+
content: clip(line.trim(), 1000),
|
|
2278
|
+
eventType: "provider_cli_error"
|
|
2279
|
+
}];
|
|
965
2280
|
}
|
|
966
|
-
return
|
|
2281
|
+
return [];
|
|
967
2282
|
}
|
|
968
2283
|
accumulateUsage(event) {
|
|
969
2284
|
const usage = objectField(event, "usage");
|
|
@@ -1094,37 +2409,37 @@ class CodexJsonState {
|
|
|
1094
2409
|
consume(line) {
|
|
1095
2410
|
const event = parseJsonLine(line);
|
|
1096
2411
|
if (!event) {
|
|
1097
|
-
return
|
|
2412
|
+
return [];
|
|
1098
2413
|
}
|
|
1099
2414
|
const type = stringField(event, "type") ?? "";
|
|
1100
2415
|
if (type === "thread.started") {
|
|
1101
2416
|
this.threadId = stringField(event, "thread_id");
|
|
1102
2417
|
if (this.threadId && !this.emittedThread) {
|
|
1103
2418
|
this.emittedThread = true;
|
|
1104
|
-
return {
|
|
1105
|
-
|
|
1106
|
-
|
|
1107
|
-
|
|
1108
|
-
|
|
1109
|
-
|
|
2419
|
+
return [{
|
|
2420
|
+
role: "runner",
|
|
2421
|
+
kind: "checkpoint",
|
|
2422
|
+
content: `Codex thread started: ${this.threadId}.`,
|
|
2423
|
+
eventType: "provider_thread_started"
|
|
2424
|
+
}];
|
|
1110
2425
|
}
|
|
1111
2426
|
}
|
|
1112
2427
|
if (type === "turn.completed") {
|
|
1113
2428
|
this.accumulateUsage(event);
|
|
1114
|
-
return {
|
|
1115
|
-
|
|
1116
|
-
|
|
1117
|
-
|
|
1118
|
-
|
|
1119
|
-
|
|
2429
|
+
return [{
|
|
2430
|
+
role: "runner",
|
|
2431
|
+
kind: "checkpoint",
|
|
2432
|
+
content: "Codex turn completed.",
|
|
2433
|
+
eventType: "provider_turn_completed"
|
|
2434
|
+
}];
|
|
1120
2435
|
}
|
|
1121
2436
|
if (type === "turn.failed" || type === "error") {
|
|
1122
|
-
return {
|
|
1123
|
-
|
|
1124
|
-
|
|
1125
|
-
|
|
1126
|
-
|
|
1127
|
-
|
|
2437
|
+
return [{
|
|
2438
|
+
role: "runner",
|
|
2439
|
+
kind: "error",
|
|
2440
|
+
content: clip(line.trim(), 1000),
|
|
2441
|
+
eventType: "provider_cli_error"
|
|
2442
|
+
}];
|
|
1128
2443
|
}
|
|
1129
2444
|
if (type === "item.completed" || type === "item.updated") {
|
|
1130
2445
|
const item = objectField(event, "item");
|
|
@@ -1133,28 +2448,32 @@ class CodexJsonState {
|
|
|
1133
2448
|
const text = stringField(item, "text");
|
|
1134
2449
|
if (text) {
|
|
1135
2450
|
this.finalMessage = clip(text, 4000);
|
|
1136
|
-
return {
|
|
1137
|
-
|
|
1138
|
-
|
|
1139
|
-
|
|
1140
|
-
|
|
1141
|
-
|
|
2451
|
+
return [{
|
|
2452
|
+
role: "assistant",
|
|
2453
|
+
kind: "message",
|
|
2454
|
+
content: this.finalMessage,
|
|
2455
|
+
eventType: "provider_message"
|
|
2456
|
+
}];
|
|
1142
2457
|
}
|
|
1143
2458
|
}
|
|
1144
2459
|
if (itemType === "command_execution") {
|
|
1145
2460
|
const command = stringField(item, "command");
|
|
1146
2461
|
const status = stringField(item, "status");
|
|
1147
2462
|
if (command) {
|
|
1148
|
-
return {
|
|
1149
|
-
|
|
1150
|
-
|
|
1151
|
-
|
|
1152
|
-
|
|
1153
|
-
|
|
2463
|
+
return [{
|
|
2464
|
+
role: "worker",
|
|
2465
|
+
kind: "checkpoint",
|
|
2466
|
+
content: `Codex command ${status || "completed"}: ${clip(command, 500)}`,
|
|
2467
|
+
eventType: "provider_command"
|
|
2468
|
+
}];
|
|
1154
2469
|
}
|
|
1155
2470
|
}
|
|
1156
2471
|
}
|
|
1157
|
-
|
|
2472
|
+
const mcpEvents = formatCodexMcpToolCallEvents(type, event);
|
|
2473
|
+
if (mcpEvents.length > 0) {
|
|
2474
|
+
return mcpEvents;
|
|
2475
|
+
}
|
|
2476
|
+
return [];
|
|
1158
2477
|
}
|
|
1159
2478
|
accumulateUsage(event) {
|
|
1160
2479
|
const usage = objectField(event, "usage");
|
|
@@ -1170,6 +2489,113 @@ class CodexJsonState {
|
|
|
1170
2489
|
});
|
|
1171
2490
|
}
|
|
1172
2491
|
}
|
|
2492
|
+
function formatCodexMcpToolCallEvents(type, event) {
|
|
2493
|
+
if (type !== "item.started" && type !== "item.updated" && type !== "item.completed") {
|
|
2494
|
+
return [];
|
|
2495
|
+
}
|
|
2496
|
+
const item = objectField(event, "item");
|
|
2497
|
+
const itemType = stringField(item, "type") ?? "";
|
|
2498
|
+
const serverName = mcpServerName(item);
|
|
2499
|
+
const toolName = mcpToolName(item);
|
|
2500
|
+
const isMcpItem = itemType.toLowerCase().includes("mcp")
|
|
2501
|
+
|| Boolean(serverName)
|
|
2502
|
+
|| (toolName ? isForgeCompletionTool(toolName) || toolName.toLowerCase().includes("mcp") : false);
|
|
2503
|
+
if (!isMcpItem || !toolName) {
|
|
2504
|
+
return [];
|
|
2505
|
+
}
|
|
2506
|
+
const status = normalizedString(stringField(item, "status")
|
|
2507
|
+
?? stringField(event, "status")
|
|
2508
|
+
?? (type === "item.started" ? "started" : type === "item.completed" ? "completed" : "updated"));
|
|
2509
|
+
const failed = status === "failed" || status === "error" || status === "cancelled" || Boolean(item.error);
|
|
2510
|
+
const completed = failed || type === "item.completed" || status === "completed" || status === "succeeded" || status === "success";
|
|
2511
|
+
const started = type === "item.started" || status === "started" || status === "running" || status === "in_progress";
|
|
2512
|
+
const data = safeProviderMcpData(item, serverName ?? "unknown", toolName, status);
|
|
2513
|
+
const label = `${serverName ?? "unknown"}.${toolName}`;
|
|
2514
|
+
if (failed) {
|
|
2515
|
+
const summary = mcpErrorSummary(item) ?? "MCP tool call failed.";
|
|
2516
|
+
const events = [{
|
|
2517
|
+
role: "tool",
|
|
2518
|
+
kind: "error",
|
|
2519
|
+
content: `MCP tool call failed: ${label} - ${summary}`,
|
|
2520
|
+
eventType: "provider_mcp_call_failed",
|
|
2521
|
+
data
|
|
2522
|
+
}];
|
|
2523
|
+
if (isForgeCompletionTool(toolName)) {
|
|
2524
|
+
events.push({
|
|
2525
|
+
role: "tool",
|
|
2526
|
+
kind: "error",
|
|
2527
|
+
content: `Forge completion tool validation failed: ${label} - ${summary}`,
|
|
2528
|
+
eventType: "completion_tool_validation_failed",
|
|
2529
|
+
data
|
|
2530
|
+
});
|
|
2531
|
+
}
|
|
2532
|
+
return events;
|
|
2533
|
+
}
|
|
2534
|
+
if (completed) {
|
|
2535
|
+
return [{
|
|
2536
|
+
role: "tool",
|
|
2537
|
+
kind: "checkpoint",
|
|
2538
|
+
content: `MCP tool call completed: ${label}.`,
|
|
2539
|
+
eventType: "provider_mcp_call_completed",
|
|
2540
|
+
data
|
|
2541
|
+
}];
|
|
2542
|
+
}
|
|
2543
|
+
if (started) {
|
|
2544
|
+
return [{
|
|
2545
|
+
role: "tool",
|
|
2546
|
+
kind: "checkpoint",
|
|
2547
|
+
content: `MCP tool call started: ${label}.`,
|
|
2548
|
+
eventType: "provider_mcp_call_started",
|
|
2549
|
+
data
|
|
2550
|
+
}];
|
|
2551
|
+
}
|
|
2552
|
+
return [];
|
|
2553
|
+
}
|
|
2554
|
+
function mcpServerName(item) {
|
|
2555
|
+
return stringField(item, "server")
|
|
2556
|
+
?? stringField(item, "server_name")
|
|
2557
|
+
?? stringField(item, "mcp_server")
|
|
2558
|
+
?? stringField(objectField(item, "mcp"), "server")
|
|
2559
|
+
?? stringField(objectField(item, "mcp"), "server_name");
|
|
2560
|
+
}
|
|
2561
|
+
function mcpToolName(item) {
|
|
2562
|
+
return stringField(item, "tool")
|
|
2563
|
+
?? stringField(item, "tool_name")
|
|
2564
|
+
?? stringField(item, "name")
|
|
2565
|
+
?? stringField(objectField(item, "function"), "name")
|
|
2566
|
+
?? stringField(objectField(item, "mcp"), "tool")
|
|
2567
|
+
?? stringField(objectField(item, "mcp"), "tool_name");
|
|
2568
|
+
}
|
|
2569
|
+
function mcpErrorSummary(item) {
|
|
2570
|
+
const direct = stringField(item, "error")
|
|
2571
|
+
?? stringField(item, "error_message")
|
|
2572
|
+
?? stringField(item, "message");
|
|
2573
|
+
if (direct) {
|
|
2574
|
+
return clip(direct, 600);
|
|
2575
|
+
}
|
|
2576
|
+
const error = objectField(item, "error");
|
|
2577
|
+
return stringField(error, "message")
|
|
2578
|
+
?? stringField(error, "summary")
|
|
2579
|
+
?? stringField(objectField(item, "result"), "error")
|
|
2580
|
+
?? null;
|
|
2581
|
+
}
|
|
2582
|
+
function safeProviderMcpData(item, serverName, toolName, status) {
|
|
2583
|
+
const elapsedMs = numericField(item, "elapsed_ms") ?? numericField(item, "duration_ms");
|
|
2584
|
+
return JSON.stringify(stripUndefined({
|
|
2585
|
+
server_name: serverName,
|
|
2586
|
+
tool_name: toolName,
|
|
2587
|
+
status,
|
|
2588
|
+
elapsed_ms: elapsedMs,
|
|
2589
|
+
error_summary: mcpErrorSummary(item)
|
|
2590
|
+
}));
|
|
2591
|
+
}
|
|
2592
|
+
function isForgeCompletionTool(toolName) {
|
|
2593
|
+
const normalized = toolName.trim().toLowerCase();
|
|
2594
|
+
return normalized.startsWith("forge.complete_")
|
|
2595
|
+
|| normalized.startsWith("complete_")
|
|
2596
|
+
|| normalized.includes("forge.complete_")
|
|
2597
|
+
|| normalized.includes("complete_architect_plan");
|
|
2598
|
+
}
|
|
1173
2599
|
function objectField(source, key) {
|
|
1174
2600
|
const value = source[key];
|
|
1175
2601
|
return value && typeof value === "object" && !Array.isArray(value)
|
|
@@ -1180,3 +2606,16 @@ function stringField(source, key) {
|
|
|
1180
2606
|
const value = source[key];
|
|
1181
2607
|
return typeof value === "string" && value.trim().length > 0 ? value : null;
|
|
1182
2608
|
}
|
|
2609
|
+
function numericField(source, key) {
|
|
2610
|
+
const value = source[key];
|
|
2611
|
+
return typeof value === "number" && Number.isFinite(value) ? value : null;
|
|
2612
|
+
}
|
|
2613
|
+
function stripUndefined(value) {
|
|
2614
|
+
return Object.fromEntries(Object.entries(value).filter(([, entry]) => entry !== undefined));
|
|
2615
|
+
}
|
|
2616
|
+
function normalizedString(value) {
|
|
2617
|
+
return value.trim().toLowerCase().replace(/-/g, "_");
|
|
2618
|
+
}
|
|
2619
|
+
function isNodeError(error) {
|
|
2620
|
+
return error instanceof Error && "code" in error;
|
|
2621
|
+
}
|